bsalomon
bd500f09ce
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ )
...
Reason for revert:
Need workaround for chrome to build
Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
> DOCS_PREVIEW= https://skia.org/?cl=1728093005
>
> Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1734043002
2016-02-25 06:52:12 -08:00
Greg Daniel
2d07b76405
Update shaderc lib and use single combined lib
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737653002
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/1737653002
2016-02-25 09:47:33 -05:00
bsalomon
57599fe6c0
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 06:33:27 -08:00
yujieqin
ddb347b63c
Add -lrt flag for ChromeOS to enable the usage of clock_gettime. Enable RawCodec for ChromeOS
...
BUG=b/26813410
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733223002
Review URL: https://codereview.chromium.org/1733223002
2016-02-25 05:42:30 -08:00
kkinnunen
45c2c8166b
Implement support for using GL ES 3.0 with command buffer
...
Adds a new 'api': --config gpu(api=commandbuffer3) for dm/nanobench.
BUG=skia:4943
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684413003
Review URL: https://codereview.chromium.org/1684413003
2016-02-25 02:03:43 -08:00
mtklein
3eed7ddb25
trim DM fat
...
- cuts out a few fringe features like logs and notes tallies
- moves vetos and blacklisting earlier so they're never really seen
- many string strength reductions, either to const SkString& or const char*
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1727363004
Review URL: https://codereview.chromium.org/1727363004
2016-02-24 19:07:07 -08:00
Brian Salomon
dcceacf574
Fix ~,! typo when clearing kRenderTarget flag
...
TBR=brucedawson@chromium.org ,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1727413004
Review URL: https://codereview.chromium.org/1727413004 .
2016-02-24 21:55:47 -05:00
mtklein
da884c49e2
DM: assert we ran as many tasks as we thought we would
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731783003
Review URL: https://codereview.chromium.org/1731783003
2016-02-24 18:00:23 -08:00
halcanary
7d57124a2a
Unit Tests: eliminate stray SkDebugf()s.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733113002
Review URL: https://codereview.chromium.org/1733113002
2016-02-24 17:59:16 -08:00
halcanary
8e9f5e39d7
SkPDF: fix scalar serialization
...
BUG=skia:4868
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720863003
Review URL: https://codereview.chromium.org/1720863003
2016-02-24 15:46:46 -08:00
brianosman
fbe355208d
Add skia.conf (configuration file that supports printShaders, etc...) to .gitignore
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734563003
Review URL: https://codereview.chromium.org/1734563003
2016-02-24 15:38:48 -08:00
fmalita
36693b5ac8
Add 4f linear gradient benches
...
Plus some more regular tiling mode variations and random cleanups.
R=reed@google.com ,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728283003
Review URL: https://codereview.chromium.org/1728283003
2016-02-24 15:32:57 -08:00
halcanary
1e440510d8
SkPDF/Bench: add bench for SkPDFSharedStream (deflate)
...
Also, simplify gyp.
BUG=skia:5009
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730833003
Review URL: https://codereview.chromium.org/1730833003
2016-02-24 15:17:20 -08:00
ericrk
f7b8b8affe
Add wrapBackendTextureAsRenderTarget API
...
Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
* wrapBackendTexture - wraps a texture into a GrTexture. Depending on
flags, this GrTexture can be converted to a GrRenderTarget. Skia
manages the render target objects it may create to provide a render
target for the texture. This allows Skia to create stencil buffers
if needed and manager MSAA resolves.
* wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
object cannot be converted to a GrTexture. Skia does not manage
the render target objects for such a GrRenderTarget, and as such
cannot attach stencil buffers or perform MSAA resolves on the
created GrRenderTarget.
Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.
While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.
To address this, a new function is created:
* wrapBackendTextureAsRenderTarget - wraps a texture into a
GrRenderTarget. As with wrapBackendTexture, the created render
target objects are fully managed by Skia. Unlike wrapBackendTexture
no GrTexture is created, and the created object will never be
textured from.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709163003
Review URL: https://codereview.chromium.org/1709163003
2016-02-24 14:49:52 -08:00
robertphillips
0cc2f85a19
Hide GrDrawTarget from GrOvalRenderer
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731413002
Review URL: https://codereview.chromium.org/1731413002
2016-02-24 13:36:56 -08:00
mtklein
afae30aeef
Rethink DM output
...
Instead of printing out each task as it finishes, or as it starts and as it finishes, periodically print out what we're up to.
Example output:
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6436/steps/dm/logs/stdio
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730943003
Review URL: https://codereview.chromium.org/1730943003
2016-02-24 12:28:32 -08:00
brianosman
ca34846584
Added a flag that forces SampleApp to continuously redraw, even in non-animated tests. Helpful when profiling or debugging.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731853003
Review URL: https://codereview.chromium.org/1731853003
2016-02-24 11:47:47 -08:00
benjaminwagner
43437c2f19
Round to nearest in ScalarTo256.
...
This is a followup to https://codereview.chromium.org/1693683002 per discussion on https://codereview.chromium.org/1691403002 .
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723483004
Review URL: https://codereview.chromium.org/1723483004
2016-02-24 10:57:47 -08:00
halcanary
1cc345f699
Documentation: sync-and-gyp design document
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/design/sync-and-gyp?cl=1736483002
Review URL: https://codereview.chromium.org/1736483002
2016-02-24 10:50:35 -08:00
benjaminwagner
f156ea3c3e
Change SkUnitScalarClampToByte to more accurate implementation.
...
The previous implementation was likely more efficient when SkScalar was SkFixed.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691403002
Review URL: https://codereview.chromium.org/1691403002
2016-02-24 10:07:52 -08:00
reed
3719886415
remove debugging printf
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725173003
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/1725173003
2016-02-24 09:32:40 -08:00
halcanary
1abea462c8
SkPDF/Bench: add bench for SkPDFCreateBitmapObject
...
BUG=skia:5009
Review URL: https://codereview.chromium.org/1729943003
2016-02-24 09:25:58 -08:00
joshualitt
b8d864902b
fixup GLPrograms textblob todo
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730253002
Review URL: https://codereview.chromium.org/1730253002
2016-02-24 09:23:03 -08:00
caryclark
d78c088b61
fix path ops fuzz bug
...
If one path is empty and the other has extreme values, the
intermediate coincident paths cannot be resolved, but triggers
an assert that a data structure unexpectedly has zero-length.
Tunnel this failure back up to the top and return that the
entire path op fails.
A future optimization could detect the empty path and avoid
this, allowing the op to succeed -- not sure that it's worth
the additional logic though.
TBR=reed@google.com
BUG=535151
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730293002
Review URL: https://codereview.chromium.org/1730293002
2016-02-24 09:03:07 -08:00
mtklein
d9381acb0e
Turn off DM --pre_log on the bots. Too spammy.
...
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734703002
Review URL: https://codereview.chromium.org/1734703002
2016-02-24 08:58:27 -08:00
jvanverth
970fd1fbea
Use ARM fixes for SDF encoding.
...
This pulls out the encoding fixes by Joel Liang from
https://codereview.chromium.org/1643143002/
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726763002
Review URL: https://codereview.chromium.org/1726763002
2016-02-24 08:33:10 -08:00
benjaminwagner
c2d35d8513
Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/1683743005/ )
...
Reason for revert:
New test is failing on Windows.
Original issue's description:
> Cleanups related to SkFixed.
>
> Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
>
> Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
>
> Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
>
> BUG=skia:4632
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
>
> Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c
TBR=mtklein@google.com ,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4632
Review URL: https://codereview.chromium.org/1724283003
2016-02-24 08:29:11 -08:00
ethannicholas
f15b07b75c
Revert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview.chromium.org/1720963002/ )
...
Reason for revert:
This is in the blamelist for Visualbench failures:
https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench/builds/1035
and seems the most likely candidate for the failure, so I am tentatively reverting.
Original issue's description:
> Include glGetMultisamplefv API
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002
>
> Committed: https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4
TBR=bsalomon@google.com ,joshualitt@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1731333002
2016-02-24 08:19:04 -08:00
reed
8516dc1016
extend xfermodes gm to include 3 custom modes
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1736523002
Review URL: https://codereview.chromium.org/1736523002
2016-02-24 08:18:42 -08:00
benjaminwagner
9d24023c66
Ensure the Gaussian tail of circle blurs goes to zero.
...
Compare blurcircle GM masked so that values <255 are white and =255 are black:
https://x20web.corp.google.com/~benjaminwagner/review/1723383002/blurcircles-lt255-before.png
https://x20web.corp.google.com/~benjaminwagner/review/1723383002/blurcircles-lt255-after.png
This is a spinoff of https://codereview.chromium.org/1691403002 , which was previously causing more "rectangles" in this GM.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723383002
Review URL: https://codereview.chromium.org/1723383002
2016-02-24 07:51:33 -08:00
benjaminwagner
7ea5cb1838
Cleanups related to SkFixed.
...
Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
Review URL: https://codereview.chromium.org/1683743005
2016-02-24 06:51:52 -08:00
reed
8f7b0b2d80
simplify/unify xferproc api
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721223002
Review URL: https://codereview.chromium.org/1721223002
2016-02-24 06:21:36 -08:00
joshualitt
cbbc9df143
Create new GM to target translations problems in GrAtlasTextContext
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721833005
Review URL: https://codereview.chromium.org/1721833005
2016-02-24 05:49:55 -08:00
fmalita
ca058f57a3
Retire SkShader::kSupports4f_Flag
...
No longer used except in one test.
Introduce kPrefers4f_Flag instead.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726983002
Review URL: https://codereview.chromium.org/1726983002
2016-02-23 19:02:20 -08:00
hcm
85a7a5fc6c
Skia schedule on skia.org
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726253002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1726253002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1726253002
2016-02-23 16:26:03 -08:00
cdalton
69c1b24bca
Include glGetMultisamplefv API
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002
Review URL: https://codereview.chromium.org/1720963002
2016-02-23 13:38:47 -08:00
fmalita
55430a6207
Update 4f linear gradient selection heuristic
...
Use the 4f context when
* dest type is 4f
* there's no perpective
Keeping the define and testing flag overrides for now.
R=reed@google.com ,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725793003
Review URL: https://codereview.chromium.org/1725793003
2016-02-23 13:26:28 -08:00
bungeman
ccb74b824a
Move SkPackBits to src/effects.
...
Prior to this change SkPackBits.h was in include/core and SkPackBits.cpp
in src/core. However, SkPackBits appears to have been written
specifically as an implementation detail of the SkTableColorFilter
effect. This change moves SkPackBits out of core and into effects, which
is the only current user.
Review URL: https://codereview.chromium.org/1722173003
2016-02-23 12:55:20 -08:00
benjaminwagner
d936f63c35
Simplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc.
...
All callers of (the result of) SkPaint::getDrawCacheProc were passing zero as the last two arguments. This is the same as (the result of) SkPaint::getMeasureCacheProc(true).
Per bungeman, make this typedef a member of SkPaint.
Although the typedef is technically public, the only uses are private, so this is not really an API change.
TBR=reed
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718423002
Review URL: https://codereview.chromium.org/1718423002
2016-02-23 10:44:32 -08:00
mtklein
246ba3a8b4
Add a handler to DM to print out what was running when we crash.
...
This is an experiment to see if we can use something like this
rather than today's extremely verbose logging.
Now, hopefully something crashes.
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725543002
Review URL: https://codereview.chromium.org/1725543002
2016-02-23 10:39:36 -08:00
caryclark
5a70bc7f3c
make transformed rrect radii fit rectangle
...
one more case caught by 1M skps
R=herb@google.com ,reed@google.com
BUG=skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722483003
Review URL: https://codereview.chromium.org/1722483003
2016-02-23 10:32:40 -08:00
msarett
9ca27f39dd
Remove unnecessary GOOGLE3 ifdefs from SkRawCodec
...
These should be fine now that SkJpegCodec is building in GOOGLE3.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718343002
Review URL: https://codereview.chromium.org/1718343002
2016-02-23 08:21:21 -08:00
msarett
fda6cea7f8
Update SK_IMAGE_VERSION to 3
...
This includes two new test wbmps (that came from clients of BitmapFactory).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722263002
Review URL: https://codereview.chromium.org/1722263002
2016-02-23 08:14:19 -08:00
bungeman
5d2cd6e074
Move SkUtils.h to src/core.
...
Review URL: https://codereview.chromium.org/1722703003
2016-02-23 07:34:25 -08:00
ethannicholas
807dcabe99
added 'visible' attribute to skiaserve JSON
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726663002
Review URL: https://codereview.chromium.org/1726663002
2016-02-23 06:53:37 -08:00
yujieqin
2d172ebb29
Use new API instead of the deprecated ones.
...
This change will allow us to remove the old API in follow up clean up.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728553002
Review URL: https://codereview.chromium.org/1728553002
2016-02-23 06:49:38 -08:00
yujieqin
cf16e67f84
Update PIEX: Prepares support for uncompressed thumbnails
...
The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate.
BUG=b/26894354
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723123002
Review URL: https://codereview.chromium.org/1723123002
2016-02-23 06:18:14 -08:00
msarett
285e7c62ed
Turn on TURBO_HAS_CROP for Android framework
...
https://buganizer.corp.google.com/u/0/issues/27290496
BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721953002
Review URL: https://codereview.chromium.org/1721953002
2016-02-23 05:48:01 -08:00
msarett
b65e604f10
Make DM failures fatal
...
We should now only be pushing Srcs for tests that we expect
to succeed. So any failures should be treated as errors.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719293002
Review URL: https://codereview.chromium.org/1719293002
2016-02-23 05:37:25 -08:00
fmalita
d0c4e092d5
Add dest type hint to SkShader::ContextRec
...
Let SkBlitter decide which dst type is optimal (PMColor vs PM4f), and
pass that info to shaders.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724503002
Review URL: https://codereview.chromium.org/1724503002
2016-02-22 17:19:04 -08:00