msarett
be8216a922
Make SkAndroidCodec support ico
...
BUG=skia:
Review URL: https://codereview.chromium.org/1472933002
2015-12-04 08:00:50 -08:00
bsalomon
ea75053c96
Speculative fix for win8 bot crash in ~GrAutoLocaleSetter
...
Review URL: https://codereview.chromium.org/1493913008
2015-12-04 07:27:36 -08:00
scroggo
97ff7f5662
Revert of Make SkAndroidCodec support ico (patchset #7 id:130002 of https://codereview.chromium.org/1472933002/ )
...
Reason for revert:
Crashing: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release/builds/1499/steps/dm/logs/stdio
Also, related ASAN failures:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3676/steps/dm/logs/stdio
Original issue's description:
> Make SkAndroidCodec support ico
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1603e9310f62cf0dd543cdb09dea06aa78373f13
TBR=djsollen@google.com ,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1498903004
2015-12-04 07:09:57 -08:00
borenet
41cbf3f807
Add android_skp_capture.py, JSON file for geniewidget
...
The script runs through the directory of JSON files, capturing SKPs from
the apps specified by the JSON files.
BUG=skia:
Review URL: https://codereview.chromium.org/1483063006
2015-12-04 06:59:31 -08:00
robertphillips
433625e67c
Reduce calls sites where both the GrDrawContext & GrRenderTarget are both passed
...
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/1494083003
2015-12-04 06:58:16 -08:00
mtklein
66cfcffd5d
simplify nanobench --quiet / -q output
...
This tries to cut things down to the very minimum you might want to know:
$ out/Release/nanobench --match nytimes --config 8888 gpu -q
Timer overhead: 29.6ns
! -> high variance, ? -> moderate variance
micros bench
2479.05 ! desk_nytimes.skp_1_mpd 8888
1313.92 desk_nytimes.skp_1_mpd gpu
3617.65 desk_nytimes.skp_1 8888
1158.34 desk_nytimes.skp_1 gpu
1368.99 ! keymobi_nytimes_com_.skp_1_mpd 8888
393.40 keymobi_nytimes_com_.skp_1_mpd gpu
1179.68 ! keymobi_nytimes_com_.skp_1 8888
342.74 keymobi_nytimes_com_.skp_1 gpu
All times are printed in microseconds, and high variance runs are marked.
BUG=skia:
Review URL: https://codereview.chromium.org/1493313003
2015-12-04 06:35:30 -08:00
msarett
1603e9310f
Make SkAndroidCodec support ico
...
BUG=skia:
Review URL: https://codereview.chromium.org/1472933002
2015-12-04 05:43:09 -08:00
kkinnunen
bbf2ce4b06
Load ANGLE EGL library correctly on Linux
...
Assign dynamically loaded ANGLE EGL library to correct variable.
BUG=skia:
Review URL: https://codereview.chromium.org/1494963002
2015-12-03 23:11:40 -08:00
kkinnunen
a18a8bca24
Skip dm GPU configs when context creation fails
...
Skip dm GPU configs when context creation fails instead of stopping
the whole dm run.
Review URL: https://codereview.chromium.org/1497713002
2015-12-03 23:04:50 -08:00
bsalomon
6dea83f244
Add option to draw wireframe batch bounds
...
Committed: https://skia.googlesource.com/skia/+/26489ef21ff5df33b8cb5943fddfd4604e203960
Review URL: https://codereview.chromium.org/1494473005
2015-12-03 12:58:06 -08:00
reed
6f2753deee
add bench for sprite-like drawing w/ imagefilters
...
visualbench run on Mac Pro
curr/maxrss loops min median mean max stddev samples config bench
96/96 MB 16 412µs 413µs 413µs 414µs 0% ▄▁█▅▅▅▅▆▅▃▅ gpu warmupbench
98/98 MB 4 1.86ms 1.86ms 1.86ms 1.86ms 0% ▁▂▇█▆▅▇▄▃▃▃ gpu image-filter-sprite-draw-image
100/100 MB 4 1.86ms 1.86ms 1.86ms 1.86ms 0% ▆▇▅▄▁▆▅█▅▄▅ gpu image-filter-sprite-draw-bitmap
100/100 MB 32 547µs 548µs 590µs 1.01ms 24% █▁▁▁▁▁▁▁▁▁▁ gpu image-filter-sprite-draw-sprite
BUG=skia:
Review URL: https://codereview.chromium.org/1497843003
2015-12-03 12:56:59 -08:00
msarett
cb0d5c940a
Add currScanline() getter to SkCodec API
...
This is more correct than using nextScanline() for the
SkGifCodec scanline decoder (since we will get a strange
result in the interlaced case) and is necessary if we want
to add scanline decoding to SkIcoCodec.
This does not actually fix bugs or change behavior.
BUG=skia:
Review URL: https://codereview.chromium.org/1489163002
2015-12-03 12:23:43 -08:00
erikchen
2b1516fe35
Update documentation for SkFontMgr methods.
...
The appropriate way to get the default system font is to pass |nullptr| as the
familyName. This was not clear from the interface, which may be why ui/gfx/ has
the wrong behavior.
BUG=chromium:564266
Review URL: https://codereview.chromium.org/1494253002
2015-12-03 12:12:13 -08:00
scroggo
e2725f5840
Revert of Add option to draw wireframe batch bounds (patchset #6 id:100001 of https://codereview.chromium.org/1494473005/ )
...
Reason for revert:
Looks to be responsible for breaking builds e.g. https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/3030/steps/dm/logs/stdio
Original issue's description:
> Add option to draw wireframe batch bounds
>
> Committed: https://skia.googlesource.com/skia/+/26489ef21ff5df33b8cb5943fddfd4604e203960
TBR=joshualitt@google.com ,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1492633007
2015-12-03 10:30:34 -08:00
scroggo
4f11b1be55
Stop disabling fixed test
...
skbug.com/1282 has been fixed, so there is no need to skip these
images
BUG=skia:1282
Review URL: https://codereview.chromium.org/1391143007
2015-12-03 09:49:02 -08:00
msarett
54ed1edda5
Match libjpeg-turbo name change in Android
...
BUG=skia:
Review URL: https://codereview.chromium.org/1464423003
2015-12-03 09:48:54 -08:00
bsalomon
26489ef21f
Add option to draw wireframe batch bounds
...
Review URL: https://codereview.chromium.org/1494473005
2015-12-03 09:36:49 -08:00
kjlubick
222b30d3a8
Make building with clang documentation a bit easier to find
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1495913002
Review URL: https://codereview.chromium.org/1495913002
2015-12-03 09:20:55 -08:00
egdaniel
7ea439b220
Create GLSLUniformHandler class for gpu backend
...
BUG=skia:
Review URL: https://codereview.chromium.org/1490283004
2015-12-03 09:20:44 -08:00
jvanverth
73063dc517
Add transfer buffer support.
...
BUG=skia:4604
Committed: https://skia.googlesource.com/skia/+/fa498fe12239988578465d0dee69f0d5645bb361
Review URL: https://codereview.chromium.org/1490473003
2015-12-03 09:15:47 -08:00
fmalita
c2e0ac4fce
Don't use the Sk4f gradient impl without SIMD
...
Also remove the SK_SUPPORT_LEGACY_LINEAR_GRADIENT_TABLE guard since it is no
longer used in Chromium.
BUG=chromium:563492
R=reed@google.com ,mtklein@google.com
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1489233005
2015-12-03 09:15:26 -08:00
egdaniel
53c5d5fb79
Revert of Add transfer buffer support. (patchset #9 id:160001 of https://codereview.chromium.org/1490473003/ )
...
Reason for revert:
speculative revert for deps roll failures
Original issue's description:
> Add transfer buffer support.
>
> BUG=skia:4604
>
> Committed: https://skia.googlesource.com/skia/+/fa498fe12239988578465d0dee69f0d5645bb361
TBR=bsalomon@google.com ,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4604
Review URL: https://codereview.chromium.org/1496843003
2015-12-03 06:32:22 -08:00
benjaminwagner
404816ee3f
Fix ODR violation.
...
src/ports/SkFontMgr_fontconfig.cpp and src/fonts/SkFontMgr_fontconfig.cpp both define SkFontMgr_fontconfig.
BUG=skia:
TBR=bungeman
Review URL: https://codereview.chromium.org/1491943004
2015-12-03 05:04:03 -08:00
reed
7850eb2f35
API to support native scaling by image-generator
...
BUG=skia:
Review URL: https://codereview.chromium.org/1396323007
2015-12-02 14:19:47 -08:00
joshualitt
dc5685ac37
Wire up resource cache stats dumping in nanobench
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1495543003
2015-12-02 14:08:25 -08:00
joshualitt
7384d07855
Wire up new define in buildbot_spec
...
BUG=skia:
Review URL: https://codereview.chromium.org/1492133002
2015-12-02 14:04:46 -08:00
joshualitt
8fd844f38e
reset shader compilations for stats
...
BUG=skia:
Review URL: https://codereview.chromium.org/1491823003
2015-12-02 13:36:47 -08:00
jvanverth
fa498fe122
Add transfer buffer support.
...
BUG=skia:4604
Review URL: https://codereview.chromium.org/1490473003
2015-12-02 13:06:37 -08:00
joshualitt
f16f88b779
Create a define for nanobench builds to dump stats
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1499453002
2015-12-02 13:00:37 -08:00
reed
0711bdbcca
drawSprite and drawImage+clip should draw the same w/ an imagefilter applied. This gm exercises that invariant.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1498523002
2015-12-02 12:58:39 -08:00
mtklein
5c05d10511
Revert of skstd -> std for unique_ptr (patchset #17 id:320001 of https://codereview.chromium.org/1436033003/ )
...
Reason for revert:
Chromium bots can't handle forward declared types, e.g.
struct Foo {
int x,y;
std::unique_ptr<Foo> next;
};
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/86497
Original issue's description:
> skstd -> std for unique_ptr
>
> TBR=reed@google.com
> No public API changes.
>
> BUG=skia:4564
>
> Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065
>
> Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
>
> Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907
TBR=bungeman@google.com ,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4564
Review URL: https://codereview.chromium.org/1498583002
2015-12-02 12:32:02 -08:00
joshualitt
3b8c0a9b7e
Add gpuStatsDump to nanobench GPU bots
...
BUG=skia:
Review URL: https://codereview.chromium.org/1497533002
2015-12-02 11:04:51 -08:00
mtklein
dadfc245cc
skstd -> std for unique_ptr
...
TBR=reed@google.com
No public API changes.
BUG=skia:4564
Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065
Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
Review URL: https://codereview.chromium.org/1436033003
2015-12-02 10:46:18 -08:00
robertphillips
954cbc15b3
Reduce use of GrRenderTarget in GrTextContexts
...
Cleanup prior to switching over to GrRenderTargetProxy.
Review URL: https://codereview.chromium.org/1485973004
2015-12-02 10:33:46 -08:00
stephana
c60b310af7
Modify iOSShell-gyp to generate unique bundle identifier
...
BUG=skia:
Review URL: https://codereview.chromium.org/1483143002
2015-12-02 09:45:30 -08:00
joshualitt
e45c81c8f3
Began logging more gpu stats from nanobench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1489033004
2015-12-02 09:05:38 -08:00
robertphillips
6ee690e1d8
Remove plumbing of clipRect thoughout the TextContexts
...
The RenderTarget was only being passed around to be able to recreate the clipRect.
Review URL: https://codereview.chromium.org/1486323002
2015-12-02 08:57:50 -08:00
msarett
7d5105c4d2
Allow SkAndroidCodec to use SkPngChunkReader
...
Also update documentation of SkPngChunkReader
in SkCodec.
BUG=skia:
Review URL: https://codereview.chromium.org/1487583003
2015-12-02 07:02:41 -08:00
herb
2e8fec7965
Revert of Simplify draw one glyph (patchset #3 id:40001 of https://codereview.chromium.org/1403573002/ )
...
Reason for revert:
This seems to break nexus 9 release.
Original issue's description:
> Replace D1G with a simpler implementation.
>
> Committed: https://skia.googlesource.com/skia/+/001e74426672e00f3f2783ccf728031662d4a358
TBR=bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1486723004
2015-12-01 14:14:17 -08:00
egdaniel
f34b293681
Add in shader blending for CoverageSetOp XP
...
BUG=skia:
Review URL: https://codereview.chromium.org/1488213002
2015-12-01 13:54:06 -08:00
robertphillips
7bceedc550
Retract GrRenderTarget a bit
...
These sites don't necessarily need the full power of a GrRenderTarget object. This is a clean up for switching over to GrRenderTargetProxys.
Review URL: https://codereview.chromium.org/1486923004
2015-12-01 12:51:26 -08:00
bungeman
c1da4d0e92
Update CMakeLists.txt to exclude SkFontConfigInterface_direct_*.
...
These files are not expected to be used by common users.
2015-12-01 14:26:28 -05:00
benjaminwagner
2211a7bdd1
Fix Google3 fonts. Use fontconfig rather than custom_directory_factory. Add Google3 font caching.
...
Some future dependents require these changes.
Depends on internal cl/108287941.
Review URL: https://codereview.chromium.org/1471033002
2015-12-01 11:12:05 -08:00
herb
001e744266
Replace D1G with a simpler implementation.
...
Review URL: https://codereview.chromium.org/1403573002
2015-12-01 09:50:04 -08:00
fmalita
aa0df4e98d
Add an SkPath conic conversion utility.
...
Expose SkConic::chopIntoQuadsPOW2() as SkPath::ConvertConicToQuads().
BUG=chromium:315277
R=reed@google.com
Review URL: https://codereview.chromium.org/1484373002
2015-12-01 09:13:23 -08:00
halcanary
0cbe7ee765
CMake, include/: changes to make fiddle 2.0 better
...
cmake: remove unused directories from skia.h / ${public_includes}
SkPreConfig.h: work around buggy `#ifdef linux`
include: guard many platform-specific headers
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1488813002
2015-12-01 09:02:49 -08:00
scroggo
9323dc6a72
Revert of Fix Android framework build (patchset #1 id:1 of https://codereview.chromium.org/1491563003/ )
...
Reason for revert:
eeebdb538d
was reverted, so this one needs to be reverted, too
Original issue's description:
> Fix Android framework build
>
> eeebdb538d
did not update a Config that
> only builds if SK_BUILD_FOR_ANDROID_FRAMEWORK. This appears to be the
> necessary parameter that is missing.
>
> BUG=skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/cb6cb21cd9d27054810d2c80ef534dcddd615d4b
TBR=bsalomon@google.com ,tomhudson@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:2992
Review URL: https://codereview.chromium.org/1487033002
2015-12-01 08:08:18 -08:00
bsalomon
a0a024e323
Revert of Make NVPR a GL context option instead of a GL context (patchset #2 id:20001 of https://codereview.chromium.org/1448883002/ )
...
Reason for revert:
BUG=skia:4609
skbug.com/4609
Seems like GrContextFactory needs to fail when the NVPR option is requested but the driver version isn't sufficiently high.
Original issue's description:
> Make NVPR a GL context option instead of a GL context
>
> Make NVPR a GL context option instead of a GL context.
> This may enable NVPR to be run with command buffer
> interface.
>
> No functionality change in DM or nanobench. NVPR can
> only be run with normal GL APIs.
>
> BUG=skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1
TBR=mtklein@google.com ,jvanverth@google.com,kkinnunen@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:2992
Review URL: https://codereview.chromium.org/1486153002
2015-12-01 07:58:44 -08:00
scroggo
cb6cb21cd9
Fix Android framework build
...
eeebdb538d
did not update a Config that
only builds if SK_BUILD_FOR_ANDROID_FRAMEWORK. This appears to be the
necessary parameter that is missing.
BUG=skia:2992
Review URL: https://codereview.chromium.org/1491563003
2015-12-01 07:53:37 -08:00
lsalzman
c19247fd03
check that SSE2 is available before using __vectorcall
...
BUG=skia:4563
Review URL: https://codereview.chromium.org/1489873002
2015-12-01 07:21:09 -08:00