joshualitt
beba90864a
Add a bit more to the python test driver
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1773263002
Review URL: https://codereview.chromium.org/1773263002
2016-03-09 14:19:38 -08:00
joshualitt
80993639df
Create explicit microhttpd.gyp
...
Review URL: https://codereview.chromium.org/1779903002
2016-03-09 14:00:52 -08:00
yujieqin
c04df21bb6
Limit the maximum buffer size of SkRawBufferedStream
...
BUG=b/27475341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1780643003
Review URL: https://codereview.chromium.org/1780643003
2016-03-09 13:49:37 -08:00
Brian Salomon
e344b26a7d
Fix Mac bots because of failing readback of 565
...
TBR=robertphillips@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784553003
Review URL: https://codereview.chromium.org/1784553003 .
2016-03-09 16:27:49 -05:00
robertphillips
08d739c036
Fix Windows clang compiler complaint
...
https://codereview.chromium.org/1740533003 ( Initialize font fallback when creating DWrite font manager) seems to have broken the clang/win builds with:
..\..\third_party\skia\src\ports\SkFontMgr_win_dw.cpp(272,11) : error: field
'fLocaleName' will be initialized after field 'fFontFallback'
[-Werror,-Wreorder]
, fLocaleName(localeNameLength)
^
1 error generated.
I have also created skbug.com/5078 (Add Windows clang bot)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784533002
Review URL: https://codereview.chromium.org/1784533002
2016-03-09 12:05:00 -08:00
bsalomon
045afea979
Add SkImage::NewTextureFromPixmap
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776913003
Review URL: https://codereview.chromium.org/1776913003
2016-03-09 11:31:18 -08:00
halcanary
7d825f8d5c
experimental: coreGraphicsPdf2png
...
motivation: used for testing on my macbook.
TBR=
Review URL: https://codereview.chromium.org/1131643004
2016-03-09 11:26:51 -08:00
halcanary
cf430139db
SkPDF/Bench becnchmark new SkPDFUtils::FloatToDecimal function.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735063004
Review URL: https://codereview.chromium.org/1735063004
2016-03-09 10:49:23 -08:00
robertphillips
e6163bf353
Switch SkPaintImageFilter over to new onFilterImage interface
...
This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761373002
Review URL: https://codereview.chromium.org/1761373002
2016-03-09 10:17:41 -08:00
bungeman
f1255953e2
Fully specify libmicrohttpd.a path in build.
...
This is more uniform and also makes things work with the cmake gyp
generator.
Review URL: https://codereview.chromium.org/1777573005
2016-03-09 10:12:06 -08:00
msarett
f7a840aaba
Remove uses SkImageDecoder in imgblur and imgslice
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777753002
Review URL: https://codereview.chromium.org/1777753002
2016-03-09 10:09:02 -08:00
joshualitt
e0449cf9f4
Fix up picture clip bounds in SkiaServe
...
BUG=skia:5067
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1781653002
Review URL: https://codereview.chromium.org/1781653002
2016-03-09 10:07:02 -08:00
jvanverth
0fcfb7525f
Fix some issues for Linux Vulkan build
...
lifecycle in GrVkGpu was tagged as uninitialized before use, and err in GrVkImage as unused.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782453004
Review URL: https://codereview.chromium.org/1782453004
2016-03-09 09:57:52 -08:00
bsalomon
5b592e8d09
Reenable dev bounds clip reduction
...
TBR=joshualitt@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1781663002
Review URL: https://codereview.chromium.org/1781663002
2016-03-09 09:55:56 -08:00
bsalomon
7467ab8cc0
Fix nullptr access in GrTextureProvider::createMipMappedTexture
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777013002
Review URL: https://codereview.chromium.org/1777013002
2016-03-09 09:52:45 -08:00
reed
2ad1aa67c6
partial switch over to sp usage of shaders
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776973003
Review URL: https://codereview.chromium.org/1776973003
2016-03-09 09:50:50 -08:00
robertphillips
7f229ed827
Revert of don't create zero length intervals (patchset #1 id:1 of https://codereview.chromium.org/1766243004/ )
...
Reason for revert:
This may, or may not, be blocking the DEPS roll with:
svg/W3C-SVG-1.1/painting-stroke-04-t.svg
- LayoutSVGPath {path} at (50,127) size 380x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"]
+ LayoutSVGPath {path} at (60,127) size 370x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"]
Original issue's description:
> don't create zero length intervals
>
> Dashing a pattern without zero-length intervals should
> not create them if the end of the on interval coincides
> with the beginning of the initial dash offset.
>
> R=reed@google.com
> BUG=591993
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766243004
>
> Committed: https://skia.googlesource.com/skia/+/18bbd00190623fb6cdb119df4a118ac3c1aed52a
TBR=reed@google.com ,fmalita@chromium.org,caryclark@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591993
Review URL: https://codereview.chromium.org/1779803002
2016-03-09 08:37:23 -08:00
halcanary
e94ea625fb
SkPDF: use sk_ref_sp
...
s/sk_sp<[^>]*>(SkRef(\([^)]*\)))/sk_ref_sp(\1)/
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777923002
Review URL: https://codereview.chromium.org/1777923002
2016-03-09 07:52:10 -08:00
bungeman
51190df040
Add SkDrawPosTextHCommand JSON, fix skiaserve build.
...
Adds SkDrawPosTextHCommand ::fromJSON and ::toJSON.
Both SkDrawPosTextCommand and SkDrawPosTextHCommand's
::toJSON write the correct number of positions, preventing reading
uninitialized memory.
The microhttpd build is now done in the build tree as opposed to in a
temporary directory.
The microhttpd build script uses os.path.join so that absolute paths
do not confuse the build. This allows compatibility with the cmake
gyp generator as CMake likes to pass absolute paths.
The microhttpd gyp target is now marked as 'none' since it is not
a 'static_library' target (which directs gyp to compile sources into
a static library). The dependencies to the action are updated to the
minimum required for sane re-building.
The everything gyp target now depends on the skiaserve gyp target.
This means that when using skia_build_server=1, building 'most' will
build skiaserve, but when skia_build_server is not defined the
skiaserve target will still be available if specified manually.
The old json.gyp is removed as it currently does not build anything.
All of the files currently referenced by it as sources no longer exist.
Review URL: https://codereview.chromium.org/1775203002
2016-03-09 07:42:54 -08:00
msarett
c3adf2fb41
Deprecate SkImageDecoder
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776153003
Review URL: https://codereview.chromium.org/1776153003
2016-03-09 07:14:41 -08:00
bsalomon
e699d0cd25
Don't allow nullptr in texels array params (unless using a transfer buffer).
...
Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765633002
Committed: https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec
Review URL: https://codereview.chromium.org/1765633002
2016-03-09 06:25:16 -08:00
msarett
790f99ae72
Remove usage of SkImageDecoder in debugger
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774313003
Review URL: https://codereview.chromium.org/1774313003
2016-03-09 06:16:55 -08:00
caryclark
18bbd00190
don't create zero length intervals
...
Dashing a pattern without zero-length intervals should
not create them if the end of the on interval coincides
with the beginning of the initial dash offset.
R=reed@google.com
BUG=591993
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766243004
Review URL: https://codereview.chromium.org/1766243004
2016-03-09 05:55:53 -08:00
robertphillips
6ac97b7eb9
Switch SkImageSource image filter over to new onFilterImage interface
...
This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772933002
Review URL: https://codereview.chromium.org/1772933002
2016-03-09 05:17:10 -08:00
reed
8a21c9fe7f
use Make instead of Create to return a shared shader
...
Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002
Review URL: https://codereview.chromium.org/1772463002
2016-03-08 18:50:00 -08:00
kulshin
042f859c19
Initialize the font fallback when the direct write font
...
manager is created.
This ensures that the fallback is initialized prior to
sandbox startup in Chromium.
This enables the use of font fallback when combined with
Chromium change https://codereview.chromium.org/1740593002/
Review URL: https://codereview.chromium.org/1740533003
2016-03-08 17:30:05 -08:00
halcanary
8103a34300
SkPDF: Add sk_sp setters; .release() becomes std::move()
...
Note to reviewers: Start with changes to SkPDFTypes.h
Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.
There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.
Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775043002
Review URL: https://codereview.chromium.org/1775043002
2016-03-08 15:10:16 -08:00
mtklein
c48fc9b1fd
Revert of nanobench: turn on f16 and sRGB on the bots (patchset #1 id:1 of https://codereview.chromium.org/1769163006/ )
...
Reason for revert:
Debug bots failing at
Running writepix_RGBA_UPM f16
../../../src/core/SkBitmap.cpp:558: fatal error: ""false && \"Can't return addr for config\"""
Original issue's description:
> nanobench: turn on f16 and sRGB on the bots
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006
>
> Committed: https://skia.googlesource.com/skia/+/6b5c5cc7b7bdffb4882706b915b544aba8714961
TBR=reed@google.com ,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1780463003
2016-03-08 13:25:42 -08:00
joshualitt
b82f088a11
Fix skiaserve in debug mode
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774263002
Review URL: https://codereview.chromium.org/1774263002
2016-03-08 13:24:33 -08:00
halcanary
51d04d3c17
Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (patchset #2 id:20001 of https://codereview.chromium.org/1775043002/ )
...
Reason for revert:
https://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/6405/steps/compile/logs/stdio
Original issue's description:
> SkPDF: Add sk_sp setters; .release() becomes std::move()
>
> Note to reviewers: Start with changes to SkPDFTypes.h
>
> Many places that had a bare pointer owning a reference are refactored to
> use a sk_sp.
>
> There remain several places where a non-owning pointer `T*` should be
> replaced with `const sk_sp<T>&` to eliminate the common pattern
> `sk_sp<T>(SkRef(x))`.
>
> Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308
TBR=bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1775143002
2016-03-08 13:03:55 -08:00
reed
647cc84748
Add sk_ref_sp helper function.
...
Review URL: https://codereview.chromium.org/1773943004
2016-03-08 12:54:48 -08:00
halcanary
9904c92120
SkPDF: Add sk_sp setters; .release() becomes std::move()
...
Note to reviewers: Start with changes to SkPDFTypes.h
Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.
There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.
Review URL: https://codereview.chromium.org/1775043002
2016-03-08 12:38:22 -08:00
mtklein
6b5c5cc7b7
nanobench: turn on f16 and sRGB on the bots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006
Review URL: https://codereview.chromium.org/1769163006
2016-03-08 12:34:11 -08:00
egdaniel
d5e3b9e1e0
Fill out more information in GrVkCaps
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768083003
Review URL: https://codereview.chromium.org/1768083003
2016-03-08 12:19:54 -08:00
brianosman
8418aacec6
Remove SkImageGeneratorUtils. None of this code is used.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778613002
Review URL: https://codereview.chromium.org/1778613002
2016-03-08 12:15:09 -08:00
jvanverth
910114a350
Buffer fix for VkProgram caching
...
When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963003
Review URL: https://codereview.chromium.org/1774963003
2016-03-08 12:09:27 -08:00
robertphillips
40736abf74
Switch SkComposeImageFilter over to new onFilterImage interface
...
This CL depends on https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768283002
Review URL: https://codereview.chromium.org/1768283002
2016-03-08 12:05:37 -08:00
bsalomon
093779c39a
Expand coverage of vertices gm
...
Review URL: https://codereview.chromium.org/1361173003
2016-03-08 11:53:31 -08:00
yujieqin
412f534563
Update DNG SDK version.
...
* Integrate integer overflow changes from security branch
BUG=b/26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004
Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567
Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754
Review URL: https://codereview.chromium.org/1748363004
2016-03-08 11:47:31 -08:00
mtklein
bb6c41b1db
add f16 and srgb --configs to nanobench
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775093002
Review URL: https://codereview.chromium.org/1775093002
2016-03-08 11:31:11 -08:00
aleksandar.stojiljkovic
88cb82246a
4377: drawVertices crashes when shader+colorfilter in the paint
...
Fix memory corruption that is result of static_casting SkFilterShaderContext*
to SkTriColorShaderContext* and then changing it's state using setup()
SkTriColorShader and it's Context could be wrapped by Compose, 3DShader and
SkFilterShader, but the link SkTriColorShaderContext -> SkTriColorShader
(fShader) always remain - so this way, data about triangle is propagated.
BUG=4377
Didn't add new unit test - it would be redundant since the GM vertices update here: https://codereview.chromium.org/1361173003/ is covering the bug. With this patch it passes.
Review URL: https://codereview.chromium.org/1431713003
2016-03-08 11:18:22 -08:00
joshualitt
810f77fb9c
Create a small python driver for skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754213005
Review URL: https://codereview.chromium.org/1754213005
2016-03-08 10:56:41 -08:00
robertphillips
ab01ccd278
Rename SkSpecialImage::getBitmap to getBitmapDeprecated
...
Review URL: https://codereview.chromium.org/1780433002
2016-03-08 10:45:32 -08:00
joshualitt
b0666ad3a9
Fix up GrAuditTrail to allow arbitrary reordering
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765123002
Review URL: https://codereview.chromium.org/1765123002
2016-03-08 10:43:42 -08:00
fmalita
d8a4f77211
Fix 4f gradient swizzle post http://crrev.com/1774523002
...
* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance
Also remove an unused Interval ctor.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1770153002
Review URL: https://codereview.chromium.org/1770153002
2016-03-08 10:20:49 -08:00
reed
93bb080503
make pm4f be RGBA always, not pmcolor order
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774523002
Review URL: https://codereview.chromium.org/1774523002
2016-03-08 10:09:18 -08:00
joshualitt
08e65e718a
Lazy init batch unique ID
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772023003
Review URL: https://codereview.chromium.org/1772023003
2016-03-08 09:31:15 -08:00
senorblanco
e6eaa320e8
Small GrTessellator refactor and cleanup.
...
Implement a VertexList, and use it.
Rename insert<> -> list_insert<>.
Rename remove<> -> list_remove<>.
Remove some spurious returns.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771373002
Review URL: https://codereview.chromium.org/1771373002
2016-03-08 09:06:44 -08:00
reed
aa5e1ae06b
work around leftshift for negative values
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963002
Review URL: https://codereview.chromium.org/1774963002
2016-03-08 09:02:24 -08:00
mtklein
c41fd9251d
DM: verbose and quiet logging
...
If you pass no flags, output is pretty much unchanged from today: calls to
info() go to the console, calls to vlog() are ignored.
If you pass --verbose and -w dir, all calls to info(), vlog() and all of stderr
are redirected to dir/verbose.log. info() calls also go to the console,
unless you pass --quiet, in which case nothing goes to the console at all.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771143002
Review URL: https://codereview.chromium.org/1771143002
2016-03-08 09:01:39 -08:00