djsollen@google.com
c1d1f414a0
Remove Bitmaps Raw Pixel Support.
...
bitmap.setPixels(...) now creates a mutable pixelRef instead
of just setting fPixels.
Review URL: https://codereview.appspot.com/6419044
git-svn-id: http://skia.googlecode.com/svn/trunk@4722 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 16:54:30 +00:00
reed@google.com
7d1941a72e
update images after gpu changes
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4721 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 15:14:18 +00:00
reed@google.com
f4cc18726b
use SkTRefArray to share readonly data between pictures
...
Review URL: https://codereview.appspot.com/6351121
git-svn-id: http://skia.googlecode.com/svn/trunk@4720 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 15:04:45 +00:00
reed@google.com
f79430350d
add protected method for internal_dispose overrides to jam fRefCnt before
...
calling destructor.
move SkTRefArray to actually inherit from SkRefCnt
Review URL: https://codereview.appspot.com/6422057
git-svn-id: http://skia.googlecode.com/svn/trunk@4719 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 14:50:38 +00:00
junov@chromium.org
8317e17448
Response to post-commit review comments on r4714
...
Correcting formatting and adding const in SkDeferredCanvas.h
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@4718 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 14:17:45 +00:00
reed@google.com
61fea88711
update images after gpu change
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4717 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 14:07:34 +00:00
reed@google.com
35e4e8f51d
removing incorrect image
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4716 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 14:07:08 +00:00
scroggo@google.com
e9617eb352
In SkWriter32::writeString, initialize all memory reserved.
...
SkFlatData compares data which is sometimes created by writeString.
Initialize all the memory in writeString so it does not compare
uninitialized memory.
See http://code.google.com/p/skia/issues/detail?id=721&thanks=721
Review URL: https://codereview.appspot.com/6428054
git-svn-id: http://skia.googlecode.com/svn/trunk@4715 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 13:44:10 +00:00
junov@chromium.org
bfeddae9da
Fix unbound memory consumption problem with run away deferred canvases.
...
With this CL, deferred canvases will trigger a flush when then the
memory allocated for recording commands (including flattened objects)
exceeds 64MB.
TEST=DeferredCanvas skia unit test, test step TestDeferredCanvasMemoryLimit
BUG=http://code.google.com/p/chromium/issues/detail?id=137884
Review URL: https://codereview.appspot.com/6425053
git-svn-id: http://skia.googlecode.com/svn/trunk@4714 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 13:35:14 +00:00
caryclark@google.com
47580694fb
shape ops work in progress
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4713 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-23 12:14:49 +00:00
reed@google.com
a276975a62
check for memory leaks in debug-build
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4712 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-22 22:33:05 +00:00
reed@google.com
ddf98a8834
use SkData to share between record and playback
...
use SkReader32 on the stack, as a step towards thread-reentrant playback
git-svn-id: http://skia.googlecode.com/svn/trunk@4711 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-21 20:31:09 +00:00
reed@google.com
0c6a736617
include <new> since we use placement-new
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4710 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-21 19:39:24 +00:00
reed@google.com
80ba7964cd
add SkTRefArray, in hopes that it will enable more sharing between pictureplaybacks
...
in different threads.
git-svn-id: http://skia.googlecode.com/svn/trunk@4709 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-21 17:31:40 +00:00
keyar@chromium.org
fdd909ca00
Added picture recording benchmark options to bench.
...
-forceRecording benchmarks how long it takes C++ code to be recorded into a picture.
-forcePictureRecording benchmarks how long it takes a picture to be recorded into a picture.
Preliminary investigation shows that the second benchmarks can often be much faster than the first. Will rerun these benchmarks and upload the results somewhere when/if this code is committed.
Review URL: https://codereview.appspot.com/6404055
git-svn-id: http://skia.googlecode.com/svn/trunk@4708 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 23:03:42 +00:00
keyar@chromium.org
472b379b5b
render_pictures can now do tiling based rendering.
...
Review URL: https://codereview.appspot.com/6401057
git-svn-id: http://skia.googlecode.com/svn/trunk@4707 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 22:34:27 +00:00
bsalomon@google.com
4f43f20c59
Add a ton of GPU baseline images.
...
Review URL: http://codereview.appspot.com/6428065/
git-svn-id: http://skia.googlecode.com/svn/trunk@4706 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 21:35:28 +00:00
epoger@google.com
fbc37297ff
whitespace change to trigger Skia buildbots after master update/restart
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4704 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 21:00:33 +00:00
rileya@google.com
03c1c359b3
Added asNewCustomStage to SkShader and implemented it for all the gradient shaders.
...
Not actually hooked up yet, but it should be ready to replace asABitmap for a future CL.
Review URL: https://codereview.appspot.com/6351113
git-svn-id: http://skia.googlecode.com/svn/trunk@4702 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 20:02:43 +00:00
tomhudson@google.com
2683a4166a
Fix build break in r4694: move reset() call before setting custom stage on sampler.
...
Over-the-shoulder review by bsalomon@.
http://codereview.appspot.com/6419061/
git-svn-id: http://skia.googlecode.com/svn/trunk@4700 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 19:15:06 +00:00
rileya@google.com
1c46d2d269
Rebaseline Nexus S gradient GMs for bilinear filtering change (r4680).
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4699 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 19:10:31 +00:00
borenet@google.com
b4e704306a
Add flag to skip pipe on select GMs
...
Confirmed with scroggo@ that these should not be run
with pipe.
Review URL: https://codereview.appspot.com/6405068
git-svn-id: http://skia.googlecode.com/svn/trunk@4698 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 18:45:10 +00:00
junov@chromium.org
8e1678ff9e
Reverting r4695
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4697 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 18:32:39 +00:00
borenet@google.com
03fc17cbf8
Disable bitmapcopy gm on Android
...
This has been failing on Nexus S. Disable so that we
don't miss further regressions.
Bug @ http://code.google.com/p/skia/issues/detail?id=705
Review URL: https://codereview.appspot.com/6427053
git-svn-id: http://skia.googlecode.com/svn/trunk@4696 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 18:19:06 +00:00
junov@chromium.org
278de8b3b3
Try turning on the SkGPipe path in SkDeferredCanvas
...
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@4695 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 18:00:59 +00:00
tomhudson@google.com
1e8f016305
Remove easily-removable uses of setTexture(), instead creating a GrSingleTextureEffect -
...
where feasible, through convenience function on GrDrawState.
http://codereview.appspot.com/6425055/
git-svn-id: http://skia.googlecode.com/svn/trunk@4694 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 16:25:18 +00:00
bsalomon@google.com
96291dfa70
Remove assertion when texture matrix is unused
...
Review URL: http://codereview.appspot.com/6420054/
git-svn-id: http://skia.googlecode.com/svn/trunk@4693 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 16:17:03 +00:00
robertphillips@google.com
80214e26c5
Made clarifying renamings to SkClipStack's iterators (and added to unit test)
...
http://codereview.appspot.com/6423051/
git-svn-id: http://skia.googlecode.com/svn/trunk@4692 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 15:33:18 +00:00
bsalomon@google.com
cbd0ad9030
Fix color filter LUT (install custom stage after reset of sampler). Over the shoulder review by TomH.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4691 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 15:09:31 +00:00
bsalomon@google.com
25f3e9bb63
Work around unused matrix uniform assertion for color filter LUT.
...
Review URL: http://codereview.appspot.com/6420054/
git-svn-id: http://skia.googlecode.com/svn/trunk@4690 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 14:23:09 +00:00
tomhudson@google.com
300f562ded
SkNEW instead of new for lighting effects.
...
http://codereview.appspot.com/6351112/
git-svn-id: http://skia.googlecode.com/svn/trunk@4689 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 14:15:22 +00:00
bsalomon@google.com
e3d3216fe1
Remove stage masks
...
Review URL: http://codereview.appspot.com/6422047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4688 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 13:37:06 +00:00
junov@chromium.org
426aebc850
Adding new steps to Canvas unit test to validate that the deferred
...
canvas state coherence test case passes with sequences of draw commands
that trigger flushes and purges of deferred draw commands.
This CL confirms that using SkGPipe fixes the deferred canvas issues that are
the root problem of crbug.com/133432
BUG=https://code.google.com/p/chromium/issues/detail?id=133432
Review URL: https://codereview.appspot.com/6416049
git-svn-id: http://skia.googlecode.com/svn/trunk@4687 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 13:21:58 +00:00
reed@google.com
73c48f1713
removing trailing ',' on last entry in enum, to fix warning
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4686 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 11:35:40 +00:00
reed@google.com
005832439e
#include "SkTemplates.h"
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4685 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 11:34:36 +00:00
reed@google.com
ca0062ee5e
add SkPaint::getPosTextPath(), with gm to test it
...
Review URL: https://codereview.appspot.com/6427055
git-svn-id: http://skia.googlecode.com/svn/trunk@4684 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 11:20:32 +00:00
twiz@google.com
4df7a16f0a
Addition of new-lines at end of files to correct Chromium builds.
...
Review URL: https://codereview.appspot.com/6423061
git-svn-id: http://skia.googlecode.com/svn/trunk@4683 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 22:09:19 +00:00
junov@chromium.org
6a0d010e2d
Fixing heap corruption issue in deferred canvas when using SkGPipe.
...
Swapping the declaration order of fPipeController and fPipeWriter to
make sure that the writer is destroyed first before the controller.
Review URL: https://codereview.appspot.com/6427054
git-svn-id: http://skia.googlecode.com/svn/trunk@4682 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 21:00:07 +00:00
rileya@google.com
585d9b1912
Rebaseline after enabling bilinear filtering for gpu linear gradients.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4681 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 20:51:32 +00:00
rileya@google.com
5ce42ca157
Make GPU linear gradients do bilinear filtering.
...
This will require GM (and webkit) rebaselines.
Review URL: https://codereview.appspot.com/6431048
git-svn-id: http://skia.googlecode.com/svn/trunk@4680 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 19:42:10 +00:00
tomhudson@google.com
aa72eab5d8
Create GL implementation for GrSingleTextureEffect, use it instead of GrPaint::setTexture()
...
or GrDrawState::setTexture() in GrContext.cpp
http://codereview.appspot.com/6399053/
git-svn-id: http://skia.googlecode.com/svn/trunk@4677 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 18:01:07 +00:00
epoger@google.com
3af4ff46a7
skdiff output: indicate which result types would cause failure
...
Review URL: https://codereview.appspot.com/6419053
git-svn-id: http://skia.googlecode.com/svn/trunk@4676 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 17:35:04 +00:00
rileya@google.com
ceaa5beb66
Rebaseline for slight changes in linear gradient behavior.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4675 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 17:31:34 +00:00
rileya@google.com
22e57f9916
New subclasses for both Gr and GrGL gradient effect classes.
...
This replaces GrSingleTextureEffect as the base for gradient effects (so we'll be able to do gradient effects without textures), and adds a base class to the GL gradient custom stage implementations (which will soon handle generating the appropriate code to pass colors in and lerp instead of using a cached texture for simpler gradient cases).
Also added a custom stage for linear gradients.
Review URL: https://codereview.appspot.com/6426049
git-svn-id: http://skia.googlecode.com/svn/trunk@4674 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 15:16:19 +00:00
borenet@google.com
d4cf366473
Rebaseline Xoom
...
Review URL: https://codereview.appspot.com/6416048
git-svn-id: http://skia.googlecode.com/svn/trunk@4672 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 14:57:19 +00:00
borenet@google.com
04bad500d4
Temporarily remove giantbitmap gpu GM baselines on Xoom
...
These are drawing black boxes.
Review URL: https://codereview.appspot.com/6423055
git-svn-id: http://skia.googlecode.com/svn/trunk@4671 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 14:12:24 +00:00
borenet@google.com
627ac0bb09
Rebaseline Nexus S images
...
These haven't been updated in a long time.
Review URL: https://codereview.appspot.com/6428051
git-svn-id: http://skia.googlecode.com/svn/trunk@4670 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 14:10:17 +00:00
chudy@google.com
ea79aba75b
Fixed glaring typo in SkDebuggerGUI.cpp, unreviewed.
...
BUG=
TEST=
Review URL: https://codereview.appspot.com/6423052
git-svn-id: http://skia.googlecode.com/svn/trunk@4669 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 13:48:14 +00:00
chudy@google.com
d3058f5fd8
Quick bug fix that was rendering debugger unusable.
...
Review URL: https://codereview.appspot.com/6422050
git-svn-id: http://skia.googlecode.com/svn/trunk@4668 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 13:41:27 +00:00
borenet@google.com
3da2a0d315
Temporarily remove giantbitmap gpu GMs on Nexus S
...
These are just drawing a black box.
Review URL: https://codereview.appspot.com/6419051
git-svn-id: http://skia.googlecode.com/svn/trunk@4667 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 13:25:27 +00:00