Commit Graph

28267 Commits

Author SHA1 Message Date
Robert Phillips
c375704a20 Revert "Convert DstTexture to DstProxy"
This reverts commit 87f7f1c3ce.

Reason for revert: grumble, grumble

Original change's description:
> Convert DstTexture to DstProxy
> 
> The last GrTexture-based TextureSampler::reset call must be removed before the TextureSamplers can become purely GrTextureProxy-backed
> 
> Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler))
> 
> Change-Id: Ic1435177d8b5d9bd3fc38b4903c9baae8205cfb0
> Reviewed-on: https://skia-review.googlesource.com/16908
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> 

TBR=egdaniel@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I9af52bb222bd2d8cc696250a9efb62afb80edba1
Reviewed-on: https://skia-review.googlesource.com/17203
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-05-17 13:00:27 +00:00
recipe-roller
a6f68d3860 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/bc4aedb9281865224a85b08442cdbee891ce2c07 Add gsubtreed builder for aosp/platform/system/core. (tandrii@chromium.org)
  https://crrev.com/050b9f74f78395ca1f5b15502e55a9534c61b4ce Log masked exception in test utils (machenbach@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I164bba8cfa50216acec82b601e7a61288ed64e7a
Reviewed-on: https://skia-review.googlesource.com/17200
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-17 12:44:46 +00:00
Robert Phillips
87f7f1c3ce Convert DstTexture to DstProxy
The last GrTexture-based TextureSampler::reset call must be removed before the TextureSamplers can become purely GrTextureProxy-backed

Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler))

Change-Id: Ic1435177d8b5d9bd3fc38b4903c9baae8205cfb0
Reviewed-on: https://skia-review.googlesource.com/16908
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-05-17 12:17:03 +00:00
Mike Reed
1314918f90 Revert "add guard for extra includes"
This reverts commit 037d78f841.

Reason for revert: did not help, will fix caller

Original change's description:
> add guard for extra includes
> 
> Bug: skia:
> Change-Id: Id500cb6ac6c2f4a925135a8e83ed4f2a07b73661
> Reviewed-on: https://skia-review.googlesource.com/17162
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
> 

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: skia:

Change-Id: I6d7dd1c51ca81a6c24604ff509b31c2171b26314
Reviewed-on: https://skia-review.googlesource.com/17163
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-17 11:40:03 +00:00
Mike Reed
a281dd37e2 remove SK_API from namespaced enum
try to fix roll

Bug: skia:
Change-Id: I3022f23486e5c077f46711de520366f3ea90ef8d
Reviewed-on: https://skia-review.googlesource.com/17161
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-17 10:23:56 +00:00
Mike Reed
037d78f841 add guard for extra includes
Bug: skia:
Change-Id: Id500cb6ac6c2f4a925135a8e83ed4f2a07b73661
Reviewed-on: https://skia-review.googlesource.com/17162
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-17 10:22:08 +00:00
recipe-roller
4b30fd8a4c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3b8a0585e3c7390a7c1c339c6b70d042de8f913c [engine] make all ad-hoc steps properly colored (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e3011f3e90f4c038bfe8e69e0e2f1738724cb18
Reviewed-on: https://skia-review.googlesource.com/17160
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-17 09:52:10 +00:00
recipe-roller
d80817921a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/632d231c826e13b02ade64d77ed2a41e25aa6fb3 [step_runner] Add a Placeholder Exception step when rendering placeholders raises a StepFailure. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iab504ed66501a140a306abfe44ed43a958162003
Reviewed-on: https://skia-review.googlesource.com/17138
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-17 08:51:33 +00:00
Jim Van Verth
9392f569cc Fix shadow_utils light position for SampleApp tiling
Change-Id: Icddc82a095aa698bdba9004641acdc411392632f
Reviewed-on: https://skia-review.googlesource.com/17044
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-05-17 02:29:39 +00:00
Matt Sarett
d5a16911bb Add support for webp lossless compression
Bug: 713862
Change-Id: I8dcc6506338f3c54fb14a78620e7daaadadfedde
Reviewed-on: https://skia-review.googlesource.com/17073
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2017-05-17 02:24:29 +00:00
Greg Daniel
1cdbdda917 Enable vulkan copies as draws for everything but qualcomm
Bug: skia:
Change-Id: I9fe2593460e2ff83ba4f9471e384f506c16544f9
Reviewed-on: https://skia-review.googlesource.com/17109
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-05-16 22:27:14 +00:00
recipe-roller
065c580824 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/88f0382b399586b171806af18ba0f88d46cf0a1e Add target_os=['fuchsia'] to fyi bot .gclient (scottmg@chromium.org)
  https://crrev.com/b9841c873eb172e8bc3522cc7c6984dad4f2e6ff Switch chromedriver and emulator recipes to devil provisioning. (jbudorick@chromium.org)
  https://crrev.com/83993d2461f62f12d0a64ffa45b4c22c15da9e04 [chromium_android] Deprecate detect_and_setup_devices. (jbudorick@chromium.org)
  https://crrev.com/0b92ca117dfab6ef5c78977c98c65803c828a5a2 Move --isolate file into the isolate root. (dnj@chromium.org)
  https://crrev.com/a1029142e5c37e0ca6ffa1c48681eea8e17c67e6 Update v8 rollers to not call pycurl (dnj@chromium.org)
depot_tools:
  https://crrev.com/7f8c775571a15f7d9dc25fb59a3361b119eec117 Revert "gclient: return non-zero exit code on unknown command" (machenbach@chromium.org)
  https://crrev.com/90e958b3b882b4d0c4457f8c86398bbde10a5208 bot_update: set fake user.{name,email} when running rebase. (tandrii@chromium.org)
  https://crrev.com/052034967a2daf32bc718aa576e0fea8ead5a0b8 Modernize gclient-new-workdir.py by using argparse (wychen@chromium.org)
  https://crrev.com/704be878162e5e0f776d77b182f4969103aa886b Add reflink support for gclient-new-workdir.py (wychen@chromium.org)
  https://crrev.com/d105249ddaa338aa8b4d090646c05102f9169f3b Don't add WATCHLIST CCs on private CLs (agable@chromium.org)
recipe_engine:
  https://crrev.com/3343170e687e1cfa402e70c6e90019f9f88f913f [package.py] prevent overriding undeclared repo dependency. (iannucci@chromium.org)
  https://crrev.com/c2d0f5d807793894df762930bc5d2729297658bf [bundle] do not include the main repo in the overrides. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I942ff7263b866b859b42cc94ec46a95bcd366335
Reviewed-on: https://skia-review.googlesource.com/17135
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 22:12:44 +00:00
Mike Klein
f45e3d78a4 try Herb's new to_srgb
This was 6-8% faster than the previous code on my Trashcan.

Change-Id: I70081009e233c83226d6d302f871fb7e86cdc438
Reviewed-on: https://skia-review.googlesource.com/16986
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-16 22:03:05 +00:00
Mike Reed
c090c647e4 move files out of private, and fix up callers to IWYU
Realized that a pending CL needed to add (yet another) private type to SkRecords.h, but w/o this CL I'd be forced to move that header also into private. This change frees us up to not have transitive exposure for types that need to be recorded.

Bug: skia:
Change-Id: Id79f1c2e44ba85e063c1360cf96c92de6397ca2b
Reviewed-on: https://skia-review.googlesource.com/17031
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-16 21:29:03 +00:00
Brian Salomon
50e66d4ab4 Remove GrRenderTargetContext::desc()
Change-Id: I04bf4a5b443f799896f62fe7aa61b6fb5d5c9c7f
Reviewed-on: https://skia-review.googlesource.com/16918
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-05-16 21:15:20 +00:00
Greg Daniel
a63e7ab3bb Require copy as draws for vulkan cross context image support
Bug: skia:
Change-Id: I0eb5039146278f88b7a869c8c19d5f84d5857529
Reviewed-on: https://skia-review.googlesource.com/17108
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-05-16 21:15:18 +00:00
Mike Klein
7e68bc93ff clamp to premul in dither
Dither can bump color values above alpha (duh), or below
zero (duh), so clamp back to premul after dithering.

BUG=skia:6644,skia:6643

Change-Id: Ida107e866380e06130af0d01467117bca929ba44
Reviewed-on: https://skia-review.googlesource.com/17070
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-16 21:10:14 +00:00
Brian Osman
0eb4ecb885 Remove Windows Intel blacklisting of cross context texture
The new version of this feature creates and destroys textures
on the same context, so shouldn't encounter the bug.

Bug: skia:
Change-Id: I5ace8fd066b0198e075a53742875554637fde553
Reviewed-on: https://skia-review.googlesource.com/17101
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-05-16 21:10:13 +00:00
Herb Derby
eb99bfd858 Move lambdas to statics.
Change-Id: I53663197de96402152c07e2ff208fd74e380b0c6
Reviewed-on: https://skia-review.googlesource.com/17061
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-16 15:04:43 +00:00
Hal Canary
23e474cb73 SkCanvas: Helpers for draw{Point,Line,Circle}
Change-Id: Ie9c7d3b8f01aee435563b23b7d27f098f07dd287
Reviewed-on: https://skia-review.googlesource.com/16909
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-16 12:59:11 +00:00
Florin Malita
03d1e59bda Add SK_LEGACY_SWEEP_GRADIENT on Android
Speculative roll fix.

Change-Id: I570c807c4f1d695fe46526a943d5376b79b358a1
Reviewed-on: https://skia-review.googlesource.com/17023
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-05-16 12:07:06 +00:00
recipe-roller
738aa4dc70 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/25c9fdc7e7213be80307a1f6712c374028deb6c4 Use service_account module in goma module (tikuta@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idca977c9451d3be62fb6c88f74aa64ed6a86be61
Reviewed-on: https://skia-review.googlesource.com/17000
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 04:25:42 +00:00
recipe-roller
daa8dae225 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/bc0fded15f08ac584403368fb9a27af8f80ed5e2 Temporarily disable LocalOutputCache (shinyak@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I20684354c6df8b466f2a63d4c683d8fe7bc09fb4
Reviewed-on: https://skia-review.googlesource.com/16999
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 03:15:17 +00:00
recipe-roller
4b3d2b48c6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/7fe83ca6ea8c7da4047d6ccd7dfd1cf76ca806f9 remove code for cleaning old goma dir (tfarina@chromium.org)
depot_tools:
  https://crrev.com/2c199e1ec4a226ccecb5282879f284965c5c9b39 gclient: return non-zero exit code on unknown command (phajdan.jr@chromium.org)
  https://crrev.com/c482674289a15e552fac358542a1b00a959bd29d Add support for hooks_os in .gclient (scottmg@chromium.org)
  https://crrev.com/8b5d230254dcd09338a4bf2c0c2a789b9afb4e44 Roll "vpython". (dnj@google.com)
  https://crrev.com/93248c5ccbaab4d3a43bc86681ff21bdbb932f6c owners: handle CLs which only have partial OWNERS (agable@chromium.org)
  https://crrev.com/e2af38e019298d7f5a2762830fdda228d8205bd9 [git retry] Fix Git wrapper fallthrough. (dnj@chromium.org)
  https://crrev.com/a3ba888db8f00dce68cbd6e36fd058ae1d471bc1 [bot_update] Remove "git retry" call. (dnj@chromium.org)
recipe_engine:
  https://crrev.com/9be63aeb7800439b172aaf2d77a156ff5d523947 [context] Fix "check_type" error. (dnj@google.com)
  https://crrev.com/b5078f1d18d40c1e8e073ca0e17c6ac382ddcb57 [test] Don't print coverage version by default. (dnj@google.com)
  https://crrev.com/def1c0f3b0bc9712e87e58031eb08e967e7ee46c [test] improve test failure message with retraining instructions. (iannucci@chromium.org)
  https://crrev.com/ea1ac7522268ac435550c701790fd1276f3e6a05 [post_process] make the check function return True if the expression is (iannucci@chromium.org)
  https://crrev.com/1a90c2644e03337ecfd91dd1e76a7c2713b42808 [platform] improve testing assertions. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I04fd38756ab61cfe32246fba81c722b624635852
Reviewed-on: https://skia-review.googlesource.com/16998
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 02:43:17 +00:00
Florin Malita
7d022e099b Always use raster pipeline for SkSweepGradient
Add an opt-in mechanism (SkShader::isRasterPipelineOnly) and switch
SkSweepGradient to always-RP.

This also repurposes the existing SK_LEGACY_SWEEP_GRADIENT guard.

Change-Id: Iabf0a701eda56f009d331120f0c987f96bd35d27
Reviewed-on: https://skia-review.googlesource.com/16912
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-05-16 02:01:03 +00:00
recipe-roller
a5da966a86 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/f1a52bdea3939b52c096b980fdda4cdd00a45577 Switch recipes over to recipe_engine "url". (dnj@google.com)
  https://crrev.com/1dad4f223eeb2f867d5e6d7c88ad6a23afb26f16 Add 3 more android perf bots to swarming (martiniss@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1241e5ec55769bc8775f4e8d58f8c2bda2a5e30b
Reviewed-on: https://skia-review.googlesource.com/16991
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 00:44:17 +00:00
recipe-roller
cdee29aa90 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5bf5ff865bea2479f2f50fd4829dd3a3d56943be Fix the PGO trybot slaves config. (sebmarchand@chromium.org)
  https://crrev.com/14341361190c01441ac69f599f9856604f879370 ios: Use checkout-relative paths. (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib6881e77f1eb18e058aad48f02880a7687d074f4
Reviewed-on: https://skia-review.googlesource.com/16990
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 00:13:17 +00:00
Mike Klein
ca2194b38e add a test that sRGB stages round trip
Change-Id: Ide8303f6fc162f3703f7db298fe210d47225a580
Reviewed-on: https://skia-review.googlesource.com/16988
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 23:57:48 +00:00
recipe-roller
f82b3cd6b5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/f522dd62d97d12f77f41793955f68bbae2d944d3 annotated_run: Flip on use_result_proto on chromium.fyi (martiniss@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9207e5b373f7632bf2bbb132e655380501c9a94d
Reviewed-on: https://skia-review.googlesource.com/16989
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 22:56:13 +00:00
recipe-roller
4399601b7d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/182e9aa84d8536bb43c28ce0c0653cc8b78d6848 [remote_run] roll recipes-py to match canary (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01cae50984a1c24118a7e6a6a9a77eee267403d1
Reviewed-on: https://skia-review.googlesource.com/16987
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 22:26:18 +00:00
recipe-roller
d43afc65b9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/3dd44c72ac7525343fe66f240897daeb0402855c Fix bug in recipe result handling logic (martiniss@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8c03ee08a2087389d54f3f32c662f374a514d1d
Reviewed-on: https://skia-review.googlesource.com/16985
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 21:55:18 +00:00
Mike Klein
8af18591ca fix windows detection in SkExecutor.cpp
defined(SK_BUILD_FOR_WIN32) is our usual way of detecting Windows.
It's basically a roundabout defined(_WIN32).

Don't know why I picked _MSC_VER here.

BUG=skia:6635

Change-Id: I8986ec12dc1cc79a1cf16abf2a1ecbc5e0447786
Reviewed-on: https://skia-review.googlesource.com/16919
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 21:47:27 +00:00
recipe-roller
25166c6637 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5ec0e7a366c2ecae11a1603aa5d91097014b34b7 Add new bots to client.boringssl. (davidben@chromium.org)
  https://crrev.com/31979e555f4e6c30109344df86232a52e73e73e3 Switch buckets for BoringSSL SDE builder. (davidben@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d867a3ead1a45f76c81a0b663a46e848420e2c5
Reviewed-on: https://skia-review.googlesource.com/16982
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 21:17:41 +00:00
Greg Daniel
5635193be2 Enable CrossContextTextureSupport on vulkan
Bug: skia:
Change-Id: I49d9c697e1749972f4f2fbc89ca47a472c986b65
Reviewed-on: https://skia-review.googlesource.com/16980
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-05-15 21:14:21 +00:00
Brian Salomon
05441c40d6 Convert GrOvalOpFactory from GrLegacyMeshDrawOp to GrMeshDrawOp using GrSimpleDrawOpHelper.
Change-Id: Ib9f59ddf1c2c3f2bd0004ae16f842e52f45df8c9
Reviewed-on: https://skia-review.googlesource.com/16832
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-05-15 21:11:41 +00:00
recipe-roller
ab1a34670e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/df3fabbcf94016a8a37b74014bb4604e55faa577 Add another slave to the PGO pool (sebmarchand@chromium.org)
  https://crrev.com/a1d4fe1c5b7eb1960420c1f2cc7d11f3442e9ab7 move goma_setup() and goma_teardown() into goma_utils.py (tfarina@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2de885899ed22916e360f2bb0cf33c491c0602cf
Reviewed-on: https://skia-review.googlesource.com/16916
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 20:48:18 +00:00
Mike Klein
fd35c742bf fix SkJumper radial gradient precision
rcp(rsqrt(x)) doesn't have enough precision when x is a coordinate.
(It's fine when x is a color, like in the softlight blend mode.)

Adds a GM to test this.  It used to look quite ugly.

Change-Id: Icec295c2e2f50ae7a5e3e33c62270f632a58f65c
Reviewed-on: https://skia-review.googlesource.com/16914
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 20:37:16 +00:00
Mike Klein
0dc6dd0a3f Add sRGB support to monobench.
We'll now run non-rendering and raster benchmarks,
for simplicity choosing sRGB as the only raster configuration.

$ ninja -C out monobench; and out/monobench "linear_clamp_(3color|pos)\$"
    gradient_linear_clamp_…
    6257  …3color 1x  …pos 1.03x

$ ninja -C out monobench; and out/monobench "linear_clamp_.*[^4][^f]\$"
    gradient_linear_clamp_…
    321  …shallow 1x  …shallow_dither 1x  …3color 1.49x  …hicolor 1.5x  …pos 1.52x

Change-Id: I7282a84c982eb1f11f0ea2dfe39afea66231761c
Reviewed-on: https://skia-review.googlesource.com/16877
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 20:24:26 +00:00
Hal Canary
cbd0f3b4e3 experimental/documentation/gerrit.md: more tricks
NOTRY=true
Change-Id: I04d371b16f7805b4c972010a5bc1eebd979169a6
Reviewed-on: https://skia-review.googlesource.com/16915
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-15 20:21:36 +00:00
Hal Canary
35a87d60e6 documentaion: consistant formatting
NOTRY=true
Change-Id: I2dd9d755242ca6c3522c465e1fa00139dda71a9d
Reviewed-on: https://skia-review.googlesource.com/16220
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-15 20:05:56 +00:00
Mike Reed
74564b40bc check for no_paint and remove some drawdrawable special-casing
Bug: skia:
Change-Id: I824980a47ddd7c8c7627dabb5efd40f8f0889b67
Reviewed-on: https://skia-review.googlesource.com/16900
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-15 19:03:11 +00:00
Jim Van Verth
4c9b893953 Allow shadow zParams to be applied to affine transformations
Change-Id: Iedfded98ce82d15945667232fde22d046d5106b3
Reviewed-on: https://skia-review.googlesource.com/16879
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2017-05-15 18:21:39 +00:00
Brian Salomon
0ec981ba49 Remove kCheckAllocation_GrSurfaceFlags.
This flags was only specified in one place (per backend). However, it was specified when no allocations occur.

Change-Id: Ic892d3064598519a07fb6773ba626fe022ef2f78
Reviewed-on: https://skia-review.googlesource.com/16904
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-05-15 18:19:49 +00:00
Greg Daniel
604b197c6b Add support for creating a shared vulkan test context
Bug: skia:
Change-Id: I997c6269e4676bf4cedddcd87e71d107053678bb
Reviewed-on: https://skia-review.googlesource.com/16905
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-05-15 18:12:59 +00:00
Chris Dalton
bca46e29e9 Convert GrMesh back to a class
Specific methods that limit the data to valid configurations are better
than a runtime mega-assert.

Bug: skia:
Change-Id: Ie15f2dc79659e44cfaddd16eb474795b110fda73
Reviewed-on: https://skia-review.googlesource.com/16577
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-05-15 18:01:59 +00:00
Robert Phillips
18e9484ad5 Rename finishOpList to finishFlush and call it less frequently
It is expected that this will fix the Vulkan perf regression associated with splitting up the opLists

Change-Id: I1bbb6f71745bb08d4a8c2f7810e5ab84cca75e84
Reviewed-on: https://skia-review.googlesource.com/16901
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-05-15 17:39:38 +00:00
Ben Wagner
bcce7ff0d7 Remove old iPadMini4 jobs.
These were replaced with RPi-based jobs in
https://skia-review.googlesource.com/c/11521/. The old jobs no longer
have any bots to run them, which is causing a lot of warnings in the
task scheduler logs.

No-Try: true
Change-Id: Iae7b8371cd80fd7ee3fbe368d5dccb0a94913f14
Reviewed-on: https://skia-review.googlesource.com/16876
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-05-15 17:18:57 +00:00
Mike Klein
c33aa9090c add unaligned_store()
Don't know why I never wrote unaligned_store() to mirror
unaligned_load(), but now I have.  This replaces all
remaining memcpy() in SkJumper_stages.cpp, which is nice.

The generated stage code didn't change.

Change-Id: I714c1072a975d7fa268a4b06c13f06557bf0c12c
Reviewed-on: https://skia-review.googlesource.com/16870
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 17:14:07 +00:00
recipe-roller
c4c4b60d55 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/a2952f1cdf2d9a080b6f9d83f921a0bfe8bed2e7 [cipd_bootstrap_v2] Roll vpython. (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97353c4714722ae23fb04435d27a5027bf2f9a99
Reviewed-on: https://skia-review.googlesource.com/16878
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 17:07:17 +00:00
Jim Van Verth
78c8f30d61 Add filled occluders to shadow_utils GM, take 2
Classifies fully visible opaque shadows differently
than transparent to avoid cache collisions.

Change-Id: Iba5aab2b2cbe08f70205c343e86fe92b0cab7497
Reviewed-on: https://skia-review.googlesource.com/16858
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2017-05-15 16:01:43 +00:00