This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b9f204be62708530b3dfe4a67d8d4010f6f9f177 Merging two TestPlaceholders with identical retcodes should work. (erikchen@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I340a54db6b13c368b5a8dc4bec108875df752589
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202191
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
9b050f846a..df35e382de
git log 9b050f846a06..df35e382de78 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 spang@chromium.org Fuchsia: Remove use of deprecated header <lib/fdio/util.h>
2019-03-19 jonahr@google.com Add Android device name, version, manufacturer to gpu_info_util
Created with:
gclient setdep -r third_party/externals/angle2@df35e382de78
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com
Change-Id: I1968b809f5e6b32c2bf3db6382ac1a5e65be249b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202183
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This reverts commit 4a20dbeaf3.
Reason for revert: layout tests suppressed.
Original change's description:
> Revert "Add small offset to t in GrLinearGradientLayout."
>
> This reverts commit 1a15723397.
>
> Reason for revert: causes two layout tests to "fail". Need to disable tests
>
> Original change's description:
> > Add small offset to t in GrLinearGradientLayout.
> >
> > This works around a varying interpolation issue when a hard stop occurs
> > a along a row or column of pixel centers.
> >
> > Bug: chromium:938592
> > Change-Id: I4c239b2831c3e901cbbfa43f0a60a3d7fb0fef75
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/200939
> > Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> > Commit-Queue: Brian Salomon <bsalomon@google.com>
>
> TBR=bsalomon@google.com,michaelludwig@google.com
>
> Change-Id: Iebe45929050b8ab1d07574518a1b3d9ac5147512
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:938592
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201655
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,michaelludwig@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:938592
Change-Id: I3020bbe2f2bddf5b933dac56f39d821681a1e070
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201617
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Camera layers introduce a top-level 3d camera/view matrix based on their
transform properties:
* position - camera location
* point of interest (stored as anchor point by BM) - camera direction
* rotation - camera orientation
The perspective degree is controlled by a "zoom" camera property (which
corresponds to the view distance), and the composition dimensions.
Current limitations:
* single camera track/layer
* affects all layers (not just 3d-tagged layers)
* parent layer transforms are likely not applied correctly
Bug: skia:
Change-Id: Ifc1b8b699ff09fa13b4804d18546b444d02e81c2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201651
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Bug: skia:
Change-Id: I840a4d12e9b7b09b64ef6c386714e813f75a86a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201613
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
This allows us to remove certain interfaces at compile time.
This replaces most (all?) of the cases where it was
if (gl) else [implicit gles] to be explicitly
if (gl) else if (gles)
in preparation for adding a WebGL standard.
For consistency, I tried to check first for GL, then for
GLES, which involved re-arranging a few if blocks.
PS 3 removes about 1.2KB (0.4 KB gzipped) from CanvasKit by
removing the GrGLInterface related checks from
GrGlInterface::validate()
PS 8 removes a total of 6.0 KB (2.6 KB gzipped) from
GrGlInterface::validate() and GrGlCaps::*
Bug: skia:8378
Change-Id: Ia91b732d888907f5d94b0eac8ca023084999fa7e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201604
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: skia:
Change-Id: I5df6735da3d574439f2ca2bcdcf01057adc95384
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201612
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This allows for testing falling into various buckets in the gpu
fallbacks.
Change-Id: Ia0c319a6bdd03c5cdece1ce83ab228c1a3a7c46d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/199420
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
and SortUsingDeclarations is too new to use
Cq-Include-Trybots: skia.primary:Housekeeper-PerCommit-CheckGeneratedFiles
Change-Id: Id785aa76c58ff354cdb820f1c74b8b2be399c341
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202115
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Change-Id: Ibbfd36d0c1e89fdbbf8e7ba36f1bf5c236ef5e0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202107
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
I just spent a bunch of time manually formatting SkScan_AAAPath.cpp so
that I could read it, a bunch of really frustrating time. So I decided
to see how clang-format would do, and with a couple of tweaks I think
I'm happy to let the tool take the wheel. It actually fixed up a few
places I missed.
Most controversial stuff is proably parameter/argument packing? I find
packing these makes it hard to distinguish which and even how many
arguments you're passing to a function... it all becomes a bit of a sea
of letters and you need to hunt for commas. This way you always see
them distinctly, and if things start to look ridiculously tall, it's
probably because the _function_ is ridiculous.
I'd have even gone as far to set AllowAllArgumentsOnNextLine: false, but
it doesn't exist yet.
Change-Id: I504dedb50f99d0d935d59e252d30f59eca451a0c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202000
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This seems to be a less surprising handling of the path renderer flags.
Right now the DDL1 bot runs w/ "pr ~small" which is magically turning CCPR back on.
Change-Id: Ibbf630653853b9d421f2bedf7ed6e2845adfbc44
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201607
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
eb986426cd..9b050f846a
git log eb986426cd6d..9b050f846a06 --date=short --no-merges --format='%ad %ae %s'
2019-03-19 jiajia.qin@intel.com Fix that 0 is a valid memory barrier
Created with:
gclient setdep -r third_party/externals/angle2@9b050f846a06
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com
Change-Id: Ic6f2edd9f03a3d744a5177ee999b0baf2ef2d2d5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202101
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/1c21d7cb523d20b7d3febb5aa9dc5798c1ffdbae [bot_update] show git protocol version (tikuta@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie93d6ae8768340cf267c9e1ef11d27114c5d16ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202073
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/c2f74c1698a8e75f9474b92dcd69c73178d240b8 Make fetch compatible with Python 3 (raul@tambre.ee)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If9bd4ee63a7df36ab4ba6cf034d5142bf899adb7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201465
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
cda4383919..eb986426cd
git log cda4383919b9..eb986426cd6d --date=short --no-merges --format='%ad %ae %s'
2019-03-18 syoussefi@chromium.org Prefix glmark2 perf results with glmark2_
2019-03-18 agrieve@chromium.org Add COMPONENT to OWNERS
2019-03-18 syoussefi@chromium.org Add missing entries in texture load functions map
2019-03-18 jonahr@google.com gl_VertexID is incorrect if offset argument to glDrawArrays is non-zero
2019-03-18 jmadill@chromium.org Add a helper script for triggering tests on swarming.
Created with:
gclient setdep -r third_party/externals/angle2@eb986426cd6d
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com
Change-Id: I009052e0b656d43f3819558b8915597ea14aaf0a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202064
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/99e0eb1d865bde251635d46fa5d8982e59937002 Enable displaying code and varmap information for if/while conditions. (gbeaty@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4af0401e80c2df801f6b7e4e2bbb85a02d99649b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202031
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/cdddd19f1b197fc56cb2219eb46663d979056bc8 Move magic_check_fn module to recipe_engine.internal.test. (gbeaty@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If42dd441e4e130c60e2c8535f119ede717771b26
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202024
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Fragment shaders typically have at least three (?) processors, and from
histogramming GMs and SKPs, the largest number is six. Even our vertex
shaders (half of all shaders being built) have one, and this code had an
off-by-one in the preallocation size: We set aside enough space for
kCode (10) elements, then immediately pushed 11 (i <= kCode).
This change should cut down on three heap allocations for every shader.
Bug: skia:
Change-Id: Iaa2a38b9ff82eb5b81935f9f1d1d96a9bc8aad90
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201463
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
These names come from the bookmaker generated md files.
Also, delete ducplicated and empty examples.
A later CL will re-name the cpp files.
Change-Id: Ie365b9cc1cc705d010c674b9988b32c8307a0455
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201609
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Bug: skia:
Change-Id: I33a65f59e1e886a2734fe2a344fceeeeabfc9124
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201983
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/2f797295a58cf5378d086f4c470675e14dea9539 windows_sdk module: yield paths to provided SDK directories (veranika@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I65f2605e8a8b9eccf78843f796a28e3540995b9d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201975
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Looks like I'm gonna have to figure out how this code works.
Before I do, restyle the code.
Change-Id: Iaa7cf7e823f1e201b216867c8d7041d742fcb910
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201970
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Everything appears to be working other than DDLOperatorEqTest, still
need to implement full mipmap support.
Bug: skia:8243
Change-Id: Ifb9e1abc850c9e6b01871a61c7bbbc5b23008037
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201981
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
This reverts commit 93b9451239.
Reason for revert: Didn't help.
Original change's description:
> Omit some SKPs that seem to cause GalaxyS9 to crash.
>
> Bug: skia:8854
> Change-Id: I7bf90ba1217ec05e60dd976a66f3b61290396767
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/200059
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,benjaminwagner@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:8854
Change-Id: I0a3603c45069f3734a6689fc5ab9db467a922ac2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201608
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
