skia2

Author	SHA1	Message	Date
reed@google.com	1a7eabc8dc	support multiple (OR'd) -match parameters git-svn-id: http://skia.googlecode.com/svn/trunk@2568 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-31 16:33:52 +00:00
reed@google.com	57c4957604	add bench for building aaclips git-svn-id: http://skia.googlecode.com/svn/trunk@2565 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-31 14:33:35 +00:00
bsalomon@google.com	4a018bb20b	Fix pure virtual call from destructor and turn VertBench back on git-svn-id: http://skia.googlecode.com/svn/trunk@2556 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-28 19:50:21 +00:00
reed@google.com	7b1ca8c66e	disable for now (brian is fixing) git-svn-id: http://skia.googlecode.com/svn/trunk@2555 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-28 19:24:58 +00:00
reed@google.com	05d63aef00	add initial bench for drawVertices git-svn-id: http://skia.googlecode.com/svn/trunk@2553 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-28 18:57:32 +00:00
tomhudson@google.com	ca529d303e	In debug builds, only run each benchmark 1 time (test for assertion-breakage, not performance). codereview.appspot.com/5314064/ git-svn-id: http://skia.googlecode.com/svn/trunk@2552 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-28 15:34:49 +00:00
tomhudson@google.com	8382394bf2	Instead of using fixed size for GPU context in benchmain, walk list of benchmarks and find the largest size required. codereview.appspot.com/5330045/ git-svn-id: http://skia.googlecode.com/svn/trunk@2551 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-28 14:59:07 +00:00
bsalomon@google.com	74913722bf	Add NULL GL context implementation. Use in bench (-nullgl) and SampleApp (backspace key) Review URL: http://codereview.appspot.com/5303080/ git-svn-id: http://skia.googlecode.com/svn/trunk@2545 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-27 20:44:19 +00:00
tomhudson@google.com	71dd3e0359	New benchmark for blitRect based on call frequency observed while scrolling Gmail inside Chrome. Is a bit slow... git-svn-id: http://skia.googlecode.com/svn/trunk@2540 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-27 13:27:20 +00:00
bsalomon@google.com	820e80ad63	Fix some warnings on VS2010 Review URL: http://codereview.appspot.com/5312051/ git-svn-id: http://skia.googlecode.com/svn/trunk@2520 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-24 21:09:40 +00:00
bungeman@google.com	c961442926	Fix wall clock in bench system timer on Windows. git-svn-id: http://skia.googlecode.com/svn/trunk@2503 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-19 22:10:21 +00:00
bsalomon@google.com	ba3664285b	Pass NULL to BenchTimer cons when gl context creation failed. git-svn-id: http://skia.googlecode.com/svn/trunk@2501 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-19 21:02:27 +00:00
bsalomon@google.com	788e247484	Fix benchmain to build w/ scalar=fixed git-svn-id: http://skia.googlecode.com/svn/trunk@2500 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-19 20:56:30 +00:00
bsalomon@google.com	373a6635b7	Virtualize SkGLContext with subclasses SkNativeGLContext and SkMesaGLContext, allow both in gm Review URL: http://codereview.appspot.com/5307045/ git-svn-id: http://skia.googlecode.com/svn/trunk@2499 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-19 20:43:20 +00:00
reed@google.com	095186a466	change text bench to measure text blit speed git-svn-id: http://skia.googlecode.com/svn/trunk@2483 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-18 12:21:50 +00:00
bsalomon@google.com	e295313f01	move utils/SkEGLContext to gpu/SkGLContext, some gpu.gyp cleanup, set eol style LF on all gpu files Review URL: http://codereview.appspot.com/5242056/ git-svn-id: http://skia.googlecode.com/svn/trunk@2474 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-13 13:33:08 +00:00
reed@google.com	e05cc8e94e	explicitly set opt level for mac-release delete obsolete FPS bench git-svn-id: http://skia.googlecode.com/svn/trunk@2442 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-10 14:19:40 +00:00
bungeman@google.com	a38c819b76	Fix two warnings in bench timers. http://codereview.appspot.com/5164049/ git-svn-id: http://skia.googlecode.com/svn/trunk@2400 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-10-03 20:44:39 +00:00
tomhudson@google.com	5ea050f662	Optimize software radial gradients (remove branches from the inner loop where we can, because an entire row is conservatively either outside or inside the gradient.) Change the gradient benchmark to capture both cases, and add new gm to detect errors in these optimized paths. git-svn-id: http://skia.googlecode.com/svn/trunk@2327 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-09-26 15:03:55 +00:00
bungeman@google.com	9399cac0a1	Change no-op math bench to noOp. http://codereview.appspot.com/4962047/ git-svn-id: http://skia.googlecode.com/svn/trunk@2206 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-08-31 19:47:59 +00:00
reed@google.com	ddc518b90f	add git-svn-id: http://skia.googlecode.com/svn/trunk@2185 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-08-29 17:49:23 +00:00
bsalomon@google.com	971d0c8049	Get rid of createRenderTargetFrom3DAPIState and associated glGets necessary to support it. Review URL: http://codereview.appspot.com/4928041/ git-svn-id: http://skia.googlecode.com/svn/trunk@2144 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-08-19 17:22:05 +00:00
epoger@google.com	3726000a28	More little improvements to bench_graph_svg.py - add ability to express revision numbers as offset from latest - add configurable title Review URL: http://codereview.appspot.com/4808081 git-svn-id: http://skia.googlecode.com/svn/trunk@2067 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-08-08 20:27:04 +00:00
epoger@google.com	c71174da7a	Incremental improvements to bench graph generation - make revision number a link to that change on code.google.com - clean up display and add help text - make revision lines show up a bit more (light yellow) Review URL: http://codereview.appspot.com/4839053 git-svn-id: http://skia.googlecode.com/svn/trunk@2062 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-08-08 17:19:23 +00:00
epoger@google.com	ec3ed6a5eb	Automatic update of all copyright notices to reflect new license terms. I have manually examined all of these diffs and restored a few files that seem to require manual adjustment. The following files still need to be modified manually, in a separate CL: android_sample/SampleApp/AndroidManifest.xml android_sample/SampleApp/res/layout/layout.xml android_sample/SampleApp/res/menu/sample.xml android_sample/SampleApp/res/values/strings.xml android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java experimental/CiCarbonSampleMain.c experimental/CocoaDebugger/main.m experimental/FileReaderApp/main.m experimental/SimpleCocoaApp/main.m experimental/iOSSampleApp/Shared/SkAlertPrompt.h experimental/iOSSampleApp/Shared/SkAlertPrompt.m experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig gpu/src/android/GrGLDefaultInterface_android.cpp gyp/common.gypi gyp_skia include/ports/SkHarfBuzzFont.h include/views/SkOSWindow_wxwidgets.h make.bat make.py src/opts/memset.arm.S src/opts/memset16_neon.S src/opts/memset32_neon.S src/opts/opts_check_arm.cpp src/ports/SkDebug_brew.cpp src/ports/SkMemory_brew.cpp src/ports/SkOSFile_brew.cpp src/ports/SkXMLParser_empty.cpp src/utils/ios/SkImageDecoder_iOS.mm src/utils/ios/SkOSFile_iOS.mm src/utils/ios/SkStream_NSData.mm tests/FillPathTest.cpp Review URL: http://codereview.appspot.com/4816058 git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-07-28 14:26:00 +00:00
reed@google.com	8c4a2db81c	fix printf output for name when skscalar is fixed git-svn-id: http://skia.googlecode.com/svn/trunk@1866 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-07-14 19:22:19 +00:00
reed@google.com	25df8884bb	add bench for building blurs git-svn-id: http://skia.googlecode.com/svn/trunk@1865 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-07-14 19:03:58 +00:00
mike@reedtribe.org	63e5e34c4e	be sure to call setupPaint, so we can respect the command-line args like alpha git-svn-id: http://skia.googlecode.com/svn/trunk@1814 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-07-07 01:17:07 +00:00
junov@google.com	4ee7ae5dcf	Adding the notion of a volatile bitmap to SkBitmap. Volatility is a hint that indicates that the contents of a bitmap are ephemeral. SkGpuDevice will not preserve volatile bitmaps in its texture cache, and will use textures from a pool of keyless (recyclable) textures to avoid the performance hit of texture allocation and release. A subsequent change is required in webkit in order to take advantage of this optimization. putImageData, and other methods that create temporary bitmaps will have to mark their bitmaps as volatile. before rendering them through skia. git-svn-id: http://skia.googlecode.com/svn/trunk@1769 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-30 17:30:49 +00:00
reed@google.com	1ca4f26039	fix warning about SkPoint initialization git-svn-id: http://skia.googlecode.com/svn/trunk@1717 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-24 19:17:37 +00:00
tomhudson@google.com	f5f83e1f7e	Fix bad merge which broke compiles. git-svn-id: http://skia.googlecode.com/svn/trunk@1716 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-24 19:15:57 +00:00
tomhudson@google.com	317d540409	New benchmark for SkMatrix::computeType(). Utility function in SkMatrix to make benchmarking more accurate. git-svn-id: http://skia.googlecode.com/svn/trunk@1710 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-24 18:30:49 +00:00
bungeman@google.com	3c1412f717	Update BenchGpuTimer.cpp to new interface. http://codereview.appspot.com/4645055/ git-svn-id: http://skia.googlecode.com/svn/trunk@1678 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-23 13:14:57 +00:00
tomhudson@google.com	6e8d335b45	New benchmark to create many random quadratic paths. Added to try to get a handle on the cost of CPU-side changes to GPU rendering, but probably too noisy to be useful. git-svn-id: http://skia.googlecode.com/svn/trunk@1674 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-22 17:16:35 +00:00
bungeman@google.com	6d0c02cc25	Fix Gradient2Bench colors so that Debug bench will run. git-svn-id: http://skia.googlecode.com/svn/trunk@1639 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-17 17:56:23 +00:00
bungeman@google.com	85669f9d77	Add graphing for multiple runs of bench. http://codereview.appspot.com/4539087/ git-svn-id: http://skia.googlecode.com/svn/trunk@1628 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-17 13:58:14 +00:00
reed@google.com	af951c9bc4	make SkDevice constructors explicit between offscreen and on/direct http://codereview.appspot.com/4632044/ git-svn-id: http://skia.googlecode.com/svn/trunk@1620 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-16 19:10:39 +00:00
reed@google.com	8ac7a0fcef	add gradient_create bench, just to measure the time to create a new gradient git-svn-id: http://skia.googlecode.com/svn/trunk@1610 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-16 13:14:19 +00:00
reed@google.com	72415161dd	add tilemode options git-svn-id: http://skia.googlecode.com/svn/trunk@1607 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-15 21:17:37 +00:00
bungeman@google.com	a5d4841424	Add information to bench output. http://codereview.appspot.com/4602057/ git-svn-id: http://skia.googlecode.com/svn/trunk@1598 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-15 17:25:46 +00:00
epoger@google.com	baa677b248	delete all old (non-Gyp) buildfiles git-svn-id: http://skia.googlecode.com/svn/trunk@1583 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-14 18:35:08 +00:00
bungeman@google.com	2080900985	Fix scale metric bench. git-svn-id: http://skia.googlecode.com/svn/trunk@1549 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-08 19:38:53 +00:00
bungeman@google.com	be9ad4e5fc	Higher resolution timers for bench. http://codereview.appspot.com/4548090/ git-svn-id: http://skia.googlecode.com/svn/trunk@1534 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-07 19:16:02 +00:00
tomhudson@google.com	288ff33d06	New benchmarks to determine performance of matrix-point multiplication for floating point vs. double matrices. Over-the-shoulder review by reed@. git-svn-id: http://skia.googlecode.com/svn/trunk@1525 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-07 14:31:38 +00:00
tomhudson@google.com	25583a3812	Make scalar benchmarks compile and run under SKIA_SCALAR=fixed as well as float. git-svn-id: http://skia.googlecode.com/svn/trunk@1516 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-06 17:55:11 +00:00
tomhudson@google.com	f910b36e45	New scalar benchmark suite, comparing SkScalarAs2sCompliment vs native float operations http://http://codereview.appspot.com/4532116/ git-svn-id: http://skia.googlecode.com/svn/trunk@1511 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-06 15:16:31 +00:00
reed@google.com	cbefd7d842	add internal multiplier for loopcount, to reduce variance for simple/fast tests git-svn-id: http://skia.googlecode.com/svn/trunk@1510 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-06 13:31:30 +00:00
reed@google.com	e0dcde7399	make concat_float distinguishable using -match init our float/double arrays, so we get reliable timings (NaNs are slow) git-svn-id: http://skia.googlecode.com/svn/trunk@1509 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-06 13:20:29 +00:00
tomhudson@google.com	a20416b010	Remove warnings, improve benchmark quality, complicate benchmark results: - data on heap instead of stack - more closely match operations of actual SkMatrix::setConcat() - avoid random perturbations, do_always; use perf annotate to verify that assembly isn't getting optimized away git-svn-id: http://skia.googlecode.com/svn/trunk@1500 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-03 20:32:58 +00:00
tomhudson@google.com	7b4e107322	<body onunload="M_unloadPage();"> <!-- Begin help window --> <script type="text/javascript"><!-- var xsrfToken = 'dd5d1a57ca1d5440593050fdc596d377'; var helpDisplayed = false; document.onclick = M_clickCommon; var media_url = "/static/"; var base_url = "/"; var publish_link = "/4571045/publish"; // --> </script> <div id="help" style="display: none;"> <div style="font-size: medium; text-align: center;">Keyboard Shortcuts</div> <hr> <table width="100%"> <tbody><tr valign="top"> <td> <table width="100%"> <tbody><tr> <td></td><th>File</th> </tr> <tr> <td class="shortcut"><span class="letter">u</span> <b>:</b></td><td>up to issue</td> </tr> <tr> <td class="shortcut"><span class="letter">m</span> <b>:</b></td><td>publish + mail comments</td> </tr> <tr> <td class="shortcut"><span class="letter">M</span> <b>:</b></td><td>edit review message</td> </tr> <tr> <td class="shortcut"><span class="letter">j</span> / <span class="letter">k</span> <b>:</b></td><td>jump to file after / before current file</td> </tr> <tr> <td class="shortcut"><span class="letter">J</span> / <span class="letter">K</span> <b>:</b></td><td>jump to next file with a comment after / before current file</td> </tr> <tr> <td></td><th>Side-by-side diff</th> </tr> <tr> <td class="shortcut"><span class="letter">i</span> <b>:</b></td><td>toggle intra-line diffs</td> </tr> <tr> <td class="shortcut"><span class="letter">e</span> <b>:</b></td><td>expand all comments</td> </tr> <tr> <td class="shortcut"><span class="letter">c</span> <b>:</b></td><td>collapse all comments</td> </tr> <tr> <td class="shortcut"><span class="letter">s</span> <b>:</b></td><td>toggle showing all comments</td> </tr> <tr> <td class="shortcut"><span class="letter">n</span> / <span class="letter">p</span> <b>:</b></td><td>next / previous diff chunk or comment</td> </tr> <tr> <td class="shortcut"><span class="letter">N</span> / <span class="letter">P</span> <b>:</b></td><td>next / previous comment</td> </tr> <tr> <td class="shortcut"><span class="letter"><Enter></span> <b>:</b></td><td>respond to / edit current comment</td> </tr> </tbody></table> </td> <td> <table width="100%"> <tbody><tr> <td></td><th>Issue</th> </tr> <tr> <td class="shortcut"><span class="letter">u</span> <b>:</b></td><td>up to list of issues</td> </tr> <tr> <td class="shortcut"><span class="letter">m</span> <b>:</b></td><td>publish + mail comments</td> </tr> <tr> <td class="shortcut"><span class="letter">j</span> / <span class="letter">k</span> <b>:</b></td><td>jump to patch after / before current patch</td> </tr> <tr> <td class="shortcut"><span class="letter">o</span> / <span class="letter"><Enter></span> <b>:</b></td><td>open current patch in side-by-side view</td> </tr> <tr> <td class="shortcut"><span class="letter">i</span> <b>:</b></td><td>open current patch in unified diff view</td> </tr> <tr><td> </td></tr> <tr><td></td><th>Issue List</th></tr> <tr> <td class="shortcut"><span class="letter">j</span> / <span class="letter">k</span> <b>:</b></td><td>jump to issue after / before current issue</td> </tr> <tr> <td class="shortcut"><span class="letter">o</span> / <span class="letter"><Enter></span> <b>:</b></td><td>open current issue</td> </tr> <tr> <td class="shortcut"><span class="letter">#</span> <b>:</b></td> <td>close issue</td> </tr> <tr><td> </td></tr> <tr> <td></td><th>Comment/message editing</th> </tr> <tr> <td class="shortcut"><span class="letter"><Ctrl></span> + <span class="letter">s</span> <b>:</b></td><td>save comment</td> </tr> <tr> <td class="shortcut"><span class="letter"><Esc></span> <b>:</b></td><td>cancel edit</td> </tr> </tbody></table> </td> </tr> </tbody></table> </div> <!-- End help window --> <div align="right"> <div style="float:left; font-weight:bold"><i>Rietveld</i> Code Review Tool</div> <b>tomhudson@google.com (TomH)</b> \| <a class="novisit" href="/settings">Settings</a> \| <a class="novisit" target="_blank" href="http://code.google.com/p/rietveld/wiki/CodeReviewHelp">Help</a> \| <a class="novisit" target="_blank" href="http://code.google.com/p/rietveld/issues/list">Bug tracker</a> \| <a class="novisit" target="_blank" href="http://groups.google.com/group/codereview-discuss">Discussion group</a> \| <a class="novisit" target="_blank" href="http://code.google.com/p/rietveld">Source code</a> \| <a class="novisit" href="http://codereview.appspot.com/_ah/logout?continue=https://www.google.com/accounts/Logout%3Fcontinue%3Dhttps://appengine.google.com/_ah/logout%253Fcontinue%253Dhttp://codereview.appspot.com/4571045/%26service%3Dah">Sign out</a> </div> <div class="counter">(691)</div> <div class="mainmenu"> <a href="/" class="active">Issues</a> <a href="/repos">Repositories</a> <a href="/search">Search</a> </div> <div class="mainmenu2"> <a href="/use_uploadpy">Create Issue</a> \| <a href="/mine">My Issues</a> \| <a href="/starred">Starred</a> \| <a href="/all">Open</a> \| <a href="/all?closed=1">All</a> </div> <div> <h2> <span id="issue-star-4571045"> <a href="javascript:M_addIssueStar(4571045)"> <img src="/static/star-dark.gif" width="15" height="15" border="0"></a> </span> <span class="issue-close" id="issue-close-4571045"> <a href="javascript:M_closeIssue(4571045)"> <img src="/static/close.gif" title="Close This Issue" width="15" height="15" border="0"></a> </span> Issue <a href="/4571045/" onmouseover="M_showPopUp(this, 'popup-issue');"> 4571045</a>: New matrix benchmarks to evaluate ::setConcat implementation options </h2> <table class="issue-details" border="0" width="100%"> <tbody><tr valign="top"> <td class="meta" width="20%"> <div> <a class="novisit" href="/4571045/edit"> Edit Issue </a> <br> <a class="novisit" href="/4571045/publish"> Publish+Mail Comments </a> ('m') <br> <a class="novisit" href="/4571045/diff/1/bench/MatrixBench.cpp"> <b>Start Review</b> </a> </div> <div class="issue_details_sidebar"> <div><b>Created:</b><br> 16 minutes ago by me </div> <div><b>Modified:</b><br> 0 minutes ago </div> <div><b>Reviewers:</b><br> <a href="/user/reed1" onmouseover="M_showUserInfoPopup(this)">reed1</a> </div> <div><b>CC:</b><br> </div> <div><b>Base URL:</b><br> http://skia.googlecode.com/svn/trunk/ </div> <div><b>Visibility:</b><br> Public. </div> </div> </td> <td style="padding-left: .8em; padding-right: .8em;" width="80%"> <h3><a id="issue-description-pointer" href="javascript:M_toggleSection('issue-description')" class="toggled-section opentriangle"> Description</a></h3> <div id="issue-description" style="margin-left:15px;"> <pre>On platforms that use Float (instead of Fixed), SkMatrix stores its internal values as floats, but setConcat() needs extra precision and so uses doubles to contain intermediate values. These three benchmarks compare the speed of float-only, double-only, and float-cast-to-double implementations of a chunk of code extracted from the non-perspective case of setConcat(). </pre> </div> <h3> <a id="ps-1-pointer" href="javascript:M_toggleSectionForPS('4571045', '1')" class="toggled-section opentriangle"> Patch Set 1 </a> </h3> <div id="ps-1" style=""> <div class="issue-list"> <div class="pagination"> <div style="float: left;"> <i>Created:</i> 16 minutes ago </div> <div style="float: right;"> <a href="/download/issue4571045_1.diff"> Download raw patch set</a> </div> <div style="clear:both;"></div> </div> <table id="queues" style="clear:both;"> <tbody><tr align="left"> <th colspan="2"></th> <th>Unified diffs</th> <th>Side-by-side diffs</th> <th>Delta from patch set</th> <th colspan="3">Stats</th> <th>Patch</th> </tr> <tr name="patch"> <td class="first" width="14"><img src="/static/closedtriangle.gif" style="" width="12" height="9"></td> <td style="white-space: nowrap">M </td> <td> <a class="noul" href="/4571045/patch/1/2"> bench/MatrixBench.cpp </a> </td> <td> <a class="noul" href="/4571045/diff/1/bench/MatrixBench.cpp"> View </a> </td> <td style="white-space: nowrap"> </td> <td style="white-space: nowrap">4 chunks</td> <td style="white-space: nowrap">+114 lines, -3 lines</td> <td style="white-space: nowrap"> 0 comments </td> <td> <a href="/download/issue4571045_1_2.diff" title="Download patch for bench/MatrixBench.cpp"> Download </a> </td> </tr> </tbody></table> </div> </div> <h3> <a id="messages-pointer" href="javascript:M_toggleSection('messages')" class="toggled-section opentriangle"> Messages </a> </h3> <div><i>Total messages: 3</i></div> <div id="messages"> <div style="margin-bottom: .5em;"> <a href="javascript:M_showAllComments('cl', 3)"> Expand All Messages</a> \| <a href="javascript:M_hideAllComments('cl', 3)"> Collapse All Messages</a> </div> <div class="message " id="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY6QcM" name="0"> <a name="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY6QcM"></a> <div class="header"> <table border="0" width="100%" cellspacing="0" cellpadding="0"> <tbody><tr class="comment_title" onclick="M_switchChangelistComment(0)"> <td style="padding-left: 5px; white-space: nowrap;"> <b>me</b> </td> <td width="100%"> <table style="table-layout:fixed; white-space: nowrap;" width="100%"> <tbody><tr> <td> <div style="white-space: nowrap; overflow: hidden;" class="extra" id="cl-preview-0"> </div> </td> </tr> </tbody></table> </td> <td align="right" style="white-space: nowrap; padding-right: 5px;"> 13 minutes ago </td> </tr> </tbody></table> </div> <div id="cl-comment-0" style="display: none;"> <div class="message-body"> <pre name="cl-message-0"></pre> </div> <div class="message-actions"> <a href="javascript:M_replyToMessage('0', '2011/06/03 18:57:35', 'TomH')" id="message-reply-href-0">Reply</a> <textarea rows="7" cols="70" name="message" style="display:none"></textarea> <div id="message-reply-0" style="display:none;"></div> </div> </div> </div> <div class="message " id="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY0Q8M" name="1"> <a name="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY0Q8M"></a> <div class="header"> <table border="0" width="100%" cellspacing="0" cellpadding="0"> <tbody><tr class="comment_title" onclick="M_switchChangelistComment(1)"> <td style="padding-left: 5px; white-space: nowrap;"> <b>reed1</b> </td> <td width="100%"> <table style="table-layout:fixed; white-space: nowrap;" width="100%"> <tbody><tr> <td> <div style="white-space: nowrap; overflow: hidden;" class="extra" id="cl-preview-1"> 1. lets remove the "fix" from the function name. just muladdmul I think 2. we ... </div> </td> </tr> </tbody></table> </td> <td align="right" style="white-space: nowrap; padding-right: 5px;"> 10 minutes ago </td> </tr> </tbody></table> </div> <div id="cl-comment-1" style="display: none;"> <div class="message-body"> <pre name="cl-message-1">1. lets remove the "fix" from the function name. just muladdmul I think 2. we can remove the return, since it will be compiled away anyway 3. nice checkin comment! 4. what are the results like?</pre> </div> <div class="message-actions"> <a href="javascript:M_replyToMessage('1', '2011/06/03 19:00:39', 'reed1')" id="message-reply-href-1">Reply</a> <textarea rows="7" cols="70" name="message" style="display:none"></textarea> <div id="message-reply-1" style="display:none;"></div> </div> </div> </div> <div class="message " id="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UYuRcM" name="2"> <a name="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UYuRcM"></a> <div class="header"> <table border="0" width="100%" cellspacing="0" cellpadding="0"> <tbody><tr class="comment_title" onclick="M_switchChangelistComment(2)"> <td style="padding-left: 5px; white-space: nowrap;"> <b>me</b> </td> <td width="100%"> <table style="table-layout:fixed; white-space: nowrap;" width="100%"> <tbody><tr> <td> <div style="white-space: nowrap; overflow: hidden; visibility: hidden;" class="extra" id="cl-preview-2"> > 4. what are the results like? For posterity: tomhudson@tomhudson-zx600-linux:/usr/local/google/src/skia3$ out/bench/bench -match matrix_concat -repeat 1000 ... </div> </td> </tr> </tbody></table> </td> <td align="right" style="white-space: nowrap; padding-right: 5px;"> 0 minutes ago </td> </tr> </tbody></table> </div> <div id="cl-comment-2"> <div class="message-body"> <pre name="cl-message-2">> 4. what are the results like? For posterity: tomhudson@tomhudson-zx600-linux:/usr/local/google/src/skia3$ out/bench/bench -match matrix_concat -repeat 1000 skia bench: alpha=0xFF antialias=1 filter=0 running bench [640 480] matrix_concat_double 8888: msecs = 0.79 565: msecs = 0.79 GPU: msecs = 0.79 running bench [640 480] matrix_concat_floatdouble 8888: msecs = 0.97 565: msecs = 0.97 GPU: msecs = 0.97 running bench [640 480] matrix_concat_float 8888: msecs = 0.74 565: msecs = 0.73 GPU: msecs = 0.74</pre> </div> <div class="message-actions"> <a href="javascript:M_replyToMessage('2', '2011/06/03 19:11:06', 'TomH')" id="message-reply-href-2">Reply</a> <textarea rows="7" cols="70" name="message" style="display:none"></textarea> <div id="message-reply-2" style="display:none;"></div> </div> </div> </div> <div> <a href="javascript:M_showAllComments('cl', 3)"> Expand All Messages</a> \| <a href="javascript:M_hideAllComments('cl', 3)"> Collapse All Messages</a> </div> </div> <script language="JavaScript" type="text/javascript"> <!-- document.onkeydown = M_changelistKeyDown; var dashboardState = new M_DashboardState(window, 'patch', 'M_CLPatchMarker'); M_switchChangelistCommentByAnchor(); // --> </script> <div style="display:none;"> <form method="POST" action="/4571045/publish" id="message-reply-form"> <input type="hidden" name="xsrf_token" value="dd5d1a57ca1d5440593050fdc596d377"> <div></div> <input type="hidden" name="subject" value="New matrix benchmarks to evaluate ::setConcat implementation options"> <input type="hidden" name="message_only" value="1"> <input type="submit" value="Send Message"> <input type="button" value="Discard" name="discard"> <input type="checkbox" name="send_mail" value="1" id="message-reply-send-mail" checked="checked"> <label>Send mail to reviewers</label> </form> </div> <a id="resizer" class="resizer" style="display:none;cursor:pointer"> <img src="/static/zippyplus.gif"> </a> </td> </tr> </tbody></table> </div> <div class="popup" id="popup-issue" style="left: 104px; top: 116px; visibility: hidden; "> <b>Issue 4571045: New matrix benchmarks to evaluate ::setConcat implementation options </b><br> Created 16 minutes ago by me<br> Modified 0 minutes ago<br> Reviewers: reed1<br> Base URL: http://skia.googlecode.com/svn/trunk/<br> Comments: 0 </div> <p></p> <div style="float: left;"> <a target="_blank" href="http://code.google.com/appengine/"><img border="0" src="/static/appengine-noborder-120x30.gif" alt="Powered by Google App Engine"></a> </div> <div class="extra" style="font-size: 9pt; float: right; text-align: right;"> <div style="height:14px;"> <img src="/static/rss.gif" alt="RSS Feeds" width="14" height="14" align="top"> <a href="/rss/all">Recent Issues</a> \| <a href="/rss/mine/TomH">My Issues</a> \| <a href="/rss/reviews/TomH">My Reviews</a> \| <a href="/rss/closed/TomH">My Closed</a> \| <a href="/rss/issue/4571045">This issue</a> </div> <div style="margin-top: .3em;">This is Rietveld <a href="http://code.google.com/p/rietveld/updates/list">r756 </a></div> </div> <script type="text/javascript"> var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www."); document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E")); </script><script src="http://www.google-analytics.com/ga.js" type="text/javascript"></script> <script type="text/javascript"> var pageTracker = _gat._getTracker("UA-4803694-4"); pageTracker._initData(); pageTracker._trackPageview(); </script> On platforms that use Float (instead of Fixed), SkMatrix stores its internal values as floats, but setConcat() needs extra precision and so uses doubles to contain intermediate values. These three benchmarks compare the speed of float-only, double-only, and float-cast-to-double implementations of a chunk of code extracted from the non-perspective case of setConcat(). git-svn-id: http://skia.googlecode.com/svn/trunk@1497 2bbb7eff-a529-9590-31e7-b0007b416f81	2011-06-03 19:16:56 +00:00

1 2

94 Commits