reed@google.com
c75c36a14b
revert 5578 -- broke pipe
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5579 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 13:20:52 +00:00
reed@google.com
f1ab723033
Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This
...
allows the client more control over the scaling. Because of virtual overrides
and wanting to keep the old call-sites up and running, this CL renames the
virtual entry-point to drawBitmapRectToRect, and downgrades drawBitmapRect to
a non-virtual helper function.
The implementation is to use the float-rect for computing the matrix, but still
cons-up an integer rect for the purposes of subsetting the original bitmap. We
do this by calling float_src->roundOut(&int_src) so that we include all
(partially) covered src pixels.
No change needed on SkDevice, since that signature is explicitly passed the
computed matrix.
Review URL: https://codereview.appspot.com/6501140
git-svn-id: http://skia.googlecode.com/svn/trunk@5578 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 12:59:44 +00:00
skia.committer@gmail.com
54339a826e
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5577 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 02:01:09 +00:00
tfarina@chromium.org
b1b7f70790
Add a header for OverView.cpp as well.
...
This fixes another FIXMEs.
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://codereview.appspot.com/6492125
git-svn-id: http://skia.googlecode.com/svn/trunk@5576 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 01:52:20 +00:00
borenet@google.com
13fd5a15a1
Set DEFAULT_REPEATS to 1
...
bench defaults to 1 repeat, so bench_pictures should do the same.
This is causing the Android build cycles to be *hours* long.
Review URL: https://codereview.appspot.com/6490123
git-svn-id: http://skia.googlecode.com/svn/trunk@5575 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 21:10:05 +00:00
borenet@google.com
66bcbd12bf
Check for invalid SkPictures
...
- Remove hasRecorded() since nobody uses it.
- Add "success" boolean to SkPicture stream constructor
- Track failures in render_pictures and bench_pictures
Review URL: https://codereview.appspot.com/6493105
git-svn-id: http://skia.googlecode.com/svn/trunk@5573 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 18:26:06 +00:00
bsalomon@google.com
7534747e63
Add GrColor to RGBA float helper func
...
Review URL: https://codereview.appspot.com/6518044/
git-svn-id: http://skia.googlecode.com/svn/trunk@5572 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 17:23:21 +00:00
bungeman@google.com
0729b62373
Fix a Ref count bug in SkFontHost_win_dw.cpp
...
https://codereview.appspot.com/6495133
Props tinytail.
git-svn-id: http://skia.googlecode.com/svn/trunk@5568 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 14:25:42 +00:00
robertphillips@google.com
f92cfcf362
Fixed unused variable compiler complaint
...
http://codereview.appspot.com/6496129/
git-svn-id: http://skia.googlecode.com/svn/trunk@5567 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 13:38:57 +00:00
robertphillips@google.com
31f8f73e83
Fixed valgrind complaint in MatrixBench
...
https://codereview.appspot.com/6492129/
git-svn-id: http://skia.googlecode.com/svn/trunk@5566 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 13:36:47 +00:00
robertphillips@google.com
968c17ddda
fixed compiler complaints
...
http://codereview.appspot.com/6499124/
git-svn-id: http://skia.googlecode.com/svn/trunk@5565 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 12:05:40 +00:00
robertphillips@google.com
bf3ef28f3b
Fixed memory leak in deferred_canvas_record bench
...
http://codereview.appspot.com/6499123/
git-svn-id: http://skia.googlecode.com/svn/trunk@5564 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 11:52:48 +00:00
robertphillips@google.com
433ce5e686
Made more benchs non-rendering
...
http://codereview.appspot.com/6498132/
git-svn-id: http://skia.googlecode.com/svn/trunk@5562 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 10:49:30 +00:00
skia.committer@gmail.com
055c7c299c
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5561 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-15 02:01:41 +00:00
bsalomon@google.com
6c5418e6c2
Temporarily revert r5433 due to http://www.crbug.com/148637 until after M23 branch.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5557 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 20:30:37 +00:00
reed@google.com
6132eb9607
speculative fix for crbug.com/147406 -- disabling save/clip/restore peephole
...
optimization, to see if it reduces crash rates.
git-svn-id: http://skia.googlecode.com/svn/trunk@5556 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 19:07:28 +00:00
rileya@google.com
a9baf11e13
Double size of buffer for SkString::printf()
...
Review URL: https://codereview.appspot.com/6503120
git-svn-id: http://skia.googlecode.com/svn/trunk@5555 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 19:03:42 +00:00
epoger@google.com
cbc4a5d96c
Add file I forgot in https://code.google.com/p/skia/source/detail?r=5552
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5554 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 18:52:10 +00:00
epoger@google.com
37711e1f99
Update expected bench results for picture_playback_drawText_GPU_c
...
to fix http://code.google.com/p/skia/issues/detail?id=877
git-svn-id: http://skia.googlecode.com/svn/trunk@5553 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 18:47:13 +00:00
epoger@google.com
6a12178fb3
Add a header file for TransitionView.cpp
...
committed from https://codereview.appspot.com/6492119/ for Thiago Farina <tfarina@chromium.org>
git-svn-id: http://skia.googlecode.com/svn/trunk@5552 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 18:42:01 +00:00
scroggo@google.com
39362527e9
Turn serialization back on in GM.
...
With https://codereview.appspot.com/6503106/ it is now safe to do
serialization by default.
Review URL: https://codereview.appspot.com/6498121
git-svn-id: http://skia.googlecode.com/svn/trunk@5551 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 17:37:46 +00:00
scroggo@google.com
d614c6a4e0
For a picture playback with nothing written, use an empty SkData.
...
This prevents crashing when attempting to access fOpData.
BUG=https://code.google.com/p/skia/issues/detail?id=870
Review URL: https://codereview.appspot.com/6499108
git-svn-id: http://skia.googlecode.com/svn/trunk@5550 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 17:26:37 +00:00
reed@google.com
9548be3bad
landing https://codereview.appspot.com/6506117
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5549 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 16:00:01 +00:00
rileya@google.com
1c6307e36f
Fix some nits from http://codereview.appspot.com/6506103/
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5547 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 15:52:47 +00:00
borenet@google.com
3a8b0d8288
Scale even smaller in bench_pictures to get things green
...
Over-the-shoulder review from reed@
Review URL: https://codereview.appspot.com/6512043
git-svn-id: http://skia.googlecode.com/svn/trunk@5545 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 15:27:41 +00:00
reed@google.com
8cae8358f7
fix fragile cubic stepper, where we want to assert that each tesselated segment
...
is monotonically going down, but the finite math we use cannot ensure that...
so we explicitly pin the y-value after it is calculated.
add unittest that exercises the bug/assert that was found on an SVG site
git-svn-id: http://skia.googlecode.com/svn/trunk@5544 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 15:18:41 +00:00
borenet@google.com
e21795e277
Enable automatic rescaling in bench_pictures
...
bench_pictures with "--device gpu" is failing because we're trying to allocate
too much GPU memory. Move the recently-added scaling code into picture_utils
and share it between render_pictures and bench_pictures.
Review URL: https://codereview.appspot.com/6495125
git-svn-id: http://skia.googlecode.com/svn/trunk@5543 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 14:34:28 +00:00
rileya@google.com
71e21ba2af
Fix picture refcnt bug in distantclip gm. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5542 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 14:24:14 +00:00
caryclark@google.com
235f56a92f
shape ops work in progress
...
add quartic solution for intersecting quadratics
git-svn-id: http://skia.googlecode.com/svn/trunk@5541 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 14:19:30 +00:00
rileya@google.com
ffadfb5d43
Add gm to test SkRegion/clipPath bug.
...
Review URL: https://codereview.appspot.com/6501131
git-svn-id: http://skia.googlecode.com/svn/trunk@5540 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 13:53:36 +00:00
skia.committer@gmail.com
1d225f2b33
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5539 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 02:01:10 +00:00
rileya@google.com
90f2d07d34
Fix for gcc compile error. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5538 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 21:47:48 +00:00
rileya@google.com
8515e79a76
Add R-Tree record flag to SkPicture, plus some cleanup/fixes in associated classes.
...
Review URL: https://codereview.appspot.com/6506103
git-svn-id: http://skia.googlecode.com/svn/trunk@5537 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 21:41:51 +00:00
bensong@google.com
ad0c5d248c
Adds bench expectation file and mechanism for triggering bench-out-of-range alerts from bench_graph_svg.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5536 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 21:08:52 +00:00
borenet@google.com
a49bffdb03
Do not exit on failure to open logFile
...
Temporary solution for write-protected Android devices. Intention is to revert
in favor of a more permanent solution.
Review URL: https://codereview.appspot.com/6497132
git-svn-id: http://skia.googlecode.com/svn/trunk@5535 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 18:54:48 +00:00
george@mozilla.com
ca0ec4c65a
Check if SK_BUILD_FOR_MAC is defined rather than whether it's 1
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5532 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 17:55:34 +00:00
reed@google.com
e04e92b19f
To avoid running out of memory, we rescale very large pictures before we
...
render them.
Review URL: https://codereview.appspot.com/6504045
git-svn-id: http://skia.googlecode.com/svn/trunk@5530 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 17:44:32 +00:00
robertphillips@google.com
83187a2737
Make all random path benchs non-rendering
...
https://codereview.appspot.com/6490111/
git-svn-id: http://skia.googlecode.com/svn/trunk@5527 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 16:39:08 +00:00
tomhudson@google.com
9dc2713fc4
Let SkBenchmark classes specify that they do no rendering.
...
Doing this gives us a 15-20% speedup in bench cycle time.
Here again I'm just picking the easy targets.
http://codereview.appspot.com/6500115/
git-svn-id: http://skia.googlecode.com/svn/trunk@5525 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 15:50:24 +00:00
tomhudson@google.com
fc15722a21
Turn down repeat count on ref counting and memory pool benches.
...
No reason these things need to run for 10s of ms.
http://codereview.appspot.com/6501122/
git-svn-id: http://skia.googlecode.com/svn/trunk@5524 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 15:42:33 +00:00
robertphillips@google.com
163c84ba50
Added GPU resource cache stats printing to render_pictures
...
https://codereview.appspot.com/6492104/
git-svn-id: http://skia.googlecode.com/svn/trunk@5523 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 15:40:37 +00:00
scroggo@google.com
69fbc52e95
Keep the entries in .gitignore sorted in alphabetical order.
...
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://codereview.appspot.com/6506107
git-svn-id: http://skia.googlecode.com/svn/trunk@5522 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 15:26:51 +00:00
borenet@google.com
e33073bac8
Revert r5520
...
Unfortunately, since we can only build ANGLE by including a gypi, and since
gyp cannot process includes conditionally, we *have* to have a build_angle.gypi
file in the third_party/externals/ANGLE/src directory. We could do a hack
where we create an empty gypi if ANGLE is not checked out, but for now we just
check out ANGLE on all platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@5521 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 14:53:15 +00:00
borenet@google.com
45bfcbcfba
Only check out ANGLE on Windows
...
Review URL: https://codereview.appspot.com/6500118
git-svn-id: http://skia.googlecode.com/svn/trunk@5520 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 14:38:04 +00:00
robertphillips@google.com
9d59420851
Added GPU resource cache stats printing to bench & removed some noise from inst counting information
...
https://codereview.appspot.com/6497125/
git-svn-id: http://skia.googlecode.com/svn/trunk@5519 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 14:05:00 +00:00
robertphillips@google.com
178a267a6c
Address warnings from clang build bot
...
http://codereview.appspot.com/6506111/
git-svn-id: http://skia.googlecode.com/svn/trunk@5518 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 13:25:30 +00:00
reed@google.com
1f1543f012
re-apply 5508, but with the new compile-flag disabled for now
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5516 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-12 21:08:33 +00:00
bungeman@google.com
752acc765f
Provide labels for variant settings in bench graph.
...
https://codereview.appspot.com/6494118/
git-svn-id: http://skia.googlecode.com/svn/trunk@5515 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-12 19:34:17 +00:00
scroggo@google.com
4cea9f41d1
Use double dashes for bench options to be consistent.
...
Breaks the bots, since the arguments being passed to bench have changed, but there is a change to fix it at https://codereview.appspot.com/6488114/
Review URL: https://codereview.appspot.com/6500108
git-svn-id: http://skia.googlecode.com/svn/trunk@5513 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-12 19:27:11 +00:00
scroggo@google.com
d8a6cc814f
Make texteffects gm work through serialization and pipe.
...
Move Line2DPathEffect (now Sk_) into a separate header file so it can
be shared and initialized.
Switch to the shared version in SampleAll and SampleSlides.
Remove the skip pipe flag from texteffects, since it can now be serialized.
I have a separate change to turn serialization on by default at https://codereview.appspot.com/6498121/
Review URL: https://codereview.appspot.com/6503106
git-svn-id: http://skia.googlecode.com/svn/trunk@5512 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-12 18:53:49 +00:00