Commit Graph

10337 Commits

Author SHA1 Message Date
robertphillips@google.com
01a2f1cbad Revert r12758 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2) - https://codereview.chromium.org/118533003) due to Chromium-side compilation issues
git-svn-id: http://skia.googlecode.com/svn/trunk@12762 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 23:56:59 +00:00
vandebo@chromium.org
7e5d24c22e Update expectations for r12729
"[PDF] Fix clipping in xfermode improvement."

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/112343007

git-svn-id: http://skia.googlecode.com/svn/trunk@12761 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 22:20:16 +00:00
tfarina@chromium.org
9f9d5829c2 Get rid of DEFINE_TESTCLASS() macro.
Remaining tests were rewrite to use DEF_TEST() macro instead. This fixes
the FIXME in TestClassDef.h

BUG=None
TEST=tests
R=mtklein@google.com

Review URL: https://codereview.chromium.org/114563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12760 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 22:15:12 +00:00
commit-bot@chromium.org
9cfa287bc7 Remove SkBitmapAlphaThresholdShader
R=bsalomon@google.com

Author: zork@chromium.org

Review URL: https://codereview.chromium.org/108653012

git-svn-id: http://skia.googlecode.com/svn/trunk@12759 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 21:58:53 +00:00
commit-bot@chromium.org
0ef335ac81 Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2)
Requires changes from https://codereview.chromium.org/99053007/ before this can be rolled in Chromium DEPS. If this begins breaking the build due to an early roll, please contact bajones@chromium.org before reverting.

BUG=326382
R=bsalomon@chromium.org
TBR=bsalomon@chromium.org

Author: bajones@chromium.org

Review URL: https://codereview.chromium.org/118533003

git-svn-id: http://skia.googlecode.com/svn/trunk@12758 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 21:09:21 +00:00
commit-bot@chromium.org
98000efa59 Android now uses Harfbuzz-NG. No need to keep code specific to the old version of Harfbuzz around!
R=scroggo@google.com, reed@google.com, bungeman@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/107663012

git-svn-id: http://skia.googlecode.com/svn/trunk@12756 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 19:49:27 +00:00
commit-bot@chromium.org
7af78e0d6a fix off-by-one error with rotated HQ scaling
BUG=
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/118193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12755 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 19:47:57 +00:00
robertphillips@google.com
087b313939 Add cast to fix Win* compile complaint/failure
https://codereview.chromium.org/100313005/



git-svn-id: http://skia.googlecode.com/svn/trunk@12750 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 19:00:47 +00:00
robertphillips@google.com
5db04dfad7 Address memory leak in SkScaledImageCache
https://codereview.chromium.org/107443009/



git-svn-id: http://skia.googlecode.com/svn/trunk@12749 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 18:48:08 +00:00
commit-bot@chromium.org
1ad518bf38 Revert of https://codereview.chromium.org/93703004/
Reason for revert: Test failures

R=scroggo@google.com, djsollen@google.com, reed@google.com, halcanary@google.com
TBR=djsollen@google.com, halcanary@google.com, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/103753007

git-svn-id: http://skia.googlecode.com/svn/trunk@12747 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 18:33:15 +00:00
commit-bot@chromium.org
1cd71fb013 Expose more SkPaint fields in Lua API.
Adds getters (but not setters) for most SkPaint fields.

R=reed@google.com, robertphillips@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/105143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12746 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 18:28:07 +00:00
halcanary@google.com
d665dc4c10 Add Options to SkDecodingImageGenerator, simplify API.
Motivation: We want to remove redundant classes from Skia.  To
that end we want to remove SkImageRef and its subclasses and
replace their uses with SkDiscardablePixelRef +
SkDecodingImageGenerator.  Since Android uses SkImageRef, we need
to make sure that SkDecodingImageGenerator allows all of the
settings that Android exposes in BitmapFactory.Options.

To that end, we have created an Options struct for the
SkDecodingImageGenerator which lets the client of the generator set
sample size, dithering, and bitmap config.

We have made the SkDecodingImageGenerator constructor private
and replaced the SkDecodingImageGenerator::Install functions
with a SkDecodingImageGenerator::Create functions (one for
SkData and one for SkStream) which now take a
SkDecodingImageGenerator::Options struct.

Also added a ImageDecoderOptions test which loops through a list
of sets of options and tries them on a set of 5 small encoded
images.

Also updated several users of SkDecodingImageGenerator::Install to
follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp,
and PictureTest.cpp, CachedDecodingPixelRefTest.cpp.

We also added a new ImprovedBitmapFactory Test which simulates the
exact function that Android will need to modify to use this,
installPixelRef() in BitmapFactory.

R=reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/93703004

git-svn-id: http://skia.googlecode.com/svn/trunk@12744 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 17:40:25 +00:00
robertphillips@google.com
45e01c36da Suppress questionable gpu errors
https://codereview.chromium.org/118283002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12743 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 17:28:55 +00:00
robertphillips@google.com
94d8f1ed61 Update bench pictures to time image decode & upload costs
https://codereview.chromium.org/117583002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12742 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 17:25:33 +00:00
commit-bot@chromium.org
d20f9b7358 Rebaselining displacement gms
Rebaseline needed because of changes made in https://codereview.chromium.org/101623007/

BUG=
R=senorblanco@chromium.org, senorblanco@google.com, bsalomon@google.com, bsalomon@chromium.org, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12741 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 16:50:13 +00:00
reed@google.com
8015cdd8fa replace SkScalarMulRound(a,b) with SkScalarRountToInt(a*b)
BUG=
R=sugoi@google.com

Review URL: https://codereview.chromium.org/111393010

git-svn-id: http://skia.googlecode.com/svn/trunk@12740 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 15:49:32 +00:00
commit-bot@chromium.org
83aaf88b99 rebaseline_server: write JSON files using Unix line endings, even on Windows
(SkipBuildbotRuns)
BUG=skia:1815
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com, epoger@google.com

Author: epoger@gmail.com

Review URL: https://codereview.chromium.org/117783004

git-svn-id: http://skia.googlecode.com/svn/trunk@12739 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 15:28:24 +00:00
bungeman@google.com
d9947f605a Split atomic and mutex implementations and make inlinable.
Skia cannot use Chromium's implementation of mutex (Lock) due to static
initializers. However, we would like to be able to use Chromium's
implementation of atomics. This motivates the split of implementation.

Skia's atomic and mutex calls should be inlinable, especially the atomics.
These calls often compile down to very few instructions, and we currently have
the overhead of a function call. This motivates the header implementation.

There is still a desire for the build system to select the implementation, so
the SK_XXX_PLATFORM_H pattern for header files is introduced. This allows the
build system to control which platform specific header files are chosen.

The Chromium side changes (most of which will need to go in before this change
can be found at https://codereview.chromium.org/19477005/ .
The Chromium side changes after this lands can be seen at 
https://codereview.chromium.org/98073013 .

Review URL: https://codereview.chromium.org/19808007

git-svn-id: http://skia.googlecode.com/svn/trunk@12738 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 15:27:39 +00:00
halcanary@google.com
e2380570de SamplePicture no longer uses SkImageRef
Motivation: in an attempt to simplify life, we are depricating
SkImageRef and its subclasses.  To that end, SamplePicture will now
use SkDiscardablePixelRef.

Also, fixed missing resource.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/116423006

git-svn-id: http://skia.googlecode.com/svn/trunk@12737 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 15:08:35 +00:00
commit-bot@chromium.org
6cb74f2b86 Adjusts Ubuntu bench multi_4_threads values. Widens range to cope with the new average instead of 25th.
BUG=
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/108653014

git-svn-id: http://skia.googlecode.com/svn/trunk@12736 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 14:55:02 +00:00
skia.committer@gmail.com
3b85deb9c3 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12734 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 07:01:56 +00:00
reed@google.com
83c6a22525 remove last remnant of SK_SCALAR_IS_FIXED code
move SkScalarMean into its only caller, reducing out public API exposure

BUG=

Review URL: https://codereview.chromium.org/117133004

git-svn-id: http://skia.googlecode.com/svn/trunk@12733 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 05:19:22 +00:00
reed@google.com
6e252d49c9 move SkScalarMean into its only caller, reducing out public API exposure
BUG=

Review URL: https://codereview.chromium.org/117973002

git-svn-id: http://skia.googlecode.com/svn/trunk@12732 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 05:06:52 +00:00
reed@google.com
e15b2f5296 move SkScalarLog2 into its only client, in a move to reduce our public API surface area
BUG=

Review URL: https://codereview.chromium.org/93643004

git-svn-id: http://skia.googlecode.com/svn/trunk@12731 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 04:59:26 +00:00
commit-bot@chromium.org
0fc0dea333 Add a setTimer() function.
Seemed simple, but required adding a Global class that contains all the global state (instance and context) for our running V8 instance. Also moved canvas.inval to be just inval() at the global level.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/103143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12730 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 04:45:37 +00:00
commit-bot@chromium.org
4e8f1e56b1 [PDF] Fix clipping in xfermode improvement.
In some cases, the wrong clip (src clip instead of initial clip) was used.
Switch almost exclusively to initial clip because it is safe and generates a smaller result.

BUG=chromium:328009
R=reed@google.com, bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/116423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12729 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 23:38:28 +00:00
commit-bot@chromium.org
b09bfcb7b1 add virtual destructor for SkExample to fix build error.
The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples":
error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor.

R=caryclark@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/98463013

git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 23:37:38 +00:00
commit-bot@chromium.org
658e1b38b9 Fixing valgrind error
After an error in the stream prevented the deserialization of SkRect members, there was no check to see if there was an error state before testing the validity of these uninitialized SkRect members. Added the check to fix the valgrind error.

BUG=
R=robertphillips@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/114493005

git-svn-id: http://skia.googlecode.com/svn/trunk@12727 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:32:42 +00:00
bsalomon@google.com
d6c1d58763 Remove bleed from ignored-tests.txt
BUG=skia:1880

Review URL: https://codereview.chromium.org/103213011

git-svn-id: http://skia.googlecode.com/svn/trunk@12726 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:27:39 +00:00
bsalomon@google.com
62bb849a88 Mark bleed gpu as ignore failure on Xoom (Release version)
BUG=skia:1938

Review URL: https://codereview.chromium.org/117633002

git-svn-id: http://skia.googlecode.com/svn/trunk@12725 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:20:41 +00:00
bsalomon@google.com
c1c6a4f552 Mark bleed gpu as ignore failure on Xoom
BUG=skia:1938

Review URL: https://codereview.chromium.org/116093005

git-svn-id: http://skia.googlecode.com/svn/trunk@12724 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:13:00 +00:00
commit-bot@chromium.org
ef74fa189b Fixed more fuzzer issues
- Added the "isAvailable" function to check how much bytes are remaining in the stream before doing potentially large mallocs. That way, we can signal a bad stream instead of crashing.
- Added data validation in SkImageInfo.cpp
- Added NULL pointer check in displacement
- Modified the fuzzer for randomized bitmap types

BUG=328934,329254
R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/116773002

git-svn-id: http://skia.googlecode.com/svn/trunk@12723 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:49:46 +00:00
bsalomon@google.com
7d0b613191 Mark 8888/565 bleed GMS as ignore-failure
BUG=skia:1934

Review URL: https://codereview.chromium.org/117563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12722 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:30:17 +00:00
commit-bot@chromium.org
b6a1c0154d Adjusts Win7 bench tile_256x256_multi_4_threads. Using 8f4d230.
BUG=
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/117523002

git-svn-id: http://skia.googlecode.com/svn/trunk@12721 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:23:22 +00:00
reed@google.com
26deb23e15 change SkScalarRound to SkScalarRoundToInt
BUG=

Review URL: https://codereview.chromium.org/105073006

git-svn-id: http://skia.googlecode.com/svn/trunk@12720 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 19:50:57 +00:00
reed@google.com
e1ca705cac deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/111353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 19:22:07 +00:00
commit-bot@chromium.org
3fb15f4d21 Bench rebaseline for Ubuntu. Also manually adjust one entry for Nexus7.
BUG= https://code.google.com/p/skia/issues/detail?id=1871
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/106593003

git-svn-id: http://skia.googlecode.com/svn/trunk@12718 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 18:39:27 +00:00
commit-bot@chromium.org
50ad8e4d8e rebaseline_server: return rebaseline results faster, and reload UI page automatically after
Old way:
Wait until server has loaded the updated results before telling the user the rebaseline
was successful, and trust the user to reload the page before submitting more baselines.

New way:
Make server load the updated results in a separate thread, and automatically reload the page
so that the user can submit more baselines if she wants to.

(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/117453002

git-svn-id: http://skia.googlecode.com/svn/trunk@12717 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 18:06:13 +00:00
halcanary@google.com
588be53706 Added five small images to the resources/encoding.
1428 bytes total.

For use in testing https://codereview.chromium.org/93703004/

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/107863005

git-svn-id: http://skia.googlecode.com/svn/trunk@12716 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:40:13 +00:00
commit-bot@chromium.org
55f6b24eb8 Add unreviewed skimage expectations for Test-Win8-ShuttleA-GTX660-x86-Release-NVPR
NOTRY=True
BUG=
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/110663006

git-svn-id: http://skia.googlecode.com/svn/trunk@12715 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:35:13 +00:00
commit-bot@chromium.org
bf8ba65cca Add Win8 bots to rebaseline.py, add baselines for Win8
NOTRY=True
BUG=
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/117433003

git-svn-id: http://skia.googlecode.com/svn/trunk@12714 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:29:33 +00:00
reed@google.com
8f4d2306fa remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats
To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.

BUG=
R=bsalomon@google.com, caryclark@google.com

Review URL: https://codereview.chromium.org/117053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:44:46 +00:00
bsalomon@google.com
a34b638b90 Rebaseline gpu and pdf bleed GM images
BUG=1880

Review URL: https://codereview.chromium.org/100023006

git-svn-id: http://skia.googlecode.com/svn/trunk@12711 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:37:07 +00:00
commit-bot@chromium.org
4952516abe Create empty GM expectations for all Win8 builders
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/117233003

git-svn-id: http://skia.googlecode.com/svn/trunk@12710 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:33:35 +00:00
robertphillips@google.com
bbd893dcc3 Fix handling of aggregate times in TimerData::getResult
https://codereview.chromium.org/117393002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12709 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:32:51 +00:00
bsalomon@google.com
442fa37ffd Rebaseline innocuous image changes on Android.
Review URL: https://codereview.chromium.org/117343002

git-svn-id: http://skia.googlecode.com/svn/trunk@12708 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 15:34:17 +00:00
robertphillips@google.com
3cf7e93b67 Revert r12694 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows - https://codereview.chromium.org/111403003) due to Chromium-side compilation errors
git-svn-id: http://skia.googlecode.com/svn/trunk@12707 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 15:13:55 +00:00
commit-bot@chromium.org
77887af13f Prevent crash in Lua bindings.
SkPaint::getTypeface() can return NULL; paint:getTypeface() would
attempt to refcount that value before storing it on the Lua stack
and crash. This is a minimal workaround that fixes the crash.

R=reed@google.com, tomhudson@google.com, robertphillips@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/109793010

git-svn-id: http://skia.googlecode.com/svn/trunk@12706 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 14:28:19 +00:00
robertphillips@google.com
090601c917 Make bench_pictures' timing more GPU friendly
https://codereview.chromium.org/113873005/



git-svn-id: http://skia.googlecode.com/svn/trunk@12705 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 13:40:20 +00:00
skia.committer@gmail.com
495dc860bf Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12703 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 07:01:45 +00:00