reed@google.com
ce29b329e4
remove flag for legacy copyTo -- call sites have been updated
...
TBR=robertphilips@google.com
Review URL: https://codereview.chromium.org/189513005
git-svn-id: http://skia.googlecode.com/svn/trunk@13706 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 16:20:47 +00:00
commit-bot@chromium.org
19dff99a67
update Doxygen config file to include gpu directory in api generation
...
BUG=skia:2263
R=epoger@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/182253012
git-svn-id: http://skia.googlecode.com/svn/trunk@13705 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 16:20:36 +00:00
commit-bot@chromium.org
8016f79cfc
This is just the first version and shows how I intend to orchestrate this. Future enhancements will:
...
track the portion of the bitmap required
track any resizing that might be required
actually preload something
R=bsalomon@google.com , mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/187833003
git-svn-id: http://skia.googlecode.com/svn/trunk@13704 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 15:53:01 +00:00
commit-bot@chromium.org
8eb20cc112
remove code disabled from writePixels change
...
These tests were asserting that particular, non-documented, optimizations were taking place
in the deferreddevice. Theese particualr short-cuts are no longer possible given the change
to canvas' writepixels to always require a raw-pointer.
R=junov@google.com
TBR=junov@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/190853002
git-svn-id: http://skia.googlecode.com/svn/trunk@13703 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 14:52:22 +00:00
commit-bot@chromium.org
210a6aa8bd
getFactory() must return a factory.
...
BUG=348821
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/190843002
git-svn-id: http://skia.googlecode.com/svn/trunk@13702 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 14:52:09 +00:00
commit-bot@chromium.org
7fc2228795
Fix underlying issue causing crbug.com/348821.
...
SkDashPathEffect refuses to flatten itself if it thinks it's a no-op. This
messes with the assumption that flattening a non-NULL effect and then
unflattening from those bytes produces a non-NULL effect. I'd rather make that
assumption always be true than save a few bytes for rare nonsense path effects.
BUG=348821
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/189643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13701 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 14:43:00 +00:00
commit-bot@chromium.org
32a7195310
fix the build error of SkiaExample -- use setColorType, not setConfig
...
BUG=skia:
R=reed@google.com , scroggo@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/190303002
git-svn-id: http://skia.googlecode.com/svn/trunk@13700 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 13:24:52 +00:00
commit-bot@chromium.org
fe089b383a
SSE2 implementation of S32A_D565_Opaque_Dither
...
Run benchmarks with command line option "--forceDither true --forceBlend
1", almost all the benchmarks exercised S32A_D565_Opaque_Dither can get
about 20%-70% performance improvement.
Here are the data on i7-3770:
before after
verts 4314.81 3627.64 15.93%
constXTile_MM_filter_trans 1434.22 432.82 69.82%
constXTile_CC_filter_trans_scale 1440.17 437.00 69.66%
constXTile_RR_filter_trans 1436.96 431.93 69.94%
constXTile_MM_trans_scale 1436.33 435.77 69.66%
constXTile_CC_trans 1433.12 431.36 69.90%
constXTile_RR_trans_scale 1436.13 436.06 69.64%
constXTile_MM_filter 1411.55 408.06 71.09%
constXTile_CC_filter_scale 1416.68 414.18 70.76%
constXTile_RR_filter 1429.46 409.81 71.33%
constXTile_MM_scale 1415.00 412.56 70.84%
constXTile_CC 1410.32 408.36 71.04%
constXTile_RR_scale 1413.26 413.16 70.77%
repeatTile_4444_A 1922.01 879.03 54.27%
repeatTile_4444_A 1430.68 818.34 42.80%
repeatTile_4444_X 1817.43 816.63 55.07%
maskshader 5911.09 5895.46 0.26%
gradient_create_alpha 4.41 4.41 -0.15%
gradient_conical_clamp_3color 35298.71 27574.34 21.88%
gradient_conical_clamp_hicolor 35262.15 27538.99 21.90%
gradient_conical_clamp 35276.21 27599.80 21.76%
gradient_radial2_mirror 20846.74 12969.39 37.79%
gradient_radial2_clamp_hicolor 21848.12 13967.57 36.07%
gradient_radial2_clamp 21829.95 13978.57 35.97%
bitmap_4444_A_scale_rotate_bicubic 105.31 87.13 17.26%
bitmap_4444_A_scale_bicubic 73.69 47.76 35.20%
bitmap_4444_update_scale_rotate_bilerp 125.65 87.86 30.08%
bitmap_4444_update_volatile_scale_rotate_bilerp 125.50 87.65 30.16%
bitmap_4444_scale_rotate_bilerp 124.46 87.91 29.37%
bitmap_4444_A_scale_rotate_bilerp 105.09 87.27 16.96%
bitmap_4444_update_scale_bilerp 106.78 63.28 40.74%
bitmap_4444_update_volatile_scale_bilerp 106.66 63.66 40.32%
bitmap_4444_scale_bilerp 106.70 63.19 40.78%
bitmap_4444_A_scale_bilerp 83.05 62.25 25.04%
bitmap_a8 98.11 52.76 46.22%
bitmap_a8_A 98.24 52.85 46.20%
BUG=
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/179443003
git-svn-id: http://skia.googlecode.com/svn/trunk@13699 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 13:24:42 +00:00
commit-bot@chromium.org
275804782f
SSE2 implementation of S32_D565_Opaque_Dither
...
Run benchmarks with command line option "--forceDither true". The result
shows that all benchmarks exercised S32_D565_Opaque_Dither benefit from
this SSE2 optimization. Here are the data on i7-3770:
before after
constXTile_MM_filter 900.93 217.75 75.83%
constXTile_CC_filter_scale 907.59 225.65 75.14%
constXTile_RR_filter 903.33 219.41 75.71%
constXTile_MM_scale 902.45 221.46 75.46%
constXTile_CC 898.55 218.37 75.70%
constXTile_RR_scale 902.69 222.35 75.37%
repeatTile_4444_X 938.53 240.49 74.38%
gradient_radial2_mirror 16999.49 11540.39 32.11%
gradient_radial2_clamp_hicolor 17943.38 12501.71 30.33%
gradient_radial2_clamp 17816.36 12492.04 29.88%
bitmaprect_FF_filter_trans 47.81 10.98 77.03%
bitmaprect_FF_nofilter_trans 47.79 10.91 77.18%
bitmaprect_FF_filter_identity 47.74 10.89 77.18%
bitmaprect_FF_nofilter_identity 47.83 10.89 77.24%
bitmap_4444_update_scale_rotate_bilerp 100.45 76.84 23.50%
bitmap_4444_update_volatile_scale_rotate_bilerp 100.80 76.70 23.91%
bitmap_4444_scale_rotate_bilerp 100.43 77.18 23.15%
bitmap_4444_update_scale_bilerp 79.00 49.03 37.93%
bitmap_4444_update_volatile_scale_bilerp 78.90 48.87 38.06%
bitmap_4444_scale_bilerp 78.92 48.81 38.16%
bitmap_4444_update 42.19 11.53 72.68%
bitmap_4444_update_volatile 42.28 11.49 72.82%
bitmap_a8 60.37 29.75 50.72%
bitmap_4444 42.19 11.52 72.69%
BUG=
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/181293002
git-svn-id: http://skia.googlecode.com/svn/trunk@13698 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 03:25:32 +00:00
commit-bot@chromium.org
4cd9e2169e
Add SkCanvas::writePixels that takes info+pixels directly
...
add corresponding methods to device (w/ diff name to avoid colliding with exising virtuals)
BUG=skia:
R=bsalomon@google.com , robertphillips@google.com , junov@google.com , junov@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/180113010
git-svn-id: http://skia.googlecode.com/svn/trunk@13697 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 03:25:16 +00:00
commit-bot@chromium.org
a5572e5bb2
Add a class to allocate small objects w/o extra calls to new.
...
Add SkSmallAllocator, a template for allocating small (as defined by the
instantiation) objects without extra calls to new. Add a helper macro to
make using it simple.
Remove SkTemplatesPriv.h, whose behavior is replaced by SkSmallAllocator.
The old SK_PLACEMENT_NEW had the following drawbacks:
- Easily confused with SkNEW_PLACEMENT.
- Requires passing around lots of void*s along with the storageSize.
- Requires using a separate class for deleting it.
- We had multiple ways Auto objects for deleting in different places.
- It always did a straight heap allocation on Windows, meaning Windows
did not get any advantages from the confusing code.
The new SkSmallAllocator simplifies things:
- It is clear about what it does.
- It takes care of the deletion in one place that is automatically
handled.
Further, the new class can be used to create more than one object. This
is in preparation for BUG=skia:1976, for which we would like to create
a new object without extra heap allocations. The plan is to create both
the blitter and the new object on the stack using the SkSmallAllocator.
Add a new test for SkSmallAllocator.
SkShader.h:
Move the private version of CreateBitmapShader to SkBitmapProcShader
(which already has the implementation) and remove the friend class
(which was only used to call this private function). This allows
SkSmallAllocator to reside in the private src/ directory.
SkBitmapProcShader:
Move CreateBitmapShader and the macro for the storage size here. With
the macro in a (private) header, the (private) headers with function
declarations (which now depend on the storage size used) can see the
macro.
Use SkSmallAllocator in CreateBitmapShader.
Change the macro to kBlitterStorageByteCount, since SkSmallAllocator
takes a byte count as its template parameter.
SkBlitter:
Use the SkSmallAllocator.
Remove Sk3DShader::fKillProc and SkAutoCallProc. Both of their
behaviors have been moved into SkSmallAllocator (SkAutoCallProc was
unnecessary anyway, because the only time we ever used it we also
called detach(), so its auto behavior never happened).
Create the Sk3DShader on the stack, if there's room.
Remove the helper version of Choose, which was unused.
SmallAllocatorTest:
Test for the new class.
The rest:
Use SkSmallAllocator.
BUG=skia:1976
R=reed@google.com , mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/179343005
git-svn-id: http://skia.googlecode.com/svn/trunk@13696 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 03:24:41 +00:00
commit-bot@chromium.org
1d328e4617
Yet another whitespace change to see if the bots are fixed
...
NOTRY=true
NOTREECHECKS=true
R=epoger@google.com , rmistry@google.com
TBR=epoger, rmistry
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/189453002
git-svn-id: http://skia.googlecode.com/svn/trunk@13695 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 23:38:52 +00:00
commit-bot@chromium.org
4d5337e799
Whitespace change to verify that the bots are fixed
...
R=epoger@google.com , rmistry@google.com
TBR=epoger, rmistry
NOTREECHECKS=true
NOTRY=true
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/189253003
git-svn-id: http://skia.googlecode.com/svn/trunk@13694 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 23:08:33 +00:00
commit-bot@chromium.org
66645e3bdd
Whitespace change to test whether builders are fixed
...
R=epoger@google.com , rmistry@google.com
TBR=epoger, rmistry
NOTRY=true
NOTREECHECKS=true
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/188633005
git-svn-id: http://skia.googlecode.com/svn/trunk@13693 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 21:48:57 +00:00
commit-bot@chromium.org
06e9752521
Add debug check of chunk size written to skp
...
R=mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/182153003
git-svn-id: http://skia.googlecode.com/svn/trunk@13692 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 20:53:44 +00:00
commit-bot@chromium.org
b193c3b9fc
Mark mixed_xfermodes_gpu on Win7 perspective bot as ignore-failure
...
BUG=skia:2262
NOTRY=true
R=epoger@google.com , bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/183803034
git-svn-id: http://skia.googlecode.com/svn/trunk@13691 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 20:34:02 +00:00
commit-bot@chromium.org
e597e7b5c8
Remove MCRec.fNext
...
No longer used.
R=reed@google.com , mtklein@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/186973004
git-svn-id: http://skia.googlecode.com/svn/trunk@13690 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 19:56:58 +00:00
commit-bot@chromium.org
525bceebd8
Manually add baseline for typeface_565
...
BUG=skia:2146
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/180533011
git-svn-id: http://skia.googlecode.com/svn/trunk@13689 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 19:29:24 +00:00
commit-bot@chromium.org
0438645c72
Actually, we wrote only size bytes.
...
BUG=skia:
R=halcanary@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/188343004
git-svn-id: http://skia.googlecode.com/svn/trunk@13688 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 19:23:51 +00:00
commit-bot@chromium.org
d10913b8a9
Avoid recomputing two consecutive identical 1D filters.
...
If the arguments to the X and Y filter computation are identical,
the results will be identical; copying is much faster than recomputing.
With a change like https://codereview.chromium.org/183763047/ applied
this speeds up BitmapScaleBench on Linux by around 10%.
BUG=skia:2236
R=humper@google.com , tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/188743002
git-svn-id: http://skia.googlecode.com/svn/trunk@13687 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 19:10:44 +00:00
commit-bot@chromium.org
0015df93b3
Make arm64 test script more efficient with old versions of gsutil.
...
This continues the changes indtroduced in
<https://codereview.chromium.org/183883020 >, and also simplifies the
script considerably.
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/176973010
git-svn-id: http://skia.googlecode.com/svn/trunk@13686 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 17:47:49 +00:00
commit-bot@chromium.org
1b28f6f1ce
Adding this call simulates seeing a *different* bitmap every time we scale, which changes the code path (places much heavier load on constructing a new filter). This better emulates the kind of environment most embedders see us in, where they try to cache a scaled bitmap rather than frequently rescaling it.
...
This change will cause significant regressions in microbenchmark scores.
BUG=skia:2236
R=humper@google.com , reed@google.com , scroggo@google.com , tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/183763047
git-svn-id: http://skia.googlecode.com/svn/trunk@13685 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 17:16:37 +00:00
commit-bot@chromium.org
490fb6b471
Add size_t bytesWritten() const to SkWStream.
...
BUG=skia:
R=reed@google.com , mtklein@google.com , robertphillips@google.com , bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/187653003
git-svn-id: http://skia.googlecode.com/svn/trunk@13684 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 17:16:26 +00:00
rmistry@google.com
d7a9fcc61f
Revert of Manually set fFilterValues in SkConvolutionFilter1D
...
Revert of https://codereview.chromium.org/184323003
Reason for revert:
Caused unexpected CompareGM failures-
http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86_64-Debug/builds/461/steps/CompareGMs/logs/stdio
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Release/builds/2062/steps/CompareGMs/logs/stdio
http://108.170.217.252:10117/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/1400/steps/CompareGMs/logs/stdio
TBR=
NOTREECHECKS=True
NOTRY=True
git-svn-id: http://skia.googlecode.com/svn/trunk@13683 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 15:37:53 +00:00
commit-bot@chromium.org
fd5c9a6e04
Begin making SkPerlinNoiseShader const.
...
The overall goal is to make SkShader itself immutable (BUG=skia:1976).
The fields cannot yet be made constant, due to the constructor which
takes an SkReadBuffer. Other than that constructor, the fields are now
unchanged.
Remove setTileSize and initPaint. Merge initPaint with the constructor
of PaintingData, since it is only ever used on a new PaintingData.
Merge setTileSize with the SkPerlinNoiseShader constructor, its only
call site.
BUG=skia:1976
R=reed@google.com , sugoi@google.com , dominikg@chromium.org , senorblanco@google.com , senorblanco@chromium.org
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/169973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13682 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 15:13:53 +00:00
commit-bot@chromium.org
5b70e7e2df
Manually set fFilterValues in SkConvolutionFilter1D.
...
Using fFilterValues.reset() or a loop of fFilterValues.push_back() is about 5x slower than calling fFilterValues.resize_back() and then looping using primitive [] and =.
This is only going to show up if you apply https://codereview.chromium.org/183763047/ , where it yields about 2.5% speedup in the bitmap resize microbenchmarks on a Linux desktop. Ceteris paribus, it should actually improve rasterization time of drawBitmapRectToRect() with a resize by about 5% in Chromium.
BUG=skia:2258
R=humper@google.com , tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/184323003
git-svn-id: http://skia.googlecode.com/svn/trunk@13681 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 14:57:46 +00:00
commit-bot@chromium.org
759cf48468
Now that the matching changes have landed in Chromium we can clean up the API on our side.
...
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/187553003
git-svn-id: http://skia.googlecode.com/svn/trunk@13680 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 13:18:07 +00:00
skia.committer@gmail.com
06acb58074
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13679 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-06 03:02:32 +00:00
commit-bot@chromium.org
5bee0543f0
Give PictureTest more verbose error messages.
...
Motivation: On an odd build system I'm testing, we're triggering these
errors. More verbose test output will help me diagnose the errors.
R=robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/183023014
git-svn-id: http://skia.googlecode.com/svn/trunk@13678 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 20:59:45 +00:00
commit-bot@chromium.org
026ea9d1f1
Update baselines for Win7 perspective and Nexus4
...
BUG=skia:2146
NOTRY=true
R=epoger@google.com , bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/185943007
git-svn-id: http://skia.googlecode.com/svn/trunk@13677 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 20:49:59 +00:00
commit-bot@chromium.org
61f1606236
rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images
...
BUG=skia:2248,skia:2231
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/183893030
git-svn-id: http://skia.googlecode.com/svn/trunk@13676 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 19:46:17 +00:00
commit-bot@chromium.org
0b98f67b90
Fix FontMgrTest to allow for unnamed fonts.
...
Motivation: we are testing on a system without fonts and are falling
back on SkTypeface_Empty.
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/187933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13675 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 19:41:10 +00:00
commit-bot@chromium.org
cabf4b2f36
Unify edge type enums across GrEffect subclasses that clip rendering to a geometry.
...
BUG=skia:
R=egdaniel@google.com , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/183893023
git-svn-id: http://skia.googlecode.com/svn/trunk@13674 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 18:27:43 +00:00
commit-bot@chromium.org
dcb8e54ffd
This CL is motivated by the desire to make the skpinfo tool work a bit better. The main concern is that the assumptions made w.r.t. written bytes may not be valid for all SkWStream sub-classes.
...
R=bungeman@gmail.com , bungeman@google.com , reed@google.com , mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/182733008
git-svn-id: http://skia.googlecode.com/svn/trunk@13673 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 18:25:20 +00:00
commit-bot@chromium.org
890b826fa3
Remove unused TimerData that generates errors
...
As far as I can tell all uses of TimerData::appendTimes were stripped out in https://chromiumcodereview.appspot.com/23121002 but the surrounding code was left in, causing it to print errors when there are none.
BUG=skia:2242
R=sglez@google.com , tomhudson@chromium.org , mtklein@google.com , tomhudson@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/187643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13672 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 17:09:46 +00:00
bungeman@google.com
8d79f963b6
Prevent SkBlockMemoryStream::skip from writing to low memory.
...
SkBlockMemoryStream::read was modeled on SkDynamicMemoryWStream::read.
However, SkDynamicMemoryWStream::read does not allow passing a NULL buffer
and SkBlockMemoryStream::read must correctly handle this case for skips.
In the current code, if a 'skip' crosses a block boundary, 'read' may
attempt to write to low memory.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/187683003
git-svn-id: http://skia.googlecode.com/svn/trunk@13671 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 16:26:14 +00:00
senorblanco@chromium.org
968f1623af
New baselines for offsetimagefilter GM.
...
TBR=rmistry@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/187883002
git-svn-id: http://skia.googlecode.com/svn/trunk@13670 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 15:38:21 +00:00
commit-bot@chromium.org
eef834f2be
DM: read image files without an extra copy
...
BUG=skia:
R=halcanary@google.com , reed@google.com , bsalomon@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/185263012
git-svn-id: http://skia.googlecode.com/svn/trunk@13669 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 15:37:11 +00:00
commit-bot@chromium.org
c4b3e75a7b
Make arm64 test script comaptable with old versions of gsutil.
...
NOTRY=true
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/183883020
git-svn-id: http://skia.googlecode.com/svn/trunk@13668 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 14:16:36 +00:00
commit-bot@chromium.org
5e4112b33a
Replace scaled bitmap if entry already exist in cache.
...
BUG=skia:2251
R=reed@google.com
Author: reveman@chromium.org
Review URL: https://codereview.chromium.org/185263009
git-svn-id: http://skia.googlecode.com/svn/trunk@13667 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 13:44:18 +00:00
commit-bot@chromium.org
8ef51b975c
remove deprecated use of bitmap config from tests
...
BUG=skia:
R=halcanary@google.com , reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/184233003
git-svn-id: http://skia.googlecode.com/svn/trunk@13666 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 13:43:15 +00:00
skia.committer@gmail.com
f1f66c0c86
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13665 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 03:02:06 +00:00
commit-bot@chromium.org
fab349c0bf
remove SK_SUPPORT_DEEPCOPYTO_CONFIG code -- no longer used
...
R=reed@google.com
TBR=bsalomon@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/183763035
git-svn-id: http://skia.googlecode.com/svn/trunk@13664 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 02:34:58 +00:00
commit-bot@chromium.org
1f6cf695b3
Counterproposal to 182733007: Add iterator to SkTDynamicHash
...
BUG=skia:
R=egdaniel@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/177263005
git-svn-id: http://skia.googlecode.com/svn/trunk@13663 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 01:00:50 +00:00
commit-bot@chromium.org
e492ac4fb6
Manual revert of https://code.google.com/p/skia/source/detail?r=13353 due to perf regression.
...
BUG=344020
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/187023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13662 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 22:37:29 +00:00
commit-bot@chromium.org
6e2be5dbe3
Fix error in barelinux_make build script
...
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/187093002
git-svn-id: http://skia.googlecode.com/svn/trunk@13661 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 22:32:49 +00:00
commit-bot@chromium.org
24e0496e8d
Factor out a BaseContext from JsContext.
...
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/186783004
git-svn-id: http://skia.googlecode.com/svn/trunk@13660 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 20:44:32 +00:00
senorblanco@chromium.org
a100bb25a5
New baselines for imagefiltersclipped, imagefiltersscaled GMs.
...
Required after r13637.
TBR=rmistry@google.com
Review URL: https://codereview.chromium.org/186933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13659 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 19:22:43 +00:00
commit-bot@chromium.org
e494dbdec3
The motivation for this CL is to de-clutter SkPicture's beginRecording method.
...
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/186813003
git-svn-id: http://skia.googlecode.com/svn/trunk@13658 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 19:08:57 +00:00
commit-bot@chromium.org
cb336874e4
Start prototyping what DisplayList support will look like.
...
None of the new codepaths get executed yet since DisplayList doesn't exist, but that will happening in the new few CLs.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/183883017
git-svn-id: http://skia.googlecode.com/svn/trunk@13657 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 19:05:50 +00:00