Commit Graph

933 Commits

Author SHA1 Message Date
senorblanco
b0e89dcc1d Fix image filters for PDF backend.
Currently, the PDF backend does not support image filters (since PDF
does not have that functionality), so it simply removes them. This is
causing Chrome print preview to render incorrectly (see bug). The fix
here is to fall back to a raster device for image filters, as we used
to do in Blink. The resulting bitmap will be drawn to the destination
device as a normal main-memory-backed bitmap.

Note: this change invalidates the PDF results of all GMs containing
image filters (since they'll actually be rendered).

BUG=422144

Review URL: https://codereview.chromium.org/644323006
2014-10-20 14:03:13 -07:00
bungeman
a4c4a2d8cd Replace SkTypeface::Style with SkFontStyle.
Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20

Review URL: https://codereview.chromium.org/488143002
2014-10-20 13:33:19 -07:00
jvanverth
fca302ccf4 Add color emoji fallback for distance field text.
BUG=skia:3033

Review URL: https://codereview.chromium.org/670533002
2014-10-20 13:12:55 -07:00
Florin Malita
4ce01d606d Rebaseline textblob GM
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/654303006
2014-10-16 20:45:49 -04:00
fmalita
19653d1d00 Implicit SkTextBlob bounds
Compute blob bounds when the client doesn't pass explicit run rects to
the builder. This allows us to remove a couple of internal workarounds.

R=reed@google.com,mtklein@google.com,bungeman@google.com

Review URL: https://codereview.chromium.org/654873003
2014-10-16 11:53:30 -07:00
jvanverth
aab626c367 Revert of Change drawText() to generate positions and send to drawPosText() (patchset #4 id:60001 of https://codereview.chromium.org/653133004/)
Reason for revert:
A large number of GMs on Ubuntu12 are failing. The text layout on GPU is visibly different than that for 8888.

Original issue's description:
> Change drawText() to generate positions and send to drawPosText()
>
> The idea here is to have a central place that does layout for drawText(), and
> then always feed text through drawPosText(). This both makes all of the
> GrTextContexts consistent in drawText() output, and does a better job of
> stressing drawPosText().
>
> Because of the effect of matrices on hinting and approximation error, the
> generated text is not 100% identical to that produced by the raster pipeline.
>
> BUG=skia:2778
>
> Committed: https://skia.googlesource.com/skia/+/7851a56895c9c076f73a835a7dd51d3c6180c16f

TBR=cdalton.nvidia@gmail.com,bungeman@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2778

Review URL: https://codereview.chromium.org/659993003
2014-10-16 08:04:39 -07:00
jvanverth
7851a56895 Change drawText() to generate positions and send to drawPosText()
The idea here is to have a central place that does layout for drawText(), and
then always feed text through drawPosText(). This both makes all of the
GrTextContexts consistent in drawText() output, and does a better job of
stressing drawPosText().

Because of the effect of matrices on hinting and approximation error, the
generated text is not 100% identical to that produced by the raster pipeline.

BUG=skia:2778

Review URL: https://codereview.chromium.org/653133004
2014-10-16 06:20:35 -07:00
Brian Salomon
5b9cb06761 Ignore ubuntu nvprmsaa4/mixed_xfermodes GM result.
BUG=skia:2443

Review URL: https://codereview.chromium.org/653153003
2014-10-14 16:12:23 -04:00
Brian Salomon
d5da96a814 Rebaseline mixedxfermodes on ubuntu/nvprmsaa4
TBR=

Review URL: https://codereview.chromium.org/657603005
2014-10-14 15:52:46 -04:00
borenet
af44e701a5 Fix links to skia-buildbot code in preparation for deletion
BUG=skia:761

Review URL: https://codereview.chromium.org/655643002
2014-10-14 04:44:44 -07:00
jvanverth
0880686d95 Enable color emoji GM on Android
BUG=skia:2887

Review URL: https://codereview.chromium.org/656433002
2014-10-13 12:48:10 -07:00
jvanverth
75e926a1b1 Update coloremoji expectations
TBR=reed@google.com
BUG=skia:2887

Review URL: https://codereview.chromium.org/649753003
2014-10-10 12:58:46 -07:00
jvanverth
294c32612d Fix color emoji.
Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

Review URL: https://codereview.chromium.org/636183005
2014-10-10 11:36:12 -07:00
jvanverth
e817dbb889 Revert of Fix color emoji. (patchset #11 id:320001 of https://codereview.chromium.org/636183005/)
Reason for revert:
Crashing the Windows bots.

Original issue's description:
> Fix color emoji.
>
> Removes the GrMaskFormat and single atlas in GrTextStrike.
> Replaces it by storing the GrMaskFormat in each GrGlyph, and
> doing a lookup for the correct atlas based on that.
>
> Disables color glyph rendering in GrDistanceFieldTextContext
> for now.
>
> BUG=skia:2887
>
> Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

TBR=robertphillips@google.com,bungeman@google.com,reed@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2887

Review URL: https://codereview.chromium.org/640413004
2014-10-10 08:52:03 -07:00
jvanverth
bc92163ddf Fix color emoji.
Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Review URL: https://codereview.chromium.org/636183005
2014-10-10 08:21:29 -07:00
jvanverth
6cb35fa467 Ignore complexclip_path_aa on Win7-HD2000 for the moment.
TBR=reed@google.com
BUG=skia:3006

Review URL: https://codereview.chromium.org/643103002
2014-10-10 07:14:55 -07:00
joshualitt
d8088f846f updating expectations
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/646963002
2014-10-10 06:48:48 -07:00
jvanverth
e01844540a Update expectations for distance field path rendering.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/641203002
2014-10-09 12:37:36 -07:00
egdaniel
691d6730e0 Rebase Nexus 10 gm failure
TBR=robertphillips@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/638043002
2014-10-08 09:38:30 -07:00
bsalomon
b82b9d577e Make GM default to reseting gpu contexts on android.
TBR=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb

Review URL: https://codereview.chromium.org/635293003
2014-10-08 08:17:11 -07:00
derekf
e6efd39a33 Only use msaa target for blur mask when doAA is true
BUG=skia:2995

Review URL: https://codereview.chromium.org/639523002
2014-10-07 14:44:34 -07:00
jvanverth
d99741cbbe Update perspective GMs for dfpaths
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/632363004
2014-10-07 10:55:43 -07:00
jvanverth
c7c2716a5b Add baselines for dftext GM.
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/638683002
2014-10-07 10:23:34 -07:00
robertphillips
c1188aacd5 Added more msaa blurring rebaselines & a suppression
These are rebaselines for: Create MSAA render target for blur mask texture - https://codereview.chromium.org/616923004

BUG=skia:2995
TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628813003
2014-10-07 05:56:24 -07:00
robertphillips
b1b2085569 Rebaseline multipicturedraw_biglayer_*
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/635813003
2014-10-07 05:08:12 -07:00
robertphillips
40e01c499e Remove suppressions in ignored-tests.txt
This should be safe after: Update suppressed baseline images - https://codereview.chromium.org/605973003/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628013003
2014-10-07 04:52:16 -07:00
bsalomon
4e8955b772 Rebaseline after msaa blur change
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631993002
2014-10-06 13:29:22 -07:00
robertphillips
e71d8841ce Update suppressed baseline images
This updates the non-multipicturedraw GM images suppressed in:
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/605973003
2014-10-06 12:54:15 -07:00
robertphillips
3342d1b5a0 Add suppression for multipicturedraw_biglayer GM
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631973002
2014-10-06 12:27:53 -07:00
robertphillips
0cb34b5ab6 Update baseline GM images
This updates the multipicturedraw_* GM images for:

Reduce overdraw in MultiPictureDraw Sierpinski GM - https://codereview.chromium.org/582633003/
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/632703003
2014-10-06 11:41:04 -07:00
robertphillips
2e5a986bc7 New baselines
New baseline images for multipicturedraw_biglayer* GMs added in (Add a MultiPictureDraw GM to exercise layer clipping - https://codereview.chromium.org/617723004/).

NOTRY=true
TBR=reed@google.com

Review URL: https://codereview.chromium.org/629293002
2014-10-06 10:57:14 -07:00
jvanverth
5d271f1581 Update fontcache expectations
TBR=reed@google.com

Review URL: https://codereview.chromium.org/634623002
2014-10-06 10:47:59 -07:00
jvanverth
fa38a30897 Add GrAASmallPathRenderer.
Uses cached signed distance fields to render scaled and rotated versions
of small paths.

BUG=skia:2935

Review URL: https://codereview.chromium.org/589103004
2014-10-06 05:59:05 -07:00
robertphillips
4611e7f479 Don't turn on dither for saveLayers which have no paint
Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining.

NOTRY=true

Review URL: https://codereview.chromium.org/619363002
2014-10-03 06:53:04 -07:00
fmalita
08bd03bc17 Add blobshader GM baselines.
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/616853003
2014-10-02 05:00:29 -07:00
reed
5817f21e0b remove suppression for gm
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/617193003
2014-10-01 12:53:53 -07:00
reed
8324a6a27e add baseline for clip_strokerect
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/618373002
2014-10-01 12:41:13 -07:00
reed
39f31c6ed0 baseline new GMs
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/623443004
2014-10-01 12:18:40 -07:00
robertphillips
6589dec11e Rebaseline Unknown-Arm64 GM flakes
These inconsequential changes appeared after (GrResourceCache2 manages scratch texture - https://codereview.chromium.org/608883003) but persisted even after that CL was reverted.

TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/617103005
2014-10-01 09:47:11 -07:00
fmalita
dbcb5ff125 Add pdf-native textblobshader GM baseline
BUG=skia:2983
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/615853004
2014-10-01 09:19:05 -07:00
robertphillips
92656eaaa8 Add buggy GPU baselines for MultiPictureDraw Sierpinski GM (with bug label)
I am checking in these baseline images even though they are afflicted by a bug (skia:2979).

NOTRY=true
NOTREECHECKS=true
BUG=skia:2979
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/619873003
2014-10-01 08:04:29 -07:00
Justin Novosad
e946f7115c New baselines for image=surface gm
TBR=robertphillips@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/623473002
2014-10-01 10:29:16 -04:00
robertphillips
24e430ff32 Add 8888 & 565 baselines for multipicturedraw Sierpinski GM
TBR=jvanverth@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/614353002
2014-10-01 05:33:25 -07:00
robertphillips
dbe6074a06 Revert of GrResourceCache2 manages scratch texture. (patchset #14 id:260001 of https://codereview.chromium.org/608883003/)
Reason for revert:
Turning bots red:
Nanobench seems to be uniformly failing on Android
(http://108.170.220.21:10117/builders/Perf-Android-Venue8-PowerVR-x86-Release/builds/99/steps/RunNanobench/logs/stdio)

Ubuntu GTX660 32bit is failing in both Debug and Release on GM generation (it appears to be out of memory) (http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/builds/2457/steps/GenerateGMs/logs/stdio)

Original issue's description:
> GrResourceCache2 manages scratch texture.
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3d398c876440deaab39bbf2a9b881c337e6dc8d4

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/611383003
2014-09-30 06:54:17 -07:00
bsalomon
3d398c8764 GrResourceCache2 manages scratch texture.
BUG=skia:
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/608883003
2014-09-30 06:02:23 -07:00
robertphillips
92f7fc4868 Rebaselining Win7 image failures (textblob, verttext2)
Rebaselining these for now and see if they recur.

R=borenet@google.com
TBR=borenet@google.com

BUG=skia:2956

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/600533003
2014-09-29 11:17:58 -07:00
Justin Novosad
cce6bbf494 Adding test suppression for image-surface GM
Test needs to be rebaselined on gpu

TBR=bsalomon

Review URL: https://codereview.chromium.org/602203006
2014-09-26 17:41:28 -04:00
cdalton
9959c21dc7 Rebaseline gm expectations after nvpr text change
BUG=skia:2951
BUG=skia:2954
R=bsalomon@google.com, borenet@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/580943003
2014-09-22 12:26:41 -07:00
jvanverth
f782639a7c Add ignored expectation for https://codereview.chromium.org/563283004.
BUG=skia:2951
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/585943002
2014-09-19 06:46:09 -07:00
cdalton
855d83ff79 Uses a single pre-baked set of paths for drawing nvpr text of a given
typeface. Loads the paths using the driver's glyph loading routines.

Refactors GrPathRange to accept a PathGenerator class that it uses to
lazily initialize its paths. The client code is no longer expected to
initialize the paths in a GrPathRange; instead it must provide a
PathGenerator* instance to createPathRange().

Adds a new createGlyphs() method to GrPathRendering that creates a
range of glyph paths, indexed by glyph id. GrPathRendering implements
createGlyphs() with a PathGenerator that loads glyph paths using the
skia frameworks. GrGLPathRendering uses glMemoryGlyphIndexArrayNV()
instead, when possible, to load the glyph paths.

Removes all GlyphPathRange logic from GrStencilAndCoverTextContext.
It instead uses createGlyphs().

BUG=skia:2939
R=bsalomon@google.com, jvanverth@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/563283004
2014-09-18 13:51:53 -07:00