commit-bot@chromium.org
d611864e67
ARM Skia NEON patches - 32 - Xfermode: 1-pixel NEON modeprocs
...
In some cases, it's easy to provide a NEON version of the 1-pixel modeprocs.
Combined with https://codereview.chromium.org/23724013/ (merged) it allows
up to 35% speed improvement on Xfermodes when aa is non-NULL.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com , reed@google.com , mtklein@google.com , luisjoseromeroesclusa@hotmail.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/104883004
git-svn-id: http://skia.googlecode.com/svn/trunk@12525 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 11:32:27 +00:00
skia.committer@gmail.com
726b97a3c4
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12524 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 07:02:04 +00:00
senorblanco@chromium.org
899b22ab97
Revert "Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource"." until I can sort out the xfermodeimagefilter and tileimagefilter failures.
...
This reverts commit b26725c8c9755415284c34399e76be098868e01a, aka r12522.
BUG=
TBR=reed@google.com
Review URL: https://codereview.chromium.org/107093005
git-svn-id: http://skia.googlecode.com/svn/trunk@12523 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 23:06:07 +00:00
senorblanco@chromium.org
af35920e6d
Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
...
Note: I initially implemented this as a fully-generic SkResizeImageFilter, but then I realized that the dstRect should always be transformed by the filter matrix, but that the srcRect should not (since it's specified relative to the dimensions of the original bitmap). Since this would be confusing for someone attempting to use this as a generic resizing filter, I decided to build the functionality into SkBitmapSource instead.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/106933002
git-svn-id: http://skia.googlecode.com/svn/trunk@12522 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 22:41:53 +00:00
epoger@google.com
c94a9911b1
Update not-reviewed-by-human poppler baselines
...
BUG=skia:1657,skia:1578
TBR=vandebo
These were already annotated as belonging to
https://code.google.com/p/skia/issues/detail?id=1578 ('commit GM actuals
as expectations for all tests, marking them as unreviewed'),
which means they had not been visually reviewed in the first place.
So we have no reason to believe their current results are incorrect
(for all we know, they were wrong before)
For these and all other expectations with the bug1578 annotation, we should
figure out a way to validate them. But that's for another day...
Review URL: https://codereview.chromium.org/107293002
git-svn-id: http://skia.googlecode.com/svn/trunk@12521 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 22:07:08 +00:00
commit-bot@chromium.org
456610717b
Fix refcounting bug for Type1 font usage with more than 255 characters.
...
R=bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/103423003
git-svn-id: http://skia.googlecode.com/svn/trunk@12520 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 21:14:02 +00:00
halcanary@google.com
dbba5a4e97
Fix change src/ports/SkImageDecoder_empty.cpp missed in 103033002
...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/107123002
git-svn-id: http://skia.googlecode.com/svn/trunk@12519 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 20:40:04 +00:00
commit-bot@chromium.org
1b2c1b893a
SkOnce: let f be any functor, update comments
...
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/104433005
git-svn-id: http://skia.googlecode.com/svn/trunk@12518 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 19:20:49 +00:00
epoger@google.com
7787f2128d
expectations/gm/ignored-tests.txt: add links to tracking bugs
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/106643003
git-svn-id: http://skia.googlecode.com/svn/trunk@12516 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:45:18 +00:00
halcanary@google.com
2c7c7ee47d
Big Cleanup: SkBitmapFactory, SkLazyPixelRef, SkImageCache
...
Removed SkBitmapFactory since no clients were using it. New cache
selection mechanism can simply pass a SkDiscardableMemory::Factory
into the SkDiscardablePixelRef if non-default SkDiscardableMemory
should be used. Removed BitmapFactoryTest.
SkDiscardableMemory::Factory interface. Android will need this
functionality in the future inside their BitmapFactory.
Removed SkLazyPixelRef, since it's functionality is now subsumed into
SkDiscardablePixelRef. Removed LazyPixelRef test.
Modified SkDiscardablePixelRef to optionally allow it to use a
SkDiscardableMemory::Factory. This tiny change makes it a replacement
for SkLazyPixelRef. This functioanlity is also necessary for moving
Android over to SkDiscardablePixelRef from SkImageRef in a later CL.
Added a test for this.
SkDecodingImageGenerator::Install can optionally pass a factory in to
SkDiscardablePixelRef.
Removed SkImageCache, SkLruImageCache, and SkPurgeableImageCache.
This functionality can be handled much more cleanly by
SkDiscardableMemory.
New SkDiscardableMemoryPool class to replace SkLruImageCache. In a
later CL, we will replace SkImageRef_GlobalPool (used by android) as
well. This is a concrete implementation of
SkDiscardableMemory::Factory. Added a test for this.
modified gm/factory.cpp to remove dependnce on SkBitmapFactory +
SkLruImageCache. Now uses SkDecodingImageGenerator +
SkDiscardablePixelRef + SkDiscardableMemoryPool.
SkImageDecoder::Target replaces SkBitmapFactory::Target. The
DecodeMemoryToTarget function may disappear in the future.
Moved SkLazyCachingPixelRef::DecodeProc replaces
SkBitmapFactory::DecodeProc. This is a short term change, since
another CL changes SkLazyCachingPixelRef to use SkImageGenerator
instead of DecodeProc.
Modified DrawBitmapRectTest to use SkDiscardablePixelRef instead of
SkLazyPixelRef.
tools/LazyDecodeBitmap.cpp now uses SkDecodingImageGenerator +
SkDiscardablePixelRef instead of a SkBitmapFactory.
bench_pictures uses the Global SkDiscardableMemoryPool instead of a
global gLruImageCache.
R=reed@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/103033002
git-svn-id: http://skia.googlecode.com/svn/trunk@12515 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:31:42 +00:00
jvanverth@google.com
3e0446ccbf
One last rebaseline (I hope)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12514 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:12:47 +00:00
epoger@google.com
62a5ef0a9b
rebaseline_server: add "deep linking" to allow bookmarking of particular views
...
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/104623003
git-svn-id: http://skia.googlecode.com/svn/trunk@12513 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:03:24 +00:00
commit-bot@chromium.org
cc6db406e4
Make sure four_byte_interp benches the entire FourByteInterp call.
...
Relative bench performance still says switch to Fast.
Desktop:
four_byte_interp_slow_256 11.68
four_byte_interp_slow_255 12.11
four_byte_interp_fast_256 7.17
four_byte_interp_fast_255 8.17
N5:
four_byte_interp_slow_256 28.49
four_byte_interp_slow_255 25.08
four_byte_interp_fast_256 19.40
four_byte_interp_fast_255 21.69
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/102053006
git-svn-id: http://skia.googlecode.com/svn/trunk@12512 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 16:43:08 +00:00
jvanverth@google.com
5a1cb5b408
Finish rebaselines for https://codereview.chromium.org/102683002/
...
Review URL: https://codereview.chromium.org/106773002
git-svn-id: http://skia.googlecode.com/svn/trunk@12511 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 16:26:02 +00:00
robertphillips@google.com
28ea0b258e
Update valgrind suppressions for new driver
...
https://codereview.chromium.org/102473003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12510 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 16:23:37 +00:00
epoger@google.com
2682c90860
rebaseline_server: start HTTP server immediately, auto-reload once results are available
...
BUG=skia:1877
(SkipBuildbotRuns)
R=vandebo@chromium.org
Review URL: https://codereview.chromium.org/106453002
git-svn-id: http://skia.googlecode.com/svn/trunk@12509 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 16:05:16 +00:00
robertphillips@google.com
ea4f3dbcf1
Add Windows compilation support to V8 example
...
https://codereview.chromium.org/106163004/
git-svn-id: http://skia.googlecode.com/svn/trunk@12508 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 15:55:00 +00:00
commit-bot@chromium.org
91246b9fc7
Update documentation around drawBitmap and shaders
...
R=reed@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/105823004
git-svn-id: http://skia.googlecode.com/svn/trunk@12507 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 15:43:19 +00:00
halcanary@google.com
dcfebfa823
Fix MacOS build error from 36d08c5c90
...
BUG=
Review URL: https://codereview.chromium.org/105453005
git-svn-id: http://skia.googlecode.com/svn/trunk@12506 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 14:18:07 +00:00
halcanary@google.com
36d08c5c90
SkCachingPixelRef to use SkImageGenerator
...
- Remove SkLazyCachingPixelRef class.
- Refactor unit tests.
BUG=
R=reed@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/84083002
git-svn-id: http://skia.googlecode.com/svn/trunk@12505 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 14:00:03 +00:00
djsollen@google.com
0e9297c7bd
update android build to use SDK API level 19.
...
BUG=1817
Review URL: https://codereview.chromium.org/88223002
git-svn-id: http://skia.googlecode.com/svn/trunk@12504 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 13:57:54 +00:00
commit-bot@chromium.org
44a3877442
V8 and Skia
...
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/93933005
git-svn-id: http://skia.googlecode.com/svn/trunk@12503 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 13:45:19 +00:00
robertphillips@google.com
bd04652cd6
Image rebaselines
...
https://codereview.chromium.org/101313004/
git-svn-id: http://skia.googlecode.com/svn/trunk@12502 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 13:39:47 +00:00
commit-bot@chromium.org
ab1c13864d
Fix compilation with SK_ENABLE_INST_COUNT=1
...
Add INHERITED declarations to class declarations that prevent
compilation with the flag.
Remove SK_DEFINE_INST_COUNT from all class implementations. Instead,
use function-local static variables in the reference count helper
classes to create the global instances to store the needed info. The
accessor functions are defined inline in the helper classes, so
definitions are not needed. The initialization point of the variables
should be as well defined as previously.
Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT
instead. This avoids possible future compilation errors further.
For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member
function to all classes that use SK_DECLARE_INST_COUNT and
SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes
contain public INHERITED typedef. This member function seems to be
compiled away. This shouĺd ensure that part of the compilation errors
are caught earlier.
Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses.
R=robertphillips@google.com , richardlin@chromium.org , bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/98703002
git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 12:08:12 +00:00
commit-bot@chromium.org
000d732ca7
Move non-trivial work in RectBench() to onPreDraw.
...
Saw this on a profile where rects was filtered out. ಠ_ಠ
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/93703003
git-svn-id: http://skia.googlecode.com/svn/trunk@12500 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 12:07:44 +00:00
skia.committer@gmail.com
8491d24bdc
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12499 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 07:02:16 +00:00
bensong@google.com
967b258065
Fixes bench_util's CONFIG_RE to cope with space flexibility.
...
The real "fix" down the road is Joe's ongoing work of switching to JSON.
Review URL: https://codereview.chromium.org/103943004
git-svn-id: http://skia.googlecode.com/svn/trunk@12498 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 01:31:56 +00:00
jvanverth@google.com
498aafadd5
More rebaselines for https://codereview.chromium.org/102683002
...
Review URL: https://codereview.chromium.org/105963002
git-svn-id: http://skia.googlecode.com/svn/trunk@12497 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 00:28:04 +00:00
jvanverth@google.com
2f9f0c08a8
Rebaseline ANGLE for https://codereview.chromium.org/102683002 .
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12496 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 23:46:30 +00:00
jvanverth@google.com
e4b6e38b04
Update ignored tests.
...
BUG=
Review URL: https://codereview.chromium.org/105793002
git-svn-id: http://skia.googlecode.com/svn/trunk@12495 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 23:16:40 +00:00
commit-bot@chromium.org
f543fd9e8c
Simplify matrix generation for convex path renderer
...
Addresses precision issues which were leading to asserts in Debug
R=bsalomon@google.com , mtklein@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/102683002
git-svn-id: http://skia.googlecode.com/svn/trunk@12494 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 21:33:08 +00:00
senorblanco@chromium.org
c53f15c3bc
Nit to self: NULL is not false.
...
R=mtklein@google.com , mtklein
BUG=
Review URL: https://codereview.chromium.org/105423002
git-svn-id: http://skia.googlecode.com/svn/trunk@12493 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 20:55:24 +00:00
commit-bot@chromium.org
c84728d72a
Changed maxInputCount for exact inputCount
...
Processing still had issue when the number of inputs was 0, so I changed my previous fix from a maximum input count to an exact input count. -1 is used when the input count isn't fixed (but still has to be a non-negative number).
BUG=
R=senorblanco@chromium.org , reed@google.com , sugoi@google.com , bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/100803004
git-svn-id: http://skia.googlecode.com/svn/trunk@12492 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 20:07:47 +00:00
scroggo@google.com
a0b266d817
Remove deprecated setPrefConfigTable.
...
Safe once its only caller (in Android) has been updated.
BUG=skia:1874
R=reed@google.com
Review URL: https://codereview.chromium.org/99473004
git-svn-id: http://skia.googlecode.com/svn/trunk@12491 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 19:56:31 +00:00
senorblanco@chromium.org
bdb677a277
Do proper NEON checking for SkBoxBlur procs.
...
TBR=mtklein
BUG=
Review URL: https://codereview.chromium.org/98373003
git-svn-id: http://skia.googlecode.com/svn/trunk@12490 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 19:53:41 +00:00
scroggo@google.com
f78cdb4ba9
Force linking for skhello.
...
Otherwise encoders are stripped and the program produces nothing.
git-svn-id: http://skia.googlecode.com/svn/trunk@12487 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 18:34:58 +00:00
senorblanco@chromium.org
1d62f42e21
Implement a NEON version of the RGBA gaussian blur. This shows a 9-15% speedup on Nexus-10.
...
R=mtklein@google.com , mtklein
before:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 33063.23
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 32800.25
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 33017.88
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 32743.35
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 21024.04
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 22904.15
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 18738.08
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 18798.98
after:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 30180.96
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 29861.90
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 30178.98
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 29911.25
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 19344.35
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 19957.07
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 17158.84
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 17330.73
Review URL: https://codereview.chromium.org/99933004
git-svn-id: http://skia.googlecode.com/svn/trunk@12486 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 18:19:45 +00:00
commit-bot@chromium.org
db6f36e784
Remove problematic GrContext thread local instance counting
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/104893002
git-svn-id: http://skia.googlecode.com/svn/trunk@12485 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 17:55:15 +00:00
commit-bot@chromium.org
cd3b15ca63
Fixed bad bitmap size crashes
...
There were 2 issues :
1 ) If the size of an SkBitmap's underlying SkPixelRef's alocated memory is too small to fit the bitmap, then the deserialization will now check this and set an error appropriately.
2 ) If a device fails to allocate its pixels, the device will be deleted and NULL will be returned to avoid attempting to draw on a bad device.
BUG=
R=senorblanco@chromium.org , reed@google.com , sugoi@google.com , halcanary@google.com , mtklein@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/92793002
git-svn-id: http://skia.googlecode.com/svn/trunk@12484 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 17:06:49 +00:00
vandebo@chromium.org
2b7d463990
Rebaseline after r12473
...
Review URL: https://codereview.chromium.org/104783003
git-svn-id: http://skia.googlecode.com/svn/trunk@12483 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 16:52:15 +00:00
bungeman@google.com
7fd1f50bfb
Put all of SkPostConfig.h inside top level ifdef.
...
Due to inconsistent indentation, the last third of this header is outside
of the top level ifdef header guard. This CL fixes that, as well as
makes the indents more consistent to avoid this issue in the future.
R=mtklein@google.com , reed@google.com
Review URL: https://codereview.chromium.org/102153002
git-svn-id: http://skia.googlecode.com/svn/trunk@12482 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 16:40:42 +00:00
commit-bot@chromium.org
1d02264b41
Remove cityhash.gyp
...
According to https://code.google.com/p/skia/issues/detail?id=1286 it should be fine to remove this empty gyp file now.
BUG=None
TEST=None
R=epoger@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/102603004
git-svn-id: http://skia.googlecode.com/svn/trunk@12481 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 16:30:03 +00:00
jvanverth@google.com
d9288322ad
Last set of rebaselines for https://codereview.chromium.org/99993002
...
BUG=
Review URL: https://codereview.chromium.org/104733002
git-svn-id: http://skia.googlecode.com/svn/trunk@12480 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 15:04:11 +00:00
commit-bot@chromium.org
7cc93bcc4b
Make SkTInternalLList::validate validate all nodes
...
Make SkTInternalLList::validate validate all nodes, including the
first one.
R=mtklein@google.com , bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/104553002
git-svn-id: http://skia.googlecode.com/svn/trunk@12479 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 14:51:31 +00:00
commit-bot@chromium.org
1735d6696e
Fix incremental visibility filter handling.
...
When drawing incrementally, SkDebugCanvas can end up applying the
visibility overlay multiple times (resulting in a fade-to-white effect).
The CL also includes a minor/unrelated SkDebugCanvas cleanup.
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/103083004
git-svn-id: http://skia.googlecode.com/svn/trunk@12478 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 13:42:46 +00:00
skia.committer@gmail.com
6e515d67d2
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12477 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 07:02:26 +00:00
commit-bot@chromium.org
e76a3225d5
SkSplay and SkUnsplay work on any uint32_t, not just SkPMColor.
...
BUG=
R=reed@google.com , tfarina@chromium.org
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/102813002
git-svn-id: http://skia.googlecode.com/svn/trunk@12476 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 00:42:07 +00:00
jvanverth@google.com
fe9d8a44d6
Rebaseline GMs for https://codereview.chromium.org/99993002/
...
Review URL: https://codereview.chromium.org/102953002
git-svn-id: http://skia.googlecode.com/svn/trunk@12475 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-03 21:45:59 +00:00
jvanverth@google.com
23d005669b
Ignore colortype_msaa4 (for https://codereview.chromium.org/99993002 )
...
Review URL: https://codereview.chromium.org/102713003
git-svn-id: http://skia.googlecode.com/svn/trunk@12474 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-03 21:30:16 +00:00
commit-bot@chromium.org
7542dc8897
[PDF] Fixes the cases where SkPDFDevice::finishContentEntry is called with empty content.
...
There are some cases (like drawing a completely transparent image) where the code tries to finish a content entry with no content and an xfermode other than clear. This makes those cases work correctly.
This is likely what was happening in chromium:316546, but it wasn't clear what the core problem was. desk_techcrunch.skp tripped a debug only assert that exposed the core issue.
BUG=skia:1868,chromium:316546
R=reed@google.com , bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/92453002
git-svn-id: http://skia.googlecode.com/svn/trunk@12473 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-03 21:08:46 +00:00