commit-bot@chromium.org
8e13a159f3
Fixed cross compilation with mingw.
...
Tested in Mozilla source tree. I tried to use skia build system, but it's up to the task for cross compilation.
SkHRESULT.cpp - Use proper file name (that matters on case sensitive OSes)
SkAtomics_win.h - Don't use pragma intrinsic on GCC (this causes massive warnings)
SkOSFile_win.cpp - This one is tricky. GCC doesn't allow (void*) casts in template argument constants and INVALID_HANDLE_VALUE looks like this:
((HANDLE)(LONG_PTR)-1)
where HANDLE is typedefed to void*. Changed the code to use LONG_PTR as template argument and cast it when needed.
BUG=skia:
R=bungeman@google.com , reed@google.com
Author: cjacek@gmail.com
Review URL: https://codereview.chromium.org/198643004
git-svn-id: http://skia.googlecode.com/svn/trunk@13862 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 19:28:00 +00:00
commit-bot@chromium.org
bdc772ebbe
Add quiet mode to lua_pictures.
...
This allows:
for i in {0..5}; do
out/Debug/lua_pictures -q --skpPath $SKP_PATH -l $SCRIPT --modulo $i 6
done
to generate output similar to what telemetry will generate.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/197793007
git-svn-id: http://skia.googlecode.com/svn/trunk@13861 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 19:23:17 +00:00
senorblanco@chromium.org
b7b7eb32f4
Fix accessBitmap() with deferred clear, GPU path.
...
When accessBitmap() is called on a GPU device which has deferred clear,
and no drawing has been done, force the clear before returning the
bitmap.
This is covered by the top right test case in the imagefilterscropexpand
GM, where an offset image filter is drawn but the resulting bitmap is
cropped out, resulting in no drawing to the offscreen. It should be
empty, but without this fix it results in garbage (previous scratch
texture contents).
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/204903002
git-svn-id: http://skia.googlecode.com/svn/trunk@13860 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 18:24:04 +00:00
commit-bot@chromium.org
f5e315ccf1
add --writeChecksumBasedFilenames flag to render_pictures
...
BUG=skia:1455,skia:2230
R=robertphillips@google.com , robertphillips@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/202983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13859 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 17:26:07 +00:00
commit-bot@chromium.org
fffb2cd463
Revert of SkPaint: eliminate some dead bytes in 64-bit build. ( https://codereview.chromium.org/203203003/ )
...
Reason for revert:
Causing RunTest failures on Android.
Original issue's description:
> SkPaint: eliminate some dead bytes in 64-bit build.
>
> + memcpy-based copy constructor was hiding this gap -> manual copy constructor.
> + Split tests for finer-grained failures.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13856
R=reed@google.com , mtklein@google.com , mtklein@chromium.org
TBR=mtklein@chromium.org , mtklein@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/204543002
git-svn-id: http://skia.googlecode.com/svn/trunk@13858 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 14:36:29 +00:00
commit-bot@chromium.org
2aae29832a
Whitespace change to verify that buildbot scripts are fixed.
...
BUG=skia:2312
NOTRY=true
NOTREECHECKS=true
R=rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/199273006
git-svn-id: http://skia.googlecode.com/svn/trunk@13857 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 14:22:18 +00:00
commit-bot@chromium.org
fa4dc2c4cb
SkPaint: eliminate some dead bytes in 64-bit build.
...
+ memcpy-based copy constructor was hiding this gap -> manual copy constructor.
+ Split tests for finer-grained failures.
BUG=skia:
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/203203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13856 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 11:42:34 +00:00
skia.committer@gmail.com
2002d881e8
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13855 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 03:02:22 +00:00
senorblanco@chromium.org
3604853488
Rebaseline imagefiltersscaled GM.
...
Rebaseline imagefiltersscaled GM for new test cases added in
https://code.google.com/p/skia/source/detail?r=13798 .
TBR=jcgregorio@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/203093004
git-svn-id: http://skia.googlecode.com/svn/trunk@13854 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 17:59:47 +00:00
commit-bot@chromium.org
70512af9dd
Add a means of extracting active operations from SkPicture
...
For the "pull forward" task I will be comparing the two cases:
analyze the whole skp and use the BBH information
analyze only the active portion of the skp
In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it.
Committed: http://code.google.com/p/skia/source/detail?r=13836
R=reed@google.com , bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/195793010
git-svn-id: http://skia.googlecode.com/svn/trunk@13853 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 17:45:32 +00:00
commit-bot@chromium.org
af5346a39c
Add reg test for http://crbug.com/348821
...
BUG=348821
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/189373008
git-svn-id: http://skia.googlecode.com/svn/trunk@13852 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 17:38:34 +00:00
commit-bot@chromium.org
e5957f67d0
update comment on setShader to clarify alpha-bitmap behavior in bitmapshaders
...
BUG=skia:2293
R=bsalomon@google.com , yunchao.he@intel.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/203203005
git-svn-id: http://skia.googlecode.com/svn/trunk@13851 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 16:28:12 +00:00
robertphillips@google.com
14bdd527ee
Revert of r13836 due to Chromium cc_unittests failures
...
https://codereview.chromium.org/203333005/
git-svn-id: http://skia.googlecode.com/svn/trunk@13850 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 13:56:09 +00:00
commit-bot@chromium.org
92362383a4
Remove SkCanvas matrix ops return value.
...
The internal SkMatrix ops can no longer fail -> we can remove the bool
return value.
R=bsalomon@google.com , reed@google.com , robertphillips@google.com , scroggo@google.com , fmalita@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/200223008
git-svn-id: http://skia.googlecode.com/svn/trunk@13849 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 12:51:48 +00:00
commit-bot@chromium.org
2077427227
Put SimpleOffsetFilter on heap.
...
Effects want to live on the heap!
BUG=skia:
R=senorblanco@chromium.org , dominikg@chromium.org , scroggo@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/203273002
git-svn-id: http://skia.googlecode.com/svn/trunk@13848 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 10:28:27 +00:00
commit-bot@chromium.org
a1dfa0cf05
Slightly faster quadtree searching
...
BUG=skia:2125
R=tomhudson@google.com , mtklein@google.com , robertphillips@google.com , reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/196383026
git-svn-id: http://skia.googlecode.com/svn/trunk@13847 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 09:07:27 +00:00
commit-bot@chromium.org
341241d567
short-term fix for RunToolSelfTests
...
BUG=skia:2307
NOTREECHECKS=True
NOTRY=True
R=bensong@google.com
TBR=bensong
Author: epoger@google.com
Review URL: https://codereview.chromium.org/202203010
git-svn-id: http://skia.googlecode.com/svn/trunk@13846 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 05:41:33 +00:00
skia.committer@gmail.com
db0c875377
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13845 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 03:02:11 +00:00
senorblanco@chromium.org
d9cdff67a4
Fix GPU displacement with expanding crop rects.
...
Fix GPU displacement with expanding crop rects, and re-enable the
imagefilterscropexpand GM. There were two bugs: the result texture was
being created at input color bitmap size, not the cropped bounds size,
and the matrix in GrContext was not being set to identity before draw.
R=junov@chromium.org
Review URL: https://codereview.chromium.org/195973007
git-svn-id: http://skia.googlecode.com/svn/trunk@13844 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 23:41:40 +00:00
commit-bot@chromium.org
1301bf3abf
add initial scraper for dashing
...
BUG=skia:
R=bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/196603027
git-svn-id: http://skia.googlecode.com/svn/trunk@13843 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 23:09:47 +00:00
robertphillips@google.com
e4ff3e6fe8
Update SkXPSDevice.cpp too
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13842 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 22:34:32 +00:00
robertphillips@google.com
158001d6fc
Windows build fix
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13841 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 22:09:34 +00:00
commit-bot@chromium.org
a713f9c6f6
add new readPixels with direct memory parameters
...
BUG=skia:
R=scroggo@google.com , bsalomon@google.com , robertphillips@google.com , fmalita@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/199413013
git-svn-id: http://skia.googlecode.com/svn/trunk@13840 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 21:31:26 +00:00
commit-bot@chromium.org
f338d7c860
Add nine patch type to SkRRect.
...
BUG=skia:2181
Committed: http://code.google.com/p/skia/source/detail?r=13833
R=robertphillips@google.com , reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/196343015
git-svn-id: http://skia.googlecode.com/svn/trunk@13839 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 21:17:30 +00:00
commit-bot@chromium.org
b1bcb21631
gen_bench_expectations to generate bench expectations files.
...
BUG=skia:2225
NOTRY=true
R=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/201423002
git-svn-id: http://skia.googlecode.com/svn/trunk@13838 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 21:16:29 +00:00
commit-bot@chromium.org
bab3fc4c90
Revert of Add nine patch type to SkRRect. ( https://codereview.chromium.org/196343015/ )
...
Reason for revert:
causes tests to have infinite loop
Original issue's description:
> Add nine patch type to SkRRect.
>
> BUG=skia:2181
>
> Committed: http://code.google.com/p/skia/source/detail?r=13833
R=robertphillips@google.com , reed@google.com
TBR=reed@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2181
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/202163004
git-svn-id: http://skia.googlecode.com/svn/trunk@13837 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 19:47:40 +00:00
commit-bot@chromium.org
ecb745dba7
Add a means of extracting active operations from SkPicture
...
For the "pull forward" task I will be comparing the two cases:
analyze the whole skp and use the BBH information
analyze only the active portion of the skp
In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it.
R=reed@google.com , bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/195793010
git-svn-id: http://skia.googlecode.com/svn/trunk@13836 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 18:11:57 +00:00
commit-bot@chromium.org
4ef54f8d72
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG -- dead code
...
BUG=skia:
R=halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/201973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13834 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 17:03:18 +00:00
commit-bot@chromium.org
761b8e5572
Add nine patch type to SkRRect.
...
BUG=skia:2181
R=robertphillips@google.com , reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/196343015
git-svn-id: http://skia.googlecode.com/svn/trunk@13833 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 15:39:01 +00:00
robertphillips@google.com
1c556dba15
Reverting r13831 (Add a means of extracting active operations from SkPicture) due to Mac compiler issue
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13832 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 15:10:02 +00:00
robertphillips@google.com
0b23f9e15f
Add a means of extracting active operations from SkPicture
...
https://codereview.chromium.org/195793010/
git-svn-id: http://skia.googlecode.com/svn/trunk@13831 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 14:56:13 +00:00
commit-bot@chromium.org
d1c85d2920
rebaseline_server: make intermediate JSON specify base urls for diff images
...
BUG=skia:1919,skia:2230
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/196533021
git-svn-id: http://skia.googlecode.com/svn/trunk@13830 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 14:22:02 +00:00
bungeman@google.com
1d1f2347d3
SkFontStyleSet_DirectWrite::getStyle to properly handle NULL out params.
...
R=reed@google.com
Review URL: https://codereview.chromium.org/201213003
git-svn-id: http://skia.googlecode.com/svn/trunk@13829 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 14:04:50 +00:00
commit-bot@chromium.org
be4825c873
Fix result order reliance
...
The old tests presumed result order in a way was safe because SkPicture was sorting the paint calls.
This fixes the tests to not check result ordering, just presence
BUG=skia:
R=robertphillips@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/197813011
git-svn-id: http://skia.googlecode.com/svn/trunk@13828 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 12:14:48 +00:00
commit-bot@chromium.org
7ae3bc7ffb
Change tilegrid test to test it directly, rather than through SkPicture
...
This is necessary because it makes assumptions that picture will draw all the rects that match the grids, which may not hold if picture decides to improve the accuracy of the results.
BUG=skia:2125
R=tomhudson@google.com , mtklein@google.com , reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/199083004
git-svn-id: http://skia.googlecode.com/svn/trunk@13827 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 10:51:44 +00:00
commit-bot@chromium.org
949b9986de
Fast implementation of QuadTree
...
Rewritten to avoid memory allocations.
BUG=skia:2242
R=tomhudson@google.com , mtklein@google.com , reed@google.com , robertphillips@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/187233002
git-svn-id: http://skia.googlecode.com/svn/trunk@13826 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 10:38:34 +00:00
skia.committer@gmail.com
eb849e5fd1
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13825 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 03:02:17 +00:00
commit-bot@chromium.org
42b08932e8
add NewRasterDirect for creating a canvas drawing to pre-allocated pixels
...
R=reed@google.com
TBR=scroggo@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/196923004
git-svn-id: http://skia.googlecode.com/svn/trunk@13824 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 02:13:07 +00:00
robertphillips@google.com
0f03f43e44
Move SkNoSaveLayerCanvas.h to include/utils
...
https://codereview.chromium.org/197243005
git-svn-id: http://skia.googlecode.com/svn/trunk@13823 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-16 21:59:11 +00:00
commit-bot@chromium.org
145d1c0fdc
Proposed SkCanvas API for preLoading textures to VRAM v2.0
...
This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/ ). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)).
Committed: http://code.google.com/p/skia/source/detail?r=13810
R=reed@google.com , bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/197123003
git-svn-id: http://skia.googlecode.com/svn/trunk@13822 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-16 19:46:36 +00:00
senorblanco@chromium.org
beca2ee3ec
Rebaselining stragglers.
...
TBR=halcanary@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/197283024
git-svn-id: http://skia.googlecode.com/svn/trunk@13821 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-15 14:20:35 +00:00
skia.committer@gmail.com
f0f9f5f904
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13820 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-15 03:02:32 +00:00
senorblanco@chromium.org
708dd94665
More imagefiltersclipped and displacement rebaselines.
...
TBR=halcanary@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/197283022
git-svn-id: http://skia.googlecode.com/svn/trunk@13819 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-15 00:37:33 +00:00
commit-bot@chromium.org
68bda15ccf
Removes bench expectations files. New place is skia-autogen svn repo. See https://codereview.chromium.org/196653010/
...
BUG=skia:2225
NOTRY=true
NOTREECHECKS=true
TBR=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/199143004
git-svn-id: http://skia.googlecode.com/svn/trunk@13818 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 23:42:16 +00:00
commit-bot@chromium.org
e78f7cfced
change tooBitForLCD to compare against linear size of the text, not the area
...
BUG=skia:
R=bungeman@google.com , alokp@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/200643003
git-svn-id: http://skia.googlecode.com/svn/trunk@13817 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 22:59:05 +00:00
senorblanco@chromium.org
e01cdb3a20
New baselines for displacement, imagefiltersclipped GMs.
...
TBR=halcanary@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/196383021
git-svn-id: http://skia.googlecode.com/svn/trunk@13816 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 21:55:15 +00:00
commit-bot@chromium.org
0bed43c926
Get correct text metrics for distance fields, and fix dropouts due to thin features.
...
BUG=skia:2173
R=robertphillips@google.com , reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/200423003
git-svn-id: http://skia.googlecode.com/svn/trunk@13815 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 21:22:38 +00:00
commit-bot@chromium.org
1e7ee999d4
fix a leak
...
R=sugoi@chromium.org , bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/195763025
git-svn-id: http://skia.googlecode.com/svn/trunk@13814 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 21:22:22 +00:00
reed@google.com
69e6463792
don't reference config() -- use colorType() instead
...
BUG=skia:
Review URL: https://codereview.chromium.org/200853002
git-svn-id: http://skia.googlecode.com/svn/trunk@13813 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 20:48:05 +00:00
commit-bot@chromium.org
2ff20aba21
Suppress imagefilterscropexpand GM temporarily to fix Win Debug failures.
...
NOTREECHECKS=true
NOTRY=true
R=halcanary@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/200703002
git-svn-id: http://skia.googlecode.com/svn/trunk@13812 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 19:02:15 +00:00