Florin Malita
c13bc571d3
Fix SkTextBlob offset semantics.
...
Implement proper x/y drawTextBlob() handling by plumbing a
drawPosText() offset parameter (to act as an additional glyph pos
translation) throughout the device layer.
The new offset superceeds the existing constY, with a minor semantic
tweak: whereas previous implementations were ignoring constY in 2D
positioning mode (scalarsPerGlyph == 2), now the offset is always
observed, in all positioning modes. We can do this because existing
drawPosText() clients always pass constY == 0 for full positioning mode.
R=reed@google.com , jvanverth@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/605533002
2014-09-26 10:33:37 -04:00
piotaixr
2cce421bdf
Replace a forgotten call to SkImage::draw() by SkCanvas::drawImageRect()
...
BUG=skia:2947
R=reed@google.com , junov@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/599203007
2014-09-26 07:10:38 -07:00
egdaniel
89af44a0f1
Split GrDrawState and GrOptDrawState into separate classes and remove base class.
...
Besides splitting the two classes, there are no logical changes here and mostly moving code around.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/597323002
2014-09-26 06:15:04 -07:00
tfarina
fbe8d890ce
Reinitialize monit to changes take effect.
...
Otherwise changes made to the configuration won't take effect when they
are synced.
BUG=None
TEST=None
R=jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/602293002
2014-09-26 06:10:00 -07:00
borenet
8fb7b79de8
Update SKP version to 112
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/604983003
2014-09-25 21:25:26 -07:00
senorblanco
91c395af69
Fix SkTableColorFilter deserialization validation.
...
Broken in https://skia.googlesource.com/skia/+/9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187 .
R=reed@google.com
TBR=reed@google.com
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/604873004
2014-09-25 15:51:35 -07:00
piotaixr
d52893cfc8
Add doc on SkCanvas::drawImage*() methods
...
BUG=skia:2947
R=junov@chromium.org , reed@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/595043002
2014-09-25 14:39:40 -07:00
piotaixr
90a36e5feb
Make SkImage::draw() private
...
BUG=skia:2947
R=junov@chromium.org , reed@google.com , bsalomon@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/608623002
2014-09-25 14:30:57 -07:00
Mike Klein
587c5a2b89
Seems that some of our compliers can't infer this type, though most can.
...
BUG=skia:
Review URL: https://codereview.chromium.org/603263002
2014-09-25 15:07:55 -04:00
mtklein
610a015fda
Remove SkPaint dirty bits.
...
fDirtyBits is only used by SkPaint::FlatteningTraits, which in turn was
only used as a smaller, faster format to flatten paints in-memory to dedup
them in the old picture backend.
SkRecord obsoleted all this. Neither flatten()/unflatten() (disk format)
nor FlatteningTraits is used anywhere performance or size matters.
Here I revert the deduping code back to using the disk format for flattened paints.
We stil do have to flatten and unflatten paints while coverting from SkRecord
backend to the old backend, so we can't just delete this all yet, but any
faithful round trip flatten()/unflatten() pair will be fine, however slow.
NOTRY=true
BUG=skia:
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/604813003
2014-09-25 11:57:53 -07:00
piotaixr
b5fae93d72
SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas
...
BUG=skia:2947
Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08
R=junov@chromium.org , reed@google.com , bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/583453002
2014-09-24 13:03:30 -07:00
senorblanco
0f7197bc0d
Fix SkXfermode deserialization.
...
Validation was failing due to an inverted test condition.
BUG=417266
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/596333002
2014-09-24 11:09:38 -07:00
bungeman
7b09aab713
Correct glyph with non-bmp from typeface on Mac.
...
CTFontGetGlyphsForChars puts the glyph id at the index of the lead
surrogate as is documented in comments, but the code is looking at
the index of the trail surrogate.
BUG=skia:2960
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/596413002
2014-09-24 11:04:41 -07:00
borenet
2456b7681a
Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas (patchset #9 id:160001 of https://codereview.chromium.org/583453002/ )
...
Reason for revert:
Broke ChromiumOS Ozone builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio
Reverting to unblock DEPS roll.
Original issue's description:
> SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas
>
> BUG=skia:2947
>
> Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08
R=junov@chromium.org , reed@google.com , bsalomon@google.com , piotaixr@chromium.org
TBR=bsalomon@google.com , junov@chromium.org , piotaixr@chromium.org , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2947
Author: borenet@google.com
Review URL: https://codereview.chromium.org/598133002
2014-09-24 11:03:35 -07:00
egdaniel
d632ea4b9e
Use OptDrawState instead of DrawState when flushing state in GrGpuGL
...
BUG=skia:
R=bsalomon@google.com , joshualitt@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/599963002
2014-09-24 10:30:13 -07:00
mtklein
eee606c7bf
Swap iteration order in TileGrid::insert().
...
Was looking at performance here (it's the record hotspot) and noticed we
iterate through the grid out of order. This is a tiny little thing, but it's
probably orthogonal to any other performance improvements we'll make in here.
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/598933004
2014-09-24 08:59:37 -07:00
robertphillips
30d2cc6ff4
Update layer hoisting code to correctly render sub-picture layers
...
The prior code assumed all layers came from a single picture.
BUG=skia:2315
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/595543002
2014-09-24 08:52:19 -07:00
Brian Salomon
34a9895baf
Revert "Use draw buffer for texture copy impl."
...
This reverts commit e3d4bf234a
2014-09-24 11:41:24 -04:00
mtklein
dc5bbab138
Have nanobench --verbose mode always just print integer nanoseconds.
...
Don't know that anyone but me is using this. Speak up now!
BUG=skia:
NOTREECHECKS=true
R=mtklein@google.com , tfarina@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/599913002
2014-09-24 06:34:09 -07:00
borenet
e33985a56d
Revert "Add support for EGL on linux"
...
This reverts commit 1cea736c32R=bsalomon@google.com , djsollen@google.com
TBR=bsalomon, djsollen
NOTRY=true
BUG=skia:
Author: borenet@google.com
Review URL: https://codereview.chromium.org/599493003
2014-09-24 05:31:07 -07:00
borenet
6915f7f849
Update SKP version to 110
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/595203002
2014-09-23 21:22:12 -07:00
derekf
1cea736c32
Add support for EGL on linux
...
Allow setting skia_egl=1 to build skia against EGL instead of GLX on unix
R=bsalomon@google.com , djsollen@google.com
Author: derekf@osg.samsung.com
Review URL: https://codereview.chromium.org/543363004
2014-09-23 15:17:36 -07:00
piotaixr
432789972c
SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas
...
BUG=skia:2947
R=junov@chromium.org , reed@google.com , bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/583453002
2014-09-23 14:10:50 -07:00
Mike Klein
271a030f5d
We need to adjust the bounds of clip ops with SaveLayer paints too.
...
Before this CL, SkRecord only adjusted the bounds of draw ops for SaveLayers' paints.
That worked fine, but as a final step we intersect the bounds of draw ops with the
bounds of the current clip, essentially undoing all that work.
I think the right fix here is to also adjust the bounds of the clip ops.
BUG=skia:2957, 415468
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/595953002
2014-09-23 15:28:38 -04:00
egdaniel
f64596d415
Remove unused fRequiresVertexShader data member from OptDrawState
...
BUG=skia:
R=jvanverth@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/578323003
2014-09-23 11:04:54 -07:00
joshualitt
b0a8a377f8
Patch to create a distinct geometry processor. The vast majority of this patch
...
is just a rename. The meat is in GrGeometryProcessor, GrProcessor,
GrGL*Processor, GrProcessorStage, Gr*BackendProcessorFactory,
GrProcessUnitTestFactory, and the builders
BUG=skia:
R=bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/582963002
2014-09-23 09:50:21 -07:00
mtklein
e51ac563de
Remove underscores from mode identifiers.
...
Underscore is used as a field separator sometimes when parsing the task
name into a list of config, mode, etc. (This itself is dumb and TODO(mtklein): fix.)
Underscores in the field names will really mess that up, both in directories generated
from human-mode -w, and in the .json file.
BUG=skia:
R=jcgregorio@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/599503002
2014-09-23 09:20:14 -07:00
bsalomon
e3d4bf234a
Use draw buffer for texture copy impl.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/589143004
2014-09-23 09:15:03 -07:00
bsalomon
cd523ebe2b
Use uniform color/coverage inputs when path rendering.
...
BUG=skia:2954
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/600483002
2014-09-23 08:19:00 -07:00
egdaniel
033ea7f2ad
Fix inputCoverageIsUsed bug in GrGLProgramDesc
...
BUG=skia:
R=joshualitt@chromium.org
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/593803003
2014-09-23 08:14:13 -07:00
junov
f23809101e
Adding support for GL_CHROMIUM_copy_texture, part 1
...
Part 1 of 2. This change just adds the gl API entrypoint
so that the chromium/ganesh bindings can set it. Once
the chromium part is landed, we will add full support for
the extension
BUG=crbug.com/415100
R=bsalomon@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/594663002
2014-09-23 07:30:09 -07:00
borenet
d39c191e28
Update SKP version to 109
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/594783002
2014-09-22 21:33:08 -07:00
jvanverth
76ce81e5e6
Fix SDF font positions when using global scale.
...
Also fixes a crash in the dftext GM when using SampleApp,
and adds new test case in dftext.
BUG=skia:2928
R=joshualitt@google.com , egdaniel@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/588223002
2014-09-22 14:26:53 -07:00
egdaniel
c06482494d
Calculate Primary and Secondary output types in the GrOptDrawState
...
Follow up CL to https://codereview.chromium.org/545693004/
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/554833002
2014-09-22 13:17:03 -07:00
egdaniel
ae444965c4
Change GrGLProgramDesc header to have DoPathRendering flag instead of RequiresVertexShader
...
Also update GLProgramTests to fix bug where it would incorrectly try to PathRendering when we did
not want to.
BUG=skia:
R=bsalomon@google.com , joshualitt@chromium.org
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/586793002
2014-09-22 12:29:52 -07:00
cdalton
9959c21dc7
Rebaseline gm expectations after nvpr text change
...
BUG=skia:2951
BUG=skia:2954
R=bsalomon@google.com , borenet@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/580943003
2014-09-22 12:26:41 -07:00
bungeman
a85511adc0
Don't try to scale embedded bitmaps.
...
If a font is bitmap only we need to scale a bitmap to obtain
the requested size if there isn't an exact match. If a font has
embedded bitmaps then these bitmaps should never be scaled by Skia.
Allow FreeType to do the scaling (as requested by the font).
BUG=chromium:408059
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/596513002
2014-09-22 12:24:41 -07:00
bsalomon
8d034a154f
Don't flush on read/write pixels unless necessary
...
BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/150723b9298772a5096bec7acd2999c5c9d66239
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/586073002
2014-09-22 12:21:08 -07:00
mtklein
ee902cd4f4
Make a flipped fDirtyBit always mean "this field is not the default".
...
Haven't been able to measure any perf effect, so I figure I'll let the bots have at it.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/595583003
2014-09-22 11:40:33 -07:00
reed
baae2f1aa2
remove flags that now live in chrome's SkUserConfig.h
...
NOTRY=True
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/591133003
2014-09-22 10:34:41 -07:00
jcgregorio
c0a77553f7
Fix typo in experimental/webtry/DESIGN.md.
...
R=tfarina@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/593723003
2014-09-22 10:33:00 -07:00
joshualitt
0125847c16
Proposed fix for small bug in gpu conical gradients
...
BUG=skia:
R=bsalomon@google.com , egdaniel@google.com , senorblanco@chromium.org
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/593443002
2014-09-22 10:29:30 -07:00
bsalomon
4401a1f7d6
Revert of Don't flush on read/write pixels unless necessary (patchset #2 id:20001 of https://codereview.chromium.org/586073002/ )
...
Reason for revert:
Breaking the tree
Original issue's description:
> Don't flush on read/write pixels unless necessary
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/150723b9298772a5096bec7acd2999c5c9d66239
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/594543004
2014-09-22 09:12:11 -07:00
bsalomon
150723b929
Don't flush on read/write pixels unless necessary
...
BUG=skia:2889
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/586073002
2014-09-22 08:17:02 -07:00
reed
4a8126e7f8
Introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/ )"
...
This reverts commit 29c857d0f3reed@google.com
Review URL: https://codereview.chromium.org/588143004
2014-09-22 07:29:03 -07:00
piotaixr
a29b5d8430
Cleaning includes in SkImage-related files
...
BUG=skia:2948
R=junov@chromium.org , tfarina@chromium.org , reed@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/586853003
2014-09-22 06:01:37 -07:00
borenet
a392c9d423
Update SKP version to 108
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/586403002
2014-09-21 20:37:57 -07:00
reed
29c857d0f3
Revert of introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/ )
...
Reason for revert:
Broke call site in WebKit
Original issue's description:
> introduce Props to surface (work in progress)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3716fd067a5621bb94a6cb08d72afec8bf3aceda
R=robertphillips@google.com , bsalomon@google.com , jvanverth@google.com , bungeman@google.com , fmalita@google.com , vangelis@chromium.org , reed@google.com
TBR=bsalomon@google.com , bungeman@google.com , fmalita@google.com , jvanverth@google.com , reed@google.com , robertphillips@google.com , vangelis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/583773004
2014-09-21 10:25:07 -07:00
reed
3716fd067a
introduce Props to surface (work in progress)
...
BUG=skia:
R=robertphillips@google.com , bsalomon@google.com , jvanverth@google.com , bungeman@google.com , fmalita@google.com , vangelis@chromium.org , reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/551463004
2014-09-21 09:39:55 -07:00
borenet
00a138c542
Update SKP version to 107
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/585313002
2014-09-20 21:15:07 -07:00
