mtklein
e4a712b665
GN: just new deps
...
These just are the DEPS changes from the previous GN CL, each rolled up to head.
I've removed the hooks to fetch GN and Clang... will have to figure out how to
deal with .gclient files in different places later.
BUG=skia:5452
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087403002
Review-Url: https://codereview.chromium.org/2087403002
2016-06-23 05:56:18 -07:00
rmistry
9afccaaf8e
Reland of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2087913003/ )
...
Reason for revert:
Will watch this after it is in.
Original issue's description:
> Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ )
>
> Reason for revert:
> Reverting due to purple trybots in https://codereview.chromium.org/2087343002/
>
> We will have to investigate..
>
> Original issue's description:
> > add a Chrome builder to the CQ
> >
> > This appears to be the fastest Chrome builder, averaging 8-9 minutes.
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
> >
> > Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d
>
> TBR=reed@google.com ,mtklein@google.com,mtklein@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1afb8f8965b0549525c1ad8d8baa885ccdb48f6d
TBR=reed@google.com ,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2096613002
2016-06-23 04:16:38 -07:00
msarett
949999d0bb
Potential fix for flaky TSAN
...
TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084243003
Review-Url: https://codereview.chromium.org/2084243003
2016-06-22 15:29:00 -07:00
msarett
9bba21530d
Do loads and math in parallel in SkColorXform_opts
...
Note that baselines have changed a little since I
recently started using clang.
201295.jpg on HP z620 (300x280)
Skia Xform sRGB Dst Before 0.378 ms
Skia Xform sRGB Dst After 0.322 ms
1.17x
Skia Xform 2.2 Dst Before 0.428 ms
Skia Xform 2.2 Dst After 0.395 ms
1.08x
QCMS Xform 0.418 ms
sRGB Dst vs QCMS 1.30x
2.2 Dst vs QCMS 1.06x
--------------------------------------------
Nexus 6P:
Skia Xform sRGB Dst Before 1.58 ms
Skia Xform sRGB Dst After 1.43 ms
Skia Xform 2.2 Dst Before 2.69 ms
Skia Xform 2.2 Dst After 2.62 ms
Dell Venue 8:
Skia Xform sRGB Dst Before 2.78 ms
Skia Xform sRGB Dst After 2.74 ms
Skia Xform 2.2 Dst Before 3.73 ms
Skia Xform 2.2 Dst After 3.64 ms
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081933005
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2081933005
2016-06-22 14:55:51 -07:00
msarett
b39067696a
Use a table-based implementation of SkDefaultXform
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084673002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2084673002
2016-06-22 14:07:48 -07:00
csmartdalton
57e98530c1
Support GL_SAMPLES queries in null contexts
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
Committed: https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
Review-Url: https://codereview.chromium.org/2085043002
2016-06-22 13:47:08 -07:00
fmenozzi
17b64b2fd4
Add GM for hard stop gradients
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087273002
Review-Url: https://codereview.chromium.org/2087273002
2016-06-22 13:39:25 -07:00
rmistry
1afb8f8965
Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ )
...
Reason for revert:
Reverting due to purple trybots in https://codereview.chromium.org/2087343002/
We will have to investigate..
Original issue's description:
> add a Chrome builder to the CQ
>
> This appears to be the fastest Chrome builder, averaging 8-9 minutes.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
>
> Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d
TBR=reed@google.com ,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2087913003
2016-06-22 10:41:02 -07:00
mtklein
cb4efa90ab
add a Chrome builder to the CQ
...
This appears to be the fastest Chrome builder, averaging 8-9 minutes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
Review-Url: https://codereview.chromium.org/2085333002
2016-06-22 10:22:55 -07:00
herb
632d004677
Add guards around access to font cache global fields.
...
BUG=589439
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2082423002
Review-Url: https://codereview.chromium.org/2082423002
2016-06-22 10:19:16 -07:00
mtklein
3917cf4ef7
Revert of GN (patchset #12 id:220001 of https://codereview.chromium.org/2087593002/ )
...
Reason for revert:
gclient not happy on some bots
Original issue's description:
> GN
>
> What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp.
>
> The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try:
> - add another backend like vs or xcode to GN directly
> - intercept via a custom toolchain
> - reverse from ninja -t commands
> That last option seems kind of fun.
>
> This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients.
>
> This pulls in some new DEPS:
> - build: Chrome's GN configuration, and much more
> - buildtools: hashes for gn binary, pulled via hooks
> - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build
> It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac.
>
> Have not yet tried building for Windows, Android, or iOS.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002
>
> Committed: https://skia.googlesource.com/skia/+/1d8de594f126b9a80bd8f8fa2005e90faf3b5b17
TBR=bsalomon@google.com ,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2088253002
2016-06-22 10:07:07 -07:00
mtklein
1d8de594f1
GN
...
What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp.
The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try:
- add another backend like vs or xcode to GN directly
- intercept via a custom toolchain
- reverse from ninja -t commands
That last option seems kind of fun.
This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients.
This pulls in some new DEPS:
- build: Chrome's GN configuration, and much more
- buildtools: hashes for gn binary, pulled via hooks
- tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build
It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac.
Have not yet tried building for Windows, Android, or iOS.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002
Review-Url: https://codereview.chromium.org/2087593002
2016-06-22 09:52:13 -07:00
brianosman
1d20258360
Tab -> spaces
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2082393002
Review-Url: https://codereview.chromium.org/2082393002
2016-06-22 08:30:40 -07:00
msarett
111a42d9ce
Enable flattening and unflattening of SkColorSpace
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085653003
Review-Url: https://codereview.chromium.org/2085653003
2016-06-22 08:18:54 -07:00
egdaniel
05dceabf34
Use single alloc for vulkan optimal image heaps to fix memory crash
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087283002
Review-Url: https://codereview.chromium.org/2087283002
2016-06-22 07:45:50 -07:00
scroggo
7732c0cae7
Revert of Bring back compiling third_party/libpng in public.bzl (patchset #3 id:40001 of https://codereview.chromium.org/2044703006/ )
...
Reason for revert:
Breaking Google3
Original issue's description:
> Bring back compiling third_party/libpng in public.bzl
>
> Disable the optimizations for simplicity, as suggested in [1].
>
> Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22.
>
> [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006
>
> Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce
TBR=benjaminwagner@google.com ,msarett@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2090643002
2016-06-22 07:25:16 -07:00
brianosman
6efeda4838
Revert of Store mipmap levels in deferred texture image (patchset #15 id:280001 of https://codereview.chromium.org/2034933003/ )
...
Reason for revert:
Crashes on a few different bots (including ASAN). Examples:
https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/6324
https://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug/builds/5400
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3539
Original issue's description:
> Store mipmap levels in deferred texture image
>
> When creating the deferred texture image, detect if using medium / high
> quality. If so, generate and store mipmaps in the deferred texture
> image.
>
> When creating a texture from that be sure to read it back out.
>
> BUG=578304
> R=bsalomon@google.com
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2034933003
>
> Committed: https://skia.googlesource.com/skia/+/b3105190a6e02d37f1d7f07a3a8bdd368ec7f157
TBR=bsalomon@google.com ,ericrk@chromium.org,cblume@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=578304
Review-Url: https://codereview.chromium.org/2083393002
2016-06-22 07:10:06 -07:00
fmenozzi
b105cff6e2
Remove bubbles GM
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087263002
Review-Url: https://codereview.chromium.org/2087263002
2016-06-22 06:36:26 -07:00
brianosman
e6865a09d1
Revert of Support GL_SAMPLES queries in null contexts (patchset #2 id:20001 of https://codereview.chromium.org/2085043002/ )
...
Reason for revert:
Chrome unit tests failing (eg https://codereview.chromium.org/2085243002 )
Original issue's description:
> Support GL_SAMPLES queries in null contexts
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
>
> Committed: https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521
TBR=bsalomon@google.com ,csmartdalton@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2089013003
2016-06-22 05:57:17 -07:00
csmartdalton
64b92a5929
Support GL_SAMPLES queries in null contexts
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002
Review-Url: https://codereview.chromium.org/2085043002
2016-06-21 14:27:17 -07:00
scroggo
e6939c15dc
Bring back compiling third_party/libpng in public.bzl
...
Disable the optimizations for simplicity, as suggested in [1].
Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22.
[1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006
Review-Url: https://codereview.chromium.org/2044703006
2016-06-21 14:13:40 -07:00
cblume
b3105190a6
Store mipmap levels in deferred texture image
...
When creating the deferred texture image, detect if using medium / high
quality. If so, generate and store mipmaps in the deferred texture
image.
When creating a texture from that be sure to read it back out.
BUG=578304
R=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2034933003
Review-Url: https://codereview.chromium.org/2034933003
2016-06-21 13:43:13 -07:00
brianosman
79b15f60f4
Add new GM that exercises Gray 8 mipmapping and sRGB-ness
...
This demonstrates the bug that was fixed by:
https://codereview.chromium.org/2088883002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087933002
Review-Url: https://codereview.chromium.org/2087933002
2016-06-21 13:40:12 -07:00
stani
a80bb676d3
Remove check for cmake in android make script.
...
Update docs explaining how to setup Android SDK.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084763003
DOCS_PREVIEW= https://skia.org/?cl=2084763003
Review-Url: https://codereview.chromium.org/2084763003
2016-06-21 13:13:20 -07:00
brianosman
7e5e594ea6
Never use CPU-built mips for Gray_8.
...
Fixes a bug where Gray_8 textures would still render as Alpha_8 (if the
first draw was detected as needing mips).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2088883002
Review-Url: https://codereview.chromium.org/2088883002
2016-06-21 12:08:24 -07:00
reed
dabe5d3780
update callers to not use SkColorProfileType
...
Requires https://codereview.chromium.org/2087833002/ to land first.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086583002
Review-Url: https://codereview.chromium.org/2086583002
2016-06-21 10:28:14 -07:00
msarett
db197a54b5
Fix Mac clang linker
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2077353006
Review-Url: https://codereview.chromium.org/2077353006
2016-06-21 09:44:29 -07:00
fmenozzi
497e9e2b36
Integers can now be passed as uniforms; needed for passing color count to fragment shader
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
Committed: https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
Review-Url: https://codereview.chromium.org/2076143003
2016-06-21 09:42:12 -07:00
msarett
67cb666481
Add --simpleCodec to nanobench flags to run a smaller set of benchmarks
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084683002
Review-Url: https://codereview.chromium.org/2084683002
2016-06-21 08:49:26 -07:00
bsalomon
93f66bc3af
Apply canonicalizations to path GrShapes.
...
The following canonicalizations of path-backed GrShapes are added:
*convex shapes are stored with even/odd (or inv even/odd) fill.
*filled paths are closed.
*dashed paths ignore inverseness of the fill
This will improve the results of queries about the geometry that will be added in a future change.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067283003
Review-Url: https://codereview.chromium.org/2067283003
2016-06-21 08:35:49 -07:00
csmartdalton
9b972c4a12
Support texel and draw-indirect buffers in null GL contexts
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081183002
Review-Url: https://codereview.chromium.org/2081183002
2016-06-21 07:55:17 -07:00
update-skps
5691144d54
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086843002
Review-Url: https://codereview.chromium.org/2086843002
2016-06-21 06:29:02 -07:00
brianosman
473466c017
Reorder colorspaces in GM to match previous behavior
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2088493002
Review-Url: https://codereview.chromium.org/2088493002
2016-06-20 14:43:00 -07:00
liyuqian
a27f669f46
Benchmark rotated rect with AA/noAA
...
Using this benchmark, we verify that AA is about 4x slower than noAA in
path_fill_big_rotated_rect. This is what I aim to improve in the next
CL.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003
Review-Url: https://codereview.chromium.org/2087453003
2016-06-20 14:05:27 -07:00
borenet
70ba047eac
Buildbot spec: Add device_type for Android One
...
BUG=skia:5185
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085713002
Review-Url: https://codereview.chromium.org/2085713002
2016-06-20 13:04:25 -07:00
bsalomon
ddbc6e5d27
Exempt GrShape test from running on Android
...
BUG=skia:5438
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2074403003
Review-Url: https://codereview.chromium.org/2074403003
2016-06-20 12:48:33 -07:00
bsalomon
1b28c1adc1
Some simplifications of GrShape reductions/canonicalizations
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064113004
Review-Url: https://codereview.chromium.org/2064113004
2016-06-20 12:28:17 -07:00
reed
d7ec12e41c
assert that non-empty clips have non-empty bounds
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084603002
TBR=
Review-Url: https://codereview.chromium.org/2084603002
2016-06-20 10:21:24 -07:00
brianosman
1a48e13303
Respect color type and gamma settings in nanobench GPU configs
...
We were ignoring the requested properties in things like gpuf16 and
gpusrgb.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075133003
Review-Url: https://codereview.chromium.org/2075133003
2016-06-20 09:41:41 -07:00
brianosman
52ede1d905
More removal of SkColorProfileType...
...
Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with
the command line flag that was setting it in DM and nanobench.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002
Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67
Review-Url: https://codereview.chromium.org/2071393002
2016-06-20 08:25:02 -07:00
msarett
0ed057542c
Sanitize parsing of color look-up table
...
BUG=skia:5443
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2079243003
Review-Url: https://codereview.chromium.org/2079243003
2016-06-20 08:08:28 -07:00
msarett
d2809573de
Support sRGB dsts in opt code
...
201295.jpg on HP z620 (300x280)
QCMS Xform 0.418 ms
Skia NEW Xform 0.378 ms
Vs QCMS 1.11x
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2078623002
2016-06-20 06:07:45 -07:00
brianosman
452ba88066
Revert of Integers can now be passed as uniforms (patchset #1 id:1 of https://codereview.chromium.org/2076143003/ )
...
Reason for revert:
Compile failures on Vulkan platforms (eg https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan )
Original issue's description:
> Integers can now be passed as uniforms; needed for passing color count to fragment shader
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
>
> Committed: https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
TBR=tomhudson@google.com ,bsalomon@google.com,fmenozzi@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
Review-Url: https://codereview.chromium.org/2080133002
2016-06-19 18:05:12 -07:00
mtklein
875e13ca09
Simplify mask/clip intersection, making sure to explicitly check for an empty mask.
...
Previously we were only asserting the mask wasn't empty, which isn't necessarily true when we're given pathological float coordinates like +Inf or NaN.
A local run of nanobench --match text_ was not able to show this is faster or slower.
This patch fixed this first Chrome bug on my desktop, and the second is probably a dupe.
BUG=chromium:619378,chromium:613912
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2073873002
Review-Url: https://codereview.chromium.org/2073873002
2016-06-19 05:28:33 -07:00
fmenozzi
cc3a22b369
Integers can now be passed as uniforms; needed for passing color count to fragment shader
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
Review-Url: https://codereview.chromium.org/2076143003
2016-06-18 09:31:58 -07:00
egdaniel
802acec187
Revert of More removal of SkColorProfileType... (patchset #2 id:20001 of https://codereview.chromium.org/2071393002/ )
...
Reason for revert:
This was still used in chrome
Original issue's description:
> More removal of SkColorProfileType...
>
> Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with
> the command line flag that was setting it in DM and nanobench.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002
>
> Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67
TBR=msarett@google.com ,reed@google.com,bsalomon@google.com,brianosman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2074103004
2016-06-17 15:11:46 -07:00
hstern
992a22d2e9
Fix mixup where SamplePathOverstroke wasn't added
...
- My sampleapp for the stroking bugs was inflight or something when
this change got made, so it didn't get added to this file.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076283002
Review-Url: https://codereview.chromium.org/2076283002
2016-06-17 14:06:13 -07:00
mtklein
3e3181263c
Quick bandaid for chromium:611002.
...
We're somehow receiving non-premultiplied src inputs like 0x00ffffff to this
SrcOver blend. That's a bug I intend to follow up on. But for a quick
compatibility fix, go back to treating values like 0x00ffffff as transparent,
like we used to before crrev.com/1820313002.
This will not affect the correctness of code paths using properly premultiplied colors.
This should not change performance in any meaningful way.
The SIMD code paths (handling strides of 16 pixels at a time) happen to treat
invalid colors like 0x00fffff as transparent already.
BUG=chromium:611002
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075173002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2075173002
2016-06-17 13:47:53 -07:00
brianosman
944876f274
More removal of SkColorProfileType...
...
Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with
the command line flag that was setting it in DM and nanobench.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002
Review-Url: https://codereview.chromium.org/2071393002
2016-06-17 13:43:27 -07:00
cabanier
e75cdcb85b
SkPDF: Use type 2/3 shading for gradient shaders
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925233003
Review-Url: https://codereview.chromium.org/1925233003
2016-06-17 12:38:54 -07:00