Commit Graph

36744 Commits

Author SHA1 Message Date
Jim Van Verth
e6146bd7be Fix float overflow in shadow tessellator
Bug: skia:
Change-Id: Idc133df4ed8ed0922a756023365c9106c0efcf8b
Reviewed-on: https://skia-review.googlesource.com/153666
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-09-11 18:57:02 +00:00
angle-skia-autoroll
17c66940d0 Roll third_party/externals/angle2 0d0fb43f34ee..2da04538b4ff (2 commits)
0d0fb43f34..2da04538b4


git log 0d0fb43f34ee..2da04538b4ff --date=short --no-merges --format='%ad %ae %s'
2018-09-11 oetuaho@nvidia.com Add sampler2DMSArray support to HLSL output
2018-09-11 chrome-bot@chromium.org DEPS: Remove the need for angle_root.


Created with:
  gclient setdep -r third_party/externals/angle2@2da04538b4ff

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=caryclark@google.com

Change-Id: I211ee1d4d3ec02d25d6f1e47f341f98c14e58ca9
Reviewed-on: https://skia-review.googlesource.com/153680
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-11 18:47:56 +00:00
Florin Malita
3d413c5761 Reland: add SkPath::shrinkToFit
Original CL: https://skia-review.googlesource.com/c/skia/+/150967

  * expanded tests
  * fixed shared pathref copying

Change-Id: I4bfe89f597485aa2db68f58d99112188615faceb
Reviewed-on: https://skia-review.googlesource.com/153553
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
2018-09-11 18:33:00 +00:00
Brian Salomon
efa6bcb022 Make GrAAConvexTessellator bail on paths that map to inf/nan in device space.
This makes us avoid hitting assertions when computing normals.

We could be better and clip but have to be careful about strokes.

Bug: 882609
Change-Id: I6550e7f8b912021fb8dfbcad7a03151dfb272b11
Reviewed-on: https://skia-review.googlesource.com/153664
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-09-11 17:59:57 +00:00
Jim Van Verth
fb18639804 Set ambient stroke to full width of blur.
Gives better blur behavior around corners and looks more like an
actual blur. Also removed the color members, as they're mostly
constant.

Bug: skia:7971
Change-Id: I22a5dcb93da1f39040148ca6ddb391844382cc73
Reviewed-on: https://skia-review.googlesource.com/153280
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-09-11 17:23:16 +00:00
Jim Van Verth
b7c955199a Fix some overflowing integers in SkPolyUtils
Bug: oss-fuzz:10293
Change-Id: If3a98e60081ebef7bdc8460fce4fa682245c68cc
Reviewed-on: https://skia-review.googlesource.com/153661
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-09-11 17:16:17 +00:00
Cary Clark
5831e11133 fix another pathmeasure fuzz
Delete the cache of measurements if the total
length is not computable (NaN), since the individual
measurements may cause other failures later, like
finding the initial segment position.

R=kjlubick@google.com

Bug: skia:8373
Change-Id: Ibf58c261c46a5535a0a1f12cbeb94da29e33f471
Reviewed-on: https://skia-review.googlesource.com/153601
Commit-Queue: Cary Clark <caryclark@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-09-11 16:27:27 +00:00
Cary Clark
1ea5656a28 Revert "Base Gradient FP Refactor"
This reverts commit 10f7a1e075.

Reason for revert: broke google3 roll
Original change's description:
> Base Gradient FP Refactor
> 
> --
> 
> Redefines how gradients will be written in the GPU back-end:
> 
> They are split into three fragment processor components: master, layout, and colorizer.
> The layout FP is responsible for converting the fragment position into an interpolant value, t.
> Each high-level gradient--such as linear, radial, etc.--are implemented solely in a layout FP.
> The colorizer FP is responsible for converting t into a color.
> The master FP invokes the layout, clamps t into the proper domain, and then invokes the colorizer.
> GrGradientShader provides factory functions to create FP graphs from SkGradientShader instances.
> This pattern is documented in gpu/gradients/README.md.
> 
> Goals for current CL
> ====================
> 
> Outline the FP components by providing .fp implementations for the simplest gradients.
> Defines a two-color single interval colorizer and a linear gradient layout, and the master effect.
> A MakeLinear() factory function is provided that can convert SkGradientShaders that fit these constraints.
> SkLinearGradient first attempts to use the new system, falling back to the original GrGradientEffect.
> 
> Future CLs
> ==========
> 
> To keep the CL reviews manageable, additional dependent CLs will be added that gradually replace past functionality.
> A CL for each layout will be defined.
> CLs for the different analytic colorizer cases and the textured gradient case will be defined.
> Once the new system supports all current layouts and colorizer capabilities, all old GPU gradient code will be removed.
> After this clean-up, analytic colorization can hopefully be expanded to reduce the usage of textured gradients.
> 
> Bug: skia:
> Change-Id: Iafe7b8b4071491a71c473babcd7bedda659150c1
> Reviewed-on: https://skia-review.googlesource.com/148120
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,michaelludwig@google.com

Change-Id: Ib735e323795ac8874cb00b007a915786b50517a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153600
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-09-11 15:51:56 +00:00
Hal Canary
9f61f40ffa SkPDF: Device subclass no longer tracks size.
Change-Id: I13ad631a80d3ca2f4ad5bb2db21d670444650b0f
Reviewed-on: https://skia-review.googlesource.com/153140
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2018-09-11 15:26:22 +00:00
Hal Canary
2473d94720 SkPDF: allocate for single Canvas
Change-Id: I852717b30c687c1f2bba38cfa7ab59780b61c1f5
Reviewed-on: https://skia-review.googlesource.com/153100
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2018-09-11 15:04:51 +00:00
Michael Ludwig
10f7a1e075 Base Gradient FP Refactor
--

Redefines how gradients will be written in the GPU back-end:

They are split into three fragment processor components: master, layout, and colorizer.
The layout FP is responsible for converting the fragment position into an interpolant value, t.
Each high-level gradient--such as linear, radial, etc.--are implemented solely in a layout FP.
The colorizer FP is responsible for converting t into a color.
The master FP invokes the layout, clamps t into the proper domain, and then invokes the colorizer.
GrGradientShader provides factory functions to create FP graphs from SkGradientShader instances.
This pattern is documented in gpu/gradients/README.md.

Goals for current CL
====================

Outline the FP components by providing .fp implementations for the simplest gradients.
Defines a two-color single interval colorizer and a linear gradient layout, and the master effect.
A MakeLinear() factory function is provided that can convert SkGradientShaders that fit these constraints.
SkLinearGradient first attempts to use the new system, falling back to the original GrGradientEffect.

Future CLs
==========

To keep the CL reviews manageable, additional dependent CLs will be added that gradually replace past functionality.
A CL for each layout will be defined.
CLs for the different analytic colorizer cases and the textured gradient case will be defined.
Once the new system supports all current layouts and colorizer capabilities, all old GPU gradient code will be removed.
After this clean-up, analytic colorization can hopefully be expanded to reduce the usage of textured gradients.

Bug: skia:
Change-Id: Iafe7b8b4071491a71c473babcd7bedda659150c1
Reviewed-on: https://skia-review.googlesource.com/148120
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-09-11 14:52:55 +00:00
Brian Osman
bd65955441 Remove SkImageCacherator entirely
It was just the slice of SkImage_Lazy's API that we needed to expose to
GrImageTextureMaker. Instead, give SkImage_Lazy a header, so that the
maker can use it directly.

Change-Id: Iea6198f63e8065b8c987f7c07f3222409cdda439
Reviewed-on: https://skia-review.googlesource.com/153546
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-11 14:24:32 +00:00
swiftshader-skia-autoroll
b42a897819 Roll third_party/externals/swiftshader 6dafcf32ec41..17b75890e71a (12 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6dafcf32ec41..17b75890e71a


git log 6dafcf32ec41..17b75890e71a --date=short --no-merges --format='%ad %ae %s'
2018-09-11 loganchien@google.com Add LLVM 7.0 Android.mk
2018-09-11 loganchien@google.com Add LLVM 7.0 ARM/AArch64 backend to CMakeLists.txt
2018-09-11 loganchien@google.com Move atomicExchange under PERF_PROFILE
2018-09-11 loganchien@google.com Add the unimplemented non-x86 code generator
2018-09-11 loganchien@google.com Port SwiftShader to LLVM 7.0
2018-09-11 loganchien@google.com Add LLVM 7.0 configs for Linux and Android
2018-09-11 loganchien@google.com Add LLVM 7.0 config generation script
2018-09-11 loganchien@google.com Add LLVM 7.0 git submodule
2018-09-11 loganchien@google.com Refactor LLVM initialization code
2018-09-11 loganchien@google.com Wrap call arguments with ARGS macro
2018-09-11 loganchien@google.com Remove sw::Value, sw::BasicBlock, and sw::SwitchCases
2018-09-11 loganchien@google.com Remove stale LLVM include path


Created with:
  gclient setdep -r third_party/externals/swiftshader@17b75890e71a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=caryclark@google.com

Change-Id: I8830af571a79033dc5b26845586309726c7089db
Reviewed-on: https://skia-review.googlesource.com/153500
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-11 13:10:19 +00:00
Mike Klein
b83891433f just zero flags
This memset() zeroes more than is really needed.
All these fields will be overwritten eventually,
unless we early return where none of them are used.

Change-Id: Ibb75ae8853eab81251a8995bb9d681689187e727
Reviewed-on: https://skia-review.googlesource.com/153262
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-09-11 12:37:25 +00:00
Cary Clark
58aa824dda fix pathmeasure fuzz
distanceToSegment can return NaN

R=kjlubick@google.com

Bug: skia:
Change-Id: Iaafe5712bbf416058c8c5066a46300858c12ce4b
Reviewed-on: https://skia-review.googlesource.com/153494
Auto-Submit: Cary Clark <caryclark@skia.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-09-11 12:31:19 +00:00
angle-skia-autoroll
2bf7a7bcc6 Roll third_party/externals/angle2 63aa0e5b7001..0d0fb43f34ee (1 commits)
63aa0e5b70..0d0fb43f34


git log 63aa0e5b7001..0d0fb43f34ee --date=short --no-merges --format='%ad %ae %s'
2018-09-11 jmadill@chromium.org Pass unpack buffer as explicit parameter to texSubImage.


Created with:
  gclient setdep -r third_party/externals/angle2@0d0fb43f34ee

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=caryclark@google.com

Change-Id: I3975b0f0537c8fb9f0594da50807cd933a7340e0
Reviewed-on: https://skia-review.googlesource.com/153401
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-11 09:54:30 +00:00
swiftshader-skia-autoroll
82bf31003c Roll third_party/externals/swiftshader cf47cfdd7c44..6dafcf32ec41 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/cf47cfdd7c44..6dafcf32ec41


git log cf47cfdd7c44..6dafcf32ec41 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 nicolas.capens@gmail.com Fix Visual Studio SubzeroTest build.


Created with:
  gclient setdep -r third_party/externals/swiftshader@6dafcf32ec41

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=caryclark@google.com

Change-Id: I484b04b7682d639296f676047c6c918f009e5331
Reviewed-on: https://skia-review.googlesource.com/153400
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-11 05:00:00 +00:00
angle-skia-autoroll
5518e65d90 Roll third_party/externals/angle2 480edb8c1d7d..63aa0e5b7001 (2 commits)
480edb8c1d..63aa0e5b70


git log 480edb8c1d7d..63aa0e5b7001 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 wfh@chromium.org Fix 64-bit -> 32-bit implicit conversions in libangle.
2018-09-10 jmadill@chromium.org Vulkan: Fix FragCoord scaling when a viewport is applied.


Created with:
  gclient setdep -r third_party/externals/angle2@63aa0e5b7001

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=caryclark@google.com

Change-Id: I42a847d0d51fcc8a1e9c3e946ba12064110c779b
Reviewed-on: https://skia-review.googlesource.com/153340
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-11 01:01:27 +00:00
Herb Derby
3c4d533d8e Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig
With less stressful tests.

Change-Id: I600cb728f6efca5aab87a16e71039a0ed00c47e1
Reviewed-on: https://skia-review.googlesource.com/153220
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-09-10 21:57:16 +00:00
Brian Osman
7891994e89 Add fast path to SkColorSpaceXformSteps
No need to do any real work if the src and dst are identical

Change-Id: I46dd21ed6464e9ffcbf07434e696f16b85f3193b
Reviewed-on: https://skia-review.googlesource.com/153006
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-10 21:04:42 +00:00
Mike Reed
a21a16b5dd Revert "add SkPath::shrinkToFit"
This reverts commit 3d69be51bb.

Reason for revert: breaks on SAN builds

Original change's description:
> add SkPath::shrinkToFit
> 
> Bug: skia:
> Change-Id: Ief647bcea53c0aeae2750473288bd31f16521772
> Reviewed-on: https://skia-review.googlesource.com/150967
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>
> Auto-Submit: Mike Reed <reed@google.com>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: Ic3d6497268df1eb86392f83844d3fdcdb0674373
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153261
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-10 21:03:53 +00:00
Allan MacKinnon
638ab5ac2d Selected a much better HotSort "shape" for NVIDIA.
Updated kernel building scripts.
Documentation updates.

NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Bug: skia:
Change-Id: I79292c14bd358259e6a5c919a0538f140e9a5032
Reviewed-on: https://skia-review.googlesource.com/153166
Reviewed-by: Allan MacKinnon <allanmac@google.com>
Commit-Queue: Allan MacKinnon <allanmac@google.com>
Auto-Submit: Allan MacKinnon <allanmac@google.com>
2018-09-10 20:59:35 +00:00
Mike Reed
3d69be51bb add SkPath::shrinkToFit
Bug: skia:
Change-Id: Ief647bcea53c0aeae2750473288bd31f16521772
Reviewed-on: https://skia-review.googlesource.com/150967
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2018-09-10 20:49:31 +00:00
Brian Osman
086679bc11 Revert "increase Builder's prealloc size after colorspace change"
This reverts commit e53de48393.

Reason for revert: Key size distribution has changed back.

Original change's description:
> increase Builder's prealloc size after colorspace change
> 
> BUG=skia:
> 
> Change-Id: I003dcbde7d987404ae823df6621e13664cf440a1
> Reviewed-on: https://skia-review.googlesource.com/9523
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com,reed@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I506a1ec791e6d99df1836cbf3262747fbfa224a7
Reviewed-on: https://skia-review.googlesource.com/153008
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-10 20:49:30 +00:00
Cary Clark
aa5f38f0ba Revert "Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig"
This reverts commit a2bc1ca21b.

Reason for revert: see if make chromecast failures go away

Original change's description:
> Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig
> 
> Change-Id: I1353d3facf191e3323027fc288715672240d1f87
> Reviewed-on: https://skia-review.googlesource.com/152591
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=jvanverth@google.com,bsalomon@google.com,herb@google.com

Change-Id: I970ec86678c97046001889dc436df5307750da1b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/153180
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-09-10 20:28:13 +00:00
Greg Daniel
303e83e6b3 Let unbudgeted, unique keyed resources stay in gpu ResourceCache.
Also has some fixes to make sure we are allowing unique keys on uninstantiated
proxies and that we then forward those unique keys to resources during lazy
instantiation.

Bug: skia:
Change-Id: Ief33bc38dbe06a081123a86e33c69b239f5a862b
Reviewed-on: https://skia-review.googlesource.com/152980
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-09-10 19:46:02 +00:00
Jim Van Verth
d737ab95e5 Consolidate more shadow generation code.
Moves the spot shadow code into the base class, and has both shadow
types use it to generate their geometry.

Bug: skia:7971
Change-Id: I866aa8a8a796a5f4bbf4698e1df5148c547ee3c2
Reviewed-on: https://skia-review.googlesource.com/152662
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-09-10 19:37:30 +00:00
Mike Reed
52fd68762a Reland "remove legacy google3 flag"
This reverts commit 5f5dd18c28.

Reason for revert: google3 site updated

Original change's description:
> Revert "remove legacy google3 flag"
> 
> This reverts commit b8b2586dd3.
> 
> Reason for revert: broke google3
> 
> Original change's description:
> > remove legacy google3 flag
> > 
> > Bug: skia:
> > Change-Id: I9110f65e696a0c91c43954927dc05194797bf18c
> > Reviewed-on: https://skia-review.googlesource.com/152960
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=reed@google.com
> 
> Change-Id: I2e0ff73c9ed340ef447de1606c618d2935fa8fae
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/153002
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I07d7ded6e76012610df46e907e9303c1efd38e57
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153120
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-10 19:00:15 +00:00
Herb Derby
a2bc1ca21b Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig
Change-Id: I1353d3facf191e3323027fc288715672240d1f87
Reviewed-on: https://skia-review.googlesource.com/152591
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-09-10 17:49:56 +00:00
Brian Osman
10494e34e4 Restore lazy image cache key logic
This was removed in https://skia-review.googlesource.com/c/skia/+/151661
It appears to be a no-op, but wrapping the original key means that images
and bitmaps with the same unique ID won't hit the same proxies in the
cache.

Change-Id: I9af0594349f22e56af1404c5bcb9e926ded8753e
Reviewed-on: https://skia-review.googlesource.com/153005
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-10 17:27:24 +00:00
Mike Reed
c81ebd272b implement onMakeFromData for FontConfigInterface
Bug: skia:
Change-Id: Ife3192a7a41a89301da7300bf0577a10515341cd
Reviewed-on: https://skia-review.googlesource.com/153021
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-09-10 16:53:36 +00:00
angle-skia-autoroll
2ed97e3cdd Roll third_party/externals/angle2 a735ee2f6df8..480edb8c1d7d (1 commits)
a735ee2f6d..480edb8c1d


git log a735ee2f6df8..480edb8c1d7d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 oetuaho@nvidia.com Clean up TextureStorage11_2DMultisample


Created with:
  gclient setdep -r third_party/externals/angle2@480edb8c1d7d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=caryclark@google.com

Change-Id: Iaafbefcadb5a946caeaef5eb01cc86b4d99a31f8
Reviewed-on: https://skia-review.googlesource.com/153060
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-10 16:12:03 +00:00
Brian Salomon
71df5d5777 Relax hairline requirement that all non-quadratic cubics are split once.
Change-Id: Ib3653535bea1a24c84e60c744bafc0f3fb9d2ff5
Reviewed-on: https://skia-review.googlesource.com/153003
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-09-10 15:58:36 +00:00
Florin Malita
a61f0f73dc [skottie] Add support for explicit image asset sizing
TBR=
Change-Id: Ie1c8a30ebc6a7c647265f05fe39b39b53758f016
Reviewed-on: https://skia-review.googlesource.com/153004
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-09-10 15:44:42 +00:00
Brian Salomon
57d2beabc7 Simplify GrResourceCache/GrDrawingManager flush interaction.
Change-Id: I2442da32a364ec77ccbefc58ceaa62de8e991caf
Reviewed-on: https://skia-review.googlesource.com/152669
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-09-10 15:23:46 +00:00
Mike Reed
5f5dd18c28 Revert "remove legacy google3 flag"
This reverts commit b8b2586dd3.

Reason for revert: broke google3

Original change's description:
> remove legacy google3 flag
> 
> Bug: skia:
> Change-Id: I9110f65e696a0c91c43954927dc05194797bf18c
> Reviewed-on: https://skia-review.googlesource.com/152960
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I2e0ff73c9ed340ef447de1606c618d2935fa8fae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153002
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-10 15:11:29 +00:00
Florin Malita
cd9d074578 [skottie] More efficient group sizing
Replace sksg::Group::shrink_to_fit() with a factory accepting an
externally-built children array.

This provides more control for clients (e.g. reserve() instead of
shrink_to_fit()).

Change-Id: Iad587435e0e9da15251a9d3bc2510ca945950b5d
Reviewed-on: https://skia-review.googlesource.com/152861
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-10 14:17:30 +00:00
Mike Reed
b8b2586dd3 remove legacy google3 flag
Bug: skia:
Change-Id: I9110f65e696a0c91c43954927dc05194797bf18c
Reviewed-on: https://skia-review.googlesource.com/152960
Reviewed-by: Mike Reed <reed@google.com>
2018-09-10 13:21:48 +00:00
Brian Salomon
43b882bced Remove purging of GPU resources based on flush counts.
We've had a better time-based mechanism available for a long time.

Change-Id: I130ab79dc0e8161a6817eb53b83e0988546dfa71
Reviewed-on: https://skia-review.googlesource.com/152668
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-09-10 13:11:07 +00:00
angle-skia-autoroll
c55b114a75 Roll third_party/externals/angle2 1cee042197da..a735ee2f6df8 (1 commits)
1cee042197..a735ee2f6d


git log 1cee042197da..a735ee2f6df8 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 jiajia.qin@intel.com ES31: Support shader storage block in D3D11 compiler - Part1


Created with:
  gclient setdep -r third_party/externals/angle2@a735ee2f6df8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=caryclark@google.com

Change-Id: I831640f26a10767e9c5b07f5e7de962f33231071
Reviewed-on: https://skia-review.googlesource.com/152900
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-10 07:07:35 +00:00
angle-skia-autoroll
038f252b76 Roll third_party/externals/angle2 3b9680534909..1cee042197da (1 commits)
3b96805349..1cee042197


git log 3b9680534909..1cee042197da --date=short --no-merges --format='%ad %ae %s'
2018-09-09 fjhenigman@chromium.org Suppress ...shaders.builtin_variable.fragcoord_w.


Created with:
  gclient setdep -r third_party/externals/angle2@1cee042197da

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=caryclark@google.com

Change-Id: Iab3f2e8da22f01aa4c6d71368d062fd73a4a1ff7
Reviewed-on: https://skia-review.googlesource.com/152885
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-09 22:17:48 +00:00
skia-recreate-skps
d22a4ff1f2 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I6ce6d6cb6d0ef778bdf3aec478fd43fca62937f0
Reviewed-on: https://skia-review.googlesource.com/152882
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-09-09 12:11:52 +00:00
Florin Malita
40c7c64572 [skottie] Skip group nodes for single-draw shapes
Pulling this off requires deferring the group creation until after we've
resolved all the draws.  Doable, but somewhat tricky due to the
interaction with the dangling/uncommitted animator logic.

TBR=
Bug: skia:8340
Change-Id: Id00c841152bd80330751db45f6b26462efc844a5
Reviewed-on: https://skia-review.googlesource.com/152860
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-09-09 00:30:27 +00:00
angle-skia-autoroll
a3dc329d1d Roll third_party/externals/angle2 d84b6737fa10..3b9680534909 (4 commits)
d84b6737fa..3b96805349


git log d84b6737fa10..3b9680534909 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 fjhenigman@chromium.org Clean up state in EGLDebugTest.
2018-09-07 jmadill@chromium.org Vulkan: Make ContextVk driver uniforms a dirty bit.
2018-09-07 jmadill@chromium.org Vulkan: Correct gl_FragCoord with default FBO.
2018-09-07 fjhenigman@chromium.org Fix ClearTest.RGB8WithMaskFramebuffer.


Created with:
  gclient setdep -r third_party/externals/angle2@3b9680534909

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jvanverth@google.com

Change-Id: I3d87dea0b6d80dc22c74e628f60b1af004ba22fe
Reviewed-on: https://skia-review.googlesource.com/152802
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-08 00:09:51 +00:00
swiftshader-skia-autoroll
2810c856df Roll third_party/externals/swiftshader 3655209d86f4..cf47cfdd7c44 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/3655209d86f4..cf47cfdd7c44


git log 3655209d86f4..cf47cfdd7c44 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 sugoi@google.com Guard against out of bounds accesses caused by a large base level


Created with:
  gclient setdep -r third_party/externals/swiftshader@cf47cfdd7c44

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: I11cd17182b414e6ffb353d09a6929e363b57c4ee
Reviewed-on: https://skia-review.googlesource.com/152801
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-07 22:33:47 +00:00
swiftshader-skia-autoroll
24e8f58cfa Roll third_party/externals/swiftshader a062f321768d..3655209d86f4 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/a062f321768d..3655209d86f4


git log a062f321768d..3655209d86f4 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 nicolas.capens@gmail.com Fix texture completeness test when using sampler objects.


Created with:
  gclient setdep -r third_party/externals/swiftshader@3655209d86f4

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: I1d434dd7f3081cbeb19ade9038353f7cf8b62333
Reviewed-on: https://skia-review.googlesource.com/152800
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-09-07 21:45:56 +00:00
Mike Reed
87ce0690b7 Revert "Revert "add flag to soften the blow of removing a legacy api for flutter""
Remember to delete the define from SkTypeface.h

This reverts commit b5f23f398d.

Bug: skia:
Change-Id: I63b2e395dac3850d352f38fdfee9ad751cdcace9
Reviewed-on: https://skia-review.googlesource.com/152590
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-07 20:58:54 +00:00
Brian Salomon
3ac1f95987 Preseve tangents when converting cubics->quads in GrAAHairlinePathRenderer
Bug: chromium:847759
Change-Id: I35a6d069f732d906714a640fca59a71fd35b74ec
Reviewed-on: https://skia-review.googlesource.com/152664
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-09-07 20:21:24 +00:00
Eric Boren
3867d59050 [infra] Revert broken recipe rolls, add test for missing patch_ref
A recent upstream CL caused our trybots to stop providing the
--patch_ref flag to bot_update:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1174988

Unfortunately, we did not have a "normal" trybot as part of our tests,
so we did not catch it during the roll:
https://skia-review.googlesource.com/c/skia/+/151984

Bug: skia:
Change-Id: I2a02a2e1923715a685448ce5f4d58a93de51c3ef
Reviewed-on: https://skia-review.googlesource.com/152741
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Edward Lemur <ehmaldonado@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-09-07 19:54:48 +00:00
Brian Osman
b3f383041a Add support for gray + colorspace to SkCodec
Bug: skia:
Change-Id: Ib0996ac5aff5eeb4bd67e9938ad0d9246703a0e7
Reviewed-on: https://skia-review.googlesource.com/151661
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-07 19:46:47 +00:00