epoger@google.com
ee2c3b9fb3
GM self-test: add --writePath and --mismatchPath , but in a way that works cross-platform
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15085007
git-svn-id: http://skia.googlecode.com/svn/trunk@9077 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 18:09:06 +00:00
scroggo@google.com
614f9e3a54
Fix some warnings in SkPath.
...
R=caryclark@google.com
Review URL: https://codereview.chromium.org/14969003
git-svn-id: http://skia.googlecode.com/svn/trunk@9076 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 18:05:32 +00:00
commit-bot@chromium.org
a9f142e9f0
remove unneeded reference to SkTScopedPtr
...
R=djsollen@google.com , scroggo@google.com
Author: reed@google.com
Review URL: https://chromiumcodereview.appspot.com/14057013
git-svn-id: http://skia.googlecode.com/svn/trunk@9075 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 16:15:20 +00:00
commit-bot@chromium.org
8d47ddc19a
Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or fragment position
...
R=senorblanco@chromium.org , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/14998007
git-svn-id: http://skia.googlecode.com/svn/trunk@9074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 14:55:46 +00:00
bsalomon@google.com
504976ef6f
Move loops that chain together effects into GrGLShaderBuilder from GrGLProgram.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/14925010
git-svn-id: http://skia.googlecode.com/svn/trunk@9073 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 13:45:02 +00:00
skia.committer@gmail.com
be21431872
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9072 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 07:02:04 +00:00
reed@google.com
3eff3592ac
need to clamp all of the cubic points after a chop, in case our finite precision
...
meant we didn't compute values below the chop-point.
crbug:234190
R=caryclark@google.com
Review URL: https://codereview.chromium.org/14607012
git-svn-id: http://skia.googlecode.com/svn/trunk@9071 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 21:08:21 +00:00
scroggo@google.com
6843bdb706
Write/compare against expectations in skimage tool.
...
skimage:
Add two new modes: one to write expectations to a json file, and
another to compare results against expectations.
Use SkPATH_SEPARATOR instead of '/'.
gm_expectations:
Split into a static library so it can be used by skimage.
Make functions non static and move function definitions into source
file.
Capitalize static member functions to follow the coding style
guidelines.
BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com
Review URL: https://codereview.chromium.org/14670021
git-svn-id: http://skia.googlecode.com/svn/trunk@9069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 19:14:23 +00:00
reed@google.com
94b366a3e8
negate FontBox.bottom, since it is negative, but we want it positive (doh)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9067 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 17:46:48 +00:00
epoger@google.com
2a9a8bec45
fix BitmapHasher unittest failure as of r9064
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9066 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 16:24:05 +00:00
epoger@google.com
0a117be391
Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp
...
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15060008/
git-svn-id: http://skia.googlecode.com/svn/trunk@9064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 16:04:02 +00:00
junov@chromium.org
d575eed354
Fix behavior of SkPicture::kUsePathBoundsForClip_RecordingFlag to handle inverse fills and all clip ops correctly.
...
BUG=crbug.com/229011
TEST=Picture unit test + complexclip* GMs
Review URL: https://codereview.chromium.org/14820021
git-svn-id: http://skia.googlecode.com/svn/trunk@9063 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:39:13 +00:00
reed@google.com
8b7463db00
remove dead code (SkBitmapSampler)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9062 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:32:41 +00:00
jvanverth@google.com
e3647415d7
Revert r9055.
...
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@9061 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:31:43 +00:00
epoger@google.com
e8d08a0fc2
Roll out r9059 to unbreak bots
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:22:36 +00:00
epoger@google.com
aaf7343e16
Remove third-party cityhash, unused since r8992
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/15027013
git-svn-id: http://skia.googlecode.com/svn/trunk@9059 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:49:50 +00:00
reed@google.com
0a01f5a2c4
we only need one fontmetrics, since the paint (and fontcache) now know explicitly
...
if they are horizontal or vertical.
Review URL: https://codereview.chromium.org/14940018
git-svn-id: http://skia.googlecode.com/svn/trunk@9058 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:19:08 +00:00
reed@google.com
60af92cb6d
Use more fields from OutlineFontMEtrics: linegap, bbox.
...
Up our canonical size to 2048 to reduce precision loss.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14759021
git-svn-id: http://skia.googlecode.com/svn/trunk@9057 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:11:28 +00:00
epoger@google.com
fed9db6930
GM self-test: add option to exercise --writePath and --mismatchPath, but not on bots
...
(individual developers can set WRITE_IMAGE_FILES=1 for local testing)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/14863009
git-svn-id: http://skia.googlecode.com/svn/trunk@9056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:10:28 +00:00
commit-bot@chromium.org
74d50a4d12
Better method for rendering AA ellipses.
...
This uses the standard ellipse equation as a signed distance
test, and adjusts the result by the length of the gradient
at that point to get a better approximation of the distance
to the ellipse. It replaces the standard ellipse and
roundrect shader renderers.
Also adds a check to see if the curvature extrema of the
stroke are less than the curvature extrema of the ellipse (i.e.
the radius of curvature is larger). In this case, it's no
longer an ellipse and we can't use this renderer.
Committed: http://code.google.com/p/skia/source/detail?r=9016
R=bsalomon@google.com , robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/14938004
git-svn-id: http://skia.googlecode.com/svn/trunk@9055 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 13:59:36 +00:00
reed@google.com
d028056712
add SK_API
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9054 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 13:25:02 +00:00
bsalomon@google.com
1b8014ce82
Comment out invalid assert.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/15021008
git-svn-id: http://skia.googlecode.com/svn/trunk@9053 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 12:49:49 +00:00
rmistry@google.com
32ecf40696
Autogen has been reset. Whitespace change to trigger rebuilds
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9052 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 11:18:34 +00:00
skia.committer@gmail.com
2b34fe01d7
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9051 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 07:01:40 +00:00
mike@reedtribe.org
6862cbad08
share derivative code with extrema logic, remove some dead code.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 01:55:49 +00:00
mike@reedtribe.org
1040b473c1
fix impl for conic derivative (tangent)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 01:15:54 +00:00
reed@google.com
24bd210f2e
add (untested) tangent calc for conics
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9048 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 20:42:35 +00:00
caryclark@google.com
96fd3440fa
path ops -- make combined clips soft if one is soft
...
Review URL: https://codereview.chromium.org/14786018
git-svn-id: http://skia.googlecode.com/svn/trunk@9047 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 19:48:31 +00:00
bsalomon@google.com
7f4ad5a30f
Reland r9043 with fix.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9046 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 19:36:43 +00:00
bsalomon@google.com
c77256b83b
Make make.bat and gyp_skia work with VS 2012.
...
Review URL: https://codereview.chromium.org/14963005/
git-svn-id: http://skia.googlecode.com/svn/trunk@9045 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 19:31:20 +00:00
bsalomon@google.com
4bb235bf0c
revert 9043
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9044 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 19:19:24 +00:00
bsalomon@google.com
7df1bb76d3
SkGpuDevice: Delay locking bitmap pixels until we have a known texture cache miss.
...
Reivew URL: https://codereview.chromium.org/15035004/
git-svn-id: http://skia.googlecode.com/svn/trunk@9043 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 19:17:02 +00:00
caryclark@google.com
a5e55925ea
path ops -- fix skp bugs
...
This fixes a series of bugs discovered by running
the small set of Skia skp files through pathops
to flatten the clips.
Review URL: https://codereview.chromium.org/14798004
git-svn-id: http://skia.googlecode.com/svn/trunk@9042 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 18:51:31 +00:00
robertphillips@google.com
3faf1f1fb6
Nexus 7 performance trigger rebaselines
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9040 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 17:43:22 +00:00
reed@google.com
3b34505d79
add block comment describing sync nature of SkStream
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9039 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 15:59:16 +00:00
epoger@google.com
366a770159
GM: now that we use MD5 instead of CityHash, the JSON should say so
...
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14758003
git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 15:51:54 +00:00
commit-bot@chromium.org
b5e34e22aa
XPS ttc handling.
...
R=reed@google.com
Author: bungeman@google.com
Review URL: https://chromiumcodereview.appspot.com/14873006
git-svn-id: http://skia.googlecode.com/svn/trunk@9037 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 15:28:15 +00:00
scroggo@google.com
2983ddd4b5
Revert "Allow supporting 1 older PICTURE_VERSION."
...
This reverts commit deb9d6990ef2d153230340d960d86b0966f261e1.
That change was just to allow us to bump the PICTURE_VERSION
without changing the SKPs to the new one. Since it is not
entirely reliable, I am removing it.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/14741007
git-svn-id: http://skia.googlecode.com/svn/trunk@9035 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 14:45:40 +00:00
commit-bot@chromium.org
66f5aaad90
Check whether font creation is failed to avoid segment fault.
...
In some rare cases, SkFontHost::CreateTypeface in src/ports/SkFontHost_fontconfig.cpp will return NULL, this will lead to segment fault because the previous code would access to 0x0 by (SkTypeface *)NULL->unref().
BUG=
R=reed@google.com , bungeman@google.com
Author: yunchao.he@intel.com
Review URL: https://chromiumcodereview.appspot.com/14907005
git-svn-id: http://skia.googlecode.com/svn/trunk@9034 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 14:32:58 +00:00
junov@chromium.org
279627efc5
reverting 9031
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9033 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 14:11:40 +00:00
junov@chromium.org
0962ae1fbc
Fix SkPicture path bound optimization to handle inverse filled paths.
...
BUG=crbug.com/229011
TEST=Picture unit test
Review URL: https://codereview.chromium.org/14819008
git-svn-id: http://skia.googlecode.com/svn/trunk@9031 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 13:26:18 +00:00
robertphillips@google.com
8e2cdff9ab
Nexus 7 performance trigger rebaseline
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9030 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 13:08:41 +00:00
jvanverth@google.com
ce0ce4fa35
Add stroked oval benches.
...
Reviewed by: bsalomon
Review URL: https://codereview.chromium.org/14849011/
git-svn-id: http://skia.googlecode.com/svn/trunk@9029 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 13:03:21 +00:00
borenet@google.com
1ce5cef859
Run bench_pictures with "--config msaa4" on Razr I, Nexus 10, and GNex
...
Addresses: https://code.google.com/p/skia/issues/detail?id=1276
Review URL: https://codereview.chromium.org/15012002
git-svn-id: http://skia.googlecode.com/svn/trunk@9027 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 12:09:54 +00:00
skia.committer@gmail.com
e944de7523
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9023 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 07:01:03 +00:00
commit-bot@chromium.org
c5fd461718
Mask orientation and layout correctly.
...
R=reed@google.com , clefru@google.com
Author: bungeman@google.com
Review URL: https://chromiumcodereview.appspot.com/14884010
git-svn-id: http://skia.googlecode.com/svn/trunk@9022 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 22:23:08 +00:00
jvanverth@google.com
f58d8540a4
Reverting r9016 due to Nexus7 GM regressions
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9020 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 19:29:23 +00:00
scroggo@google.com
665b2cca88
lockPixels before calling getColorTable.
...
Fixes a bug where we try to dereference a NULL pointer.
Update the comment for SkBitmap::getColorTable, telling
the client that pixels must be locked for it to return
non-NULL.
R=edisonn@google.com
Review URL: https://codereview.chromium.org/15002002
git-svn-id: http://skia.googlecode.com/svn/trunk@9018 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 18:08:05 +00:00
commit-bot@chromium.org
1335264fce
Better method for rendering AA ellipses.
...
This uses the standard ellipse equation as a signed distance
test, and adjusts the result by the length of the gradient
at that point to get a better approximation of the distance
to the ellipse. It replaces the standard ellipse and
roundrect shader renderers.
Also adds a check to see if the curvature extrema of the
stroke are less than the curvature extrema of the ellipse (i.e.
the radius of curvature is larger). In this case, it's no
longer an ellipse and we can't use this renderer.
R=bsalomon@google.com , robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/14938004
git-svn-id: http://skia.googlecode.com/svn/trunk@9016 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 16:44:03 +00:00
reed@google.com
fcc9ca09a5
by hook or by crook, force gcc to return the value of SkPoint::length() to actually be a float
...
instead of a double. Otherwise we can't properly test for overflow with large values.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/14884011
git-svn-id: http://skia.googlecode.com/svn/trunk@9015 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 15:59:51 +00:00