robertphillips
ee843b2ae4
Revert of Make GrResourceCache dynamically change between LRU and random replacement strategies. (patchset #8 id:140001 of https://codereview.chromium.org/2321563006/ )
...
Reason for revert:
Causing problems on Mac & Windows bots.
Original issue's description:
> Make GrResourceCache dynamically change between LRU and random replacement strategies.
>
> Random performs significantly better when each frame exceeds the budget by a small margin whereas LRU has worst case behavior.
>
> The decision of which to use is made based on the history from a few frames of the ratio of total unique key cache misses to unique key cache misses of resources purged in the last 2 frames.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321563006
>
> Committed: https://skia.googlesource.com/skia/+/0f147ac2ae575bbad3515a526f13700bc5c8e9d7
TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2386993004
2016-10-04 05:30:20 -07:00
Brian Salomon
2ebd0c80a2
Remove option to make GrCoordTransforms apply to device positions.
...
Adds a device space texture decal effect to use for clipping.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2870
Change-Id: Ifcc7617ea87f5a86e301995cba9dfc30a4b0e2c5
Reviewed-on: https://skia-review.googlesource.com/2870
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2016-10-03 21:39:33 +00:00
Mike Reed
2cbcd12281
Revert "Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"""
...
This reverts commit I86875511a13497112827cbaed1dbd7639e9e3d10.
legacy (100K) skp failure
Original change's description:
> Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints""
>
> This reverts commit ce02e71758
.
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878
>
> Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10
> Reviewed-on: https://skia-review.googlesource.com/2878
> Reviewed-by: Matt Sarett <msarett@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>
TBR=msarett@google.com ,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ife6f0cf3a22b3e8cf885a188f7f44e1ff62e06a5
Reviewed-on: https://skia-review.googlesource.com/2881
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2016-10-03 21:34:36 +00:00
reed
418374c0d2
Revert of add cast for tostring (patchset #1 id:1 of https://codereview.chromium.org/2385353002/ )
...
Reason for revert:
base CL has legacy skp bug, so have to revert it
Original issue's description:
> add cast for tostring to fix google3
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2385353002
>
> TBR=True
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/4cfd5af26e5fab1699cfa2ab40d49c24cededd72
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2384303002
2016-10-03 14:33:48 -07:00
reed
4cfd5af26e
add cast for tostring to fix google3
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2385353002
TBR=True
NOTRY=True
Review-Url: https://codereview.chromium.org/2385353002
2016-10-03 14:20:40 -07:00
bsalomon
0f147ac2ae
Make GrResourceCache dynamically change between LRU and random replacement strategies.
...
Random performs significantly better when each frame exceeds the budget by a small margin whereas LRU has worst case behavior.
The decision of which to use is made based on the history from a few frames of the ratio of total unique key cache misses to unique key cache misses of resources purged in the last 2 frames.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321563006
Review-Url: https://codereview.chromium.org/2321563006
2016-10-03 14:07:01 -07:00
liyuqian
e60d85597f
Add GMs for Analytic Anti-Aliasing
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2386293002
Review-Url: https://codereview.chromium.org/2386293002
2016-10-03 13:49:37 -07:00
fmalita
f85d2a4fa1
Avoid unneeded paint copies in SkDraw::drawBitmap
...
Use SkTCopyOnFirstWrite to only copy when needed.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389973003
Review-Url: https://codereview.chromium.org/2389973003
2016-10-03 13:46:58 -07:00
Greg Daniel
d368211a2a
Remove unused resolve parameters for vulkan render passes
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2874
Change-Id: Ie8ad608c02e824ba5af2a81ada724dca22ac92e5
Reviewed-on: https://skia-review.googlesource.com/2874
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2016-10-03 20:46:56 +00:00
Brian Osman
0d9dfe981e
Supply random dst color space to asFP in unit tests
...
TBR=bsalomon@google.com (Testing-only API change)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2876
Change-Id: I0ca26da0307848cdfc8ffaac2d042601663ab00b
Reviewed-on: https://skia-review.googlesource.com/2876
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2016-10-03 20:23:07 +00:00
Mike Reed
70cdb396eb
Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints""
...
This reverts commit ce02e71758
.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878
Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10
Reviewed-on: https://skia-review.googlesource.com/2878
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2016-10-03 20:02:20 +00:00
Mike Klein
afb48b6227
Just add the F16 bench from https://skia-review.googlesource.com/c/2860/
...
BUG=skia:
TBR=msarett@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2875
Change-Id: I615d7aead07196f5c14b22be6f96e7d555a495a8
Reviewed-on: https://skia-review.googlesource.com/2875
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-10-03 19:32:09 +00:00
Brian Salomon
a3b45d4f7d
Move clip CTM application to SkRasterClip and SkClipStack
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2866
Change-Id: I914a57d6ba128acc457e12586c99ba6766eb940c
Reviewed-on: https://skia-review.googlesource.com/2866
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2016-10-03 19:32:07 +00:00
kjlubick
14f984bc6b
Add fuzz executable to GN
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389853002
Review-Url: https://codereview.chromium.org/2389853002
2016-10-03 11:49:45 -07:00
Brian Osman
e2f732f475
Start supplying random color space xforms to FP tests
...
Added helper to create random GrColorSpaceXforms in unit tests, and
hooked it up for the FPs that currently accept one.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2873
Change-Id: Iaf93e379e405fbf745f5e0fd23b4daf017355966
Reviewed-on: https://skia-review.googlesource.com/2873
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2016-10-03 18:47:42 +00:00
fmalita
7de5779835
Disable the SVG tests on Valgrind bots
...
Timeouts:
https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind
R=stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2385133003
Review-Url: https://codereview.chromium.org/2385133003
2016-10-03 11:07:37 -07:00
Mike Reed
ce02e71758
Revert "replace SkXfermode obj with SkBlendMode enum in paints"
...
This reverts commit I4fb489ba6b3f77b458f7e4a99f79c7ad10859135.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> replace SkXfermode obj with SkBlendMode enum in paints
>
> BUG=skia:5814
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714
>
> Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135
> Reviewed-on: https://skia-review.googlesource.com/2714
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>
TBR=bsalomon@google.com ,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I3e43f79ef5c1709929663fe63cc1f67cd78270b7
Reviewed-on: https://skia-review.googlesource.com/2871
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2016-10-03 18:03:29 +00:00
Brian Osman
6fb592e6af
Add color space xform to GrAlphaThresholdFragmentProcessor
...
Fix imagealphathreshold_surface GM to test gamut conversion.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2867
Change-Id: Id9aaebe72d1dadc613ef1a8d17d066b51049300f
Reviewed-on: https://skia-review.googlesource.com/2867
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2016-10-03 17:56:31 +00:00
Ben Wagner
57d49e4471
Remove exec bit from source file.
...
Exec bit added in https://skia.googlesource.com/skia/+/40ff5fe59b77b0b3e34467cc2f8666e4e88356f9
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2869
Change-Id: I238f75fe2a865923568ac8f63ee1978df6c89f6c
Reviewed-on: https://skia-review.googlesource.com/2869
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2016-10-03 17:39:54 +00:00
reed
2a62e853c2
remove quickreject for drawables
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388873002
Review-Url: https://codereview.chromium.org/2388873002
2016-10-03 10:35:37 -07:00
Mike Reed
0591897548
replace SkXfermode obj with SkBlendMode enum in paints
...
BUG=skia:5814
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714
Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135
Reviewed-on: https://skia-review.googlesource.com/2714
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2016-10-03 17:17:10 +00:00
bsalomon
a224bb7027
Avoid unnecessary GrShape->SkPath conversion in GrStencilAndCoverPathRenderer
...
Also remove redundant param to the path batch constructor.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348543002
Review-Url: https://codereview.chromium.org/2348543002
2016-10-03 09:48:22 -07:00
Brian Osman
01015fbea1
Fix alpha threshold GM to test with and without crop rect
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2864
Change-Id: I09f24303b2a693a384fb7399c2287ab476f16319
Reviewed-on: https://skia-review.googlesource.com/2864
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2016-10-03 16:18:09 +00:00
robertphillips
6df2c8e8e0
Fix precision issues in SkRRectsGaussianEdgeShader.cpp
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383863002
Review-Url: https://codereview.chromium.org/2383863002
2016-10-03 08:41:04 -07:00
borenet
497630a2af
Roll recipe DEPS
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2386153002
Review-Url: https://codereview.chromium.org/2386153002
2016-10-03 06:21:56 -07:00
Mike Klein
f3c874a984
There are no more cmake bots, so clean up their old scripts.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2854
Change-Id: Ieb94788182b35d8fd3197ce090d5f28a65903204
Reviewed-on: https://skia-review.googlesource.com/2854
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-09-30 22:19:20 +00:00
Mike Klein
7a02f019f2
Delete unused avx2_sources.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2853
Change-Id: If546af6bea8c51b857860be6d266347cdf064d33
Reviewed-on: https://skia-review.googlesource.com/2853
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-09-30 20:48:26 +00:00
fmalita
5776508126
Add a SkRWBuffer reserve mechanism
...
Currently, Chromium stores segmented data in a SharedBuffer and appends
to SkRWBuffer one segment at a time:
const char* segment = 0;
for (size_t length = data->getSomeData(segment, m_rwBuffer->size());
length; length = data->getSomeData(segment, m_rwBuffer->size())) {
m_rwBuffer->append(segment, length, remaining);
}
This can yield a bunch of just-above-4k allocations => wasted RAM due to
internal fragmentation.
Ideally, we'd want a SkRWBuffer::reserve(size_t bytes) API, but the
current internals don't support that trivially.
Alternatively, the caller can pass a reserve hint at append() time.
BUG=chromium:651698
R=scroggo@google.com ,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2385803002
Review-Url: https://codereview.chromium.org/2385803002
2016-09-30 13:34:19 -07:00
msarett
f6566314f8
Fix nanobench crashes
...
TBR=egdaniel@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383223003
Review-Url: https://codereview.chromium.org/2383223003
2016-09-30 13:09:01 -07:00
borenet
db182c770f
[task scheduler] Add gen_tasks.go
...
This mimics the flow of infra/bots/recipes/swarm_trigger.py
but it builds the tasks.json file instead of triggering the
actual tasks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2386663002
Review-Url: https://codereview.chromium.org/2386663002
2016-09-30 12:53:12 -07:00
Mike Reed
476e6c9a7f
fix mac build
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2852
Change-Id: I58ba4c8be14b5a40ae94a1f8e69a3c1aa08060d5
Reviewed-on: https://skia-review.googlesource.com/2852
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2016-09-30 19:47:28 +00:00
msarett
71df2d7bc1
Add a src rect to drawImageLattice() API
...
This will allow us to draw ninepatches directly from an asset
texture without having to upload them individually.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382893002
Review-Url: https://codereview.chromium.org/2382893002
2016-09-30 12:41:42 -07:00
borenet
9c8a32ff45
Stop uploading nanobench results on Valgrind bot
...
It's not needed, and it's probably making the bot a lot slower.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382313003
Review-Url: https://codereview.chromium.org/2382313003
2016-09-30 12:39:31 -07:00
borenet
d5603e670b
upload_dm_results: Remove JSON validation step
...
This is infra-failing frequently for some reason, possibly due to large
file size?
TBR=stephana
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383163002
Review-Url: https://codereview.chromium.org/2383163002
2016-09-30 12:18:47 -07:00
Hal Canary
b3480e1cb7
SkPDF: de-duplicate text-as-paths
...
TBR=
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2851
Change-Id: I0accbca13945587cd5ef903cbd4127f1f6a3fb13
Reviewed-on: https://skia-review.googlesource.com/2851
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2016-09-30 19:14:20 +00:00
benjaminwagner
c8962518dd
Unomit SkSL in public.bzl.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2380563006
Review-Url: https://codereview.chromium.org/2380563006
2016-09-30 12:06:27 -07:00
Brian Salomon
789e25ea7d
Add gn option to set the location of the Vulkan SDK
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2848
Change-Id: I0b60ae03d7b155d4f9a581cab6b551e152b03a86
Reviewed-on: https://skia-review.googlesource.com/2848
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-09-30 18:02:59 +00:00
fmalita
2e36e88f40
SkRWBuffer: preallocate 'initialCapacity'
...
We're currently ignoring the hint, resulting in multiple unneeded
allocations later.
BUG=chromium:651698
R=scroggo@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2384763002
Review-Url: https://codereview.chromium.org/2384763002
2016-09-30 10:52:08 -07:00
Mike Klein
c8deb02334
Clean up public.bzl after G3-side CL.
...
One more tiny G3 CL after this...
BUG=skia:
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2847
Change-Id: Id237ca3853614c2b9b68eb0a679f6e64b3e95983
Reviewed-on: https://skia-review.googlesource.com/2847
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-09-30 17:38:30 +00:00
Brian Osman
c68d4aa4ea
Helper functions to do SkColor -> GrColor4f
...
I started fixing more effects and realized I needed something like this.
Wanted to land it separately. After this, I'll add the DC's cached xform
from sRGB to AsFPArgs, so that we can easily leverage this code in more
places (mostly GrConstColorProcessor, or any effect that falls back to
that based on invariants, etc...)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2844
Change-Id: I335546f02a6c49620494d736140a72c14441b35d
Reviewed-on: https://skia-review.googlesource.com/2844
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2016-09-30 17:33:45 +00:00
reed
d921dbb9b8
Propagate validation errors from inner readbuffer when deserializing picture. Also allow null paints.
...
BUG=skia:5812
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379383002
Review-Url: https://codereview.chromium.org/2379383002
2016-09-30 09:27:20 -07:00
jvanverth
84741b3084
Add fence support for TransferBuffers
...
BUG=skia:4604
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2384463003
Review-Url: https://codereview.chromium.org/2384463003
2016-09-30 08:39:03 -07:00
Mike Klein
7147505955
Fix G3 excludes lists for AVX2 -> HSW.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2843
Change-Id: I8dfd4133808dd768217a7978d7ae3f6d518cd744
Reviewed-on: https://skia-review.googlesource.com/2843
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-09-30 15:35:24 +00:00
Hal Canary
f50ff39f47
SkPDF: subset drawImageRect while still deduping
...
- Replace SkImageBitmap with SkImageSubset
- SkBitmapKey becomes trivial for simplicity.
- SkPDFCanvas::onDraw(Bitmap|Image)Rect now clip and call
SkCanvas::onDraw(Bitmap|Image)Rect.
- SkPDFDevice::draw(Bitmap|BitmapRect|Sprite) now convert bitmap
into SkImageSubset via make_image_subset function.
- SkPDFDevice::draw(Image|Bitmap)Rect now implemented again.
- SkPDFDevice::internalDrawImage now performs image subsetting
as needed, while still deduping properly.
BUG=633528
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2785
Change-Id: I063346d12b0e9c6b6c0c4943ee25400c88aa1a44
Reviewed-on: https://skia-review.googlesource.com/2785
Reviewed-by: Ben Wagner <bungeman@google.com>
2016-09-30 15:22:06 +00:00
Mike Klein
78d5a3bac5
Add an SkOpts target for Haswell+ Intel chips.
...
Haswell brought a whole slew of handy new instructions for us (AVX2, FMA, BMI1+BMI2) and also feature F16C, which came one generation earlier on Ivybridge. We work with integers often enough that we really want to target AVX2 instead of AVX, and this means it's pretty practical to ask for all those other goodies along with it.
Chrome's GN files and Google3's BUILD file will need an update, before or after this CL.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2840
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: I826daf77b5104664c5d31ddaabee347e287b87a2
Reviewed-on: https://skia-review.googlesource.com/2840
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
2016-09-30 15:10:48 +00:00
fmalita
d214d6ae69
Revert of Turned on SkSL->GLSL compiler (patchset #41 id:880001 of https://codereview.chromium.org/2288033003/ )
...
Reason for revert:
1) Chromium roll failures: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/307297/steps/screenshot_sync_tests%20on%20NVIDIA%20GPU%20on%20Linux%20%28with%20patch%29%20on%20Linux/logs/stdio
2) G3 roll failures
3) iOS failures: https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release/builds/7177/steps/perf_skia%20on%20iOS-9.2/logs/stdio
Original issue's description:
> Turned on SkSL->GLSL compiler
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003
>
> Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3
> Committed: https://skia.googlesource.com/skia/+/b12b3c6908c62c908b3680be01e3b5bfd30de310
> Committed: https://skia.googlesource.com/skia/+/f008b0a59f45c0d4bea3e66faf3b01805009ec89
TBR=benjaminwagner@google.com ,bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2387643003
2016-09-30 08:05:24 -07:00
Ben Wagner
bc34404dc3
Implement 'action' in gn_to_cmake.py.
...
With this change it is possible to build all Skia targets.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2784
Change-Id: I5c53a6ba5746d210e0ae8f7a29b409d40c7b9bff
Reviewed-on: https://skia-review.googlesource.com/2784
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-09-30 13:29:52 +00:00
ethannicholas
f008b0a59f
Turned on SkSL->GLSL compiler
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003
Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3
Committed: https://skia.googlesource.com/skia/+/b12b3c6908c62c908b3680be01e3b5bfd30de310
Review-Url: https://codereview.chromium.org/2288033003
2016-09-30 06:23:25 -07:00
fmalita
ed38772630
Revert of Fix gamut GM to work w/serialization configs. Remove it from blacklist. (patchset #2 id:20001 of https://codereview.chromium.org/2383513002/ )
...
Reason for revert:
Valgrind errors:
==2603== Invalid read of size 8
==2603== at 0xA284E0: SkSurface::getCanvas() (SkSurface_Base.h:108)
==2603== by 0x4F0B0F: gamut_GM(SkCanvas*) (gamut.cpp:163)
==2603== by 0x483B77: DM::GMSrc::draw(SkCanvas*) const (DMSrcSink.cpp:69)
==2603== by 0x485F04: DM::GPUSink::draw(DM::Src const&, SkBitmap*, SkWStream*, SkString*) const (DMSrcSink.cpp:1226)
==2603== by 0x47E974: dm_main() (DM.cpp:1035)
==2603== by 0x6652EC4: (below main) (libc-start.c:287)
==2603== Address 0x20 is not stack'd, malloc'd or (recently) free'd
==2603==
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/1410/steps/test_skia%20on%20Ubuntu/logs/stdio
Original issue's description:
> Fix gamut GM to work w/serialization configs. Remove it from blacklist.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383513002
>
> Committed: https://skia.googlesource.com/skia/+/e4a17372a188f1dffc3f9c9bcdfbb9860728630b
TBR=reed@google.com ,borenet@google.com,brianosman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2380313002
2016-09-30 06:14:49 -07:00
brianosman
35a02a83f5
Support monitor profile in SampleApp (on Windows)
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381913003
Review-Url: https://codereview.chromium.org/2381913003
2016-09-29 14:37:02 -07:00