halcanary
9d524f22bf
Style bikeshed - remove extraneous whitespace
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002
Review URL: https://codereview.chromium.org/1842753002
2016-03-29 09:03:53 -07:00
mtklein
18300a3aa7
detach -> release
...
The C++ standard library uses the name "release" for the operation we call "detach".
Rewriting each "detach(" to "release(" brings us a step closer to using standard library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).
This was a fairly blind transformation. There may have been unintentional conversions in here, but it's probably for the best to have everything uniformly say "release".
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1809733002
Review URL: https://codereview.chromium.org/1809733002
2016-03-16 13:53:35 -07:00
robertphillips
d8982d7e92
Revert of Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) (patchset #2 id:20001 of https://codereview.chromium.org/1378023004/ )
...
Reason for revert:
Trial run confirmed layout test expectations - will reland after suppressions
Original issue's description:
> Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)
>
> Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db
>
> Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1378813004
2015-10-04 12:21:33 -07:00
robertphillips
5175b95630
Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)
...
Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db
Review URL: https://codereview.chromium.org/1378023004
2015-10-04 08:36:51 -07:00
robertphillips
30c4cae7d3
Add special case circle blur for Ganesh
...
This makes the blurcircles bench go from ~33us to ~8us on Windows desktop.
It will require layout test suppressions
Review URL: https://codereview.chromium.org/1311583005
2015-09-15 10:20:55 -07:00
halcanary
96fcdcc219
Style Change: NULL->nullptr
...
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
2015-08-27 07:41:16 -07:00
halcanary
385fe4d4b6
Style Change: SkNEW->new; SkDELETE->delete
...
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
2015-08-26 13:07:49 -07:00
reed@google.com
daaafa6e81
add asAShadowBlur for android to drawlooper
...
BUG=skia:
R=djsollen@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/253633003
git-svn-id: http://skia.googlecode.com/svn/trunk@14431 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 15:20:16 +00:00
commit-bot@chromium.org
3d8bf232bd
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
Committed: http://code.google.com/p/skia/source/detail?r=14404
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14420 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:49:24 +00:00
commit-bot@chromium.org
55aec08681
revert humper changes
...
https://skia.googlesource.com/skia.git/+/24e91ba3029a3a1fb60cab3ae4e68c3c44776f25
https://skia.googlesource.com/skia.git/+/a36c78240e14aeb130a97c43f3992ea19696b929
NOTREECHECKS=true
BUG=skia:
R=caryclark@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/256803011
git-svn-id: http://skia.googlecode.com/svn/trunk@14414 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 18:21:24 +00:00
commit-bot@chromium.org
e396455d2d
move common blur types into central header
...
BUG=skia:
R=scroggo@google.com , djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/253833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14411 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 16:25:35 +00:00
commit-bot@chromium.org
24e91ba302
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14404 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 15:09:14 +00:00
commit-bot@chromium.org
c76a4b2a81
Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU ( https://codereview.chromium.org/248613004/ )
...
Reason for revert:
Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio
Original issue's description:
> Fast path for blurred round rects -- blur a small 9patch rect on the CPU
> And nonlinearly stretch the resulting texture across proxy geometry.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com , reed@google.com , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/258893010
git-svn-id: http://skia.googlecode.com/svn/trunk@14400 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:44:54 +00:00
commit-bot@chromium.org
5729387fe0
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14392 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:23 +00:00
commit-bot@chromium.org
a477154cfc
plumb API for analytic rrect blur
...
BUG=skia:2281
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/189663012
git-svn-id: http://skia.googlecode.com/svn/trunk@13733 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 21:42:06 +00:00
skia.committer@gmail.com
4c18e9fbb6
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13258 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 03:01:59 +00:00
commit-bot@chromium.org
cf34bc0634
patch from issue 119343003
...
compile on 10.6, exclude failing gms
Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over.
NOTRY=true
R=bsalomon@google.com , epoger@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/148883005
git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 15:34:43 +00:00
commit-bot@chromium.org
dcfa9ff57c
Revert of Fast blurred rectangles on GPU ( https://codereview.chromium.org/119343003/ )
...
Reason for revert:
Two problems:
1. broke compile on Build-Mac10.6-* bots
2. broke GM expectations on many bots
We'll need to examine the GM impact before re-landing. I can work with you to do this on Tuesday if you like; just IM or email me.
Original issue's description:
> Perform the same analytic blur calculation on the GPU that we do on the CPU. Results in significant performance gains when using Ganesh to render drop shadows in Chrome.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=13210
R=bsalomon@google.com , reed@google.com , humper@google.com , rmistry@google.com
TBR=bsalomon@google.com , humper@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: epoger@google.com
Review URL: https://codereview.chromium.org/140853008
git-svn-id: http://skia.googlecode.com/svn/trunk@13213 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 01:55:24 +00:00
commit-bot@chromium.org
d1829151a5
Perform the same analytic blur calculation on the GPU that we do on the CPU. Results in significant performance gains when using Ganesh to render drop shadows in Chrome.
...
BUG=
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/119343003
git-svn-id: http://skia.googlecode.com/svn/trunk@13210 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 22:41:45 +00:00
reed@google.com
e1ca705cac
deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients
...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/111353003
git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 19:22:07 +00:00
commit-bot@chromium.org
4b413c8bb1
remove SkFloatToScalar macro
...
BUG=
R=reed@google.com , djsollen@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/85463005
git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 19:44:07 +00:00
senorblanco@chromium.org
f14bcd25e5
Remove some now-unused #ifdefs.
...
R=mtklein@google.com , mtklein, reed@google.com
Review URL: https://codereview.chromium.org/68473003
git-svn-id: http://skia.googlecode.com/svn/trunk@12246 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 16:46:43 +00:00
robertphillips@google.com
3dfa4cc07c
Add test to exercise extreme blur sigmas
...
https://codereview.chromium.org/23530039/
git-svn-id: http://skia.googlecode.com/svn/trunk@11099 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-05 16:39:03 +00:00
skia.committer@gmail.com
7bd141dce4
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10968 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 07:01:18 +00:00
robertphillips@google.com
7ce661d19c
Blur refactoring
...
https://codereview.chromium.org/21835004/
git-svn-id: http://skia.googlecode.com/svn/trunk@10936 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:14:03 +00:00
robertphillips@google.com
17ad2bd077
Fix quickReject computation for blurs
...
https://codereview.chromium.org/17035007/
git-svn-id: http://skia.googlecode.com/svn/trunk@10428 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 12:15:19 +00:00
commit-bot@chromium.org
0a1c3872de
Remove the non-separable blur because it is no longer used.
...
R=senorblanco@chromium.org , reed@google.com
Author: arbesfeld@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16750002
git-svn-id: http://skia.googlecode.com/svn/trunk@9503 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-11 15:23:42 +00:00
skia.committer@gmail.com
2e71f1619d
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8090 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 07:12:32 +00:00
humper@google.com
d4d573057e
add proper support for solid style, and temporarily turn off my change so the bots can go green |
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8085 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 22:18:54 +00:00
humper@google.com
68a690cb05
fix pad bug introduced during code cleanup
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8083 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 21:16:20 +00:00
humper@google.com
adef4fefd3
fix build warnings
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8078 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:32:05 +00:00
humper@google.com
7c5d7b7813
Plumb fast rectangle blur code into the skia mask filter
...
Review URL: https://codereview.chromium.org/12387099
git-svn-id: http://skia.googlecode.com/svn/trunk@8074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:16:28 +00:00
skia.committer@gmail.com
d454ec135e
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7803 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-21 07:15:03 +00:00
jvanverth@google.com
d98df1a3c4
Fix compile errors in blur code on Windows.
...
Various typecasts to remove warnings and get this code building on Windows.
git-svn-id: http://skia.googlecode.com/svn/trunk@7797 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-20 19:02:34 +00:00
humper@google.com
1e1a24e2ca
remove blur radius reinterpretation for now to make rebaselining simpler and avoid significant changes to webkit and JNI -- those come later
...
BUG=
Review URL: https://codereview.appspot.com/7391043
git-svn-id: http://skia.googlecode.com/svn/trunk@7795 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-20 18:35:40 +00:00
humper@google.com
a99a92ceba
Complete the implementation of the faster blur; now supports all blur styles and matches the boxfilter approximation visually. Also change the interpretation of the blur radius to be sigma/2; need to add SK_IGNORE_BLUR_RADIUS_CORRECTNESS to chromium GYP to avoid immediate layout test failures over there.
...
Review URL: https://codereview.appspot.com/7307076
git-svn-id: http://skia.googlecode.com/svn/trunk@7793 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-20 16:42:06 +00:00
skia.committer@gmail.com
76bf70d38f
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7787 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-20 07:02:30 +00:00
senorblanco@chromium.org
a62a9ce9e6
Enable blur rounding (unreviewed).
...
At a minimum, the following tests will need a rebaseline: tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect, blurs, drawbitmapmatrix.
git-svn-id: http://skia.googlecode.com/svn/trunk@7769 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-19 17:09:14 +00:00
senorblanco@chromium.org
4a525d7fc2
Add rounding to the separable blurs. This should ensure that the box blurs are energy-preserving (ie., blurring solid 255 alpha stays 255 alpha).
...
Disabled by default; will enable & rebaseline.
Review URL: https://codereview.appspot.com/7350043
git-svn-id: http://skia.googlecode.com/svn/trunk@7768 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-19 16:09:10 +00:00
bsalomon@google.com
33cdbdea3d
Fix leaks in blurrect benchs and gm.
...
Review URL: https://codereview.appspot.com/7071060
git-svn-id: http://skia.googlecode.com/svn/trunk@7142 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:54:44 +00:00
jvanverth@google.com
9c4e5ac5b7
Cleaned up warnings in Windows build.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7057 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 18:41:28 +00:00
skia.committer@gmail.com
8ae714b186
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-05 02:02:05 +00:00
humper@google.com
7c7292c607
Added a new function to directly generate a blurred rectangle analytically.
...
Added two new microbenchmarks to demonstrate speedup over existing BlurSeparable approach.
Added new GM tests for blurred rectangles.
Review URL: https://codereview.appspot.com/7037050
git-svn-id: http://skia.googlecode.com/svn/trunk@7034 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 20:29:03 +00:00
senorblanco@chromium.org
91f489a65d
Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs. Change the Coarse flag (which just turns on separable blurs) to an #ifdef, since separable is no longer just Coarse. (This #ifdef will hopefully be shortlived, once Chrome has switched).
...
The separable blur algorithm gives +45% on SampleBlur, +84% on SampleBigBlur, +31% on TheVerge, +35 to +85% on blurbench in HQ (depending on size), +8 to +35% in low quality. (All of these on 32bit MacPro).
Review URL: https://codereview.appspot.com/6851117
git-svn-id: http://skia.googlecode.com/svn/trunk@6601 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 17:09:27 +00:00
senorblanco@chromium.org
9b0d4d79f0
Implement radius interpolation for separable blur. Unroll both separable implementations, which yields up to 2X perf improvement.
...
Review URL: https://codereview.appspot.com/6850088
git-svn-id: http://skia.googlecode.com/svn/trunk@6576 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 22:57:41 +00:00
senorblanco@chromium.org
336b4da6b0
Separable mask blurs: Add compile-time flag. Fix reversed offsets in asymmetrical blurs (this bug cancels itself out, but I thought it might be confusing for future readers). Use correct stride in asymmetrical blurs (this is a real bug).
...
Review URL: https://codereview.appspot.com/6782089
git-svn-id: http://skia.googlecode.com/svn/trunk@6508 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 17:09:40 +00:00
senorblanco@chromium.org
c438130964
Separable blur: subpixel blurring. We approximate intermediate values of blur for even kernel sizes by using a kernel of size N offset to the left in the first pass, a kernel of size N offset to the right in the second pass, and a centered kernel of size N + 1 in the third pass. This required adding support for asymmetrical radii to the box blur.
...
Since this can only be done in the 3-pass blur for separable blurs, we turn off the optimization that drops to low quality for blurs of < 3 pixels.
Review URL: https://codereview.appspot.com/6843072
git-svn-id: http://skia.googlecode.com/svn/trunk@6464 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 17:22:33 +00:00
skia.committer@gmail.com
884e60be30
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6447 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 02:01:17 +00:00
senorblanco@chromium.org
908276b396
Reorder the separable blur passes into XXX/YYY, with an image transpose on the last pass of each group. This results in continuguous memory reads in all passes, giving a 22% speedup on theverge.skp over the previous separable implementation, and a 30%-50% improvement over the existing implementation (depending on platform).
...
Review URL: https://codereview.appspot.com/6851053
git-svn-id: http://skia.googlecode.com/svn/trunk@6445 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-15 20:27:35 +00:00
senorblanco@chromium.org
72fac3533e
Build fix. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6406 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-13 20:41:43 +00:00