skia.committer@gmail.com
f54ad6f488
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12101 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-02 07:02:02 +00:00
caryclark@google.com
585744a7db
fix more expectations for shadertext shadertext2 hairlines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12099 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 21:15:01 +00:00
vandebo@chromium.org
fc7f6384a2
Update missed expectations for xfermodes
...
ref: r12034, r12053
Review URL: https://codereview.chromium.org/56473003
git-svn-id: http://skia.googlecode.com/svn/trunk@12098 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 21:10:17 +00:00
caryclark@google.com
c7b14a6633
update ignored tests with rebaselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12097 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 20:45:49 +00:00
caryclark@google.com
c57503629f
fix shadertext2 expectations
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12096 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 20:34:24 +00:00
caryclark@google.com
353372b19a
fix shadedtext expectations
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12095 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 20:25:47 +00:00
caryclark@google.com
23aa56fed0
fix hairline expectations
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12094 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 20:16:50 +00:00
caryclark@google.com
24ebc011ae
fix expectations for arcofzorro
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12093 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 20:02:16 +00:00
caryclark@google.com
97b2de9af4
ignore gm roundrect errors including arcofzorro
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12092 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 19:28:33 +00:00
robertphillips@google.com
32700ace30
Reverting r12082 (Add bevel-stroke support in GrAARectRenderer) due to GM failures
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12091 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 19:22:42 +00:00
caryclark@google.com
61f8a6726d
ignore gm roundrect errors
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12090 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 19:18:59 +00:00
caryclark@google.com
a2bbc6e19d
pathops work in progress
...
BUG=
Review URL: https://codereview.chromium.org/52653002
git-svn-id: http://skia.googlecode.com/svn/trunk@12089 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 17:36:03 +00:00
epoger@google.com
045c3d330c
rebaseline_server: make default landing page list supported query URLs
...
(SkipBuildbotRuns)
Originally, the default landing page redirected to view.html?resultsToLoad=all
(which displays all results, and can take a while).
Instead, start with a fast-loading page that shows the user all the result
sets that are available.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/46413004
git-svn-id: http://skia.googlecode.com/svn/trunk@12088 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 16:46:41 +00:00
reed@google.com
f0784bde75
Revert "Avoid re-rendering stencil clip for every draw with reducable clip stack"
...
This reverts commit 92a7d4bf6a371f1f864154be902e8d86938e560b.
Revert "fix mac 10.6 build"
This reverts commit 114cd1a9f2734aaed6914718814364811b78bd7f.
BUG=
Review URL: https://codereview.chromium.org/54543008
git-svn-id: http://skia.googlecode.com/svn/trunk@12087 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 16:25:59 +00:00
reed@google.com
eea3ab78e9
fix mac 10.6 build
...
- double -> float implicit conversion (for literals like 1.3)
- locally defined (and named) struct
R=scroggo@google.com
Review URL: https://codereview.chromium.org/56103002
git-svn-id: http://skia.googlecode.com/svn/trunk@12086 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 16:15:01 +00:00
commit-bot@chromium.org
f91aaecbe9
Construct round rects with perpendicular tangents.
...
The round rects are constructed as before out of quadratics,
but without fudging the control points. Instead, the mid on-
curve point is nudged slightly outward to prevent the
convexity test from failing.
The convexity test now includes an error term for sign
inequality after computing the cross product of the control
lines. When the control points are represented as vectors,
the number of bits of precision may be greatly reduced.
Account for this by passing the number of bits available
from the original control point values into the equality
check.
Making round rect construction lines perpendicular improves
the chances of success when path ops encounters clips.
No new tests are needed -- this change is exercised by the
convex Path unit tests and the gm tests arcofzorro and
hairlines.
R=robertphillips@google.com , reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/48783002
git-svn-id: http://skia.googlecode.com/svn/trunk@12085 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 15:24:55 +00:00
commit-bot@chromium.org
679eb674fc
Avoid re-rendering stencil clip for every draw with reducable clip stack
...
Fixes the cases where clip stack reduction would cause clip to be
re-rendered to stencil for each draw call. This causes unneeded
slowdown.
Stencil cache would not be used because the clip stack generation id communicated
by the clip stack element list would be invalid. This happended due to
a) clip stack reduction creating new elements in the element list.
b) purging logic removing the generation id, but reduction logic
selecting already purged element, and thus the generation id, as
the representative state of the clip.
Cases of a) where reduction would flatten the stack to a single new
element were fixed by assigning the generation id of the top-most
element of the clip stack as the generation id of the new
element. This is not strictly minimal, but enables more caching than
using invalid id.
Cases of a) where reduction would substitute a stack element with a
new element the generation id of the substituted element is used.
The b) part was fixed by removing the purging logic. It was not
exactly correct, as the previously purged states were actually
used. The purging was not used for anything.
Changes SkClipStack API to highlight that invalid generation id is
never returned by SkClipStack. Empty stacks are wide open. Changes the
clients to reflect this.
Fixes a crash when not passing anti-alias out parameter to
GrReducedClip::ReduceClipStack. The crash is not exercised in the
current code.
R=bsalomon@google.com , robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/48593003
git-svn-id: http://skia.googlecode.com/svn/trunk@12084 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 15:24:20 +00:00
commit-bot@chromium.org
5c8ee2539b
Make GrContext cache the gpu paths
...
Creating paths for nv_path_rendering is costly. Try to reduce this
cost by caching paths based on the SkPath "hash" (i.e. SkPathRef
generation id) and stroke properties.
Adds the paths to GrContext::fTextureCache instance. Later this should
be renamed and the GrContext API should reflect the nature of the cache
better.
R=bsalomon@google.com , mtklein@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/26557003
git-svn-id: http://skia.googlecode.com/svn/trunk@12083 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 15:23:44 +00:00
commit-bot@chromium.org
e1e99ef0af
Add bevel-stroke support in GrAARectRenderer
...
R=robertphillips@google.com , bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/23712005
git-svn-id: http://skia.googlecode.com/svn/trunk@12082 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 15:23:17 +00:00
robertphillips@google.com
9a0f0006b2
Rebaseline improved N4 images
...
https://codereview.chromium.org/49983005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12081 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 15:11:18 +00:00
robertphillips@google.com
8995b7b626
Only disable scratch texture reuse on the N10 and N4
...
https://codereview.chromium.org/48903017/
git-svn-id: http://skia.googlecode.com/svn/trunk@12080 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 15:03:34 +00:00
epoger@google.com
7b1c2c102e
rebaseline_server: right-align "select/clear/toggle all tests" buttons with results table
...
(SkipBuildbotRuns)
R=edisonn@google.com
Review URL: https://codereview.chromium.org/55073003
git-svn-id: http://skia.googlecode.com/svn/trunk@12079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 14:29:03 +00:00
reed@google.com
2bd8b81005
move SkImage::ColorType into SkColorType
...
objective -- move clients over to SkImage
tasks
- use SkImageInfo instead of SkBitmap::Config
- add support for colortables to SkImage
- add drawImage to SkCanvas
- return SkImage from readPixels
This CL works towards the first task
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/54363008
git-svn-id: http://skia.googlecode.com/svn/trunk@12077 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 13:46:54 +00:00
edisonn@google.com
05d56ebbf3
Update results for a Nexus4 tests that don't render well with perspective
...
Review URL: https://codereview.chromium.org/55633003
git-svn-id: http://skia.googlecode.com/svn/trunk@12076 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 12:33:43 +00:00
commit-bot@chromium.org
f2f8f3a43c
Adding a way to disable SkOffsetImageFilter's optimized path in blink/chrome
...
BUG=
R=senorblanco@chromium.org , reed@google.com , sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/54543005
git-svn-id: http://skia.googlecode.com/svn/trunk@12075 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 11:55:06 +00:00
commit-bot@chromium.org
2080722493
Fix two inconsistencies in handling fixed-function texture coordinate set generation
...
Prevent off-by-one bug leaving the texture coordinate set 0 always enabled if
it ever was used. This makes the code consistent with its apparent purpose.
When enabling / disabling texture coordinate sets, call glPathTexGen
only if path rendering is applicable. This makes the functions
consistent with GrGpuGL::resetContext.
R=cdalton@nvidia.com , bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/54403003
git-svn-id: http://skia.googlecode.com/svn/trunk@12074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 11:54:54 +00:00
commit-bot@chromium.org
a0fd1b3407
add some GM tests for rects
...
BUG=
R=robertphillips@google.com , bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/54213002
git-svn-id: http://skia.googlecode.com/svn/trunk@12073 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 11:54:29 +00:00
skia.committer@gmail.com
18bb41e956
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12071 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 07:02:15 +00:00
robertphillips@google.com
3b60c14e66
Fix for r12069 (actually turn on don't-reuse-scratch-textures feature)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12070 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 01:55:40 +00:00
robertphillips@google.com
f7ee05fa9d
Turn on don't-reuse-scratch-textures for all Android devices
...
https://codereview.chromium.org/54493005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 00:40:47 +00:00
robertphillips@google.com
7124abdf86
Another rebaseline
...
https://codereview.chromium.org/46043021/
git-svn-id: http://skia.googlecode.com/svn/trunk@12068 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 23:20:03 +00:00
robertphillips@google.com
d2f7948cdf
Disabling SK_ATTR_DEPRECATED the hard way
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12067 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 22:42:33 +00:00
robertphillips@google.com
77121cf843
More image rebaselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12066 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 22:36:37 +00:00
robertphillips@google.com
fd3ae2e576
Yet more rebaselines
...
https://codereview.chromium.org/55303004/
git-svn-id: http://skia.googlecode.com/svn/trunk@12065 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 22:21:25 +00:00
robertphillips@google.com
56ce48ade3
Add can-ignore-rect hint to clear call
...
https://codereview.chromium.org/53823003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 21:44:25 +00:00
robertphillips@google.com
fc7ceefd1a
Add suppressions for Issue 1784
...
https://codereview.chromium.org/49533006/
git-svn-id: http://skia.googlecode.com/svn/trunk@12063 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 21:27:44 +00:00
commit-bot@chromium.org
3843f3fc89
Partial fix for Skia issue 1769: GenerateGMs crashing (out of memory)
...
GenerateGMs was crashing because we were adding genID listeners for
textures even when creation failed -- in this case the key generated
is not valid, so when it comes time to purge it, it triggers an
assert and then an apparent crash. The solution is to not add
a genID listener in this case.
This doesn't solve the problem of running out of memory, it just prevents it
from causing a crash in Debug builds.
BUG=
R=bsalomon@google.com , robertphillips@google.com , mtklein@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/55023005
git-svn-id: http://skia.googlecode.com/svn/trunk@12062 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 20:22:47 +00:00
robertphillips@google.com
908f1270c7
Rebaseline images that improved with 12037
...
https://codereview.chromium.org/55193002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12061 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 19:43:24 +00:00
robertphillips@google.com
f1df61c243
Rebaseline lingering RoundRect RHB images
...
https://codereview.chromium.org/52713011/
git-svn-id: http://skia.googlecode.com/svn/trunk@12060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 19:36:42 +00:00
commit-bot@chromium.org
0251288112
Adding size parameter to read array functions
...
In some cases, the allocated array into which the data will be read is using getArrayCount() to allocate itself, which should be safe, but some cases use fixed length arrays or compute the array size before reading, which could overflow if the stream is compromised.
To prevent that from happening, I added a check that will verify that the number of bytes to read will not exceed the capacity of the input buffer argument passed to all the read...Array() functions.
I chose to use the byte array for this initial version, so that "size" represents the same value across all read...Array() functions, but I could also use the element count, if it is preferred.
Note : readPointArray and writePointArray are unused, so I could also remove them
BUG=
R=reed@google.com , mtklein@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/37803002
git-svn-id: http://skia.googlecode.com/svn/trunk@12058 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 18:37:50 +00:00
reed@google.com
4469938e92
Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning""
...
This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d.
BUG=
Review URL: https://codereview.chromium.org/54603004
git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 17:28:30 +00:00
reed@google.com
6fcbfcead5
Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"
...
This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497.
git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 16:31:11 +00:00
reed@google.com
081560e3ab
add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning
...
BUG=
R=robertphillips@google.com , senorblanco@chromium.org , vandebo@chromium.org
Review URL: https://codereview.chromium.org/51033004
git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 16:24:08 +00:00
robertphillips@google.com
94bdd7e3fc
Fix bug in don't-reuse-scratch-textures path
...
https://codereview.chromium.org/50853003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12054 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 15:50:43 +00:00
vandebo@chromium.org
e4e5cabb48
Rebaseline for r12034
...
xfermodes changed in all configs - added more src types.
The following gms changed only for pdf configs:
xfermodes2, xfermodes3, aarectmodes, colormatrix, lumafilter, mixed_xfermodes
R=edisonn@google.com
Review URL: https://codereview.chromium.org/54763003
git-svn-id: http://skia.googlecode.com/svn/trunk@12053 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 15:46:38 +00:00
robertphillips@google.com
d5743ed263
Remove suppression of morphology image diffs
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:42:30 +00:00
robertphillips@google.com
0bef50638c
Rebaselines of morphology GM for r11966
...
https://codereview.chromium.org/54353004/
git-svn-id: http://skia.googlecode.com/svn/trunk@12049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:25:18 +00:00
borenet@google.com
44b3a64811
Whitespace change to trigger builds after buildbot script changes
...
Review URL: https://codereview.chromium.org/54673002
git-svn-id: http://skia.googlecode.com/svn/trunk@12047 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:21:32 +00:00
skia.committer@gmail.com
7ed98df9ba
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12043 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 07:01:53 +00:00
robertphillips@google.com
cb505101a2
No longer use scratch textures on ARM devices
...
https://codereview.chromium.org/50643003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12042 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 00:51:18 +00:00