skia.committer@gmail.com
f5e67c12c8
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13105 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-16 07:01:48 +00:00
commit-bot@chromium.org
c665804300
Move SkMessageBus::Get out of header, and retry crrev.com/106563002.
...
BUG=
R=bsalomon@google.com , kkinnunen@nvidia.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/140053002
git-svn-id: http://skia.googlecode.com/svn/trunk@13104 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 23:09:01 +00:00
commit-bot@chromium.org
b06faacaf1
Factor out UnPreMultiplyPreservingByteOrder
...
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/130303005
git-svn-id: http://skia.googlecode.com/svn/trunk@13103 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 22:24:58 +00:00
commit-bot@chromium.org
6a18079de8
Use MACOSX_DEPLOYMENT_TARGET instead of SDKROOT.
...
MACOSX_DEPLOYMENT_TARGET is the minimum unconditionally supported OS,
which should just be 10.6 for us until Chrome changes. SDKROOT is the
maximum conditionally supported OS, which defaults sanely to whatever's
the latest SDK the machine has, so we don't need to mention it.
BUG=skia:
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/137793010
git-svn-id: http://skia.googlecode.com/svn/trunk@13102 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 21:39:18 +00:00
commit-bot@chromium.org
389fb7fcd4
DM: don't change byte order when unpremultiplying to compare to PNGs.
...
We've already decoded the PNGs themselves into unpremultiplied bitmaps with native byte order. SkColor is just not the right choice unless you get lucky.
dm -w /tmp/dm && dm -r /tmp/dm still works on Linux, and it's much closer to working on Mac:
0 tasks left, 2 failed
Failures:
matrixconvolution_gpu
colormatrix_gpu
BUG=skia:
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/139943002
git-svn-id: http://skia.googlecode.com/svn/trunk@13101 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 21:28:25 +00:00
commit-bot@chromium.org
c3147c668c
render_pictures: adjust unittests to show specific failures
...
BUG=skia:2043,skia:2044
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/139383004
git-svn-id: http://skia.googlecode.com/svn/trunk@13100 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 20:35:54 +00:00
commit-bot@chromium.org
43f4a55104
Change to fuzzer for new constructor
...
BUG=skia:
R=senorblanco@google.com , sugoi@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/139613002
git-svn-id: http://skia.googlecode.com/svn/trunk@13099 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 20:20:24 +00:00
reed@google.com
5f62ed7434
no need to refcnt colortables, since pixelrefs own them
...
BUG=skia:
R=halcanary@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/139463007
git-svn-id: http://skia.googlecode.com/svn/trunk@13098 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:59:45 +00:00
commit-bot@chromium.org
a3b15ed037
Make GrGLInterface be context-specific on all platforms
...
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/137753005
git-svn-id: http://skia.googlecode.com/svn/trunk@13097 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:32:03 +00:00
senorblanco@chromium.org
5fdaffdbcb
Add new baselines for bitmapsource, dropshadowimagefilter, pictureimagefilter and resizeimagefilter GMs.
...
TBR=djsollen
Review URL: https://codereview.chromium.org/139513004
git-svn-id: http://skia.googlecode.com/svn/trunk@13096 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:28:53 +00:00
commit-bot@chromium.org
424fce31c1
disable poplar/fontconfig by default on mac
...
BUG=skia:2045
NOTRY=true
R=vandebo@chromium.org , mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/139863002
git-svn-id: http://skia.googlecode.com/svn/trunk@13095 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:28:27 +00:00
commit-bot@chromium.org
04747a53d3
rebaseline_server: ignore TSAN, ASAN, Valgrind bots
...
BUG=skia:2036
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/134643010
git-svn-id: http://skia.googlecode.com/svn/trunk@13094 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:16:09 +00:00
reed@google.com
615316cefb
add asserts to validate
...
BUG=skia:
R=halcanary@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/139063003
git-svn-id: http://skia.googlecode.com/svn/trunk@13093 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:15:23 +00:00
commit-bot@chromium.org
05ec2233e3
change isRect to return true for 3-sided rectangular paths
...
BUG=skia:
R=caryclark@google.com , yunchao.he@intel.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/139483002
git-svn-id: http://skia.googlecode.com/svn/trunk@13092 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 18:00:57 +00:00
commit-bot@chromium.org
fa190be48a
Roll fontconfig to 2.11.0 and reenable poppler on mac
...
R=mtklein@google.com , epoger@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/138843002
git-svn-id: http://skia.googlecode.com/svn/trunk@13091 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 17:24:22 +00:00
scroggo@google.com
5ccae2c5b1
Reland "Fix genID cloning bugs."
...
SkBitmap.cpp:
When copyTo calls readPixels, only clone the genID if the resulting
SkPixelRef has the same dimensions as the original. This catches a
bug where copying an SkBitmap representing the subset of an SkPixelRef
(which implements onReadPixels) would result in the copy sharing the
genID. (Thanks to r6710, this case can only happen using setPixelRef,
so the updated GpuBitmapCopyTest checks for that.)
Move some unnecessary NULL checks to asserts.
When copyTo performs a memcpy, only clone the genID if the resulting
SkPixelRef has the same dimensions as the original. This catches a bug
where copying an extracted SkBitmap with the same width as its original
SkPixelRef would incorrectly have the same genID.
Add a comment and assert in deepCopyTo, when cloning the genID, since
that case correctly clones it.
BitmapCopyTest.cpp:
Pull redundant work out of the inner loop (setting up the source bitmaps
and testing extractSubset). Create a new inner loop for extractSubset, to
test copying the result to each different config.
Extract a subset that has the same width as the original, to catch the
bug mentioned above.
Remove the reporter assert which checks for the resulting rowbytes.
Add checks to ensure that copying the extracted subset changes the genID.
GpuBitmapCopyTest:
Create an SkBitmap that shares an existing SkPixelRef, but only represents
a subset. This is to test the first call to cloneGenID in SkBitmap::copyTo.
In this case, the genID should NOT be copied, since only a portion of the
SkPixelRef was copied.
Also test deepCopy on this subset.
TestIndividualCopy now takes a parameter stating whether the genID should
change in the copy. It also does a read back using the appropriate subset.
It no longer differentiates between copyTo and deepCopyTo, since that
distinction was only necessary for copying from/to configs other than 8888
(which are no longer being tested), where copyTo did a read back in 8888 and
then drew the result to the desired config (resulting in an imperfect copy).
BUG=skia:1742
Committed: http://code.google.com/p/skia/source/detail?r=13021
R=mtklein@google.com
Review URL: https://codereview.chromium.org/112113005
git-svn-id: http://skia.googlecode.com/svn/trunk@13090 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 16:56:52 +00:00
commit-bot@chromium.org
9fcd012f8c
Ignore out even if it's a symlink.
...
R=halcanary@google.com
BUG=
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/139473002
git-svn-id: http://skia.googlecode.com/svn/trunk@13089 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 16:55:04 +00:00
commit-bot@chromium.org
238771c930
[try 2] skpmaker: make the SKP more graphically interesting (add a border)
...
relanding https://codereview.chromium.org/137993008/
BUG=skia:1942
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/139583002
git-svn-id: http://skia.googlecode.com/svn/trunk@13088 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 16:33:31 +00:00
commit-bot@chromium.org
7e1a31db6a
Revert of skpmaker: make the SKP slightly more interesting (add a border) ( https://codereview.chromium.org/137993008/ )
...
Reason for revert:
broke http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/2837
Original issue's description:
> skpmaker: make the SKP slightly more interesting (add a border)
>
> This will help with render_pictures self-testing
> BUG=skia:1942
>
> Committed: http://code.google.com/p/skia/source/detail?r=13086
R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1942
Author: epoger@google.com
Review URL: https://codereview.chromium.org/139553002
git-svn-id: http://skia.googlecode.com/svn/trunk@13087 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 16:04:45 +00:00
commit-bot@chromium.org
a3b0c4fe63
skpmaker: make the SKP slightly more interesting (add a border)
...
This will help with render_pictures self-testing
BUG=skia:1942
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/137993008
git-svn-id: http://skia.googlecode.com/svn/trunk@13086 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 15:40:13 +00:00
robertphillips@google.com
40299fe511
Rebaseline complexclip_aa_layer image for Nexus 4
...
https://codereview.chromium.org/138273008/
git-svn-id: http://skia.googlecode.com/svn/trunk@13085 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 14:52:03 +00:00
commit-bot@chromium.org
17cc3eaeaf
When a picture lies about its size (i.e., claims to be 100x100 but only ever draws to 90x100) arbitrary pixel differences can appear in the undrawn portion. This is causing spurious differences to appear in the 8888 vs. gpu telemetry results.
...
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/136553004
git-svn-id: http://skia.googlecode.com/svn/trunk@13084 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 14:51:25 +00:00
skia.committer@gmail.com
d77b3ecd92
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13083 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 07:01:43 +00:00
senorblanco@chromium.org
a612d4c513
Implement a resize image filter. This is needed for the "filterRes" feature in SVG filter effects, which specifies the required size for intermediate processing buffers. In order to make this work, we need to render the primitive at the given resolution (doable at the callsite in Blink), and then to resize the result to the actual on-screen size. The latter is where this filter comes in.
...
It simply applies a scaling factor (and the current CTM) to its input, and draws its input bitmap at that size.
R=reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=13077
Reverted: https://code.google.com/p/skia/source/detail?r=13078
BUG=
Review URL: https://codereview.chromium.org/136863006
git-svn-id: http://skia.googlecode.com/svn/trunk@13082 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 04:49:18 +00:00
commit-bot@chromium.org
32678d9a45
use some helper Make functions to initialize SkImageInfo
...
BUG=
R=halcanary@google.com , scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/137993012
git-svn-id: http://skia.googlecode.com/svn/trunk@13081 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 02:38:22 +00:00
commit-bot@chromium.org
78f6ddc1a0
rebaseline blur related outputs
...
rebaseline for the differences introduced by https://codereview.chromium.org/105893003/
BUG=
R=senorblanco@chromium.org , reed@google.com
Author: zheng.xu@arm.com
Review URL: https://codereview.chromium.org/136483002
git-svn-id: http://skia.googlecode.com/svn/trunk@13080 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 02:37:57 +00:00
tfarina@chromium.org
62f1048ada
Deprecate two more functions using SK_ATTR_DEPRECATED macro.
...
BUG=None
TEST=None
R=reed@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/136973007
git-svn-id: http://skia.googlecode.com/svn/trunk@13079 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 00:19:21 +00:00
senorblanco@chromium.org
96673a918d
Revert "Implement a resize image filter."
...
This reverts commit 3f996e31c7043929fc1553b9b5ecd6a82b5fe125 (r13077).
TBR=reed
Review URL: https://codereview.chromium.org/136793012
git-svn-id: http://skia.googlecode.com/svn/trunk@13078 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 22:55:04 +00:00
senorblanco@chromium.org
535e1ccbd0
Implement a resize image filter. This is needed for the "filterRes" feature in SVG filter effects, which specifies the required size for intermediate processing buffers. In order to make this work, we need to render the primitive at the given resolution (doable at the callsite in Blink), and then to resize the result to the actual on-screen size. The latter is where this filter comes in.
...
It simply applies a scaling factor (and the current CTM) to its input, and draws its input bitmap at that size.
R=reed@google.com
Review URL: https://codereview.chromium.org/136863006
git-svn-id: http://skia.googlecode.com/svn/trunk@13077 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 22:20:48 +00:00
djsollen@google.com
8844f99780
Revert "Make leak counters thread-safe and turn them on by default for Debug"
...
iThis CL is breaking the Android debug test bots by firing an assert.
BUG=skia:1219
Review URL: https://codereview.chromium.org/138683006
git-svn-id: http://skia.googlecode.com/svn/trunk@13076 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 21:54:44 +00:00
commit-bot@chromium.org
b5a827ab1c
Add BUG_PREFIX to codereview.settings
...
NOTRY=True
NOTREECHECKS=True
(SkipBuildbotRuns)
BUG=skia:1983
R=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/138863002
git-svn-id: http://skia.googlecode.com/svn/trunk@13075 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 21:19:21 +00:00
commit-bot@chromium.org
e2eac8b2fd
Move macros from TestClassDef.h to Test.h
...
Motivation: those macros don't make any sense without the definitions
in Test.h.
BUG=
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/138563004
git-svn-id: http://skia.googlecode.com/svn/trunk@13074 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 21:04:37 +00:00
commit-bot@chromium.org
19382421b9
Convert SkWriter32 to use an SkTDArray for its internal storage.
...
This reduces the allocation overhead of a null picture (create, beginRecording(), endRecording) from about 18K to about 1.9K. (There's still lots more to prune.)
SkPictureFlat can exploit the fact that Writer32 is contiguous simplify its memory management. The Writer32 itself becomes the scratch buffer.
Remove lots and lots of arbitrary magic numbers that were size guesses and minimum allocation sizes. Keep your eyes open for the big obvious DUH why we save 16K per picture! (Spoiler alert. It's because that first save we issue in beginRecording() forces the old SkWriter32 to allocate 16K.)
Tests passing, DM passing.
bench --match writer: ~20% faster
null bench_record: ~30% faster
bench_record on buildbot .skps: ~3-6% slower, ranging 25% faster to 20% slower
bench_pictures on buildbot .skps: ~1-2% faster, ranging 13% faster to 28% slower
BUG=skia:1850
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/137433003
git-svn-id: http://skia.googlecode.com/svn/trunk@13073 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 20:51:26 +00:00
commit-bot@chromium.org
b638a3a941
Default Mac to 64-bit.
...
DM keeps exhausting 4G address space when it's really rolling.
BUG=
R=reed@google.com , borenet@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/135733004
git-svn-id: http://skia.googlecode.com/svn/trunk@13072 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 20:49:26 +00:00
commit-bot@chromium.org
9f8e282901
submit_try: Obtain the list of trybots from the checked-in slaves.cfg
...
This should drastically speed up the script.
BUG=
R=epoger@google.com , rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/136683006
git-svn-id: http://skia.googlecode.com/svn/trunk@13071 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 19:18:45 +00:00
commit-bot@chromium.org
a6d46cb1bc
Add default_msaa16 and nvpr configs to bench_pictures.cfg
...
BUG=skia:2032
R=robertphillips@google.com , bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/137313005
git-svn-id: http://skia.googlecode.com/svn/trunk@13070 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:47:07 +00:00
commit-bot@chromium.org
f0c41e24d5
Initialize written paths and strokerecs lazily during GPU drawPath
...
Initialize SkPaths and SkStrokeRecs lazily during GPU drawPath calls.
The constructors seem to appear in some profiler results on ARM (~1%).
R=bsalomon@google.com , robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/118143002
git-svn-id: http://skia.googlecode.com/svn/trunk@13069 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:42:34 +00:00
commit-bot@chromium.org
46de153d4e
Make leak counters thread-safe and turn them on by default for Debug
...
Make leak counters implemented with SK_DECLARE_INST_COUNT thread-safe.
Enable the leak counting for Debug builds.
Protect the instance counter initialization step (initStep) by
using SkOnce.
Makes SkOnce.h part of the public API, since SkInstCnt is public.
Protect the per-class child list shared variable with a per-class mutex.
Changes the behavior in the way that if the child list has been
"cleaned up", it will still try to create subsequent child lists.
BUG=skia:1219
Committed: http://code.google.com/p/skia/source/detail?r=12635
R=robertphillips@google.com , mtklein@google.com , bsalomon@google.com , bungeman@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/99483003
git-svn-id: http://skia.googlecode.com/svn/trunk@13068 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:42:26 +00:00
bsalomon@google.com
d0c53f1d51
Rebaseline bleed and simpleblurroundrect due to GPU blur changes. Also, misc blur GMs on N4.
...
BUG=skia:199s8
Review URL: https://codereview.chromium.org/138593002
git-svn-id: http://skia.googlecode.com/svn/trunk@13067 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:20:49 +00:00
borenet@google.com
1a5e83a0ac
Use git_cl.Changelist.GetUpstreamBranch() for diff in submit_try
...
BUG=skia:1862
R=epoger@google.com
Review URL: https://codereview.chromium.org/136823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13066 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:03:10 +00:00
commit-bot@chromium.org
30d4f8372c
deprecate tools/test_rendering.py and tools/test_pictures.py
...
they will be removed entirely on/after Feb 1 unless there is objection
BUG=skia:1943
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/135783003
git-svn-id: http://skia.googlecode.com/svn/trunk@13065 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 17:01:28 +00:00
commit-bot@chromium.org
df79acdbab
Revert of Rebaselining bleed GMs due to recent GPU blur changes. ( https://codereview.chromium.org/138353002/ )
...
Reason for revert:
the bleed_gpu GM is failing on all the test builders.
Original issue's description:
> Rebaselining bleed GMs due to recent GPU blur changes.
>
> BUG=skia:1998
>
> Committed: https://code.google.com/p/skia/source/detail?r=13063
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1998
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/138133003
git-svn-id: http://skia.googlecode.com/svn/trunk@13064 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 16:21:31 +00:00
bsalomon@google.com
3f88f4d5ad
Rebaselining bleed GMs due to recent GPU blur changes.
...
BUG=skia:1998
Review URL: https://codereview.chromium.org/138353002
git-svn-id: http://skia.googlecode.com/svn/trunk@13063 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 15:28:24 +00:00
commit-bot@chromium.org
a4b054063f
remove file added accidentally
...
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/131053006
git-svn-id: http://skia.googlecode.com/svn/trunk@13062 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 13:51:14 +00:00
skia.committer@gmail.com
2e9a7157ee
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13061 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 07:01:42 +00:00
commit-bot@chromium.org
3e62ebf93b
make ignored-tests.txt specify full test name, not partial name
...
BUG=skia:2022
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/136883006
git-svn-id: http://skia.googlecode.com/svn/trunk@13060 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 02:54:11 +00:00
tfarina@chromium.org
5f43d21dd4
Remove drawPosTextOnPath() from SkDevice API.
...
All clients were updated including Chrome, so we can remove this now
from Skia.
This was committed on Chromium at
https://src.chromium.org/viewvc/chrome?view=rev&revision=244287
BUG=skia:1834
R=reed@google.com
Review URL: https://codereview.chromium.org/135583002
git-svn-id: http://skia.googlecode.com/svn/trunk@13059 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 21:42:25 +00:00
commit-bot@chromium.org
e13af711d4
Revert of https://codereview.chromium.org/132643007/
...
Reason for revert: broken tests
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=
Author: reed@google.com
Review URL: https://codereview.chromium.org/134843008
git-svn-id: http://skia.googlecode.com/svn/trunk@13058 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 20:39:14 +00:00
reed@google.com
f0b56e7448
Revert "Revert of https://codereview.chromium.org/129423002/ "
...
fixed new api references in unit tests
This reverts commit ffc0058e1fbcbd69617e1f41b2dce5b5765ff99e.
BUG=
Review URL: https://codereview.chromium.org/132643007
git-svn-id: http://skia.googlecode.com/svn/trunk@13057 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 20:28:50 +00:00
commit-bot@chromium.org
9b06ba4c91
Revert of https://codereview.chromium.org/129423002/
...
Reason for revert: broke tests (compile)
R=scroggo@google.com , halcanary@google.com
TBR=halcanary@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: reed@google.com
Review URL: https://codereview.chromium.org/137133003
git-svn-id: http://skia.googlecode.com/svn/trunk@13056 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 20:23:48 +00:00