Commit Graph

8668 Commits

Author SHA1 Message Date
senorblanco@chromium.org
fbaea53366 In image filters, apply the CTM and offset to the crop rect. This is necessary to compensate for both clipping applied by the compositor (communicated via the CTM) and for cropping applied in upstream image filters (communicated via the offset). This requires a few ugly conversions, since the crop rect is an SkIRect, and the ctm is an SkMatrix.
I also had to offset the matrix passed to filter evaluation by drawSprite() and internalDrawBitmap() by the primitive position. This is the same offset that is applied when drawing the primitive, to compensate for the internal saveLayer().

Also apply the total matrix to the filter params in asNewEffect(), so that (for example) lighting params are offset by both the compositor clipping and upstream crop rects.

R=reed@google.com

Review URL: https://codereview.chromium.org/23295017

git-svn-id: http://skia.googlecode.com/svn/trunk@10961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:37:01 +00:00
robertphillips@google.com
9d54db045b Image rebaselines for Ubuntu NoGPU x86_64
git-svn-id: http://skia.googlecode.com/svn/trunk@10960 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:34:37 +00:00
robertphillips@google.com
4d2af895db Image rebaselines for Nexus7 Release/Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@10959 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:31:22 +00:00
robertphillips@google.com
276e5d1871 Image baselines for Nexus 10 Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10958 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:18:50 +00:00
robertphillips@google.com
dbcc577079 Image rebaselines for Nexus S Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10957 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:13:15 +00:00
robertphillips@google.com
d1f437188d Image rebaselines for Mac 10.7 x86/x86_64 Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10956 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:03:01 +00:00
robertphillips@google.com
a1b44cdecf Image rebaselines for Mac10.6 x86/x86_64 Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10955 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:43:50 +00:00
scroggo@google.com
57a529877e Only destroy huffman if build succeeded.
The earlier code assumed that if jpeg_create_huffman_index
succeeded but jpeg_build_huffman_index failed that the
index would still need to be destroyed. This is not the
case. Only call jpeg_destroy_huffman_index if both
succeeded.

BUG=http://b.corp.google.com/issue?id=10263847

Review URL: https://codereview.chromium.org/22859042

git-svn-id: http://skia.googlecode.com/svn/trunk@10954 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:42:22 +00:00
robertphillips@google.com
319e01f1aa Image rebaselines for Ubuntu12 x86 Debug & Release & x86_64 Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@10952 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:29:57 +00:00
robertphillips@google.com
16c3ec99b7 Image rebaselines for Win7 x86 Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10951 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:06:15 +00:00
robertphillips@google.com
cb1908525a Image rebaselines for Win7 x86_64 Release & Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@10950 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:02:18 +00:00
robertphillips@google.com
b6c57d6693 Image baselines for Win7 x86 Release ANGLE & DirectWrite
git-svn-id: http://skia.googlecode.com/svn/trunk@10949 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:44:06 +00:00
robertphillips@google.com
b495688ada Win7 x86 Debug DirectWrite rebaselines for 10936
git-svn-id: http://skia.googlecode.com/svn/trunk@10948 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:39:03 +00:00
robertphillips@google.com
2e6a5911f9 Rebaselines for Win7 x86 Debug ANGLE
git-svn-id: http://skia.googlecode.com/svn/trunk@10946 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:31:04 +00:00
bungeman@google.com
33346487cb Fix _GDI::generateCharToGlyph to properly handle missing glyphs.
git-svn-id: http://skia.googlecode.com/svn/trunk@10945 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:05:32 +00:00
rmistry@google.com
e09d6f4819 Revert of r10943.
Review URL: https://codereview.chromium.org/23626002

git-svn-id: http://skia.googlecode.com/svn/trunk@10944 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 18:53:41 +00:00
reed@google.com
42cb6c0247 add SkDeviceLooper to handle larger-than-fixedpoint
BUG=

Review URL: https://codereview.chromium.org/23392006

git-svn-id: http://skia.googlecode.com/svn/trunk@10943 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 17:53:52 +00:00
djsollen@google.com
92e3f08c91 Fix issue when the family name is reused among multiple families.
BUG=chromium:274117
R=reed@google.com

Review URL: https://codereview.chromium.org/23592002

git-svn-id: http://skia.googlecode.com/svn/trunk@10942 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 17:40:03 +00:00
epoger@google.com
1c9518b09d Remove experimental/json-expectations , no longer needed.
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23498007

git-svn-id: http://skia.googlecode.com/svn/trunk@10941 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:48:04 +00:00
robertphillips@google.com
b75233b7fa Fix compiler warning/error in r10936
git-svn-id: http://skia.googlecode.com/svn/trunk@10938 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:31:31 +00:00
mtklein@google.com
9f842d3904 New warning -> new pattern for fingers to learn for asserting failure.
The Ubuntu Clang compile bot has a warning enabled now that yells about !"foo"
before it breaks Chrome's build where the same warning is -Werror.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23586002

git-svn-id: http://skia.googlecode.com/svn/trunk@10937 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:15:37 +00:00
robertphillips@google.com
7ce661d19c Blur refactoring
https://codereview.chromium.org/21835004/



git-svn-id: http://skia.googlecode.com/svn/trunk@10936 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:14:03 +00:00
mtklein@google.com
45891b8e37 factory can draw now too
BUG=skia:1564
R=epoger@google.com

Review URL: https://codereview.chromium.org/23607002

git-svn-id: http://skia.googlecode.com/svn/trunk@10935 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:07:48 +00:00
fmalita@google.com
d0f1a4fb28 Fix clip expansion in SkPictureRecord::recordRestoreOffsetPlaceholder()
For operations which can expand the region, zeroing previous clip ops' restore offsets is not enough: we need to also break the chain - otherwise the next restore() will simply traverse back and reset the skip offsets.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22987003

git-svn-id: http://skia.googlecode.com/svn/trunk@10934 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 15:50:19 +00:00
fmalita@google.com
b9168ed432 Adding SkLumaXfermode GM results.
Review URL: https://codereview.chromium.org/23596004

git-svn-id: http://skia.googlecode.com/svn/trunk@10933 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 13:54:36 +00:00
mtklein@google.com
6688e18f8d Four cmykjpeg GMs that weren't done yet yesterday.
This does not fix the other failures yet.

BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23591002

git-svn-id: http://skia.googlecode.com/svn/trunk@10932 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 13:03:03 +00:00
skia.committer@gmail.com
10adca5c4a Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10929 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 07:02:54 +00:00
vandebo@chromium.org
26e1449d85 [PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().
An apparently recently change started putting web fonts into SkStream objects that don't support getMemoryBase().  This change uses writeStream to avoid needing to call getMemoryBase().

BUG=chromium:274440
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23437004

git-svn-id: http://skia.googlecode.com/svn/trunk@10928 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 22:52:09 +00:00
fmalita@google.com
3b3ce3bff5 Update SkLumaMaskXfermode partial coverage handling.
Use lerp-to-dst instead of straight coverage scaling to align the behavior with
the other transfer modes.

R=reed@google.com

Review URL: https://codereview.chromium.org/23453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10927 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 21:46:34 +00:00
reed@google.com
f272e3554a test drawing large-coord aa rects
git-svn-id: http://skia.googlecode.com/svn/trunk@10926 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 21:27:03 +00:00
scroggo@google.com
b9050d73f9 Remove mismatched delete.
Use SkAutoTArray to create an array and delete it safely.

BUG=https://code.google.com/p/skia/issues/detail?id=1547
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23068033

git-svn-id: http://skia.googlecode.com/svn/trunk@10925 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 21:20:04 +00:00
mtklein@google.com
6e6dc653fc rebaseline most cmykjpeg from blank to an image
BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23447002

git-svn-id: http://skia.googlecode.com/svn/trunk@10924 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 20:40:35 +00:00
vandebo@chromium.org
ec415a8eac Revert "[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase()."
This reverts commit r10918

Review URL: https://codereview.chromium.org/23351007

git-svn-id: http://skia.googlecode.com/svn/trunk@10920 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 18:28:55 +00:00
vandebo@chromium.org
6bb656b008 [PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().
An apparently recently change started putting web fonts into SkStream objects that don't support getMemoryBase().  This change uses writeStream to avoid needing to call getMemoryBase().

BUG=chromium:274440
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23414007

git-svn-id: http://skia.googlecode.com/svn/trunk@10918 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 18:02:00 +00:00
mtklein@google.com
0dc546c37c Implement highQualityFilter16 so GM doesn't crash when you give it resources.
Testing consisted of:
 1) ninja -C out/Debug gm && gm -i resources --match mandrill_512 -w /tmp/gm
 2) notice that gm didn't segfault
 3) look in /tmp/gm and see a bunch of handsome monkeys

BUG=skia:1517
R=humper@google.com

Review URL: https://codereview.chromium.org/22801016

git-svn-id: http://skia.googlecode.com/svn/trunk@10917 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 16:21:35 +00:00
robertphillips@google.com
62aa8d6148 Update pdf.gypi to actually work with Chromium
https://chromiumcodereview.appspot.com/23112031/



git-svn-id: http://skia.googlecode.com/svn/trunk@10916 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 13:47:20 +00:00
robertphillips@google.com
57c5672901 Fix leaked SkPDFDevice in PDFPrimitivesTest.cpp
https://chromiumcodereview.appspot.com/23003035/



git-svn-id: http://skia.googlecode.com/svn/trunk@10910 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 11:10:13 +00:00
robertphillips@google.com
69b1302689 Reverting r10901 (Add unpremultiply support and GM)
git-svn-id: http://skia.googlecode.com/svn/trunk@10909 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-25 11:20:54 +00:00
epoger@google.com
44f165f6ce temporarily hard-code builder list in rebaseline.py, for quick startup
BUG=skia:1544
R=borenet@google.com

Review URL: https://codereview.chromium.org/22866023

git-svn-id: http://skia.googlecode.com/svn/trunk@10908 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-24 20:45:31 +00:00
borenet@google.com
d30cb83fd3 Don't compile the debugger on ChromeOS
TBR=epoger

Review URL: https://codereview.chromium.org/22831048

git-svn-id: http://skia.googlecode.com/svn/trunk@10904 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-24 15:50:43 +00:00
commit-bot@chromium.org
52130e8a5e Add unpremultiply support and GM
R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22831039

git-svn-id: http://skia.googlecode.com/svn/trunk@10901 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 21:43:03 +00:00
commit-bot@chromium.org
884624764c Only assert that conic/quad effects get created if they are to be used.
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22891023

git-svn-id: http://skia.googlecode.com/svn/trunk@10900 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 21:01:52 +00:00
commit-bot@chromium.org
726e621000 Use indexed extensions on ES3.
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23359002

git-svn-id: http://skia.googlecode.com/svn/trunk@10899 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 20:55:46 +00:00
bsalomon@google.com
cbe63fe1a8 add bezier effect baselines
git-svn-id: http://skia.googlecode.com/svn/trunk@10898 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 20:20:15 +00:00
fmalita@google.com
a17093f992 Updated SkLumaXfermode GM (take two).
Added AA & gradient combinations.

Review URL: https://codereview.chromium.org/23190041

git-svn-id: http://skia.googlecode.com/svn/trunk@10897 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 19:55:15 +00:00
commit-bot@chromium.org
181fcb4a21 Refactor SkPDFImage
R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22889020

git-svn-id: http://skia.googlecode.com/svn/trunk@10896 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 19:06:53 +00:00
fmalita@google.com
cbddc11419 Revert "Updated SkLumaXfermode GM."
Win compile warnings.

Review URL: https://codereview.chromium.org/22831042

git-svn-id: http://skia.googlecode.com/svn/trunk@10894 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 18:13:00 +00:00
fmalita@google.com
f9a0a660ec Updated SkLumaXfermode GM.
Added AA & gradient combinations.

Review URL: https://codereview.chromium.org/23382012

git-svn-id: http://skia.googlecode.com/svn/trunk@10893 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 18:08:53 +00:00
commit-bot@chromium.org
53a0b6cc19 Add GMs for gpu Bezier shaders
BUG=
R=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://chromiumcodereview.appspot.com/23361024

git-svn-id: http://skia.googlecode.com/svn/trunk@10892 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 18:05:01 +00:00
robertphillips@google.com
d3707a7559 Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@10890 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-23 14:17:16 +00:00