yujieqin
fda27a977d
Fix Windows build
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633413003
Review URL: https://codereview.chromium.org/1633413003
2016-01-27 09:03:20 -08:00
scroggo
0edf1693df
Stop testing SkImageDecoder in DM/nanobench
...
We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641663002
Review URL: https://codereview.chromium.org/1641663002
2016-01-27 08:26:44 -08:00
yujieqin
076d83d09a
Enable RAW codec for Windows
...
* Use new DNG SDK version from ASOP, which fixed some build issues.
* Fix SkRawCodec.
* Fix gyp files.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641533004
Review URL: https://codereview.chromium.org/1641533004
2016-01-27 08:25:53 -08:00
ebrauer
b84b5b42c1
It derives the dng_host and overrides PerformAreaTask() to split the task into several sub-tasks which get added to SkTaskGroup.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1634763002
Review URL: https://codereview.chromium.org/1634763002
2016-01-27 08:21:03 -08:00
yujieqin
24716be1d1
Fix complier issue [-Werror, -Wvla]
...
BUG=skia:4861
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1638323002
Review URL: https://codereview.chromium.org/1638323002
2016-01-27 07:59:00 -08:00
joshualitt
ccfdaa5f2a
Add primitive url handling system to skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644633002
Review URL: https://codereview.chromium.org/1644633002
2016-01-27 07:40:29 -08:00
yujieqin
8f5175842d
Update DEPS to use new PIEX version from AOSP.
...
Highlight:
* Better support for reading GPS tags
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1646433003
Review URL: https://codereview.chromium.org/1646433003
2016-01-27 07:32:43 -08:00
joshualitt
9a4e1883b0
Allow clients to upload skps to skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1638883002
Review URL: https://codereview.chromium.org/1638883002
2016-01-27 07:03:29 -08:00
robertphillips
f42fca4027
Add gpu implementation of OverdrawXfermode
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
Review URL: https://codereview.chromium.org/1607253002
2016-01-27 05:00:04 -08:00
caryclark
5ba2b9612a
move more geometry to simd
...
Remove duplicate quad and cubic code around
computing the polynomial coefficients, and
use common SIMD-based code instead.
R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633143002
Review URL: https://codereview.chromium.org/1633143002
2016-01-26 17:02:30 -08:00
robertphillips
727b7d27af
Add gpu backend for SkPixelXorXfermode
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1631873002
Review URL: https://codereview.chromium.org/1631873002
2016-01-26 12:07:13 -08:00
reed
ed0bf1b43e
remove unused sample
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1634683006
TBR=
Review URL: https://codereview.chromium.org/1634683006
2016-01-26 10:37:21 -08:00
cblume
6121405df5
Cleaning up trailing spaces and typos.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1631993002
Review URL: https://codereview.chromium.org/1631993002
2016-01-26 09:10:48 -08:00
senorblanco
eae84c2e0e
Image filters: fix srcOffset handling in asFragmentProcessor() path.
...
Filters such as SkMatrixConvolutionImageFilter which use the
asFragmentProcessor() path were not correctly handling srcOffset.
It is correctly applied to the bounds, but the srcRect and dstRect
were computed from the pre-offset bounds.
The fix is to move them to just above where they're used in drawing.
Note: this change adds a new test case to the imagefiltersgraph GM,
so it will have to be rebaselined post-landing.
BUG=skia:4855
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1637443003
Review URL: https://codereview.chromium.org/1637443003
2016-01-26 08:41:03 -08:00
ethannicholas
978d08a4a9
Initial support for turning Skia draws into a JSON document and vice versa.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636563002
Committed: https://skia.googlesource.com/skia/+/3cb582f688822461efa5a034e18008bf2f11e4f8
Review URL: https://codereview.chromium.org/1636563002
2016-01-26 07:47:58 -08:00
mtklein
a766ca87bf
de-proc sk_float_rsqrt
...
This is the first of many little baby steps to have us stop runtime-detecting NEON.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
Review URL: https://codereview.chromium.org/1616013003
2016-01-26 07:40:30 -08:00
lsalzman
05332d9c8a
check for both __ARM_NEON__ and __ARM_NEON
...
No public API changes.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1630903004
Review URL: https://codereview.chromium.org/1630903004
2016-01-26 07:34:51 -08:00
bsalomon
e9573317d3
Make A8 readbacks work from non-A8 surfaces
...
Expand testing of A8 readbacks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1613903005
Review URL: https://codereview.chromium.org/1613903005
2016-01-25 14:33:25 -08:00
robertphillips
64b0f5f957
Remove SkLerpXfermode
...
This relies on the Chromium CL https://codereview.chromium.org/1610573004/ (Replace use of SkLerpXfermode with SkArithmeticMode)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611633002
Review URL: https://codereview.chromium.org/1611633002
2016-01-25 14:19:56 -08:00
msarett
7a561230a2
Revert of Initial support for turning Skia draws into a JSON document and vice versa. (patchset #3 id:80001 of https://codereview.chromium.org/1636563002/ )
...
Reason for revert:
Breaking the CMake build.
Original issue's description:
> Initial support for turning Skia draws into a JSON document and vice versa.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636563002
>
> Committed: https://skia.googlesource.com/skia/+/3cb582f688822461efa5a034e18008bf2f11e4f8
TBR=jcgregorio@google.com ,joshualitt@google.com,mtklein@google.com,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1637643002
2016-01-25 13:57:25 -08:00
ethannicholas
3cb582f688
Initial support for turning Skia draws into a JSON document and vice versa.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636563002
Review URL: https://codereview.chromium.org/1636563002
2016-01-25 13:28:28 -08:00
msarett
8e49ca33b0
Disable RAW test when SkRawCodec is not compiled
...
TBR=scroggo@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639533002
Review URL: https://codereview.chromium.org/1639533002
2016-01-25 13:10:58 -08:00
benjaminwagner
8d61f0dd1b
Add pre_log option to nanobench; make this option default true in nanobench_flags.py and dm_flags.py.
...
BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612483002
Review URL: https://codereview.chromium.org/1612483002
2016-01-25 13:02:40 -08:00
bungeman
1fce5584cf
Work around vs2013sp2-3 bug in skstd::unique_ptr.
...
When compiling skstd::unique_ptr::compressed_base with the vc++ in
some intermediate service pack versions of Visual Studio 2013 the
compiler will crash with an internal compiler error. In the interest of
reducing headaches, work around this issue in skstd::unique_ptr until
std::unique_ptr can be used.
BUG=skia:4564
Review URL: https://codereview.chromium.org/1636503002
2016-01-25 13:00:34 -08:00
msarett
7869bbff26
Fix gyp files so that gyp_to_Android.mk succeeds
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1630723003
Review URL: https://codereview.chromium.org/1630723003
2016-01-25 11:40:02 -08:00
robertphillips
914bd435a8
Fix memory leak in pixelxorxfermode GM
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633773002
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/1633773002
2016-01-25 11:34:16 -08:00
iroth
d2ccc772d4
Changes to public.bzl to support building on iOS with objc_library bazel target.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639443002
Review URL: https://codereview.chromium.org/1639443002
2016-01-25 11:24:57 -08:00
msarett
02cb4d469a
Disable RAW test on Chrome OS, Windows
...
TBR=scroggo@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633763002
Review URL: https://codereview.chromium.org/1633763002
2016-01-25 11:01:34 -08:00
msarett
01813e880a
Fix leak of SkImageGenerator
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1638463002
Review URL: https://codereview.chromium.org/1638463002
2016-01-25 10:51:29 -08:00
joshualitt
8cc3f4e38f
Build and link microhttpd from gyp
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1628363002
Review URL: https://codereview.chromium.org/1628363002
2016-01-25 10:50:04 -08:00
benjaminwagner
89061ed2e7
Remove RAW Codec from Google3 build.
...
This should fix the build after https://codereview.chromium.org/1520403003 and allow the autoroller to complete. I will follow up to see if it will be simple to re-enable this codec.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1628393002
Review URL: https://codereview.chromium.org/1628393002
2016-01-25 09:29:09 -08:00
mtklein
20473344b2
spin off some safe parts from AVX2 CL
...
(reviewed here https://codereview.chromium.org/1532613002/ )
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1628333003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1628333003
2016-01-25 09:26:54 -08:00
msarett
0dfffbeeec
Revert of AVX 2 SrcOver blits: color32, blitmask. (patchset #24 id:450001 of https://codereview.chromium.org/1532613002/ )
...
Reason for revert:
Bot failures
Original issue's description:
> AVX 2 SrcOver blits: color32, blitmask.
>
> As a follow up to the SSE 4.1 CL, this should look pretty familiar.
>
> I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later.
>
> Perf changes (relative to SSE 4.1):
> Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit
> Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent
> text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit
> text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit
>
> This should be a big throughout win, and a small latency win.
> This should all be pixel-exact to the previous SSE 4.1 code.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1532613002
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/5d2117015eb271e09faf4a7ddd89093c9d618a36
TBR=herb@google.com ,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1632713002
2016-01-25 08:54:50 -08:00
robertphillips
37771c349e
Add GM for SkPixelXorXfermode
...
This is in preparation for adding a gpu implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1601743009
Review URL: https://codereview.chromium.org/1601743009
2016-01-25 08:39:08 -08:00
mtklein
5d2117015e
AVX 2 SrcOver blits: color32, blitmask.
...
As a follow up to the SSE 4.1 CL, this should look pretty familiar.
I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later.
Perf changes (relative to SSE 4.1):
Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit
Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent
text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit
text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit
This should be a big throughout win, and a small latency win.
This should all be pixel-exact to the previous SSE 4.1 code.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1532613002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1532613002
2016-01-25 08:37:30 -08:00
yujieqin
916de9ff18
Add RAW decoding into Skia.
...
TBR=reed@google.com
BUG=skia:
(Based on the work from ebrauer in https://codereview.chromium.org/1459473007 )
(Based on the work from adaubert in https://codereview.chromium.org/1494003003 )
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1520403003
Committed: https://skia.googlesource.com/skia/+/6bd8639f8c142eedf543f4e5f3b02d2bf11df308
Review URL: https://codereview.chromium.org/1520403003
2016-01-25 08:26:16 -08:00
msarett
d03b7ae1e2
Do not test images with alpha to 565
...
This should handle the untriaged images in Gold.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1635453002
Review URL: https://codereview.chromium.org/1635453002
2016-01-25 08:20:55 -08:00
cjacek
c721196067
Fixed compilation on mingw.
...
Found and tested in mingw Firefox build. There are two problems:
- GCC doesn't support __vectorcall calling convention, so its usage needs to be #ifdefed
- GetProcAddress returns FARPROC type (a function pointer) and GCC requires an explicit cast to void*
Review URL: https://codereview.chromium.org/1589933002
2016-01-25 07:27:36 -08:00
caryclark
a273c0f667
remove legacy defines
...
The defines
SK_SUPPORT_LEGACY_ARCTO
SK_SUPPORT_LEGACY_CONIC_MEASURE
SK_SUPPORT_LEGACY_DASH_MEASURE
SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS
SK_SUPPORT_LEGACY_PATH_MEASURE_TVALUE
have been removed from Chrome. This removes the obsolete code
from Skia as well.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1627703002
Review URL: https://codereview.chromium.org/1627703002
2016-01-25 06:33:02 -08:00
fmalita
8f66a8862f
Delete 2 legacy flags
...
No longer used in Chrome/Android:
SK_SUPPORT_LEGACY_ANISOTROPIC_MIPMAPS
SK_SUPPORT_LEGACY_PRESCALE_SEMANTICS
R=caryclark@google.com ,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1632633002
Review URL: https://codereview.chromium.org/1632633002
2016-01-25 06:29:44 -08:00
fmalita
53d9f1cfbd
SK_SUPPORT_LEGACY_DRAWFLTER typo
...
s/FLTER/FILTER/
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1634573002
Review URL: https://codereview.chromium.org/1634573002
2016-01-25 06:23:54 -08:00
kkinnunen
1517f93439
Avoid updating glPathStencilFunc unless it changes
...
Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619623005
Review URL: https://codereview.chromium.org/1619623005
2016-01-25 06:07:26 -08:00
msarett
c85a9fde77
Revert of Prototype of RAW decoding in Skia. (patchset #32 id:610001 of https://codereview.chromium.org/1520403003/ )
...
Reason for revert:
A few build failures on Chrome OS/Android.
Original issue's description:
> Add RAW decoding into Skia.
>
> TBR=reed@google.com
>
> BUG=skia:
>
> (Based on the work from ebrauer in https://codereview.chromium.org/1459473007 )
> (Based on the work from adaubert in https://codereview.chromium.org/1494003003 )
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1520403003
>
> Committed: https://skia.googlesource.com/skia/+/6bd8639f8c142eedf543f4e5f3b02d2bf11df308
TBR=scroggo@google.com ,adaubert@google.com,yujieqin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1635443002
2016-01-25 06:05:19 -08:00
caryclark
fc75253c82
fix arcto exception handling
...
To match SVG behavior,
draw a line when either radius is zero,
or when the end point equals the start point.
Update the GM to include these tests, and
take the scale used to test it on a highres display.
R=fmalita@chromium.org
BUG=skia:4849
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1627423002
Review URL: https://codereview.chromium.org/1627423002
2016-01-25 05:39:04 -08:00
yujieqin
6bd8639f8c
Add RAW decoding into Skia.
...
TBR=reed@google.com
BUG=skia:
(Based on the work from ebrauer in https://codereview.chromium.org/1459473007 )
(Based on the work from adaubert in https://codereview.chromium.org/1494003003 )
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1520403003
Review URL: https://codereview.chromium.org/1520403003
2016-01-25 05:29:03 -08:00
borenet
4d8b7bafb2
Whitespace change to test SK_IMAGE_VERSION download
...
TBR=scroggo
BUG=skia:4558
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633453003
Review URL: https://codereview.chromium.org/1633453003
2016-01-25 05:00:13 -08:00
kkinnunen
1dc85cda5e
Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed
...
Enable GL_CHROMIUM_bind_uniform_location, command buffer implementation
is fixed now.
BUG=skia:4454
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1613763003
Review URL: https://codereview.chromium.org/1613763003
2016-01-25 01:44:03 -08:00
kkinnunen
7bdb05d5c2
Do not try to get fragment input locations with CHROMIUM_path_rendering
...
Do not try to get fragment input locations with CHROMIUM_path_rendering,
it uses the binding mechanism in CHROMIUM_path_rendering
BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618773002
Review URL: https://codereview.chromium.org/1618773002
2016-01-25 00:47:23 -08:00
kkinnunen
9f63b44234
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples
...
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples.
BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1615833002
Review URL: https://codereview.chromium.org/1615833002
2016-01-25 00:31:49 -08:00
mtklein
1138be45ea
Revert of skstd -> std for unique_ptr (patchset #24 id:460001 of https://codereview.chromium.org/1436033003/ )
...
Reason for revert:
Still need an answer for SkAdvancedTypefaceMetrics (at least for Google3 iOS build).
Original issue's description:
> skstd -> std for unique_ptr
>
> TBR=reed@google.com
> No public API changes.
>
> BUG=skia:4564
>
> Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065
>
> Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
>
> Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1436033003
>
> Committed: https://skia.googlesource.com/skia/+/ccf1de0d9aa75f29829f1c4c462214b991fd8c9e
TBR=bungeman@google.com ,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4564
Review URL: https://codereview.chromium.org/1626873004
2016-01-24 19:49:24 -08:00