Commit Graph

14742 Commits

Author SHA1 Message Date
joshualitt
95f5194abc Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2

Review URL: https://codereview.chromium.org/678073005
2014-10-28 07:54:54 -07:00
robertphillips
fd61ed0d79 Alter layer hoisting to only hoist layers for one canvas at a time
This CL alters layer hoisting to defer creation of the free floating layers until they are actually needed (rather than creating _all_ the hoisted layers at the start).

It also fixes a pre vs. post Concat bug with how matrices were being accumulated.

BUG=skia:2315

Review URL: https://codereview.chromium.org/657383004
2014-10-28 07:21:44 -07:00
junov
ed53742e92 Add SK_API to global scope operators of SkMatrix
Review URL: https://codereview.chromium.org/678153002
2014-10-28 07:14:58 -07:00
reed
15c746062e not a failure if we didn't load the test file
BUG=skia:

Review URL: https://codereview.chromium.org/687453005
2014-10-28 07:12:37 -07:00
egdaniel
a703b841e3 Add Geometry processor to srcAlphaWillBeOne check.
BUG=skia:

Review URL: https://codereview.chromium.org/681333002
2014-10-28 07:06:36 -07:00
djsollen
a01a17b3f2 Update the Android NDK to r10c
Review URL: https://codereview.chromium.org/687603002
2014-10-28 06:53:09 -07:00
halcanary
eb06588dfc Replace color_wheel.* with beautiful versions I made with Skia.
NOTRY=true

Review URL: https://codereview.chromium.org/683113002
2014-10-28 06:33:07 -07:00
hcm
4396fa594e Revert of Use approximate scratch textures for image filters. (patchset #2 id:20001 of https://codereview.chromium.org/679113004/)
Reason for revert:
Continued GM failures

Original issue's description:
> Use approximate scratch textures for image filters.
>
> Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec
>
> Committed: https://skia.googlesource.com/skia/+/50a140563c5960acb2479d2be7c437d146963b3f

TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/681183002
2014-10-27 21:43:30 -07:00
hcm
d0f1969100 Revert of Fix bounds computation of all 0-input filters. (patchset #2 id:20001 of https://codereview.chromium.org/681643003/)
Reason for revert:
try again

Original issue's description:
> Fix bounds computation of all 0-input filters.
>
> The SkRectShaderImageFilter had the same bug as previously fixed for
> SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
> the implementation, this change makes all filters with 0 inputs return
> their source bounds, instead of returning false.
>
> BUG=427251
>
> Committed: https://skia.googlesource.com/skia/+/ba036cc82b5a543a13cafd11a19ba0e3087fca38

TBR=bsalomon@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=427251

Review URL: https://codereview.chromium.org/678273002
2014-10-27 20:55:01 -07:00
hcm
4984d473ab Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests. (patchset #3 id:40001 of https://codereview.chromium.org/685523002/)
Reason for revert:
Getting to revert for failures on image filter tests in Skia and Blink

Original issue's description:
> Rebaseline imagemagnifier and dropshadowimagefilter tests.
>
> BUG=skia:
> TBR=hcm@google.com
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/0fc71ea432d3895ede198a24080f877e607cd264

TBR=senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/678043003
2014-10-27 20:53:25 -07:00
hcm
ac011a5f90 Revert of Re-add suppressions for magnifier and dropshadow GMs. (patchset #1 id:1 of https://codereview.chromium.org/686573002/)
Reason for revert:
Trying to get revert of patchset potentially causing failures on image filter tests

Original issue's description:
> Re-add suppressions for magnifier and dropshadow GMs.
>
> Brian's change has invalidated the new baselines, so they'll need
> to be rebaselined again once his changed has worked its way through.
>
> TBR=bsalomon
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/fa4689d56384da5bb264a480e636fac126fb93ca

TBR=bsalomon@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/679413002
2014-10-27 20:48:57 -07:00
Ravi Mistry
2e2984f2c7 Whitespace change to trigger builds 2014-10-27 21:21:16 -04:00
joshualitt
9f2825f249 Revert of Patch to remove constant attributes (patchset #6 id:100001 of https://codereview.chromium.org/678073005/)
Reason for revert:
Breaks the K1

Original issue's description:
> Working patch to remove constant attributes.  This may cause some gm mismatches, I will rebaseline tonight.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2

TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/679363002
2014-10-27 17:56:18 -07:00
joshualitt
84c94c0dfd Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:

Review URL: https://codereview.chromium.org/678073005
2014-10-27 15:33:33 -07:00
piotaixr
76993edbe5 Reenable assertions that were reported failing in tests/CanvasTest.cpp
BUG=skia:498,skia:499

Review URL: https://codereview.chromium.org/670403002
2014-10-27 15:31:34 -07:00
joshualitt
77b1307c1f Scissor rect on drawinfo
BUG=skia:

Review URL: https://codereview.chromium.org/678683005
2014-10-27 14:51:01 -07:00
senorblanco
fa4689d563 Re-add suppressions for magnifier and dropshadow GMs.
Brian's change has invalidated the new baselines, so they'll need
to be rebaselined again once his changed has worked its way through.

TBR=bsalomon
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/686573002
2014-10-27 14:26:26 -07:00
senorblanco
0fc71ea432 Rebaseline imagemagnifier and dropshadowimagefilter tests.
BUG=skia:
TBR=hcm@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/685523002
2014-10-27 14:12:58 -07:00
bsalomon
50a140563c Use approximate scratch textures for image filters.
Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec

Review URL: https://codereview.chromium.org/679113004
2014-10-27 13:56:20 -07:00
senorblanco
ba036cc82b Fix bounds computation of all 0-input filters.
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.

BUG=427251

Review URL: https://codereview.chromium.org/681643003
2014-10-27 13:38:13 -07:00
bsalomon
a9a80e5f42 Revert of Use approximate scratch textures for image filters. (patchset #1 id:1 of https://codereview.chromium.org/679113004/)
Reason for revert:
Images change on some machines. Mostly look OK but not sure about imagefiltersbase on N5.

Old"
http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/imagefiltersbase/11449357083048653160.png

New:
http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/imagefiltersbase/14279906119350384263.png

Original issue's description:
> Use approximate scratch textures for image filters.
>
> Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec

TBR=senorblanco@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/664823003
2014-10-27 12:59:03 -07:00
bsalomon
c6327a8f7e stuff
BUG=skia:

Review URL: https://codereview.chromium.org/655913003
2014-10-27 12:53:08 -07:00
bsalomon
96c60686ee Use approximate scratch textures for image filters.
Review URL: https://codereview.chromium.org/679113004
2014-10-27 12:41:45 -07:00
bungeman
5f6094a1eb Match language tags by prefix on Android.
A request for 'zh' should match 'zh-Hans' and 'zh-Hant'.

Review URL: https://codereview.chromium.org/681823003
2014-10-27 11:51:58 -07:00
halcanary
dffa397f83 add gm: filterbitmap_image_color_wheel
BUG=skia:3061

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/633333004
2014-10-27 10:32:18 -07:00
humper
535e3b2025 Fix the way we patch up the matrix for scaled images that aren't
clamp/clamp

BUG=skia:2904
TBR=reed

Review URL: https://codereview.chromium.org/675823002
2014-10-27 10:32:07 -07:00
mtklein
4477c3c0e6 Cut down SkBBH API more.
- The expected case is now a single bulk-load insert() call instead of N;
  - reserve() and flushDeferredInserts() can fold into insert() now;
  - SkBBH subclasses may take ownership of the bounds

This appears to be a performance no-op on both my Mac and N5.  I guess
even the simplest indirect branch predictor ("same as last time") can predict
the repeated virtual calls to SkBBH::insert() perfectly.

BUG=skia:

Review URL: https://codereview.chromium.org/670213002
2014-10-27 10:27:10 -07:00
jcgregorio
5e44b00392 Start moving to the new canvas structure.
Adds DrawingMethods with some of the methods it defines. Context is now
an implementation of DrawingMethods.

The sample.js file now shows how the context is used.

Not much new code here, that's mostly in DrawingMethods::DrawPath, most everything else is a code move.

BUG=skia:

Review URL: https://codereview.chromium.org/676423002
2014-10-27 10:27:01 -07:00
scroggo
13f701a14d Allow index sources to be unpremul.
This only affects the PNG image decoder, where we have already created
the color table without premultiplication. Since the RowProcChooser is
just providing a proc that chooses indices into the color table, it can
just return the same RowProc.

Update test_row_proc_choice. It was testing to ensure that we hadn't
changed the behavior from the original version of setPrefConfigTable.
In this case, we deliberately changed the behavior, so we need to
change the test.

BUG=b/12024301

Review URL: https://codereview.chromium.org/657863005
2014-10-27 08:43:12 -07:00
joshualitt
a58fe35fda Clip mask manager sets stencil on draw type
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7afb5aa201e4b59397cbd8480e121d7501a227e7

Review URL: https://codereview.chromium.org/676983003
2014-10-27 08:39:00 -07:00
sugoi
f11c574882 Adding color cube to fuzzer
BUG=skia:

Review URL: https://codereview.chromium.org/677713003
2014-10-27 08:03:57 -07:00
jvanverth
d482d297c5 Update perspective GM expectations after disabling some DF paths
BUG=skia:3066
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/680913003
2014-10-27 07:58:30 -07:00
joshualitt
3a0cfeb961 Revert of Clip mask manager sets stencil on draw type (patchset #3 id:40001 of https://codereview.chromium.org/676983003/)
Reason for revert:
seems to cause a gm issue on windows.

Original issue's description:
> Clip mask manager sets stencil on draw type
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7afb5aa201e4b59397cbd8480e121d7501a227e7

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/678843003
2014-10-27 07:38:01 -07:00
jcgregorio
1c9acd980b Fixup references to the js files from the HTML files in SkV8Example.
BUG=skia:

Review URL: https://codereview.chromium.org/680053002
2014-10-27 07:19:44 -07:00
joshualitt
7afb5aa201 Clip mask manager sets stencil on draw type
BUG=skia:

Review URL: https://codereview.chromium.org/676983003
2014-10-27 07:17:17 -07:00
halcanary
c8306779b8 In SkPDFDocumentToBitmap, use SkCreateDataProviderFromStream
CGDataProviderCreateWithData to SkCreateDataProviderFromStream in
SkPDFDocumentToBitmap

Review URL: https://codereview.chromium.org/678763003
2014-10-27 07:06:47 -07:00
rmistry
7620bf0658 Fix ability to capture archives in webpages_playback.py
Updated all page sets to match the file name. This is to make it easier to call record_wpr with the page set class name.
Also updated the wait time for baidu to 60 seconds.

BUG=skia:3049

Review URL: https://codereview.chromium.org/683473002
2014-10-27 06:42:11 -07:00
halcanary
3dc5d70459 Use MacOS's CoreGraphics PDF Rasterizer in DM
BUG=3061

Review URL: https://codereview.chromium.org/650323004
2014-10-27 06:24:11 -07:00
skia-deps-roller
3a9c903cde Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/682573002
2014-10-27 04:26:56 -07:00
halcanary
30b83d45a3 add gm: colorwheel
BUG=skia:3061

Review URL: https://codereview.chromium.org/680533002
2014-10-26 05:23:53 -07:00
reed
86217d831d add saveLayer to lua
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/679903002
2014-10-25 20:44:40 -07:00
robertphillips
59b3815eaa Move .js files to their own directory
Review URL: https://codereview.chromium.org/677133002
2014-10-24 20:02:31 -07:00
joshualitt
d3de40dfdf bug fix for k1
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/675213003
2014-10-24 15:02:11 -07:00
egdaniel
27c1521ccf Add gpu support for glVertexAttrb1f, 2fv, and 3fv
BUG=skia:

Review URL: https://codereview.chromium.org/662583003
2014-10-24 15:00:50 -07:00
halcanary
f622a6c8fd Add SkIRect bounds() convenience method to SkImageInfo and SkBitmap.
Review URL: https://codereview.chromium.org/646213003
2014-10-24 12:54:53 -07:00
jvanverth
87ab518627 Update GM expectations for https://codereview.chromium.org/677463002/
BUG=skia:2935
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/677123002
2014-10-24 12:53:01 -07:00
jcgregorio
e22f45fd89 Doing the "using namespace" penance by adding in v8:: everywhere, like I should have to begin with.
Also:
  - SkWindow now has createSurface, not createCanvas.
  - Add the platform init code v8 now seems to require.
  - Fix library linkage.
  - Call isolate->Enter(); because it doesn't look
    like v8 starts with a default isolate to begin with.

BUG=skia:

Review URL: https://codereview.chromium.org/673223002
2014-10-24 12:49:17 -07:00
bsalomon
a0036c6e33 Delete unused method aliases and texture flag.
Committed: https://skia.googlesource.com/skia/+/7fdffe41494cbd78a8ee2a6ef0509e46ec77039f

Review URL: https://codereview.chromium.org/672753002
2014-10-24 12:46:57 -07:00
bsalomon
e79a2dab91 When bmp is not cached don't upload as index8 format.
Review URL: https://codereview.chromium.org/673883002
2014-10-24 12:42:51 -07:00
jvanverth
0deb2d9c5d Add some more volatile paths.
Some clip paths were not marked as volatile, and ending up in the
distance field path renderer when they shouldn't.

BUG=skia:3066

Review URL: https://codereview.chromium.org/680543002
2014-10-24 12:41:32 -07:00