AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
12d62a7d51
skia2/samplecode
History
fmalita a1f4fa7230 Revert of Hide SkCanvas::LayerIter (patchset #2 id:20001 of https://codereview.chromium.org/1897863008/ ) 
Reason for revert:
Das roll ist gebusted: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/214775/steps/compile%20%28with%20patch%29/logs/stdio

FAILED: /b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/platform/graphics/paint/blink_platform_unittests.PaintArtifactToSkCanvasTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=266460-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -Igen/blink -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -Igen/third_party/WebKit -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/harfbuzz-ng/src -I../../third_party/qcms/src -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../v8/include -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr  -c ../../third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp -o obj/third_party/WebKit/Source/platform/graphics/paint/blink_platform_unittests.PaintArtifactToSkCanvasTest.o
../../third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp:201:22: error: 'LayerIter' is a protected member of 'SkCanvas'
    return SkCanvas::LayerIter(canvas, false).clip();
                     ^
../../third_party/skia/include/core/SkCanvas.h:1230:18: note: declared protected here
    class SK_API LayerIter /*: SkNoncopyable*/ {
                 ^
1 error generated.
ninja: build stopped: subcommand failed.

Original issue's description:
> Hide SkCanvas::LayerIter
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897863008
>
> Committed: https://skia.googlesource.com/skia/+/a814000cbb0e90624a410b4359fff7f3ec66f0e0

TBR=reed@google.com,robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1906573003
2016-04-20 17:03:38 -07:00
..
ClockFaceView.cpp change flattenable factory to return sk_sp 2016-04-03 09:11:13 -07:00
DecodeFile.h Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
GMSampleView.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
GMSampleView.h C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
OverView.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
OverView.h Add a header for OverView.cpp as well. 2012-09-18 01:52:20 +00:00
PerlinPatch.cpp switch xfermodes over to sk_sp 2016-03-29 11:32:50 -07:00
Sample2PtRadial.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleAAClip.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleAARectModes.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleAARects.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleAll.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleAnimatedText.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleAnimator.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleAnimBlur.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleApp.cpp Add control of the sRGB global hack flag in SampleApp 2016-04-20 09:20:46 -07:00
SampleApp.h Add 'P' to SampleApp to cycle through pixel geometries. 2016-03-31 08:30:38 -07:00
SampleArc.cpp return pictures as sk_sp 2016-03-18 07:25:55 -07:00
SampleAtlas.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleBigBlur.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleBigGradient.cpp use Make instead of Create to return a shared shader 2016-03-08 18:50:00 -08:00
SampleBitmapRect.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleBlur.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleCamera.cpp move setshader to sk_sp, re-using SK_SUPPORT_LEGACY_CREATESHADER_PTR 2016-03-25 09:08:00 -07:00
SampleChart.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleCircle.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleClamp.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleClip.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleClipDrawMatch.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleClock.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleCode.h remove SkGPipe 2016-01-08 06:30:14 -08:00
SampleColorFilter.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleComplexClip.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleConcavePaths.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleDash.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleDegenerateTwoPtRadials.cpp use Make instead of Create to return a shared shader 2016-03-08 18:50:00 -08:00
SampleDither.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleDitherBitmap.cpp use Make instead of Create to return a shared shader 2016-03-08 18:50:00 -08:00
SampleDraw.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleEffects.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleEmboss.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleFatBits.cpp switch surface to sk_sp 2016-03-23 18:59:25 -07:00
SampleFillType.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleFilter2.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleFilter.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleFilterFuzz.cpp Update TileImageFilter to sk_sp 2016-04-15 07:57:40 -07:00
SampleFilterQuality.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleFontCache.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleFontScalerTest.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleFuzz.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleGradients.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleHairCurves.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleHairline.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleHairModes.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleHT.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleIdentityScale.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleLayerMask.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleLayers.cpp Revert of Hide SkCanvas::LayerIter (patchset #2 id:20001 of https://codereview.chromium.org/1897863008/ ) 2016-04-20 17:03:38 -07:00
SampleLCD.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleLighting.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleLines.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleLua.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleManyRects.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleMeasure.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleMegaStroke.cpp add new tests 2016-01-30 10:11:21 -08:00
SamplePatch.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SamplePath.cpp Reverse dependency between SkScalar.h and SkFixed.h. 2016-04-07 08:49:31 -07:00
SamplePathClip.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SamplePathEffects.cpp guard rasterizer and drawlooper setters 2016-03-21 13:25:16 -07:00
SamplePathFill.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SamplePathFuzz.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SamplePdfFileViewer.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SamplePictFile.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SamplePoints.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SamplePolyToPoly.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleQuadStroker.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleRectanizer.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleRegion.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleRepeatTile.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleShaders.cpp switch xfermodes over to sk_sp 2016-03-29 11:32:50 -07:00
SampleShaderText.cpp use Make instead of Create to return a shared shader 2016-03-08 18:50:00 -08:00
SampleShip.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleSkLayer.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleSlides.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleStringArt.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleStrokePath.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleStrokeRect.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleSubpixelTranslate.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleText.cpp Remove uses of SkImageDecoder from samplecode 2016-03-18 15:48:49 -07:00
SampleTextAlpha.cpp Rein in the use of SkDevice.h 2016-04-20 05:29:51 -07:00
SampleTextBox.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleTextOnPath.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleTextureDomain.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
SampleTiling.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleTinyBitmap.cpp use Make instead of Create to return a shared shader 2016-03-08 18:50:00 -08:00
SampleUnpremul.cpp guard rasterizer and drawlooper setters 2016-03-21 13:25:16 -07:00
SampleVertices.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleWritePixels.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleXfer.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00
SampleXfermodesBlur.cpp switch maskfilters to sk_sp 2016-04-04 10:02:58 -07:00
vertexdump.cpp Style bikeshed - remove extraneous whitespace 2016-03-29 09:03:53 -07:00