AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1610835624
skia2/samplecode
History
reed 1610835624 Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) 
Reason for revert:
need to update unittest in blink:

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=261368-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DENABLE_OILPAN=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DV8_SHARED -DUSING_V8_SHARED -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../../third_party/WebKit/public/web -I../../third_party/WebKit/Source/web -I../../third_party/WebKit/Source/web/src -I../../third_party/WebKit/public/web/mac -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/libwebp -I../../third_party/zlib -I../../v8/include -Igen/blink -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O0 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -fstack-protector-all  -c ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp -o obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o
../../third_party/WebKit/Source/core/page/PrintContextTest.cpp:54:20: error: no member named 'getAnnotation' in 'SkPaint'
        if (!paint.getAnnotation())
             ~~~~~ ^

Original issue's description:
> move annotations to canvas virtual
>
> In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002
>
> Committed: https://skia.googlesource.com/skia/+/0eda2587cc9233066cb3f3fec08f35c061780f8e

TBR=halcanary@google.com,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1761793003
2016-03-03 09:14:36 -08:00
..
ClockFaceView.cpp Forward declare SkStrokeRec in SkPathEffect 2015-09-15 12:53:07 -07:00
GMSampleView.cpp Style Change: SkNEW->new; SkDELETE->delete 2015-08-26 13:07:49 -07:00
GMSampleView.h C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
OverView.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
OverView.h Add a header for OverView.cpp as well. 2012-09-18 01:52:20 +00:00
PerlinPatch.cpp make SkComposeShader.h private 2016-02-15 08:27:14 -08:00
Sample2PtRadial.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleAAClip.cpp IWYU: 'core' target, files starting A-C. 2015-08-05 13:57:49 -07:00
SampleAARectModes.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleAARects.cpp use SkColorType instead of SkBitmap::Config in samplecode 2014-02-17 02:55:57 +00:00
SampleAll.cpp make SkComposeShader.h private 2016-02-15 08:27:14 -08:00
SampleAnimatedText.cpp Move texture drawing utility method to SkGpuDevice 2015-12-08 18:53:44 -08:00
SampleAnimator.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleAnimBlur.cpp C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
SampleApp.cpp Revert of Implement support for using GL ES 3.0 with command buffer (patchset #6 id:100001 of https://codereview.chromium.org/1684413003/ ) 2016-03-03 07:39:49 -08:00
SampleApp.h Revert of Implement support for using GL ES 3.0 with command buffer (patchset #6 id:100001 of https://codereview.chromium.org/1684413003/ ) 2016-03-03 07:39:49 -08:00
SampleArc.cpp make SkComposeShader.h private 2016-02-15 08:27:14 -08:00
SampleAtlas.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleBigBlur.cpp move common blur types into central header 2014-04-28 16:25:35 +00:00
SampleBigGradient.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleBitmapRect.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleBlur.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleCamera.cpp Fix up -Winconsistent-missing-override 2015-07-13 06:18:39 -07:00
SampleChart.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleCircle.cpp IWYU: 'core' target, files starting A-C. 2015-08-05 13:57:49 -07:00
SampleClamp.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleClip.cpp IWYU: 'core' target, files starting A-C. 2015-08-05 13:57:49 -07:00
SampleClipDrawMatch.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleClock.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleCode.h remove SkGPipe 2016-01-08 06:30:14 -08:00
SampleColorFilter.cpp s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/ 2015-01-26 12:49:00 -08:00
SampleComplexClip.cpp fix more 64bit warnings 2014-01-27 13:42:58 +00:00
SampleConcavePaths.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleDash.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleDegenerateTwoPtRadials.cpp C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
SampleDither.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleDitherBitmap.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleDraw.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleEffects.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleEmboss.cpp remove unused Kernel33MaskFilter 2014-05-12 13:35:55 +00:00
SampleFatBits.cpp add caps option 'k' to FatBits 2015-11-16 18:57:19 -08:00
SampleFillType.cpp remove unused SkCullPoints 2015-12-21 18:37:16 -08:00
SampleFilter2.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleFilter.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleFilterFuzz.cpp Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ ) 2016-03-03 09:14:36 -08:00
SampleFilterQuality.cpp Missing resources crash SampleFilterQuality. 2015-11-10 13:29:44 -08:00
SampleFontCache.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleFontScalerTest.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleFuzz.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleGradients.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleHairCurves.cpp Change old PRG to be SkLCGRandom; change new one to SkRandom 2013-09-09 20:09:12 +00:00
SampleHairline.cpp remove xmlparser includes from samples 2016-02-29 09:13:26 -08:00
SampleHairModes.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleHT.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleIdentityScale.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleLayerMask.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleLayers.cpp Revert[2] of "add backdrop option to SaveLayerRec" 2016-01-07 11:28:08 -08:00
SampleLCD.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SampleLighting.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleLines.cpp remove xmlparser includes from samples 2016-02-29 09:13:26 -08:00
SampleLua.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleManyRects.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleMeasure.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleMegaStroke.cpp add new tests 2016-01-30 10:11:21 -08:00
SamplePatch.cpp Check bounds before casting float to integer in SamplePatch.cpp and SkBlurMaskFilter::CreateEmboss. 2016-03-01 13:44:10 -08:00
SamplePath.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SamplePathClip.cpp EdgeClip demo to show scan-converter clipping behavior 2015-09-28 06:16:07 -07:00
SamplePathEffects.cpp Remove SkLerpXfermode 2016-01-25 14:19:56 -08:00
SamplePathFill.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SamplePathFuzz.cpp If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for. 2016-01-04 19:13:19 -08:00
SamplePdfFileViewer.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SamplePictFile.cpp remove xmlparser includes from samples 2016-02-29 09:13:26 -08:00
SamplePoints.cpp remove xmlparser includes from samples 2016-02-29 09:13:26 -08:00
SamplePolyToPoly.cpp remove SkFloatToScalar macro 2013-11-25 19:44:07 +00:00
SampleQuadStroker.cpp replace arcto quads with a conic 2016-01-20 11:55:11 -08:00
SampleRectanizer.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleRegion.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleRepeatTile.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleShaders.cpp make SkComposeShader.h private 2016-02-15 08:27:14 -08:00
SampleShaderText.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleShip.cpp Add text animation sample; tweak DrawShip sample 2015-11-08 08:07:24 -08:00
SampleSkLayer.cpp deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients 2013-12-17 19:22:07 +00:00
SampleSlides.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleStringArt.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleStrokePath.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleStrokeRect.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SampleSubpixelTranslate.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleText.cpp remove xmlparser includes from samples 2016-02-29 09:13:26 -08:00
SampleTextAlpha.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleTextBox.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SampleTextOnPath.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleTextureDomain.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleTiling.cpp Reland of change all factories to return their base-class (patchset #1 id:1 of https://codereview.chromium.org/1540203002/ ) 2015-12-21 08:52:45 -08:00
SampleTinyBitmap.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleUnpremul.cpp Reland of change all factories to return their base-class (patchset #1 id:1 of https://codereview.chromium.org/1540203002/ ) 2015-12-21 08:52:45 -08:00
SampleVertices.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SampleWritePixels.cpp remove unused SkCullPoints 2015-12-21 18:37:16 -08:00
SampleXfer.cpp add interactive xfer sample 2015-09-02 19:05:10 -07:00
SampleXfermodesBlur.cpp remove xmlparser includes from samples 2016-02-29 09:13:26 -08:00
vertexdump.cpp remove SkFloatToScalar macro 2013-11-25 19:44:07 +00:00