skia2/tests/sksl/inliner/golden
John Stiles 35fee4c079 Revert "Declare all inlined variables at the topmost scope possible."
This reverts commit e8e4aca955.

Reason for revert: can break ES2 for-loop rules

Original change's description:
> Declare all inlined variables at the topmost scope possible.
>
> By itself, this is uninteresting and even perhaps slightly
> counterproductive (as it separates vardecl from its initializer,
> increasing LOC). However, this enables a followup CL
> (http://review.skia.org/344665) which allows single-return functions to
> be inlined without the creation of a temporary variable at all. This
> applies to the majority of fragment processors in a typical Ganesh
> hierarchy. This change will greatly reduce the number of inliner-created
> temporary copies when compiling a typical tree of FPs.
>
> Change-Id: I03423a13cf35050637dabace4a32973a08a4ed0a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344764
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: Ica01d6906bcb9cef1f49d22dda714fc9cbfa3885
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345121
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-12-16 18:26:21 +00:00
..
DoWhileBodyMustBeInlinedIntoAScope.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
DoWhileTestCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
ExponentialGrowth.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
ExponentialGrowthStandaloneSettings.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
ForBodyMustBeInlinedIntoAScope.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
ForInitializerExpressionsCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ForWithoutReturnInsideCanBeInlined.glsl Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
ForWithReturnInsideCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
IfBodyMustBeInlinedIntoAScope.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
IfElseBodyMustBeInlinedIntoAScope.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
IfElseChainWithReturnsCanBeInlined.glsl Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
IfTestCanBeInlined.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
IfWithReturnsCanBeInlined.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
InlineKeywordOverridesThreshold.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
InlinerAvoidsVariableNameOverlap.glsl Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
InlinerCanBeDisabled.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
InlinerCanBeDisabledStandaloneSettings.glsl Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
InlinerManglesNames.glsl Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
InlinerWrapsEarlyReturnsWithDoWhileBlock.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlinerWrapsEarlyReturnsWithDoWhileBlockStandaloneSettings.glsl Rename 'DefaultSettings' golden outputs to 'StandaloneSettings'. 2020-09-21 22:15:51 +00:00
InlineThreshold.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
InlineWithInoutArgument.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
InlineWithModifiedArgument.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
InlineWithNestedBigCalls.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
InlineWithNestedCalls.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
InlineWithUnmodifiedArgument.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
InlineWithUnnecessaryBlocks.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
ShortCircuitEvaluationsCannotInlineRightHandSide.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
SwitchWithCastCanBeInlined.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
SwitchWithoutReturnInsideCanBeInlined.glsl Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 18:26:21 +00:00
SwitchWithReturnInsideCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
SwizzleCanBeInlinedDirectly.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
TernaryResultsCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
TernaryTestCanBeInlined.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
TrivialArgumentsInlineDirectly.glsl Avoid creating unnecessary scopes during inlining. 2020-12-15 21:11:45 +00:00
WhileBodyMustBeInlinedIntoAScope.glsl Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 18:24:57 +00:00
WhileTestCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00