AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7d8013f306
skia2/gyp
History
scroggo@google.com 7d8013f306 Changes to SkTDStackNester. 
SkTDStackNester is a class used by PdfViewer to assist in saving
and restoring the PDF state. Clean up and test this class.

Add some documentation.

Add FIXME's where I have questions to resolve.

Fix a bug where fNestingLevel was not initialized.

Remove a commented out line of code copied over from
SkTDStack.

Rename SkTDStackNester::nests() to nestingLevel() and make it const.

Remove unnecessary predeclaration and friend declaration.

Remove index() (both const and non-const versions). They were
unused, return something that may not be expected (index from
the top, rather than from the bottom), and don't work to get any
elements in earlier Recs once the first one is full.

Report a warning if the nesting level goes above the maximum level,
or if we attempt to bring it below zero.

Prevent fNestingLevel from dropping below zero.

Add kUnusedObject_SkPdfIssue, and use it where appropriate.

Depends on https://codereview.chromium.org/64093009/

R=mtklein@google.com

Review URL: https://codereview.chromium.org/68843006

git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 21:40:57 +00:00
..
android_deps.gyp Update DEPS and GYP to use the copy of Android in platform_tools. 2013-05-02 12:27:21 +00:00
android_system.gyp Update DEPS and GYP to use the copy of Android in platform_tools. 2013-05-02 12:27:21 +00:00
angle.gyp Refactor skia_warnings_as_errors 2013-03-22 13:16:06 +00:00
animator.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00
apptype_console.gypi Update Skia Android tools. 2013-08-12 12:30:04 +00:00
bench.gyp refactor duplication (shouldSkip and skip_name) into a utility function 2013-07-24 17:24:23 +00:00
bench.gypi Revert "Revert "speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values."" 2013-11-07 16:06:53 +00:00
chromeos_deps.gyp GYP Changes and Scripts for Compiling Skia for ChromeOS 2013-06-11 15:52:19 +00:00
cityhash.gyp Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp 2013-05-08 16:04:02 +00:00
common_conditions.gypi More common_conditions simplifications. 2013-11-20 18:06:10 +00:00
common_variables.gypi Hook in rough distance field support for fonts 2013-11-11 20:54:09 +00:00
common.gypi Remove uses of GR_RELEASE. 2013-09-03 23:32:08 +00:00
core.gyp ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs 2013-10-17 16:29:34 +00:00
core.gypi move SkImageInfo into its own header 2013-11-13 19:09:13 +00:00
debugger.gyp Revert r11342 (Add infrastructure for testing the debugger code) due to build breakages 2013-09-18 13:28:10 +00:00
dm.gyp DM: add --pipe 2013-10-28 19:51:26 +00:00
edtaa.gyp Hook in rough distance field support for fonts 2013-11-11 20:54:09 +00:00
effects.gyp Implement SSE2-based implementations of the morphology filters (dilate & erode). This gives a 3-5X speedup over the naive implementation, and also mitigates a timing-based security attack in Chrome (https://code.google.com/p/chromium/issues/detail?id=251711). 2013-10-30 21:57:04 +00:00
effects.gypi Remove SkLumaXfermode. 2013-10-14 13:11:11 +00:00
everything.gyp Include pdfviewer in everything. 2013-11-14 15:46:25 +00:00
experimental.gyp Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
FileReaderApp.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
flags.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
fontconfig.gyp Sanitizing source files in Housekeeper-Nightly 2013-08-21 07:01:29 +00:00
freetype.gyp Add libpoppler for PDF rendering, take 2 2013-08-20 18:57:01 +00:00
freetype.gypi Sanitizing source files in Housekeeper-Nightly 2013-08-21 07:01:29 +00:00
gm.gyp Pdfviewer refactoring. 2013-11-14 19:09:27 +00:00
gmslides.gypi add GM case nonclosedpaths. The 2 bugs below showed some non-closed paths which are easy to get wrong rendering results. So add a GM case for this kind paths to avoid potential bugs to be introduced. 2013-11-09 01:37:30 +00:00
gpu.gyp Hook in rough distance field support for fonts 2013-11-11 20:54:09 +00:00
gpu.gypi GrTHashCache -> GrTHashTable 2013-10-21 21:04:06 +00:00
gputest.gyp Fix android doubly defined empty string due to static lib and shared lib thing. 2013-08-21 20:50:50 +00:00
iconv.gyp Sanitizing source files in Housekeeper-Nightly 2013-08-21 07:01:29 +00:00
images.gyp Don't require getLength on Mac. 2013-08-28 19:13:13 +00:00
jsoncpp.gyp quiet down more third-party warnings in poppler and jsoncpp 2013-09-30 18:19:26 +00:00
libjpeg.gyp Sanitizing source files in Housekeeper-Nightly 2013-06-11 07:01:17 +00:00
libwebp.gyp A fix for annoying clang error "unused-const-variabl" in third_party code. 2013-10-28 22:05:12 +00:00
lua.gyp use define to work-around localeconf() missingness in android 2013-05-15 20:55:49 +00:00
most.gyp pathops work in progress 2013-11-01 17:36:03 +00:00
nacl.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
opts.gyp Implement a NEON version of morphology. This is good for ~2.2X speedup on Tegra3. 2013-11-11 16:48:51 +00:00
pathops_unittest.gyp path ops work in progress 2013-10-02 14:49:34 +00:00
pathops_unittest.gypi path ops work in progress 2013-10-02 14:49:34 +00:00
pathops.gypi path ops work in progress 2013-09-16 15:55:01 +00:00
pdf.gyp Add SkPDFDeviceFlatenner which extends SkPDFDevice to add support to flatten the path and the text when we have perspective. 2013-10-14 13:42:12 +00:00
pdf.gypi Add SkPDFDeviceFlatenner which extends SkPDFDevice to add support to flatten the path and the text when we have perspective. 2013-10-14 13:42:12 +00:00
pdfviewer_lib.gyp Move SkTDStackNester into its own private file. 2013-11-20 20:47:21 +00:00
pdfviewer.gyp Pdfviewer refactoring. 2013-11-14 19:09:27 +00:00
pixman_test.gyp GYP Changes and Scripts for Compiling Skia for ChromeOS 2013-06-11 15:52:19 +00:00
poppler.gyp Add extra warnings to match what Android uses. 2013-11-20 15:13:49 +00:00
ports.gyp allow both GDI and DW fontmgrs at the same time 2013-08-21 15:20:43 +00:00
public_headers.gypi Remove unused header SkImageTypes.h 2013-10-16 17:02:28 +00:00
SampleApp.gyp Pdfviewer refactoring. 2013-11-14 19:09:27 +00:00
sfnt.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00
shapeops_demo.gyp GYP Changes and Scripts for Compiling Skia for ChromeOS 2013-06-11 15:52:19 +00:00
shapeops_edge.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
shapeops_tool.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
SimpleCocoaApp.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
SimpleiOSApp.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
skia_lib.gyp refactor gyp to isolate freetype usage 2013-07-22 14:12:56 +00:00
skpskgr_test.gyp pathops work in progress 2013-11-01 17:36:03 +00:00
svg.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00
tests.gyp Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
tools.gyp fix multithread related crashes in skpdiff 2013-11-12 18:29:17 +00:00
utils.gyp pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even if it is not used) 2013-11-12 17:44:28 +00:00
views_animated.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00
views.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00
xml.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00
xps.gyp Prepare skia for shared library build on android 2013-06-03 12:10:19 +00:00
zlib.gyp Update obvious deps. 2013-07-22 14:39:45 +00:00