9cb74e9079
PS 1 is re-generating existing BUILD.bazel files PS 2 is generating BUILD.bazel files for tests/gms PS 3+ makes modifications to build all of the gms and tests. It is recommended to view this CL with just a diff between PS 2 and the end, due to the large amount of generated changes in PS 1 and 2. We make a filegroup for the gms and tests because they need to be compiled as one large blob in order for the registries to work. Maybe in the future we will break these up, but at least for WASM/JS, the overhead of starting a browser for each new test would likely grind things to a halt, so we just group them all together for now. It's also the most similar to what we currently do. In gm/BUILD.bazel and tests/BUILD.bazel, we add a cc_library that encapsulates all of the deps of the tests, so we can easily include that the build. These were discovered via trial and error, not anything automatic or systematic. The is_skia_dev_build config_setting is very similar to the GN equivalent from which it was based. The list of gms and tests to skip (e.g. which are incompatible with WASM) was determined by building the wasm bundle: modules/canvaskit$ make bazel_gms_release tools/run-wasm-gm-tests$ make run_local_debug # Don't forget to click the button on the screen after the # browser loads This way of invoking the tests will be replace soon with `bazel test <something>`. As such, I didn't bother fully documenting the current way. Suggested review order: - modules/canvaskit/BUILD.bazel taking note that we always use profiling-funcs to make the stacktraces human readable. - gm/BUILD.bazel and tests/BUILD.bazel to see the lists of gms/tests. Notice the tests are roughly partitioned because we don't support things like vulkan/PDF in the wasm build and we will want a way to not build certain tests for certain configurations - tools/* noting some of the cc_libraries added to make dependencies easier to add when needed. - All other files. Change-Id: I43059cd93c28af1c4c12b93d6ebd9c46a12d381f Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506256 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com> |
||
|---|---|---|
| .. | ||
| d3d | ||
| dawn | ||
| gl | ||
| mock | ||
| mtl | ||
| vk | ||
| BackendSurfaceFactory.cpp | ||
| BackendSurfaceFactory.h | ||
| BackendTextureImageFactory.cpp | ||
| BackendTextureImageFactory.h | ||
| BUILD.bazel | ||
| FenceSync.h | ||
| FlushFinishTracker.cpp | ||
| FlushFinishTracker.h | ||
| GpuTimer.h | ||
| GrContextFactory.cpp | ||
| GrContextFactory.h | ||
| GrTest.cpp | ||
| ManagedBackendTexture.cpp | ||
| ManagedBackendTexture.h | ||
| MemoryCache.cpp | ||
| MemoryCache.h | ||
| ProxyUtils.cpp | ||
| ProxyUtils.h | ||
| TestContext.cpp | ||
| TestContext.h | ||
| TestOps.cpp | ||
| TestOps.h | ||
| YUVUtils.cpp | ||
| YUVUtils.h | ||