skia2/tests
Leon Scroggins III 995b467563 SkIcoCodec: Read the entire stream into data
Bug: 932080
Bug: b/142252770

An ICO file has a directory of images that are stored later in the file.
The directory contains the offset and size of the images. SkIcoCodec
uses these to create embedded SkPng/SkBmpCodecs. The old implementation
allocated a block of memory for each image and copied the stream into
those blocks so that the embedded SkCodecs could independently read
their encoded data.

Although SkIcoCodec checks for null, this still allows large (albeit
temporary - since we'll discard them if the stream does not contain
enough data to fill them) allocations and the potential for over-
commit.

Instead, read the entire stream into a contiguous buffer. If the stream
is already actually a buffer, just use that directly. In this case, the
new code will do less work. Otherwise, the memory we allocate is
limited by the size of the stream.

Note that this is a behavior change for a stream that contains two
consecutive ICOs, where the client expects to be able to read the second
one later. This was an issue for PNGs on Android (b/34073812), but I
suspect no one is relying on this behavior for ICO. Update Codec_end
test to remove the ICO test.

Alternatives to consider:
- only buffer the individual encoded images. This will allow us to
continue passing the Codec_end test.
- lazily read the embedded streams. Currently we read their start to
verify they are valid images (at least in the header) and read their
actual sizes and bit-depths, which could differ from that listed in
the directory. We use those to make a guess at the "best" image to use.
An image with mismatched sizes may now decode differently.

Change-Id: I30e5f6c8c2e5a0fa135348f61efe151a7f5d4756
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277058
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
2020-06-01 21:14:09 +00:00
..
AAClipTest.cpp more rect api simplifications 2019-08-25 10:12:57 +00:00
AdvancedBlendTest.cpp Make GrBlend.h private 2019-08-15 13:34:57 +00:00
AndroidCodecTest.cpp DCI-P3 -> Display P3 in Skia 2020-01-16 21:24:16 +00:00
AnimatedImageTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
AnnotationTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
ApplyGammaTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
ArenaAllocTest.cpp Add array initializer 2020-05-14 14:34:12 +00:00
AsADashTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
BackendAllocationTest.cpp Reland "Reland "Add api on GrContext to update the data of GrBackendTextures."" 2020-05-13 21:49:25 +00:00
BackendSurfaceMutableStateTest.cpp Add GrBackendMutableState object to handle shared texture state. 2020-05-29 16:53:08 +00:00
BadIcoTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
BitmapCopyTest.cpp Reland "Reland "SkSurface asynchronous read APIs allow client to extend pixel lifetime"" 2019-10-03 19:14:22 +00:00
BitmapGetColorTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
BitmapTest.cpp Reland "Make SkBitmap/SkPixmap::erase* do so in sRGB" 2020-04-23 20:07:09 +00:00
BitSetTest.cpp Fix SkBitSet. 2020-05-05 20:04:11 +00:00
BlendTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
BlitMaskClip.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
BlurTest.cpp Remove SkClampMax 2020-02-06 19:49:53 +00:00
BRDTest.cpp Move SkBitmapRegionCodec into client_utils/android 2020-05-20 20:06:48 +00:00
BulkRectTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
CachedDataTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
CachedDecodingPixelRefTest.cpp Remove unnecessary SK_SIZE_T_SPECIFIER macro. 2020-05-05 13:25:28 +00:00
CanvasStateHelpers.cpp Match CanvasStateHelpers.cpp change in Android repo 2019-08-30 13:49:11 +00:00
CanvasStateHelpers.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
CanvasStateTest.cpp update test to allow dumping images 2019-09-03 17:48:15 +00:00
CanvasTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
ChecksumTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ClearTest.cpp Reland "Simplify GrRTC::clean APIs" 2020-05-27 14:26:16 +00:00
ClipBoundsTest.cpp Simplify GrClip::getConservativeBounds() signature 2020-05-13 18:59:13 +00:00
ClipCubicTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
ClipperTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
ClipStackTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
CodecAnimTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
CodecExactReadTest.cpp SkIcoCodec: Read the entire stream into data 2020-06-01 21:14:09 +00:00
CodecPartialTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
CodecPriv.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
CodecRecommendedTypeTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
CodecTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
ColorFilterTest.cpp Remove arbitrary limit on number of composed color filters 2020-03-27 15:01:32 +00:00
ColorMatrixTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
ColorPrivTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ColorSpaceTest.cpp DCI-P3 -> Display P3 in Skia 2020-01-16 21:24:16 +00:00
ColorTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
CompressedBackendAllocationTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
CopySurfaceTest.cpp Don't require color type to make proxy copies. 2020-04-03 15:25:34 +00:00
CrbugOssfuzz21688.cpp Disallow empty interface blocks in SkSL. 2020-04-21 20:36:54 +00:00
CTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
CubicMapTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
DashPathEffectTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
DataRefTest.cpp test data.equals with empty 2020-02-17 17:53:49 +00:00
DebugLayerManagerTest.cpp Parse android layer annotations in debugger, play back layers 2019-12-12 16:32:44 +00:00
DefaultPathRendererTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
DeferredDisplayListTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
DequeTest.cpp move SkDeque.h into private 2020-02-18 02:05:08 +00:00
DescriptorTest.cpp Make allocation of SkDescriptor do initialization 2019-12-16 19:55:42 +00:00
DetermineDomainModeTest.cpp Remove texture swizzle from GrSurfaceProxy. 2020-03-27 17:01:07 +00:00
DeviceTest.cpp Remove unused dstColorSpace parameter from makeTextureImage 2019-08-14 19:09:05 +00:00
DiscardableMemoryPoolTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
DiscardableMemoryTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
DrawBitmapRectTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
DrawOpAtlasTest.cpp Plumb SkMatrixProvider throughout Ganesh 2020-04-20 13:48:40 +00:00
DrawPathTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
DrawTextTest.cpp IWYU for tests A-D. 2019-05-07 14:24:15 +00:00
EGLImageTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
EmptyPathTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
EncodedInfoTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
EncodeTest.cpp Stop including SkCanvas.h from GrTypesPriv.h 2020-03-30 20:43:34 +00:00
ExifTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ExtendedSkColorTypeTests.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
F16StagesTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
FakeStreams.h Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
FillPathTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
FitsInTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
FlattenableFactoryToName.cpp Update tests to use new image filter factories 2019-08-05 15:15:45 +00:00
FlattenableNameToFactory.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
FlattenDrawableTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Float16Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
FloatingPointTextureTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
FontHostStreamTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
FontHostTest.cpp add copytable method to typefaces 2019-07-24 19:20:46 +00:00
FontMgrAndroidParserTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
FontMgrFontConfigTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
FontMgrTest.cpp Check for invalid unicode in fallback. 2020-03-03 16:24:21 +00:00
FontNamesTest.cpp Remove SkMin32/SkMax32 2020-02-06 17:31:51 +00:00
FontTest.cpp add flatten test to SkFont 2019-11-08 18:49:15 +00:00
FrontBufferedStreamTest.cpp Reland "Move SkFrontBufferedStream into Android-only dir" 2020-04-24 17:36:30 +00:00
GeometryTest.cpp more rect api simplifications 2019-08-25 10:12:57 +00:00
GifTest.cpp Enable Codec_GifInterlacedTruncated test for Wuffs 2019-09-24 16:48:33 +00:00
GLBackendSurfaceTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
GlyphRunTest.cpp Use SkFontHinting instead of macros. 2019-05-08 12:16:37 +00:00
GpuDrawPathTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
GpuRectanizerTest.cpp Reland GrRectanizerPow2 2020-05-19 18:35:13 +00:00
GradientTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
GrAHardwareBufferTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
GrBlockAllocatorTest.cpp Refactor GrMemoryPool into reusable GrBlockAllocator 2020-03-17 14:41:14 +00:00
GrCCPRTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
GrContextAbandonTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
GrContextFactoryTest.cpp Expose GrContext::dump() when SK_ENABLE_DUMP_GPU is defined. 2019-08-09 14:13:01 +00:00
GrFinishedFlushTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
GrGLExtensionsTest.cpp Reland fully delineate GL usage w/ skia_use_gl. 2019-11-12 21:43:44 +00:00
GrMemoryPoolTest.cpp Refactor GrMemoryPool into reusable GrBlockAllocator 2020-03-17 14:41:14 +00:00
GrMeshTest.cpp Reland "Simplify GrRTC::clean APIs" 2020-05-27 14:26:16 +00:00
GrMipMappedTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
GrOpListFlushTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
GrPipelineDynamicStateTest.cpp Reland "Simplify GrRTC::clean APIs" 2020-05-27 14:26:16 +00:00
GrPorterDuffTest.cpp Add finisehd proc to backend texture creation. 2020-05-06 16:50:33 +00:00
GrQuadBufferTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
GrQuadCropTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
GrStyledShapeTest.cpp Reland "Refactor geometry union capabilities out of GrStyledShape" 2020-04-30 19:36:43 +00:00
GrSubmittedFlushTest.cpp Add submittedProc to GrFlushInfo. 2020-05-27 12:48:43 +00:00
GrSurfaceTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
GrTAllocatorTest.cpp Add GrTAllocator::push_back(T&&) 2020-03-30 22:37:25 +00:00
GrTestingBackendTextureUploadTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
GrTextureMipMapInvalidationTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
GrTRecorderTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
GrUploadPixelsTests.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
HashTest.cpp remove unused mutate() apis 2020-03-16 20:44:36 +00:00
HighContrastFilterTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
HSVRoundTripTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ICCTest.cpp Move skcms.h to include/third_party/skcms 2019-04-29 15:02:45 +00:00
ImageBitmapTest.cpp Tests: re-sort gni, file name convention 2019-05-04 02:17:09 +00:00
ImageCacheTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ImageFilterCacheTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
ImageFilterTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
ImageFrom565Bitmap.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ImageGeneratorTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ImageIsOpaqueTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ImageNewShaderTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ImageTest.cpp Reland "Implement submit API to GrContext." 2020-05-20 19:00:25 +00:00
IncrTopoSortTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
IndexedPngOverflowTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
InfRectTest.cpp more rect api simplifications 2019-08-25 10:12:57 +00:00
InsetConvexPolyTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
InterpolatorTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
InvalidIndexedPngTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
IsClosedSingleContourTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
JSONTest.cpp Move ccpr headers for display list out of include/private. 2019-05-20 14:50:56 +00:00
LayerDrawLooperTest.cpp Rename SkDevice::ctm() to localToDevice() 2019-10-18 18:04:31 +00:00
LazyProxyTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
LListTest.cpp Move ccpr headers for display list out of include/private. 2019-05-20 14:50:56 +00:00
LRUCacheTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
M44Test.cpp separate m44 tests 2020-04-16 10:53:37 +00:00
MallocPixelRefTest.cpp Make SkImageInfo::validRowBytes consider alignment 2020-01-22 16:40:34 +00:00
MaskCacheTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
MathTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
Matrix44Test.cpp separate m44 tests 2020-04-16 10:53:37 +00:00
MatrixClipCollapseTest.cpp Remove SkMin32/SkMax32 2020-02-06 17:31:51 +00:00
MatrixColorFilterTest.cpp Fix GrColorMatrixFragmentProcessor handling of premul transparent black. 2020-01-02 14:55:06 +00:00
MatrixTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
MD5Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
MemoryTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
MemsetTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
MessageBusTest.cpp Move SkMessageBus.h into src/core 2019-05-15 15:33:48 +00:00
MetaDataTest.cpp re-run tools/rewrite_includes.py 2019-07-25 15:40:33 +00:00
MipMapTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
MtlBackendAllocationTest.mm Add finisehd proc to backend texture creation. 2020-05-06 16:50:33 +00:00
MtlCopySurfaceTest.mm Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
MultiPictureDocumentTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
NonlinearBlendingTest.cpp DCI-P3 -> Display P3 in Skia 2020-01-16 21:24:16 +00:00
OctoBoundsTest.cpp ccpr: Clip path octo bounds by the scissor 2019-05-13 15:32:43 +00:00
OffsetSimplePolyTest.cpp More polyutils fixes 2019-05-01 18:02:05 +00:00
OnceTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
OnFlushCallbackTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
OpChainTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
OSPathTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
OverAlignedTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PackBitsTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PackedConfigsTextureTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
PaintImageFilterTest.cpp Update tests to use new image filter factories 2019-08-05 15:15:45 +00:00
PaintTest.cpp Remove SkMaxScalar and SkMinScalar 2020-02-06 15:43:22 +00:00
ParametricStageTest.cpp Starting to hack up HDR transfer function support 2019-10-16 18:40:16 +00:00
ParsePathTest.cpp Revert "add guard to switch to SkPathTypes" 2019-09-14 19:13:44 +00:00
PathCoverageTest.cpp Remove SkMin32/SkMax32 2020-02-06 17:31:51 +00:00
PathMeasureTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsAngleIdeas.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PathOpsAngleTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsAsWindingTest.cpp remove dead code around old SkPath enums 2019-12-14 01:58:10 +00:00
PathOpsBattles.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsBoundsTest.cpp more rect api simplifications 2019-08-25 10:12:57 +00:00
PathOpsBuilderConicTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsBuilderTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsBuildUseTest.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsChalkboardTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsConicIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsConicLineIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsConicQuadIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicConicIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicIntersectionTestData.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicIntersectionTestData.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicLineIntersectionIdeas.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PathOpsCubicLineIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicQuadIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsCubicReduceOrderTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsDCubicTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsDebug.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PathOpsDebug.h mark tests flaky for pathkit 2018-08-27 20:35:15 +00:00
PathOpsDLineTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsDPointTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsDRectTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsDVectorTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsExtendedTest.cpp Remove RawIter usages from pathops 2020-05-07 19:38:50 +00:00
PathOpsExtendedTest.h remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsFuzz763Test.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsInverseTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsIssue3651.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsLineIntersectionTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PathOpsLineParametetersTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsOpCircleThreadedTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsOpCubicThreadedTest.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsOpLoopThreadedTest.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsOpRectThreadedTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsOpTest.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsQuadIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsQuadIntersectionTestData.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsQuadIntersectionTestData.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsQuadLineIntersectionTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsQuadLineIntersectionThreadedTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsQuadReduceOrderTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsSimplifyDegenerateThreadedTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsSimplifyFailTest.cpp remove dead code around old SkPath enums 2019-12-14 01:58:10 +00:00
PathOpsSimplifyQuadralateralsThreadedTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsSimplifyQuadThreadedTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsSimplifyRectThreadedTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsSimplifyTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsSimplifyTrianglesThreadedTest.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsSkpTest.cpp remove SkTLS 2020-03-06 14:41:01 +00:00
PathOpsTestCommon.cpp Remove RawIter usages from pathops 2020-05-07 19:38:50 +00:00
PathOpsTestCommon.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsThreadedCommon.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsThreadedCommon.h Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
PathOpsThreeWayTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsTigerTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsTightBoundsTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PathOpsTSectDebug.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathOpsTypesTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PathRendererCacheTests.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
PathTest.cpp Remove SkPath::RawIter from tests/tools/samplecode 2020-05-06 16:31:53 +00:00
PDFDeflateWStreamTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PDFDocumentTest.cpp SkPDF: simplify Producer metadata logic 2019-10-21 20:01:47 +00:00
PDFGlyphsToUnicodeTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
PDFJpegEmbedTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PDFMetadataAttributeTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PDFOpaqueSrcModeToSrcOverTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PDFPrimitivesTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
PDFTaggedLinkTest.cpp Add support for tagging link annotations in PDFs. 2020-03-24 15:52:55 +00:00
PDFTaggedPruningTest.cpp Allow passing multiple node IDs per PDF structure node. 2020-02-24 18:21:16 +00:00
PDFTaggedTableTest.cpp Simplify interface to StructureElementNode. 2020-02-20 21:16:48 +00:00
PDFTaggedTest.cpp Add marked-content ID to PDF images 2020-03-06 19:48:50 +00:00
PictureBBHTest.cpp make SkBBH a public interface 2020-02-12 16:31:05 +00:00
PictureShaderTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PictureTest.cpp Remove exotic legacy bitmap drawing entry points: Nine, Lattice 2020-03-11 13:11:47 +00:00
PinnedImageTest.cpp More robust fix for command buffer context crash. 2020-04-09 19:28:06 +00:00
PixelRefTest.cpp Prevent unbounded listener growth on SkPixelRefs. 2020-03-02 22:32:09 +00:00
Point3Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PointTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PolyUtilsTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
PremulAlphaRoundTripTest.cpp Rename GrColorSpaceInfo -> GrColorInfo 2019-09-30 21:53:24 +00:00
PrimitiveProcessorTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
ProcessorTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
ProgramsTest.cpp Reland "Revert "Revert "GrDisplacementEffect uses GrTextureEffect.""" 2020-04-17 20:19:48 +00:00
PromiseImageTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
ProxyConversionTest.cpp Don't require color type to wrap a texture/RT. 2020-03-31 19:18:39 +00:00
ProxyRefTest.cpp Remove texture swizzle from GrSurfaceProxy. 2020-03-27 17:01:07 +00:00
ProxyTest.cpp Add finisehd proc to backend texture creation. 2020-05-06 16:50:33 +00:00
QuickRejectTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
RandomTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Reader32Test.cpp SkReader32::setMemory() requires 4-byte alignment 2019-11-20 20:20:10 +00:00
ReadPixelsTest.cpp Remove GrAtlasManager.h from all other .h files 2020-04-07 12:43:46 +00:00
ReadWriteAlphaTest.cpp Add some missed BGRA_1010102 testing tidbits 2020-04-30 18:31:37 +00:00
RecordDrawTest.cpp add metadata to calculated bounds 2020-02-27 19:12:35 +00:00
RecorderTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
RecordingXfermodeTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
RecordOptsTest.cpp hide savelayer's clipmask fields 2020-05-31 14:06:42 +00:00
RecordPatternTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
RecordTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
RecordTestUtils.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
RectangleTextureTest.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
RectTest.cpp Add rect subtraction utility function+tests 2020-04-15 21:44:36 +00:00
RefCntTest.cpp turn on -Wreturn-std-move-in-c++11 2020-02-18 23:55:35 +00:00
RegionTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
RenderTargetContextTest.cpp Reland "Move makeDeferredRenderTargetContext calls to factory on RTC." 2020-01-08 19:13:14 +00:00
RepeatedClippedBlurTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
ResourceAllocatorTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
ResourceCacheTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
RoundRectTest.cpp Fix false positive in SkRRectPriv::ConservativeIntersect 2020-05-06 19:49:39 +00:00
RRectInPathTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
RTreeTest.cpp make SkBBH a public interface 2020-02-12 16:31:05 +00:00
SafeMathTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SamplePatternDictionaryTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ScalarTest.cpp more rect api simplifications 2019-08-25 10:12:57 +00:00
ScaleToSidesTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SerializationTest.cpp remove unused SkLightingShader 2020-03-30 20:55:34 +00:00
SerialProcsTest.cpp Update tests to use new image filter factories 2019-08-05 15:15:45 +00:00
ShaderOpacityTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
ShaderTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
ShadowTest.cpp Improve SkVerticesPriv ergonomics 2020-03-31 16:10:07 +00:00
ShaperTest.cpp Reland "Fix empty run handling in trivial shaper iterators" 2019-11-06 14:32:13 +00:00
SizeTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkBase64Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Skbug5221.cpp Tests: re-sort gni, file name convention 2019-05-04 02:17:09 +00:00
Skbug6389.cpp Update tests to use new image filter factories 2019-08-05 15:15:45 +00:00
Skbug6653.cpp Tests: re-sort gni, file name convention 2019-05-04 02:17:09 +00:00
SkColor4fTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkColorSpaceXformStepsTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkDOMTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkFixed15Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkGaussFilterTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkGlyphBufferTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
skia_test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkImageTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkNxTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
SkPEGTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkRasterPipelineTest.cpp work around GCC false positive warning? 2019-12-04 17:07:46 +00:00
SkRemoteGlyphCacheTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
SkResourceCacheTest.cpp Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 16:58:39 +00:00
SkRuntimeEffectTest.cpp Expose sk_FragCoord for runtime effects 2020-05-27 23:06:09 +00:00
SkScalerCacheTest.cpp Reland "direct mask biased to (0,0)" 2020-05-18 15:58:37 +00:00
SkShaperJSONWriterTest.cpp Add SkMakeSpan and helpful conversion 2019-07-02 21:49:09 +00:00
SkSharedMutexTest.cpp Revert "replace SkSharedMutex" 2020-04-29 18:50:39 +00:00
SkSLErrorTest.cpp Revert "Reland "Revert "SkSL function inlining""" 2020-05-28 13:27:58 +00:00
SkSLFPTest.cpp Revert "Omit dead SkSL functions" 2020-06-01 15:00:00 +00:00
SkSLGLSLTest.cpp Reland "Remove double support from SkSL." 2020-06-01 16:10:29 +00:00
SkSLInterpreterTest.cpp Revert "Omit dead SkSL functions" 2020-06-01 15:00:00 +00:00
SkSLMemoryLayoutTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkSLMetalTest.cpp Reland "Improve matrix construction abilities in Metal codegen." 2020-05-28 22:20:10 +00:00
SkSLSPIRVTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkStrikeCacheTest.cpp Check fullness and purge on every strike lookup 2020-03-16 19:59:56 +00:00
SkUTFTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SkVMTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
SkVxTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SortTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SpecialImageTest.cpp Add SkBudgeted parameter to SkImage::makeTextureImage(). 2020-03-18 17:27:41 +00:00
SpecialSurfaceTest.cpp Make deferred render target context without config or format 2019-07-03 16:53:48 +00:00
SrcOverTest.cpp Remove SkMin32/SkMax32 2020-02-06 17:31:51 +00:00
SrcSrcOverBatchTest.cpp Fix CompatibleCoverageAsAlpha flag when reducing src-over to src. 2020-02-28 18:45:15 +00:00
SRGBReadWritePixelsTest.cpp turn on -Wreturn-std-move-in-c++11 2020-02-18 23:55:35 +00:00
SRGBTest.cpp clean up legacy sRGB stages 2020-05-24 19:47:08 +00:00
StreamBufferTest.cpp use std::make_unique 2019-12-12 22:32:45 +00:00
StreamTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
StringTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
StrokerTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
StrokeTest.cpp Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
SubsetPath.cpp Remove SkPath::RawIter from tests/tools/samplecode 2020-05-06 16:31:53 +00:00
SubsetPath.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
SurfaceSemaphoreTest.cpp Reland "Implement submit API to GrContext." 2020-05-20 19:00:25 +00:00
SurfaceTest.cpp Modify SurfaceTest to only test readbacks from supported surfaces. 2020-05-29 16:21:45 +00:00
SVGDeviceTest.cpp [svgdevice] Handle text path effects 2020-03-13 16:19:06 +00:00
SwizzlerTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
TArrayTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
TDPQueueTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
TemplatesTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Test.h Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
TestTest.cpp Revert "De-GL-ify tests, gm and tools" 2019-05-22 20:23:56 +00:00
TestUtils.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
TestUtils.h Add finisehd proc to backend texture creation. 2020-05-06 16:50:33 +00:00
TextBlobCacheTest.cpp turn off 2M glyph test 2020-05-22 16:13:44 +00:00
TextBlobTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
TextureBindingsResetTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
TextureProxyTest.cpp Don't require color type to wrap a texture/RT. 2020-03-31 19:18:39 +00:00
TextureStripAtlasManagerTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Time.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
TLazyTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
TopoSortTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
TraceMemoryDumpTest.cpp Reland "Move GrGpuResource GrSurface and GrTexture into src." 2020-03-05 19:16:21 +00:00
TracingTest.cpp Move SkLeanWindows.h to src. 2019-05-21 13:48:00 +00:00
TransferPixelsTest.cpp Add BGR_10A2 support to Ganesh (take 2) 2020-04-30 15:25:20 +00:00
TriangulatingPathRendererTests.cpp Reland "GrClips provided as pointers to GrRTC" 2020-05-29 15:09:54 +00:00
TypefaceTest.cpp Mark SkStringPrintf as SK_PRINTF_LIKE 2020-05-12 15:22:14 +00:00
UnicodeTest.cpp Use SkTextEncoding enum instead of macros. 2019-05-07 20:54:16 +00:00
UtilsTest.cpp Fix SkSpan supspan() add test 2020-05-13 16:51:31 +00:00
VerticesTest.cpp Fix SkVertices serialization bug. Also remove Builder getters for counts. 2020-04-02 00:28:36 +00:00
VkBackendSurfaceTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
VkDrawableTest.cpp Remove "nvpr" configs 2019-06-26 16:53:50 +00:00
VkHardwareBufferTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
VkPriorityExtensionTest.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
VkProtectedContextTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
VkWrapTests.cpp Add finisehd proc to backend texture creation. 2020-05-06 16:50:33 +00:00
VkYcbcrSamplerTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
VptrTest.cpp use std::make_unique 2019-12-12 22:32:45 +00:00
WangsFormulaTest.cpp Reland "Add an implementation and log2 variants for Wang's formula" 2020-05-14 02:57:59 +00:00
WindowRectanglesTest.cpp work around GCC 8 mips release bug? 2019-12-04 21:14:13 +00:00
WritePixelsTest.cpp Update internal skia uses to use flushAndSubmit and submit calls. 2020-05-14 20:26:44 +00:00
Writer32Test.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
YUVCacheTest.cpp rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
YUVTest.cpp Add BT2020 (non-constant-luminance) YUV color space 2019-11-01 14:34:13 +00:00