AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
e4949406eb
skia2/include/core
History
Cary Clark d98f78cd01 alternative no anonymous enums 
Anonymous enums play havoc with documentation;
there's no name to refer to. It may be that all
enums may either be named or replaced with constexpr
without breaking anything. Try replacing all
anonymous enums in include/core to see what happens.

This names SkCanvas::SaveLayerFlagsSet but leaves
SkCanvas::SaveLayerFlags as a uint32_t, to reduce
risk as compared to review.skia.org/123584.

There's also some chance that external linkage will
break if some client refers to anonymous enum in a way
that could require its address: see
https://stackoverflow.com/questions/22867654/enum-vs-constexpr-for-actual-static-constants-inside-classes
(This CL does not require definitions + declarations)

Brought bookmaker docs in line with this change.
This also tripped over missing code in bookmaker
handling constexpr so added that as well.

R=reed@google.com,bsalomon@google.com

Docs-Preview: https://skia.org/?cl=123920
Docs-Preview: https://skia.org/?cl=123584
Bug: skia:6898
Change-Id: I14a342edcfd59e139ef9e4501f562417c4c60391
Reviewed-on: https://skia-review.googlesource.com/123920
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-04-26 17:11:53 +00:00
..
SkAnnotation.h remove unneeded flag for annotations 2016-03-05 06:00:12 -08:00
SkBBHFactory.h Remove stray semicolons. 2016-09-27 14:04:26 +00:00
SkBitmap.h remove SK_IGNORE_TO_STRING 2018-04-05 23:52:23 +00:00
SkBlendMode.h move SkBlendMode_Name into public (for chrome) 2016-11-16 19:17:21 +00:00
SkBlurTypes.h Remove SK_SUPPORT_LEGACY_BLURMASKFILTER 2018-04-06 15:02:03 +00:00
SkCanvas.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkCanvasVirtualEnforcer.h Shim to enforce that canvas virtuals are overridden 2018-03-09 19:43:41 +00:00
SkClipOp.h add flag to hide deprecated clipops 2017-05-10 18:56:14 +00:00
SkColor.h SkColorSetARGB in constants 2018-04-17 12:25:13 +00:00
SkColorFilter.h remove SK_IGNORE_TO_STRING 2018-04-05 23:52:23 +00:00
SkColorPriv.h Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SkColorSpace.h Add SkColorSpace::Make, taking an skcms_ICCProfile 2018-04-17 15:18:14 +00:00
SkColorSpaceXform.h Cleaning up SkColorSpaceXform a bit 2018-03-06 20:01:51 +00:00
SkColorSpaceXformCanvas.h Make xformer class for SkCSXCanvas, use for draw loopers 2017-03-30 18:02:58 +00:00
SkCoverageMode.h fix symbol for intersection 2018-02-06 02:40:16 +00:00
SkData.h Class delete call unsized delete when size not known. 2016-10-19 21:41:00 +00:00
SkDataTable.h Convert NULL and 0 to nullptr. 2017-08-28 17:48:57 +00:00
SkDeferredDisplayListRecorder.h Add DoneProc to Promise Images 2018-03-16 19:27:46 +00:00
SkDeque.h This CL addresses "SkCanvas::save flags are not respected by GPU backend" (https://code.google.com/p/skia/issues/detail?id=1503). 2013-08-16 00:53:34 +00:00
SkDocument.h SkDocument: remove unused fDoneProc 2018-01-08 20:53:41 +00:00
SkDrawable.h Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SkDrawFilter.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkDrawLooper.h Remove SK_SUPPORT_LEGACY_BLURMASKFILTER 2018-04-06 15:02:03 +00:00
SkEncodedImageFormat.h GOOGLE3 -> SK_BUILD_FOR_GOOGLE3 2017-12-19 14:42:16 +00:00
SkExecutor.h Add FIFO thread pool, use it for most things. 2017-09-01 16:19:47 +00:00
SkFilterQuality.h Skia Filter Quality and Scaling Metrics 2016-04-18 09:14:00 -07:00
SkFlattenable.h Add API for SkTextBlob serialization into caller's memory. 2018-04-04 01:25:11 +00:00
SkFont.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkFontArguments.h Add SkTypeface::getVariationDesignPosition. 2017-02-24 16:59:05 +00:00
SkFontLCDConfig.h Add SK_API to SkFontLCDConfig. 2016-05-03 11:56:03 -07:00
SkFontStyle.h Make SkTypeface::Style and FromOldStyle private. 2017-10-13 15:49:18 +00:00
SkGraphics.h Remove TLS glyph cache calls. 2018-03-09 19:32:22 +00:00
SkICC.h Improve comment in SkICC.h 2017-02-24 20:35:57 +00:00
SkImage.h Support downscaling to max texture size when making cross-context images 2018-04-13 20:41:12 +00:00
SkImageEncoder.h centralize encoding to SkData 2017-12-09 01:36:48 +00:00
SkImageFilter.h remove SK_IGNORE_TO_STRING 2018-04-05 23:52:23 +00:00
SkImageGenerator.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkImageInfo.h fix SkImageInfo indentation 2018-04-03 19:59:21 +00:00
SkMallocPixelRef.h removed dead colortable code 2017-07-19 22:20:57 +00:00
SkMaskFilter.h Reland "Fix handling of MaskFilter matrices" 2018-04-11 20:13:22 +00:00
SkMath.h SkLiteDL: remove freelisting, add reset() and SKLITEDL_PAGE knob. 2016-08-16 09:36:18 -07:00
SkMatrix44.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkMatrix.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkMetaData.h Convert NULL and 0 to nullptr. 2017-08-28 17:48:57 +00:00
SkMilestone.h Update Skia milestone to 68 2018-04-13 14:01:02 +00:00
SkMultiPictureDraw.h Convert NULL and 0 to nullptr. 2017-08-28 17:48:57 +00:00
SkOverdrawCanvas.h Shim to enforce that canvas virtuals are overridden 2018-03-09 19:43:41 +00:00
SkPaint.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkPath.h Reland "Add private fIsBadForDAA bit to SkPath" 2018-04-12 16:24:40 +00:00
SkPathEffect.h remove SK_IGNORE_TO_STRING 2018-04-05 23:52:23 +00:00
SkPathMeasure.h harden pathmeasure and fix empty case 2018-03-12 14:26:28 +00:00
SkPicture.h Change behavior of custom image serial/deserial 2018-03-08 21:50:51 +00:00
SkPictureRecorder.h Convert NULL and 0 to nullptr. 2017-08-28 17:48:57 +00:00
SkPixelRef.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkPixmap.h update autogenerated includes 2018-04-03 16:33:10 +00:00
SkPngChunkReader.h Delete SkImageDecoder 2016-03-24 10:41:47 -07:00
SkPoint3.h Add some additional checks for shadow generation 2018-02-26 20:02:38 +00:00
SkPoint.h move SkIPoint16 to private header 2018-04-04 20:16:58 +00:00
SkPostConfig.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
SkPreConfig.h eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
SkRasterHandleAllocator.h Make header files self-sufficient 2017-02-10 01:19:52 +00:00
SkRect.h remove unused/dumb methods from SkRect 2018-04-11 19:40:57 +00:00
SkRefCnt.h hide virtual and rename to onMakeComposed 2018-02-19 19:40:14 +00:00
SkRegion.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkRRect.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkRSXform.h Revert "Revert "Make GPU backend triangulate rects such that they are rendered as tri strips rather than tri fans."" 2017-10-18 12:21:17 +00:00
SkRWBuffer.h Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SkScalar.h begin to wrap all float divides 2018-02-12 19:04:19 +00:00
SkSerialProcs.h Change behavior of custom image serial/deserial 2018-03-08 21:50:51 +00:00
SkShader.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkSize.h SkSize can be aggregate-initialized 2017-04-11 18:57:20 +00:00
SkStream.h remove dead code for STREAM_API 2017-09-20 20:43:50 +00:00
SkString.h SkString: remove externally unused ::setUTF16() from API 2018-03-01 22:16:34 +00:00
SkStrokeRec.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00
SkSurface.h Revert "Delete getRenderTargetHandle call on SkSurface." 2018-04-14 18:08:12 +00:00
SkSurfaceCharacterization.h Add SK_API to SkSurfaceCharacterization 2018-04-05 14:20:12 +00:00
SkSurfaceProps.h Flesh out SkSurfaceCharacterization 2017-11-30 17:10:38 +00:00
SkSwizzle.h Add missing SK_API to SkSwizzle.h 2016-03-24 07:50:14 -07:00
SkTextBlob.h Add API for SkTextBlob serialization into caller's memory. 2018-04-04 01:25:11 +00:00
SkTime.h Make SkTime SK_API so that SkTime::GetDateTime() is visible to the clients. 2016-05-02 15:04:46 -07:00
SkTLazy.h Fix SkTCopyOnFirstWrite copy semantics 2018-04-11 17:25:07 +00:00
SkTraceMemoryDump.h Dump additional details about the gpu resources. 2018-03-29 18:08:15 +00:00
SkTypeface.h Add GetTypefaceOrDefault to SkPaintPriv 2018-03-06 15:50:26 +00:00
SkTypes.h remove SK_IGNORE_TO_STRING 2018-04-05 23:52:23 +00:00
SkUnPreMultiply.h Factor out UnPreMultiplyPreservingByteOrder 2014-01-15 22:24:58 +00:00
SkVertices.h Fixed SkVertices crashing on Windows DLL builds 2018-04-22 14:42:01 +00:00
SkYUVSizeInfo.h alternative no anonymous enums 2018-04-26 17:11:53 +00:00