hpayer
071a28605e
Use nobarrier load in store buffer duplicate removal to annotate harmless race.
...
BUG=
Review URL: https://codereview.chromium.org/787383002
Cr-Commit-Position: refs/heads/master@{#25745}
2014-12-10 12:24:33 +00:00
dcarney
70caf05b6a
fix gcmole warning after r25737
...
TBR=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/794563002
Cr-Commit-Position: refs/heads/master@{#25744}
2014-12-10 12:14:23 +00:00
Benedikt Meurer
f6849d9ed4
[turbofan] Fix cycles introduced by pushing ToNumbers into phis.
...
TEST=cctest
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/790123002
Cr-Commit-Position: refs/heads/master@{#25743}
2014-12-10 11:59:44 +00:00
dcarney
59753fb9c1
[turbofan] update register allocator with auto, nullptr and ZoneVector
...
BUG=
Review URL: https://codereview.chromium.org/789083005
Cr-Commit-Position: refs/heads/master@{#25742}
2014-12-10 11:48:33 +00:00
yangguo
7cff32a9bd
Reland "Use same blob format for internal and external snapshots."
...
Review URL: https://codereview.chromium.org/791723004
Cr-Commit-Position: refs/heads/master@{#25741}
2014-12-10 11:46:55 +00:00
titzer
9a823cf612
Reland "[turbofan] Fix control reducer bug with NTLs."
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/789083004
Cr-Commit-Position: refs/heads/master@{#25740}
2014-12-10 11:45:35 +00:00
ulan
d2e54925ca
Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs'
...
BUG=v8:3663
LOG=N
Review URL: https://codereview.chromium.org/792543003
Cr-Commit-Position: refs/heads/master@{#25739}
2014-12-10 10:57:36 +00:00
ulan
3834b78465
Reland 'Do not embed constant functions in StoreTransition stub.'
...
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/787153002
Cr-Commit-Position: refs/heads/master@{#25738}
2014-12-10 10:28:51 +00:00
dcarney
ea11ffc65b
ExecutableAccessorInfo::clear_setter should set a null foreign pointer
...
R=jkummerow@chromium.org
BUG=433458
LOG=N
Review URL: https://codereview.chromium.org/759683004
Cr-Commit-Position: refs/heads/master@{#25737}
2014-12-10 10:18:12 +00:00
dcarney
aae665862f
[turbofan] delay inserting spill slots for parent ranges.
...
R=jarin@chromium.org ,
BUG=
Review URL: https://codereview.chromium.org/785993002
Cr-Commit-Position: refs/heads/master@{#25736}
2014-12-10 09:46:01 +00:00
d
4161b54d58
Add Array.prototype.includes
...
Requires adding a SameValueZero implementation.
LOG=Y
BUG=v8:3575
R=dslomov@chromium.org , arv@chromium.org
TEST=added to test262
Review URL: https://codereview.chromium.org/771863002
Cr-Commit-Position: refs/heads/master@{#25735}
2014-12-10 08:58:15 +00:00
caitpotter88
017eace733
Rename shadowing pos
variable in ParseTemplateLiteral()
...
LOG=N
R=dslomov@chromium.org
BUG=
Review URL: https://codereview.chromium.org/785233005
Cr-Commit-Position: refs/heads/master@{#25734}
2014-12-10 08:57:08 +00:00
dslomov
008405f0b9
Pass --noharmony-scoping to tests validating that we throw on 'const' in strict mode.
...
R=marja@chromium.org
BUG=v8:2198
LOG=N
Review URL: https://codereview.chromium.org/784323002
Cr-Commit-Position: refs/heads/master@{#25733}
2014-12-10 08:55:53 +00:00
dslomov
6751f0439f
Fix messages tests.
...
Change tests so that message location is stable under --debug-code.
R=yangguo@chromium.org
BUG=v8:3744
LOG=N
Review URL: https://codereview.chromium.org/792563003
Cr-Commit-Position: refs/heads/master@{#25732}
2014-12-10 08:54:48 +00:00
Benedikt Meurer
19418d76df
[x64] Fix optimization for certain checked load/stores.
...
BUG=chromium:439743
LOG=y
TEST=mjsunit
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/733893008
Cr-Commit-Position: refs/heads/master@{#25731}
2014-12-10 07:49:12 +00:00
Ben L. Titzer
a068503b45
Revert "[turbofan] Fix control reducer bug with NTLs."
...
This reverts commit aeda76c5cf
.
Reason: exposed other TurboFan bugs.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/785233003
Cr-Commit-Position: refs/heads/master@{#25730}
2014-12-09 16:28:20 +00:00
machenbach
da6dbe78bc
Revert of Use same blob format for internal and external snapshots. (patchset #2 id:20001 of https://codereview.chromium.org/787033002/ )
...
Reason for revert:
[sheriff] breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1293
Original issue's description:
> Use same blob format for internal and external snapshots.
>
> R=vogelheim@chromium.org
TBR=vogelheim@chromium.org ,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/792563002
Cr-Commit-Position: refs/heads/master@{#25729}
2014-12-09 16:19:57 +00:00
yangguo
d9de2aaa17
Revert of Do not embed constant functions in StoreTransition stub. (patchset #3 id:40001 of https://codereview.chromium.org/769733003/ )
...
Reason for revert:
GC stress failure: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress%20-%201/builds/1038
Original issue's description:
> Do not embed constant functions in StoreTransition stub.
>
> BUG=v8:3629
> LOG=N
TBR=ishell@google.com ,ishell@chromium.org,ulan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3629
Review URL: https://codereview.chromium.org/785253002
Cr-Commit-Position: refs/heads/master@{#25728}
2014-12-09 16:09:44 +00:00
yangguo
03ba4becbf
Use same blob format for internal and external snapshots.
...
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/787033002
Cr-Commit-Position: refs/heads/master@{#25727}
2014-12-09 15:12:27 +00:00
ulan
876a1ddd80
Do not embed constant functions in StoreTransition stub.
...
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/769733003
Cr-Commit-Position: refs/heads/master@{#25726}
2014-12-09 15:11:11 +00:00
titzer
aeda76c5cf
[turbofan] Fix control reducer bug with NTLs.
...
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/789773002
Cr-Commit-Position: refs/heads/master@{#25725}
2014-12-09 15:09:59 +00:00
chunyang.dai
56f8ba13d5
Fix a typo error.
...
This error is introduced by baafb8f92e
.
BUG=
Review URL: https://codereview.chromium.org/791543003
Cr-Commit-Position: refs/heads/master@{#25724}
2014-12-09 15:08:55 +00:00
jochen
581747c869
Make it possible to turn on OBJECT_PRINT without DEBUG
...
BUG=none
R=machenbach@chromium.org
LOG=n
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/771323006
Cr-Commit-Position: refs/heads/master@{#25723}
2014-12-09 14:20:16 +00:00
Benedikt Meurer
48a6766e78
[x86] Disable invalid checked load/store optimization.
...
TEST=mjsunit/compiler/regress-lena
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/784153006
Cr-Commit-Position: refs/heads/master@{#25722}
2014-12-09 14:16:34 +00:00
jochen
93f3531051
Really enable DEBUG code on android unless full debug is specified
...
R=machenbach@chromium.rg
LOG=n
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/786203003
Cr-Commit-Position: refs/heads/master@{#25721}
2014-12-09 11:32:36 +00:00
jochen
7216f37ce7
Also ignore NDEBUG for chromium code
...
BUG=none
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/792513002
Cr-Commit-Position: refs/heads/master@{#25720}
2014-12-09 10:57:23 +00:00
jochen
8a7a81141f
Temporarily restore make dependencies
...
We will remove dependencies in about a week again.
BUG=none
R=machenbach@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/733203008
Cr-Commit-Position: refs/heads/master@{#25719}
2014-12-09 10:55:47 +00:00
bmeurer
baafb8f92e
[turbofan] Turn JSToBoolean and JSUnaryNot into pure operators.
...
Also fix the pushing of JSToBoolean into Phis and generalize it to
also include pushing into Selects.
TEST=cctest,unittests
Review URL: https://codereview.chromium.org/792463003
Cr-Commit-Position: refs/heads/master@{#25718}
2014-12-09 07:35:12 +00:00
mstarzinger
8acf387620
Make --no-turbo-types work on all paths through the pipeline.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/785933002
Cr-Commit-Position: refs/heads/master@{#25717}
2014-12-09 04:47:59 +00:00
Dmitry Lomov
90a297a8e0
Ignore tests that fail on nosnap apparently for infa reasons.
...
TBR=arv@chromium.org
BUG=v8:3744
LOG=N
NOTRY=true
Review URL: https://codereview.chromium.org/746743003
Cr-Commit-Position: refs/heads/master@{#25716}
2014-12-08 18:41:39 +00:00
adamk
243764b04b
Optimize add/set/delete operations for string keys in Maps and Sets
...
This was previously landed in commit 8599f5f
, but failed the
collections mjsunit test on ia32 with --deopt-every-n=1. The fixed
patch adds a ClearFlag(HValue::kCanOverflow) call after every
arithmetic operation, which should remove all the deopt points in these
intrinsics.
Ideally, it seems like there should be a way to verify that there are
no deopt points for these inline optimized functions, since there's
nothing to deopt to. But I don't currently know of such a thing.
Review URL: https://codereview.chromium.org/782073002
Cr-Commit-Position: refs/heads/master@{#25715}
2014-12-08 18:03:39 +00:00
dslomov
b4f3250712
Better message location for 'super(...)' restriction error.
...
R=arv@chromium.org
BUG=v8:3330
LOG=N
Review URL: https://codereview.chromium.org/776563002
Cr-Commit-Position: refs/heads/master@{#25714}
2014-12-08 15:55:03 +00:00
chunyang.dai
e980c7e41b
update test case for "Disable neutering on embedded arraybuffers"
...
This test case ( added by git: 4c7effe56e
).
should has different implementation for Turbofan and crankshaft.
BUG=
Review URL: https://codereview.chromium.org/774163005
Cr-Commit-Position: refs/heads/master@{#25713}
2014-12-08 15:14:56 +00:00
dslomov
1954ad8bc1
Do not reflect uninitialized 'let' and 'const' in scope mirrors.
...
R=yangguo@chromium.org ,aandrey@chromium.org
BUG=v8:3743
LOG=N
Review URL: https://codereview.chromium.org/758603004
Cr-Commit-Position: refs/heads/master@{#25712}
2014-12-08 14:59:28 +00:00
Jochen Eisinger
4ba9e967e9
Fix ARM64 build
...
The android toolchain for L now has a proper version (21)
BUG=none
TBR=rossberg@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/777273004
Cr-Commit-Position: refs/heads/master@{#25711}
2014-12-08 13:04:17 +00:00
jochen
779076e006
Update all DEPS to match chromium's DEPS at edb488e
...
Also remove the now disfunctinal 'builddeps' and 'dependencies' targets
BUG=none
R=machenbach@chromium.org ,jkummerow@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/788613002
Cr-Commit-Position: refs/heads/master@{#25710}
2014-12-08 12:27:26 +00:00
mstarzinger
abe5c29077
Silence --trace-turbo a bit and behave graceful in sandbox.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/786763002
Cr-Commit-Position: refs/heads/master@{#25709}
2014-12-08 12:26:22 +00:00
marja
6680fd1591
Handle invalid parser cache gracefully (move invalid cache handling to embedder).
...
Blink already has code for handling invalid cached data. The attached test
ensures that cached data is gracefully rejected if it cannot be used.
This also unifies parser cache and code cache handling.
R=yangguo@chromium.org
BUG=439889
LOG=N
Review URL: https://codereview.chromium.org/781203003
Cr-Commit-Position: refs/heads/master@{#25708}
2014-12-08 11:47:50 +00:00
Benedikt Meurer
a92adc5803
[turbofan] Remove obsolete pure flag.
...
Use the Operator::kPure flag instead, which determines whether the JS
operator has effect/control edges.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/720233006
Cr-Commit-Position: refs/heads/master@{#25707}
2014-12-08 11:25:46 +00:00
ulan
9a60180487
Temporarily skip test-mark-compact/MarkCompactCollector.
...
BUG=v8:3742
LOG=N
Review URL: https://codereview.chromium.org/764783003
Cr-Commit-Position: refs/heads/master@{#25706}
2014-12-08 11:05:56 +00:00
ulan
513d1261e1
Fix typo in r25689 (Refactor Map::ConstructionCount.)
...
BUG=chromium:439868
LOG=N
Review URL: https://codereview.chromium.org/779293003
Cr-Commit-Position: refs/heads/master@{#25705}
2014-12-08 10:46:19 +00:00
dcarney
a26a5440a5
[turbofan] reuse spill slots for phis
...
R=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/777403003
Cr-Commit-Position: refs/heads/master@{#25704}
2014-12-08 10:45:13 +00:00
yangguo
58fe6e732e
Clear cached line ends array when serializing script object.
...
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/790433002
Cr-Commit-Position: refs/heads/master@{#25703}
2014-12-08 10:23:13 +00:00
Jochen Eisinger
7a21cf2f77
Fix compilation with verify heap on in release mode
...
BUG=none
TBR=rossberg@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/788603002
Cr-Commit-Position: refs/heads/master@{#25702}
2014-12-08 09:52:51 +00:00
jochen
97c1f4b15c
Turn on DCHECKs and other debugging code if dcheck_always_on is 1
...
When compiling with the macro DCHECK_ALWAYS_ON defined, DCHECKs and
supporting code gets compiled and enabled.
This increases test coverage for chromium release buildbots
BUG=v8:3731
R=jkummerow@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/760213005
Cr-Commit-Position: refs/heads/master@{#25701}
2014-12-08 09:26:16 +00:00
machenbach
46762966c4
Correct clean up in android perf runner.
...
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
NOTRY=true
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/776223003
Cr-Commit-Position: refs/heads/master@{#25700}
2014-12-08 09:10:48 +00:00
Benedikt Meurer
11b52971d9
Make cpplint happy.
...
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/783913003
Cr-Commit-Position: refs/heads/master@{#25699}
2014-12-08 08:53:20 +00:00
Benedikt Meurer
1a05ece305
[turbofan] Improve typing of JSToNumber.
...
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/786703002
Cr-Commit-Position: refs/heads/master@{#25698}
2014-12-08 08:28:25 +00:00
adamk
75dbd0d352
Add myself to OWNERS
...
Review URL: https://codereview.chromium.org/780323002
Cr-Commit-Position: refs/heads/master@{#25697}
2014-12-08 05:46:46 +00:00
adamk
1988251044
Revert of Optimize add/set/delete operations for string keys in Maps and Sets (patchset #1 id:1 of https://codereview.chromium.org/777663003/ )
...
Reason for revert:
Deopt fuzzer reports that something's still broken, reverting until
I can create a minimal repro.
Original issue's description:
> Optimize add/set/delete operations for string keys in Maps and Sets
>
> This was previously landed in commit 66e2f60
, but failed the
> collections mjsunit test with --deopt-every-n=1 due to a typo
> in the shrinking code. This patch corrects and simplifies the
> shrinking logic, and the tests now pass.
>
> R=dslomov@chromium.org
>
> Committed: 8599f5f047
TBR=dslomov@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/742353006
Cr-Commit-Position: refs/heads/master@{#25696}
2014-12-05 22:25:11 +00:00