epertoso
c78c499a64
Disables readability/fn_sizes for v8.
...
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2231083002
Cr-Commit-Position: refs/heads/master@{#38546}
2016-08-10 15:15:21 +00:00
mstarzinger
9d3e055212
[presubmit] Disable linter check for alpha-sorted includes.
...
The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.
Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1822003002
Cr-Commit-Position: refs/heads/master@{#34985}
2016-03-22 12:27:12 +00:00
titzer
28d3cba243
[formatting] Remove the formatting requirement for 2 empty lines between declarations.
...
R=mstarzinger@chromium.org ,rossberg@chromium.org,bmeurer@chromium.org,hpayer@chromium.org,jochen@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1600873002
Cr-Commit-Position: refs/heads/master@{#33485}
2016-01-25 09:50:17 +00:00
mstarzinger
cdafea2011
[presubmit] Enable readability/nolint linter checking.
...
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1506233008
Cr-Commit-Position: refs/heads/master@{#32745}
2015-12-10 10:41:47 +00:00
jkummerow
f7a0ecb0ca
[test+presubmit] Remove duplicate test status file entries
...
And add a presubmit check to guard against future duplicates.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1477403002
Cr-Commit-Position: refs/heads/master@{#32380}
2015-11-27 15:04:49 +00:00
machenbach
e8bfedab96
[test] Add status-file presubmit check.
...
This loads all test suites and status files to catch subtle
syntax errors. It also checks basic status file integrity
and common mistakes.
NOTRY=true
Review URL: https://codereview.chromium.org/1475663002
Cr-Commit-Position: refs/heads/master@{#32271}
2015-11-25 13:19:33 +00:00
ishell
7d7eee513a
[presubmit] Enabling readability/inheritance linter checking.
...
Review URL: https://codereview.chromium.org/1412223018
Cr-Commit-Position: refs/heads/master@{#31785}
2015-11-04 13:08:42 +00:00
mstarzinger
6a769ac1df
[presubmit] Enable readability/namespace linter checking.
...
This enables linter checking for "readability/namespace" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1371083003
Cr-Commit-Position: refs/heads/master@{#31019}
2015-09-30 13:47:11 +00:00
mstarzinger
6a20034d24
[presubmit] Fix whitespace/semicolon linter violations.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1365803004
Cr-Commit-Position: refs/heads/master@{#30963}
2015-09-28 08:18:49 +00:00
mstarzinger
6ec34c7cb3
[presubmit] Enable runtime/threadsafe_fn linter checking.
...
This enables linter checking for "runtime/threadsafe_fn" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1369673003
Cr-Commit-Position: refs/heads/master@{#30933}
2015-09-25 11:32:48 +00:00
mstarzinger
3a204ea97e
[presubmit] Enable build/c++11 linter checking.
...
This enables the general linter checking for "build/c++11" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1317463007
Cr-Commit-Position: refs/heads/master@{#30621}
2015-09-07 14:24:18 +00:00
mstarzinger
92e85aed10
[presubmit] Fix build/include linter violations.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1318863004
Cr-Commit-Position: refs/heads/master@{#30554}
2015-09-03 07:56:14 +00:00
mstarzinger
f9255550eb
[presubmit] Fix whitespace/empty_loop_body linter violations.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1327523003
Cr-Commit-Position: refs/heads/master@{#30553}
2015-09-03 07:15:17 +00:00
mstarzinger
093f7260e9
[presubmit] Fix runtime/indentation_namespace linter violations.
...
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1302413007
Cr-Commit-Position: refs/heads/master@{#30514}
2015-09-01 15:20:09 +00:00
mstarzinger
77e40bc5f3
Make presubmit.py rules differential.
...
This turns the absolute list of linter rules within the presubmit.py
wrapper into a list relative to the default of the cpplint.py script.
This has the advantage that new rules are picked up when the script is
updated and that allowed violations are visible from the list.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1325833005
Cr-Commit-Position: refs/heads/master@{#30513}
2015-09-01 14:28:31 +00:00
yangguo
6bef1d0a13
Remove builtin/runtime name clash presubmit check.
...
It has become obsolete since we do the name lookup at compile time.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1319893004
Cr-Commit-Position: refs/heads/master@{#30405}
2015-08-27 11:14:09 +00:00
oth
cff8c9b933
Ensure mjsunit tests use dashes not underscores in flags directives.
...
BUG=chromium:505228
LOG=Y
Review URL: https://codereview.chromium.org/1219723002
Cr-Commit-Position: refs/heads/master@{#29355}
2015-06-29 17:08:18 +00:00
Benedikt Meurer
556221a23e
[mjsunit] Import asm.js test case for poppler.
...
R=hablich@chromium.org
Review URL: https://codereview.chromium.org/1105483002
Cr-Commit-Position: refs/heads/master@{#27996}
2015-04-22 09:33:43 +00:00
Benedikt Meurer
78f2efe0e4
[mjsunit] Add custom tests based on SQLite 3.8.9.
...
Also adjust the test runner to remove --always-opt for FAST_VARIANTS.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1056423004
Cr-Commit-Position: refs/heads/master@{#27989}
2015-04-22 07:44:50 +00:00
Benedikt Meurer
f68e24ad46
Revert "[test] Initial import of an emscripten test suite."
...
This reverts commit bb346227db
because it
adds a lot of overhead without significantly increasing our test
coverage. We need a different approach to deal with this.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1099813007
Cr-Commit-Position: refs/heads/master@{#27987}
2015-04-22 04:31:56 +00:00
Benedikt Meurer
bb346227db
[test] Initial import of an emscripten test suite.
...
These tests are based on individual tests from the Emscripten benchmark
suite, which are used to test Emscripten itself. We adopt them to test
asm.js code paths in V8.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1101493002
Cr-Commit-Position: refs/heads/master@{#27962}
2015-04-21 12:24:10 +00:00
Benedikt Meurer
7eb7141fc4
[mjsunit] Import test case based on the Massive/SQLite benchmark.
...
This adds a stripped down version of the SQLite benchmark (running with
--size 1) to the mjsunit suite. We might want to move that to a
dedicated slow/stress/whatever test suite once an appropriate decision
is made.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1094043002
Cr-Commit-Position: refs/heads/master@{#27930}
2015-04-20 07:58:31 +00:00
marja
770d866823
Check author of a CL against the AUTHORS file.
...
The code is copied from Chromium presubmit.
BUG=
Review URL: https://codereview.chromium.org/837503003
Cr-Commit-Position: refs/heads/master@{#26077}
2015-01-15 13:10:09 +00:00
bmeurer@chromium.org
24d288cb8a
Fix copyright headers.
...
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/720793002
Cr-Commit-Position: refs/heads/master@{#25295}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25295 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-11-12 13:29:57 +00:00
bmeurer@chromium.org
bfd37ab267
Move unit tests to test/unittests.
...
As per discussion on the V8 team, this is the place we want them to live,
not following the Chrome Style Guide for this.
BUG=v8:3489
LOG=y
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/615393002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24350 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-01 08:34:25 +00:00
jkummerow@chromium.org
5cc34b6b52
Delete generated runtime tests
...
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/548383002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-09 12:24:43 +00:00
bmeurer@chromium.org
b22724966b
[turbofan] Merge compiler unit tests into src.
...
BUG=v8:3489
LOG=n
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/530693002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-01 10:26:12 +00:00
bmeurer@chromium.org
58a5d15ba7
Merge heap unit tests into src.
...
Also rip out the unused runtime-unittests; will be added back on-demand.
BUG=v8:3489
LOG=n
R=ulan@chromium.org , svenpanne@chromium.org
Review URL: https://codereview.chromium.org/525193004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23545 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-01 09:12:50 +00:00
bmeurer@chromium.org
4edcff907f
Refactor libplatform unit tests to use GTest/GMock.
...
Also migrate them to src.
BUG=v8:3489
LOG=n
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/526043002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23541 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-01 07:13:55 +00:00
bmeurer@chromium.org
bcef1fa497
Add missing test directories to presubmit.py.
...
R=machenbach@chromium.org
BUG=v8:3489
LOG=n
Review URL: https://codereview.chromium.org/479503004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23294 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-22 07:54:41 +00:00
machenbach@chromium.org
943960dfd1
Skip gmock and gtest in presubmit.
...
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/454693004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23044 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-11 14:07:08 +00:00
bmeurer@chromium.org
12e8b34b07
Reland "Add initial support for compiler unit tests using GTest/GMock.".
...
LOG=y
BUG=v8:3489
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/457503002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22987 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-08 07:04:07 +00:00
bmeurer@chromium.org
38ca3f4fc2
Revert "Add initial support for compiler unit tests using GTest/GMock."
...
This reverts commit r22927 for breaking build.
TBR=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/448663002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22928 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-06 12:59:02 +00:00
bmeurer@chromium.org
1f1e9495e5
Add initial support for compiler unit tests using GTest/GMock.
...
TEST=compiler-unittests
BUG=v8:3489
LOG=y
R=svenpanne@chromium.org , jochen@chromium.org
Review URL: https://codereview.chromium.org/447563003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22927 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-06 12:52:47 +00:00
bmeurer@chromium.org
ef17fe7633
Refactor unit tests for the base library to use GTest.
...
TEST=base-unittests
BUG=v8:3489
LOG=y
R=jochen@chromium.org , svenpanne@chromium.org
Review URL: https://codereview.chromium.org/448603002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-06 09:35:21 +00:00
yangguo@chromium.org
0fb57e51d4
Check that external references are registered in the serializer.
...
Inspired by a patch by Slava Chigrin <vchigrin@yandex-team.ru>
R=jkummerow@chromium.org , vchigrin@yandex-team.ru
Review URL: https://codereview.chromium.org/441983002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22896 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-06 07:20:14 +00:00
bmeurer@chromium.org
ecec301571
Revert "Initial import of unittests using GTest/GMock."
...
This reverts commit r22847 and r22848. Isolate initialization/shutdown
still broken (so certain debug builds just crash), and our compiler flags
do not work with other Google projects (i.e. GTest/GMock).
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/438243003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22855 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-05 10:16:47 +00:00
jochen@chromium.org
c608c2f0be
Move a bunch of GC related files to heap/ subdirectory
...
BUG=none
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/437993003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-05 08:18:22 +00:00
bmeurer@chromium.org
62ac0d1050
Initial import of unittests using GTest/GMock.
...
R=jochen@chromium.org , svenpanne@chromium.org
Review URL: https://codereview.chromium.org/439863004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-05 08:07:25 +00:00
bmeurer@chromium.org
d07a2eb806
Rename ASSERT* to DCHECK*.
...
This way we don't clash with the ASSERT* macros
defined by GoogleTest, and we are one step closer
to being able to replace our homegrown base/ with
base/ from Chrome.
R=jochen@chromium.org , svenpanne@chromium.org
Review URL: https://codereview.chromium.org/430503007
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-04 11:34:54 +00:00
mstarzinger@chromium.org
fec6e62dfb
Check alpha-sorting of includes during presubmit.
...
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/333013002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-20 08:40:11 +00:00
ishell@chromium.org
55443af648
Fixed lint errors caused by "runtime/references" rule (Is this a non-const reference?) and the rule itself is restored.
...
BUG=v8:3326
LOG=N
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/314723002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-03 15:45:38 +00:00
jochen@chromium.org
368262fc76
Ignore buildtools directory in presubmit.py checks
...
BUG=none
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/314573004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-03 13:38:35 +00:00
jkummerow@chromium.org
43c170eb44
Move check for existence of generated tests from run-tests.py to presubmit.py
...
Inspired by https://codereview.chromium.org/275143002#msg3
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/290023002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21341 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-16 13:18:13 +00:00
ishell@chromium.org
ff2d004f85
Presubmit checks recover:
...
1) runtime/references checks temporarily disabled (56 items left)
2) other errors fixed
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/277913002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-09 12:59:24 +00:00
jochen@chromium.org
f4994ae876
Don't bail out of the cpplint cache is broken.
...
Instead, try to remove it.
BUG=none
R=ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/117823013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-02 15:06:27 +00:00
yangguo@chromium.org
aa3518a0f3
Make sure files end with exactly one new line and police this in presubmit.
...
The changes are (excluding presubmit.py) mechanical. I added the following
lines after the check and iterated the presubmit script until all errors
went away:
f = open(name, "w");
if contents.endswith('\n\n'):
f.write(contents[0:-1])
else:
f.write(contents + '\n')
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/82803005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-11-22 13:50:39 +00:00
yangguo@chromium.org
de432db19a
Exclude benchmark tests from presubmit check in a non-git checkout.
...
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/83353002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18006 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-11-22 12:21:43 +00:00
yangguo@chromium.org
7dd2d6c590
Reland "Make Array.prototype.pop throw if the last element is not configurable."
...
This relands r17346.
R=machenbach@chromium.org
BUG=311164
Review URL: https://codereview.chromium.org/43923002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-25 11:55:56 +00:00
yangguo@chromium.org
0f564cb1b0
Revert "Make Array.prototype.pop throw if the last element is not configurable."
...
This reverts commit r17346.
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/39593002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17360 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-24 07:48:23 +00:00