AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
4,534 Commits 1 Branch 0 Tags 839 MiB
455cfe5932
Commit Graph

3871 Commits

Author SHA1 Message Date
antonm@chromium.org
7c238db829 Do not shortcut union of keys if lhs is empty. 
The problem is other array may have holes, for example
when fixed array comes from JSArray (in case of named interceptor).

If that would prove to be a performance problem, we could
pass an additional argument into UnionOfKeys to hold actual length.

Review URL: http://codereview.chromium.org/3595013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5591 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-05 13:10:43 +00:00
vitalyr@chromium.org
91b9a92336 Addressing Mads' comments from http://codereview.chromium.org/3585010/show. 
Review URL: http://codereview.chromium.org/3613009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5588 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-05 11:51:41 +00:00
yurys@chromium.org
a3e66d2df4 Fix lint errors 
TBR=mnaganov
Review URL: http://codereview.chromium.org/3525014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5587 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-05 09:07:17 +00:00
yurys@chromium.org
eb24a86e1b StackTrace should provide access to //@ sourceURL=... value 
Review URL: http://codereview.chromium.org/3602013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5586 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-05 08:53:51 +00:00
vitalyr@chromium.org
d498613c9a Make lint happy. 
TBR=kmillikin@chromium.org

Review URL: http://codereview.chromium.org/3609008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-04 15:21:38 +00:00
vitalyr@chromium.org
b999ae3cbd API: expose RegExp. 
Review URL: http://codereview.chromium.org/3585010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-04 15:04:16 +00:00
kmillikin@chromium.org
ea910460bd More refactoring of class Compiler's interface. 
Change more functions used by the Compiler class to have a uniform
interface: they get passed as argument an input/output pointer to a
CompilationInfo that they mutate if they succeed, and they return a
flag telling whether they succeeded.

Also, remove some unnecessary timers.

Review URL: http://codereview.chromium.org/3561012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5583 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-04 14:30:43 +00:00
mikhail.naganov@gmail.com
2f54abf974 Previously, there was a bug there, fixed in r5581. But having an assert still makes sense. 
Also, add functions registration to CPU profiler in case
when closure code wasn't compiled yet.

Review URL: http://codereview.chromium.org/3557007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5582 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-04 12:54:31 +00:00
kmillikin@chromium.org
bef3ae07db Begin a more aggressive refactoring of the Compiler interface. 
The plan is to use the CompilationInfo class to communicate inputs and
outputs to compilation pipeline phases, which each return a boolean
success/failure flag.

The intent is to make it easier to compose small pieces of the
pipeline without having to grow a custom function each time, each
taking a half dozen arguments.

This change modifies the very front end (the parser).

Review URL: http://codereview.chromium.org/3586006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5581 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-04 11:35:46 +00:00
ricow@chromium.org
26163835a7 Prepare push to trunk. Now working on version 2.4.9. 
Review URL: http://codereview.chromium.org/3538009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-04 07:57:07 +00:00
kmillikin@chromium.org
5d1dac259a Fix a pair of compilation failure bugs in test files due to r5576. 
1. parser.h depends on ast.h, but only gets it included implicitly
   everywhere parser.h is included (except for tests).  Include ast.h in
   parser.h.

2. Regular expression tests test the free functions that have just been
   moved into class Parser.

TBR=fschneider@chromium.org

Review URL: http://codereview.chromium.org/3602007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5577 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 15:32:32 +00:00
kmillikin@chromium.org
d0fcd24c03 Make some free functions into static members of class Parser. 
Review URL: http://codereview.chromium.org/3518005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 14:10:47 +00:00
kaznacheev@chromium.org
f1d057dfec Fix property array length calculation in TransformPropertiesToFastFor. 
It was silently assumed that inobject_properties value is not too large.
Recent introduction of inobject slack tracking made the assumption false
and debug tests with no snapshot failed.

Review URL: http://codereview.chromium.org/3584004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5575 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 12:40:30 +00:00
sgjesse@chromium.org
a11fb492fa Rename include guard to match file name 
Review URL: http://codereview.chromium.org/3532006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5574 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 09:30:42 +00:00
lrn@chromium.org
a556a16f0f Fix bad cast in string-search.h. 
Review URL: http://codereview.chromium.org/3530004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5572 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 09:08:52 +00:00
kaznacheev@chromium.org
1156bbc82a Fine-tune inobject slack tracking. 
The current parameters (initial slack = 6, kGenerousAllocationsCount = 16)
caused 15-20% performance regression on 3d-raytrace on x64 
(visible both in standalone shell and in the web harness). This is very
likely some kind of an alignment  problem (it goes away completely with --prof).
A similar problem can be observed on ia32 with initial slack=2.

Increased initial slack to 8 and decreased constructions count to 8. 
This made the regression go away (and did not harm any of the other tests).

Review URL: http://codereview.chromium.org/3595002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5571 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 08:28:28 +00:00
mikhail.naganov@gmail.com
5a30072502 Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced 
during snapshot size optimization.

Sorry, now I figured out that the diff implementation itself was also
incorrect.  Reachable nodes must be filtered from the beginning,
otherwise, an object that is already disconnected, but not discarded
yet, will not appear as a deleted (thankfully, this bug for some
reason had appeared on the x64 port.)

BUG=868
TEST=HeapSnapshotRootPreservedAfterSorting

Review URL: http://codereview.chromium.org/3531005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5570 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-10-01 07:19:23 +00:00
vitalyr@chromium.org
7228d867cb Use existing global cell status as a hint when generating loads. 
Review URL: http://codereview.chromium.org/3537003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 17:39:31 +00:00
mikhail.naganov@gmail.com
44050b12b9 Revert last commit due to check fail on Linux. 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5568 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 12:35:03 +00:00
mikhail.naganov@gmail.com
99c276bbbc Fix HeapSnapshotsDiff test and a bug introduced during snapshot size optimization. 
The bug wasn't revealed because the test was disabled.

BUG=848
TEST=HeapSnapshotsDiff,HeapSnapshotRootPreservedAfterSorting

Review URL: http://codereview.chromium.org/3572003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5567 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 12:24:56 +00:00
antonm@chromium.org
f8b274eea8 Rename some x64 macros to be more precise about their semantics. 
Review URL: http://codereview.chromium.org/3574002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5566 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 11:48:03 +00:00
mikhail.naganov@gmail.com
4e961fdd36 Add fflush after writing to log (Issue 868). 
BUG=868

Review URL: http://codereview.chromium.org/3605001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 10:50:39 +00:00
kmillikin@chromium.org
9190e5f941 Prepare push to trunk. Now working on version 2.4.8. 
Review URL: http://codereview.chromium.org/3585003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5562 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 09:35:50 +00:00
kmillikin@chromium.org
c019508bad Cleanup of the parser. 
The lazy parsing functions took a host of arguments that can all be
derived from the SharedFunctionInfo, and the SharedFunctionInfo is
always available when parsing lazily.  Change the interface to take a
single CompilationInfo or SharedFunctionInfo argument.

Also remove a flag in the parser that was always false when it was read.

Review URL: http://codereview.chromium.org/3538005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5561 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 09:28:58 +00:00
kmillikin@chromium.org
f21b34ef0f Introduce subclasses of class CompilationInfo. 
It was a wart that we had three handle fields, exactly one of which
was non-null; and that we had three overloaded constructors.  Instead,
introduce subclasses and virtual methods.

Remove some unused fields from class CompilationInfo.

Review URL: http://codereview.chromium.org/3566003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5560 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 08:48:37 +00:00
erik.corry@gmail.com
d46fb9d454 New attempt to make the allocation routines 64 bit clean. 
This one has been approved by the 64 bit compiler in MSVC
2005 so I hope it also passes the 2008 version.

The --max-new-space-size option is now in kBytes.
The --max-old-space-size option is now in MBytes.

Some issues remain with 64 bit heaps and the counters.  See
http://code.google.com/p/v8/issues/detail?id=887
Review URL: http://codereview.chromium.org/3573005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5559 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-30 07:22:53 +00:00
antonm@chromium.org
9e618ff460 Add another check to be sure non-negative smi fits into Uint32 range. 
Review URL: http://codereview.chromium.org/3546003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 18:15:36 +00:00
kmillikin@chromium.org
4d04e9d5d4 Remove some unused fields from class CompilationInfo. 
Review URL: http://codereview.chromium.org/3533007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5557 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 17:38:37 +00:00
antonm@chromium.org
3567207741 Do not invoke indexed interceptor getters for negative indices. 
BUG=https://bugs.webkit.org/show_bug.cgi?id=46689

Review URL: http://codereview.chromium.org/3520006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5553 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 15:08:38 +00:00
erik.corry@gmail.com
ef135e5351 Add cast to make Win-64 compile without warnings. This is a commit of http://codereview.chromium.org/3521002 for lrn. 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5552 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 14:06:30 +00:00
lrn@chromium.org
3614edebea Added missing file. Mea culpa. 
Review URL: http://codereview.chromium.org/3586001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 12:12:45 +00:00
lrn@chromium.org
2c85faf1ae Refactored string search code. 
Made string search state explicit for repreated calls (a StringSearch class).

Review URL: http://codereview.chromium.org/3467010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5550 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 10:57:23 +00:00
kmillikin@chromium.org
d9d49052f9 Add an AST node type enum to AST nodes. 
When inspecting an AST node in the debugger, it can be difficult to
find its concrete type.  Add a "node_type" virtual function to all the
concrete AST nodes.

Use a macro to generate the definition of node_type as well as Accept
and the AsXXX type testing/casting functions.

Review URL: http://codereview.chromium.org/3431026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5549 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-29 07:51:47 +00:00
vitalyr@chromium.org
e0feeec039 Mark ptest instruction as requiring SSE4.1. 
I also added a flag like the ones we have for other SSE versions.

Review URL: http://codereview.chromium.org/3505003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5548 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 14:56:36 +00:00
vitalyr@chromium.org
9aa65c29dc Fix external array iteration used in array concat. 
We should use Factory and not Heap there.

Review URL: http://codereview.chromium.org/3380031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5547 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 14:49:29 +00:00
erik.corry@gmail.com
2d0c23bc82 Revert attempt to make heap size 32/64 clean. This change needs to 
be done from Windows where the compiler is stricter about truncating
changes.
Review URL: http://codereview.chromium.org/3454035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5545 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 12:49:25 +00:00
erik.corry@gmail.com
d6313dbbb7 More changes to 32/64 bit correctness. 
TBR=vegorov
Review URL: http://codereview.chromium.org/3412038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 12:18:19 +00:00
erik.corry@gmail.com
28d7064856 More correctness around PrintF and 32/64 bit values. 
Fix test after 64 bit heap size change.
Review URL: http://codereview.chromium.org/3432032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5543 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 11:44:30 +00:00
erik.corry@gmail.com
f1635606df Use intptr_t instead of int for heap sizes. This is a step towards 
removing the 1Gbyte limit.
Review URL: http://codereview.chromium.org/3418035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5542 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 10:35:47 +00:00
lrn@chromium.org
8f7bfea235 Avoid logging preparse-data inside lazily compiled functions. 
Reduces size of preparser data significantly when there are nested functions.
Also allows us to drop the "skip" fields of function entries,
that tells us how much preparse-data to skip when skipping the function source.

Review URL: http://codereview.chromium.org/3412034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5541 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-28 07:50:32 +00:00
vitalyr@chromium.org
1982f9d257 Custom call IC for Math.abs. 
Review URL: http://codereview.chromium.org/3446024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-27 23:41:41 +00:00
podivilov@chromium.org
0012576e2b Add Debug::CancelDebugBreak method to api 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-27 15:09:55 +00:00
whesse@chromium.org
9c31eb8229 Prepare push of version 2.4.6 to trunk. Now working on version 2.4.7. 
Review URL: http://codereview.chromium.org/3470016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5531 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-27 10:58:18 +00:00
vegorov@chromium.org
9045e2e60f Fix more GC unsafe places 
Review URL: http://codereview.chromium.org/3499001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-27 10:29:25 +00:00
whesse@chromium.org
25f31f13fa Fix error in x64 inlined optimized shift operators. 
Review URL: http://codereview.chromium.org/3496007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5529 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-27 07:24:01 +00:00
dimich@chromium.org
589eb4a861 Add CODE_POINTER_ALIGN, use it in Page to align generated code. 
The object's space in Page starts after Page header and is aligned to kMapAlignment which is 32 bytes on 32-bit and 8 bytes on 64-bit.

In case of 64-bit target, the current page header size is exactly 32 bytes so we get the code magically aligned at 32 bytes but it is better to have a separate CODE_POINTER_ALIGN macro to make sure the object space in Page is aligned properly for both maps and code.

There could be a small waste of bytes sometimes (since both Page header and Code header sizes are aligned separately) but it seems the optimal one would involve cross-dependencies between .h files and not clear if it's worth it.

This is a back-port from Isolates branch.

Review URL: http://codereview.chromium.org/3461021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 21:48:44 +00:00
kaznacheev@chromium.org
c39194e06f Implemented missing instructions in ia32 and x64 disassembler. 
ia32: fld(i), fldpi
x64: fld(i), fldpi, cvtsd2si, cvttsd2si

Review URL: http://codereview.chromium.org/3471011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5525 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 12:55:17 +00:00
mikhail.naganov@gmail.com
0a539dc181 Fix presubmit error. 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5524 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 11:50:50 +00:00
mikhail.naganov@gmail.com
8f22667805 Provide more functions to CPU profiler (fix issue 858). 
The cause for missing functions is that some of them are created
from compiled code (see FastNewClosureStub), and thus not get
registered in profiler's code map.

My solution is to hook on GC visitor to provide JS functions
addresses to profiler, only if it is enabled.

BUG=858
TEST=

Review URL: http://codereview.chromium.org/3417019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5523 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 11:45:12 +00:00
erik.corry@gmail.com
a26a9b74ab Revert 5520 due to compilation failure. 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5521 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 09:35:19 +00:00
erik.corry@gmail.com
68ef41af29 Small tweaks to make the x64 full code generator generate 
more compact code.
Review URL: http://codereview.chromium.org/3443022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 08:34:52 +00:00
kmillikin@chromium.org
9c503a8330 Fix some inconsistent formatting. 
I noticed we sometimes had extra spaces before and after the "const"
keyword.  Probably the result of a search and replace gone wrong.

This is a whitespace only change.

Review URL: http://codereview.chromium.org/3427021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5519 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 08:25:31 +00:00
kaznacheev@chromium.org
cfbc1eed9c Prevent modification of cached normalized maps. 
Finally sovles the problem that r5342 attempted to solve.
When adding a stub to a map's code cache we need to make
sure that this map is not used by object that do not need
this stub.

Existing solution had 2 flaws:
1. It checked that the map is cached by asking the current context.
If the object escaped into another context then NormalizedMapCache::Contains
returns false negative.

2. If a map gets evicted from the cache we should not try to modify it
even though Contains returns false.

This patch implements much less fragile solution of the same problem:
A map now has a flag (is_shared) that is set once the map is added
to a cache, stays set even after the cache eviction, and is cleared
if the object goes back to fast mode.

Added a regression test.

Review URL: http://codereview.chromium.org/3472006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5518 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 08:18:33 +00:00
kmillikin@chromium.org
830185b175 Clean up some messiness in Scopes. 
For some reason, the scope's arguments and arguments shadow were
variable proxies, which resulted in all references to the arguments
shadow being shared in the AST.  This makes it hard to put per-node
state on the AST nodes.

I took the opportunity to remove Variable::AsVariable which has
confused people in the past, and to rename Variable::slot to the more
accurate Variable::AsSlot.

Review URL: http://codereview.chromium.org/3432022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5517 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-24 07:53:59 +00:00
kaznacheev@chromium.org
5e572e4622 Support dec_b instruction in ia32 and x64 disassembler. 
Review URL: http://codereview.chromium.org/3412028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5515 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 19:01:56 +00:00
vitalyr@chromium.org
740aba98fb Add an assert to ensure we never allocate second empty fixed array. 
Review URL: http://codereview.chromium.org/3442012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5514 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 12:49:59 +00:00
vitalyr@chromium.org
48fd3dcaf9 Fix copy-on-write assert by setting the new array map early. 
BUG=876

Review URL: http://codereview.chromium.org/3466013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 12:23:35 +00:00
vegorov@chromium.org
622351fedd Fix getOwnPropertyDescriptor() support for index properties. 
Add support for index properties with getters, setters or indexed interceptors.

For indexed interceptor case only fix crashes, do not guarantee any semantic soundness. Separate issue opened for this http://code.google.com/p/v8/issues/detail?id=877

BUG=http://code.google.com/p/v8/issues/detail?id=874

Review URL: http://codereview.chromium.org/3462005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5512 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 11:25:01 +00:00
erik.corry@gmail.com
94cf27373c Cleanup of contexts in the full code generator. 
Review URL: http://codereview.chromium.org/3449004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 09:22:45 +00:00
kaznacheev@chromium.org
06c867404b Dynamically determine optimal instance size. 
The number of inobject properties used to be derived from the number
of this property assignments in the constructor (and increased by 2 to
allow for properties added later). This very often leads to wasted inobject 
slots.

This patch reclaims some of the unused inobject space by the following method:
 - for each constructor function the first several objects are allocated using the initial 
   ("generous) instance size estimation (this is called 'tracking phase').
 - during the tracking phase map transitions are tracked and actual property counts are collected.
 - at the end of the tracking phase instance sizes in the maps are decreased if necessary
   (starting with the function's initial map and traversing the transition tree).
 - all further allocation use more realistic instance size estimation.

Shrinking generously allocated objects without costly heap traversal is made possible 
by initializing their inobject properties with one_pointer_filler_map (instead of undefined). 

The initial slack for the generous allocation is increased from 2 to 6 which really helps some tests.

Review URL: http://codereview.chromium.org/3329019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5510 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 09:15:26 +00:00
vegorov@chromium.org
7c8bb52737 Fix possible evaluation order problems. 
We should not allow handle dereference and GC inside the same expression because order of subexpression evalution are not defined.

Review URL: http://codereview.chromium.org/3398014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5509 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 08:27:51 +00:00
kaznacheev@chromium.org
e69278a70c Unuse labels when bailing out of StubCompiler methods. 
There are 3 methods where early return happen before the 
miss label is bound. This is harmless in Release mode, 
in Debug an assertion fails.

Review URL: http://codereview.chromium.org/3405022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5508 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-23 08:06:19 +00:00
lrn@chromium.org
0dece535d9 RegExp: Fix caching to correctly set lastIndex. 
BUG: 52801

Review URL: http://codereview.chromium.org/3389022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5504 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-22 11:22:57 +00:00
fschneider@chromium.org
22eb9af355 Prepare push to trunk. Now working on version 2.4.6. 
Review URL: http://codereview.chromium.org/3466009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5501 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-22 09:35:56 +00:00
vitalyr@chromium.org
d80c627875 Try fix win64 build. 
TBR=erik.corry

Review URL: http://codereview.chromium.org/3446015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5500 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-21 13:04:42 +00:00
vitalyr@chromium.org
a6bbe9820e Custom call IC for Math.floor. 
Review URL: http://codereview.chromium.org/3327022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5499 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-21 12:54:12 +00:00
yurys@chromium.org
b2f444f6e6 Use //@ sourceURL when formatting stack trace 
BUG=672
Review URL: http://codereview.chromium.org/3444011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5498 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-20 15:55:28 +00:00
vitalyr@chromium.org
ceb9d79d73 Generate inline code for contextual loads. 
Contextual load requires only a map check followed by a cell hole
check so we can generate pretty compact code for that. The fact that
we have inlined code is marked by mov ecx, offset instruction after
the IC call. Inlining is only enabled inside loops and in non-builtin
functions.

The generated code size increase is about 3%. This descreased the
pc-to-code cache hit rate in some of the benchmarks that trigger
GC. To compensate we now have 4 times as much entries in the cache.

Review URL: http://codereview.chromium.org/3402014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5497 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-20 13:50:27 +00:00
floitschV8@gmail.com
8fdf96727f Fix build-breakage on Mac. Initial variable eventhough it is initialized in all reachable branches. 
Review URL: http://codereview.chromium.org/3471001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-20 10:58:41 +00:00
mikhail.naganov@gmail.com
c1903ce332 Show RegExp calls in the profile. 
It turns out they were filtered out. But when I unfiltered them, I
discovered another issue: when DevTools run, regexp literals get
recompiled each time they called (looks like this is concerned with
switching to full compiler), so I ended up having multiple entries for
the same regexp. To fix this, I changed the way of how code entries
equivalence is considered.

BUG=crbug/55999
TEST=cctest/test-profile-generator/ProfileNodeFindOrAddChildForSameFunction
(the test isn't for the whole issue, but rather for equivalence testing)

Review URL: http://codereview.chromium.org/3426008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-20 09:29:12 +00:00
floitschV8@gmail.com
fc9915b770 Added precision mode to fast-dtoa. 
Review URL: http://codereview.chromium.org/2000004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-20 09:18:00 +00:00
lrn@chromium.org
a98baf9666 Remove unused variable from Scanner class. 
BUG=None
TEST=compiles

Patch from Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3413015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-20 08:43:35 +00:00
lrn@chromium.org
81b0236d76 Make preparsing data reusable. 
Fix bug in writing symbol ids over 128.

Review URL: http://codereview.chromium.org/3416010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5485 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-17 12:55:27 +00:00
fschneider@chromium.org
78f550c6fd Add missing x87 instructions fisttp and fst to the disassembler. 
Review URL: http://codereview.chromium.org/3408011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-17 12:08:50 +00:00
vitalyr@chromium.org
c6c55a69a9 Fix direct loading of global function prototypes: 
We must also check the current context has not changed.

The bug reported by Florian.

Review URL: http://codereview.chromium.org/3410014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-17 09:56:47 +00:00
lrn@chromium.org
3b8235b306 Make some runtime arguments checks be RUNTIME_ASSERT, not ASSERT. 
Review URL: http://codereview.chromium.org/3411013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-17 08:34:53 +00:00
peter.rybin@gmail.com
41064a57c3 Add breakOnCaughtException and breakOnUncaughtException flags 
Review URL: http://codereview.chromium.org/3275011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5480 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 21:40:42 +00:00
kaznacheev@chromium.org
eef3bd7c04 Prevent inline constructor generation when duplicate properties are present in the constructor. 
Currenly the constructor like this:
function f() {
  this.a = 0;
  this.a = 1;
  this.a = 2;
}
creates a map with duplicate desciptors which is bad in many ways.


Review URL: http://codereview.chromium.org/3434004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5476 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 10:55:37 +00:00
fschneider@chromium.org
e91a352d02 Fix a regression in character-at stub when doing a keyed load on a string. 
Loading from out-of-range has to go to the runtime system to check if there
exists a property with that index in the prototype.

Review URL: http://codereview.chromium.org/3410011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 09:18:08 +00:00
kasperl@chromium.org
b2306a41d0 Clean up the insertion of nops (signalling non-inlined loads and 
stores) in the full codegens.
Review URL: http://codereview.chromium.org/3431010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 09:10:34 +00:00
mikhail.naganov@gmail.com
2133ee3fee Really fix Mac build, and lint. 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 08:51:13 +00:00
mikhail.naganov@gmail.com
64d07348ab Fix compilation issue on Mac 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 08:39:27 +00:00
mikhail.naganov@gmail.com
187d249d92 Enhance SafeStackFrameIterator to avoid triggering assertions in debug mode. 
When running profiling in debug mode, several assertions in frame
iterators that are undoubtedly useful when iterator is started from a
VM thread in a known "good" state, may fail when running over a stack
of a suspended VM thread. This patch makes SafeStackFrameIterator
to proactively check addresses and bail out from iteration early,
before an assertion will be triggered.

BUG=crbug/55565

Review URL: http://codereview.chromium.org/3436006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 08:23:34 +00:00
mikhail.naganov@gmail.com
b6c5c5b50d Fix x64 compilation error. Patch from tfarina@chromium.org 
http://codereview.chromium.org/3442004/show

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5466 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 08:17:46 +00:00
lrn@chromium.org
4d99cef867 X64: Templating Smi-macros to use both Label and NearLabel. 
Added some more uses of NearLabel.

Review URL: http://codereview.chromium.org/3381005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-16 07:24:15 +00:00
ricow@chromium.org
240cee91e4 Add support for near labels. 
This change introduces near labels in the assembler, allowing us to
uptimize forward jumps (conditional and unconditional) if we can
guarantee that the jump is witin range -128 to +127.

I changed a large fractions of the existing Labels to NearLabels, and
left out cases where it was not immediately clear if it could be used
or not (not immediately clear means labels covering a large code
block, or used in function calls which we could potentially change to
accept near labels). 

Review URL: http://codereview.chromium.org/3388004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-15 11:43:12 +00:00
erik.corry@gmail.com
fbd67b1045 Prepare push to trunk. We are now working on version 2.4.5. 
Review URL: http://codereview.chromium.org/3429006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-15 10:58:25 +00:00
lrn@chromium.org
cb514b72db Made predata smaller by storing symbol data in variable length base-128. 
Remove position from symbol data - they must come in the correct order anyway.

Review URL: http://codereview.chromium.org/3384003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-15 10:54:35 +00:00
erik.corry@gmail.com
62ec3292de Replace 2 ARM ldr instructions with one ldrd in the code generated 
for a SubStringStub and StringCompareStub in the ARM backend.  This
is a commit of http://codereview.chromium.org/3341012 for Andreas
Anyuru.
Review URL: http://codereview.chromium.org/3387003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5457 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-15 10:22:55 +00:00
fschneider@chromium.org
bd6a8c1e4e Make the CompareStub and the UnaryOpStub accept smi inputs. 
The stubs get an additional flag for including the smi code
inside the stub. This allows us to generate more compact code
if we don't want to inline the smi case outside the stub.

Review URL: http://codereview.chromium.org/3388005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5456 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-15 10:14:25 +00:00
antonm@chromium.org
dae5fc6f81 Attempt to collect more garbage before panicking with out of memory. 
Currently weak handles retain an object for another GC round (oftem times,
major GC round.)  Instrumenting Chromium shows that navigation leaves
many global objects which are only collected in next go.  Let's
attempt to collect more garbage when approacing OOM condition.

Review URL: http://codereview.chromium.org/3327021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-14 17:48:56 +00:00
vitalyr@chromium.org
c3f04bf46f Add a few missing nops to signal no inlined code was generated. 
Review URL: http://codereview.chromium.org/3399005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5454 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-14 16:38:02 +00:00
whesse@chromium.org
141e82b31e Allow List::sort, with an integer comparison function, to sort 64-bit pointers in profile-generator. Change a static const int member to be declared and defined only inside the class declaration in class Runtime. 
Review URL: http://codereview.chromium.org/3424002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5453 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-14 15:16:32 +00:00
mikhail.naganov@gmail.com
228d56bd8e Add support for abortion in v8::OutputStream. 
It's a good idea to allow receiver to interrupt data transmission.

Review URL: http://codereview.chromium.org/3409002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5452 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-14 15:11:24 +00:00
whesse@chromium.org
fc83faa8fd Move inlined function declarations and support from codegen.* to runtime.*. 
Review URL: http://codereview.chromium.org/3293002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5451 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-14 14:52:53 +00:00
mikhail.naganov@gmail.com
2388079051 Implement heap snapshots serialization into JSON. API is designed 
to avoid storing serialized snapshot on VM, instead it is emitted
using output stream interface.

The size of JSON emitted is roughly equal to used heap size
(when stored as an ASCII string).

Now a whole heap snapshot can be serialized and transmitted outside
VM. This makes possible:
  - implementing non-async UI for heap snapshots inspection;
  - storing heap snapshots for further inspection;
  - remote profiling (we can even implement a snapshotting mode
    where a snapshot isn't even stored in VM, only transmitted --
    good for mobile devices);
  - creating tools for outside heap snapshots processing, e.g.
    converting to HPROF.

Review URL: http://codereview.chromium.org/3311028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-14 11:49:06 +00:00
sgjesse@chromium.org
6ba4022033 Prepare push to trunk. We are now working on version 2.4.4. 
Review URL: http://codereview.chromium.org/3308028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5446 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-13 09:10:47 +00:00
kasperl@chromium.org
dffb7533aa Implement for-in cache validity checking in the full codegen on IA-32. 
Review URL: http://codereview.chromium.org/3376003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5445 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-13 06:13:20 +00:00
ager@chromium.org
666b98fb4b Handle both global and local variables potentially shadowed by 
eval-introduced variables in full-codegen.

Make sure that x64 assembler records source positions for calls.
Review URL: http://codereview.chromium.org/3357022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-10 10:57:07 +00:00
lrn@chromium.org
bc2bf76129 Move string-search functions to separate file. 
Review URL: http://codereview.chromium.org/3291021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-10 09:22:41 +00:00
lrn@chromium.org
84d8115ecf Fix bug in Array.prototype.indexOf/lastIndexOf when called on non-sparse non-arrays. 
Review URL: http://codereview.chromium.org/3358025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-10 08:21:01 +00:00
lrn@chromium.org
ac2ae05f85 make Date.parse properly handle TZ offsets 
This makes, e.g., Date.parse("2010-08-31T22:35:36-09:00") work as
expected. Without this change, the "-9:00" timezone-offset portion
causes V8 to fail to properly parse that string into a date.
BUG=http://code.google.com/p/v8/issues/detail?id=857
TEST=Try Date.parse("2010-08-31T22:35:36-09:00") and make sure
that it gets parsed without errors and does not return NaN.

Review URL: http://codereview.chromium.org/3318017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-10 07:00:28 +00:00
peter.rybin@gmail.com
4ed429cc43 Landing 3338012: Move a function below to private section. 
Review URL: http://codereview.chromium.org/3295023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5434 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-09 17:45:21 +00:00
vitalyr@chromium.org
624b13a804 Custom call IC for String.fromCharCode. 
Review URL: http://codereview.chromium.org/3291015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5433 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-09 13:38:01 +00:00
lrn@chromium.org
d1a674f7c1 Add sparse array handling to Array.protoype.indexOf/lastIndexOf. 
Review URL: http://codereview.chromium.org/3132046

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5432 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-09 12:57:32 +00:00
lrn@chromium.org
67d8302779 Avoid collecting symbol info for one-off preparsing. 
Review URL: http://codereview.chromium.org/3356010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5431 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-09 11:49:21 +00:00
ager@chromium.org
e5b63e7213 Handle global variables potentially shadowed by eval-introduced 
variables in full-codegen.

Review URL: http://codereview.chromium.org/3295022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-09 10:44:24 +00:00
sandholm@chromium.org
3877e1132b Change threshold for using ComplexIndexOf (using Boyer-Moore string 
search) from 5 to 7. 
Review URL: http://codereview.chromium.org/3294016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-08 12:57:50 +00:00
sandholm@chromium.org
3684dc4d88 Store pattern.length() in a local. 
Review URL: http://codereview.chromium.org/3300020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5428 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-08 11:05:54 +00:00
lrn@chromium.org
dc4898aae2 Don't generate preparse data if lazy-flag is false. 
Review URL: http://codereview.chromium.org/3304012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-08 10:33:15 +00:00
ager@chromium.org
d6b50d5a12 Prepare push of version 2.4.2 to trunk. 
Review URL: http://codereview.chromium.org/3324010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5424 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-08 06:20:09 +00:00
podivilov@chromium.org
8c595da419 Move stack check below while statement. 
Call to Runtime_StackGuard should be generated after loop body.
Otherwise, break position will be the previous position before
loop statement.

Review URL: http://codereview.chromium.org/3302012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5423 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-07 15:34:16 +00:00
kaznacheev@chromium.org
73c02394bf Avoid pushing arguments twice in GenericBinaryOpStub. 
Under some conditions (ADD, non-number arguments passed in registers)
GenerateRegisterArgumentsPush was called twice and the stack broke.

Review URL: http://codereview.chromium.org/3290012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5422 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-07 13:33:40 +00:00
lrn@chromium.org
7d3711ef75 Avoid (some) symbol lookups at parse time if preparse data is available. 
Review URL: http://codereview.chromium.org/3308010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5421 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-07 12:52:16 +00:00
serya@chromium.org
e54ad9ee86 Removing a wrong check. 
A strings which represents an array index with length 8 and 9 digits do not pass this check. However generated hash is valid.

Review URL: http://codereview.chromium.org/3295017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-07 11:32:20 +00:00
whesse@chromium.org
7368ce808e Fix the ambigous Operand(0) for newer C++ compilers. 
Review URL: http://codereview.chromium.org/3351010/show
Committed for Thiago Farina <tfarina@chromium.org>


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-07 11:09:45 +00:00
vegorov@chromium.org
983ed89a14 Ensure that empty descriptor array is marked before visiting any maps in marking phase. 
Review URL: http://codereview.chromium.org/3318014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5416 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-07 09:15:15 +00:00
vitalyr@chromium.org
ece887dabf Turn visitor_id into a byte field and free back one word in Map. 
Review URL: http://codereview.chromium.org/3364007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-06 12:50:11 +00:00
kmillikin@chromium.org
47e6e4fa6f Prepare push to trunk. Now working on version 2.4.2. 
Review URL: http://codereview.chromium.org/3305012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-06 11:31:07 +00:00
sgjesse@chromium.org
aa48d61c2b Improve performance of Error.stack when stack contains local functions. 
BUG=http://crbug.com/53303
TEST=Use the test case attached in the bug report.

Patch by Xianzhu Wang <wangxianzhu@google.com>

Review URL: http://codereview.chromium.org/3167042


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-06 09:10:11 +00:00
erik.corry@gmail.com
d59bb82f1f Add and use AsciiAlphaToLower. Move RemoveLast test. Add Clear test. This is a commit of http://codereview.chromium.org/3307003/show http://codereview.chromium.org/3312007/show and http://codereview.chromium.org/3341002/show for tfarina 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-03 12:59:52 +00:00
sgjesse@chromium.org
a6166065c4 Fix compilation on 64-bit Windows (a third try) 
Review URL: http://codereview.chromium.org/3295014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-03 12:56:08 +00:00
sgjesse@chromium.org
5309a79e12 Fix compilation on 64-bit Windows (a second try) 
TBR=pmehta@chromium.org
Review URL: http://codereview.chromium.org/3290009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-03 12:31:43 +00:00
vitalyr@chromium.org
62f7cd8500 Handle argument conversion in StringAddStub. 
In case one of the arguments is known to be a string we emit a few
fast conversion attempts for the other.  This allows using the
StringAddStub instead of STRING_ADD_{LEFT,RIGHT} builtins.

Review URL: http://codereview.chromium.org/3338007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5405 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-03 12:10:44 +00:00
sgjesse@chromium.org
bb7825051b Fix compilation on 64-bit Windows 
TBR=pmehta@chromium.org
Review URL: http://codereview.chromium.org/3333015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-03 12:00:05 +00:00
sgjesse@chromium.org
d3e457303e Add API callback for tracking allocated memory 
Allows the host application to provide a mechanism for notification and custom logging through a callback (set through the API V8::AddMemoryAllocationCallback and removed through V8::RemoveMemoryAllocationCallback), when V8 allocates ro frees memory. 

This replaces the current histogram data "V8.ExecutableMemoryMax" by allowing usage data to be logged by the application as required rather than always through V8. 

BUG=http://crbug.com/54222
TEST=Set the callback function with the API and cause V8 to allocate memory.

Patch by Paul Mehta <pmehta@chromium.org>

Review URL: http://codereview.chromium.org/3329006


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5403 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-03 11:31:58 +00:00
erik.corry@gmail.com
2b1e4560e7 Clang compatibility changes. This is a commit of http://codereview.chromium.org/3364002 for coldredlemur 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-02 10:18:44 +00:00
erik.corry@gmail.com
76e3e2afbb ARM: Handle bitwise operations with literal Smi for 32bits integers without calling the GenericBinaryOpStub. Refactored and updated the routine to convert a signed int to a double. This is a commit of http://codereview.chromium.org/3247008 for Rodolph Perfetta. 
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5401 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-02 08:30:52 +00:00
lrn@chromium.org
5628d3c482 Fix parsing of /**/--> on first line of input. 
BUG=53548
TEST=

Review URL: http://codereview.chromium.org/3330001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5400 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-02 07:36:30 +00:00
lrn@chromium.org
fce2fad17e Fix bug in JSON character quote table. 
Review URL: http://codereview.chromium.org/3349006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-02 07:35:35 +00:00
lrn@chromium.org
6670c0ad38 Make JSON.stringify not quote non-ASCII characters. Fix bug 855. 
Review URL: http://codereview.chromium.org/3336001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-02 07:09:28 +00:00
vitalyr@chromium.org
780934e17f ia32 StringAddStub: fast two character case. 
Review URL: http://codereview.chromium.org/3327001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-01 17:20:36 +00:00
yurys@chromium.org
5b1ba9a48c Don't access PagedSpace::executability after the object has been destroyed 
Review URL: http://codereview.chromium.org/3344001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-01 17:01:58 +00:00
whesse@chromium.org
990992a857 Remove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in test-log-stack-tracer.cc with an alternative implementation. 
Review URL: http://codereview.chromium.org/3311002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-01 13:13:31 +00:00
mikhail.naganov@gmail.com
ead8b4bea6 Fix memory overrun possibility during tick samples processing. 
This really can cause crash described in crbug/51919.

BUG=51919
TEST=NONE

Review URL: http://codereview.chromium.org/3334001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-01 13:08:39 +00:00
yurys@chromium.org
19d31d3e59 Initialize all VariableProxy fields in its constructor 
Review URL: http://codereview.chromium.org/3330002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-01 12:25:46 +00:00
ricow@chromium.org
0bde4a0312 Prepare push of version 2.4.0 to trunk. Now working on version 2.4.1. 
Review URL: http://codereview.chromium.org/3303002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5387 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-09-01 06:37:49 +00:00
mikhail.naganov@gmail.com
e82081a506 CPU profiler: limit the number of simultaneously collected profiles. 
This is related to Chromium issue 51919

BUG=51919
TEST=test-profile-generator/Issue51919

Review URL: http://codereview.chromium.org/3287005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5384 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 14:16:01 +00:00
ricow@chromium.org
a63f954588 Fix win64 compilation (using static_cast) 
Review URL: http://codereview.chromium.org/3225011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 12:20:22 +00:00
ricow@chromium.org
cd52245890 Simplify Array.splice by simply returning the result of AllocateEmptyJSArray. 
Review URL: http://codereview.chromium.org/3216014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5382 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 10:39:12 +00:00
ricow@chromium.org
a9641176fd Remove assertion that is no longer valid in InitializeStringSearch. 
This assertion is no longer valid because r5380 changes the assumption
about the pat parameter.

In addition, we embed the no allocation part of StringSplit in a block
to reenable allocation later in that method.


Review URL: http://codereview.chromium.org/3254010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 10:39:02 +00:00
sandholm@chromium.org
97ccb64a06 Simplify code by removing special-casing for single-character patterns 
Review URL: http://codereview.chromium.org/3276004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5380 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 09:22:53 +00:00
erik.corry@gmail.com
663f378da5 Get gcc to check that we don't ignore return values of functions that can 
fail to allocate because we need a GC.
Review URL: http://codereview.chromium.org/3274008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 08:05:42 +00:00
ricow@chromium.org
f19d6133f2 Fix mozilla and debug check failures. 
This removes the expected failure of a mozilla test that we now pass
(an empty array is returned if Array.splice is called with no
arguments) and fixes debug check failure by allocating a new empty
array using AllocateEmptyArray if splice is called with zero arguments
(makes sure we can always create a handle).

 
Review URL: http://codereview.chromium.org/3218010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-31 07:31:25 +00:00
ager@chromium.org
d955b212b5 Follow Safari and Firefox in returning empty array from array splice 
with no arguments.

Review URL: http://codereview.chromium.org/3277005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-30 18:08:50 +00:00
vitalyr@chromium.org
e9461cc50a Set the code pointer when compiling a function. 
Without this fix LazyCompile has to be called twice to set it.

Review URL: http://codereview.chromium.org/3253003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-30 13:39:07 +00:00
mikhail.naganov@gmail.com
18c7882ea2 Fix a error in SamplingCircularQueue found using Valgrind memcheck. 
Review URL: http://codereview.chromium.org/3251004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-30 13:30:54 +00:00
antonm@chromium.org
19dc35c13f Force relinking of paged space if first attempt to recommit from space fails. 
That could improve chances for commit success as currently,
if we moved free pages out of order, we cannot shrink spaces.
However, when we experience problems commiting from space back, we should
use most of resources at our disposal.

Also get rid of currently unused parameter to DeallocateFunction.

Review URL: http://codereview.chromium.org/3260001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5372 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-30 12:34:32 +00:00
whesse@chromium.org
a18f9d1114 Remove dependence of code-stubs on codegen, the virtual frame code generator. Move some functions used by code-stubs and full-codegen from codegen to macro-assembler. 
Review URL: http://codereview.chromium.org/3169049

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-30 11:48:07 +00:00
ricow@chromium.org
3fb62235e3 Add functionality for finding code objects from a pc that points into 
the code object's instructions.

This allows us to find a code object using just the pc. This approach
uses a cache (PcToCodeCache) to make sure we don't continuously have
to iterate heap pages.

This change eliminates the need for cooking and uncooking of stack frames.


Review URL: http://codereview.chromium.org/3226014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2010-08-30 08:54:43 +00:00