yangguo
8ae463d736
[debugger] remove mirror cache and v8::Debug::GetMirror.
...
R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2670823002
Cr-Commit-Position: refs/heads/master@{#42893}
2017-02-02 14:22:15 +00:00
yangguo
876da98a51
[debugger api] remove legacy JSON debug protocol.
...
R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2642253005
Cr-Original-Commit-Position: refs/heads/master@{#42543}
Committed: e26a58e43c
Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42595}
2017-01-23 10:44:20 +00:00
yangguo
7e420cf186
Revert of [debugger api] remove legacy JSON debug protocol. (patchset #2 id:20001 of https://codereview.chromium.org/2642253005/ )
...
Reason for revert:
Node.js relies on this
Original issue's description:
> [debugger api] remove legacy JSON debug protocol.
>
> R=jgruber@chromium.org
> BUG=v8:5530
>
> Review-Url: https://codereview.chromium.org/2642253005
> Cr-Commit-Position: refs/heads/master@{#42543}
> Committed: e26a58e43c
TBR=jgruber@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2644233003
Cr-Commit-Position: refs/heads/master@{#42549}
2017-01-20 11:30:06 +00:00
yangguo
e26a58e43c
[debugger api] remove legacy JSON debug protocol.
...
R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2642253005
Cr-Commit-Position: refs/heads/master@{#42543}
2017-01-20 10:44:27 +00:00
yangguo
a8cfc2f5e4
[debugger] deprecate v8::Debug:GetDebugContext.
...
R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2589203002
Cr-Original-Commit-Position: refs/heads/master@{#41911}
Committed: 381082168d
Review-Url: https://codereview.chromium.org/2589203002
Cr-Commit-Position: refs/heads/master@{#42220}
2017-01-11 11:59:54 +00:00
yangguo
f85678159d
Revert of [debugger] deprecate v8::Debug:GetDebugContext. (patchset #2 id:20001 of https://codereview.chromium.org/2589203002/ )
...
Reason for revert:
crbug/676749
Original issue's description:
> [debugger] deprecate v8::Debug:GetDebugContext.
>
> R=jgruber@chromium.org
> BUG=v8:5530
>
> Review-Url: https://codereview.chromium.org/2589203002
> Cr-Commit-Position: refs/heads/master@{#41911}
> Committed: 381082168d
TBR=jgruber@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5530, chromium:676749
Review-Url: https://codereview.chromium.org/2595413003
Cr-Commit-Position: refs/heads/master@{#41935}
2016-12-23 09:15:15 +00:00
yangguo
381082168d
[debugger] deprecate v8::Debug:GetDebugContext.
...
R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2589203002
Cr-Commit-Position: refs/heads/master@{#41911}
2016-12-22 07:04:01 +00:00
jgruber
1a6dae8070
[debug] Partial reland of debug API deprecation
...
This relands API deprecation (without removing the implementation),
removal of NewFunction and BeforeCompile events, and removal of
DebugCommandProcessor tests.
The remaining portion of the original CLs can be relanded after the 4.7
branch point.
Original CLs:
https://codereview.chromium.org/2524323002
https://codereview.chromium.org/2531543002
BUG=v8:5510
Review-Url: https://codereview.chromium.org/2546473008
Cr-Commit-Position: refs/heads/master@{#41446}
2016-12-02 09:02:01 +00:00
jgruber
4292f32ed3
[debug] Revert debug API removal
...
Debugging API is still in use by Node.
Revert "[debug] remove deprecated debug command message queue."
This reverts commit abdbfc953d
.
Revert "[debug] mark more unused debug API as deprecated."
This reverts commit d5ada19ce7
.
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2537313005
Cr-Commit-Position: refs/heads/master@{#41427}
2016-12-01 13:34:45 +00:00
yangguo
d5ada19ce7
[debug] mark more unused debug API as deprecated.
...
R=jgruber@chromium.org
BUG=v8:5510
Review-Url: https://codereview.chromium.org/2531543002
Cr-Commit-Position: refs/heads/master@{#41283}
2016-11-25 09:11:04 +00:00
yangguo
abdbfc953d
[debug] remove deprecated debug command message queue.
...
R=jgruber@chromium.org
BUG=v8:5510
Review-Url: https://codereview.chromium.org/2524323002
Cr-Commit-Position: refs/heads/master@{#41259}
2016-11-24 12:56:21 +00:00
yangguo
81a64aa548
[debug] remove JSON debug protocol related tests.
...
In most cases we can use the debug event listener as alternative.
Multithreaded tests are obsolete.
R=jgruber@chromium.org
BUG=v8:5510
Review-Url: https://codereview.chromium.org/2529883002
Cr-Commit-Position: refs/heads/master@{#41256}
2016-11-24 10:43:22 +00:00
yangguo
ff542972f6
[debugger] remove deprecated api functions.
...
Review-Url: https://codereview.chromium.org/2162503002
Cr-Commit-Position: refs/heads/master@{#37892}
2016-07-20 08:52:18 +00:00
jochen
37394eb3b0
Add a convenience method to get the debugged context
...
Since the generic GetCallingContext is deprecated, but there's still the
use case for the debugger to get the currently debugged context while in
the debug context, add a convenience API for it.
Note that EventDetails already exposes this context, but the embedder
might not necessarily have the EventDetails around.
R=verwaest@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2040853003
Cr-Commit-Position: refs/heads/master@{#36751}
2016-06-06 14:12:10 +00:00
kozyatinskiy
725672512a
[V8] Removed debugger V8::PromiseEvent
...
We decided to remove related devtools experiment.
BUG=chromium:526811
LOG=Y
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/1833563002
Cr-Commit-Position: refs/heads/master@{#35275}
2016-04-05 18:13:02 +00:00
ishell
037f7f6215
[api] Add a switch that controls if ES2015 tail call elimination feature is enabled or not.
...
BUG=v8:4698
LOG=N
TBR=rossberg@chromium.org
Review URL: https://codereview.chromium.org/1842763002
Cr-Commit-Position: refs/heads/master@{#35132}
2016-03-30 11:05:19 +00:00
jochen
0f2bffa11e
Mark deprecated debugger APIs as such
...
We should consider deprecating the message based API as well in the
future.
BUG=none
R=yangguo@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/1485333007
Cr-Commit-Position: refs/heads/master@{#32621}
2015-12-04 15:25:40 +00:00
jochen
6c0d1a1100
Pass explicit Isolate parameter to v8::Debug methods that need it
...
BUG=v8:2487
LOG=n
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1496493002
Cr-Commit-Position: refs/heads/master@{#32509}
2015-12-02 12:47:41 +00:00
mstarzinger
92e85aed10
[presubmit] Fix build/include linter violations.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1318863004
Cr-Commit-Position: refs/heads/master@{#30554}
2015-09-03 07:56:14 +00:00
jochen
f022e53b95
Make v8::Handle as "deprecated soon"
...
BUG=v8:4131
R=bmeurer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1224623004
Cr-Commit-Position: refs/heads/master@{#29473}
2015-07-06 07:09:13 +00:00
yurys
ae6ec1861e
Provide accessor for object internal properties that doesn't require debugger to be active
...
Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context.
Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL.
BUG=chromium:481845
LOG=Y
Review URL: https://codereview.chromium.org/1134193002
Cr-Commit-Position: refs/heads/master@{#28371}
2015-05-12 15:40:27 +00:00
yangguo
396236bfa0
Revert of Provide accessor for object internal properties that doesn't require debugger to be active (patchset #3 id:40001 of https://codereview.chromium.org/1126103006/ )
...
Reason for revert:
GC mole issues: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio
Original issue's description:
> Provide accessor for object internal properties that doesn't require debugger to be active
>
> Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context.
>
> Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL.
>
> BUG=chromium:481845
> LOG=Y
>
> Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d
> Cr-Commit-Position: refs/heads/master@{#28362}
TBR=pfeldman@chromium.org ,kozyatinskiy@chromium.org,yurys@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:481845
Review URL: https://codereview.chromium.org/1133243002
Cr-Commit-Position: refs/heads/master@{#28365}
2015-05-12 13:03:52 +00:00
yurys
bdeb0de88c
Provide accessor for object internal properties that doesn't require debugger to be active
...
Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context.
Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL.
BUG=chromium:481845
LOG=Y
Review URL: https://codereview.chromium.org/1126103006
Cr-Commit-Position: refs/heads/master@{#28362}
2015-05-12 12:38:15 +00:00
yurys
cf07add227
Don't create debug context if debug listener is not set
...
If there had been no debug listener v8::Debug::GetDebugContext would have created new context and wouln't have kept reference to it. This way we may well end up with several debug contexts and disabled debugger.
As a side effect this change allows to efficiently distinguish debug context from blink contexts by simply comparing handles.
BUG=chromium:482290
LOG=Y
Review URL: https://codereview.chromium.org/1136733002
Cr-Commit-Position: refs/heads/master@{#28356}
2015-05-12 07:33:18 +00:00
yangguo
10b979e6aa
Debugger: clean up debug events.
...
The debug event BreakForCommand is now deprecated, as it cannot happen any longer.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/1089893002
Cr-Commit-Position: refs/heads/master@{#28071}
2015-04-27 12:10:00 +00:00
yangguo
8e723e9892
Debugger: remove debug command API.
...
Instead, please use v8::Isolate::RequestInterrupt to synchronize
to the main thread.
R=yurys@chromium.org
API=Removed v8::Debug::DebugBreakForCommand
LOG=Y
Review URL: https://codereview.chromium.org/1036863002
Cr-Commit-Position: refs/heads/master@{#27625}
2015-04-07 12:21:42 +00:00
dcarney
5234d9977d
convert most remaining api functions needing context to maybes
...
BUG=
Review URL: https://codereview.chromium.org/993223003
Cr-Commit-Position: refs/heads/master@{#27126}
2015-03-11 09:33:04 +00:00
yangguo@chromium.org
5832ab8501
Expose function CheckDebugBreak in the debugger api
...
API=v8::Debug::CheckDebugBreak
LOG=Y
R=aandrey@chromium.org , vsevik@chromium.org , yurys@chromium.org
Review URL: https://codereview.chromium.org/473913002
Patch from Sergei Vasilinetc <sergeyv@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-20 11:04:05 +00:00
aandrey@chromium.org
952a986dd1
Introduce debug events for Microtask queue.
...
R=yangguo@chromium.org , adamk@chromium.org , rafaelw@chromium.org , rossberg@chromium.org
BUG=chromium:272416
LOG=Y
Review URL: https://codereview.chromium.org/362783002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-03 15:56:01 +00:00
yangguo@chromium.org
f6c4178aa7
Introduce debug events for promises.
...
R=aandrey@chromium.org , rossberg@chromium.org
BUG=v8:3093
LOG=Y
Review URL: https://codereview.chromium.org/357603005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22086 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-30 11:12:42 +00:00
yangguo@chromium.org
0133d96be3
Remove script collected debug event.
...
R=yurys@chromium.org
Review URL: https://codereview.chromium.org/358873005
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22063 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-27 12:10:43 +00:00
yurys@chromium.org
0339d069d9
Add OnCompileError handler and v8::CompileError debug event.
...
This event is generated when the parser can not generate code.
R=vsevik@chromium.org , yangguo@chromium.org , yurys@chromium.org
Review URL: https://codereview.chromium.org/264333007
Patch from Alexey Kozyatinskiy <kozyatinskiy@google.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22043 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-26 16:03:52 +00:00
svenpanne@chromium.org
f67f8fc4c5
Removed dead API entries.
...
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/322293003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-11 09:12:35 +00:00
yangguo@chromium.org
50cba82cb9
Remove unused debug API.
...
R=yurys@chromium.org
Review URL: https://codereview.chromium.org/303693010
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21590 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-02 06:22:09 +00:00
yangguo@chromium.org
33fba3bfa1
Remove DebuggerAgent.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/279423004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21315 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-14 16:28:46 +00:00
yangguo@chromium.org
20a627183f
Rename debug API methods.
...
R=yurys@chromium.org
Review URL: https://codereview.chromium.org/281733002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21295 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-14 08:07:21 +00:00
yangguo@chromium.org
f56701f30c
Clean up Debugger::NotifyMessageHandler.
...
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/276433004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-09 09:24:32 +00:00
yangguo@chromium.org
7e367ae0ed
Reland "Trigger exception debug event for promises at the throw site."
...
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/266533003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-30 15:17:51 +00:00
yangguo@chromium.org
792af58115
Revert "Trigger exception debug event for promises at the throw site."
...
This reverts r21092.
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/262533009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-30 14:51:41 +00:00
yangguo@chromium.org
eed0e7e7a3
Trigger exception debug event for promises at the throw site.
...
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/260723002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-30 14:17:40 +00:00
yangguo@chromium.org
3a92c26e36
Rename debug event enum to be consistent.
...
R=aandrey@chromium.org
Review URL: https://codereview.chromium.org/255163004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-29 14:03:06 +00:00
bmeurer@chromium.org
d4b533d41b
Bulk update of Google copyright headers in source files.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/259183002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-29 06:42:26 +00:00
yangguo@chromium.org
28f5cf398e
Trigger debug event on not yet caught exception in promises.
...
R=aandrey@chromium.org , rossberg@chromium.org , yurys@chromium.org
BUG=v8:3093
LOG=Y
Review URL: https://codereview.chromium.org/249503002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-25 07:03:05 +00:00
svenpanne@chromium.org
cd89f90bd1
Removed GetDefaultIsolate{Debugger,ForLocking,StackGuard}.
...
Some first steps towards removing the default Isolate. Fixed argument
order on the way, incl. temporary helpers.
BUG=359977
LOG=y
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/238803002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20747 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-15 07:47:33 +00:00
yurys@chromium.org
681c15eb4e
Remove debugger_auto_break flag
...
The flag was introduced to support console debugger in Chrome. That debugger was replaced by DevTools long time ago and the flag is always true now.
BUG=None
LOG=Y
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/220743003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-01 11:23:23 +00:00
svenpanne@chromium.org
085dddc69d
Removed 'executable' bits from header.
...
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/212793011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-27 12:15:14 +00:00
dcarney@chromium.org
c96a606e77
Remove default isolate usage from almost all tests
...
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24220003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-19 07:33:45 +00:00
dcarney@chromium.org
ce687e4bed
thread isolate for DebugMessage
...
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23904012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16621 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-10 14:26:07 +00:00
yurys@chromium.org
4f60ee6bd7
Remove deprecated methods from debugger API
...
Deleting SetDebugEventListener and SetMessageHandler from v8::Debug. this methods were deprecated in 3.20
https://code.google.com/p/v8/source/browse/branches/3.20/include/v8-debug.h but in fact they have been superseded by SetDebugEventListener2 and SetMessageHandler2 long ago.
BUG=None
R=bmeurer@chromium.org , loislo@chromium.org
Review URL: https://codereview.chromium.org/23576002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-28 07:11:37 +00:00
yurys@chromium.org
2144dc2d0f
Define V8EXPORT only in v8.h and use it in the other headers
...
V8EXPORT is defined in each header of V8 public API and the definitions already have some slight discrepancies. This CL makes all headers use the same definition in v8.h
BUG=None
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/22363003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-06 14:37:35 +00:00