Commit Graph

12617 Commits

Author SHA1 Message Date
bmeurer@chromium.org
9929a9cd12 Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.
- Use V8_FINAL and V8_OVERRIDE in objects.
- Use V8_FINAL and V8_OVERRIDE in Ast classes.
- Use V8_FINAL and V8_OVERRIDE in Lithium mips backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium arm backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium x64 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium ia32 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium classes.
- Use V8_FINAL and V8_OVERRIDE in Hydrogen classes.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/23064017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-20 07:27:06 +00:00
bmeurer@chromium.org
cb4eb5b3e1 Add V8_FINAL and V8_OVERRIDE macros for C++11 final/override.
TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/22914019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-20 06:51:58 +00:00
bmeurer@chromium.org
c44ccc2d79 Revert "Add FINAL and OVERRIDE macros for C++11 final/override."
This reverts commit r16222 for not using V8_ prefix.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23301006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-20 06:39:04 +00:00
dslomov@chromium.org
80ec7fab15 Revert "Promote ArrayBuffer, DataView and typed arrays to non-experimental."
This reverts commit r16137 for breaking Windows build.
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22985011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-20 01:37:09 +00:00
dslomov@chromium.org
62505a3901 Promote ArrayBuffer, DataView and typed arrays to non-experimental.
The primary reason for this change is to bake these guys into the
snapshot.

Flag definitions (--harmony-typed-arrays, --harmony-array-buffer) are
still there so that Blink does not complain, but they are noop and
default to true.

R=mstarzinger@chromium.org
BUG=270527

Committed: https://code.google.com/p/v8/source/detail?r=16137

Review URL: https://codereview.chromium.org/22390008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16228 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-20 00:48:25 +00:00
danno@chromium.org
ca9a3c71a1 Remove platform-specific dead code for KeyedStores
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22745003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 22:12:46 +00:00
mstarzinger@chromium.org
bbf9018c0f Fix invalid out-of-bounds store in MacroAssembler::Allocate.
This fixes an out-of-bounds store in inlined allocations when double
alignment and pretenuring into old-data-space have been requested.

R=hpayer@chromium.org, jkummerow@chromium.org, plind44@gmail.com
BUG=chromium:263515

Review URL: https://codereview.chromium.org/23242006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16224 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 17:46:43 +00:00
palfia@homejinni.com
8bb2b9307f MIPS: Remove wrong restriction in GenerateDeoptJumpTable.
* This Abort condition does not apply to MIPS, since the
  assembler can also emit long Branches automatically, when
  it is needed.

TEST=mjsunit/math-floor-of-div,benchmarks/octane/gbemu,benchmarks/octane/mandreel

BUG=

Review URL: https://codereview.chromium.org/23020018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 16:02:50 +00:00
bmeurer@chromium.org
254482e4a3 Add FINAL and OVERRIDE macros for C++11 final/override.
We also use new the constant naming scheme for Yield::Kind values to avoid
clash with the FINAL macro.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23098004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 14:46:35 +00:00
bmeurer@chromium.org
a04490517a ARM: Fix register misuse bug in Allocate().
The bug is triggered if flags contains DOUBLE_ALIGNMENT and the
object_size is not an ARM immediate value. In this case, the code
for DOUBLE_ALIGNMENT uses the scratch2 register, which is aliased
to obj_size_reg containing the object_size.

Instead of pre-loading the object_size, which is difficult since
we are out of registers here, we simply generate a non-empty
sequence of add instructions for the addition of the constant
object_size (carefully handling possible overflow in each step).

Also turn static ASSERT into STATIC_ASSERT in Allocate().

BUG=v8:2851
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23323002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 13:37:57 +00:00
mstarzinger@chromium.org
665a6d8a94 Prevent empty handle dereference in Runtime_InternalNumberFormat.
R=jochen@chromium.org
BUG=chromium:275467

Review URL: https://codereview.chromium.org/22859025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 13:03:58 +00:00
verwaest@chromium.org
20ca26f494 Improve generalization / migration tracing.
R=yangguo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23047002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 12:32:50 +00:00
mstarzinger@chromium.org
94fb05f823 Temporary workaround for GC stress builder.
R=hpayer@chromium.org, hpayer@google.com
TEST=cctest/test-debug/ScriptCollectedEventContext --gc-interval=500

Review URL: https://codereview.chromium.org/22987004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16216 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 11:10:08 +00:00
mstarzinger@chromium.org
d52f489c79 Clarify side effects of HTransitionElementsKind.
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22796011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16215 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 10:55:51 +00:00
rossberg@chromium.org
17046dbe14 Prepare push to trunk. Now working on version 3.21.1.
R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/22856005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 09:34:18 +00:00
bmeurer@chromium.org
8fa088b273 Drop broken and unnecessary RequiredInputRepresentation() in HMathFloorOfDiv.
R=titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16190

Review URL: https://codereview.chromium.org/23190002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-19 07:25:25 +00:00
mstarzinger@chromium.org
c5c6c23a23 Handlify Accessors::FunctionSetPrototype method.
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/23280004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-16 21:27:11 +00:00
mstarzinger@chromium.org
3fa964bf53 Remove check for empty handle for CodeGenerator::MakeCodeEpilogue.
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/22840002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-16 19:52:29 +00:00
verwaest@chromium.org
d81af53131 Store copied value rather than the original double.
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23262002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-16 15:43:42 +00:00
mstarzinger@chromium.org
3e4fbd0e85 Mark HStringCompareAndBranch as potentially causing GCs.
This also adds a %SetAllocationTimout runtime function which helps to
write regression tests that need to trigger a GC at a certain point in
program execution.

R=hpayer@chromium.org
BUG=chromium:274438
TEST=mjsunit/regress/regress-crbug-274438

Review URL: https://codereview.chromium.org/22933006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16205 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-16 15:10:07 +00:00
jochen@chromium.org
aabfd6d610 Revert "make Intl non-enumerable"
This reverts commit 327355efe28995f5d91aadb54c71ea1d292c8428.

TBR=svenpanne@chromium.org,dcarney@chromium.org

Review URL: https://codereview.chromium.org/22893026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-16 14:10:08 +00:00
danno@chromium.org
d5762717d6 Fix bug in test-code-stubs-x64 which meant not all registers were being checked.
Also change test-code-stubs-ia32 to use the same style as x64.

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/22865006

Patch from Ross McIlroy <mcilroy@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-16 11:29:54 +00:00
palfia@homejinni.com
aaeca64dd6 MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all uses allow undefined as nan.
Port r16183 (1858bc57)

BUG=

Review URL: https://codereview.chromium.org/23130006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 23:07:48 +00:00
danno@chromium.org
48ff27831c Prepare push to trunk. Now working on version 3.21.0
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22870007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 17:10:14 +00:00
danno@chromium.org
6bcca144a9 Fix GC Mole warning
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22815005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 17:03:19 +00:00
danno@chromium.org
6cd9ae7bc1 Fix src/version.cc number to be consistent with next trunk push
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23000010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 17:00:16 +00:00
verwaest@chromium.org
928b07f558 Fix no-sse2 part 2.
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23154004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 16:58:14 +00:00
danno@chromium.org
7aa3fedaab Fix Crankshafted CompareNil of constant values
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23198002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 16:13:58 +00:00
verwaest@chromium.org
ea14c000bc Fix CmpHoleAndBranch on no-sse2
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22810005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 15:50:23 +00:00
bmeurer@chromium.org
051a196723 Revert "Drop broken and unnecessary RequiredInputRepresentation() in HMathFloorOfDiv."
This reverts r16190.

TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/23188003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 14:50:15 +00:00
bmeurer@chromium.org
6be103c041 Drop broken and unnecessary RequiredInputRepresentation() in HMathFloorOfDiv.
R=titzer@chromium.org

Review URL: https://codereview.chromium.org/23190002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 14:34:40 +00:00
jochen@chromium.org
13cc3b59be updates
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 12:53:09 +00:00
jochen@chromium.org
aeaa87714c updates
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 12:53:01 +00:00
jochen@chromium.org
ef95294896 Add a bootstrap script to make it easier to build gcmole
R=machenbach@chromium.org

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 12:52:51 +00:00
jkummerow@chromium.org
1fcccc22ee Revert "Make GlobalHandle::NodeBlock deletable"
This reverts r16040 due to OOM crashes.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/22970004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 12:40:44 +00:00
jkummerow@chromium.org
e71a91ca08 Fix Math.round/floor that had bogus Smi representation
BUG=chromium:272564
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23022005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 12:14:08 +00:00
verwaest@chromium.org
8e11d9c5c0 Load size in signed int before making negative.
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23074003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 09:47:27 +00:00
verwaest@chromium.org
169f5a9d7b Never hchange nan-hole to hole or hole to nan-hole.
Only allow changing hole to nan if all uses allow undefined as nan.

R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22152003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-14 08:54:27 +00:00
palfia@homejinni.com
e12b6ff35d MIPS: Store doubles before calling into the elements transition stub
Port r16172 (cc2b6204)

BUG=

Review URL: https://codereview.chromium.org/23110002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 23:34:34 +00:00
jkummerow@chromium.org
6f800f90ee Fix overflow check computation for Smi Phis
BUG=v8:2836
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22629011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 18:18:24 +00:00
jkummerow@chromium.org
b3b99969b0 Fix overwriting order of object literal properties for MATERIALIZED_LITERALs
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22982005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 17:27:58 +00:00
danno@chromium.org
bbd28067a2 Prepare push to trunk. Now working on version 3.20.17.
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23073003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 17:08:20 +00:00
yangguo@chromium.org
1041f58e8f Use Cell instead of PropertyCell in DoCheckFunction (in case of new space object).
R=danno@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23036004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16175 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 16:58:14 +00:00
yangguo@chromium.org
415b61e12e Fix bug in HPhi::SimplifyConstantInput
R=jkummerow@chromium.org
BUG=269679

Review URL: https://codereview.chromium.org/23075003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 16:47:27 +00:00
jkummerow@chromium.org
b9d8275ba0 Make HToFastProperties GC safe.
The runtime call can cause a GC, so the instruction must have proper flags set.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22980003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 16:26:53 +00:00
verwaest@chromium.org
145f240060 Store doubles before calling into the elements transition stub on ARM
BUG=
R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22854011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 15:06:17 +00:00
jochen@chromium.org
edd8714aca Fix gcmole bugs in i18n code
R=mstarzinger@chromium.org,dcarney@chromium.org
BUG=v8:2745

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 12:24:44 +00:00
jochen@chromium.org
ab4cbbc083 Also add i18n directories to gcmole
R=vegorov@chromium.org

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 12:22:56 +00:00
jochen@chromium.org
91f0f5f0c3 Run gcmole on i18n code.
BUG=none
R=vegorov@chromium.org, vegorov@google.com

Review URL: https://codereview.chromium.org/23011004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 11:05:30 +00:00
verwaest@chromium.org
e8d6f44183 Mark CheckMaps that can cause migration with ChangesNewSpacePromotion.
BUG=
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22982003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-13 09:38:46 +00:00