floitschV8@gmail.com
ce666fc2fe
Implement fast case for strtod.
...
If there are few non-zero digits and the 10^exponent fits into a double then
we can compute the result using 1 (or 2) double operations.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3584015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5603 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-07 12:01:25 +00:00
whesse@chromium.org
d4afed6bff
Fix new strtod on Windows platform, using OS::SNPrintF instead of snprintf. Fixes error in r5600.
...
Review URL: http://codereview.chromium.org/3601018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5602 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-07 09:40:26 +00:00
floitschV8@gmail.com
e5bb73acba
Fix build-breakage. Add new line to end of strtod.h. TBR: whesse@chromium.org
...
BUG=
TEST=
Review URL: http://codereview.chromium.org/3584018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-07 09:12:21 +00:00
floitschV8@gmail.com
caf6856ade
Move gay_strtod outside conversions.cc.
...
This is the first part of removing calls to gay's strtod. Future CLs will
get rid of calls to gay_strtod entirely.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3563009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-07 08:54:10 +00:00
kasperl@chromium.org
fdde212fec
Promote the current V8 benchmark suite candidate to version 6.
...
Review URL: http://codereview.chromium.org/3571021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-07 07:25:22 +00:00
kmillikin@chromium.org
92a74be6f1
Fix presubmit failure.
...
Review URL: http://codereview.chromium.org/3605008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5595 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-06 08:47:08 +00:00
floitschV8@gmail.com
9c00ea744b
During StringToDouble negative exponents may be less than -999 with a result that is not 0.0.
...
Review URL: http://codereview.chromium.org/3564011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-06 08:33:52 +00:00
ager@chromium.org
55356a3627
Land for Rodolph Perfetta.
...
Added a missing SetCC in the ARM CompareStub.
BUG=none
TEST=none
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5593 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-06 06:09:05 +00:00
yurys@chromium.org
481c25908c
Code clean-up in src/top.cc This patch addresses late review comments for http://code.google.com/p/v8/source/detail?r=5586
...
Review URL: http://codereview.chromium.org/3596005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5592 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 13:29:31 +00:00
antonm@chromium.org
7c238db829
Do not shortcut union of keys if lhs is empty.
...
The problem is other array may have holes, for example
when fixed array comes from JSArray (in case of named interceptor).
If that would prove to be a performance problem, we could
pass an additional argument into UnionOfKeys to hold actual length.
Review URL: http://codereview.chromium.org/3595013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5591 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 13:10:43 +00:00
antonm@chromium.org
6e1d8065a4
Add a check that accessors set to instance template work even if we have a custom call handler.
...
Review URL: http://codereview.chromium.org/3526008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5590 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 12:48:32 +00:00
vitalyr@chromium.org
2ffa84ad4d
Fix typo in the spec reference.
...
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/3547012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5589 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 12:01:46 +00:00
vitalyr@chromium.org
91b9a92336
Addressing Mads' comments from http://codereview.chromium.org/3585010/show .
...
Review URL: http://codereview.chromium.org/3613009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5588 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 11:51:41 +00:00
yurys@chromium.org
a3e66d2df4
Fix lint errors
...
TBR=mnaganov
Review URL: http://codereview.chromium.org/3525014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5587 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 09:07:17 +00:00
yurys@chromium.org
eb24a86e1b
StackTrace should provide access to //@ sourceURL=... value
...
Review URL: http://codereview.chromium.org/3602013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5586 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-05 08:53:51 +00:00
vitalyr@chromium.org
d498613c9a
Make lint happy.
...
TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/3609008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-04 15:21:38 +00:00
vitalyr@chromium.org
b999ae3cbd
API: expose RegExp.
...
Review URL: http://codereview.chromium.org/3585010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-04 15:04:16 +00:00
kmillikin@chromium.org
ea910460bd
More refactoring of class Compiler's interface.
...
Change more functions used by the Compiler class to have a uniform
interface: they get passed as argument an input/output pointer to a
CompilationInfo that they mutate if they succeed, and they return a
flag telling whether they succeeded.
Also, remove some unnecessary timers.
Review URL: http://codereview.chromium.org/3561012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5583 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-04 14:30:43 +00:00
mikhail.naganov@gmail.com
2f54abf974
Previously, there was a bug there, fixed in r5581. But having an assert still makes sense.
...
Also, add functions registration to CPU profiler in case
when closure code wasn't compiled yet.
Review URL: http://codereview.chromium.org/3557007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5582 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-04 12:54:31 +00:00
kmillikin@chromium.org
bef3ae07db
Begin a more aggressive refactoring of the Compiler interface.
...
The plan is to use the CompilationInfo class to communicate inputs and
outputs to compilation pipeline phases, which each return a boolean
success/failure flag.
The intent is to make it easier to compose small pieces of the
pipeline without having to grow a custom function each time, each
taking a half dozen arguments.
This change modifies the very front end (the parser).
Review URL: http://codereview.chromium.org/3586006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5581 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-04 11:35:46 +00:00
ricow@chromium.org
26163835a7
Prepare push to trunk. Now working on version 2.4.9.
...
Review URL: http://codereview.chromium.org/3538009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-04 07:57:07 +00:00
kmillikin@chromium.org
5d1dac259a
Fix a pair of compilation failure bugs in test files due to r5576.
...
1. parser.h depends on ast.h, but only gets it included implicitly
everywhere parser.h is included (except for tests). Include ast.h in
parser.h.
2. Regular expression tests test the free functions that have just been
moved into class Parser.
TBR=fschneider@chromium.org
Review URL: http://codereview.chromium.org/3602007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5577 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 15:32:32 +00:00
kmillikin@chromium.org
d0fcd24c03
Make some free functions into static members of class Parser.
...
Review URL: http://codereview.chromium.org/3518005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 14:10:47 +00:00
kaznacheev@chromium.org
f1d057dfec
Fix property array length calculation in TransformPropertiesToFastFor.
...
It was silently assumed that inobject_properties value is not too large.
Recent introduction of inobject slack tracking made the assumption false
and debug tests with no snapshot failed.
Review URL: http://codereview.chromium.org/3584004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5575 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 12:40:30 +00:00
sgjesse@chromium.org
a11fb492fa
Rename include guard to match file name
...
Review URL: http://codereview.chromium.org/3532006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5574 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 09:30:42 +00:00
lrn@chromium.org
a556a16f0f
Fix bad cast in string-search.h.
...
Review URL: http://codereview.chromium.org/3530004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5572 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 09:08:52 +00:00
kaznacheev@chromium.org
1156bbc82a
Fine-tune inobject slack tracking.
...
The current parameters (initial slack = 6, kGenerousAllocationsCount = 16)
caused 15-20% performance regression on 3d-raytrace on x64
(visible both in standalone shell and in the web harness). This is very
likely some kind of an alignment problem (it goes away completely with --prof).
A similar problem can be observed on ia32 with initial slack=2.
Increased initial slack to 8 and decreased constructions count to 8.
This made the regression go away (and did not harm any of the other tests).
Review URL: http://codereview.chromium.org/3595002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5571 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 08:28:28 +00:00
mikhail.naganov@gmail.com
5a30072502
Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced
...
during snapshot size optimization.
Sorry, now I figured out that the diff implementation itself was also
incorrect. Reachable nodes must be filtered from the beginning,
otherwise, an object that is already disconnected, but not discarded
yet, will not appear as a deleted (thankfully, this bug for some
reason had appeared on the x64 port.)
BUG=868
TEST=HeapSnapshotRootPreservedAfterSorting
Review URL: http://codereview.chromium.org/3531005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5570 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-01 07:19:23 +00:00
vitalyr@chromium.org
7228d867cb
Use existing global cell status as a hint when generating loads.
...
Review URL: http://codereview.chromium.org/3537003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 17:39:31 +00:00
mikhail.naganov@gmail.com
44050b12b9
Revert last commit due to check fail on Linux.
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5568 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 12:35:03 +00:00
mikhail.naganov@gmail.com
99c276bbbc
Fix HeapSnapshotsDiff test and a bug introduced during snapshot size optimization.
...
The bug wasn't revealed because the test was disabled.
BUG=848
TEST=HeapSnapshotsDiff,HeapSnapshotRootPreservedAfterSorting
Review URL: http://codereview.chromium.org/3572003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5567 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 12:24:56 +00:00
antonm@chromium.org
f8b274eea8
Rename some x64 macros to be more precise about their semantics.
...
Review URL: http://codereview.chromium.org/3574002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5566 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 11:48:03 +00:00
mikhail.naganov@gmail.com
4e961fdd36
Add fflush after writing to log (Issue 868).
...
BUG=868
Review URL: http://codereview.chromium.org/3605001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 10:50:39 +00:00
kmillikin@chromium.org
9190e5f941
Prepare push to trunk. Now working on version 2.4.8.
...
Review URL: http://codereview.chromium.org/3585003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5562 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 09:35:50 +00:00
kmillikin@chromium.org
c019508bad
Cleanup of the parser.
...
The lazy parsing functions took a host of arguments that can all be
derived from the SharedFunctionInfo, and the SharedFunctionInfo is
always available when parsing lazily. Change the interface to take a
single CompilationInfo or SharedFunctionInfo argument.
Also remove a flag in the parser that was always false when it was read.
Review URL: http://codereview.chromium.org/3538005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5561 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 09:28:58 +00:00
kmillikin@chromium.org
f21b34ef0f
Introduce subclasses of class CompilationInfo.
...
It was a wart that we had three handle fields, exactly one of which
was non-null; and that we had three overloaded constructors. Instead,
introduce subclasses and virtual methods.
Remove some unused fields from class CompilationInfo.
Review URL: http://codereview.chromium.org/3566003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5560 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 08:48:37 +00:00
erik.corry@gmail.com
d46fb9d454
New attempt to make the allocation routines 64 bit clean.
...
This one has been approved by the 64 bit compiler in MSVC
2005 so I hope it also passes the 2008 version.
The --max-new-space-size option is now in kBytes.
The --max-old-space-size option is now in MBytes.
Some issues remain with 64 bit heaps and the counters. See
http://code.google.com/p/v8/issues/detail?id=887
Review URL: http://codereview.chromium.org/3573005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5559 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-30 07:22:53 +00:00
antonm@chromium.org
9e618ff460
Add another check to be sure non-negative smi fits into Uint32 range.
...
Review URL: http://codereview.chromium.org/3546003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 18:15:36 +00:00
kmillikin@chromium.org
4d04e9d5d4
Remove some unused fields from class CompilationInfo.
...
Review URL: http://codereview.chromium.org/3533007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5557 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 17:38:37 +00:00
antonm@chromium.org
3567207741
Do not invoke indexed interceptor getters for negative indices.
...
BUG=https://bugs.webkit.org/show_bug.cgi?id=46689
Review URL: http://codereview.chromium.org/3520006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5553 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 15:08:38 +00:00
erik.corry@gmail.com
ef135e5351
Add cast to make Win-64 compile without warnings. This is a commit of http://codereview.chromium.org/3521002 for lrn.
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5552 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 14:06:30 +00:00
lrn@chromium.org
3614edebea
Added missing file. Mea culpa.
...
Review URL: http://codereview.chromium.org/3586001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 12:12:45 +00:00
lrn@chromium.org
2c85faf1ae
Refactored string search code.
...
Made string search state explicit for repreated calls (a StringSearch class).
Review URL: http://codereview.chromium.org/3467010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5550 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 10:57:23 +00:00
kmillikin@chromium.org
d9d49052f9
Add an AST node type enum to AST nodes.
...
When inspecting an AST node in the debugger, it can be difficult to
find its concrete type. Add a "node_type" virtual function to all the
concrete AST nodes.
Use a macro to generate the definition of node_type as well as Accept
and the AsXXX type testing/casting functions.
Review URL: http://codereview.chromium.org/3431026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5549 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-29 07:51:47 +00:00
vitalyr@chromium.org
e0feeec039
Mark ptest instruction as requiring SSE4.1.
...
I also added a flag like the ones we have for other SSE versions.
Review URL: http://codereview.chromium.org/3505003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5548 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-28 14:56:36 +00:00
vitalyr@chromium.org
9aa65c29dc
Fix external array iteration used in array concat.
...
We should use Factory and not Heap there.
Review URL: http://codereview.chromium.org/3380031
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5547 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-28 14:49:29 +00:00
erik.corry@gmail.com
2d0c23bc82
Revert attempt to make heap size 32/64 clean. This change needs to
...
be done from Windows where the compiler is stricter about truncating
changes.
Review URL: http://codereview.chromium.org/3454035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5545 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-28 12:49:25 +00:00
erik.corry@gmail.com
d6313dbbb7
More changes to 32/64 bit correctness.
...
TBR=vegorov
Review URL: http://codereview.chromium.org/3412038
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-28 12:18:19 +00:00
erik.corry@gmail.com
28d7064856
More correctness around PrintF and 32/64 bit values.
...
Fix test after 64 bit heap size change.
Review URL: http://codereview.chromium.org/3432032
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5543 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-28 11:44:30 +00:00
erik.corry@gmail.com
f1635606df
Use intptr_t instead of int for heap sizes. This is a step towards
...
removing the 1Gbyte limit.
Review URL: http://codereview.chromium.org/3418035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5542 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-28 10:35:47 +00:00