AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
0a01afda76
v8/test/cctest
History
marja@chromium.org 0a01afda76 Re-enable Parser::symbol_cache_ (after a long time!) 
The Parser never used the symbol stream produced by the PreParser for anything
useful, due to a bug introduced 3.5 years ago by
https://codereview.chromium.org/3356010/diff/7001/src/parser.cc.

The bug is that calling Initialize on symbol_cache_ doesn't change its
length. So the length remains 0, and the "if" in Parser::LookupSymbol is always
true, and Parser::LookupCachedSymbol is never called and symbol_cache_ never
filled.

This bug also masked a bug that the symbol stream produced by PreParser doesn't
match what Parser wants to consume. The repro case is the following:

var myo = {if: 4}; print(myo.if);

PreParser doesn't log a symbol for the first "if", but in the corresponding
place, Parser consumes one symbol from the symbol stream. Since the consumed
symbols were never really used, this mismatch went unnoticed.

This CL also fixes that bug.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/172753002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19505 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-20 11:35:37 +00:00
..
cctest.cc Fixed a few lifetime/ownership issues in cctest/test-api. 2014-01-31 07:29:25 +00:00
cctest.gyp A64 support for DoubleToIStub (truncating). 2014-02-17 15:09:46 +00:00
cctest.h Re-enable Parser::symbol_cache_ (after a long time!) 2014-02-20 11:35:37 +00:00
cctest.status Enable test-api/SetFunctionEntryHook for a64. It was fixed in r19297. 2014-02-13 10:56:10 +00:00
gay-fixed.cc Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
gay-fixed.h Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
gay-precision.cc Added precision mode to fast-dtoa. 2010-09-20 09:18:00 +00:00
gay-precision.h Added precision mode to fast-dtoa. 2010-09-20 09:18:00 +00:00
gay-shortest.cc Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
gay-shortest.h Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
log-eq-of-logging-and-traversal.js Fix test-log/EquivalenceOfLoggingAndTraversal 2013-08-26 14:56:23 +00:00
OWNERS Add per-file OWNERS for MIPS-specific cctests 2014-02-04 09:53:26 +00:00
print-extension.cc Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
print-extension.h Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
profiler-extension.cc Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
profiler-extension.h Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
test-accessors.cc api accessor store ics should return passed value 2014-02-14 14:13:06 +00:00
test-alloc.cc Remove Heap::MaxRegularSpaceAllocationSize and use Page::MaxRegularHeapObjectSize instead. 2014-01-23 13:02:27 +00:00
test-api.cc Upgrade Symbol implementation to match current ES6 behavior. 2014-02-19 14:19:42 +00:00
test-assembler-a64.cc A64: Introduce 'branch types' that extend the architectural conditions. 2014-02-19 16:13:09 +00:00
test-assembler-arm.cc ARM: Optimize truncating division and fix sim 2014-01-02 16:36:21 +00:00
test-assembler-ia32.cc Prepare removal of ObjectTemplate::New without Isolate parameter. 2014-01-08 06:53:31 +00:00
test-assembler-mips.cc MIPS: Fix test-assembler-mips/MIPS10 test. 2014-02-04 14:05:46 +00:00
test-assembler-x64.cc Win64 fixes. 2014-02-07 07:44:19 +00:00
test-ast.cc Zonify types in compiler frontend 2014-01-21 16:22:52 +00:00
test-bignum-dtoa.cc Fix X64 compilation on Windows. 2011-02-03 11:13:04 +00:00
test-bignum.cc Bignum implementation of Strtod. 2010-11-08 11:49:47 +00:00
test-circular-queue.cc Rename some of SamplingCircularQueue methods 2013-09-05 10:31:18 +00:00
test-code-stubs-a64.cc A64: Tidy up Push and Pop TODOs. 2014-02-19 09:43:45 +00:00
test-code-stubs-arm.cc Drop IsPregenerated() and allow_stub_calls flag. 2013-11-29 20:49:15 +00:00
test-code-stubs-ia32.cc Drop IsPregenerated() and allow_stub_calls flag. 2013-11-29 20:49:15 +00:00
test-code-stubs-mips.cc MIPS: Add missing cctests of DoubleToIStub (r16322). 2014-01-22 13:44:00 +00:00
test-code-stubs-x64.cc Drop IsPregenerated() and allow_stub_calls flag. 2013-11-29 20:49:15 +00:00
test-code-stubs.cc A64 support for DoubleToIStub (truncating). 2014-02-17 15:09:46 +00:00
test-code-stubs.h Arm support for DoubleToIStub (truncating). 2013-08-26 12:24:03 +00:00
test-compiler.cc Update Isolate::RequestGarbageCollection after r18691 2014-01-20 15:44:03 +00:00
test-condition-variable.cc Improve cctest/test-condition-variable. 2013-09-03 11:27:02 +00:00
test-constantpool.cc Out-of-line constant pool on Arm: Stage 2 - Introduce ConstantPoolArray object. 2013-10-14 13:35:06 +00:00
test-conversions.cc Add support for explicit octal and binary integer literals 2013-07-19 09:57:35 +00:00
test-cpu-ia32.cc Fix the CPU feature detection. 2013-08-26 09:37:39 +00:00
test-cpu-profiler.cc Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
test-cpu-x64.cc Fix the CPU feature detection. 2013-08-26 09:37:39 +00:00
test-cpu.cc Replace OS::NumberOfCores() with CPU::NumberOfProcessorsOnline(). 2013-08-28 12:32:56 +00:00
test-dataflow.cc bulk replace Isolate::Current in tests 2013-09-19 09:17:13 +00:00
test-date.cc bulk replace Isolate::Current in tests 2013-09-19 09:17:13 +00:00
test-debug.cc Remove CallICs 2014-01-31 16:52:17 +00:00
test-declarative-accessors.cc Revert r18451 "Revert r18449 "Reland r18383: More API cleanup." and r18450 "Unbreak build."" since necessary WebKit changes are rolled in Chromium. 2014-01-03 14:31:17 +00:00
test-decls.cc Revert r18451 "Revert r18449 "Reland r18383: More API cleanup." and r18450 "Unbreak build."" since necessary WebKit changes are rolled in Chromium. 2014-01-03 14:31:17 +00:00
test-deoptimization.cc Allow map check hoisting in GVN for stable maps. 2014-02-13 10:47:00 +00:00
test-dictionary.cc Remove calls to JSObject::SetLocalPropertyIgnoreAttributesTrampoline within objects.cc 2013-11-05 11:47:11 +00:00
test-disasm-a64.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-disasm-arm.cc bulk replace Isolate::Current in tests 2013-09-19 09:17:13 +00:00
test-disasm-ia32.cc [x64] add disasm for two fp instructions 2014-02-03 08:13:12 +00:00
test-disasm-mips.cc bulk replace Isolate::Current in tests 2013-09-19 09:17:13 +00:00
test-disasm-x64.cc [x64] add disasm for two fp instructions 2014-02-03 08:13:12 +00:00
test-diy-fp.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-double.cc Keep two empty lines between declarations for cpp files 2013-07-05 09:52:11 +00:00
test-dtoa.cc Fix compilation on 64-bit Windows, update Visual Studio projects. 2011-02-03 13:29:10 +00:00
test-fast-dtoa.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-fixed-dtoa.cc Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
test-flags.cc Add flags to force or prevent setting of isolate.is_memory_constrained. 2013-09-17 13:48:17 +00:00
test-func-name-inference.cc Replace 'operator*' with explicit 'get' method on SmartPointer 2013-12-09 07:41:20 +00:00
test-fuzz-a64.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-global-handles.cc Make LeakSanitizer happy, part 2. Fixed register usage on the way. 2014-02-07 07:06:13 +00:00
test-global-object.cc Revert r18451 "Revert r18449 "Reland r18383: More API cleanup." and r18450 "Unbreak build."" since necessary WebKit changes are rolled in Chromium. 2014-01-03 14:31:17 +00:00
test-hashing.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-hashmap.cc Make the hash map test run faster by doing less work. 2009-05-15 13:49:00 +00:00
test-heap-profiler.cc DevTools: Drop kSinTable dependency off the heap profiler ArrayBuffer backing_store test 2014-02-18 15:57:44 +00:00
test-heap.cc Revert "Second attempt at introducing a premonomorphic state in the call" 2014-02-19 13:55:25 +00:00
test-javascript-a64.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-js-a64-variables.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-libplatform-task-queue.cc [platform] Implement a worker pool 2013-12-20 07:52:58 +00:00
test-libplatform-worker-thread.cc [platform] Implement a worker pool 2013-12-20 07:52:58 +00:00
test-libplatform.h [platform] Implement a worker pool 2013-12-20 07:52:58 +00:00
test-list.cc revert thread isolate in PreallocatedStorageAllocationPolicy 2013-09-02 11:39:23 +00:00
test-liveedit.cc bulk replace Isolate::Current in tests 2013-09-19 09:17:13 +00:00
test-lockers.cc Remove usage of deprecated APIs from cctests 2013-11-22 12:43:17 +00:00
test-log-stack-tracer.cc Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
test-log.cc Make LeakSanitizer happy, part 1. 2014-02-06 07:16:41 +00:00
test-macro-assembler-arm.cc Drop IsPregenerated() and allow_stub_calls flag. 2013-11-29 20:49:15 +00:00
test-macro-assembler-ia32.cc Drop IsPregenerated() and allow_stub_calls flag. 2013-11-29 20:49:15 +00:00
test-macro-assembler-mips.cc MIPS: Add NaN test to cctest/test-macro-assembler-mips. 2014-02-10 19:46:34 +00:00
test-macro-assembler-x64.cc Make LeakSanitizer happy, part 1. 2014-02-06 07:16:41 +00:00
test-mark-compact.cc Disable concurrent osr for test-mark-compact/BootUpMemoryUse. 2014-02-11 11:47:38 +00:00
test-mementos.cc Add filler at the new space top when forcing scavenge. 2014-02-18 16:34:52 +00:00
test-microtask-delivery.cc V8 Microtask Queue & API 2014-02-12 22:04:19 +00:00
test-mutex.cc Cleanup Mutex and related classes. 2013-08-29 09:58:30 +00:00
test-object-observe.cc Prepare removal of ObjectTemplate::New without Isolate parameter. 2014-01-08 06:53:31 +00:00
test-parsing.cc Re-enable Parser::symbol_cache_ (after a long time!) 2014-02-20 11:35:37 +00:00
test-platform-linux.cc Revert r16648, r16641, r16638 and r16637. 2013-09-11 18:30:01 +00:00
test-platform-macos.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-platform-tls.cc Keep two empty lines between declarations for cpp files 2013-07-05 09:52:11 +00:00
test-platform-win32.cc Revert r16648, r16641, r16638 and r16637. 2013-09-11 18:30:01 +00:00
test-platform.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-profile-generator.cc Make LeakSanitizer happy, part 1. 2014-02-06 07:16:41 +00:00
test-random-number-generator.cc Fix clang C++11 compiler warning. 2013-09-10 13:39:53 +00:00
test-regexp.cc Merge experimental/a64 to bleeding_edge. 2014-02-12 09:19:30 +00:00
test-reloc-info.cc Replace 'operator*' with explicit 'get' method on SmartPointer 2013-12-09 07:41:20 +00:00
test-representation.cc Generate TypedArrayInitialize builtin in hydrogen. 2013-11-25 14:41:46 +00:00
test-semaphore.cc Fix Mac llvm-gcc42 build after commit r16473. 2013-09-02 12:36:08 +00:00
test-serialize.cc Remove usage of deprecated APIs from cctests 2013-11-22 12:43:17 +00:00
test-socket.cc Cleanup Socket class and remove it from the platform files. 2013-09-04 10:41:51 +00:00
test-spaces.cc Remove Heap::MaxRegularSpaceAllocationSize and use Page::MaxRegularHeapObjectSize instead. 2014-01-23 13:02:27 +00:00
test-strings.cc More cctest fixes regarding lifetime/ownership. 2014-02-03 07:29:23 +00:00
test-strtod.cc Fix MSVC compiler warning after commit r16612. 2013-09-10 11:33:14 +00:00
test-symbols.cc Add filler at the new space top when forcing scavenge. 2014-02-18 16:34:52 +00:00
test-thread-termination.cc Prepare removal of ObjectTemplate::New without Isolate parameter. 2014-01-08 06:53:31 +00:00
test-threads.cc Make LeakSanitizer happy, part 1. 2014-02-06 07:16:41 +00:00
test-time.cc Use std:: on symbols declared in C++-style C headers. 2014-01-14 09:57:05 +00:00
test-types.cc don't anger clang 2014-01-27 10:06:37 +00:00
test-unbound-queue.cc Make sure files end with exactly one new line and police this in presubmit. 2013-11-22 13:50:39 +00:00
test-unique.cc Make sure files end with exactly one new line and police this in presubmit. 2013-11-22 13:50:39 +00:00
test-utils-a64.cc make a64 compile on mavericks - part 1 2014-02-17 15:20:54 +00:00
test-utils-a64.h make a64 compile on mavericks - part 1 2014-02-17 15:20:54 +00:00
test-utils.cc Remove unused function MoveBytes(). 2013-10-28 09:59:15 +00:00
test-version.cc Update V8 to version 3.0 (re-land r5920). 2010-12-07 11:31:57 +00:00
test-weakmaps.cc Remove all stuff marked as V8_DEPRECATED. 2013-12-18 08:09:37 +00:00
test-weaksets.cc Remove all stuff marked as V8_DEPRECATED. 2013-12-18 08:09:37 +00:00
test-weaktypedarrays.cc Mark deprecated APIs with relatively little use as deprecated 2013-11-28 08:21:26 +00:00
testcfg.py Remove SCons related files 2013-04-18 11:01:14 +00:00
trace-extension.cc Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00
trace-extension.h Various extension-related cleanup and simplifications. 2014-01-17 10:52:00 +00:00