fffae64444
Client isolates that tear down only participate in the safepointing protocol to remove themselves from the list of all clients without blacking global safepoints. However, we do not need to consider them for the root set since such isolates will just detach as soon as possible and therefore are not allowed to touch the shared heap anymore anyways. This fixes a heap verification bug where heap verification fails for an isolate that tears down fails because the external string table was already finalized. We also can't move external string table finalization after detaching since then we would have races on the shared external pointer table. Bug: v8:13267, chromium:1401078 Change-Id: I7d97c2d223bd87f620d9a92a9266be7b88afd9c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4110857 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#84870} |
||
---|---|---|
.. | ||
base | ||
cppgc | ||
cppgc-js | ||
allocation-observer-unittest.cc | ||
bitmap-test-utils.h | ||
bitmap-unittest.cc | ||
code-object-registry-unittest.cc | ||
conservative-stack-visitor-unittest.cc | ||
embedder-tracing-unittest.cc | ||
gc-idle-time-handler-unittest.cc | ||
gc-tracer-unittest.cc | ||
global-handles-unittest.cc | ||
global-safepoint-unittest.cc | ||
heap-controller-unittest.cc | ||
heap-unittest.cc | ||
heap-utils.cc | ||
heap-utils.h | ||
index-generator-unittest.cc | ||
lab-unittest.cc | ||
list-unittest.cc | ||
local-factory-unittest.cc | ||
local-handles-unittest.cc | ||
local-heap-unittest.cc | ||
marking-inner-pointer-resolution-unittest.cc | ||
marking-unittest.cc | ||
marking-worklist-unittest.cc | ||
memory-reducer-unittest.cc | ||
object-start-bitmap-unittest.cc | ||
object-stats-unittest.cc | ||
page-promotion-unittest.cc | ||
persistent-handles-unittest.cc | ||
progressbar-unittest.cc | ||
safepoint-unittest.cc | ||
shared-heap-unittest.cc | ||
slot-set-unittest.cc | ||
spaces-unittest.cc | ||
unmapper-unittest.cc |