2017-08-18 23:52:05 +00:00
|
|
|
/*
|
2016-08-30 17:04:33 +00:00
|
|
|
* Copyright (c) 2016-present, Yann Collet, Facebook, Inc.
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
2017-08-18 23:52:05 +00:00
|
|
|
* This source code is licensed under both the BSD-style license (found in the
|
|
|
|
* LICENSE file in the root directory of this source tree) and the GPLv2 (found
|
|
|
|
* in the COPYING file in the root directory of this source tree).
|
2017-09-08 07:09:23 +00:00
|
|
|
* You may select, at your option, one of the above-listed licenses.
|
2016-08-30 17:04:33 +00:00
|
|
|
*/
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
|
2016-07-06 14:12:38 +00:00
|
|
|
/*-**************************************
|
|
|
|
* Tuning parameters
|
|
|
|
****************************************/
|
2017-03-24 22:02:09 +00:00
|
|
|
#define MINRATIO 4 /* minimum nb of apparition to be selected in dictionary */
|
2016-07-06 14:25:46 +00:00
|
|
|
#define ZDICT_MAX_SAMPLES_SIZE (2000U << 20)
|
2017-03-24 22:02:09 +00:00
|
|
|
#define ZDICT_MIN_SAMPLES_SIZE (ZDICT_CONTENTSIZE_MIN * MINRATIO)
|
2016-07-06 14:12:38 +00:00
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
/*-**************************************
|
2016-01-27 23:29:58 +00:00
|
|
|
* Compiler Options
|
|
|
|
****************************************/
|
|
|
|
/* Unix Large Files support (>4GB) */
|
|
|
|
#define _FILE_OFFSET_BITS 64
|
|
|
|
#if (defined(__sun__) && (!defined(__LP64__))) /* Sun Solaris 32-bits requires specific definitions */
|
|
|
|
# define _LARGEFILE_SOURCE
|
|
|
|
#elif ! defined(__LP64__) /* No point defining Large file for 64 bit */
|
|
|
|
# define _LARGEFILE64_SOURCE
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
2016-01-28 16:56:33 +00:00
|
|
|
/*-*************************************
|
2016-02-11 23:07:30 +00:00
|
|
|
* Dependencies
|
2016-01-27 23:29:58 +00:00
|
|
|
***************************************/
|
2016-01-31 22:45:35 +00:00
|
|
|
#include <stdlib.h> /* malloc, free */
|
|
|
|
#include <string.h> /* memset */
|
|
|
|
#include <stdio.h> /* fprintf, fopen, ftello64 */
|
|
|
|
#include <time.h> /* clock */
|
|
|
|
|
|
|
|
#include "mem.h" /* read */
|
2016-07-06 10:35:09 +00:00
|
|
|
#include "fse.h" /* FSE_normalizeCount, FSE_writeNCount */
|
2016-06-04 22:42:28 +00:00
|
|
|
#define HUF_STATIC_LINKING_ONLY
|
2016-12-17 15:28:12 +00:00
|
|
|
#include "huf.h" /* HUF_buildCTable, HUF_writeCTable */
|
2016-06-04 18:17:38 +00:00
|
|
|
#include "zstd_internal.h" /* includes zstd.h */
|
2016-12-17 15:28:12 +00:00
|
|
|
#include "xxhash.h" /* XXH64 */
|
2016-02-12 17:45:02 +00:00
|
|
|
#include "divsufsort.h"
|
2016-07-06 10:35:09 +00:00
|
|
|
#ifndef ZDICT_STATIC_LINKING_ONLY
|
|
|
|
# define ZDICT_STATIC_LINKING_ONLY
|
|
|
|
#endif
|
2016-06-04 16:56:23 +00:00
|
|
|
#include "zdict.h"
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
|
2016-01-28 16:56:33 +00:00
|
|
|
/*-*************************************
|
2016-01-27 23:29:58 +00:00
|
|
|
* Constants
|
|
|
|
***************************************/
|
|
|
|
#define KB *(1 <<10)
|
|
|
|
#define MB *(1 <<20)
|
|
|
|
#define GB *(1U<<30)
|
|
|
|
|
2016-08-30 16:56:25 +00:00
|
|
|
#define DICTLISTSIZE_DEFAULT 10000
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
#define NOISELENGTH 32
|
|
|
|
|
2017-08-24 21:45:06 +00:00
|
|
|
static const int g_compressionLevel_default = 3;
|
2016-01-31 22:45:35 +00:00
|
|
|
static const U32 g_selectivity_default = 9;
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
|
2016-01-28 16:56:33 +00:00
|
|
|
/*-*************************************
|
|
|
|
* Console display
|
2016-01-27 23:29:58 +00:00
|
|
|
***************************************/
|
2016-07-06 10:35:09 +00:00
|
|
|
#define DISPLAY(...) { fprintf(stderr, __VA_ARGS__); fflush( stderr ); }
|
2016-09-03 00:28:41 +00:00
|
|
|
#define DISPLAYLEVEL(l, ...) if (notificationLevel>=l) { DISPLAY(__VA_ARGS__); } /* 0 : no display; 1: errors; 2: default; 3: details; 4: debug */
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-07-06 11:13:12 +00:00
|
|
|
static clock_t ZDICT_clockSpan(clock_t nPrevious) { return clock() - nPrevious; }
|
|
|
|
|
2016-09-03 00:28:41 +00:00
|
|
|
static void ZDICT_printHex(const void* ptr, size_t length)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
const BYTE* const b = (const BYTE*)ptr;
|
|
|
|
size_t u;
|
2016-05-29 03:01:04 +00:00
|
|
|
for (u=0; u<length; u++) {
|
2016-01-27 23:29:58 +00:00
|
|
|
BYTE c = b[u];
|
|
|
|
if (c<32 || c>126) c = '.'; /* non-printable char */
|
2016-09-03 00:28:41 +00:00
|
|
|
DISPLAY("%c", c);
|
2016-01-27 23:29:58 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
/*-********************************************************
|
2016-01-27 23:29:58 +00:00
|
|
|
* Helper functions
|
|
|
|
**********************************************************/
|
2016-02-11 23:07:30 +00:00
|
|
|
unsigned ZDICT_isError(size_t errorCode) { return ERR_isError(errorCode); }
|
2016-01-31 22:45:35 +00:00
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
const char* ZDICT_getErrorName(size_t errorCode) { return ERR_getErrorName(errorCode); }
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-08-19 12:23:58 +00:00
|
|
|
unsigned ZDICT_getDictID(const void* dictBuffer, size_t dictSize)
|
|
|
|
{
|
|
|
|
if (dictSize < 8) return 0;
|
2017-06-27 20:50:34 +00:00
|
|
|
if (MEM_readLE32(dictBuffer) != ZSTD_MAGIC_DICTIONARY) return 0;
|
2016-08-19 12:23:58 +00:00
|
|
|
return MEM_readLE32((const char*)dictBuffer + 4);
|
|
|
|
}
|
|
|
|
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/*-********************************************************
|
|
|
|
* Dictionary training functions
|
|
|
|
**********************************************************/
|
2017-12-05 01:57:42 +00:00
|
|
|
static unsigned ZDICT_NbCommonBytes (size_t val)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
if (MEM_isLittleEndian()) {
|
|
|
|
if (MEM_64bits()) {
|
|
|
|
# if defined(_MSC_VER) && defined(_WIN64)
|
|
|
|
unsigned long r = 0;
|
|
|
|
_BitScanForward64( &r, (U64)val );
|
|
|
|
return (unsigned)(r>>3);
|
|
|
|
# elif defined(__GNUC__) && (__GNUC__ >= 3)
|
|
|
|
return (__builtin_ctzll((U64)val) >> 3);
|
|
|
|
# else
|
|
|
|
static const int DeBruijnBytePos[64] = { 0, 0, 0, 0, 0, 1, 1, 2, 0, 3, 1, 3, 1, 4, 2, 7, 0, 2, 3, 6, 1, 5, 3, 5, 1, 3, 4, 4, 2, 5, 6, 7, 7, 0, 1, 2, 3, 3, 4, 6, 2, 6, 5, 5, 3, 4, 5, 6, 7, 1, 2, 4, 6, 4, 4, 5, 7, 2, 6, 5, 7, 6, 7, 7 };
|
|
|
|
return DeBruijnBytePos[((U64)((val & -(long long)val) * 0x0218A392CDABBD3FULL)) >> 58];
|
|
|
|
# endif
|
|
|
|
} else { /* 32 bits */
|
|
|
|
# if defined(_MSC_VER)
|
|
|
|
unsigned long r=0;
|
|
|
|
_BitScanForward( &r, (U32)val );
|
|
|
|
return (unsigned)(r>>3);
|
|
|
|
# elif defined(__GNUC__) && (__GNUC__ >= 3)
|
|
|
|
return (__builtin_ctz((U32)val) >> 3);
|
|
|
|
# else
|
|
|
|
static const int DeBruijnBytePos[32] = { 0, 0, 3, 0, 3, 1, 3, 0, 3, 2, 2, 1, 3, 2, 0, 1, 3, 3, 1, 2, 2, 2, 2, 0, 3, 1, 2, 0, 1, 0, 1, 1 };
|
|
|
|
return DeBruijnBytePos[((U32)((val & -(S32)val) * 0x077CB531U)) >> 27];
|
|
|
|
# endif
|
|
|
|
}
|
|
|
|
} else { /* Big Endian CPU */
|
|
|
|
if (MEM_64bits()) {
|
|
|
|
# if defined(_MSC_VER) && defined(_WIN64)
|
|
|
|
unsigned long r = 0;
|
|
|
|
_BitScanReverse64( &r, val );
|
|
|
|
return (unsigned)(r>>3);
|
|
|
|
# elif defined(__GNUC__) && (__GNUC__ >= 3)
|
|
|
|
return (__builtin_clzll(val) >> 3);
|
|
|
|
# else
|
|
|
|
unsigned r;
|
|
|
|
const unsigned n32 = sizeof(size_t)*4; /* calculate this way due to compiler complaining in 32-bits mode */
|
|
|
|
if (!(val>>n32)) { r=4; } else { r=0; val>>=n32; }
|
|
|
|
if (!(val>>16)) { r+=2; val>>=8; } else { val>>=24; }
|
|
|
|
r += (!val);
|
|
|
|
return r;
|
|
|
|
# endif
|
|
|
|
} else { /* 32 bits */
|
|
|
|
# if defined(_MSC_VER)
|
|
|
|
unsigned long r = 0;
|
|
|
|
_BitScanReverse( &r, (unsigned long)val );
|
|
|
|
return (unsigned)(r>>3);
|
|
|
|
# elif defined(__GNUC__) && (__GNUC__ >= 3)
|
|
|
|
return (__builtin_clz((U32)val) >> 3);
|
|
|
|
# else
|
|
|
|
unsigned r;
|
|
|
|
if (!(val>>16)) { r=2; val>>=8; } else { r=0; val>>=24; }
|
|
|
|
r += (!val);
|
|
|
|
return r;
|
|
|
|
# endif
|
|
|
|
} }
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
/*! ZDICT_count() :
|
2016-01-27 23:29:58 +00:00
|
|
|
Count the nb of common bytes between 2 pointers.
|
|
|
|
Note : this function presumes end of buffer followed by noisy guard band.
|
|
|
|
*/
|
2016-02-11 23:07:30 +00:00
|
|
|
static size_t ZDICT_count(const void* pIn, const void* pMatch)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
const char* const pStart = (const char*)pIn;
|
|
|
|
for (;;) {
|
2016-05-29 03:01:04 +00:00
|
|
|
size_t const diff = MEM_readST(pMatch) ^ MEM_readST(pIn);
|
|
|
|
if (!diff) {
|
|
|
|
pIn = (const char*)pIn+sizeof(size_t);
|
|
|
|
pMatch = (const char*)pMatch+sizeof(size_t);
|
|
|
|
continue;
|
|
|
|
}
|
2016-02-11 23:07:30 +00:00
|
|
|
pIn = (const char*)pIn+ZDICT_NbCommonBytes(diff);
|
2016-01-27 23:29:58 +00:00
|
|
|
return (size_t)((const char*)pIn - pStart);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
typedef struct {
|
|
|
|
U32 pos;
|
|
|
|
U32 length;
|
|
|
|
U32 savings;
|
|
|
|
} dictItem;
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
static void ZDICT_initDictItem(dictItem* d)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
d->pos = 1;
|
|
|
|
d->length = 0;
|
|
|
|
d->savings = (U32)(-1);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
#define LLIMIT 64 /* heuristic determined experimentally */
|
|
|
|
#define MINMATCHLENGTH 7 /* heuristic determined experimentally */
|
2016-02-11 23:07:30 +00:00
|
|
|
static dictItem ZDICT_analyzePos(
|
2016-01-27 23:29:58 +00:00
|
|
|
BYTE* doneMarks,
|
2016-02-11 23:07:30 +00:00
|
|
|
const int* suffix, U32 start,
|
2016-09-03 00:28:41 +00:00
|
|
|
const void* buffer, U32 minRatio, U32 notificationLevel)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
U32 lengthList[LLIMIT] = {0};
|
|
|
|
U32 cumulLength[LLIMIT] = {0};
|
|
|
|
U32 savings[LLIMIT] = {0};
|
|
|
|
const BYTE* b = (const BYTE*)buffer;
|
|
|
|
size_t maxLength = LLIMIT;
|
|
|
|
size_t pos = suffix[start];
|
|
|
|
U32 end = start;
|
|
|
|
dictItem solution;
|
|
|
|
|
|
|
|
/* init */
|
|
|
|
memset(&solution, 0, sizeof(solution));
|
|
|
|
doneMarks[pos] = 1;
|
|
|
|
|
|
|
|
/* trivial repetition cases */
|
|
|
|
if ( (MEM_read16(b+pos+0) == MEM_read16(b+pos+2))
|
|
|
|
||(MEM_read16(b+pos+1) == MEM_read16(b+pos+3))
|
|
|
|
||(MEM_read16(b+pos+2) == MEM_read16(b+pos+4)) ) {
|
|
|
|
/* skip and mark segment */
|
2018-01-11 17:42:38 +00:00
|
|
|
U16 const pattern16 = MEM_read16(b+pos+4);
|
|
|
|
U32 u, patternEnd = 6;
|
|
|
|
while (MEM_read16(b+pos+patternEnd) == pattern16) patternEnd+=2 ;
|
|
|
|
if (b[pos+patternEnd] == b[pos+patternEnd-1]) patternEnd++;
|
|
|
|
for (u=1; u<patternEnd; u++)
|
2016-01-27 23:29:58 +00:00
|
|
|
doneMarks[pos+u] = 1;
|
|
|
|
return solution;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* look forward */
|
2018-01-11 17:42:38 +00:00
|
|
|
{ size_t length;
|
|
|
|
do {
|
|
|
|
end++;
|
|
|
|
length = ZDICT_count(b + pos, b + suffix[end]);
|
|
|
|
} while (length >= MINMATCHLENGTH);
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* look backward */
|
2018-01-11 17:42:38 +00:00
|
|
|
{ size_t length;
|
|
|
|
do {
|
|
|
|
length = ZDICT_count(b + pos, b + *(suffix+start-1));
|
|
|
|
if (length >=MINMATCHLENGTH) start--;
|
|
|
|
} while(length >= MINMATCHLENGTH);
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* exit if not found a minimum nb of repetitions */
|
|
|
|
if (end-start < minRatio) {
|
|
|
|
U32 idx;
|
|
|
|
for(idx=start; idx<end; idx++)
|
|
|
|
doneMarks[suffix[idx]] = 1;
|
|
|
|
return solution;
|
|
|
|
}
|
|
|
|
|
2016-03-20 18:14:22 +00:00
|
|
|
{ int i;
|
2018-11-20 23:13:27 +00:00
|
|
|
U32 mml;
|
2016-01-27 23:29:58 +00:00
|
|
|
U32 refinedStart = start;
|
|
|
|
U32 refinedEnd = end;
|
|
|
|
|
|
|
|
DISPLAYLEVEL(4, "\n");
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAYLEVEL(4, "found %3u matches of length >= %i at pos %7u ", (unsigned)(end-start), MINMATCHLENGTH, (unsigned)pos);
|
2016-01-27 23:29:58 +00:00
|
|
|
DISPLAYLEVEL(4, "\n");
|
|
|
|
|
2018-11-20 23:13:27 +00:00
|
|
|
for (mml = MINMATCHLENGTH ; ; mml++) {
|
2016-01-27 23:29:58 +00:00
|
|
|
BYTE currentChar = 0;
|
|
|
|
U32 currentCount = 0;
|
|
|
|
U32 currentID = refinedStart;
|
|
|
|
U32 id;
|
|
|
|
U32 selectedCount = 0;
|
|
|
|
U32 selectedID = currentID;
|
|
|
|
for (id =refinedStart; id < refinedEnd; id++) {
|
2018-11-20 23:13:27 +00:00
|
|
|
if (b[suffix[id] + mml] != currentChar) {
|
2016-01-27 23:29:58 +00:00
|
|
|
if (currentCount > selectedCount) {
|
|
|
|
selectedCount = currentCount;
|
|
|
|
selectedID = currentID;
|
|
|
|
}
|
|
|
|
currentID = id;
|
2018-11-20 23:13:27 +00:00
|
|
|
currentChar = b[ suffix[id] + mml];
|
2016-01-27 23:29:58 +00:00
|
|
|
currentCount = 0;
|
|
|
|
}
|
|
|
|
currentCount ++;
|
|
|
|
}
|
|
|
|
if (currentCount > selectedCount) { /* for last */
|
|
|
|
selectedCount = currentCount;
|
|
|
|
selectedID = currentID;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (selectedCount < minRatio)
|
|
|
|
break;
|
|
|
|
refinedStart = selectedID;
|
|
|
|
refinedEnd = refinedStart + selectedCount;
|
|
|
|
}
|
|
|
|
|
2018-07-31 20:58:54 +00:00
|
|
|
/* evaluate gain based on new dict */
|
2016-01-27 23:29:58 +00:00
|
|
|
start = refinedStart;
|
|
|
|
pos = suffix[refinedStart];
|
|
|
|
end = start;
|
|
|
|
memset(lengthList, 0, sizeof(lengthList));
|
|
|
|
|
|
|
|
/* look forward */
|
2018-01-11 17:42:38 +00:00
|
|
|
{ size_t length;
|
|
|
|
do {
|
|
|
|
end++;
|
|
|
|
length = ZDICT_count(b + pos, b + suffix[end]);
|
|
|
|
if (length >= LLIMIT) length = LLIMIT-1;
|
|
|
|
lengthList[length]++;
|
|
|
|
} while (length >=MINMATCHLENGTH);
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* look backward */
|
2018-01-11 17:42:38 +00:00
|
|
|
{ size_t length = MINMATCHLENGTH;
|
|
|
|
while ((length >= MINMATCHLENGTH) & (start > 0)) {
|
|
|
|
length = ZDICT_count(b + pos, b + suffix[start - 1]);
|
|
|
|
if (length >= LLIMIT) length = LLIMIT - 1;
|
|
|
|
lengthList[length]++;
|
|
|
|
if (length >= MINMATCHLENGTH) start--;
|
|
|
|
}
|
2016-12-21 18:25:15 +00:00
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* largest useful length */
|
|
|
|
memset(cumulLength, 0, sizeof(cumulLength));
|
|
|
|
cumulLength[maxLength-1] = lengthList[maxLength-1];
|
2016-01-28 14:39:52 +00:00
|
|
|
for (i=(int)(maxLength-2); i>=0; i--)
|
2016-01-27 23:29:58 +00:00
|
|
|
cumulLength[i] = cumulLength[i+1] + lengthList[i];
|
|
|
|
|
|
|
|
for (i=LLIMIT-1; i>=MINMATCHLENGTH; i--) if (cumulLength[i]>=minRatio) break;
|
|
|
|
maxLength = i;
|
|
|
|
|
|
|
|
/* reduce maxLength in case of final into repetitive data */
|
2016-05-29 03:01:04 +00:00
|
|
|
{ U32 l = (U32)maxLength;
|
|
|
|
BYTE const c = b[pos + maxLength-1];
|
2016-01-27 23:29:58 +00:00
|
|
|
while (b[pos+l-2]==c) l--;
|
|
|
|
maxLength = l;
|
|
|
|
}
|
|
|
|
if (maxLength < MINMATCHLENGTH) return solution; /* skip : no long-enough solution */
|
|
|
|
|
|
|
|
/* calculate savings */
|
|
|
|
savings[5] = 0;
|
|
|
|
for (i=MINMATCHLENGTH; i<=(int)maxLength; i++)
|
|
|
|
savings[i] = savings[i-1] + (lengthList[i] * (i-3));
|
|
|
|
|
2018-07-31 20:58:54 +00:00
|
|
|
DISPLAYLEVEL(4, "Selected dict at position %u, of length %u : saves %u (ratio: %.2f) \n",
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
(unsigned)pos, (unsigned)maxLength, (unsigned)savings[maxLength], (double)savings[maxLength] / maxLength);
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-01-28 14:39:52 +00:00
|
|
|
solution.pos = (U32)pos;
|
|
|
|
solution.length = (U32)maxLength;
|
2016-01-27 23:29:58 +00:00
|
|
|
solution.savings = savings[maxLength];
|
|
|
|
|
|
|
|
/* mark positions done */
|
2016-05-29 03:01:04 +00:00
|
|
|
{ U32 id;
|
2016-01-27 23:29:58 +00:00
|
|
|
for (id=start; id<end; id++) {
|
2018-01-11 17:42:38 +00:00
|
|
|
U32 p, pEnd, length;
|
2016-05-29 03:01:04 +00:00
|
|
|
U32 const testedPos = suffix[id];
|
2016-01-27 23:29:58 +00:00
|
|
|
if (testedPos == pos)
|
|
|
|
length = solution.length;
|
|
|
|
else {
|
2018-01-11 17:42:38 +00:00
|
|
|
length = (U32)ZDICT_count(b+pos, b+testedPos);
|
2016-01-27 23:29:58 +00:00
|
|
|
if (length > solution.length) length = solution.length;
|
|
|
|
}
|
2016-01-28 14:39:52 +00:00
|
|
|
pEnd = (U32)(testedPos + length);
|
2016-01-27 23:29:58 +00:00
|
|
|
for (p=testedPos; p<pEnd; p++)
|
|
|
|
doneMarks[p] = 1;
|
|
|
|
} } }
|
|
|
|
|
|
|
|
return solution;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-03-25 00:56:45 +00:00
|
|
|
static int isIncluded(const void* in, const void* container, size_t length)
|
|
|
|
{
|
|
|
|
const char* const ip = (const char*) in;
|
|
|
|
const char* const into = (const char*) container;
|
|
|
|
size_t u;
|
|
|
|
|
2017-03-26 21:39:13 +00:00
|
|
|
for (u=0; u<length; u++) { /* works because end of buffer is a noisy guard band */
|
2017-03-25 00:56:45 +00:00
|
|
|
if (ip[u] != into[u]) break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return u==length;
|
|
|
|
}
|
|
|
|
|
2017-09-14 22:12:57 +00:00
|
|
|
/*! ZDICT_tryMerge() :
|
2016-01-27 23:29:58 +00:00
|
|
|
check if dictItem can be merged, do it if possible
|
|
|
|
@return : id of destination elt, 0 if not merged
|
|
|
|
*/
|
2017-03-26 21:39:13 +00:00
|
|
|
static U32 ZDICT_tryMerge(dictItem* table, dictItem elt, U32 eltNbToSkip, const void* buffer)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
const U32 tableSize = table->pos;
|
2016-10-18 23:34:58 +00:00
|
|
|
const U32 eltEnd = elt.pos + elt.length;
|
2017-03-26 07:59:14 +00:00
|
|
|
const char* const buf = (const char*) buffer;
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* tail overlap */
|
|
|
|
U32 u; for (u=1; u<tableSize; u++) {
|
|
|
|
if (u==eltNbToSkip) continue;
|
2016-10-18 23:34:58 +00:00
|
|
|
if ((table[u].pos > elt.pos) && (table[u].pos <= eltEnd)) { /* overlap, existing > new */
|
2016-01-27 23:29:58 +00:00
|
|
|
/* append */
|
2017-03-26 09:59:13 +00:00
|
|
|
U32 const addedLength = table[u].pos - elt.pos;
|
2016-01-27 23:29:58 +00:00
|
|
|
table[u].length += addedLength;
|
|
|
|
table[u].pos = elt.pos;
|
|
|
|
table[u].savings += elt.savings * addedLength / elt.length; /* rough approx */
|
2017-03-26 21:51:00 +00:00
|
|
|
table[u].savings += elt.length / 8; /* rough approx bonus */
|
2016-01-27 23:29:58 +00:00
|
|
|
elt = table[u];
|
2016-10-18 23:34:58 +00:00
|
|
|
/* sort : improve rank */
|
2016-01-27 23:29:58 +00:00
|
|
|
while ((u>1) && (table[u-1].savings < elt.savings))
|
2016-10-18 23:34:58 +00:00
|
|
|
table[u] = table[u-1], u--;
|
2016-01-27 23:29:58 +00:00
|
|
|
table[u] = elt;
|
|
|
|
return u;
|
|
|
|
} }
|
|
|
|
|
|
|
|
/* front overlap */
|
|
|
|
for (u=1; u<tableSize; u++) {
|
|
|
|
if (u==eltNbToSkip) continue;
|
2017-03-25 00:56:45 +00:00
|
|
|
|
2016-10-18 23:34:58 +00:00
|
|
|
if ((table[u].pos + table[u].length >= elt.pos) && (table[u].pos < elt.pos)) { /* overlap, existing < new */
|
2016-01-27 23:29:58 +00:00
|
|
|
/* append */
|
2017-03-26 09:59:13 +00:00
|
|
|
int const addedLength = (int)eltEnd - (table[u].pos + table[u].length);
|
2016-10-18 23:34:58 +00:00
|
|
|
table[u].savings += elt.length / 8; /* rough approx bonus */
|
|
|
|
if (addedLength > 0) { /* otherwise, elt fully included into existing */
|
2016-01-27 23:29:58 +00:00
|
|
|
table[u].length += addedLength;
|
|
|
|
table[u].savings += elt.savings * addedLength / elt.length; /* rough approx */
|
|
|
|
}
|
2016-10-18 23:34:58 +00:00
|
|
|
/* sort : improve rank */
|
2016-01-27 23:29:58 +00:00
|
|
|
elt = table[u];
|
|
|
|
while ((u>1) && (table[u-1].savings < elt.savings))
|
|
|
|
table[u] = table[u-1], u--;
|
|
|
|
table[u] = elt;
|
|
|
|
return u;
|
2017-03-25 00:56:45 +00:00
|
|
|
}
|
|
|
|
|
2017-03-26 09:59:13 +00:00
|
|
|
if (MEM_read64(buf + table[u].pos) == MEM_read64(buf + elt.pos + 1)) {
|
|
|
|
if (isIncluded(buf + table[u].pos, buf + elt.pos + 1, table[u].length)) {
|
|
|
|
size_t const addedLength = MAX( (int)elt.length - (int)table[u].length , 1 );
|
|
|
|
table[u].pos = elt.pos;
|
|
|
|
table[u].savings += (U32)(elt.savings * addedLength / elt.length);
|
|
|
|
table[u].length = MIN(elt.length, table[u].length + 1);
|
|
|
|
return u;
|
|
|
|
}
|
2017-03-25 00:56:45 +00:00
|
|
|
}
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
static void ZDICT_removeDictItem(dictItem* table, U32 id)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
2017-09-14 22:12:57 +00:00
|
|
|
/* convention : table[0].pos stores nb of elts */
|
|
|
|
U32 const max = table[0].pos;
|
2016-01-27 23:29:58 +00:00
|
|
|
U32 u;
|
|
|
|
if (!id) return; /* protection, should never happen */
|
2016-01-28 14:39:52 +00:00
|
|
|
for (u=id; u<max-1; u++)
|
2016-01-27 23:29:58 +00:00
|
|
|
table[u] = table[u+1];
|
|
|
|
table->pos--;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-03-25 00:56:45 +00:00
|
|
|
static void ZDICT_insertDictItem(dictItem* table, U32 maxSize, dictItem elt, const void* buffer)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
/* merge if possible */
|
2017-03-26 21:39:13 +00:00
|
|
|
U32 mergeId = ZDICT_tryMerge(table, elt, 0, buffer);
|
2016-01-27 23:29:58 +00:00
|
|
|
if (mergeId) {
|
|
|
|
U32 newMerge = 1;
|
|
|
|
while (newMerge) {
|
2017-03-26 21:39:13 +00:00
|
|
|
newMerge = ZDICT_tryMerge(table, table[mergeId], mergeId, buffer);
|
2016-02-11 23:07:30 +00:00
|
|
|
if (newMerge) ZDICT_removeDictItem(table, mergeId);
|
2016-01-27 23:29:58 +00:00
|
|
|
mergeId = newMerge;
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* insert */
|
2016-05-29 03:01:04 +00:00
|
|
|
{ U32 current;
|
2016-01-27 23:29:58 +00:00
|
|
|
U32 nextElt = table->pos;
|
|
|
|
if (nextElt >= maxSize) nextElt = maxSize-1;
|
|
|
|
current = nextElt-1;
|
|
|
|
while (table[current].savings < elt.savings) {
|
|
|
|
table[current+1] = table[current];
|
|
|
|
current--;
|
|
|
|
}
|
|
|
|
table[current+1] = elt;
|
|
|
|
table->pos = nextElt+1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
static U32 ZDICT_dictSize(const dictItem* dictList)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
|
|
|
U32 u, dictSize = 0;
|
|
|
|
for (u=1; u<dictList[0].pos; u++)
|
|
|
|
dictSize += dictList[u].length;
|
|
|
|
return dictSize;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-06-27 04:07:14 +00:00
|
|
|
static size_t ZDICT_trainBuffer_legacy(dictItem* dictList, U32 dictListSize,
|
2016-07-06 14:12:38 +00:00
|
|
|
const void* const buffer, size_t bufferSize, /* buffer must end with noisy guard band */
|
2016-01-31 22:45:35 +00:00
|
|
|
const size_t* fileSizes, unsigned nbFiles,
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned minRatio, U32 notificationLevel)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
2016-02-11 23:07:30 +00:00
|
|
|
int* const suffix0 = (int*)malloc((bufferSize+2)*sizeof(*suffix0));
|
|
|
|
int* const suffix = suffix0+1;
|
2016-01-27 23:29:58 +00:00
|
|
|
U32* reverseSuffix = (U32*)malloc((bufferSize)*sizeof(*reverseSuffix));
|
|
|
|
BYTE* doneMarks = (BYTE*)malloc((bufferSize+16)*sizeof(*doneMarks)); /* +16 for overflow security */
|
|
|
|
U32* filePos = (U32*)malloc(nbFiles * sizeof(*filePos));
|
2016-02-12 01:31:57 +00:00
|
|
|
size_t result = 0;
|
2016-09-02 22:32:39 +00:00
|
|
|
clock_t displayClock = 0;
|
2016-09-03 00:04:49 +00:00
|
|
|
clock_t const refreshRate = CLOCKS_PER_SEC * 3 / 10;
|
|
|
|
|
2016-09-03 00:28:41 +00:00
|
|
|
# define DISPLAYUPDATE(l, ...) if (notificationLevel>=l) { \
|
2016-09-03 00:04:49 +00:00
|
|
|
if (ZDICT_clockSpan(displayClock) > refreshRate) \
|
|
|
|
{ displayClock = clock(); DISPLAY(__VA_ARGS__); \
|
2017-03-23 18:13:52 +00:00
|
|
|
if (notificationLevel>=4) fflush(stderr); } }
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* init */
|
|
|
|
DISPLAYLEVEL(2, "\r%70s\r", ""); /* clean display line */
|
2016-02-12 01:31:57 +00:00
|
|
|
if (!suffix0 || !reverseSuffix || !doneMarks || !filePos) {
|
|
|
|
result = ERROR(memory_allocation);
|
|
|
|
goto _cleanup;
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
if (minRatio < MINRATIO) minRatio = MINRATIO;
|
|
|
|
memset(doneMarks, 0, bufferSize+16);
|
|
|
|
|
2016-07-06 14:12:38 +00:00
|
|
|
/* limit sample set size (divsufsort limitation)*/
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
if (bufferSize > ZDICT_MAX_SAMPLES_SIZE) DISPLAYLEVEL(3, "sample set too large : reduced to %u MB ...\n", (unsigned)(ZDICT_MAX_SAMPLES_SIZE>>20));
|
2016-07-06 14:12:38 +00:00
|
|
|
while (bufferSize > ZDICT_MAX_SAMPLES_SIZE) bufferSize -= fileSizes[--nbFiles];
|
|
|
|
|
2016-01-27 23:29:58 +00:00
|
|
|
/* sort */
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAYLEVEL(2, "sorting %u files of total size %u MB ...\n", nbFiles, (unsigned)(bufferSize>>20));
|
2016-07-14 15:18:20 +00:00
|
|
|
{ int const divSuftSortResult = divsufsort((const unsigned char*)buffer, suffix, (int)bufferSize, 0);
|
|
|
|
if (divSuftSortResult != 0) { result = ERROR(GENERIC); goto _cleanup; }
|
|
|
|
}
|
2016-02-11 23:07:30 +00:00
|
|
|
suffix[bufferSize] = (int)bufferSize; /* leads into noise */
|
|
|
|
suffix0[0] = (int)bufferSize; /* leads into noise */
|
2016-07-06 14:25:46 +00:00
|
|
|
/* build reverse suffix sort */
|
|
|
|
{ size_t pos;
|
2016-01-27 23:29:58 +00:00
|
|
|
for (pos=0; pos < bufferSize; pos++)
|
2016-01-28 14:39:52 +00:00
|
|
|
reverseSuffix[suffix[pos]] = (U32)pos;
|
2016-09-26 16:03:33 +00:00
|
|
|
/* note filePos tracks borders between samples.
|
|
|
|
It's not used at this stage, but planned to become useful in a later update */
|
2016-01-27 23:29:58 +00:00
|
|
|
filePos[0] = 0;
|
|
|
|
for (pos=1; pos<nbFiles; pos++)
|
2016-01-28 14:39:52 +00:00
|
|
|
filePos[pos] = (U32)(filePos[pos-1] + fileSizes[pos-1]);
|
2016-01-27 23:29:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
DISPLAYLEVEL(2, "finding patterns ... \n");
|
2016-01-29 15:48:10 +00:00
|
|
|
DISPLAYLEVEL(3, "minimum ratio : %u \n", minRatio);
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-05-29 03:01:04 +00:00
|
|
|
{ U32 cursor; for (cursor=0; cursor < bufferSize; ) {
|
2016-01-27 23:29:58 +00:00
|
|
|
dictItem solution;
|
|
|
|
if (doneMarks[cursor]) { cursor++; continue; }
|
2016-09-03 00:28:41 +00:00
|
|
|
solution = ZDICT_analyzePos(doneMarks, suffix, reverseSuffix[cursor], buffer, minRatio, notificationLevel);
|
2016-01-27 23:29:58 +00:00
|
|
|
if (solution.length==0) { cursor++; continue; }
|
2017-03-25 00:56:45 +00:00
|
|
|
ZDICT_insertDictItem(dictList, dictListSize, solution, buffer);
|
2016-01-27 23:29:58 +00:00
|
|
|
cursor += solution.length;
|
|
|
|
DISPLAYUPDATE(2, "\r%4.2f %% \r", (double)cursor / bufferSize * 100);
|
2016-01-29 15:48:10 +00:00
|
|
|
} }
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-02-12 01:31:57 +00:00
|
|
|
_cleanup:
|
2016-01-27 23:29:58 +00:00
|
|
|
free(suffix0);
|
|
|
|
free(reverseSuffix);
|
|
|
|
free(doneMarks);
|
|
|
|
free(filePos);
|
2016-02-12 01:31:57 +00:00
|
|
|
return result;
|
2016-01-27 23:29:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
static void ZDICT_fillNoise(void* buffer, size_t length)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
2016-08-30 16:56:25 +00:00
|
|
|
unsigned const prime1 = 2654435761U;
|
|
|
|
unsigned const prime2 = 2246822519U;
|
|
|
|
unsigned acc = prime1;
|
2016-01-27 23:29:58 +00:00
|
|
|
size_t p=0;;
|
|
|
|
for (p=0; p<length; p++) {
|
2016-08-30 16:56:25 +00:00
|
|
|
acc *= prime2;
|
2016-01-27 23:29:58 +00:00
|
|
|
((unsigned char*)buffer)[p] = (unsigned char)(acc >> 21);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
typedef struct
|
|
|
|
{
|
2018-07-31 20:58:54 +00:00
|
|
|
ZSTD_CDict* dict; /* dictionary */
|
2018-01-11 17:42:38 +00:00
|
|
|
ZSTD_CCtx* zc; /* working context */
|
2017-05-19 17:51:30 +00:00
|
|
|
void* workPlace; /* must be ZSTD_BLOCKSIZE_MAX allocated */
|
2016-01-27 23:29:58 +00:00
|
|
|
} EStats_ress_t;
|
|
|
|
|
2016-06-15 11:53:34 +00:00
|
|
|
#define MAXREPOFFSET 1024
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-07-15 09:56:53 +00:00
|
|
|
static void ZDICT_countEStats(EStats_ress_t esr, ZSTD_parameters params,
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned* countLit, unsigned* offsetcodeCount, unsigned* matchlengthCount, unsigned* litlengthCount, U32* repOffsets,
|
2018-01-11 17:42:38 +00:00
|
|
|
const void* src, size_t srcSize,
|
|
|
|
U32 notificationLevel)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
2017-05-19 17:51:30 +00:00
|
|
|
size_t const blockSizeMax = MIN (ZSTD_BLOCKSIZE_MAX, 1 << params.cParams.windowLog);
|
2016-06-22 09:05:34 +00:00
|
|
|
size_t cSize;
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-07-15 09:56:53 +00:00
|
|
|
if (srcSize > blockSizeMax) srcSize = blockSizeMax; /* protection vs large samples */
|
2018-07-31 20:58:54 +00:00
|
|
|
{ size_t const errorCode = ZSTD_compressBegin_usingCDict(esr.zc, esr.dict);
|
2018-07-31 17:36:45 +00:00
|
|
|
if (ZSTD_isError(errorCode)) { DISPLAYLEVEL(1, "warning : ZSTD_compressBegin_usingCDict failed \n"); return; }
|
|
|
|
|
2016-09-03 00:28:41 +00:00
|
|
|
}
|
2017-05-19 17:51:30 +00:00
|
|
|
cSize = ZSTD_compressBlock(esr.zc, esr.workPlace, ZSTD_BLOCKSIZE_MAX, src, srcSize);
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
if (ZSTD_isError(cSize)) { DISPLAYLEVEL(3, "warning : could not compress sample size %u \n", (unsigned)srcSize); return; }
|
2016-03-26 19:52:14 +00:00
|
|
|
|
2016-06-22 09:05:34 +00:00
|
|
|
if (cSize) { /* if == 0; block is not compressible */
|
2018-01-11 17:42:38 +00:00
|
|
|
const seqStore_t* const seqStorePtr = ZSTD_getSeqStore(esr.zc);
|
2016-03-26 19:52:14 +00:00
|
|
|
|
2016-06-22 09:05:34 +00:00
|
|
|
/* literals stats */
|
|
|
|
{ const BYTE* bytePtr;
|
|
|
|
for(bytePtr = seqStorePtr->litStart; bytePtr < seqStorePtr->lit; bytePtr++)
|
|
|
|
countLit[*bytePtr]++;
|
2016-03-26 19:52:14 +00:00
|
|
|
}
|
|
|
|
|
2016-06-22 09:05:34 +00:00
|
|
|
/* seqStats */
|
2016-07-29 22:55:13 +00:00
|
|
|
{ U32 const nbSeq = (U32)(seqStorePtr->sequences - seqStorePtr->sequencesStart);
|
2016-07-29 19:22:17 +00:00
|
|
|
ZSTD_seqToCodes(seqStorePtr);
|
2016-03-26 19:52:14 +00:00
|
|
|
|
2016-07-29 19:22:17 +00:00
|
|
|
{ const BYTE* codePtr = seqStorePtr->ofCode;
|
|
|
|
U32 u;
|
2016-06-22 09:05:34 +00:00
|
|
|
for (u=0; u<nbSeq; u++) offsetcodeCount[codePtr[u]]++;
|
|
|
|
}
|
2016-06-15 11:53:34 +00:00
|
|
|
|
2016-07-29 19:22:17 +00:00
|
|
|
{ const BYTE* codePtr = seqStorePtr->mlCode;
|
|
|
|
U32 u;
|
2016-06-22 09:05:34 +00:00
|
|
|
for (u=0; u<nbSeq; u++) matchlengthCount[codePtr[u]]++;
|
|
|
|
}
|
2016-06-15 11:53:34 +00:00
|
|
|
|
2016-07-29 19:22:17 +00:00
|
|
|
{ const BYTE* codePtr = seqStorePtr->llCode;
|
|
|
|
U32 u;
|
2016-06-22 09:05:34 +00:00
|
|
|
for (u=0; u<nbSeq; u++) litlengthCount[codePtr[u]]++;
|
2016-08-11 20:09:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (nbSeq >= 2) { /* rep offsets */
|
|
|
|
const seqDef* const seq = seqStorePtr->sequencesStart;
|
|
|
|
U32 offset1 = seq[0].offset - 3;
|
|
|
|
U32 offset2 = seq[1].offset - 3;
|
|
|
|
if (offset1 >= MAXREPOFFSET) offset1 = 0;
|
|
|
|
if (offset2 >= MAXREPOFFSET) offset2 = 0;
|
|
|
|
repOffsets[offset1] += 3;
|
|
|
|
repOffsets[offset2] += 1;
|
|
|
|
} } }
|
2016-01-27 23:29:58 +00:00
|
|
|
}
|
|
|
|
|
2016-03-30 17:48:05 +00:00
|
|
|
static size_t ZDICT_totalSampleSize(const size_t* fileSizes, unsigned nbFiles)
|
|
|
|
{
|
2016-06-15 11:53:34 +00:00
|
|
|
size_t total=0;
|
2016-03-30 17:48:05 +00:00
|
|
|
unsigned u;
|
2016-06-15 11:53:34 +00:00
|
|
|
for (u=0; u<nbFiles; u++) total += fileSizes[u];
|
2016-03-30 17:48:05 +00:00
|
|
|
return total;
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-06-15 11:53:34 +00:00
|
|
|
typedef struct { U32 offset; U32 count; } offsetCount_t;
|
|
|
|
|
|
|
|
static void ZDICT_insertSortCount(offsetCount_t table[ZSTD_REP_NUM+1], U32 val, U32 count)
|
|
|
|
{
|
|
|
|
U32 u;
|
|
|
|
table[ZSTD_REP_NUM].offset = val;
|
|
|
|
table[ZSTD_REP_NUM].count = count;
|
|
|
|
for (u=ZSTD_REP_NUM; u>0; u--) {
|
|
|
|
offsetCount_t tmp;
|
|
|
|
if (table[u-1].count >= table[u].count) break;
|
|
|
|
tmp = table[u-1];
|
|
|
|
table[u-1] = table[u];
|
|
|
|
table[u] = tmp;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-01-11 19:16:32 +00:00
|
|
|
/* ZDICT_flatLit() :
|
|
|
|
* rewrite `countLit` to contain a mostly flat but still compressible distribution of literals.
|
|
|
|
* necessary to avoid generating a non-compressible distribution that HUF_writeCTable() cannot encode.
|
|
|
|
*/
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
static void ZDICT_flatLit(unsigned* countLit)
|
2018-01-11 19:16:32 +00:00
|
|
|
{
|
|
|
|
int u;
|
|
|
|
for (u=1; u<256; u++) countLit[u] = 2;
|
|
|
|
countLit[0] = 4;
|
|
|
|
countLit[253] = 1;
|
|
|
|
countLit[254] = 1;
|
|
|
|
}
|
2016-06-15 11:53:34 +00:00
|
|
|
|
2016-07-27 12:37:00 +00:00
|
|
|
#define OFFCODE_MAX 30 /* only applicable to first block */
|
2016-02-11 23:07:30 +00:00
|
|
|
static size_t ZDICT_analyzeEntropy(void* dstBuffer, size_t maxDstSize,
|
2016-09-03 00:28:41 +00:00
|
|
|
unsigned compressionLevel,
|
|
|
|
const void* srcBuffer, const size_t* fileSizes, unsigned nbFiles,
|
|
|
|
const void* dictBuffer, size_t dictBufferSize,
|
|
|
|
unsigned notificationLevel)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned countLit[256];
|
2016-01-27 23:29:58 +00:00
|
|
|
HUF_CREATE_STATIC_CTABLE(hufTable, 255);
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned offcodeCount[OFFCODE_MAX+1];
|
2016-03-26 19:52:14 +00:00
|
|
|
short offcodeNCount[OFFCODE_MAX+1];
|
2016-07-27 12:37:00 +00:00
|
|
|
U32 offcodeMax = ZSTD_highbit32((U32)(dictBufferSize + 128 KB));
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned matchLengthCount[MaxML+1];
|
2016-01-27 23:29:58 +00:00
|
|
|
short matchLengthNCount[MaxML+1];
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned litLengthCount[MaxLL+1];
|
2016-03-26 19:52:14 +00:00
|
|
|
short litLengthNCount[MaxLL+1];
|
2016-08-11 20:09:09 +00:00
|
|
|
U32 repOffset[MAXREPOFFSET];
|
2016-06-15 11:53:34 +00:00
|
|
|
offsetCount_t bestRepOffset[ZSTD_REP_NUM+1];
|
2018-08-14 19:56:21 +00:00
|
|
|
EStats_ress_t esr = { NULL, NULL, NULL };
|
2016-01-27 23:29:58 +00:00
|
|
|
ZSTD_parameters params;
|
2016-07-17 14:21:37 +00:00
|
|
|
U32 u, huffLog = 11, Offlog = OffFSELog, mlLog = MLFSELog, llLog = LLFSELog, total;
|
2016-01-27 23:29:58 +00:00
|
|
|
size_t pos = 0, errorCode;
|
|
|
|
size_t eSize = 0;
|
2016-03-30 17:48:05 +00:00
|
|
|
size_t const totalSrcSize = ZDICT_totalSampleSize(fileSizes, nbFiles);
|
2016-08-01 17:11:54 +00:00
|
|
|
size_t const averageSampleSize = totalSrcSize / (nbFiles + !nbFiles);
|
2016-06-15 11:53:34 +00:00
|
|
|
BYTE* dstPtr = (BYTE*)dstBuffer;
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* init */
|
2018-01-11 17:42:38 +00:00
|
|
|
DEBUGLOG(4, "ZDICT_analyzeEntropy");
|
2017-07-14 00:12:16 +00:00
|
|
|
if (offcodeMax>OFFCODE_MAX) { eSize = ERROR(dictionaryCreation_failed); goto _cleanup; } /* too large dictionary */
|
2017-03-26 09:50:00 +00:00
|
|
|
for (u=0; u<256; u++) countLit[u] = 1; /* any character must be described */
|
|
|
|
for (u=0; u<=offcodeMax; u++) offcodeCount[u] = 1;
|
|
|
|
for (u=0; u<=MaxML; u++) matchLengthCount[u] = 1;
|
|
|
|
for (u=0; u<=MaxLL; u++) litLengthCount[u] = 1;
|
2016-08-11 20:09:09 +00:00
|
|
|
memset(repOffset, 0, sizeof(repOffset));
|
2016-06-15 11:53:34 +00:00
|
|
|
repOffset[1] = repOffset[4] = repOffset[8] = 1;
|
|
|
|
memset(bestRepOffset, 0, sizeof(bestRepOffset));
|
2018-04-09 19:09:28 +00:00
|
|
|
if (compressionLevel==0) compressionLevel = g_compressionLevel_default;
|
2016-07-14 14:52:45 +00:00
|
|
|
params = ZSTD_getParams(compressionLevel, averageSampleSize, dictBufferSize);
|
2018-07-31 17:36:45 +00:00
|
|
|
|
2018-07-31 20:58:54 +00:00
|
|
|
esr.dict = ZSTD_createCDict_advanced(dictBuffer, dictBufferSize, ZSTD_dlm_byRef, ZSTD_dct_rawContent, params.cParams, ZSTD_defaultCMem);
|
2018-07-31 17:36:45 +00:00
|
|
|
esr.zc = ZSTD_createCCtx();
|
|
|
|
esr.workPlace = malloc(ZSTD_BLOCKSIZE_MAX);
|
2018-07-31 20:58:54 +00:00
|
|
|
if (!esr.dict || !esr.zc || !esr.workPlace) {
|
2018-07-31 17:36:45 +00:00
|
|
|
eSize = ERROR(memory_allocation);
|
|
|
|
DISPLAYLEVEL(1, "Not enough memory \n");
|
|
|
|
goto _cleanup;
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2018-01-11 17:42:38 +00:00
|
|
|
/* collect stats on all samples */
|
2016-01-27 23:29:58 +00:00
|
|
|
for (u=0; u<nbFiles; u++) {
|
2016-07-15 09:56:53 +00:00
|
|
|
ZDICT_countEStats(esr, params,
|
2016-09-03 00:28:41 +00:00
|
|
|
countLit, offcodeCount, matchLengthCount, litLengthCount, repOffset,
|
|
|
|
(const char*)srcBuffer + pos, fileSizes[u],
|
|
|
|
notificationLevel);
|
2016-01-27 23:29:58 +00:00
|
|
|
pos += fileSizes[u];
|
|
|
|
}
|
|
|
|
|
2018-01-11 19:16:32 +00:00
|
|
|
/* analyze, build stats, starting with literals */
|
|
|
|
{ size_t maxNbBits = HUF_buildCTable (hufTable, countLit, 255, huffLog);
|
|
|
|
if (HUF_isError(maxNbBits)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
|
|
|
DISPLAYLEVEL(1, " HUF_buildCTable error \n");
|
|
|
|
goto _cleanup;
|
|
|
|
}
|
|
|
|
if (maxNbBits==8) { /* not compressible : will fail on HUF_writeCTable() */
|
2018-01-11 19:29:28 +00:00
|
|
|
DISPLAYLEVEL(2, "warning : pathological dataset : literals are not compressible : samples are noisy or too regular \n");
|
2018-01-11 19:16:32 +00:00
|
|
|
ZDICT_flatLit(countLit); /* replace distribution by a fake "mostly flat but still compressible" distribution, that HUF_writeCTable() can encode */
|
|
|
|
maxNbBits = HUF_buildCTable (hufTable, countLit, 255, huffLog);
|
|
|
|
assert(maxNbBits==9);
|
|
|
|
}
|
|
|
|
huffLog = (U32)maxNbBits;
|
2016-02-12 01:31:57 +00:00
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-06-15 23:14:41 +00:00
|
|
|
/* looking for most common first offsets */
|
|
|
|
{ U32 offset;
|
|
|
|
for (offset=1; offset<MAXREPOFFSET; offset++)
|
|
|
|
ZDICT_insertSortCount(bestRepOffset, offset, repOffset[offset]);
|
|
|
|
}
|
|
|
|
/* note : the result of this phase should be used to better appreciate the impact on statistics */
|
|
|
|
|
2016-07-27 12:48:47 +00:00
|
|
|
total=0; for (u=0; u<=offcodeMax; u++) total+=offcodeCount[u];
|
|
|
|
errorCode = FSE_normalizeCount(offcodeNCount, Offlog, offcodeCount, total, offcodeMax);
|
2016-02-12 01:31:57 +00:00
|
|
|
if (FSE_isError(errorCode)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "FSE_normalizeCount error with offcodeCount \n");
|
2016-02-12 01:31:57 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
Offlog = (U32)errorCode;
|
|
|
|
|
|
|
|
total=0; for (u=0; u<=MaxML; u++) total+=matchLengthCount[u];
|
|
|
|
errorCode = FSE_normalizeCount(matchLengthNCount, mlLog, matchLengthCount, total, MaxML);
|
2016-02-12 01:31:57 +00:00
|
|
|
if (FSE_isError(errorCode)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "FSE_normalizeCount error with matchLengthCount \n");
|
2016-02-12 01:31:57 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
mlLog = (U32)errorCode;
|
|
|
|
|
2016-03-26 19:52:14 +00:00
|
|
|
total=0; for (u=0; u<=MaxLL; u++) total+=litLengthCount[u];
|
|
|
|
errorCode = FSE_normalizeCount(litLengthNCount, llLog, litLengthCount, total, MaxLL);
|
2016-02-12 01:31:57 +00:00
|
|
|
if (FSE_isError(errorCode)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "FSE_normalizeCount error with litLengthCount \n");
|
2016-02-12 01:31:57 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
llLog = (U32)errorCode;
|
|
|
|
|
|
|
|
/* write result to buffer */
|
2016-06-15 11:53:34 +00:00
|
|
|
{ size_t const hhSize = HUF_writeCTable(dstPtr, maxDstSize, hufTable, 255, huffLog);
|
|
|
|
if (HUF_isError(hhSize)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "HUF_writeCTable error \n");
|
2016-06-15 11:53:34 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
|
|
|
dstPtr += hhSize;
|
|
|
|
maxDstSize -= hhSize;
|
|
|
|
eSize += hhSize;
|
2016-02-12 01:31:57 +00:00
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-06-15 11:53:34 +00:00
|
|
|
{ size_t const ohSize = FSE_writeNCount(dstPtr, maxDstSize, offcodeNCount, OFFCODE_MAX, Offlog);
|
|
|
|
if (FSE_isError(ohSize)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "FSE_writeNCount error with offcodeNCount \n");
|
2016-06-15 11:53:34 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
|
|
|
dstPtr += ohSize;
|
|
|
|
maxDstSize -= ohSize;
|
|
|
|
eSize += ohSize;
|
2016-02-12 01:31:57 +00:00
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-06-15 11:53:34 +00:00
|
|
|
{ size_t const mhSize = FSE_writeNCount(dstPtr, maxDstSize, matchLengthNCount, MaxML, mlLog);
|
|
|
|
if (FSE_isError(mhSize)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "FSE_writeNCount error with matchLengthNCount \n");
|
2016-06-15 11:53:34 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
|
|
|
dstPtr += mhSize;
|
|
|
|
maxDstSize -= mhSize;
|
|
|
|
eSize += mhSize;
|
2016-02-12 01:31:57 +00:00
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-06-15 11:53:34 +00:00
|
|
|
{ size_t const lhSize = FSE_writeNCount(dstPtr, maxDstSize, litLengthNCount, MaxLL, llLog);
|
|
|
|
if (FSE_isError(lhSize)) {
|
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "FSE_writeNCount error with litlengthNCount \n");
|
2016-06-15 11:53:34 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
|
|
|
dstPtr += lhSize;
|
|
|
|
maxDstSize -= lhSize;
|
|
|
|
eSize += lhSize;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (maxDstSize<12) {
|
2016-02-12 01:31:57 +00:00
|
|
|
eSize = ERROR(GENERIC);
|
2016-08-18 13:02:11 +00:00
|
|
|
DISPLAYLEVEL(1, "not enough space to write RepOffsets \n");
|
2016-02-12 01:31:57 +00:00
|
|
|
goto _cleanup;
|
|
|
|
}
|
2016-06-15 23:14:41 +00:00
|
|
|
# if 0
|
2016-06-15 11:53:34 +00:00
|
|
|
MEM_writeLE32(dstPtr+0, bestRepOffset[0].offset);
|
|
|
|
MEM_writeLE32(dstPtr+4, bestRepOffset[1].offset);
|
|
|
|
MEM_writeLE32(dstPtr+8, bestRepOffset[2].offset);
|
2016-06-15 23:14:41 +00:00
|
|
|
#else
|
|
|
|
/* at this stage, we don't use the result of "most common first offset",
|
|
|
|
as the impact of statistics is not properly evaluated */
|
|
|
|
MEM_writeLE32(dstPtr+0, repStartValue[0]);
|
|
|
|
MEM_writeLE32(dstPtr+4, repStartValue[1]);
|
|
|
|
MEM_writeLE32(dstPtr+8, repStartValue[2]);
|
|
|
|
#endif
|
2016-06-15 11:53:34 +00:00
|
|
|
eSize += 12;
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-02-12 01:31:57 +00:00
|
|
|
_cleanup:
|
2018-07-31 20:58:54 +00:00
|
|
|
ZSTD_freeCDict(esr.dict);
|
2016-01-27 23:29:58 +00:00
|
|
|
ZSTD_freeCCtx(esr.zc);
|
|
|
|
free(esr.workPlace);
|
|
|
|
|
|
|
|
return eSize;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-12-22 19:18:43 +00:00
|
|
|
|
|
|
|
size_t ZDICT_finalizeDictionary(void* dictBuffer, size_t dictBufferCapacity,
|
|
|
|
const void* customDictContent, size_t dictContentSize,
|
2018-08-23 19:06:20 +00:00
|
|
|
const void* samplesBuffer, const size_t* samplesSizes,
|
|
|
|
unsigned nbSamples, ZDICT_params_t params)
|
2016-12-22 19:18:43 +00:00
|
|
|
{
|
|
|
|
size_t hSize;
|
2017-03-24 23:04:29 +00:00
|
|
|
#define HBUFFSIZE 256 /* should prove large enough for all entropy headers */
|
2016-12-22 19:18:43 +00:00
|
|
|
BYTE header[HBUFFSIZE];
|
2018-04-09 19:09:28 +00:00
|
|
|
int const compressionLevel = (params.compressionLevel == 0) ? g_compressionLevel_default : params.compressionLevel;
|
2016-12-22 19:18:43 +00:00
|
|
|
U32 const notificationLevel = params.notificationLevel;
|
|
|
|
|
|
|
|
/* check conditions */
|
2018-01-11 17:42:38 +00:00
|
|
|
DEBUGLOG(4, "ZDICT_finalizeDictionary");
|
2016-12-23 02:01:14 +00:00
|
|
|
if (dictBufferCapacity < dictContentSize) return ERROR(dstSize_tooSmall);
|
2016-12-22 19:18:43 +00:00
|
|
|
if (dictContentSize < ZDICT_CONTENTSIZE_MIN) return ERROR(srcSize_wrong);
|
|
|
|
if (dictBufferCapacity < ZDICT_DICTSIZE_MIN) return ERROR(dstSize_tooSmall);
|
|
|
|
|
|
|
|
/* dictionary header */
|
2017-06-27 20:50:34 +00:00
|
|
|
MEM_writeLE32(header, ZSTD_MAGIC_DICTIONARY);
|
2016-12-22 19:18:43 +00:00
|
|
|
{ U64 const randomID = XXH64(customDictContent, dictContentSize, 0);
|
|
|
|
U32 const compliantID = (randomID % ((1U<<31)-32768)) + 32768;
|
|
|
|
U32 const dictID = params.dictID ? params.dictID : compliantID;
|
|
|
|
MEM_writeLE32(header+4, dictID);
|
|
|
|
}
|
|
|
|
hSize = 8;
|
|
|
|
|
|
|
|
/* entropy tables */
|
|
|
|
DISPLAYLEVEL(2, "\r%70s\r", ""); /* clean display line */
|
|
|
|
DISPLAYLEVEL(2, "statistics ... \n");
|
|
|
|
{ size_t const eSize = ZDICT_analyzeEntropy(header+hSize, HBUFFSIZE-hSize,
|
|
|
|
compressionLevel,
|
|
|
|
samplesBuffer, samplesSizes, nbSamples,
|
|
|
|
customDictContent, dictContentSize,
|
|
|
|
notificationLevel);
|
|
|
|
if (ZDICT_isError(eSize)) return eSize;
|
|
|
|
hSize += eSize;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* copy elements in final buffer ; note : src and dst buffer can overlap */
|
2016-12-23 02:01:14 +00:00
|
|
|
if (hSize + dictContentSize > dictBufferCapacity) dictContentSize = dictBufferCapacity - hSize;
|
2016-12-22 19:18:43 +00:00
|
|
|
{ size_t const dictSize = hSize + dictContentSize;
|
|
|
|
char* dictEnd = (char*)dictBuffer + dictSize;
|
|
|
|
memmove(dictEnd - dictContentSize, customDictContent, dictContentSize);
|
|
|
|
memcpy(dictBuffer, header, hSize);
|
|
|
|
return dictSize;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-09-27 22:13:43 +00:00
|
|
|
static size_t ZDICT_addEntropyTablesFromBuffer_advanced(
|
|
|
|
void* dictBuffer, size_t dictContentSize, size_t dictBufferCapacity,
|
|
|
|
const void* samplesBuffer, const size_t* samplesSizes, unsigned nbSamples,
|
|
|
|
ZDICT_params_t params)
|
2016-05-31 01:49:58 +00:00
|
|
|
{
|
2018-04-09 19:09:28 +00:00
|
|
|
int const compressionLevel = (params.compressionLevel == 0) ? g_compressionLevel_default : params.compressionLevel;
|
2016-09-03 00:28:41 +00:00
|
|
|
U32 const notificationLevel = params.notificationLevel;
|
2017-03-26 09:50:00 +00:00
|
|
|
size_t hSize = 8;
|
2016-05-31 01:49:58 +00:00
|
|
|
|
2017-03-26 09:50:00 +00:00
|
|
|
/* calculate entropy tables */
|
2016-05-31 01:49:58 +00:00
|
|
|
DISPLAYLEVEL(2, "\r%70s\r", ""); /* clean display line */
|
|
|
|
DISPLAYLEVEL(2, "statistics ... \n");
|
2016-08-18 13:02:11 +00:00
|
|
|
{ size_t const eSize = ZDICT_analyzeEntropy((char*)dictBuffer+hSize, dictBufferCapacity-hSize,
|
2016-05-31 01:49:58 +00:00
|
|
|
compressionLevel,
|
|
|
|
samplesBuffer, samplesSizes, nbSamples,
|
2016-09-03 00:28:41 +00:00
|
|
|
(char*)dictBuffer + dictBufferCapacity - dictContentSize, dictContentSize,
|
|
|
|
notificationLevel);
|
2016-08-18 13:02:11 +00:00
|
|
|
if (ZDICT_isError(eSize)) return eSize;
|
|
|
|
hSize += eSize;
|
|
|
|
}
|
|
|
|
|
2017-03-26 09:50:00 +00:00
|
|
|
/* add dictionary header (after entropy tables) */
|
2017-06-27 20:50:34 +00:00
|
|
|
MEM_writeLE32(dictBuffer, ZSTD_MAGIC_DICTIONARY);
|
2017-03-26 09:50:00 +00:00
|
|
|
{ U64 const randomID = XXH64((char*)dictBuffer + dictBufferCapacity - dictContentSize, dictContentSize, 0);
|
|
|
|
U32 const compliantID = (randomID % ((1U<<31)-32768)) + 32768;
|
|
|
|
U32 const dictID = params.dictID ? params.dictID : compliantID;
|
|
|
|
MEM_writeLE32((char*)dictBuffer+4, dictID);
|
|
|
|
}
|
2016-05-31 01:49:58 +00:00
|
|
|
|
|
|
|
if (hSize + dictContentSize < dictBufferCapacity)
|
|
|
|
memmove((char*)dictBuffer + hSize, (char*)dictBuffer + dictBufferCapacity - dictContentSize, dictContentSize);
|
|
|
|
return MIN(dictBufferCapacity, hSize+dictContentSize);
|
|
|
|
}
|
2016-01-29 01:45:26 +00:00
|
|
|
|
2018-09-27 22:13:43 +00:00
|
|
|
/* Hidden declaration for dbio.c */
|
|
|
|
size_t ZDICT_trainFromBuffer_unsafe_legacy(
|
|
|
|
void* dictBuffer, size_t maxDictSize,
|
|
|
|
const void* samplesBuffer, const size_t* samplesSizes, unsigned nbSamples,
|
|
|
|
ZDICT_legacy_params_t params);
|
2017-06-27 04:07:14 +00:00
|
|
|
/*! ZDICT_trainFromBuffer_unsafe_legacy() :
|
2016-07-27 12:37:00 +00:00
|
|
|
* Warning : `samplesBuffer` must be followed by noisy guard band.
|
|
|
|
* @return : size of dictionary, or an error code which can be tested with ZDICT_isError()
|
2016-03-26 19:52:14 +00:00
|
|
|
*/
|
2017-06-27 04:07:14 +00:00
|
|
|
size_t ZDICT_trainFromBuffer_unsafe_legacy(
|
2016-01-31 22:45:35 +00:00
|
|
|
void* dictBuffer, size_t maxDictSize,
|
2016-05-31 01:49:58 +00:00
|
|
|
const void* samplesBuffer, const size_t* samplesSizes, unsigned nbSamples,
|
2017-06-27 04:07:14 +00:00
|
|
|
ZDICT_legacy_params_t params)
|
2016-01-27 23:29:58 +00:00
|
|
|
{
|
2016-08-30 16:56:25 +00:00
|
|
|
U32 const dictListSize = MAX(MAX(DICTLISTSIZE_DEFAULT, nbSamples), (U32)(maxDictSize/16));
|
2016-05-30 19:18:52 +00:00
|
|
|
dictItem* const dictList = (dictItem*)malloc(dictListSize * sizeof(*dictList));
|
2016-07-27 11:28:46 +00:00
|
|
|
unsigned const selectivity = params.selectivityLevel == 0 ? g_selectivity_default : params.selectivityLevel;
|
2016-08-01 00:26:20 +00:00
|
|
|
unsigned const minRep = (selectivity > 30) ? MINRATIO : nbSamples >> selectivity;
|
2016-05-30 19:18:52 +00:00
|
|
|
size_t const targetDictSize = maxDictSize;
|
2016-07-27 10:53:54 +00:00
|
|
|
size_t const samplesBuffSize = ZDICT_totalSampleSize(samplesSizes, nbSamples);
|
2016-01-31 22:45:35 +00:00
|
|
|
size_t dictSize = 0;
|
2017-06-27 04:07:14 +00:00
|
|
|
U32 const notificationLevel = params.zParams.notificationLevel;
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-01-31 22:45:35 +00:00
|
|
|
/* checks */
|
2016-03-26 19:52:14 +00:00
|
|
|
if (!dictList) return ERROR(memory_allocation);
|
2017-03-24 22:02:09 +00:00
|
|
|
if (maxDictSize < ZDICT_DICTSIZE_MIN) { free(dictList); return ERROR(dstSize_tooSmall); } /* requested dictionary size is too small */
|
2017-03-23 23:24:02 +00:00
|
|
|
if (samplesBuffSize < ZDICT_MIN_SAMPLES_SIZE) { free(dictList); return ERROR(dictionaryCreation_failed); } /* not enough source to create dictionary */
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-01-31 22:45:35 +00:00
|
|
|
/* init */
|
2016-02-11 23:07:30 +00:00
|
|
|
ZDICT_initDictItem(dictList);
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
/* build dictionary */
|
2017-06-27 04:07:14 +00:00
|
|
|
ZDICT_trainBuffer_legacy(dictList, dictListSize,
|
|
|
|
samplesBuffer, samplesBuffSize,
|
|
|
|
samplesSizes, nbSamples,
|
|
|
|
minRep, notificationLevel);
|
2016-07-27 10:53:54 +00:00
|
|
|
|
|
|
|
/* display best matches */
|
2017-06-27 04:07:14 +00:00
|
|
|
if (params.zParams.notificationLevel>= 3) {
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned const nb = MIN(25, dictList[0].pos);
|
|
|
|
unsigned const dictContentSize = ZDICT_dictSize(dictList);
|
|
|
|
unsigned u;
|
|
|
|
DISPLAYLEVEL(3, "\n %u segments found, of total size %u \n", (unsigned)dictList[0].pos-1, dictContentSize);
|
2016-11-02 20:57:55 +00:00
|
|
|
DISPLAYLEVEL(3, "list %u best segments \n", nb-1);
|
|
|
|
for (u=1; u<nb; u++) {
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned const pos = dictList[u].pos;
|
|
|
|
unsigned const length = dictList[u].length;
|
2016-11-02 20:57:55 +00:00
|
|
|
U32 const printedLength = MIN(40, length);
|
2018-08-28 05:25:05 +00:00
|
|
|
if ((pos > samplesBuffSize) || ((pos + length) > samplesBuffSize)) {
|
|
|
|
free(dictList);
|
2016-11-02 20:57:55 +00:00
|
|
|
return ERROR(GENERIC); /* should never happen */
|
2018-08-28 05:25:05 +00:00
|
|
|
}
|
2016-07-27 10:53:54 +00:00
|
|
|
DISPLAYLEVEL(3, "%3u:%3u bytes at pos %8u, savings %7u bytes |",
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
u, length, pos, (unsigned)dictList[u].savings);
|
2016-09-03 00:28:41 +00:00
|
|
|
ZDICT_printHex((const char*)samplesBuffer+pos, printedLength);
|
2016-07-27 10:53:54 +00:00
|
|
|
DISPLAYLEVEL(3, "| \n");
|
|
|
|
} }
|
|
|
|
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* create dictionary */
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
{ unsigned dictContentSize = ZDICT_dictSize(dictList);
|
2017-03-24 22:02:09 +00:00
|
|
|
if (dictContentSize < ZDICT_CONTENTSIZE_MIN) { free(dictList); return ERROR(dictionaryCreation_failed); } /* dictionary content too small */
|
|
|
|
if (dictContentSize < targetDictSize/4) {
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAYLEVEL(2, "! warning : selected content significantly smaller than requested (%u < %u) \n", dictContentSize, (unsigned)maxDictSize);
|
2017-03-24 22:02:09 +00:00
|
|
|
if (samplesBuffSize < 10 * targetDictSize)
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAYLEVEL(2, "! consider increasing the number of samples (total size : %u MB)\n", (unsigned)(samplesBuffSize>>20));
|
2016-07-27 11:28:46 +00:00
|
|
|
if (minRep > MINRATIO) {
|
|
|
|
DISPLAYLEVEL(2, "! consider increasing selectivity to produce larger dictionary (-s%u) \n", selectivity+1);
|
|
|
|
DISPLAYLEVEL(2, "! note : larger dictionaries are not necessarily better, test its efficiency on samples \n");
|
|
|
|
}
|
2016-07-27 10:53:54 +00:00
|
|
|
}
|
|
|
|
|
2016-09-27 13:14:32 +00:00
|
|
|
if ((dictContentSize > targetDictSize*3) && (nbSamples > 2*MINRATIO) && (selectivity>1)) {
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned proposedSelectivity = selectivity-1;
|
2016-07-27 11:28:46 +00:00
|
|
|
while ((nbSamples >> proposedSelectivity) <= MINRATIO) { proposedSelectivity--; }
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAYLEVEL(2, "! note : calculated dictionary significantly larger than requested (%u > %u) \n", dictContentSize, (unsigned)maxDictSize);
|
2016-09-27 13:14:32 +00:00
|
|
|
DISPLAYLEVEL(2, "! consider increasing dictionary size, or produce denser dictionary (-s%u) \n", proposedSelectivity);
|
2017-03-24 22:02:09 +00:00
|
|
|
DISPLAYLEVEL(2, "! always test dictionary efficiency on real samples \n");
|
2016-07-27 10:53:54 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* limit dictionary size */
|
|
|
|
{ U32 const max = dictList->pos; /* convention : nb of useful elts within dictList */
|
|
|
|
U32 currentSize = 0;
|
|
|
|
U32 n; for (n=1; n<max; n++) {
|
|
|
|
currentSize += dictList[n].length;
|
2016-07-27 11:28:46 +00:00
|
|
|
if (currentSize > targetDictSize) { currentSize -= dictList[n].length; break; }
|
2016-07-27 10:53:54 +00:00
|
|
|
}
|
|
|
|
dictList->pos = n;
|
2016-07-27 11:28:46 +00:00
|
|
|
dictContentSize = currentSize;
|
2016-07-27 10:35:29 +00:00
|
|
|
}
|
2016-01-27 23:29:58 +00:00
|
|
|
|
|
|
|
/* build dict content */
|
2016-05-30 19:18:52 +00:00
|
|
|
{ U32 u;
|
|
|
|
BYTE* ptr = (BYTE*)dictBuffer + maxDictSize;
|
|
|
|
for (u=1; u<dictList->pos; u++) {
|
|
|
|
U32 l = dictList[u].length;
|
|
|
|
ptr -= l;
|
2016-07-13 15:19:57 +00:00
|
|
|
if (ptr<(BYTE*)dictBuffer) { free(dictList); return ERROR(GENERIC); } /* should not happen */
|
2016-05-30 19:18:52 +00:00
|
|
|
memcpy(ptr, (const char*)samplesBuffer+dictList[u].pos, l);
|
|
|
|
} }
|
2016-01-27 23:29:58 +00:00
|
|
|
|
2016-05-31 01:49:58 +00:00
|
|
|
dictSize = ZDICT_addEntropyTablesFromBuffer_advanced(dictBuffer, dictContentSize, maxDictSize,
|
|
|
|
samplesBuffer, samplesSizes, nbSamples,
|
2017-06-27 04:07:14 +00:00
|
|
|
params.zParams);
|
2016-01-27 23:29:58 +00:00
|
|
|
}
|
|
|
|
|
2016-07-06 10:35:09 +00:00
|
|
|
/* clean up */
|
2016-01-27 23:29:58 +00:00
|
|
|
free(dictList);
|
2016-01-31 22:45:35 +00:00
|
|
|
return dictSize;
|
2016-01-27 23:29:58 +00:00
|
|
|
}
|
|
|
|
|
2016-01-31 22:45:35 +00:00
|
|
|
|
2018-01-11 19:29:28 +00:00
|
|
|
/* ZDICT_trainFromBuffer_legacy() :
|
|
|
|
* issue : samplesBuffer need to be followed by a noisy guard band.
|
|
|
|
* work around : duplicate the buffer, and add the noise */
|
2017-06-27 04:07:14 +00:00
|
|
|
size_t ZDICT_trainFromBuffer_legacy(void* dictBuffer, size_t dictBufferCapacity,
|
|
|
|
const void* samplesBuffer, const size_t* samplesSizes, unsigned nbSamples,
|
|
|
|
ZDICT_legacy_params_t params)
|
2016-01-31 22:45:35 +00:00
|
|
|
{
|
2016-07-27 12:37:00 +00:00
|
|
|
size_t result;
|
2016-01-31 22:45:35 +00:00
|
|
|
void* newBuff;
|
2016-07-27 12:37:00 +00:00
|
|
|
size_t const sBuffSize = ZDICT_totalSampleSize(samplesSizes, nbSamples);
|
2016-08-30 16:56:25 +00:00
|
|
|
if (sBuffSize < ZDICT_MIN_SAMPLES_SIZE) return 0; /* not enough content => no dictionary */
|
2016-01-31 22:45:35 +00:00
|
|
|
|
|
|
|
newBuff = malloc(sBuffSize + NOISELENGTH);
|
|
|
|
if (!newBuff) return ERROR(memory_allocation);
|
|
|
|
|
|
|
|
memcpy(newBuff, samplesBuffer, sBuffSize);
|
2016-02-11 23:07:30 +00:00
|
|
|
ZDICT_fillNoise((char*)newBuff + sBuffSize, NOISELENGTH); /* guard band, for end of buffer condition */
|
2016-01-31 22:45:35 +00:00
|
|
|
|
2017-06-27 04:07:14 +00:00
|
|
|
result =
|
|
|
|
ZDICT_trainFromBuffer_unsafe_legacy(dictBuffer, dictBufferCapacity, newBuff,
|
|
|
|
samplesSizes, nbSamples, params);
|
2016-07-27 12:37:00 +00:00
|
|
|
free(newBuff);
|
|
|
|
return result;
|
2016-01-31 22:45:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-02-11 23:07:30 +00:00
|
|
|
size_t ZDICT_trainFromBuffer(void* dictBuffer, size_t dictBufferCapacity,
|
|
|
|
const void* samplesBuffer, const size_t* samplesSizes, unsigned nbSamples)
|
2016-01-31 22:45:35 +00:00
|
|
|
{
|
2018-08-23 19:06:20 +00:00
|
|
|
ZDICT_fastCover_params_t params;
|
2018-01-11 17:42:38 +00:00
|
|
|
DEBUGLOG(3, "ZDICT_trainFromBuffer");
|
2016-02-11 23:07:30 +00:00
|
|
|
memset(¶ms, 0, sizeof(params));
|
2017-06-27 04:07:14 +00:00
|
|
|
params.d = 8;
|
|
|
|
params.steps = 4;
|
2018-01-11 17:42:38 +00:00
|
|
|
/* Default to level 6 since no compression level information is available */
|
2018-08-23 19:06:20 +00:00
|
|
|
params.zParams.compressionLevel = 3;
|
2018-06-13 18:59:26 +00:00
|
|
|
#if defined(DEBUGLEVEL) && (DEBUGLEVEL>=1)
|
|
|
|
params.zParams.notificationLevel = DEBUGLEVEL;
|
2018-01-11 17:42:38 +00:00
|
|
|
#endif
|
2018-08-23 19:06:20 +00:00
|
|
|
return ZDICT_optimizeTrainFromBuffer_fastCover(dictBuffer, dictBufferCapacity,
|
2018-01-11 17:42:38 +00:00
|
|
|
samplesBuffer, samplesSizes, nbSamples,
|
|
|
|
¶ms);
|
2016-01-31 22:45:35 +00:00
|
|
|
}
|
2016-05-31 01:49:58 +00:00
|
|
|
|
|
|
|
size_t ZDICT_addEntropyTablesFromBuffer(void* dictBuffer, size_t dictContentSize, size_t dictBufferCapacity,
|
2018-01-11 17:42:38 +00:00
|
|
|
const void* samplesBuffer, const size_t* samplesSizes, unsigned nbSamples)
|
2016-05-31 01:49:58 +00:00
|
|
|
{
|
|
|
|
ZDICT_params_t params;
|
|
|
|
memset(¶ms, 0, sizeof(params));
|
|
|
|
return ZDICT_addEntropyTablesFromBuffer_advanced(dictBuffer, dictContentSize, dictBufferCapacity,
|
|
|
|
samplesBuffer, samplesSizes, nbSamples,
|
|
|
|
params);
|
|
|
|
}
|