Commit Graph

4413 Commits

Author SHA1 Message Date
Owen Taylor
d2b64a0b83 Sanitize move/resize code, removing various bad, non-functional hacks.
Fri Nov 30 16:37:01 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkcombo.c (gtk_combo_popup_list): Sanitize
	move/resize code, removing various bad, non-functional
	hacks. (Fixes #65048, reported by Damon Chaplin.)
2001-11-30 21:51:46 +00:00
Owen Taylor
845d3701f7 Patch from Hidetoshi Tajima to fix bad match error when target drawable is
Fri Nov 30 16:12:21 2001  Owen Taylor  <otaylor@redhat.com>
	* gdk/gdkpango.c: Patch from Hidetoshi Tajima to fix
	bad match error when target drawable is not the
	same depth as the root window. (#65841)
	* HACKING: Update.
2001-11-30 21:14:07 +00:00
Owen Taylor
2de8e8bf5e Fix alignment problem in deserialization, (#65785, reported by Hidetoshi
Fri Nov 30 15:55:34 2001  Owen Taylor  <otaylor@redhat.com>
	* gdk-pixdata.c (gdk_pixdata_deserialize): Fix
	alignment problem in deserialization, (#65785,
	reported by Hidetoshi Tajima)
2001-11-30 21:01:01 +00:00
Matthias Clasen
24aef23aab Typo fix.
* gdk/gdkwindow.c: Typo fix.

        * gtk/gtk-sections.sgml: Add GtkTextChildAnchor.

        * gdk/tmpl/dnd.sgml: Updates.

        * gdk/tmpl/pango_interaction.sgml: Document GdkPangoAttrEmbossed
        and GdkPangoAttrStipple.
2001-11-29 23:08:38 +00:00
Kristian Rietveld
209d0867e6 add checks for empty menu items to behave like insensitive items (#59456)
Thu Nov 29 21:35:56 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtkmenu.c (gtk_menu_motion_notify): add checks for
        empty menu items to behave like insensitive items (#59456)

        * gtk/gtkmenuitem.c (gtk_real_menu_item_activate_item): select
        next item if the first item in the menu is a tear off item
        (#59456-2, suggestion by Matthias Clasen)

        * gtk/gtkmenushell.c (gtk_menu_shell_button_press),
        (gtk_menu_shell_button_release), (gtk_menu_shell_entry_notify),
        (gtk_menu_shell_leave_notify), (gtk_real_menu_shell_move_current),
        (gtk_real_menu_shell_activate_current): add check, so empty
        menu items behave like insensitive items (#59456)

        * gtk/gtkmenuitem.[ch]: add _gtk_menu_item_is_selectable to make
        the checks more readable ...

        * gtk/gtkmenushell.c (gtk_menu_shell_button_press),
        (gtk_menu_shell_button_release): causes the menu to dropdown if the
        caption is clicked again (#64977)
2001-11-29 20:36:12 +00:00
Havoc Pennington
ddfc7377d4 assertion here that we were at the end iterator was not correct; change
2001-11-29  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextiter.c (_gtk_text_iter_forward_indexable_segment):
	assertion here that we were at the end iterator was not correct;
	change code to move us to the end iterator. bug #65731
2001-11-29 20:09:41 +00:00
Manish Singh
a0dd3bc884 Fill in missing error parameters to DecodeHeader and DecodeColormap.
2001-11-28  Manish Singh  <yosh@gimp.org>

        * gdk-pixbuf/io-bmp.c (gdk_pixbuf__bmp_image_load_increment): Fill
        in missing error parameters to DecodeHeader and DecodeColormap.
2001-11-29 01:39:34 +00:00
Owen Taylor
ea644d3572 Remove improper use of g_locale_to_utf8() to convert from latin-1, and do
Wed Nov 28 20:05:44 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkaccellabel.c (gtk_accel_label_refetch): Remove
	improper use of g_locale_to_utf8() to convert from
	latin-1, and do it the easy way by building the string
	correctly in the first place.
2001-11-29 01:15:52 +00:00
Owen Taylor
51f1c2a73c Convert atoms to and from atoms for properties of type XA_ATOM. (#65555,
Wed Nov 28 19:34:15 2001  Owen Taylor  <otaylor@redhat.com>
	* gdk/x11/gdkproperty-x11.c (gdk_property_change, gdk_property_get):
	Convert atoms to and from atoms for properties of type XA_ATOM.
	(#65555, patch from Hidetoshi Tajima)
2001-11-29 00:43:24 +00:00
Federico Mena Quintero
ab13c8803d Fix Ximian bug #12125; merged from gdk-pixbuf stable.
2001-11-21  Federico Mena Quintero  <federico@ximian.com>

	Fix Ximian bug #12125; merged from gdk-pixbuf stable.

	* gdk-pixbuf/io-bmp.c (gdk_pixbuf__bmp_image_load_increment): Use
	a simple state machine instead of a scary if/else chain.
	(DecodeHeader): Set the reading state.
	(DecodeColormap): Set the reading state.
	(decode_bitmasks): New function, decodes the bitmasks for
	BI_BITFIELDS coding.
	(OneLine32): Handle BI_BITFIELDS coding.
	(OneLine16): Likewise.
2001-11-29 00:13:02 +00:00
Owen Taylor
3e3322608c Rename 'id' parameter to avoid problems with Objective C.
Wed Nov 28 18:37:04 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtksocket.[ch] (gtk_socket_add_id): Rename 'id' parameter
	to avoid problems with Objective C.
2001-11-28 23:54:30 +00:00
Matthias Clasen
a381648faa Typo fixes. (#65607)
* gtk/gtkaccelmap.c: Typo fixes. (#65607)

        * gtk/gtkfixed.c (gtk_fixed_set_has_window, gtk_fixed_get_has_window):
        Fix docs. (#65505)

        * gtk/gtkwindow.c (gtk_window_set_mnemnonic_modifier): Document.

        * gtk/tmpl/gtkwindow.sgml: Document gtk_window_position.

        * gdk/tmpl/dnd.sgml: Document GdkDragProtocol and GdkDragContext.

        * gdk/tmpl/events.sgml: Document gdk_setting_get.

        * gdk/tmpl/fonts.sgml: Document gdk_font_full_name_get and
        gdk_font_full_name_free.

        * gdk/tmpl/windows.sgml: Document gdk_window_register_dnd.
2001-11-28 23:41:12 +00:00
Owen Taylor
476d2a84b7 Move accounting of menu->tearoff_scrollbar width to here and make sure we
Wed Nov 28 18:19:12 2001  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkmenu.c (gtk_menu_set_tearoff_hints): Move
        accounting of menu->tearoff_scrollbar width to here
        and make sure we have the correct requisition.

        * gtk/gtkmenu.c (gtk_menu_position): Fix fixme
        by using gtk_window_move().

        * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Force
        the requisition to be updated by calling
        gtk_widget_size_request() (#65440)

        * gtk/gtktearoffmenuitem.c (gtk_tearoff_menu_item_activate):
        queue resize before calling gtk_menu_set_tearoff_state().
2001-11-28 23:26:17 +00:00
Kristian Rietveld
2418e92303 fix typo
Wed Nov 28 22:20:44 2001  Kristian Rietveld  <kristian@planet.nl>

        * demos/gtk-demo/editable_cells.c: fix typo

        * demos/gtk-demo/list_store.c (add_columns): remove call to
        gtk_tree_view_column_set_clickable which didn't make sense
2001-11-28 21:19:40 +00:00
Havoc Pennington
53da925c9b put the warning explaining the validation error in front of the
2001-11-28  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_paint): put the warning
	explaining the validation error in front of the G_BREAKPOINT

	* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
	process updates with include_children = FALSE instead of TRUE, so
	we redraw the range only, not the whole darn window.  Making
	GtkRange a NO_WINDOW widget had weirdly caused the text widget
	Trace/breakpoint trap bug to become much easier to trigger.
2001-11-28 20:42:15 +00:00
Owen Taylor
931fe180ff Remove reference to gdkcursors.h.
Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
	* gdk/Makefile.am (gdk_public_h_sources): Remove reference
	to gdkcursors.h.
2001-11-28 19:32:18 +00:00
Matthias Clasen
fa7f30239b Add markup to docs.
* gtk/gtkwindow.c (gtk_window_move): Add markup to docs.
2001-11-28 19:08:36 +00:00
Matthias Clasen
af4bb73f59 gdk/tmpl/windows.sgml, gdk/tmpl/general.sgml,
gdk/tmpl/pixmaps.sgml, gdk/tmpl/drawing.sgml,
        gdk/tmpl/gcs.sgml: Updates.
2001-11-28 19:05:58 +00:00
Matthias Clasen
0b0b2b6483 forgotten Changelog entry. 2001-11-28 18:47:27 +00:00
Matthias Clasen
4ee972a5c9 Directly include the contents of gdkcursors.h in the GdkCursorType enum.
* gdk/gdkcursor.h: Directly include the contents
        of gdkcursors.h in the GdkCursorType enum.

        * gdk/gdkcursors.h: Deleted.

        * gdk/gdkkeysyms.h: Remove XFree86-specific keysyms, add
        header boilerplate.

        * gdk/Makefile.am: Remove the X-derived-headers rule.

        * gdk/tmpl/cursors.sgml: Document GdkCursor and standard cursors.
2001-11-28 18:38:43 +00:00
Carlos Perell Marn
04a076158e Some fixes.
2001-11-28  Carlos Perell Marn <carlos@gnome-db.org>

	* es.po: Some fixes.
2001-11-28 12:17:36 +00:00
Owen Taylor
488463ef21 Notify on the ::active property _here_, not in
Tue Nov 27 20:17:55 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkcheckmenuitem.c (gtk_check_menu_item_activate):
	Notify on the ::active property _here_, not in
	gtk_check_menu_item_set_active.
2001-11-28 01:20:14 +00:00
Jonathan Blandford
b2676e9229 add 2 properties (PIXBUF_EXPANDER_OPEN and PIXBUF_EXPANDER_CLOSED)
Mon Nov 26 19:11:18 2001  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkcellrendererpixbuf.c
	(gtk_cell_renderer_pixbuf_class_init): add 2 properties
	(PIXBUF_EXPANDER_OPEN and PIXBUF_EXPANDER_CLOSED)
2001-11-27 00:14:42 +00:00
Owen Taylor
6a252271fb Add long, but horribly sketchy comment about what is going on in this
Sun Nov 25 21:19:02 2001  Owen Taylor  <otaylor@redhat.com>
	* gdk/x11/gdkgeometry-x11.c: Add long, but horribly sketchy
	comment about what is going on in this file.
	* gdk/x11/gdkgeometry-x11.c (gdk_window_compute_position): Fix
	x/y problem.
2001-11-26 02:20:06 +00:00
Akira TAGOH
c117249322 Added -version-info.
2001-11-26  Akira TAGOH  <tagoh@redhat.com>

	* Makefile.am (libgdk_pixbuf_xlib_1_3_la_LDFLAGS):
	Added -version-info.
2001-11-26 00:42:29 +00:00
Owen Taylor
bc99cf97a2 Calculate size based on the _child_ of the menu item, not the menuitem.
Sun Nov 25 18:59:19 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkoptionmenu.c (gtk_option_menu_calc_size):
	Calculate size based on the _child_ of the menu item,
	not the menuitem. (#65005, Damon Chaplin)
	* gtk/gtklistitem.c (gtk_list_item_new_with_label): Add
	some extra vertical padding to the label widget ... restores
	GTK+-1.2 spacing. (#65085, Damon Chaplin.)
2001-11-26 00:19:31 +00:00
Tor Lillqvist
9a60bfac0c demos/pixbuf-demo.c M_PI -> G_PI.
2001-11-26  Tor Lillqvist  <tml@iki.fi>

	* demos/pixbuf-demo.c
	* demos/gtk-demo/pixbufs.c: M_PI -> G_PI.

	* demos/gtk-demo/main.c (read_line): No flockfile() or
	getc_unlocked() on Win32.

2001-11-25  Tor Lillqvist  <tml@iki.fi>

	* configure.in
	* acconfig.h: As we now use GDir, no need to check for dirent.h.
2001-11-25 23:36:29 +00:00
Kristian Rietveld
7a181cf52b free font_desc when finished (#65266)
Sun Nov 25 23:18:39 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtktexttag.c (gtk_text_tag_set_property): free font_desc
        when finished (#65266)

Sun Nov 25 23:16:29 2001  Kristian Rietveld  <kristian@planet.nl>

        * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): free
        data after we set the property. (#65264)

Sun Nov 25 23:14:06 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtkbutton.c: add destroy method so label_text gets freed
        if it has been allocated (#65268)
2001-11-25 22:19:22 +00:00
Manish Singh
dc0b9c8021 gdk/linux-fb/gdkdrawable-fb2.c update to latest Pango API
Sat Nov 24 13:39:51 2001  Manish Singh  <yosh@gimp.org>

        * gdk/linux-fb/gdkdrawable-fb2.c
        * gdk/linux-fb/gdkpango-fb.c: update to latest Pango API

        * gdk/linux-fb/gdkwindow-fb.c: implement gdk_window_show_unraised

        * gdk/linux-fb/gdkfont-fb.c (gdk_font_load): plug memleak on
        set_family

        * gdk/linux-fb/gdkfbswitch.c: minor cleanups
2001-11-24 21:52:50 +00:00
Kristian Rietveld
51eb87f3bd don't deactivate menu when menu_item isn't sensitive (#61389)
Sat Nov 24 22:05:27 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtkmenushell.c (gtk_menu_shell_button_release): don't
        deactivate menu when menu_item isn't sensitive (#61389)
2001-11-24 21:05:10 +00:00
Owen Taylor
38dfbda4bc Fix invalid UTF-8.
Sat Nov 24 13:19:58 2001  Owen Taylor  <otaylor@redhat.com>

	* nl.po: Fix invalid UTF-8.
2001-11-24 18:20:21 +00:00
Kristian Rietveld
b95c4f0bb3 free path before we return (in case of a failure here)
Sat Nov 24 15:35:26 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtktreemodel.c (gtk_tree_model_foreach): free path before
        we return (in case of a failure here)
2001-11-24 17:32:27 +00:00
Owen Taylor
4da8e00b62 Handle events in windows other than widget->event_window properly.
Fri Nov 23 19:22:50 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtknotebook.c: Handle events in windows other
	than widget->event_window properly. (#65079, reported
	by Damon Chaplin)
	* gdk/gdkevents.c (gdk_event_get_coords): Fix x/y bug.
2001-11-24 00:24:18 +00:00
Owen Taylor
06ac4f721b Align the image at the top, #65020, request from Seth Nickell)
Fri Nov 23 18:57:46 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkmessagedialog.c (gtk_message_dialog_init): Align
	the image at the top, #65020, request from Seth Nickell)
2001-11-24 00:05:17 +00:00
Dirk-Jan C. Binnema
ad9dc1b108 - fixes, additions, updates (dutch translation) 2001-11-24 00:04:16 +00:00
Owen Taylor
46a8d6e80d Remove some strange arithmetic that was resulting in rows being drawn too
Fri Nov 23 18:49:53 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/{gtkclist,gtkctree.c} (draw_row): Remove some strange
	arithmetic that was resulting in rows being drawn too low.
	(#65001, reported by Damon Chaplin)
2001-11-23 23:55:19 +00:00
Owen Taylor
1123956779 Offset invalidated range correctly. Fix scrolling of title window.
Fri Nov 23 18:36:42 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkrange.c (gtk_range_button_press): Offset
	invalidated range correctly.
	* gtk/gtkclist.c (hadjustment_value_changed): Fix scrolling
	of title window. (#65001, reported by Damon Chaplin)
	* gtk/gtkcombo.c (gtk_combo_button_event_after): Replace
	horrible hack with use of ::event_after.
2001-11-23 23:42:30 +00:00
Owen Taylor
2936c8e942 Version 1.3.11 Require GLib-1.3.11, Pango-0.22, ATK-0.7. Restore to
Thu Nov 22 15:01:03 2001  Owen Taylor  <otaylor@redhat.com>
        * Version 1.3.11
        * configure.in (ATK_REQUIRED_VERSION): Require
        GLib-1.3.11, Pango-0.22, ATK-0.7.
        * tests/prop-editor.c (property_widget): Restore
        to working as well as it did before.
        * gtk/gtklistitem.h: Mark deprecated since it is
        an integral part of GtkList.
        * demos/gtk-demo/demo-common.h: New header file,
        for a common functions not important to the meat
        of the demos.

        * demos/gtk-demo/main.c (demo_ifind_file): Add a utility
        function to search for a file used by the demo.
        * demos/*.c: Use demo_find_file.
2001-11-23 21:46:44 +00:00
Owen Taylor
393c47573e Add windows.sgml Revert last diff to get things to build.
Fri Nov 23 15:12:07 2001  Owen Taylor  <otaylor@redhat.com>
        * gtk/Makefile.am (content_files): Add windows.sgml
        * gdk/tmpl/cursors.sgml: Revert last diff to get things to
        build.
2001-11-23 20:44:13 +00:00
Matthias Clasen
dcfc387678 Actually commit typo fixes already mentioned in ChangeLog entry on
* gtk/gtktextbuffer.c (gtk_text_buffer_create_tag),
        gtk/gtkruler.c (gtk_ruler_get_metric): Actually commit typo
        fixes already mentioned in ChangeLog entry on 2001-11-14.

        * docs/reference/gdk/tmpl/drawing.sgml: Minor markup fixes.
2001-11-23 20:20:38 +00:00
Hans Breuer
36ddd7d958 reflect Pango API change
2001-11-23  Hans Breuer  <hans@breuer.org>

	* gdk/win32/gdkfont-win32.c (gdk_font_from_description) :
	reflect Pango API change

	* gtk/gtk.def : updated externals

	* gtk/gtkfixed.c (gtk_fixed_get_has_window) : use
	g_return_val_if_fail() to avoid 'function must return a value'

	* gtk/gtkrc.c : added spaces to fix small coding style issues
	* gtk/gtkwidget.c : ... and linebreaks. Also a static for
	'static correctness'

	* gtk/makefile.msc.in : temporary(?) disable gtk<plug|socket>
	because they only can be build on win32 after applying my patch
2001-11-23 16:05:39 +00:00
Matthias Clasen
a259f181fb Add better explanation of proximity events.
* gdk/tmpl/event_structs.sgml: Add better explanation of proximity
        events.

        * gdk/tmpl/cursors.sgml: Document GdkCursor and standard cursors.

        * gdk/images/*.png: The standard X cursors as pngs.

        * gdk/Makefile.am (HTML_IMAGES): Add the images.
2001-11-22 22:06:37 +00:00
Tim Janik
656ff6e8fa raise event window afte children, in order for the input pnly window to
Wed Nov 21 22:55:37 2001  Tim Janik  <timj@gtk.org>

        * gtk/gtkbutton.c (gtk_button_map): raise event window afte
        children, in order for the input pnly window to stay *above*
        children.

Wed Nov 21 22:44:27 2001  Tim Janik  <timj@gtk.org>

        * tests/testtreeview.c: make hackery worse ;) by checking fundamental
        type walks againts G_TYPE_FUNDAMENTAL_MAX.

        * tests/prop-editor.c: disable type hackery.
2001-11-21 23:49:17 +00:00
Owen Taylor
aa1a46e26b Fix problem with lost parameter.
Wed Nov 21 17:41:39 2001  Owen Taylor  <otaylor@redhat.com>

        * gdk/gdkimage.c (gdk_image_get): Fix problem with
        lost parameter.
2001-11-21 22:42:50 +00:00
Owen Taylor
9b6c73271f Remove trailing commas in enum declarations.
Wed Nov 21 17:01:25 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtkcellrenderer.h gtk/gtktreemodel.h
	gtk/gtktreeprivate.h gtk/gtktreesortable.h: Remove
	trailing commas in enum declarations.
2001-11-21 22:08:09 +00:00
Owen Taylor
bffb11e1d6 Version 1.3.11, interface, binary age 0.
Wed Nov 21 15:21:26 2001  Owen Taylor  <otaylor@redhat.com>

	* configure.in (GTK_MICRO_VERSION): Version 1.3.11,
	interface, binary age 0.

	* NEWS: Updates

	* gtk/gtktreemodel.c gtk/gtkrc.c gtk/gtkentry.c: SGML
	fixes in docs.

	* gtk/gtkmain.h: Remove unused and misnamespaced
	get_gtk_win32_directory() prototype.

	* gdk/gdkimage.c (gdk_image_get): Fix parameter names
	to match header.

	* gdk/gdkwindow.h: Fix parameters to gdk_window_shape_combine_mask(),
	gdk_window_set_transient_for(), gdk_window_set_geometry_hints(),
	to match docs.

	* gdk/gdkevents.c (gdk_event_get_coords)
	  gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_get_active)
	  gtk/gtkdnd.c (gtk_drag_set_icon_stock):
	Fix parameter names in docs.

	* docs/faq/Makefile.am (FAQ_FILES): Add missing files.
	(#64961, Akira Tagoh)
2001-11-21 21:44:08 +00:00
Owen Taylor
b56118cf13 Updates
Wed Nov 21 15:57:29 2001  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtk-sections.txt: Updates

        * gtk/tmpl/gtkstock.sgml: Close end tags.

        * gtk/gtk.types: Remove interface types which gtk-doc
        can't handle currently.

        * gtk/tmpl/gtknotebook.sgml: Fix some garbage in file.

        * gdk/tmpl/x_interaction.sgml: Fix SGML errors.

        * gdk/gdk-overrides.txt gdk/gdk-sections.txt: Updates.
2001-11-21 21:43:47 +00:00
Owen Taylor
c860866dd7 Ref-sink the tooltips object. Ref-sink the tooltips object. Fix some
Wed Nov 21 11:41:29 2001  Owen Taylor  <otaylor@redhat.com>
	* tests/testgtk.c (create_tooltips): Ref-sink the tooltips object.
	* gtk/gtktoolbar.c (gtk_toolbar_init): Ref-sink the tooltips object.
	* gtk/gtkfilesel.c (open_new_dir): Fix some constness warnings.
	* gtk/gtkaccelgroup.c: Rename gtk_accel_groups_from_acceleratable()
	back to gtk_accel_groups_from_object(), change @acceleratable
	parameter to gtk_accel_groups_activate() accordingly.
	* gtk/gtkaccelmap.c (gtk_accel_map_lookup_entry): Remove
	left-over comment about quark return.
	* gtk/gtkaccelmap.h: Fix spelling of gtk_accel_map_foreach_unfiltered().
 	* gtk/gtk-boxed.defs (GtkIconSource): added as a boxed type.
        (Patch from Matt Wilson)
	* gtk/gtkobject.c (gtk_object_finalize): Warn if a floating
	object is finalized.
2001-11-21 17:04:35 +00:00
Havoc Pennington
d5db986a0b fix docs for gtk_window_set_policy() to reflect existence of
2001-11-20  Havoc Pennington  <hp@pobox.com>

	* gtk/tmpl/gtkwindow.sgml: fix docs for gtk_window_set_policy() to
	reflect existence of gtk_window_set_resizable()
2001-11-21 03:08:56 +00:00
Tim Janik
9800f731e0 applied patch from owen to get rid of accel map notifiers. changed things
Tue Nov 20 21:25:08 2001  Tim Janik  <timj@gtk.org>

	* applied patch from owen to get rid of accel map notifiers.
	changed things to fix reentrancy and API as discussed on gtk-devel.

	* gtk/gtkaccelgroup.[hc]:
	(gtk_accel_group_finalize): unregister this accel group from all
	accel map paths.
	(accel_closure_invalidate): handle invalidation of closures by
	disconnecting their accelerators.
	(quick_accel_add): move closure connection and changed notification
	into this function to reduce code duplication. don't emit change
	notification on closurers without accelerators.
	(quick_accel_remove): rewrite, do the exact opposite of quick_accel_add
	for a GtkAccelGroupEntry.
	(gtk_accel_group_connect): get rid of the accel_path_quark argument.
	(gtk_accel_group_connect_by_path): new function to add accelerators
	with an accel path.
	(gtk_accel_group_disconnect_closure): new function, disconnect a
	closure from of an accel group.
	(gtk_accel_group_disconnect): loop over all closure for a accel_ley,
	accel_mods pair and remove them.
	(_gtk_accel_group_reconnect): new function that basically does
	gtk_accel_group_disconnect_closure() and
	gtk_accel_group_connect_by_path() once an accel path changed.
	(gtk_accel_groups_disconnect_closure): remove this, there's
	gtk_accel_group_disconnect_closure().

	* gtk/gtkaccelmap.[hc]: keep list of accel groups per entry now,
	nuke notifiers.
	(_gtk_accel_path_is_valid): make this non-static for
	gtkwidget.c and gtkaccelgroup.c assertions.
	(gtk_accel_map_add_notifer): removed this function.
	(gtk_accel_map_remove_notifer): same.
	(_gtk_accel_map_add_group):
	(_gtk_accel_map_remove_group): (un-)register accel groups, with
	accel paths for correct propagation.
	(gtk_accel_map_add_entry): return void.
	(gtk_accel_map_lookup): return gboolean instead of GQuark.

	* gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): always
	set accel_path on widgets.

	* gtk/gtkwidget.[hc]:
	(accel_path_changed): got rid of this, changes are handled by
	accel maps internally now.
	(_gtk_widget_set_accel_path): get things to work without notifiers.
	(gtk_widget_list_accel_closures): list accel closures of a widget.

	* gtk/gtkwindow.[hc]: rename ::accels_changed, to ::keys_changed.
2001-11-20 23:43:03 +00:00