AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5,777 Commits 1 Branch 0 Tags 55 MiB
743ef31761
Commit Graph

4524 Commits

Author SHA1 Message Date
Behdad Esfahbod
c1ab95dd90 Fix overflow in space fallback shaping 
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=657466
 2018-02-08 17:22:07 -06:00
Behdad Esfahbod
b220b5a444 Avoid undefined-behavior in fallback mark positioning 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5584
 2018-02-08 17:14:52 -06:00
Behdad Esfahbod
3b68a03a1c [fuzzer] Minor 2018-02-08 17:00:37 -06:00
Behdad Esfahbod
5021ba2a21 [aat] Minor 2018-02-08 15:11:28 -06:00
Behdad Esfahbod
77ad8b5c8b TODO 2018-02-07 21:54:33 -06:00
Behdad Esfahbod
941bbd9f25 [subset] Fix thinko 2018-02-07 21:49:01 -06:00
Behdad Esfahbod
931f8b7eb5 Fix another thinko 2018-02-07 21:42:03 -06:00
Behdad Esfahbod
39b86695cf [subset] Fix thinko 2018-02-07 21:37:03 -06:00
Behdad Esfahbod
eeffabc875 Build 2018-02-07 21:34:05 -06:00
Behdad Esfahbod
c479a59988 [subset] Assemble font 2018-02-07 21:26:04 -06:00
Behdad Esfahbod
34ac3548b7 [set] Respect stride 
Ouch!
 2018-02-07 18:07:45 -06:00
Behdad Esfahbod
577becaf7b [subset] Fixup 2018-02-07 17:38:40 -06:00
Behdad Esfahbod
c9acab3cfb Whitespace 2018-02-07 17:28:43 -06:00
Behdad Esfahbod
7fd0b61dee [subset] Create new face and copy all tables to it 
test-subset fails now because subset-face does not know how to compile itself.
 2018-02-07 17:28:43 -06:00
Garret Rieger
4e1abe2ce0 Refactor subset glyf to remove multiple calls to glyf.fini() 2018-02-07 17:28:43 -06:00
Garret Rieger
0a5d1440f8 Add implementation of glyf subsetting. 2018-02-07 17:28:43 -06:00
Garret Rieger
05d65baa1b Extract glyf offset calculation into it's own method. 2018-02-07 17:28:43 -06:00
Behdad Esfahbod
6d7c6e19dc Fix two undefined-behavior issues 
Fixes https://github.com/harfbuzz/harfbuzz/issues/761
Fixes https://github.com/harfbuzz/harfbuzz/issues/762
 2018-02-07 14:09:56 -06:00
Behdad Esfahbod
b87cbe2bec Try fixing build for platforms that have no visibility attributes 2018-02-07 14:11:26 -05:00
Behdad Esfahbod
6804b61d2e [subset] Add hb_subset_face 
It's a hb_face_t that has add_table() and in the future knows how to
compile itself into a font blob.
 2018-02-07 13:47:35 -05:00
Behdad Esfahbod
af02812fc5 [subset] Change hb_subset API to remove hb_subset_face_t 2018-02-07 13:07:46 -05:00
Behdad Esfahbod
2da0d87e76 Remove NullPool visibility hack 
We keep a separate private NullPool in libharfbuzz-subset.so
This can fire back later since now there are two separate null objects,
and comparisons to the null pool can be confused.  Something to deal
with when it comes up. Ouch!
 2018-02-07 12:44:35 -05:00
Rod Sheeter
b95aa204ee glyph ids to retain should most likely keep the glyph id not the codepoint 2018-02-07 12:41:21 -05:00
Rod Sheeter
91428713bd Remove \ns leftover from fprintf 2018-02-07 12:41:21 -05:00
Rod Sheeter
eb485bb9e9 Horrid hack to assign new gids. Use DEBUG_MSG over fprintf 2018-02-07 12:41:21 -05:00
Rod Sheeter
8b80cbb1dd Add a subset debug category 2018-02-07 12:41:21 -05:00
Behdad Esfahbod
ee433d36fa [aat] Set debug lookup_index 2018-02-07 12:41:21 -05:00
Rod Sheeter
38df1ec8e0 TEMPORARY: remove HB_INTERNAL from null pool so subset builds again 2018-02-07 12:41:21 -05:00
Garret Rieger
53aa0e9542 Add an instance of glyf::accelerator_t to hb-subset-glyf. 2018-02-07 12:41:21 -05:00
Rod Sheeter
ef62dfed3f add back assert_pod 2018-02-07 12:41:21 -05:00
Rod Sheeter
d0ce3c66e2 Resolve codepoints:glyph ids. Does not compile; undefined reference to OT::_hb_NullPool 2018-02-07 12:41:21 -05:00
Garret Rieger
6a45e5df24 Add skeleton of hb-subset-glyf, call if from hb_subset(...) 2018-02-07 12:41:21 -05:00
Garret Rieger
31ec3c2ec4 Create a subset plan in hb_subset. 2018-02-07 12:41:21 -05:00
Garret Rieger
25e9173fe8 Make hb-subset-plan private. 2018-02-07 12:41:21 -05:00
Garret Rieger
af46a4da5a Move definition of hb_subset_input into hb-subset-private.hh. 2018-02-07 12:41:21 -05:00
Garret Rieger
7481f0ce21 Add codepoints to subset input. 2018-02-07 12:41:21 -05:00
Garret Rieger
1cfe650f02 Add a basic sketch of hb-subset-plan. 2018-02-07 12:41:21 -05:00
Behdad Esfahbod
126ffdbe95 [aat] Fix debug compile 2018-02-07 12:26:57 -05:00
Behdad Esfahbod
2971e9da49 [aat] Adjust unsafe-to-break logic some more 
I believe I'm happy with it now.
 2018-02-06 11:48:04 -05:00
Behdad Esfahbod
f49256d80f [aat] Simplify unsafe-to-break logic 2018-02-06 11:39:36 -05:00
Behdad Esfahbod
cc1e0840ba [buffer] Tweak diff re glyph_flags again 
We expect the buffer to have no flags that the reference doesn't...
Meh. Makes MORX tests pass now. Need to better define the behavior.
 2018-02-06 10:20:48 -05:00
Ebrahim Byagowi
d49ae5154e Fix hb-buffer logic error 2018-02-06 10:13:11 -05:00
Behdad Esfahbod
f41b92134a Fix fallthrough compiler warning with gcc >= 7 
Fixes https://github.com/harfbuzz/harfbuzz/issues/755
 2018-02-05 19:51:09 -05:00
Behdad Esfahbod
0ff007daaa [subset] Minor 2018-02-05 19:36:38 -05:00
Behdad Esfahbod
ae39fc8171 [subset] Build hb-subset into separate libharfbuzz-subset.so 2018-02-04 20:18:52 -05:00
Behdad Esfahbod
257022b178
Merge pull request #745 from googlefonts/master 
Interface for hb_subset, skeleton for the hb-subset cli, and basic testing rigging.
 2018-02-04 20:01:35 -05:00
Behdad Esfahbod
54e6efadd6 [aat] Fix unsafe-to-break 
At any position, if state is not zero, mark unsafe-to-break before,
unless we can reason it safe.

At any position, if there's an action entry for end-of-text, mark
unsafe to break.

Also changes buffer diff impl to allow for flag differences as long
as the buffer glyph flags are superset of reference glyph flags.

With this, all MORX tests pass.
 2018-02-04 17:18:54 -05:00
Garret Rieger
f83a43b561 Add CMake configuration for all of the new subsetting code. 2018-02-04 12:57:34 -08:00
Garret Rieger
34fa7b3ad2 Whitespace 2018-02-04 12:57:34 -08:00
Garret Rieger
8c3a672737 Get test-subset to pass. 2018-02-04 12:57:34 -08:00
Garret Rieger
74d39ed263 Attach add a hb_face_t to hb_subset_face_t. 2018-02-04 12:57:34 -08:00
Garret Rieger
a2965f2ea5 Add a basic implementation of hb-subset to enable compilation of test-subset. 2018-02-04 12:57:33 -08:00
Garret Rieger
cf403e1a53 Add hb-subset.h to hb.h 2018-02-04 12:57:33 -08:00
Garret Rieger
c02573516c Fix typo in hb-subset.h 2018-02-04 12:57:33 -08:00
Rod Sheeter
9ccb8366f6 Start to sketch APIs for subsetting 2018-02-04 12:57:33 -08:00
Behdad Esfahbod
89b1906d99 [aat] More adjustment to ContextualSubtable 
See comment.

With this, MORX-20 passes if I turn --verify off.  Our unsafe-to-break
logic is currently broken in presence of end-of-text actions.  That's,
ugh, extra work to fix.  Let me try...
 2018-02-04 14:45:02 -05:00
Behdad Esfahbod
8be596f0b7 [aat] In ContextualSubstitute, apply end-of-text action to last glyph 2018-02-04 14:40:17 -05:00
Behdad Esfahbod
c0b1c7eb2e [aat] Remove unneeded check 2018-02-04 14:19:41 -05:00
Behdad Esfahbod
aed32589af [aat] In ContextualSubtable, mark mark after substituting mark 
Fixes MORX-21.
 2018-02-04 12:36:54 -05:00
Behdad Esfahbod
fe5f9b1ae3 [aat] Fix ContextualSubtable sanitization 
Fixes MORX-18, MORX-19, and MORX-22.
 2018-02-04 12:36:54 -05:00
Bruce Mitchener
e8859fca3e Enable use of atexit() on macOS and related platforms. 
The atexit() man page indicates that this is expected to behave
in the expected way on unloading of shared libraries.
 2018-02-03 19:20:40 -08:00
Bruce Mitchener
a89573770b Use nullptr, not NULL. 2018-02-03 21:26:58 +02:00
David Corbett
ccb0367dae Let VS1 follow U+1031 MYANMAR VOWEL SIGN E 2018-02-02 12:41:07 -08:00
punchcutter
c6dbf6e77c Allow optional ZWJ in virama terminated cluster 2018-01-31 14:16:25 -08:00
Bruce Mitchener
dae20fb5a7 Use nullptr instead of 0. 2018-01-31 08:18:48 -08:00
Bruce Mitchener
90218fa93c Fix typos. 2018-01-31 08:18:15 -08:00
Bruce Mitchener
148ca61075 [ot-layout] Fix nullptr dereference. 
If the `calloc` for `gsub_accels` or `gpos_accels` fails, then the
unlikely branch afterwards can be taken, which frees up the
`hb_ot_layout_t`, but since those fields can now be `nullptr`, then
we don't want to dereference them.
 2018-01-31 08:05:25 -08:00
Bruce Mitchener
0c66043a92 [coretext] Fix memory leaks. 
In `reference_table`, if the data is empty and we return early,
we still need to release the data object.

In `hb_coretext_shape`, there two edge cases where an early
return should release the attributed string.
 2018-01-31 08:04:15 -08:00
Behdad Esfahbod
e89df6e1ae [aat] Limit number of DontAdvance transitions 
Remove the faulty loop-detection logic. Use max-ops for breaking
out of infinite loops or heavy work.

https://twitter.com/behdadesfahbod/status/958065026262183936
 2018-01-30 11:01:18 -08:00
Ebrahim Byagowi
55cae0d72e
[test] Use 'otool -L' where ldd doesn't exist (macOS) (#732) 2018-01-29 18:05:24 +03:30
David Corbett
2ec7dd1f6c Fix Travis build on macOS (#731) 2018-01-29 02:18:28 +03:30
Behdad Esfahbod
12757b6929 Misc warning fixes 
Fixes https://github.com/harfbuzz/harfbuzz/issues/712
 2018-01-26 18:14:05 -08:00
bungeman
85be365ed9 Use KernSubTableFormat2::rightClassTable 
Issue originally reported at http://cppfiles.com/chromium.txt .

This fixes what appears to be a copy - paste issue which causes both
KernSubTableFormat2::rightClassTable and the 'right' argument to
KernSubTableFormat2::get_kerning to go unused.
 2018-01-26 15:20:18 -08:00
Bruce Mitchener
19a93fcf19 Fix typos. 2018-01-21 10:33:54 -08:00
Behdad Esfahbod
51ce3828e6 [aat] Fix Ligature matching 
I hope... Makes "ffi" work with Zapfino. I'm not sure if doing it correctly though...
 2018-01-19 18:37:58 -08:00
Behdad Esfahbod
bef509855c [aat] Add TODO 2018-01-19 18:24:00 -08:00
Behdad Esfahbod
e6f283ed7d [aat] Implement LigatureSubtable 
We form the Zapfino ligature now. Yay! No further testing done.
 2018-01-19 18:09:48 -08:00
Behdad Esfahbod
f07ce661a2 [aat] Embed a sanitizer context in hb_aat_apply_context_t 
For run-time checking.
 2018-01-19 16:52:01 -08:00
Behdad Esfahbod
046690a4df [aat] Add hb_aat_apply_context_t 2018-01-19 16:40:13 -08:00
Behdad Esfahbod
fd03449094 Rename hb_apply_context_t to hb_ot_apply_context_t 2018-01-19 16:40:13 -08:00
Behdad Esfahbod
94b49beee9 Whitespace 2018-01-19 16:40:13 -08:00
Cosimo Lupo
c8f2a4f5b9 hb-common.cc: Hatran script is right-to-left (#714) 
"Hatran is written from right to left horizontally"

http://www.unicode.org/L2/L2012/12312-n4324-hatran.pdf

This ancient script was added with Unicode 8.0.

Also this spreadsheet (referenced in an inline comment in the
source code) has it as RTL: http://goo.gl/x9ilM
 2018-01-19 01:19:40 +03:30
Ebrahim Byagowi
00806149b9
Improve avoiding C++ linkage, definition creation and cmake tests (#710) 2018-01-19 01:12:31 +03:30
Behdad Esfahbod
461a605fde [aat] Allocate set dynamically 2018-01-17 10:02:48 -08:00
Behdad Esfahbod
949f6af289 Disallow sanitize recursing into Extension subtables multiple times 
Fixes https://oss-fuzz.com/v2/testcase-detail/5216838347653120
which is a stack overflow, not by way of infinite recursion, just
being deep.  That's disallowed anyway, so catch it as it happens,
not afterwards.
 2018-01-15 20:44:10 -05:00
Behdad Esfahbod
bcb6f1ae0a Whitespace 2018-01-15 20:34:05 -05:00
Behdad Esfahbod
12fffce10e [aat] Sanitize classTable in StateTable 2018-01-15 15:41:51 -05:00
Behdad Esfahbod
e6263c7142 [aat] Wire up table length to apply() 2018-01-15 15:37:55 -05:00
Behdad Esfahbod
679ae744d0 [aat] Towards implementing LigatureSubtable 2018-01-14 15:03:31 -05:00
Behdad Esfahbod
c9e12a2b9b Fix set initializer 2018-01-13 17:05:12 +00:00
Behdad Esfahbod
9009b341c4 [aat] Fix some struct sizes 
I hate it that with my compiler at least, it doesn't catch totally uncompilable
statements in templates if they are not used...
 2018-01-12 12:04:53 +01:00
Behdad Esfahbod
57051b4f67 [aat] Flush rest of buffer if state machine failed 2018-01-12 11:42:25 +01:00
Behdad Esfahbod
25364c4f00 [aat] Fix symbol visibility 
Not sure why only one of the bots sees this as visible...
 2018-01-12 11:31:20 +01:00
Behdad Esfahbod
ee16b9d8d3 Revert accidental morx enablement 2018-01-12 11:28:09 +01:00
Behdad Esfahbod
cdfa801ff4 [aat] Tweak previous commit 2018-01-12 11:12:20 +01:00
Behdad Esfahbod
f7600228a4 [aat] Detect infinite-loops in state machine 2018-01-12 11:09:21 +01:00
Behdad Esfahbod
dd38db523a [aat] Fix more builds 
Maybe I should disable C++11 detection such that my compiler also catches
these.  Doesn't look like we can switch to it for a while anyway...
 2018-01-12 09:45:42 +01:00
Behdad Esfahbod
72cb2b1f57 [aat] Fix builds 2018-01-12 09:38:55 +01:00
Ting-Wei Lan
e3a15d0c6d Update _POSIX_C_SOURCE to the latest version 
Defining _POSIX_C_SOURCE to an old version on FreeBSD can cause C99 to
be disabled in libc.
 2018-01-12 09:19:41 +01:00
Behdad Esfahbod
c70d58f97d [aat] Port RearrangementSubtable to StateTableDriver 2018-01-12 00:08:22 +01:00
Behdad Esfahbod
117cfe7bb7 [aat] Add StateTableDriver and convert ContextualSubtable to it 2018-01-12 00:01:36 +01:00
Behdad Esfahbod
1f1c85a54a [aat] Remove 'mort' support 
It's dead, Jim!
 2018-01-11 22:43:57 +01:00
Behdad Esfahbod
7e2fed6d73 [aat] Allow DontAdvance 
Apparently CoreText does allow these.  To be done: detect infinite
loops.

Fixes MORX-12 test.
 2018-01-11 19:25:21 +01:00
Behdad Esfahbod
17f01aff91 [aat] Sanitize ContextualSubtable 2018-01-11 18:54:49 +01:00
Behdad Esfahbod
9b82aa19d8 More warning fixes 2018-01-11 18:19:42 +01:00
Behdad Esfahbod
680cbc2eb3 [aat] Sanitize StateTable 2018-01-11 18:15:53 +01:00
Behdad Esfahbod
0e3b3379a0 [aat] Actually fix d887f93148 2018-01-11 18:01:10 +01:00
Behdad Esfahbod
3f291ffd5a [buffer] Fix compiler warnings 
line 323: Warning: info hides hb_buffer_t::info
...
 2018-01-11 17:57:46 +01:00
Behdad Esfahbod
d887f93148 [aat] Make bots happy 
Don't know why this is not caught by my compiler.  Looks like clang catches it
while gcc doesn't.

In file included from ../src/hb-aat-layout-morx-table.hh:31:
../src/hb-aat-layout-common-private.hh:523:30: error: no member named 'static_size' in 'AAT::ContextualSubtable<AAT::MorxTypes>::EntryData'
  DEFINE_SIZE_STATIC (4 + T::static_size);
                            ~~~^
 2018-01-11 17:41:34 +01:00
Behdad Esfahbod
f6be730994 [aat] In NoncontextualSubtable, handle MarkLast with end-of-line transition 
Fixes MORX-11 test.
 2018-01-11 15:23:24 +01:00
Behdad Esfahbod
f9be673814 [aat] Implement ContextualSubtable 
Tested with Zapfino and text "2nd". Sascha will create tests later.
 2018-01-11 15:15:36 +01:00
Behdad Esfahbod
335a9c1fe4 [aat] Towards implementing ContextualSubtable 2018-01-11 15:15:36 +01:00
Behdad Esfahbod
62348f647f [aat] Implement end-of-text in state machine 
Passes MORX-10 test now.
 2018-01-11 15:15:36 +01:00
Behdad Esfahbod
9adbd938fa Minor 2018-01-11 15:15:36 +01:00
Behdad Esfahbod
94644d7ea4 [aat] Generate finegrained unsafe-to-break in state-machine! 
Neato.
 2018-01-11 11:49:07 +01:00
Behdad Esfahbod
994eb7744c [buffer] Fix crash 2018-01-11 11:37:12 +01:00
Behdad Esfahbod
7c32e01d04 Minor 2018-01-11 10:47:31 +01:00
Behdad Esfahbod
14b4d84eef [aat] Fix RearrangementSubtable action 2018-01-11 10:43:30 +01:00
Behdad Esfahbod
800e4ae802 [aat] Mark state-machine-based lookup as completely unsafe-to-break 
To be improved later.
 2018-01-11 10:43:30 +01:00
Behdad Esfahbod
ca42d96129 [aat] Implement RearrangementSubtable 2018-01-11 10:43:30 +01:00
Ebrahim Byagowi
5dbbd0fdb9
Move the #define of _GNU_SOURCE to the top of hb-private.hh (#697) 
This fixes the build on Cygwin.
 2018-01-11 12:33:22 +03:30
Behdad Esfahbod
80fd574320 [aat] Add Class subtable thingy 
From old 'mort' table.
 2018-01-10 13:58:41 +01:00
Khaled Hosny
0b22da9541 Improve HB_BUFFER_SERIALIZE_FLAG_NO_ADVANCES docs 
Add the note about absolute glyph positions from the commit message.
 2018-01-10 07:12:07 +02:00
Behdad Esfahbod
188ee6e5ee Calculate anchor positions in float, then round 
Hoping to reduce rounding error, to make tests happier...
No luck.
 2018-01-10 05:13:47 +01:00
Behdad Esfahbod
7cdd6ab068 Round, instead of floor, when applying variations 
Hoping this would fix remaining text-rendering-tests failures,
but so far no luck.
 2018-01-10 04:44:33 +01:00
Behdad Esfahbod
3b1e97f364 Add HB_BUFFER_FLAG_REMOVE_DEFAULT_IGNORABLES 
New API:
HB_BUFFER_FLAG_REMOVE_DEFAULT_IGNORABLES
hb-shape / hb-view --remove-default-ignorables

One more text-rendering-tests test passing.  Eleven failing.
 2018-01-10 03:36:03 +01:00
Behdad Esfahbod
6b19178ee3 Prefix int types with HB 
Such a headache that Windows defines UINT8, ...; Just prefix it.
 2018-01-10 03:07:30 +01:00
Behdad Esfahbod
81e321c802 [aat] Try fixing VC bots 
c:\projects\harfbuzz\src\hb-aat-layout-common-private.hh(51): error C2872: 'UINT16': ambiguous symbol [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.14393.0\shared\basetsd.h(80): note: could be 'unsigned short UINT16'
c:\projects\harfbuzz\src\hb-open-type-private.hh(648): note: or       'OT::UINT16'
 2018-01-10 02:56:29 +01:00
Behdad Esfahbod
0ed69c9462 Disable processing of morx table in ot shaper 
So I can merge this to master...
 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
5f94b4cc39 [kern] Mark unsafe-to-break 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
71fd6325b6 Add option to buffer serialization to not output glyph advances 
When advances are not printed, glyph offsets reflect absolute glyph
positions.

New API:
HB_BUFFER_SERIALIZE_FLAG_NO_ADVANCES
hb-shape --no-advances
 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
748b989a1f [aat/morx] Implement NoncontextualSubtables 
Also makes hb-ot-shape call morx for now instead of GSUB... Just for testing.
 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
4cf3ab1d81 Minor 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
470fe5b603 [aat] Implement Lookup table 
Untested, but compiles.
 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
4646a80a87 Minor 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
7c7cb42d81 [aat] Update previous commits for rebase on master 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
a0175e75bc [aat] Start implementing common table formats 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
c71b55a223 [aat] Start implementing Apple AAT morx table 2018-01-10 02:50:49 +01:00
Behdad Esfahbod
0473d95e27 [ft] Use FT_Done_MM_Var() if available 2018-01-08 10:07:46 +00:00
Behdad Esfahbod
66d7beff96 [khmer] Relax! 
Apparently we don't use OT_A either.
 2018-01-05 18:10:25 +00:00
Behdad Esfahbod
db0207baff [khmer] Drop another joiner 2018-01-05 18:06:00 +00:00
Behdad Esfahbod
90affe831f [khmer] Shuffle 2018-01-05 18:04:56 +00:00
Behdad Esfahbod
65795e3ca2 [khmer] Simplify grammar some more 
Numbers down (from 38):

KHMER: 299090 out of 299124 tests passed. 34 failed (0.0113665%)
 2018-01-05 18:03:00 +00:00
Behdad Esfahbod
e13ee93731 [khmer] Clean 2018-01-05 18:01:01 +00:00
Behdad Esfahbod
a71c7eb2ca [khmer] Limit number of joiners 2018-01-05 17:59:43 +00:00
Behdad Esfahbod
574e42e1cf [khmer] Relax number of consonants / matras allowed 
New numbers (down from 39):

KHMER: 299086 out of 299124 tests passed. 38 failed (0.0127038%)
 2018-01-05 17:58:02 +00:00
Behdad Esfahbod
80c870bcda [khmer] Allow Independent Vowels where stacked consonants are allowed 
New numbers (down from 44):

KHMER: 299085 out of 299124 tests passed. 39 failed (0.0130381%)
 2018-01-05 17:54:52 +00:00
Behdad Esfahbod
9bd486c480 [khmer] Drop some more joiners 2018-01-05 17:47:35 +00:00
Behdad Esfahbod
5278265853 [khmer] Drop some more 2018-01-05 17:46:49 +00:00
Behdad Esfahbod
efefd87f33 [khmer] Drop some more grammar 2018-01-05 17:45:48 +00:00
Behdad Esfahbod
82e6bf8e0c [khmer] Drop some more from grammar 2018-01-05 17:44:18 +00:00
Behdad Esfahbod
957e8ea8a9 [khmer] Drop final_halant_group 2018-01-05 17:43:31 +00:00
Behdad Esfahbod
bbfdbbdc5e Minor 2018-01-05 17:34:26 +00:00
Behdad Esfahbod
f6df251521 [indic] Remove unused OT_VD category 2018-01-05 17:27:48 +00:00
Behdad Esfahbod
e6618f3bdf [khmer] Shave off some more from the grammar 2018-01-05 17:27:42 +00:00
Behdad Esfahbod
014494d5c0 [khmer] Remove unused symbol clusters 2018-01-05 17:18:12 +00:00
Behdad Esfahbod
bbac984b93 Minor 2018-01-05 17:15:31 +00:00
Behdad Esfahbod
185b68946a [khmer] Remove medials from grammar 2018-01-05 17:14:27 +00:00
Behdad Esfahbod
c265dffdf6 [khmer] Better fix for dangling final Coeng 
This is how 1471cfee3b should have
been done.
 2018-01-05 17:06:29 +00:00
Behdad Esfahbod
e3fdf1fc2f [khmer] Remove reph/repha support from grammar 2018-01-05 17:05:53 +00:00
Behdad Esfahbod
0d3a274de1 [khmer] Remove forced_rakar from grammar 
Used by Sinhala only.
 2018-01-05 17:01:37 +00:00
Behdad Esfahbod
1471cfee3b [khmer] Allow a dangling final Coeng after matras 
Uniscribe seems to allow that.  New numbers:

KHMER: 299080 out of 299124 tests passed. 44 failed (0.0147096%)
 2018-01-05 16:34:20 +00:00
Behdad Esfahbod
9eaf077ded [khmer] Remove some more unused code 2018-01-05 16:28:00 +00:00
Behdad Esfahbod
bfad6ab897 [khmer] Remove features not used by Khmer 2018-01-05 16:13:09 +00:00
Behdad Esfahbod
92a99ce084 [khmer] Remove rphf feature 2018-01-05 16:08:44 +00:00
Behdad Esfahbod
238b90e77c [khmer] Remove non-Khmer matra positioning code 2018-01-05 16:06:53 +00:00
Behdad Esfahbod
f8553c898a [khmer] Remove indic_config_t 2018-01-05 16:04:02 +00:00
Behdad Esfahbod
a119a8bce5 [khmer] Remove indic_config->reph_mode 2018-01-05 16:02:55 +00:00
Behdad Esfahbod
c135324af1 [khmer] Remove indic_config->reph_pos 2018-01-05 16:02:55 +00:00
Behdad Esfahbod
ffcd6c7efd [khmer] Remove indic_config->base_pos 2018-01-05 15:50:05 +00:00
Behdad Esfahbod
0c91638d48 [khmer] Remove other scripts 2018-01-05 15:45:30 +00:00
Behdad Esfahbod
4c0199c573 [khmer] Remove indic_config->script 2018-01-05 15:43:48 +00:00
Behdad Esfahbod
9b135d9524 [khmer] Remove indic_config->virama 2018-01-05 15:43:11 +00:00
Behdad Esfahbod
7eb3ac29d3 [khmer] Remove indic_config->has_old_spec 2018-01-05 15:41:31 +00:00
Behdad Esfahbod
961ebf85f1 [khmer] Remove Halant from Khmer shaper 2018-01-05 15:36:53 +00:00
Behdad Esfahbod
9761f9d782 [indic] Remove more Khmer-specific stuff from Indic shaper 
No numbers changed.
 2018-01-05 15:33:11 +00:00
Behdad Esfahbod
0758953644 [indic] Remove main Khmer stuff 2018-01-05 15:08:28 +00:00
Behdad Esfahbod
dcf4d95fea [khmer] Split off Khmer shaper from Indic 
Towards fixing https://github.com/harfbuzz/harfbuzz/issues/667
The Khmer spec is different enough from other Indic ones to require
its own grammar.

No change in functionality.  Test numbers are:

BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
GURMUKHI: 60729 out of 60747 tests passed. 18 failed (0.0296311%)
KANNADA: 951300 out of 951913 tests passed. 613 failed (0.0643966%)
KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%)
MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
 2018-01-05 14:54:31 +00:00
Behdad Esfahbod
1e05ea79d0 [ot] Short-circuit base instance advance variation 2018-01-05 14:01:37 +00:00
Behdad Esfahbod
54b2b93722 [ot] Fix VariationStore evaluation algorithm 
Ouch!  Missing coords should still be evaluated as coord=0, which
most of the time results in a factor of 0.  We were skipping these,
which was equivalent to a factor of 1.

Fixes https://github.com/harfbuzz/harfbuzz/issues/652
 2018-01-05 13:20:21 +00:00
Behdad Esfahbod
a3afdd1e08 Minor 2018-01-05 13:17:02 +00:00
Behdad Esfahbod
cb43bdbc2f [ft] If there's no variations set, don't set them on hb-font 2018-01-05 13:06:25 +00:00
Behdad Esfahbod
127bcc6ece Merge remote-tracking branch 'fdo/master' 2018-01-05 12:50:22 +00:00
Behdad Esfahbod
8c0d1916a4 Improve CGJ skipping logic 
Previously we made CGJ unskippable.  Now, if CGJ did NOT prevent
any reordering, allow skipping over it.  To make this work we
had to make changes to the Arabic mark reordering algorithm
implementation to renumber moved MCM marks.  See comments.

Fixes https://github.com/harfbuzz/harfbuzz/issues/554
 2018-01-05 12:48:19 +00:00
Ebrahim Byagowi
72bec1cd09
Improve tests (#679) 2018-01-05 12:42:20 +03:30
Behdad Esfahbod
293e443529 Minor 2018-01-04 16:06:25 +00:00
Bruce Mitchener
8a0952db7e atomics: Favor compiler primitives over macOS APIs. (#676) 
In macOS 10.12, the `OSMemoryBarrier` and related APIs were deprecated
in favor of using `std::atomic`. On the way to supporting `std::atomic`,
we can favor using the "Intel primitives" which are also available on
macOS.
 2018-01-04 15:10:10 +03:30
Ebrahim Byagowi
5ed26fc5bd
[cmake] Run src/ tests (#675) 2018-01-04 10:11:34 +03:30
Behdad Esfahbod
f8daeef4c4 [use] Simplify more 2018-01-03 14:27:34 +00:00
Behdad Esfahbod
877d15e73c [use] Simplify 
Fixes https://github.com/harfbuzz/harfbuzz/pull/661
 2018-01-03 14:24:44 +00:00
Behdad Esfahbod
308f419215 [use] Fix Brahmi Number Joiner 1107F 
Fixes https://github.com/harfbuzz/harfbuzz/pull/660
 2018-01-03 14:22:07 +00:00
Bruce Mitchener
85ec6d3443 Fix typos. 2018-01-02 13:26:44 -05:00
David Corbett
7bfdf1a941 Forbid Batak killers after vowel signs 2017-12-24 14:21:22 -08:00
Behdad Esfahbod
72ecaae0ad [use] Allow ZWJ before/after Halant 
https://github.com/harfbuzz/harfbuzz/issues/542#issuecomment-353169729
 2017-12-24 16:05:07 -05:00
Behdad Esfahbod
bc92245b68 Minor 2017-12-24 15:54:58 -05:00
Volker H. Simonis
a9432bde7e HarfBuzz 1.7.1 and later don't compile on AIX with xlC (#655) 2017-12-19 20:22:24 -05:00
Behdad Esfahbod
2fe5f885b6 [set] Handle nil set in add_range() / add_sorted_array() 
Fixes https://github.com/harfbuzz/harfbuzz/issues/657
 2017-12-19 14:48:26 -05:00
Behdad Esfahbod
1245395a60 [coretext] In hb_coretext_font_create() set ptem 
Otherwise setting the CTFont was ineffective as it would have been
recreated anyway unless font size was set to 18 CSS points.
 2017-12-17 12:33:08 -05:00
Behdad Esfahbod
493a005d95 [set] In add_sorted_array(), bail if data is not sorted 2017-12-16 11:49:39 -05:00
Behdad Esfahbod
a7bd6d7a4c [collect_glyphs] Bail if input data looks like garbage 
Specificaly, when a range or sorted array has unexpected order, we take that as
font data being garbage and bail out.  This fixes significant slowdown on a bad
version of Chandas font which has a 600KB GPOS with garbage inside.

Later on, I like to add a maximum-work counter for collect_glyphs to protect
against malicious fonts as well.

Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=794896
 2017-12-16 11:39:32 -05:00
Behdad Esfahbod
1ce7d6e215 [set] Optimize add_array() / add_sorted_array() 
Does page lookup as needed.
 2017-12-16 11:39:11 -05:00
Behdad Esfahbod
71e6adf1e2 [collect_glyphs] handle ClassDef better 2017-12-16 11:07:37 -05:00
Behdad Esfahbod
87cc5a65cb [collect_glyphs] In PairPosFornat2 do not collect classDef1 
The coverage already covered that.
 2017-12-16 06:18:07 -08:00
Behdad Esfahbod
81f27df4d9 More work towards improving collect_glyphs() against bad input 
The three "XXXXX"'s should be switched to false.  Doing that separately for ease
of bisecting...
 2017-12-16 06:12:06 -08:00
Behdad Esfahbod
5d02572034 [set] Add add_sorted_array() 
Not optimized to use sortedness yet.  Also start putting in place infra
to faster reject bad data.

A version of Chandas.ttf found on some Chrome bots has 660kb of GPOS,
mostly junk.  That is causing 48 million of set->add() calls in
collect_glyphs(), which is insane.

In the upcoming commits, I'll be speeding that up by optimizing
add_sorted_array(), while also reducing work by rejecting out-of-sort
arrays quickly and propagate the rejection.

Part of https://bugs.chromium.org/p/chromium/issues/detail?id=794896
 2017-12-14 19:35:47 -08:00
Behdad Esfahbod
9d6511a734 [set] Reduce number of preallocated pages from 8 to 1 
Now that pagesize is 8192, this feels better.
 2017-12-14 19:07:17 -08:00
Behdad Esfahbod
ae2e2b068e Fix partial tracing debug builds 2017-12-14 19:07:17 -08:00
Behdad Esfahbod
9daa88cd79 Minor 2017-12-14 19:07:17 -08:00
Behdad Esfahbod
f424a34223 [set] Change pagesize from 512 bits to 8192 bits 
Fixes perf regression on some heavy fonts in Chrome's FT+HB
interaction.

See:
https://bugs.chromium.org/p/chromium/issues/detail?id=782220

More work to be done:
https://bugs.chromium.org/p/chromium/issues/detail?id=794896
 2017-12-14 13:30:38 -08:00
Behdad Esfahbod
0fe62c1f33 [set] Add add_array() 
To be used to optimize adding a whole bunch of (sorted) items at the same time,
as in CoverageFormat1.
 2017-12-14 10:39:00 -08:00
Behdad Esfahbod
03b7a221f7 [debug] Use %p to print pointers 
Fixes https://github.com/harfbuzz/harfbuzz/issues/640
 2017-12-05 13:13:58 -08:00
Nathan Willis
0dc03ef757 Indic: always hyphenate pre-base-reordering, for clarity. 2017-12-05 11:29:43 -08:00
Behdad Esfahbod
be59f3cbf4 Silence unused-variables warning on MSVC 
Fixes https://github.com/harfbuzz/harfbuzz/issues/635
 2017-12-05 09:01:28 -08:00
David Corbett
80c1b01f05 Allow digits in language system tags 2017-12-05 08:56:41 -08:00
David Corbett
85bb89a88b Fix string matching in parse_bool 2017-12-04 13:10:16 -08:00
Olivier Blin
0fd89dc61c [hb-ft] Fix build when Multiple Master font support is disabled in freetype 
FT_Set_Var_Blend_Coordinates() is not available when "Multiple Master
font interface" is disabled in freetype's modules.cfg
 2017-12-04 10:52:06 -08:00
Behdad Esfahbod
eeb26d21d4 [set] Actually commit fixes mentioned in previous commit! 2017-12-02 15:22:04 -08:00
Behdad Esfahbod
0744149cda [set] Protect against bad input in hb_set_add_range() 2017-12-02 15:06:15 -08:00
Behdad Esfahbod
d5e29303db [coretext] Add hb_coretext_font_create() 
Fixes https://github.com/harfbuzz/harfbuzz/issues/628

New API:
hb_coretext_font_create()
 2017-12-02 14:52:57 -08:00
Behdad Esfahbod
9d0194b3a8 [set] Optimize add_range() some more 
It's as good as it gets, and seems to be on par with previous set implementation
in my benchmark.

Would be great if someone can double-check my bitops.
 2017-12-01 13:56:06 -08:00
Behdad Esfahbod
438c325a25 [set] Optimize add_range() 
With new set implementation, this became really costy.  Optimize it.
There's more to be done, but this shaves off most of the fat.

Part of fixing https://bugs.chromium.org/p/chromium/issues/detail?id=782220
 2017-12-01 13:34:14 -08:00
Behdad Esfahbod
be9e307a88 [ot] Ensure layout in hb_ot_layout_table_get_lookup_count() 2017-12-01 12:37:05 -08:00
Behdad Esfahbod
16fba5b215 [ot] Fix Extension type recurse to disallow recursing to another Extension 
Particularly hazardous if the second layer mixes forward and backward lookups.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4336
 2017-11-29 16:08:11 -08:00
David Corbett
9f259769a6 Categorize U+A8B4 as Consonant_Medial 2017-11-21 13:48:32 -08:00
Behdad Esfahbod
8d55340593 Fix fallback positioning of double diacritic marks 
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=787284
 2017-11-20 19:43:22 -08:00
David Corbett
87d74605f5 Categorize U+0C80 as Consonant_Placeholder 2017-11-20 13:10:28 -08:00
ebraminio
7c6937e7c7
Move all references of old url to the new address (#622) 2017-11-20 14:49:22 -05:00
Behdad Esfahbod
baf7779d2d Limit how much recursion GSUB/GPOS does 
This only counts recursions right now.  Good start.

Hopefully...
Fixes https://github.com/behdad/harfbuzz/issues/429
 2017-11-14 21:55:37 -08:00
Behdad Esfahbod
173dab6300 Minor move 2017-11-14 21:27:24 -08:00
Behdad Esfahbod
c6173a392c Add Offset16 and Offset32 2017-11-14 21:09:03 -08:00
Behdad Esfahbod
6f335ed1e5 Replace USHORT/SHORT/ULONG/etc with UINT16/INT16/UINT32/etc 2017-11-14 21:06:07 -08:00
Behdad Esfahbod
a130ee6df5 Remove a couple of unused consts 2017-11-14 20:30:03 -08:00
Behdad Esfahbod
e20e47eaa1 [glyf] Try fixing undefined-behavior 
Might fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1463
 2017-11-14 20:25:29 -08:00
Behdad Esfahbod
7b40876a58 [ot] Remove unneeded TODO item 
Looks like hb-ot-font is complete after all!

CFF font names and CFF glyph metrics don't work though...
 2017-11-14 20:22:05 -08:00
Behdad Esfahbod
eab4feb5e2 [hmtx] Use curiously recurring template pattern 
https://en.wikipedia.org/wiki/Curiously_recurring_template_pattern
 2017-11-14 20:17:15 -08:00
Behdad Esfahbod
977ddff1f1 [ot] Move hb_ot_face_cmap_accelerator_t 2017-11-14 20:06:19 -08:00
Behdad Esfahbod
a7f15959b5 Shuffle 2017-11-14 20:02:24 -08:00
Behdad Esfahbod
a85d7ead04 [ot] Move hb_ot_face_metrics_accelerator_t 2017-11-14 20:00:34 -08:00
Behdad Esfahbod
f00a94e1ec Adjust privacy for recent changes 2017-11-14 19:54:48 -08:00
Behdad Esfahbod
7e2839c438 [ot] Move hb_ot_face_glyf_accelerator_t 2017-11-14 19:52:29 -08:00
Behdad Esfahbod
c4e18e54dc [ot] Move hb_ot_face_cbdt_accelerator_t 2017-11-14 19:52:26 -08:00
Behdad Esfahbod
9b04b0384f [ot] Fold hb_ot_face_post_accelerator_t 2017-11-14 19:31:50 -08:00
Behdad Esfahbod
702d86ba6b [ot] Fold hb_ot_face_kern_accelerator_t 2017-11-14 19:25:51 -08:00
Behdad Esfahbod
909de95a11 Minor build fix 2017-11-14 16:22:52 -08:00
Behdad Esfahbod
e5930722d4 Fix invalid buffer access in OOM times 
Hopefully fully fixes
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1856
 2017-11-14 15:47:55 -08:00
Behdad Esfahbod
fcd6c338ff Fix more compiler warnings 2017-11-14 15:04:19 -08:00
Behdad Esfahbod
7fdf16b2ce Fix compiler warning 2017-11-14 15:04:19 -08:00
David Corbett
87f0ad183c Allow U+20F0 in USE clusters 2017-11-14 15:04:10 -08:00
Behdad Esfahbod
93f7c1652a Revert "[glib/ucdn/icu/ft/ot] Make returned funcs inert" 
This reverts commit 5daf3bd449.

If other atexit callbacks try to destruct the objects we destruct
in atexit callbacks, bad things will happen.

I'll come up with some other way to catch premature destruction
of HB-owned objects.

Fixes https://github.com/behdad/harfbuzz/issues/618
 2017-11-14 10:59:54 -08:00
Behdad Esfahbod
c48475f33a Whitespace 2017-11-13 20:26:29 -08:00
Behdad Esfahbod
83d6802736 Clean up GlyphID 
After 4a27c17ea0 we do not need
the special GlyphID.cmp(hb_codepoint_t), so just make GlyphID
a typedef.

Fixes https://github.com/behdad/harfbuzz/issues/612
 2017-11-13 20:25:02 -08:00
Behdad Esfahbod
7f39f57614 Implement strtod_l() on MSVC 
Patch from Jean Ghali on mailing list.
 2017-11-13 15:04:13 -08:00
Behdad Esfahbod
e4da380200 [coretext/uniscribe/directwrite/graphite/fallback] Update for unsafe-to-break 
Fixes https://github.com/behdad/harfbuzz/issues/615

We'll see which bots I broke.
 2017-11-10 17:14:27 -08:00
Martin Hosken
4de03a1585 Fix graphite intergration reordered clusters problem 2017-11-10 16:24:06 -08:00
Behdad Esfahbod
8eed9cb11e [kern] Fix invalid memory access if offset is zero 
If offset is zero, we return Null() object.  Wasn't prepared for that.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4088
 2017-11-09 18:09:40 -08:00
Behdad Esfahbod
c4f4c0a2fa Fix indexing in unsafe-to-break marking for 'stch' feature 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4099
 2017-11-08 17:04:31 -08:00
David Corbett
5a9cba9744 Mark non-initial left matras as unsafe to break 2017-11-08 19:12:10 -05:00
Behdad Esfahbod
a615030683 [kern] Implement format-2 kern subtable 2017-11-06 15:40:07 -05:00
Behdad Esfahbod
82a38d1f7a [kern] Allow subtables longer than 64kb 
Apparently calibri.ttf does this:
https://github.com/fonttools/fonttools/pull/1094#discussion_r148933791
 2017-11-06 15:28:24 -05:00
Behdad Esfahbod
625ae08fce [kern] Towards implementing format-2 2017-11-06 15:06:30 -05:00
David Corbett
74e82adaea Mark glyphs involved in 'stch' as unsafe to break 2017-11-06 15:06:23 -05:00
Behdad Esfahbod
5aad819433 Simplify tracing code when tracing is disabled 
Fixes https://github.com/behdad/harfbuzz/pull/605
 2017-11-03 17:18:17 -04:00
Behdad Esfahbod
40ec3bbb55 Consolidate debug stuff into hb-debug.hh 
Part of fixing https://github.com/behdad/harfbuzz/pull/605
 2017-11-03 17:18:17 -04:00
Behdad Esfahbod
384862d7ee Remove NO_COPY() 2017-11-03 17:18:17 -04:00
Unknown
97145df249 Trivial typos 
Found using `codespell -i 3 -w -I '../harf-whitelist.txt'`
whereas the whitelist contents were:
```
beng
iff
pres
ot
te
teh
```
 2017-11-03 15:31:21 +02:00
Behdad Esfahbod
4b3278ef8d [ot] Hook up horizontal kerning to kern table 
Seems to work.  Yay!

Still to do: run kerning if GPOS doesn't have 'kern' feature.
 2017-11-01 19:41:29 -06:00
Behdad Esfahbod
77acc1106e [kern] More... 
Almost there.
 2017-11-01 19:40:51 -06:00
Behdad Esfahbod
49c0f35580 [kern] See if this helps with making VS bot happy 2017-11-01 18:16:07 -06:00
Behdad Esfahbod
2c439210c9 [uniscribe] Fix a couple of VS warnings 2017-11-01 18:13:35 -06:00
Behdad Esfahbod
4c43a23bf4 [kern] Implement Format0 2017-11-01 18:12:26 -06:00
Behdad Esfahbod
ac3d937c6c [kern] Implement some more 2017-11-01 17:54:56 -06:00
Behdad Esfahbod
2a16f647ae [kern] Start implementing kern table 
Pushing this out early to catch bot errors since I'm using template tricks
we were not using in HarfBuzz before.
 2017-11-01 17:32:34 -06:00
ebraminio
102f5ead49
Enable PSVita (arm-none-eabi) compile again and add it to CI (#594) 2017-11-01 02:10:18 -07:00
Behdad Esfahbod
92bb508642 [indic] Use mutable for virama_glyph 2017-10-31 22:58:03 -06:00
Behdad Esfahbod
6c04dcb28d Use bsearch() for large SFNT table directories 2017-10-31 20:11:00 -06:00
Behdad Esfahbod
b0e33da02d Add BinSearchArrayOf<> 2017-10-31 20:05:37 -06:00
Behdad Esfahbod
aca378f51e Sanitize (Headless)ArrayOf()::len to ensure it doesn't use offsets 2017-10-31 18:11:10 -06:00
Behdad Esfahbod
5f04711314 Fix HeadlessArrayOf::sanitize_shallow() 2017-10-31 18:10:40 -06:00
Behdad Esfahbod
7ce9f397d1 Rename hb-sort-r.hh -> hb-dsalgs.hh 2017-10-31 16:54:31 -06:00
Behdad Esfahbod
8eaff980fc Remove HB_TAG_CHAR4 2017-10-31 16:54:31 -06:00
David Corbett
d016c5bdb9 Categorize Grantha candrabindu for use in Tamil 2017-10-31 16:54:23 -06:00
Behdad Esfahbod
0feff4ba7b Simplify hb-sort-r.hh 
See https://github.com/behdad/harfbuzz/pull/592
 2017-10-31 14:02:54 -06:00
Behdad Esfahbod
c290ba5b7d Define _GNU_SOURCE 
Might help with https://github.com/behdad/harfbuzz/pull/592
Ie. bringing in qsort_r() prototype always.
 2017-10-31 13:18:21 -06:00
Behdad Esfahbod
98acdde3c6 [coretext/uniscribe] Fix build 
https://travis-ci.org/behdad/harfbuzz/jobs/295039536#L3468
https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.697/job/dr1ujlntxafeqbej#L142
 2017-10-31 11:17:43 -06:00
Behdad Esfahbod
ec86cc5e55 Fix Windows build 
(And prevent it from happening in the future.)
 2017-10-30 14:11:59 -06:00
Behdad Esfahbod
e35a763c07 [post] Implement glyph_from_name() 
This concludes https://github.com/behdad/harfbuzz/pull/568
 2017-10-30 13:15:05 -06:00
Behdad Esfahbod
6c738f353e Make string-array return hb_string_t 2017-10-30 12:21:44 -06:00
Behdad Esfahbod
e1a37f3db4 Add hb_string_t 2017-10-30 11:42:28 -06:00
Behdad Esfahbod
21ac567858 Fix tests 2017-10-30 09:48:09 -06:00
Behdad Esfahbod
0f8b5aa1bc [post] Minor; towards implementing get_glyph_from_name() 2017-10-30 09:46:36 -06:00
Behdad Esfahbod
977679f229 Add hb_bsearch_r() 2017-10-29 17:33:32 -06:00
Behdad Esfahbod
0712e915b4 Remove hb_compare_func_t 2017-10-29 17:01:47 -06:00
Behdad Esfahbod
538da7496d Add hb-sort-r, a portable qsort_r() replacement 2017-10-29 16:38:58 -06:00
Behdad Esfahbod
923a8f520a Fix up 5de83fab94 2017-10-29 15:00:54 -06:00
Behdad Esfahbod
b98c7c3f1f [post] Minor 2017-10-29 14:52:52 -06:00
Behdad Esfahbod
5de83fab94 [ot] Speed up get_glyph_name() 
get_glyph_from_name() coming soon.
 2017-10-28 19:54:04 -06:00
Behdad Esfahbod
feadee079e [post] Refactor a bit, use our data types 2017-10-28 16:58:56 -06:00
Behdad Esfahbod
5014c60afa More nullptr fix 
Fixes https://github.com/behdad/harfbuzz/issues/585
 2017-10-28 12:00:49 -06:00
Behdad Esfahbod
5daf3bd449 [glib/ucdn/icu/ft/ot] Make returned funcs inert 
Such that client cannot accidentally destroy them, even though that
will be a bug in their code...
 2017-10-27 16:37:11 -06:00
Behdad Esfahbod
bfa7f37a73 Fix previous commit 
Oops.
 2017-10-27 16:03:51 -06:00
Behdad Esfahbod
8864864b62 [glib/icu/ucdn] Make the funcs object allocated on demand 2017-10-27 15:26:45 -06:00
Behdad Esfahbod
af3f72f9eb Correctly mark NullPool const 
Saves some more code size as well!
 2017-10-27 15:14:44 -06:00
Behdad Esfahbod
51f4d4d5cd Reduce prealloced number of user-data items from 2 to 1 
Even 1 is too many but putting 0 breaks compile.  Saves 3k in .so
 2017-10-27 15:09:22 -06:00
Behdad Esfahbod
3205de7906 Make the NullPool HB_INTERNAL shared 
Saves 2k of .bss section.
 2017-10-27 15:01:40 -06:00
Behdad Esfahbod
7036f1d22c [ot] Remove shaper name 
In ten years we never used them...
 2017-10-27 14:42:59 -06:00
Behdad Esfahbod
4a27c17ea0 Fix IntType.cmp() to avoid narrowing down integer types 
Fixes https://github.com/behdad/harfbuzz/issues/571
 2017-10-27 14:29:12 -06:00
Behdad Esfahbod
62e312ead8 Use NULL instead of polyfill, if nullptr is not available 
Part of fixing https://github.com/behdad/harfbuzz/issues/585
 2017-10-27 09:29:20 -06:00
Behdad Esfahbod
17f40b7cad Include hb-private.hh more consistently 
Part of fixing https://github.com/behdad/harfbuzz/issues/585
 2017-10-27 09:22:42 -06:00
Behdad Esfahbod
42d518513c Towards compiling with pre-C++11 compilers and nullptr fallback 
https://github.com/behdad/harfbuzz/issues/585
 2017-10-27 00:25:11 -06:00
Behdad Esfahbod
0e9256984e [post] Make format1 names array avoid relocations 2017-10-26 20:34:04 -06:00
Behdad Esfahbod
2a74968044 Add hb-string-array.hh 
Used to build static string arrays that use no relocation.
 2017-10-26 20:32:16 -06:00
Behdad Esfahbod
6f08b12bc3 Minor 2017-10-26 18:23:03 -06:00
Jonathan Kew
dfd234a97d [set] Fix page_map[] indexing in backward loop. 
Fixes https://github.com/behdad/harfbuzz/issues/579.
 2017-10-26 12:33:05 -05:00
Jonathan Kew
d511cfb557 [set] Bugfix for hb_set_next 2017-10-26 12:30:52 -05:00
Behdad Esfahbod
92bac64bd2 [post] Oops! 
https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.668/job/ikfj8peowgrp059t
 2017-10-25 18:22:47 -06:00
Behdad Esfahbod
543bd58d7a [post] Touch up and fixes 
The get_glyph_from_name() is incorrect; needs fixing.
 2017-10-25 18:01:03 -06:00
Khaled Hosny
d9e166f74c [ot-font] Implement hb_ot_get_glyph_from_name 2017-10-25 19:29:51 -04:00
Khaled Hosny
9d4d2fb9af [ot-font] Implement hb_ot_get_glyph_name 
Turns out we already have support for “post” table, it just needed to be
activated and put in use.
 2017-10-25 19:29:51 -04:00
Behdad Esfahbod
33ca3b67bf Check for headers in builddir first, in check-*.sh 
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=103346
 2017-10-25 12:09:11 -04:00
Behdad Esfahbod
9ac2e5c6c0 check-externs.sh: Make output more verbose 
Trying to figure out why this is failing on some Debian bots:
https://bugs.freedesktop.org/show_bug.cgi?id=103346

Maybe I should check for GNU grep specifically now that I'm using -n as well.
 2017-10-24 10:06:25 -04:00
Behdad Esfahbod
30a591e3ce [set] Rewrite another way :P 2017-10-23 14:29:20 -04:00
Behdad Esfahbod
8170801d78 [set] Fix crash 
Ouch!  That's what happens when one plays with increment/decrement operators!

Fixes https://github.com/behdad/harfbuzz/issues/578
 2017-10-23 14:29:14 -04:00
Behdad Esfahbod
2ee710e02f Minor 2017-10-23 08:37:48 -04:00
Behdad Esfahbod
dd33e4e96b [set] Don't use major() 
Fixes https://github.com/behdad/harfbuzz/issues/577
 2017-10-23 08:36:40 -04:00
Behdad Esfahbod
d0f0ff85b9 [set] Don't use PAGE_SIZE 
Fixes https://github.com/behdad/harfbuzz/issues/576
 2017-10-23 08:34:30 -04:00
Behdad Esfahbod
ce97945440 [icu] Fix error check 2017-10-22 18:23:38 -04:00
Behdad Esfahbod
8b9d9b71b0 Fix set initialization issues 2017-10-22 17:48:06 -04:00
Behdad Esfahbod
ced86da7dd Another try at fixing mingw32 build bot fail 2017-10-22 17:06:10 -04:00
ebraminio
d45a2138d9 Merge pull request #572 from fanc999/master.msvc 
builds: Support HarfBuzz-GObject and introspection in CMake builds
 2017-10-21 10:19:55 +03:30
Behdad Esfahbod
d8adaa97fb Another try at fixing build bots 
hb-ot-shape.cc:287:18: error: comparison of constant 32 with expression of type 'hb_unicode_general_category_t' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
 2017-10-20 13:57:43 -04:00
Behdad Esfahbod
6058f98825 Remove FLAG_SAFE() 
No flag is safe, over time... See previous commit.
 2017-10-19 11:39:52 -07:00
Behdad Esfahbod
7c561dacc3 [myanmar] Fix unsafe usage of FLAG_SAFE() 
The commit f559c63307 caused
"undefined-shift" errors in Myanmar shaper as we changed the
numeric value of type D from 19 to 32 there, making the
"FLAG_SAFE (info.myanmar_category())" wrong.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3546
 2017-10-19 11:35:51 -07:00
Chun-wei Fan
162575f2c6 CMake builds: Fix builds 
Include the fallback sources in the build, and update
src/Makefile.sources so that it can be read by the CMake build files.

Fix a typo in the DirectWrite configure option so that we can properly
enable DirectWrite builds.

Also, when building the utility program, install them as well.
 2017-10-18 22:48:18 +08:00
Behdad Esfahbod
d6f612fac8 [bsearch] Micro-optimization 2017-10-17 16:32:12 -07:00
Fredrik Roubert
41b1984be9 Switch from ICU deprecated unorm_normalize to unorm2_normalize. (#569) 
The new unorm2_normalize has been public API since ICU 4.4, while
the old unorm_normalize has been deprecated since ICU 56.

Now, beginning with ICU 60, unorm_normalize will also be annotated
U_DEPRECATED and trigger the compiler -Wdeprecated-declarations warning.
 2017-10-17 15:06:31 -07:00
Behdad Esfahbod
ba8b569607 Try fixing build on VC 
c:\projects\harfbuzz\src\hb-set-private.hh(151): error C2327: 'hb_set_t::page_t::v': is not a type name, static, or enumerator [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
 2017-10-17 11:16:36 -07:00
Behdad Esfahbod
80cc0a7e3e [coretext] Fix build 
error: static_assert expression is not an integral constant expression
 2017-10-17 11:14:48 -07:00
Behdad Esfahbod
a11249ee93 [set] Fix merge logic 2017-10-16 01:33:32 -04:00
Behdad Esfahbod
ab8f327eb4 Ouch. 2017-10-15 18:21:35 -04:00
Behdad Esfahbod
bb9917913f [set] Disable vectorization 
Fixes clang "non-const reference cannot bind to vector element" error.
 2017-10-15 18:20:25 -04:00
Behdad Esfahbod
221ce6c18f Fix bots 2017-10-15 17:58:58 -04:00
Behdad Esfahbod
0cf7d957b7 [set] Remove TODO items not worth pursuing 2017-10-15 17:01:31 -04:00
Behdad Esfahbod
10d43658e7 [set] Speed up intersects() 2017-10-15 16:56:05 -04:00
Behdad Esfahbod
56ef4e0c52 Simplify hb_prealloced_array_t initialization 2017-10-15 16:38:29 -04:00
Behdad Esfahbod
7737e87ac4 Properly detect vector_size attribute and use fallback otherwise 2017-10-15 16:21:03 -04:00
Behdad Esfahbod
f8a0ec50e2 [set] Add fallback implementation of int-vector type 2017-10-15 16:10:35 -04:00
Behdad Esfahbod
deed4a48d1 Faster hb_set_t 
Fixes https://github.com/behdad/harfbuzz/pull/23
 2017-10-15 16:45:33 -03:00
Behdad Esfahbod
1d3971200b Deprecate hb_set_invert() 2017-10-15 16:28:34 -03:00
Behdad Esfahbod
5e74044b6b Add bfind() to prealloaced_array_t 2017-10-15 16:28:34 -03:00
Behdad Esfahbod
db5f7ef189 Inline another bsearch() 2017-10-15 16:28:34 -03:00