Commit Graph

8215 Commits

Author SHA1 Message Date
bungeman@google.com
0abbff9987 Fix metrics on Windows.
With this change, Skia's metrics are much better in general, and
specifically can be made to match the metrics produced by current
Blink code. This allows Blink to use Skia's metrics.

This change will require a number of rebaselines in Skia, since
previous metrics were quite different. This will require about five
rebaslines in Blink, as the new code may cause GDI's matrix to differ
in the low bits.

Review URL: https://codereview.chromium.org/20585004

git-svn-id: http://skia.googlecode.com/svn/trunk@10399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-27 20:37:56 +00:00
skia.committer@gmail.com
aeefb2afe7 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10398 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-27 07:01:06 +00:00
commit-bot@chromium.org
149f4f5b40 differentiate mag and min filters
BUG=
R=bsalomon@google.com, robertphillips@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20809002

git-svn-id: http://skia.googlecode.com/svn/trunk@10397 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 20:40:06 +00:00
senorblanco@chromium.org
0989b21d5a Remove Nexus10 strokes3_gpu expectations. This one seems to change every run (uninit? driver bug?).
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20501004

git-svn-id: http://skia.googlecode.com/svn/trunk@10396 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 19:55:28 +00:00
zachr@google.com
785ef5d521 process gm expectation violations
R=epoger@google.com

Review URL: https://codereview.chromium.org/20527002

git-svn-id: http://skia.googlecode.com/svn/trunk@10395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 19:29:39 +00:00
senorblanco@chromium.org
fe07cfcf01 Another try at rebaselining strokes_gpu on Nexus10. If this doesn't work, I'll just add all of the hashes generated so far to the list.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20774002

git-svn-id: http://skia.googlecode.com/svn/trunk@10394 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 17:27:21 +00:00
commit-bot@chromium.org
cffff79a40 get genmipmap function in the struct
BUG=
R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20436002

git-svn-id: http://skia.googlecode.com/svn/trunk@10393 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 16:36:04 +00:00
humper@google.com
0f48ee0a07 add more stats to the bitmap matrix locator
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/19091006

git-svn-id: http://skia.googlecode.com/svn/trunk@10392 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 15:23:43 +00:00
senorblanco@chromium.org
c074ff5020 New Nexus10 baselines for strokes3_gpu.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20725002

git-svn-id: http://skia.googlecode.com/svn/trunk@10387 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 12:29:37 +00:00
senorblanco@chromium.org
42ecd5f927 New Galaxy Nexus lighting baselines.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20718002

git-svn-id: http://skia.googlecode.com/svn/trunk@10386 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 11:52:19 +00:00
skia.committer@gmail.com
956b310f13 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 07:00:58 +00:00
senorblanco@chromium.org
a260e2e4e7 New Nexus10 baselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20648002

git-svn-id: http://skia.googlecode.com/svn/trunk@10384 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 03:10:17 +00:00
senorblanco@chromium.org
2dc8bf780e Yet another round of lighting rebaselines: win7.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20625003

git-svn-id: http://skia.googlecode.com/svn/trunk@10383 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 02:46:19 +00:00
senorblanco@chromium.org
01178b4871 Next round of lighting rebaselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20636003

git-svn-id: http://skia.googlecode.com/svn/trunk@10382 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 02:21:12 +00:00
senorblanco@chromium.org
a79d6c5b53 Next round of lighting baselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20617002

git-svn-id: http://skia.googlecode.com/svn/trunk@10381 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 01:14:38 +00:00
senorblanco@chromium.org
6d427f252c First round of new lighting baselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20600003

git-svn-id: http://skia.googlecode.com/svn/trunk@10380 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 00:51:29 +00:00
senorblanco@chromium.org
4e16bb2a32 Implement crop rect for lighting image filters. Changes for the CPU path were fairly straightforward: use the bounds rectangle when traversing the pixels, not the source rectangle.
For the GPU path, this required modifying the signature of SkImageFilter::asNewEffect() to receive the bounds offset, so that the lighting filters could offset the light position by the offset. It also required modifying the base-class implementation of SkImageFilter::filterImageGPU() (which implements single-pass filters) to intersect against the bounds rect, to pass its offset to asNewEffect(), and to modify the caller's offset (so it's drawn in the correct place).

Note: this will require rebaselining the lighting GM. Six new test cases were added, to accommodate a cropped version of each lighting filter.

R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/20426002

git-svn-id: http://skia.googlecode.com/svn/trunk@10379 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 00:10:07 +00:00
commit-bot@chromium.org
4d24b747e2 Make SkImage_Gpu share it's pixelref with the surface to prevent premature return to scratch pool.
BUG=crbug.com/263329
TEST=Surface unit test, function Test_crbug263329
R=bsalomon@google.com, reed@google.com

Author: junov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20354003

git-svn-id: http://skia.googlecode.com/svn/trunk@10378 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 23:29:40 +00:00
edisonn@google.com
1acab362fd pdfviewer: limit the characters we support in ToUnicode, to 0xffff
Review URL: https://codereview.chromium.org/20538002

git-svn-id: http://skia.googlecode.com/svn/trunk@10377 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 22:03:22 +00:00
edisonn@google.com
ac4bedcb10 pdfviewer: set the default background to transparent (to match render_picture default), and fix a bug a with corrupt diffs
Review URL: https://codereview.chromium.org/20526002

git-svn-id: http://skia.googlecode.com/svn/trunk@10376 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:40:23 +00:00
robertphillips@google.com
aaa9b29ed8 Added GM to test forthcoming bleed flag
https://codereview.chromium.org/20101004/



git-svn-id: http://skia.googlecode.com/svn/trunk@10375 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:34:00 +00:00
bsalomon@google.com
68f2a0df14 This reverts commit 4052fd051db67bd1099fde2c4fe400cfbe1f2426.
git-svn-id: http://skia.googlecode.com/svn/trunk@10374 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:30:52 +00:00
humper@google.com
5dbdfee3bd reversed senses of none and bilerp
git-svn-id: http://skia.googlecode.com/svn/trunk@10373 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 20:43:44 +00:00
commit-bot@chromium.org
47fad70da3 R=borenet@google.com, bungeman@google.com, robertphillips@google.com
Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19862002

git-svn-id: http://skia.googlecode.com/svn/trunk@10372 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 20:01:20 +00:00
zachr@google.com
48b8891194 add basic HTTP server for viewing skpdiff results
R=epoger@google.com

Review URL: https://codereview.chromium.org/19929007

git-svn-id: http://skia.googlecode.com/svn/trunk@10371 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:49:17 +00:00
humper@google.com
e2cf805e9a clean up printf usage in gm
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/20373002

git-svn-id: http://skia.googlecode.com/svn/trunk@10370 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:14:37 +00:00
humper@google.com
f9ed6fe6c5 fix android build
git-svn-id: http://skia.googlecode.com/svn/trunk@10369 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:09:47 +00:00
humper@google.com
b86add1ad3 make the filter mode for GrTextureAccess an enum so we can plumb down
the paint's filter modes to the GPU

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/20362002

git-svn-id: http://skia.googlecode.com/svn/trunk@10368 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 18:49:07 +00:00
senorblanco@chromium.org
7168ecc363 Transpose the samples in imagefilterscropped, and add a 1x1 blur. The latter
exercises a different path in the GPU backend, and the former is because my
tiny brain gets confused between the results of this test and imagefiltersbase.

R=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/20315002

git-svn-id: http://skia.googlecode.com/svn/trunk@10366 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 18:08:13 +00:00
commit-bot@chromium.org
37799e1f91 Add NPOT version of tilemodes GM
R=reed@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/20204006

git-svn-id: http://skia.googlecode.com/svn/trunk@10364 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 17:52:32 +00:00
reed@google.com
ea348cb435 experimentally enable USE_HASH for scaledimagecache
BUG=

Review URL: https://codereview.chromium.org/20378002

git-svn-id: http://skia.googlecode.com/svn/trunk@10363 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 17:50:37 +00:00
reed@google.com
b8d17fef26 use dynamic hash to speed up scaledimagecache
BUG=

Review URL: https://codereview.chromium.org/20344002

git-svn-id: http://skia.googlecode.com/svn/trunk@10362 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 17:42:24 +00:00
zachr@google.com
55173f2ecc fix trailing comma in outptu of SkDiffContext
R=djsollen@google.com

Review URL: https://codereview.chromium.org/20324004

git-svn-id: http://skia.googlecode.com/svn/trunk@10361 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 17:22:58 +00:00
edisonn@google.com
50bbdb4f3e pdfviewer: update drawBitmap, and fic a gyp issue: gyp does not run in a consistent way on various palt forms, and it generates some files in ../../../foo instead of ../foo - Solution: use the (inconvenient) Shared intermediary directory that should work on all platforms.
Review URL: https://codereview.chromium.org/20328002

git-svn-id: http://skia.googlecode.com/svn/trunk@10359 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 15:33:13 +00:00
robertphillips@google.com
44a91dcf25 Add GrContext::setMaxTextureSizeOverride
https://codereview.chromium.org/20325002/



git-svn-id: http://skia.googlecode.com/svn/trunk@10358 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 15:32:06 +00:00
sglez@google.com
a9b7936a72 Add lua_pictures target to tools.gyp
BUG=
R=rmistry@google.com

Review URL: https://codereview.chromium.org/20321002

git-svn-id: http://skia.googlecode.com/svn/trunk@10355 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 14:55:18 +00:00
reed@google.com
56172676c6 use namespace instead of static for template params
git-svn-id: http://skia.googlecode.com/svn/trunk@10354 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 14:46:22 +00:00
reed@google.com
5d1e5589fe experimental dynamic-hash (disabled)
git-svn-id: http://skia.googlecode.com/svn/trunk@10353 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 14:36:15 +00:00
humper@google.com
af42a03051 add all four filter levels to the downsample gm, for comparison across cpu/gpu
BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/20317002

git-svn-id: http://skia.googlecode.com/svn/trunk@10352 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 14:34:13 +00:00
robertphillips@google.com
790930812b Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@10345 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 12:46:49 +00:00
robertphillips@google.com
9bf380ce7f drawBitmap* cleanup
https://codereview.chromium.org/19977003/



git-svn-id: http://skia.googlecode.com/svn/trunk@10342 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 12:10:42 +00:00
skia.committer@gmail.com
5c561cb8d8 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10340 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 07:01:00 +00:00
senorblanco@chromium.org
b1135a3ecd New baselines for tests affected by r10338 (and others).
TBR=
BUG=

Review URL: https://codereview.chromium.org/20236002

git-svn-id: http://skia.googlecode.com/svn/trunk@10339 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 02:40:19 +00:00
senorblanco@chromium.org
194d775edc This patch implements a crop rect for SkImageFilter. It has been implemented for SkColorFilterImageFilter and SkBlurImageFilter as examples.
In order to preserve the immutability of SkImageFilters, the crop rect is passed as a constructor parameter. If NULL (the default), the bounds of the input image are used, as before.

This also tightens up the boundary handling for SkImageBlurFilter on the GPU backend. Where we were previously using clamping semantics, we now respect decal semantics (so we don't oversaturate the edges). This brings the GPU and raster backends into closer alignment, but will require some new baselines for the GPU tests.

At a minimum, the following tests will need new baselines: imageblur, imagefiltersbase, imagefilterscropped, spritebitmap.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10251

Review URL: https://codereview.chromium.org/19775006

git-svn-id: http://skia.googlecode.com/svn/trunk@10338 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 22:19:24 +00:00
humper@google.com
91673aafdf search registered rtconf variables backwards and break when we find the
first match.  Patch from mozilla

BUG=
R=mtklein@google.com

Review URL: https://codereview.chromium.org/20136003

git-svn-id: http://skia.googlecode.com/svn/trunk@10337 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 21:44:40 +00:00
commit-bot@chromium.org
ff36a1d07f Start from scratch on a faster SkFlatDictionary.
This is like codereview.chromium.org/19276003, except it fits in better with the existing code, doesn't leak memory, and because it's back using SkChunkFlatController it's a little faster too, now a win across the board:

Slowdown	bench
-1.59%	desk_youtubetvbrowse.skp
-2.56%	desk_googlehome.skp
-6.40%	tabl_androidpolice.skp
-6.45%	desk_youtubetvvideo.skp
-6.91%	tabl_googlecalendar.skp
...
-29.70%	desk_yahoogames.skp
-32.17%	desk_googlespreadsheet.skp
-32.23%	mobi_wikipedia.skp
-37.16%	desk_chalkboard.skp
-41.57%	desk_pokemonwiki.skp
Overall slowdown: -22.74%

running bench [640 480] picture_record_recurring_paint_dictionary  NONRENDERING: cmsecs =   9.92
running bench [640 480] picture_record_unique_paint_dictionary  NONRENDERING: cmsecs =  22.16
running bench [640 480]  picture_record_dictionaries  NONRENDERING: cmsecs =   9.18

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10328

R=tomhudson@google.com, reed@google.com, scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/19564007

git-svn-id: http://skia.googlecode.com/svn/trunk@10336 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 20:37:30 +00:00
reed@google.com
1e182253f8 free cache in destructor, in case endContext was not called. change Resize to return bool indicating success.
BUG=
R=humper@google.com

Review URL: https://codereview.chromium.org/20102002

git-svn-id: http://skia.googlecode.com/svn/trunk@10335 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 20:10:42 +00:00
edisonn@google.com
2c88fe87bd pdfviewer: fix path shortcuts in python script, use os.path.join()
Review URL: https://codereview.chromium.org/19623007

git-svn-id: http://skia.googlecode.com/svn/trunk@10334 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 19:42:11 +00:00
epoger@google.com
c60e745356 rebaseline.py: add ability to write new expectations to a different file
(instead of overwriting the original expectations file)

R=zachr@google.com

Review URL: https://codereview.chromium.org/19805007

git-svn-id: http://skia.googlecode.com/svn/trunk@10333 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 19:36:51 +00:00
edisonn@google.com
d6c276f1fe pdfviewer: sets module is deprecated. use set
Review URL: https://codereview.chromium.org/20101002

git-svn-id: http://skia.googlecode.com/svn/trunk@10332 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 19:31:30 +00:00