Commit Graph

7799 Commits

Author SHA1 Message Date
bungeman@google.com
0b4d6b289c Basic error checking for debugger GL widget.
Currently the debugger segfaults if the GL context cannot be created.
This change allows the debugger to build with GL support, but still run if the
GL context cannot be created at runtime.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18275002

git-svn-id: http://skia.googlecode.com/svn/trunk@9834 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-01 13:54:10 +00:00
rmistry@google.com
637d24c18e Whitespace change to trigger GCE compile bots.
git-svn-id: http://skia.googlecode.com/svn/trunk@9833 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-01 13:50:32 +00:00
robertphillips@google.com
c111ce22e7 Partial revert of r9812 & put rest of r9812 behind a compile flag
https://codereview.chromium.org/18317003/



git-svn-id: http://skia.googlecode.com/svn/trunk@9832 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-01 13:10:10 +00:00
scroggo@google.com
6c4c3a5554 Fixes for nacl_debugger's use of picture.
Now that CreateFromStream is used, check for NULL rather than
looking at width and height (prevents a crash on an invalid SKP).

Unref the picture when done with it.

Remove the member variable for picture, since it is only accessed
inside the one function.

R=borenet@google.com

Review URL: https://codereview.chromium.org/18055014

git-svn-id: http://skia.googlecode.com/svn/trunk@9831 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-01 12:42:49 +00:00
scroggo@google.com
fa13a632a0 Expect razr to fail on some decoding tests.
Review URL: https://codereview.chromium.org/18272005

git-svn-id: http://skia.googlecode.com/svn/trunk@9830 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-01 12:38:50 +00:00
skia.committer@gmail.com
a6ff36bd61 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9826 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-29 07:03:21 +00:00
edisonn@google.com
5d41b36dd5 refactor folders to make prepare for native pdf parser
Review URL: https://codereview.chromium.org/18179007

git-svn-id: http://skia.googlecode.com/svn/trunk@9825 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 22:01:06 +00:00
scroggo@google.com
1e34b34a6c Use CreateFromStream in nacl debugger.
Review URL: https://codereview.chromium.org/18153012

git-svn-id: http://skia.googlecode.com/svn/trunk@9824 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 21:57:51 +00:00
scroggo@google.com
0e0180a176 Temporary change to keep chrome happy.
Add back in a version of the constructor taking a stream so that
chrome can build until we switch chrome to using the factory.

Will be reverted once chrome switches to using the factory.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/17916003

git-svn-id: http://skia.googlecode.com/svn/trunk@9823 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 21:35:29 +00:00
scroggo@google.com
f1754ec691 Replace SkPicture(SkStream) constructors with a factory.
SkPicture:
Remove the constructors which take an SkStream as an argument. Rather
than having to check a variable for success, the factory will return
NULL on failure.
Add a protected function for determining if an SkStream is an SKP
to share code with SkTimedPicture.
In the factory, check for a NULL SkStream.
Use a default decoder (from BUG:
https://code.google.com/p/skia/issues/detail?id=1325)

SkDebuggerGUI:
Call SkPicture::CreateFromStream when necessary.
Write a factory for creating SkTimedPictures and use it.

Use the factory throughout tools.

Add include/lazy to utils and effects gyp include_dirs so SkPicture.h
can reference SkImageDecoder.h which references SkBitmapFactory.h (in
include/lazy).

Changes code Chromium uses, so this will require a temporary Skia
and then a change to Chromium to use the new Skia code.

TODO: Create a decoder that does nothing to be used by pinspect,
lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer.

R=reed@google.com

Review URL: https://codereview.chromium.org/17113004

git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 21:32:00 +00:00
scroggo@google.com
925cdca805 Skip the TIMESTAMP file.
Allows run_decoding_tests.py to pass the name of the folder, so
Android will not fail on account of the long adb command.

R=borenet@google.com

Review URL: https://codereview.chromium.org/18175008

git-svn-id: http://skia.googlecode.com/svn/trunk@9817 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 20:04:42 +00:00
reed@google.com
92833f99b9 use width() instead of fWidth to get int value
git-svn-id: http://skia.googlecode.com/svn/trunk@9816 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 19:47:43 +00:00
reed@google.com
60d3235ab4 add bitmap::eraseArea
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/18029021

git-svn-id: http://skia.googlecode.com/svn/trunk@9815 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 19:40:50 +00:00
bsalomon@google.com
0a208a117b Add flag bits for partial GrContext reset
BUG=248728
R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9802

Review URL: https://codereview.chromium.org/17027003

git-svn-id: http://skia.googlecode.com/svn/trunk@9814 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 18:57:35 +00:00
edisonn@google.com
ab03e6816b more work on pdf fonts, more to come
Review URL: https://codereview.chromium.org/18117005

git-svn-id: http://skia.googlecode.com/svn/trunk@9813 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 18:51:20 +00:00
robertphillips@google.com
353f0971d8 GPU "fix" for thin stroked rects
https://codereview.chromium.org/17845003/



git-svn-id: http://skia.googlecode.com/svn/trunk@9812 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 17:57:06 +00:00
scroggo@google.com
5330e44796 Print the file being deserialized before deserializing.
That way it is easier to tell which file failed.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/18219002

git-svn-id: http://skia.googlecode.com/svn/trunk@9811 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 17:52:53 +00:00
bungeman@google.com
44fb1faefe Make implicit cast explicit to fix r9807 on gcc.
git-svn-id: http://skia.googlecode.com/svn/trunk@9809 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 17:21:35 +00:00
bungeman@google.com
b20a1b56a0 Minimal changes for SampleApp to eb HiDPI aware on Mac.
R=caryclark@google.com

Review URL: https://codereview.chromium.org/18055009

git-svn-id: http://skia.googlecode.com/svn/trunk@9807 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 16:44:55 +00:00
zachr@google.com
572b54dd7a add point of interest API
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18176005

git-svn-id: http://skia.googlecode.com/svn/trunk@9806 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 16:27:33 +00:00
edisonn@google.com
ba669991e5 revert 9802 breacking tests on some configs
git-svn-id: http://skia.googlecode.com/svn/trunk@9805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 16:03:21 +00:00
zachr@google.com
5eef11b293 fix OpenCL memory leak
R=djsollen@google.com

Review URL: https://codereview.chromium.org/18051004

git-svn-id: http://skia.googlecode.com/svn/trunk@9804 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 15:37:15 +00:00
zachr@google.com
c0a75a879a add yee's perceptual metric
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18066004

git-svn-id: http://skia.googlecode.com/svn/trunk@9803 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 15:34:56 +00:00
bsalomon@google.com
cad107bbe7 Add flag bits for partial GrContext reset
BUG=248728
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/17027003

git-svn-id: http://skia.googlecode.com/svn/trunk@9802 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 14:32:08 +00:00
commit-bot@chromium.org
6bf19415c3 Clang has stricter checking for conversion to a null pointer. In C++11 mode, false will produce an error if it is used in a place that expects a pointer. Change these cases to NULL.
R=reed@google.com, robertphillips@google.com

Author: rtrieu@google.com

Review URL: https://chromiumcodereview.appspot.com/18118004

git-svn-id: http://skia.googlecode.com/svn/trunk@9800 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 11:47:01 +00:00
skia.committer@gmail.com
c9f6a1a1c5 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9799 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-28 11:00:20 +00:00
scroggo@google.com
0c5618d5a1 Add expectations files for skimage.
These were downloaded from Google Storage after being generated
by the build bots.

Review URL: https://codereview.chromium.org/18117006

git-svn-id: http://skia.googlecode.com/svn/trunk@9798 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 20:50:06 +00:00
scroggo@google.com
bc91e8b7d7 Fix run_decoding_tests on xoom.
Builder Test-Android-Xoom-Tegra2-Arm7-Debug fails run_decoding_tests
due to a couple of images. Add a way in skimage to ignore failures
if an image is expected to fail. Add an expectations file for xoom
that includes ignore-failure for the two files which are failing.

I have created https://code.google.com/p/skia/issues/detail?id=1382
to track the fact that these images fail to decode, despite the bot
showing green.

R=borenet@google.com

Review URL: https://codereview.chromium.org/18023008

git-svn-id: http://skia.googlecode.com/svn/trunk@9797 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 20:21:01 +00:00
edisonn@google.com
6e49c345b1 more work on pdf fonts, more to come
Review URL: https://codereview.chromium.org/18117005

git-svn-id: http://skia.googlecode.com/svn/trunk@9796 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 20:03:43 +00:00
commit-bot@chromium.org
f48e475528 Remove SK_DEBUG_PATH_REF
R=bungeman@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/18029006

git-svn-id: http://skia.googlecode.com/svn/trunk@9795 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 18:39:39 +00:00
zachr@google.com
db54dd3f5e add command line flags
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/17885003

git-svn-id: http://skia.googlecode.com/svn/trunk@9794 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 17:51:35 +00:00
djsollen@google.com
121b3fe6a0 Add MD5 support when syncing debug files and option to just start gdbserver
R=borenet@google.com

Review URL: https://codereview.chromium.org/17910006

git-svn-id: http://skia.googlecode.com/svn/trunk@9791 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 13:43:04 +00:00
edisonn@google.com
eee4b65d0b Basic load base font when specified in a FontDescriptor. basic load of TrueType font (FontFile2)
Review URL: https://codereview.chromium.org/18059003

git-svn-id: http://skia.googlecode.com/svn/trunk@9788 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 13:22:42 +00:00
borenet@google.com
bf55701291 Whitespace change to trigger rebuilds after master restart.
Unreviewed.

Review URL: https://codereview.chromium.org/18058002

git-svn-id: http://skia.googlecode.com/svn/trunk@9787 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 11:53:37 +00:00
skia.committer@gmail.com
52394d2ef7 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9786 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 07:00:58 +00:00
bungeman@google.com
4fe06995fc Fix for crbug/253460 (generatePath crashing on Windows).
Sometimes GetGlyphOutlineW returns a number larger than BUFFERSIZE
even if BUFFERSIZE > 0. It was previously expected that GetGlyphOutlineW
would always return GDI_ERROR in this case.



git-svn-id: http://skia.googlecode.com/svn/trunk@9785 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 22:57:29 +00:00
commit-bot@chromium.org
39095b9d14 Alias deref -> unref. This allows Skia objects to be held by WTF::RefPtr
smart pointers without need for another smart pointer type.

Note that the semantics of SkRefCnt match those WTF expects. In
particular, newly created objects have refcount 1 and objects are
deallocated at refcount 0.

This seems like a better fit than the AddRef/Release alises which exist
for scoped_ptr (but seem unused).

BUG=254509
R=reed@google.com

Author: jbroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17880003

git-svn-id: http://skia.googlecode.com/svn/trunk@9784 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 22:20:22 +00:00
reed@google.com
4a551d49cf struct != class, even in a friend forward declare
git-svn-id: http://skia.googlecode.com/svn/trunk@9783 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 21:28:10 +00:00
reed@google.com
2c31a4678d move legacy mipmap apis to private, save one that is currently called by chrome. It will go soon...
git-svn-id: http://skia.googlecode.com/svn/trunk@9782 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 21:09:37 +00:00
commit-bot@chromium.org
371add80f5 Remove SK_IGNORE_MAC_TEXT_BOUNDS_FIX workaround.
Now that SK_IGNORE_MAC_TEXT_BOUNDS_FIX is no longer used in Chromium, we can remove the code.

R=bungeman@gmail.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17886002

git-svn-id: http://skia.googlecode.com/svn/trunk@9781 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 21:08:11 +00:00
bsalomon@google.com
d4a2b63cfa ignore pyc files.
R=bungeman@google.com

Review URL: https://codereview.chromium.org/17845007

git-svn-id: http://skia.googlecode.com/svn/trunk@9778 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 20:38:39 +00:00
commit-bot@chromium.org
b8d00db075 Change undefined SkGpuRenderTarget and SkGpuTexture forward declares to GrRenderTarget and GrTexture.
R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/17269003

git-svn-id: http://skia.googlecode.com/svn/trunk@9775 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 19:18:23 +00:00
zachr@google.com
18bbba9a9a add globbing util function
R=djsollen@google.com

Review URL: https://codereview.chromium.org/17881002

git-svn-id: http://skia.googlecode.com/svn/trunk@9774 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 18:55:36 +00:00
edisonn@google.com
131d4ee0ea refactoring for pdf viewer lib
Review URL: https://codereview.chromium.org/17856004

git-svn-id: http://skia.googlecode.com/svn/trunk@9773 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 17:48:12 +00:00
robertphillips@google.com
ad4d499f86 Add a new GM for very thin stroke widths
git-svn-id: http://skia.googlecode.com/svn/trunk@9770 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 17:06:45 +00:00
bungeman@google.com
dd68f4533b Fix PathRefDebugRef (SK_DEBUG_PATH_REF) case for SkPath copy constructor.
Review URL: https://codereview.chromium.org/17902003

git-svn-id: http://skia.googlecode.com/svn/trunk@9768 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 15:53:29 +00:00
edisonn@google.com
172339dd18 remove RLE config from debugger too
Review URL: https://codereview.chromium.org/17857003

git-svn-id: http://skia.googlecode.com/svn/trunk@9766 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 15:28:42 +00:00
edisonn@google.com
afe397b079 fix build break, remove "RLE" from gConfigNames too
Review URL: https://codereview.chromium.org/17893004

git-svn-id: http://skia.googlecode.com/svn/trunk@9765 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 14:52:34 +00:00
reed@google.com
2cb1480ff8 remove kRLE_Index8_Config from SkBitmap
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/17740003

git-svn-id: http://skia.googlecode.com/svn/trunk@9764 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 14:35:02 +00:00
skia.committer@gmail.com
73a4b4f91f Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9763 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-26 07:00:59 +00:00