cdalton
0ce02c3ac1
Place nvpr above tesselating path renderer in the chain
...
BUG=skia:
Review URL: https://codereview.chromium.org/1123343003
2015-05-06 13:16:43 -07:00
reed
c1e1faae07
use floor for mip-level choice
...
this chrome change must land first: https://codereview.chromium.org/1131663002/
BUG=skia:
Review URL: https://codereview.chromium.org/1131613002
2015-05-06 13:02:37 -07:00
reed
a85d4d0814
Make drawImage a virtual on SkDevice
...
This reverts commit 06dad4b92f
.
BUG=485243
Review URL: https://codereview.chromium.org/1129843003
2015-05-06 12:56:48 -07:00
mtklein
44d43d8d6e
Add a control benchmark.
...
I'm thinking of using this in perf with something like:
ratio(fill(filter("test=foo")), fill(filter("test=control")))
Does that make sense to you?
Not sure that this is really a good control bench on all bots,
but I propose we just run it a bit and find out if it needs work.
BUG=skia:
Review URL: https://codereview.chromium.org/1129823003
2015-05-06 12:42:04 -07:00
cdalton
e4017d8ca7
Add layout qualifiers to GrGLShaderBuilder
...
BUG=skia:
Review URL: https://codereview.chromium.org/1114813002
2015-05-06 11:48:56 -07:00
mtklein
6fbf4b3a7f
Do we still need this DOUBLE_LOOP feature?
...
If so, let's do it this way so it works for all source types and doesn't need
to be chosen at compile time.
BUG=skia:
Review URL: https://codereview.chromium.org/1129693003
2015-05-06 11:35:40 -07:00
halcanary
bc4696b917
SkPDF: Move utility fns to SkPDFUtils
...
BUG=skia:3585
Review URL: https://codereview.chromium.org/1124193003
2015-05-06 10:56:04 -07:00
reed
06dad4b92f
Revert of Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1126273002/ )
...
Reason for revert:
still breaking webglconformance
Original issue's description:
> Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1124003002/ )
>
> Reason for revert:
> retry now that some fixes (onDrawImage overrides) have landed in chrome/blink
>
> Original issue's description:
> > Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/ )
> >
> > Reason for revert:
> > speculative to see if it unblocks DEPS roll
> >
> > Original issue's description:
> > > Make drawImage a virtual on SkDevice
> > >
> > > Now with patch for SkDeferredCanvas
> > >
> > > This reverts commit 119468b71f
.
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
> >
> > TBR=robertphillips@google.com ,mtklein@google.com,reed@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b
>
> TBR=robertphillips@google.com ,mtklein@google.com,reed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/620ba3afe09d4173c87537040fe50c1c1895fb1a
TBR=robertphillips@google.com ,mtklein@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1127993004
2015-05-06 10:16:02 -07:00
borenet
d9b6be197f
Remove upright-matrix- configs from Android bots
...
The Android bots are flaking like crazy. I'm not sure if these configs
are hurting the situation, but let's see if this helps.
TBR=mtklein,halcanary
BUG=skia:
Review URL: https://codereview.chromium.org/1131603002
2015-05-06 08:33:51 -07:00
reed
620ba3afe0
Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1124003002/ )
...
Reason for revert:
retry now that some fixes (onDrawImage overrides) have landed in chrome/blink
Original issue's description:
> Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/ )
>
> Reason for revert:
> speculative to see if it unblocks DEPS roll
>
> Original issue's description:
> > Make drawImage a virtual on SkDevice
> >
> > Now with patch for SkDeferredCanvas
> >
> > This reverts commit 119468b71f
.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
>
> TBR=robertphillips@google.com ,mtklein@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b
TBR=robertphillips@google.com ,mtklein@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1126273002
2015-05-06 07:54:38 -07:00
mtklein
7882924c10
DM: add Via abstract class
...
BUG=skia:
Review URL: https://codereview.chromium.org/1117183007
2015-05-06 07:54:07 -07:00
mtklein
0d992db1cf
Make SkFunction copyable so it can go in containers.
...
This totally overhauls the implementation to use ordinary inheritance-based type erasure. I give up for now getting my manual vtable shenanigans to work with MSVC. Still those same "expected ; before ), also expected ) before ;" errors.
I added support for uninitialized SkFunctions and operator=(), because it was fairly straightforward with this implementation.
The main downside here is that I've removed the inline implementation. All SkFunctions involve a heap allocation, even when just wrapping function pointers.
BUG=skia:
Review URL: https://codereview.chromium.org/1056673002
2015-05-06 07:40:26 -07:00
joshualitt
444987fea8
small fix to correct bounds on distance field text
...
BUG=skia:
Review URL: https://codereview.chromium.org/1122253003
2015-05-06 06:46:01 -07:00
robertphillips
84b008873b
Add GrAAConvexTessellator class
...
This CL adds a GrAAConvexTessellator class. It does not connect it to the GrAAConvexPathRenderer.
Review URL: https://codereview.chromium.org/1084943003
2015-05-06 05:15:57 -07:00
robertphillips
91d06bcc6c
Reduce the API surface of GrBufferAllocPool and its derivatives
...
This utility class is going to be revamped and moved. This CL shrinks it a bit so there will be less to shuffle around.
Review URL: https://codereview.chromium.org/1126753003
2015-05-06 04:38:36 -07:00
reed
3538e3bfe2
Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/ )
...
Reason for revert:
speculative to see if it unblocks DEPS roll
Original issue's description:
> Make drawImage a virtual on SkDevice
>
> Now with patch for SkDeferredCanvas
>
> This reverts commit 119468b71f
.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
TBR=robertphillips@google.com ,mtklein@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1124003002
2015-05-05 17:30:45 -07:00
joshualitt
d96a67bcb1
small cleanup in GrOvalRenderer
...
BUG=skia:
Review URL: https://codereview.chromium.org/1126723004
2015-05-05 14:09:05 -07:00
joshualitt
0c14bccc31
trivial fix for drawvertices bounds
...
BUG=skia:
Review URL: https://codereview.chromium.org/1127633003
2015-05-05 13:58:20 -07:00
bsalomon
301f989c65
Fix vertex/index buffer leaks
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/1123823004
2015-05-05 13:20:09 -07:00
borenet
e3aeaec7dd
Add matrix configs to DM
...
BUG=skia:832
Review URL: https://codereview.chromium.org/1125793002
2015-05-05 13:11:27 -07:00
mtklein
d31c13d044
DM: add a Via to simulate SP pictures.
...
Will use this to test the other CL that adds small SkPicture implementations.
Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now.
BUG=skia:
Review URL: https://codereview.chromium.org/1126613005
2015-05-05 12:59:56 -07:00
reed
14fe8fd3e5
Make drawImage a virtual on SkDevice
...
Now with patch for SkDeferredCanvas
This reverts commit 119468b71f
.
BUG=skia:
Review URL: https://codereview.chromium.org/1122643005
2015-05-05 12:54:33 -07:00
reed
beedb81a7f
add DeferredCanvas mode to SampleApp
...
BUG=skia:
Review URL: https://codereview.chromium.org/1129603002
2015-05-05 12:14:45 -07:00
joshualitt
af242958a5
create GrInOrderCommandBuilder
...
BUG=skia:
Review URL: https://codereview.chromium.org/1118403003
2015-05-05 11:55:39 -07:00
mtklein
a16e69ec6c
DM: add draw_to_canvas() to trim some boilerplate for Vias.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1123743007
2015-05-05 11:38:45 -07:00
reed
d1290843c3
remove dead code behind BOOL_ONGETINFO
...
need this to land in chrome first https://codereview.chromium.org/1125573002
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1123473004
2015-05-05 11:36:02 -07:00
halcanary
002653e78c
SkPDF: Remove unused deprecated functions in SkPDFTypes
...
depends on:
http://crrev.com/1107923002
http://crrev.com/1103163002
http://crrev.com/1110533002
http://crrev.com/1107913002
http://crrev.com/1106163002
BUG=skia:3585
Review URL: https://codereview.chromium.org/1113583002
2015-05-05 11:28:55 -07:00
joshualitt
ad17cfc8c7
Move RectBatch to GrRect
...
BUG=skia:
Review URL: https://codereview.chromium.org/1127713002
2015-05-05 10:45:57 -07:00
mtklein
e4b19c4593
Add presubmit to run {dm,nanobench}_flags.py test
when changed.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1129443005
2015-05-05 10:28:44 -07:00
halcanary
bf51cfdbd9
SkPDF: clean up uses of deprecated calls in SkPDFFont
...
BUG=skia:3585
Review URL: https://codereview.chromium.org/1110533002
2015-05-05 10:24:09 -07:00
bsalomon
cb8979d088
Move DrawInfo out from GrDrawTarget and rename to GrVertices.
...
Review URL: https://codereview.chromium.org/1124733004
2015-05-05 09:51:38 -07:00
joshualitt
e46760e8b2
Create GrCommandBuilder
...
BUG=skia:
Review URL: https://codereview.chromium.org/1113313003
2015-05-05 08:41:50 -07:00
borenet
f4e0857fe9
Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4
...
BUG=skia:3802
Review URL: https://codereview.chromium.org/1115303004
2015-05-05 08:28:23 -07:00
reed
06a22f618c
add deferred config to DM
...
BUG=skia:
Review URL: https://codereview.chromium.org/1113273006
2015-05-05 08:11:33 -07:00
jvanverth
876f48b6cd
Adjust tolerance to fix GPU hairline curve issues
...
BUG=chromium:472847
Review URL: https://codereview.chromium.org/1126793003
2015-05-05 08:01:51 -07:00
halcanary
72266fd1fe
SkPDF: clean up uses of deprecated calls in SkDocument_PDF
...
BUG=skia:3585
Review URL: https://codereview.chromium.org/1107913002
2015-05-05 08:00:24 -07:00
kkinnunen
261694c98a
Avoid using SkPathEffect::DashInfo in GrStrokeInfo
...
Avoid using SkPathEffect::DashInfo for storing the phase
in GrStrokeInfo. Instead, just use normal instance variables.
Fixes the copy constructor pointing the DashInfo interval pointer
to the wrong interval data.
Also fixes GrStrokeInfo::setDashInfo(const SkPathEffect::DashInfo&)
by updating the fDashType correctly.
Makes it simpler to write code such as the operator== in the future.
Review URL: https://codereview.chromium.org/1110093002
2015-05-05 08:00:10 -07:00
reed
67383fcfc1
remove dead code for SK_SUPPORT_LEGACY_RADIAL_GRADIENT_SQRT
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1122933002
2015-05-05 07:55:19 -07:00
stephana
deee2980f4
cleanup
...
BUG=skia:
Review URL: https://codereview.chromium.org/1085583006
2015-05-05 07:55:06 -07:00
reed
7d3bdc3aa5
remove dead SK_SUPPORT_LEGACY_CUBIC_CHOPPER code
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1116263005
2015-05-05 07:49:56 -07:00
bsalomon
b5238a7571
Start on simplifying generateGeometry() overrides
...
Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963
Review URL: https://codereview.chromium.org/1122673002
2015-05-05 07:49:49 -07:00
reed
119468b71f
Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188 … (patchset #2 id:20001 of https://codereview.chromium.org/1122813002/ )
...
Reason for revert:
did not update DeferredCanvas
Original issue's description:
> Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/ )"
>
> Fixed serialization from prev CL
>
> This reverts commit 973d1f1f60
.
>
> BUG=skia:3803
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/5392785080001fe737fac9e5801fc2127a78d4fb
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803
Review URL: https://codereview.chromium.org/1123743006
2015-05-05 05:42:02 -07:00
egdaniel
99bc9fdfb5
Remove canTweakAlphaForCoverage from XP's since batch reads flag.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1127693002
2015-05-04 12:58:16 -07:00
bungeman
64fb51d36d
Fix typeface ids on Mac.
...
The current typeface ids with CoreText rely on ATS (which causes
memory use issues) or font data (which is unreliable, and will not
work with axes and synthetics). This changes the code so that stream
fonts never end up in the cache and always get a unique id, and
system fonts will be given an id as they are used.
Review URL: https://codereview.chromium.org/1125763002
2015-05-04 12:03:51 -07:00
bsalomon
07ab9f3bed
Don't attempt to draw path if dashing or stroking fails
...
TBR=egdaniel@google.com
Committed: https://skia.googlesource.com/skia/+/39202f12d37b6ef69ffaddcaa8cc92c621fcda41
Review URL: https://codereview.chromium.org/1119393002
2015-05-04 11:41:57 -07:00
bsalomon
8415abe44c
Revert of Start on simplifying generateGeometry() overrides (patchset #10 id:160001 of https://codereview.chromium.org/1122673002/ )
...
Reason for revert:
Breaking bots
Original issue's description:
> Start on simplifying generateGeometry() overrides
>
> Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1124633003
2015-05-04 11:41:42 -07:00
bsalomon
f28381c686
Start on simplifying generateGeometry() overrides
...
Review URL: https://codereview.chromium.org/1122673002
2015-05-04 11:27:45 -07:00
bsalomon
b327c3a84a
Revert of Don't attempt to draw path if dashing or stroking fails (patchset #1 id:1 of https://codereview.chromium.org/1119393002/ )
...
Reason for revert:
Doesn't draw
Original issue's description:
> Don't attempt to draw path if dashing or stroking fails
>
>
> TBR=egdaniel@google.com
>
> Committed: https://skia.googlesource.com/skia/+/39202f12d37b6ef69ffaddcaa8cc92c621fcda41
TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1119423002
2015-05-04 11:21:34 -07:00
mtklein
19e259b1ee
ignore_result()
...
BUG=skia:3801
Review URL: https://codereview.chromium.org/1127603003
2015-05-04 10:54:48 -07:00
reed
5392785080
Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/ )"
...
Fixed serialization from prev CL
This reverts commit 973d1f1f60
.
BUG=skia:3803
TBR=
Review URL: https://codereview.chromium.org/1122813002
2015-05-04 10:49:41 -07:00