Commit Graph

6138 Commits

Author SHA1 Message Date
bungeman@google.com
118c1a70c7 SkNextLog2 requires positive values.
git-svn-id: http://skia.googlecode.com/svn/trunk@7474 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 21:23:13 +00:00
bungeman@google.com
a265a1e35d SkNextLog2 requires values > 0.
git-svn-id: http://skia.googlecode.com/svn/trunk@7472 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 21:10:05 +00:00
robertphillips@google.com
1447aa3f3b Added option of profiling GPU backend to debugger
https://codereview.appspot.com/7248045/



git-svn-id: http://skia.googlecode.com/svn/trunk@7471 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 21:09:09 +00:00
bungeman@google.com
e83e994da4 Avoid possible O(n) stack space use by skqsort.
https://codereview.appspot.com/7222043/


git-svn-id: http://skia.googlecode.com/svn/trunk@7470 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 21:01:26 +00:00
robertphillips@google.com
5b33211c5e Start addressing the clang static analyzer issues
https://codereview.appspot.com/7249043/



git-svn-id: http://skia.googlecode.com/svn/trunk@7469 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 20:33:12 +00:00
bungeman@google.com
70476652a0 bench_compare proper spacing and tab option.
https://codereview.appspot.com/6908056/


git-svn-id: http://skia.googlecode.com/svn/trunk@7468 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 19:22:51 +00:00
senorblanco@chromium.org
c2594f4106 This changes the signature of SkImageFilter::filterImageGPU() to use SkBitmaps for input and output, and removes the rect param. This allows us to return textures which are larger than the actual result, such as when GrAutoScratchTextures are used. The SkBitmap's size represents the active region, while the GrTexture's size is the full texture size.
This fixes the bicubic image filter GM on the GPU, which otherwise draws garbage outside the filtered region.  It also moves us closer to unifying the signatures of SkImageFilter::onFilterImage() and SkImageFilter::filterImageGPU().

Review URL: https://codereview.appspot.com/7180048

git-svn-id: http://skia.googlecode.com/svn/trunk@7467 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 19:08:47 +00:00
bsalomon@google.com
74749cd45c Add GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws in subclasses.
Review URL: https://codereview.appspot.com/7237045

git-svn-id: http://skia.googlecode.com/svn/trunk@7466 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 16:12:41 +00:00
junov@chromium.org
e94b5e40c5 Adding a new unit test that demonstrates that dithering affects constant gradients
Related bug: crbug.com/169602
Review URL: https://codereview.appspot.com/7220063

git-svn-id: http://skia.googlecode.com/svn/trunk@7465 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 15:52:06 +00:00
reed@google.com
e40591d548 return if we're invertible for the fast scale+trans case when we have no inverse
matrix to return.
Review URL: https://codereview.appspot.com/7231063

git-svn-id: http://skia.googlecode.com/svn/trunk@7464 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 15:47:42 +00:00
jvanverth@google.com
a8e66f76d9 Adds SkMWCRandom, which generates random numbers using a variant of George Marsaglia's multiply-with-carry "mother-of-all" method. This passes the tuftests suite so it should be much better than the current method (which does not).
https://codereview.appspot.com/7235056/


git-svn-id: http://skia.googlecode.com/svn/trunk@7463 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 15:42:19 +00:00
junov@chromium.org
5ae319cc0e Re-enbling blurrect gm test wich no longer fails with rtree/tileGrid
Some re-baselining may be necessary since the existing ones may be out of date.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7462 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 15:34:57 +00:00
reed@google.com
f53d0a998b add SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK option, to disable check for
lock-count-balance when we use pixelrefs.



git-svn-id: http://skia.googlecode.com/svn/trunk@7460 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 13:17:32 +00:00
caryclark@google.com
86adc0d414 shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7459 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 12:50:38 +00:00
skia.committer@gmail.com
2a772e14c5 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7458 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 07:05:59 +00:00
caryclark@google.com
aa35831d1d shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7453 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 20:28:49 +00:00
bungeman@google.com
81d3ce0b63 Mark SkPictureStateTree::Draw::operator< as const.
https://codereview.appspot.com/7222043/


git-svn-id: http://skia.googlecode.com/svn/trunk@7452 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 19:04:14 +00:00
djsollen@google.com
bd08473d9a Fix Japanese font issue for devices running JB MR1 and higher.
Android JB MR1 is using a new format of /system/etc/fallback_fonts.xml.
This CL preserves backwards compatibility, while also recognizing the
new fallback_fonts.xml format ("lang" attrbiute in <file/>).

NOTE: This CL was originally sumbitted for Chrome on Android (m18)

Review URL: https://codereview.appspot.com/7226053

git-svn-id: http://skia.googlecode.com/svn/trunk@7448 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 15:39:35 +00:00
caryclark@google.com
4025f6fed8 shape ops work in progress
update gyp files

git-svn-id: http://skia.googlecode.com/svn/trunk@7445 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 14:34:03 +00:00
reed@google.com
8c0bc9b712 add SK_API to SkMutex (for chrome)
git-svn-id: http://skia.googlecode.com/svn/trunk@7443 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 13:03:36 +00:00
rmistry@google.com
2c8abb4daf Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7442 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 12:25:35 +00:00
rmistry@google.com
4bf1e3c636 Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7441 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 12:23:53 +00:00
skia.committer@gmail.com
cdcb2ce274 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7439 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-29 07:05:52 +00:00
reed@google.com
24d10cb635 tweak to comments, ws change to trigger bots
git-svn-id: http://skia.googlecode.com/svn/trunk@7435 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 22:36:34 +00:00
scroggo@google.com
7312a18327 Remove a workaround in gm/xfermodes.cpp
We were performing a deep copy of the pixels in a SkBitmap to work around a bug where drawing an SkBitmap whose pixel memory was set with setPixels to an SkPicture did not preserve the pixel memory.

Since the workaround was written, we have fixed the bug in two ways:
1. If setPixels is called with a pointer, we wrap the pixels in an SkPixelRef.
2. Picture recording now makes a deep copy of mutable bitmaps.

Also switch to using onOnceBeforeDraw, an existing feature on GM that performs the purpose of the init function.

BUG=http://code.google.com/p/skia/issues/detail?id=224

Review URL: https://codereview.appspot.com/7220054

git-svn-id: http://skia.googlecode.com/svn/trunk@7433 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 21:14:21 +00:00
jvanverth@google.com
ade32668eb Add missing params to renderer->resetState().
https://codereview.appspot.com/7234051/


git-svn-id: http://skia.googlecode.com/svn/trunk@7431 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 21:09:05 +00:00
junov@chromium.org
94f20dc89a Fixing crash in cloning empty SkPicture object
BUG=https://code.google.com/p/chromium/issues/detail?id=172062
TEST=Pictures unit test, test_clone_empty
Review URL: https://codereview.appspot.com/7223048

git-svn-id: http://skia.googlecode.com/svn/trunk@7430 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 21:04:44 +00:00
robertphillips@google.com
68f670fa72 Fix assert
https://codereview.appspot.com/7234050/



git-svn-id: http://skia.googlecode.com/svn/trunk@7428 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:55:42 +00:00
reed@google.com
75847199c2 fix build
Review URL: https://codereview.appspot.com/7229052

git-svn-id: http://skia.googlecode.com/svn/trunk@7426 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:53:22 +00:00
reed@google.com
b941bb3465 REBASELINE: enable setline fix for scan converter, with SK_IGNORE_SETLINE_FIX build guard.
Review URL: https://codereview.appspot.com/7225056

git-svn-id: http://skia.googlecode.com/svn/trunk@7425 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:43:09 +00:00
scroggo@google.com
08085f808b Change the method for timing individual tiles in bench_pictures.
When timing individual tiles in bench_pictures, keep a timer running
across all repeats, and then take the average. The former method of
timing each iteration separately runs into precision errors on some
platforms.

Running on my Mac Pro with OSX 10.8, the cmsecs for the new method
and the old method are roughly the same when checking the CPU time.
When checking the wall time, the old method often gives me 0ms,
while the new method gives me a larger value. I don't think this
can be entirely attributed to rounding though, since on occasion I
see the old method showing a short time period (.05 - .15ms) while
the new method shows .15ms higher (which is in range for the
difference I'm seeing for other tiles where the old method reports
0ms).

Some other changes:
PictureRenderer::resetState now takes a boolean parameter. If called
with false, it will only do a flush, while if called with true, it
will also call finish.

resetState is now called with true everywhere except in between
iterations of drawing the same tile (when timing individual tiles).

render_pictures_main no longer calls resetState directly, since it
already calls end, which calls resetState.

BUG=http://code.google.com/p/skia/issues/detail?id=1066

Review URL: https://codereview.appspot.com/7101060

git-svn-id: http://skia.googlecode.com/svn/trunk@7424 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:40:24 +00:00
jvanverth@google.com
cc78238f0b Move vertex layout definitions from GrDrawTarget to GrDrawState.
This is the first step in revising vertex layouts so that the currently
installed GrEffects determine the current vertex layout.

https://codereview.appspot.com/7235051/


git-svn-id: http://skia.googlecode.com/svn/trunk@7423 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:39:48 +00:00
robertphillips@google.com
4991b8f234 Added toString to SkDrawLooper-derived classes
https://codereview.appspot.com/7195054/



git-svn-id: http://skia.googlecode.com/svn/trunk@7422 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:21:59 +00:00
caryclark@google.com
85ec74ca54 shape ops work in progress
good checkpoint: nearly all tests pass solidly here

git-svn-id: http://skia.googlecode.com/svn/trunk@7420 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 19:25:51 +00:00
robertphillips@google.com
e219baf747 Add data() to all QString::toASCII Qt calls to help out Linux compiler
https://codereview.appspot.com/7232052/



git-svn-id: http://skia.googlecode.com/svn/trunk@7419 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 19:25:43 +00:00
robertphillips@google.com
ff6e6bade3 Add command line options to debugger
https://codereview.appspot.com/7221048/



git-svn-id: http://skia.googlecode.com/svn/trunk@7418 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 17:43:26 +00:00
reed@google.com
b6399a79b2 add (disabled) test for big dashing
git-svn-id: http://skia.googlecode.com/svn/trunk@7417 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:57:29 +00:00
senorblanco@chromium.org
22943cd588 Fix debug build. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7416 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:48:51 +00:00
bsalomon@google.com
cabe00eace Fix build break after r7411 when GR_STATIC_RECT_VB is enabled.
Review URL: https://codereview.appspot.com/7220051

git-svn-id: http://skia.googlecode.com/svn/trunk@7415 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:46:55 +00:00
senorblanco@chromium.org
ef5dbe1cd9 Add an origin flag for backend (external) textures. Some textures in WebKit have a topdown orientation, and skia needs to be notified of this, so that they are not drawn upside-down.
Review URL: https://codereview.appspot.com/7200048

git-svn-id: http://skia.googlecode.com/svn/trunk@7414 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:42:38 +00:00
bsalomon@google.com
02ddc8b85a Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7228048

git-svn-id: http://skia.googlecode.com/svn/trunk@7413 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 15:35:28 +00:00
bsalomon@google.com
9e040aed72 Remove unnecessary ptr derefs int r7411 (deref result is not used).
git-svn-id: http://skia.googlecode.com/svn/trunk@7412 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 14:31:19 +00:00
bsalomon@google.com
adc6536fe5 Remove getter of writable GrEffectStage from GrDrawState.
Upcoming changes will require GrDrawState to know things about the set of installed effects. Thus all setting of effects must go through a GrDrawState function (setEffect()). This change accomplishes that.
Review URL: https://codereview.appspot.com/7214045

git-svn-id: http://skia.googlecode.com/svn/trunk@7411 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 14:26:09 +00:00
mike@reedtribe.org
093455c116 add missing parameter to overridden onFindClickHandler
git-svn-id: http://skia.googlecode.com/svn/trunk@7410 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 02:21:27 +00:00
rmistry@google.com
27b6899b6a Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7409 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-27 17:17:19 +00:00
rmistry@google.com
42b8870069 Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7408 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-27 00:10:39 +00:00
rmistry@google.com
cc08c41aed Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7407 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-26 17:51:52 +00:00
skia.committer@gmail.com
e16efc1882 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-26 07:06:02 +00:00
rmistry@google.com
4899712109 Test for (SkipBuildbotRuns) II
git-svn-id: http://skia.googlecode.com/svn/trunk@7405 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 22:06:14 +00:00
rmistry@google.com
37eccd72c7 Test for (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7404 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 21:41:12 +00:00