brianosman
1638c0deea
Add destination color space to AsFPArgs. Eliminates last XFORMTODO.
...
This is going to be needed in many more places as I finish connecting the
dots. Even better - I'd like to switch to a world where SkColorSpace !=
nullptr is the only signal we use for gamma-correct rendering, so I can
eliminate SkSourceGammaTreatment and SkSurfaceProps::isGammaCorrect.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180503002
Review-Url: https://codereview.chromium.org/2180503002
2016-07-25 05:12:53 -07:00
brianosman
839345d634
Bundle SkShader::asFragmentProcessor arguments in a struct
...
The signature of this thing keeps changing (and is about to change again).
This just makes maintenance much easier.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175563003
Review-Url: https://codereview.chromium.org/2175563003
2016-07-22 11:04:53 -07:00
halcanary
f119796f95
tools/SkShaper: SkStream->blob
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142023002
Review-Url: https://codereview.chromium.org/2142023002
2016-07-12 09:17:43 -07:00
halcanary
627ad6db4c
using_skia_and_harfbuzz: use default typeface
...
Also: add little script to generate utf-8 test text.
BUG=skia:5434
TBR=bungeman@google.com
Review-Url: https://codereview.chromium.org/2118833002
2016-07-01 08:48:12 -07:00
bungeman
06ca8ec87c
sk_sp for Ganesh.
...
Convert use of GrFragmentProcessor, GrGeometryProcessor, and
GrXPFactory to sk_sp. This clarifies ownership and should
reduce reference count churn by moving ownership.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041113004
Review-Url: https://codereview.chromium.org/2041113004
2016-06-09 08:01:03 -07:00
brianosman
982eb7f377
Add new SkSourceGammaTreatment enum, used in situations like mipmap construction, where we need to know if we should respect (vs. ignore) the gamma encoding of sRGB tagged images. Plumb that extensively.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2037413002
Review-Url: https://codereview.chromium.org/2037413002
2016-06-06 13:10:58 -07:00
sdefresne
e3fa811657
[GN] Add support for disabling opts via SK_BUILD_NO_OPTS define.
...
When targetting iOS and using gyp to generate the build files, it is not
possible to select files to build depending on the architecture. Due to
that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS
was defined.
Since it is possible to select the correct optimised version when using
gn, this pessimisation is hurting the build. Introduce a new define to
disable the optimisation SK_BUILD_NO_OPTS. It will be used by Chromium
when building skia for iOS with gyp but not gn.
Define SK_BUILD_NO_OPTS along-side SK_BUILD_FOR_IOS for all files that
look like build configuration (Xcode projects, gyp configuration files,
public.bzl) in order to avoid introducing breakage on those builds.
BUG=607933
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002423002
Review-Url: https://codereview.chromium.org/2002423002
2016-06-01 07:08:56 -07:00
stephana
de8af07e41
Remove custom bundle ID for iOS
...
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1998273002
Review-Url: https://codereview.chromium.org/1998273002
2016-05-20 11:20:38 -07:00
brianosman
2d1ee7936e
Added --deepColor option to SampleApp, triggers creation of a ten-bit/channel
...
buffer. (Only on Windows at the moment). Uses new effect to do the final
gamma adjustment
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919993002
Review-Url: https://codereview.chromium.org/1919993002
2016-05-05 12:24:31 -07:00
halcanary
c34323549d
experimental/tools/coreGraphicsPdf2png: remove skia dependency
...
// experimental-only
TBR=
NOTRY=true
Review-Url: https://codereview.chromium.org/1950353002
2016-05-05 11:17:08 -07:00
halcanary
f5bf5785bc
experimental/tools/coreGraphicsPdf2png: fix
...
NOTRY=true
TBR=
Review-Url: https://codereview.chromium.org/1944403002
2016-05-04 08:42:35 -07:00
halcanary
f0da138c95
experimental/fiddle -> tools/fiddle
...
also, test building fiddle_main.cpp & draw.cpp
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1895143002
Review URL: https://codereview.chromium.org/1895143002
2016-04-18 11:50:07 -07:00
halcanary
7b8b237ef7
experimental/fiddle: update to new SkImage API
...
required by https://crrev.com/1897453002
NOTRY=true
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/1895103002
2016-04-18 08:17:56 -07:00
mtklein
fbcfd6d060
mojo -> nojo
...
BUG=skia:4891
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1889543003
Review URL: https://codereview.chromium.org/1889543003
2016-04-14 09:42:34 -07:00
cdalton
3f6f76f98b
Rename EmitArgs::fSamplers to fTexSamplers
...
Renames fSamplers to fTexSamplers in GrProcessor EmitArgs, and renames
GrGLSLTextureSampler to GrGLSLSampler. This will allow us to add a
second array of buffer samplers.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862373003
Review URL: https://codereview.chromium.org/1862373003
2016-04-11 12:18:09 -07:00
reed
60c9b58b32
change flattenable factory to return sk_sp
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002
Review URL: https://codereview.chromium.org/1855733002
2016-04-03 09:11:13 -07:00
halcanary
a5598a40f8
Fiddle: update to new GrGLAssembleInterface API
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1849753003
2016-03-31 10:35:13 -07:00
jcgregorio
9b2ef62d47
fiddle: Only output errors to stderr.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1843733002
Review URL: https://codereview.chromium.org/1843733002
2016-03-29 12:29:19 -07:00
halcanary
d096459b2b
experimental/fiddle: update to work again
...
NOTRY=true
Review URL: https://codereview.chromium.org/1834993003
2016-03-25 11:29:34 -07:00
fmalita
41c409634c
Relocate SK_SUPPORT_LEGACY_PICTURE_PTR
...
Move to platform-specific defines.
(Chromium already has this guard)
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831053002
Review URL: https://codereview.chromium.org/1831053002
2016-03-24 11:05:29 -07:00
mtklein
18300a3aa7
detach -> release
...
The C++ standard library uses the name "release" for the operation we call "detach".
Rewriting each "detach(" to "release(" brings us a step closer to using standard library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).
This was a fairly blind transformation. There may have been unintentional conversions in here, but it's probably for the best to have everything uniformly say "release".
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1809733002
Review URL: https://codereview.chromium.org/1809733002
2016-03-16 13:53:35 -07:00
halcanary
7d825f8d5c
experimental: coreGraphicsPdf2png
...
motivation: used for testing on my macbook.
TBR=
Review URL: https://codereview.chromium.org/1131643004
2016-03-09 11:26:51 -08:00
reed
8a21c9fe7f
use Make instead of Create to return a shared shader
...
Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002
Review URL: https://codereview.chromium.org/1772463002
2016-03-08 18:50:00 -08:00
reed
a0cee5f30e
remove align16 calls in skhader context sizes. will handle this elsewhere as needed
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768433003
TBR=
basically reverts previous CL, but keeps the create --> onCreate change
Review URL: https://codereview.chromium.org/1768433003
2016-03-04 07:38:12 -08:00
reed
773ceda51c
Enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )"
...
This reverts commit e38bcaf24b
.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763973002
TBR=
Review URL: https://codereview.chromium.org/1763973002
2016-03-03 18:18:25 -08:00
halcanary
e38bcaf24b
Revert of enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )
...
Reason for revert:
Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Debug failed dm:
....
FYI: loaded 23439 distinct uninteresting hashes from 23439 lines
Skipping config gpu: Don't understand 'gpu'.
Skipping config msaa16: Don't understand 'msaa16'.
168400 srcs * 7 sinks + 481 tests == 1179281 tasks
0ns elapsed, 5 active, 1179276 queued, 55MB RAM, 55MB peak
565 gm xfermodes2
565 gm xfermodes
565 gm xfermodeimagefilter
565 gm xfermodes3
565 gm verylarge_picture_image
c:\0\build\slave\workdir\build\skia\src\core\skshader.cpp:108:
fatal error: ""(0 == ((size) & 15))""
step returned non-zero exit code: 3
@@@STEP_FAILURE@@@
Original issue's description:
> enforce 16byte alignment in shader contexts
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004
>
> Committed: https://skia.googlesource.com/skia/+/d812fb458807245daa812adb7af0733cf5b54d96
TBR=mtklein@google.com ,fmalita@chromium.org,herb@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1759323002
2016-03-03 14:23:47 -08:00
reed
d812fb4588
enforce 16byte alignment in shader contexts
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004
Review URL: https://codereview.chromium.org/1759653004
2016-03-03 13:25:25 -08:00
bsalomon
5ec26ae9bf
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 08:33:02 -08:00
bsalomon
bd500f09ce
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ )
...
Reason for revert:
Need workaround for chrome to build
Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
> DOCS_PREVIEW= https://skia.org/?cl=1728093005
>
> Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1734043002
2016-02-25 06:52:12 -08:00
bsalomon
57599fe6c0
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 06:33:27 -08:00
fmalita
8d9f2e474a
Add ContextRec param to SkShader::contextSize()
...
To facilitate upcoming context selection changes.
R=reed@google.com ,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002
Review URL: https://codereview.chromium.org/1720933002
2016-02-22 10:39:41 -08:00
cdalton
5e58ceea85
Add GrShaderFlags enum
...
Replaces GrGLSLUniformHandler::ShaderVisibility with GrShaderFlags.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684063006
Review URL: https://codereview.chromium.org/1684063006
2016-02-11 12:49:47 -08:00
robertphillips
d3b32bf832
Last bit of GrGLSLFragmentProcessor-derived class cleanup
...
I believe these are the last two that used the dispreferred constructor pattern.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1667953005
Review URL: https://codereview.chromium.org/1667953005
2016-02-05 07:15:39 -08:00
robertphillips
bf536af15f
Next round of GrGLSLFragmentProcessor-derived class cleanup
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1661143003
Review URL: https://codereview.chromium.org/1661143003
2016-02-04 06:11:53 -08:00
halcanary
72002f28d5
SkMojo: generate on Darwin/x86_64
...
also clean up generate and skmojo.gyp to work right.
BUG=skia:4891
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660043004
Review URL: https://codereview.chromium.org/1660043004
2016-02-03 13:54:03 -08:00
halcanary
7a76f9c8f4
SkMojo: test linking Skia against the Mojo SDK
...
TODO: build on systems other than Linux.
Add mojo_skd to the DEPS.
Add a DM::Via called `mojo-`.
everything is hidden behind the gyp variable `skia_mojo`.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644043003
Review URL: https://codereview.chromium.org/1644043003
2016-02-03 11:53:19 -08:00
kkinnunen
973d92cf91
SampleApp: Remove SkWindow::setColorType
...
Remove SkWindow::setColorType, it is used wrong and inconsistently.
The color type is actually property of window backbuffer, used when the
window is painted with software. This is as opposed to a generic window
property that would affect all operation.
Similar to MSAA sample count for window GPU backbuffer, the bitmap
backbuffer color type should be a parameter of "attach" or "create
window" functions, should this property ever be added back.
The apps use the call wrong, setting the type as kRGBA_8888
or kBGRRA_8888 without no apparent rationale. These color types
are incorrect, as the raster surface can not work with these.
Reorganize the SkWindow::resize, since no change in SkWindow backbuffer size does not neccessarily mean that SkView would not need the call.
Do not show the sw backbuffer color type in SampleApp title, as
it does not really provide any information. On small screens,
kBGRA_8888_ColorType fills up the whole title.
BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1595503002
Review URL: https://codereview.chromium.org/1595503002
2016-01-18 01:18:35 -08:00
kkinnunen
8686a5eeef
SampleApp: remove Picture_DeviceType
...
Remove Picture_DeviceType from SampleApp SampleWindow DeviceType
enumeration.
Use a bool variable to control whether the drawing happens via
MultiPictureDraw.
The MultiPictureDraw mode can be activated by 'M', and title
is updated to contain "<MPD>". Previously the MPD mode was
inaccessible.
This works towards removing backend specific code from
SampleApp and VisualBench with the aim to move the code
to the common SkView framework (SkWindow in particular).
The grand goal is to be able to use command buffer GPU
API and NVPR in these apps.
BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1538343002
Review URL: https://codereview.chromium.org/1538343002
2016-01-05 00:04:33 -08:00
caryclark
0152cc3819
remove 565 effects shaders
...
This removes the 565 optimization for radial,
linear, sweep, and picture shaders. The
optimization gets little real-world use and
has a reasonable fallback. This also permits
removing the square root table for the radial
gradient case.
R=reed@google.com
BUG=skia:1947
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553103003
Review URL: https://codereview.chromium.org/1553103003
2016-01-04 09:54:55 -08:00
scroggo
671c06f979
Remove unused CallStacker
...
Found this while looking for uses of strlen (skbug.com/2810). This code
was written by a former member of the team and is not used.
BUG=skia:2810
Review URL: https://codereview.chromium.org/1512753006
2015-12-10 11:28:01 -08:00
halcanary
decb21e3ae
experiment/fiddle
...
Review URL: https://codereview.chromium.org/1349163003
2015-12-10 07:52:45 -08:00
egdaniel
7ea439b220
Create GLSLUniformHandler class for gpu backend
...
BUG=skia:
Review URL: https://codereview.chromium.org/1490283004
2015-12-03 09:20:44 -08:00
stephana
c60b310af7
Modify iOSShell-gyp to generate unique bundle identifier
...
BUG=skia:
Review URL: https://codereview.chromium.org/1483143002
2015-12-02 09:45:30 -08:00
egdaniel
4ca2e60343
Add ShaderBuilders to EmitArgs and remove gettings from ProgBuilder.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1457543003
2015-11-18 08:01:26 -08:00
caryclark
3257c12220
runs some sample animations side by side in canvas and svg
...
TBR=fmalita@chromium.org
Review URL: https://codereview.chromium.org/1342523002
2015-11-16 13:36:08 -08:00
egdaniel
57d3b039c6
Rename some processor functions from GL to GLSL
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1443743002
2015-11-13 11:57:27 -08:00
egdaniel
64c4728c70
Make all GrFragmentProcessors GL independent.
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1434313002
2015-11-13 06:54:19 -08:00
egdaniel
2d721d33aa
Move all ShaderBuilder files to GLSL
...
BUG=skia:
Review URL: https://codereview.chromium.org/1438003003
2015-11-11 13:06:05 -08:00
egdaniel
478c04efb3
Update sample to use new perlin noise shader, and make cloud like
...
BUG=skia:
Review URL: https://codereview.chromium.org/1410863006
2015-11-09 07:40:49 -08:00
ethannicholas
417011c80c
added experimental improved Perlin noise shader
...
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/1432863003
2015-11-09 06:35:12 -08:00