Bug: skia:11837
Change-Id: I92aacf8b412d0158036a5f27aa767590e426bd5c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417657
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
1fcbf77c73..ebf756983d
2021-06-11 ianelliott@google.com Vulkan: Fix AGI clear hierarchy bug for clear commands
2021-06-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d19e20ee6d7d to 7e098c965711 (1 revision)
2021-06-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 81ba5f47b66c to 9559e5836cc1 (1 revision)
2021-06-11 jplate@google.com CL: Add remaining enqueue commands
2021-06-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 399855f4bba6 to 5aaab2e1ec76 (226 revisions)
2021-06-11 ynovikov@chromium.org Add Android chromium.angle bots to CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jmbetancourt@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: jmbetancourt@google.com,robertphillips@google.com
Change-Id: I7cd053e63e42a8f9298be296f032895afca13f88
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418878
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This reverts commit 3d5483a547.
Reason for revert: Android roll.
Original change's description:
> Fix more new Clang warnings
>
> Change-Id: I82a13744669a6b5c23e23e6a719ec79878114dab
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418697
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
TBR=kjlubick@google.com,brianosman@google.com
Change-Id: I2032ee5efdb297b7cfdbe60ff2546305ef96ea57
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418937
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Change-Id: I17c624e9145d7152f65695ca3ce4592a11bb09a2
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418637
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This function was misleadingly named. It is meant to detect the cases
where we still want to use the legacy blitter; it does not actually
detect that we want to use the raster pipeline. Raster pipeline usage
is determined later by `create_SkRP_or_SkVMBlitter`.
The name probably made more sense before SkVMBlitter was introduced,
when the only two choices were "RasterPipeline" or "Legacy."
Change-Id: I4ed80e5d49a23ed22b3d34eb8a707cd752b5cc5d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418143
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Change-Id: I8d165b2d9b77b83ff32d8f081efdd927ab8d1aba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418737
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
The latest emscripten uses Clang 13, which points out some new warnings
about implicit copy constructors, copy assignment operators etc.
This addresses some that I found until llvm crashed and would not
compile further (https://bugs.llvm.org/show_bug.cgi?id=50408)
Change-Id: Ia4d3f0b308facb18bf2da50261326244a7848644
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413056
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Change-Id: I82a13744669a6b5c23e23e6a719ec79878114dab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418697
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Picks up a fix for a newer clang warning about deriving from std::iterator.
Change-Id: I68987d7b32e2bbd244a9ba93080b3df7c4abb548
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418676
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Change-Id: I63f724506dedd5c68b60bc36ed031a8b2ddbb1eb
Bug: skia:12097
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418636
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
GrCpuVertexAllocator, GrIsStrokeHairlineOrEquivalent and kLinearizationPrecision are still
useful in the NGA so divorce them from OGA-only classes.
Bug: skia:11837
Change-Id: Ib10e6b5448e0eb2b62c0178cfd019009a3a2e952
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418148
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This comment originally referred to a line that immediately followed it:
SkTBlitterAllocator allocator;
which was passed to the SkMakeBitmapShader call that followed it. This
was added at http://review.skia.org/8140 and removed soon afterwards at
http://review.skia.org/8407, but the comment was not removed.
Change-Id: Iebe4b34de737abaf3aa7c769f466a21802d0807a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418139
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
writeDataAsByteArray handles this case, exactly like we were doing.
Change-Id: I36f8597a106daa1566d884add47733708bd88ab4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418546
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
This makes the API accessible from the upcoming DSLParser.
Change-Id: I0ee31c7648e35dfeaa50285cf93dcdb9dd4872bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417678
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Change-Id: I10ecce06461eebcfa20d0ca41fc0fd2ef428679b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418145
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
In this iteration none of these commands appear in the sorted Cmds (and
the Save and Restore Cmds never will) but it sets things up for ClipCmds
being sorted.
Bug: skia:11837
Change-Id: Ia8be433cb01215c55a8b61de2ec24f5c456a0b10
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417416
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
GrStencilClip and GrStencilMaskHelper just come along for the ride
Bug: skia:11837
Change-Id: I7cfa2dd620b7457e6b6be4abf91b1ecd415d9b73
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417680
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
This will allow tracking to prevent setting duplicate state.
Change-Id: I7cc72125a5dce9efbd957f1dfffc85ce45681048
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418146
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Adlai Holler <adlai@google.com>
Now that fixed-count and convex fills are in, tessellation is expected
to be strictly faster always.
TBR=egdaniel@google.com
Bug: chromium:1163441
Bug: skia:11138
Bug: skia:11139
Change-Id: Ic77d4e2b4c99a113426f566e8ba2df4b4e1d5280
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418436
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This simple cache only remembers the locations of paths in the current
frame, so if multiple draws of the same path occur in a single frame,
they can share the same atlas entry. Its main motivation is for clip
paths.
Bug: b/188794626
Bug: chromium:928984
Change-Id: Ib909a41532cc7bdb802fab8c17f293398cd86356
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418217
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Adlai Holler <adlai@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Change-Id: I9f4378b622699d80bef449f9857117e9cc437956
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418140
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Change-Id: I734a91a1497f9b2fe8abcc572c7f60509bb043bd
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417977
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This lets the magic behavior of accessing a field of sk_Caps work from
DSL.
Change-Id: I7d21842023ee74b0d9ca8da44622a11e3a8319c8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417682
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
d769742c30..1fcbf77c73
2021-06-11 ianelliott@google.com Vulkan: Fix AGI hierarchy for query commands
2021-06-11 syoussefi@chromium.org Vulkan: SPIR-V Gen: Specialization constants
2021-06-10 ynovikov@chromium.org Roll chromium_revision 6c5859c895..399855f4bb (890175:891326)
2021-06-10 syoussefi@chromium.org Roll VK-GL-CTS from d17a353c6cd4 to 7f2ec8531b64 (15 revisions)
2021-06-10 syoussefi@chromium.org Declare specialization constants in the AST
2021-06-10 jplate@google.com CL: Add program build commands
2021-06-10 jmadill@chromium.org Use Chromium mirror of tools/perf.
2021-06-10 jplate@google.com CL: Add image enqueue commands
2021-06-10 sergeyu@google.com [Fuchsia] Cleanup vulkan_fuchsia_ext.h
2021-06-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4d0e65d25f37 to d19e20ee6d7d (4 revisions)
2021-06-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5ecc95a00e2b to 81ba5f47b66c (1 revision)
2021-06-10 gert.wollny@collabora.com test/ImageTest: Clear back buffer when test cleanup
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC adlai@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: adlai@google.com
Change-Id: I4f8307ef28d8f4ae53ff343db8a00b45ec4fa965
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417756
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
