Commit Graph

48047 Commits

Author SHA1 Message Date
skia-autoroll
3cf3a8c64f Roll third_party/externals/dawn 2d79ef264eba..754c161fd366 (5 commits)
https://dawn.googlesource.com/dawn.git/+log/2d79ef264eba..754c161fd366

git log 2d79ef264eba..754c161fd366 --date=short --first-parent --format='%ad %ae %s'
2020-04-30 jiawei.shao@intel.com Add basic supports of storage textures on Vulkan
2020-04-29 cwallez@chromium.org Fix and enable -Wfour-char-constants
2020-04-29 cwallez@chromium.org Fix and enable -Wvla-extension
2020-04-29 cwallez@chromium.org Enable -Wc++20-designator
2020-04-29 rharrison@chromium.org Rolling 5 dependencies

Also rolling transitive DEPS:
  https://chromium.googlesource.com/chromium/src/third_party/jinja2 b41863e42637..b41863e42637
  https://chromium.googlesource.com/chromium/src/third_party/markupsafe 8f45f5cfa000..8f45f5cfa000
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang 3f4e5c456306..39281fb710c3
  https://chromium.googlesource.com/external/github.com/google/shaderc ced9c72d005e..41f271e6139c

Created with:
  gclient setdep -r third_party/externals/dawn@754c161fd366

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ic7b33a3986219cde612e40a82d6fc947168e4b29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286298
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-30 13:17:00 +00:00
Corentin Wallez
93ce5b9708 Rolling 3 dependencies
Roll third_party/externals/shaderc/ ced9c72d0..41f271e61 (1 commit)

ced9c72d00..41f271e613

$ git log ced9c72d0..41f271e61 --date=short --no-merges --format='%ad %ae %s'
2020-04-28 rharrison Rolling 5 dependencies, updating expectations, and fixing build issues (#1051)

Roll third_party/externals/spirv-cross/ 6637610b1..7e0295abf (24 commits)

6637610b16..7e0295abf8

$ git log 6637610b1..7e0295abf --date=short --no-merges --format='%ad %ae %s'
2020-04-28 rharrison Update SPIR-V Headers to 1.5 rev 3
2020-04-27 post Work around odd deadlock in test_shaders.py in --parallel mode.
2020-04-27 post Implement OpAtomicLoad/OpAtomicStore.
2020-04-27 post MSL: Fix case where subpassInput is passed to leaf functions.
2020-04-27 alexis.payen Fixed recursion in combined_decoration_for_member Members in nested structs were not properly iterated on, and as a result, flags like row major for matrices could be not propagated properly.
2020-04-23 dsinclair Roll GLSLang, SPIRV-Tools and SPIRV-Headers.
2020-04-21 post GLSL: Support f16x2 <-> f32 bitcast.
2020-04-21 post Be a bit more careful what nonuniform state is propagated.
2020-04-21 post Handle RayQueryKHR type.
2020-04-21 post Update SPIR-V headers.
2020-04-18 devsh.graphicsprogramming Fix issue #1327
2020-04-21 post HLSL: Add parens in unpackUint2x32 for clarity.
2020-04-21 post HLSL: Only allow 64-bit integers in SM 6.0.
2020-04-21 post Ensure unpack/pack2x32 tests are compatible with test suite.
2020-04-17 bingkan GLSL/HLSL: Support packUint2x32 and unpackUint2x32
2020-04-21 post MSL: Deal correctly with initializers on Private variables.
2020-04-20 post MSL: Support edge case with DX layout in scalar block layout.
2020-04-20 post MSL: Allow removing clip distance user varyings.
2020-04-18 godlike Reflection: Add specialization constant name
2020-04-15 cdavis MSL: Force disabled fragment builtins to have the right name.
2020-04-15 cdavis MSL: Only disable output variables in fragment shaders.
2020-04-10 cdavis MSL: Add options to control emission of fragment outputs.
2020-04-09 h.baensch.92 Improve compatibility with clang-cl
2020-04-07 post MSL: Do not use base expression with PhysicalTypeID OpCompositeExtract.

Roll third_party/externals/spirv-headers/ f8bf11a02..c0df742ec (6 commits)

f8bf11a025..c0df742ec0

$ git log f8bf11a02..c0df742ec --date=short --no-merges --format='%ad %ae %s'
2020-04-24 cepheus Update headers to SPIR-V 1.5 Revision 3
2020-04-24 cepheus Add a bunch of missing "version" : "None" for ray tracing.
2020-04-24 cepheus Rebuild the headers with the fixed grammar file.
2020-04-24 cepheus Add missing "version" : "None" for ShaderCallKHR
2020-04-24 cepheus Grammar: The ray-tracing updates were not done in numerical ordering.
2020-04-13 cepheus Discuss generator magic number reservations.

Created with:
  roll-dep third_party/externals/shaderc third_party/externals/spirv-cross third_party/externals/spirv-headers

Change-Id: Ie435f5bc9ef0ca41dde5f0a17c262028c85c5dea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286337
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
2020-04-30 12:50:20 +00:00
Adlai Holler
5ba50afeed Replace skstd::exchange with std::exchange
Change-Id: Id8065e4ff7299c12b1469468dab278b771c0382d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286277
Auto-Submit: Adlai Holler <adlai@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-30 11:14:20 +00:00
skia-recreate-skps
21d1720203 Update Go Deps
Change-Id: Id4c44642b9c1d8c460028a3cd53d332899d7e1c8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286304
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-30 05:35:49 +00:00
skia-autoroll
d64d6f5e2b Roll third_party/externals/angle2 718ae5088c41..957417438089 (12 commits)
718ae5088c..9574174380

git log 718ae5088c41..957417438089 --date=short --first-parent --format='%ad %ae %s'
2020-04-29 sugoi@google.com Validation fix for draw with primcount <= 0
2020-04-29 jmadill@chromium.org GL loaders: Add 'ANGLE' symbol prefix.
2020-04-29 ancheng.qiao@arm.com Add gles1 covegl test compile
2020-04-29 b.schade@samsung.com Vulkan: Use DynamicBuffer for BufferVk
2020-04-29 jmadill@chromium.org Capture/Replay: Generate code integration.
2020-04-29 tobine@google.com Vulkan: Add debug label commands to SecondaryCommandBuffer
2020-04-29 xinghua.cao@intel.com Translate uniform block with large matrix array to StructuredBuffer
2020-04-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2717702e9a1f..941293d512fe (4 commits)
2020-04-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 72b2a3b275e5..f0f3d8b75af9 (7 commits)
2020-04-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 30eb0a301c33..c0f34c020d9d (1 commits)
2020-04-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3336e65e8801..f39209eb4402 (1 commits)
2020-04-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 23d68608b007..49ca250b44c6 (3 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@957417438089

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: ethannicholas@google.com
Change-Id: Ibfe049e884552428f3591e5b7a7078f31a39bade
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286299
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-30 04:52:29 +00:00
skia-autoroll
187cfac7ee Roll ../src 1a0f094cf1bb..c4c6cbc6102b (416 commits)
1a0f094cf1..c4c6cbc610


Created with:
  gclient setdep -r ../src@c4c6cbc610

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: ethannicholas@google.com
Change-Id: I54777ec8f70cb75810781ddac83ad36bb0666d82
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286296
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-30 04:44:19 +00:00
skia-autoroll
5f0965e44d Roll third_party/externals/swiftshader 941293d512fe..7d6b5913c98c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/941293d512fe..7d6b5913c98c

git log 941293d512fe..7d6b5913c98c --date=short --first-parent --format='%ad %ae %s'
2020-04-29 capn@google.com Avoid implicitly destructing thread-locals

Created with:
  gclient setdep -r third_party/externals/swiftshader@7d6b5913c98c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: ethannicholas@google.com
Change-Id: Ib9197c7bdc017321ad89eeae16eef17ce83b6473
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286297
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-30 04:39:59 +00:00
Herb Derby
47889a13e7 Use needsTransform() for deviceRect
In GrAtlasTextOp::init, I just had the deviceRect computed correctly
based on needsTransform, and it all seems to work. The bounds for large
RGB images were just wrong. This at least makes the interpretation of
fVertexBounds consistent. No diffs.

Change-Id: Icd1d26664280e2f7918e91a77293aab44e2d602d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285877
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-04-29 22:30:29 +00:00
Herb Derby
be6c7136ae cleanup device bounds calculation
We can store the so that they are relative to (0, 0), instead of the
initial origin. This simplifies much of the math for calculating the
device bounds. And, it remove the need for the inverse matrix in
GrTextBlob.

As a note, it looks like GrAtlasTextOp::init() may be calculating the
wrong bounds because it doesn't seem to respect needsTransform()
correctly. I'll check this out in the next CL.

Change-Id: Ia053b8b11ef8bbae5cc9e7bc547b918401519027
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285839
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-04-29 20:32:59 +00:00
Ethan Nicholas
e448900952 fixed UB in SkSL shift operations
Bug: oss-fuzz:20522
Change-Id: Ib08a988b83bac922e8076c62f568e329ef7866bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286136
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2020-04-29 19:49:47 +00:00
Mike Klein
77083c7d74 Revert "replace SkSharedMutex"
This reverts commit cfdc07aa0e.

Reason for revert: nope, flutter windows bots don't have it.  we got caught.

Original change's description:
> replace SkSharedMutex
> 
> I am debugging an issue with SkSharedMutex and noticed
> how sparsely it is used.  That got me curious to see if
> we can replace it with a std::shared_mutex (from C++17).
> 
> Bug: skia:10177
> Change-Id: I1ce4d2a5897af198d6ae5fb850548ff917a58f50
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285691
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,bungeman@google.com,herb@google.com

Change-Id: Iab4e55d749e386233ff0e2ba2c1cd10d5e6f1615
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10177
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286124
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 18:50:39 +00:00
Mike Klein
08e12ac54c add fm to build product whitelist
Change-Id: I4f507e46fa086d8a8c179dbb59e15e554b57a02f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286117
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 18:23:46 +00:00
Nathaniel Nifong
92e12b856f Remove libgifcodec from skottiekit build.
GIF decoding is not needed, saves another 5.5k on the brotli compressed binary

Change-Id: I4bc5f3e7bed83c190a73cb19dfb59f89fcc76cd8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285826
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2020-04-29 18:08:46 +00:00
Herb Derby
53a94381f8 treat fNeedsGlyphTransform the same for SDFT and Bitmap
MakeDistanceField should just make fNeedsGlyphTransform to
true making invariant maintenance closer to MakeBitmap.

Change-Id: I6e6652a45e39aa4d9ab4ceb16e8048ccb3655900
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286096
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-04-29 17:39:56 +00:00
Brian Salomon
702c5a3f42 Start on GM to directly test SkGpuBlurUtils
Bug: skia:10188

Change-Id: I29a8efe448532fecc2f7424622cd33afeee3287b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285876
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2020-04-29 16:50:56 +00:00
Mike Klein
c2160258f3 add skvx::{sin,cos,tan}
This lets us get rid of VECTOR_UNARY_FN_VEC.

I don't know exactly what was wrong with VECTOR_UNARY_FN_VEC,
but `color.rgb = color.rgb + a*(sin(6.28*color.rgb)*0.159)` looks
ok to me now when run through the interpreter.

Change-Id: I700398cd55eca1b8e1b3b46858415ecae5585a32
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286065
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 15:39:12 +00:00
Mike Klein
5be739bf4c add sin
enough to try out

    color.rgb = color.rgb + a*(sin(6.28*color.rgb)*0.159);

Change-Id: I45dbabb7f2a58aeebac4a651ed45b28ea90f9dd6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286059
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2020-04-29 14:32:21 +00:00
Mike Klein
cfdc07aa0e replace SkSharedMutex
I am debugging an issue with SkSharedMutex and noticed
how sparsely it is used.  That got me curious to see if
we can replace it with a std::shared_mutex (from C++17).

Bug: skia:10177
Change-Id: I1ce4d2a5897af198d6ae5fb850548ff917a58f50
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285691
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 14:15:42 +00:00
Florin Malita
a9379fb8ed [skottie] Contrast cleanup
- fix/update sample labels
  - make a note of sin-based improved approximation

TBR=
Change-Id: I53b02cd8a6dd1499805b9782fb6378d344476b87
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286037
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2020-04-29 13:57:22 +00:00
Mike Klein
cfb1b19e92 impl enough for contrast effect
I see roughly 10ms -> 5ms here in viewer when turning on skvm.

Change-Id: Ie8864ebc700ca914909d241a696e50295a0db366
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286028
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 13:42:12 +00:00
Michael Ludwig
af312c9d40 Revert "Refactor geometry union capabilities out of GrStyledShape"
This reverts commit 2becdde074.

Reason for revert: likely breaking cc unit test due to empty shape cap change.

Original change's description:
> Refactor geometry union capabilities out of GrStyledShape
> 
> The geometry union part of GrStyledShape is now held in GrShape. For the
> most part, GrShape is entirely style agnostic and focuses on storing
> the various types of geometry, and destructing them gracefully. It also
> provides a public API that unifies functionality across all shape types,
> such as contains() and bounds().
> 
> GrStyledShape now just owns a GrShape and a GrStyle, and handles the
> additional simplification logic that relies on knowing the effects of
> the style on the draw. This is where GrShape makes some allowances for
> style. Its simplify() function accepts flags that enable/disable various
> simplification optimizations. Currently these are designed around
> what is needed to respect path effects and stroking behaviors in
> GrStyledShape. The main other user of GrShape (the new clip stack) will
> always provide all flags since it treats every shape as if it were
> simply filled.
> 
> Several other related refactorings were taken at the same time:
> 1. The implementations for asNestedRects, asRRect, etc. were moved out
>    of the header and into the cpp file for GrStyledShape.
> 2. GrRenderTargetContext relies on GrStyledShape for its stroke rect
>    fallbacks.
> 3. GrShape can hold points, lines, and rects explicitly. This let me
>    simplify the stroke reasoning.
> 
> Change-Id: I9fe75613fee51c30b4049b2b5a422daf80a1a86e
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284803
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Chris Dalton <csmartdalton@google.com>

TBR=bsalomon@google.com,csmartdalton@google.com,michaelludwig@google.com

Change-Id: I2af5782e072e0ccb4a87f903bb88cbe335b9613f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286039
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-29 13:32:34 +00:00
Michael Ludwig
d91d8b60ce Revert "Fix round join comparison in if"
This reverts commit 9d4fa4f7bd.

Reason for revert: prior CL likely breaking chrome cc test

Original change's description:
> Fix round join comparison in if
> 
> This fixes adding round caps to empty rectangles with bevel joins.
> Introduced in https://skia-review.googlesource.com/c/skia/+/284803, I
> either forgot to finish my thought or inadvertently deleted it while
> editing.
> 
> TBR: ethannicholas@google.com, bsalomon@google.com
> 
> Change-Id: I72e6383260dae066c611454db9c7fa8c217422e4
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285957
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,ethannicholas@google.com,michaelludwig@google.com

Change-Id: I02e21e5ec9c14312dc9f36575dc0edccffc33e1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286038
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-29 13:32:14 +00:00
Mike Klein
e42af16143 add --stats to start with the stats overlay on
Change-Id: Ibc0a47258009a24bf7d9b378c9e21729b13d0216
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286027
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2020-04-29 13:22:22 +00:00
Florin Malita
f2072332f4 [skottie] Non-legacy (is this modern?) contrast effect support
Implement non-linear contrast using a cubic polynomial approximation,
as a SkRuntimeEffect.

The effect range is significantly more constrained than the legacy
version: https://www.desmos.com/calculator/ehem0vy3ft

Change-Id: I86bdbb9cc0d30065780f87705d2d4d39385609cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285840
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2020-04-29 12:42:41 +00:00
skia-recreate-skps
032631e490 Update Go Deps
Change-Id: I61c81e8d822c0c41d76034b7234820a054a61607
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285994
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-29 05:28:15 +00:00
skia-autoroll
849c26c00b Roll third_party/externals/angle2 4395170e6091..718ae5088c41 (12 commits)
4395170e60..718ae5088c

git log 4395170e6091..718ae5088c41 --date=short --first-parent --format='%ad %ae %s'
2020-04-29 ianelliott@google.com Vulkan: Always query EGL_WIDTH and EGL_HEIGHT
2020-04-28 jmadill@chromium.org Vulkan: Apply binding size in updateBuffersDescriptorSet.
2020-04-28 jmadill@chromium.org Ignore third_party/nasm in .gitignore.
2020-04-28 shrekshao@google.com Take into account baseVertex for drawElementsImpl D3D11
2020-04-28 jmadill@chromium.org Capture/Replay: Simplify .gni integration.
2020-04-28 jmadill@chromium.org Update .clang-format.
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 1512acdf047f..72b2a3b275e5 (4 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 62becc509a88..4c19ae6b95e4 (1 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 7774c964d3df..30eb0a301c33 (1 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 60aa34a990fa..2717702e9a1f (6 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 5547553a0c7b..23d68608b007 (7 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src bcf6a2430e99..f03cb290ac10 (3 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@718ae5088c41

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: ethannicholas@google.com
Change-Id: Ia108b30ad686dd392da18da5c67b38dbcfbc638e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285989
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-29 05:11:25 +00:00
skia-autoroll
756ed83aed Roll ../src 78824aa9d99f..1a0f094cf1bb (510 commits)
78824aa9d9..1a0f094cf1


Created with:
  gclient setdep -r ../src@1a0f094cf1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: ethannicholas@google.com
Change-Id: I98f749c931f41547e383d9294fa75ac918533daa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285986
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-29 04:56:15 +00:00
skia-autoroll
8a6f2ed4ff Roll third_party/externals/dawn 88f2ec853f80..2d79ef264eba (2 commits)
https://dawn.googlesource.com/dawn.git/+log/88f2ec853f80..2d79ef264eba

git log 88f2ec853f80..2d79ef264eba --date=short --first-parent --format='%ad %ae %s'
2020-04-28 cwallez@chromium.org Do not use Dawn's warnings for compiling Chromium's gtest main.
2020-04-28 bryan.bernhart@intel.com D3D12: Fix invalid allocation size check.

Also rolling transitive DEPS:
  https://chromium.googlesource.com/chromium/src/third_party/jinja2 b41863e42637..b41863e42637
  https://chromium.googlesource.com/chromium/src/third_party/markupsafe 8f45f5cfa000..8f45f5cfa000
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang 3f4e5c456306..3f4e5c456306
  https://chromium.googlesource.com/external/github.com/google/shaderc ced9c72d005e..ced9c72d005e

Created with:
  gclient setdep -r third_party/externals/dawn@2d79ef264eba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I2b28eb02e078c0dc653abe92561149c315f378fd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285988
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-29 04:38:25 +00:00
skia-autoroll
e40f988d76 Roll third_party/externals/swiftshader 2717702e9a1f..941293d512fe (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2717702e9a1f..941293d512fe

git log 2717702e9a1f..941293d512fe --date=short --first-parent --format='%ad %ae %s'
2020-04-28 amaiorano@google.com Eliminate use of Vulkan header BEGIN_RANGE/END_RANGE/RANGE_SIZE enums
2020-04-28 amaiorano@google.com Run clang-format on renamed headers
2020-04-28 amaiorano@google.com Rename Vulkan-source .h to .hpp
2020-04-28 bclayton@google.com ReactorUnitTests: Speed up multithreaded tests

Created with:
  gclient setdep -r third_party/externals/swiftshader@941293d512fe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: ethannicholas@google.com
Change-Id: I2db6a71c5b0acecd11e86ec73bd0db941ead2fec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285987
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-29 04:35:25 +00:00
Michael Ludwig
9d4fa4f7bd Fix round join comparison in if
This fixes adding round caps to empty rectangles with bevel joins.
Introduced in https://skia-review.googlesource.com/c/skia/+/284803, I
either forgot to finish my thought or inadvertently deleted it while
editing.

TBR: ethannicholas@google.com, bsalomon@google.com

Change-Id: I72e6383260dae066c611454db9c7fa8c217422e4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285957
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-28 22:51:45 +00:00
Robert Phillips
a50ce3c983 Revert "Add BGR_10A2 support to Ganesh"
This reverts commit 44fc53b7f5.

Reason for revert: Test to see if this is causing the linux-rel MediaColorTest.Yuv420pHighBitDepth failure on the Chrome roll

Original change's description:
> Add BGR_10A2 support to Ganesh
> 
> Bug: 1068416
> Change-Id: I40aa84b7f3f770ba550b7bea44c10173ae9a7ddf
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285356
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=egdaniel@google.com,jvanverth@google.com,robertphillips@google.com

Change-Id: I0ad0197ebd8de9b8761f84ba808c9f90891b9238
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1068416
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285958
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-04-28 22:30:46 +00:00
Mike Klein
1e0884d07a add --dylib to viewer
This JIT mode helps debugging and profiling by shelling out to an
external assembler then loading its results back in via dlopen(),
so you can see coherent function profiles and not just every
instruction as its own line in the profile.

It's very slow, so viewer will stutter for a second or two before
drawing goes smooth again.  We can paper over this by using the
interpreter while these compiles are in progress, but I haven't hooked
that up yet.

Change-Id: I23e74d65a1a3a6d89649733296db8217be306438
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285864
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-28 20:42:49 +00:00
Mike Klein
a73fa57a6b increase SkVMBlitter cache size
The old cache size was arbitrary, and the new one is also
somewhat arbitrary too, a nice round number and enough to
draw this without the overhead of JIT churn:

  viewer -f resources/skottie/skottie-brightnesscontrast-legacy.json

Change-Id: Ia84cea04535b4b88a58295186857cfe815173272
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285863
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2020-04-28 20:38:45 +00:00
Ethan Nicholas
afe2c90739 Revert "Revert "Converted texture and runtime effects to use GrMatrixEffect""
This reverts commit 36a3e014e1.

Change-Id: I2bb432ec423a85478adddc6845d5d7aa59d4055b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284918
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2020-04-28 20:37:44 +00:00
Mike Reed
3c411f58c4 remember to injectmoveto before arcTo
Bug: skia:9077
Change-Id: Iee1862fb3ebf2c0801794598ccf8a6977fa3ba1b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285841
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2020-04-28 19:52:20 +00:00
Michael Ludwig
2becdde074 Refactor geometry union capabilities out of GrStyledShape
The geometry union part of GrStyledShape is now held in GrShape. For the
most part, GrShape is entirely style agnostic and focuses on storing
the various types of geometry, and destructing them gracefully. It also
provides a public API that unifies functionality across all shape types,
such as contains() and bounds().

GrStyledShape now just owns a GrShape and a GrStyle, and handles the
additional simplification logic that relies on knowing the effects of
the style on the draw. This is where GrShape makes some allowances for
style. Its simplify() function accepts flags that enable/disable various
simplification optimizations. Currently these are designed around
what is needed to respect path effects and stroking behaviors in
GrStyledShape. The main other user of GrShape (the new clip stack) will
always provide all flags since it treats every shape as if it were
simply filled.

Several other related refactorings were taken at the same time:
1. The implementations for asNestedRects, asRRect, etc. were moved out
   of the header and into the cpp file for GrStyledShape.
2. GrRenderTargetContext relies on GrStyledShape for its stroke rect
   fallbacks.
3. GrShape can hold points, lines, and rects explicitly. This let me
   simplify the stroke reasoning.

Change-Id: I9fe75613fee51c30b4049b2b5a422daf80a1a86e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284803
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-04-28 19:17:08 +00:00
Weston Tracey
dded3c7506 Update provisioning_profile to unbreak iOS since cert refresh.
Change-Id: Ifb35349a1a1652994334cf63dcbb2c38b0bf6bb5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285836
Auto-Submit: Weston Tracey <westont@google.com>
Commit-Queue: Weston Tracey <westont@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-04-28 17:45:17 +00:00
Robert Phillips
44fc53b7f5 Add BGR_10A2 support to Ganesh
Bug: 1068416
Change-Id: I40aa84b7f3f770ba550b7bea44c10173ae9a7ddf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285356
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-04-28 17:07:57 +00:00
Herb Derby
c50f4e9399 Simplify GrTextBlob::flush
Change-Id: Ifc0693ffafdb62db68729232d1354a5915897f01
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285791
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-04-28 16:48:57 +00:00
Jim Van Verth
9145f784f3 Implement D3D copySurface.
Also fixes a minor assert in GrD3DBuffer, and removes an unused dxgi format

Change-Id: I4aa533b5c514d573fc606622c28ea7e2181bd7cb
Bug: skia:9935
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285499
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-04-28 16:37:57 +00:00
Herb Derby
02b91385f5 Rename flush -> addOp
Change-Id: I146cdde4818eca6c4198dfbb92c71face72a41f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285790
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Herb Derby <herb@google.com>
2020-04-28 15:42:44 +00:00
Joe Gregorio
a1e90aba44 Turn on Vulkan bots for Galaxy S20.
Change-Id: I7907c440a30f9f85830ac770340f09d77d76faee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285787
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2020-04-28 15:34:24 +00:00
Brian Osman
b2b9fbc567 Compare all fields in SkSL::Layout::operator==
Change-Id: I344bf5ddee4242f17325377a664ddb17b26e6f31
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285789
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-04-28 15:27:10 +00:00
Brian Osman
f1792cde0b Use constant swizzle syntax in GrDrawVerticesOp
Change-Id: Id159552ce558d278fa124c99080025cd11b0a42c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285784
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-04-28 14:52:22 +00:00
Florin Malita
fc75d5c52d [skottie] Brightness and Contrast effect
Add support for brightness/contrast, "legacy mode".  This effect can
be represented as a color matrix.

Brightness transfer function: https://www.desmos.com/calculator/zne0oqwwzb

Contrast transfer function: https://www.desmos.com/calculator/x5rxzhowhs

Change-Id: I2e6bb0f5f809aa0f33362bf753d2fe447059eaaa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285577
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
2020-04-28 14:33:12 +00:00
Mike Klein
e15088801e detect failed matrix update in SkDraw::drawAtlas()
We've been ignoring this since adding updaters with
https://skia-review.googlesource.com/c/skia/+/233061
last August.

Bug: 1070480
Change-Id: I55ed01b1d0a92731922fa2f509c1fa612cf17268
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285799
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-28 14:17:10 +00:00
Brian Osman
548de7451e Change Marker IDs to be strings
They are hashed to uint32_t at the API boundary (SkCanvas, SkVertices),
but making them functionally strings will make the SkSL interaction much
nicer.

Change-Id: I0979871bf3d21373812129eb7e994987b3030e00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285664
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-04-28 14:12:30 +00:00
Leon Scroggins III
7676f4ecf3 Remove SkFrontBufferedStream
Bug: skia:10154

Now that Android has moved to the new name
(android::skia::FrontBufferedStream), there is no need for this
redirect.

Change-Id: I1f2203a1d50bb222b8c105d8393a3b11ad6ee462
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285716
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-04-28 13:51:40 +00:00
Kevin Lubick
4baa7326cc [infra] Add POC task driver
Change-Id: I0f8972b62c938389772872adea2c96acc29ca503
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285665
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-04-28 11:50:17 +00:00
Chris Dalton
f5132a05c8 Reland "Optimize GrTessellatePathOp's code to emit inner triangles"
This is a reland of 0f9ebd100e

Original change's description:
> Optimize GrTessellatePathOp's code to emit inner triangles
>
> Previously we used a naive algorithm to generate "middle-out" topologies
> for inner polygons, including copying all endpoints to a new array.
>
> This CL adds a "GrMiddleOutPolygonTriangulator" class that
> accomplishes the same thing in 1/5th the time using a small O(log N)
> stack.
>
> Change-Id: I3a7059e5d133a730b7084a17d8fbaaa3aaa81336
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285531
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>

TBR=ethannicholas@google.com

Change-Id: I8402e5455e14aef9c5e92ee21100fcd7ace222ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285740
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-04-28 06:09:59 +00:00