Commit Graph

1261 Commits

Author SHA1 Message Date
cdalton
3fc6a2fdb2 Combine similar DrawPaths calls in GrInOrderDrawBuffer
Combines adjacent DrawPaths commands into one single call when a
conservative set of conditions are met. The end result is that whole
paragraphs can be drawn with a single call to
gliStencilThenCoverFillPathInstancedNV(), rather than one call for
each line.

BUG=skia:

Review URL: https://codereview.chromium.org/712223002
2014-11-13 11:54:20 -08:00
egdaniel
90ace96cbb Rebase gm's for first time that were in no-comparion
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/715363006
2014-11-12 12:12:50 -08:00
bungeman
06fc5cf206 Rebaseline for s4-Debug for 6fee786210. 2014-11-12 14:21:28 -05:00
bungeman
d41e5bb1cc Rebaseline for s4-Release for 6fee786210. 2014-11-12 11:58:10 -05:00
bungeman
cb060082c9 Rebaseline for Nexus10 for 6fee786210. 2014-11-12 11:36:14 -05:00
joshualitt
b103d0c64a rebase
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/717033002
2014-11-12 05:44:25 -08:00
reed
f539b8cdee modify nothingToDraw to notice filters
This reverts commit c71ffd4e76.

TBR=

Review URL: https://codereview.chromium.org/683003003
2014-11-11 12:51:33 -08:00
robertphillips
05699e5fe0 Remove multipicturedraw GMs from ignored-tests.txt
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/718763002
2014-11-11 09:42:38 -08:00
joshualitt
3595fc6a92 more gms to ignore
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691143006
2014-11-11 09:28:30 -08:00
joshualitt
4dd9988642 remove separate color from coverage
BUG=skia:

Review URL: https://codereview.chromium.org/699023003
2014-11-11 08:51:30 -08:00
robertphillips
1e4595a050 Rebaseline problem (Galaxy S4) multipicturedraw GMs
This CL rebaselines the buggy multipicturedraw GMs related to:

Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/)

TBR=jcgregorio@google.com

BUG=skia:3116

Review URL: https://codereview.chromium.org/715823002
2014-11-11 08:17:39 -08:00
robertphillips
28246af2ef Rebaseline multipicturedraw GMs
This CL rebaselines the multipicturedraw GMs as a follow up to:

Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/)

TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/714153002
2014-11-11 07:55:45 -08:00
joshualitt
43b46d1f56 rebase from early clip
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/707413003
2014-11-11 07:40:16 -08:00
jvanverth
428b2a5a4f Re-enable no-longer-flaky GMs
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/684413004
2014-11-10 12:12:55 -08:00
jvanverth
ebb4fa3ee3 Update some flaky GMs to see if they stick.
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/713893002
2014-11-10 08:27:31 -08:00
egdaniel
39fa278c40 Rebase verttext once more
TBR=jvanverth@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/717553002
2014-11-10 08:07:37 -08:00
joshualitt
270582f156 rebasing some gms
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/713633002
2014-11-08 07:09:38 -08:00
jvanverth
3c10c0d444 Reignore some tests that use distance fields
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/708173002
2014-11-07 14:57:13 -08:00
egdaniel
25ae66e96f Rebase for win7 x86 gpu
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/708153002
2014-11-07 14:22:57 -08:00
egdaniel
79fc22316c Finish rebase from df and add baseline images for n10 debug
TBR=jvanverth@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/705353003
2014-11-07 13:19:22 -08:00
egdaniel
b48af0e999 Rebaseline s4 gms
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/712693002
2014-11-07 12:56:36 -08:00
jvanverth
0c533a8731 One more attempt at rebaselining
TBR=egdaniel@google.com
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/708903006
2014-11-07 10:17:37 -08:00
jvanverth
044134b969 Missed some expectations
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/705293002
2014-11-07 08:50:16 -08:00
jvanverth
6f1cad4030 Rebaseline for https://codereview.chromium.org/703463002/.
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/709043002
2014-11-07 08:16:49 -08:00
joshualitt
2c93efeb6f Clip in grdrawtarget
NOTREECHECKS=true
BUG=skia:

Review URL: https://codereview.chromium.org/685883003
2014-11-06 12:57:13 -08:00
bsalomon
4d0fb61367 S4 Rebaselines
TBR=

Review URL: https://codereview.chromium.org/706653003
2014-11-05 11:59:25 -08:00
robertphillips
76c4fa6e30 Add new baselines for remaining dashing5 GM images
This are the baselines for the problem children:
The N5 & N10 gpu images related to Issue 3097
The perspective Windows images

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/702143002
2014-11-05 09:00:22 -08:00
egdaniel
036a2bbbcc Remove gm from ignore expectation file
No gm's actually changed from my recent change to dashing gm. This was the desired
outcome since the added calls were lines of length zero

TBR=robertphillips@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/706633002
2014-11-05 08:57:16 -08:00
robertphillips
07f5fffffc Add baselines for the new dashing5 GM
These are all the correct images

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/707513002
2014-11-05 08:25:40 -08:00
egdaniel
21402e3851 Bug fix for cull_line in SkDashPathEffect.
In cull_line we must also check if both points are the same. Otherwise we
fail the assert in the else "SkASSERT(dy && !dx)".

This is currently blocking the roll as it fails a webkit test.

BUG=skia:

Review URL: https://codereview.chromium.org/703783002
2014-11-05 05:02:27 -08:00
bungeman
e32ed6899c Additional baselines for 4b86bacb04.
The Nexus9 lacked a trybot at the time.
2014-11-04 15:28:51 -05:00
bungeman
4b86bacb04 Allow all font weights on Android and respect overrides.
This removes the code which forces 400 and 700 weights only,
and also overrides the font weight with the configured weight.

Review URL: https://codereview.chromium.org/694533006
2014-11-04 10:54:32 -08:00
joshualitt
2f5cb2fb95 update baselines and ignores for texture_domain
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/697233003
2014-11-03 17:47:47 -08:00
jvanverth
ada68ef2dc Improve quality of distance field rendering
- Update spacing of LODs to get better results scaling up to 256
- Remove unnecessary "bolding" from dftext
- Add debug colors for dftext LODs

BUG=skia:2933,skia:2935

Review URL: https://codereview.chromium.org/703463002
2014-11-03 14:00:24 -08:00
joshualitt
50408adfd2 Test factory uses the inorder draw buffer
BUG=skia:

Review URL: https://codereview.chromium.org/696353002
2014-11-03 12:31:15 -08:00
joshualitt
e672e9fca9 rebase and ignore dash cubics winnvpr
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691803005
2014-11-03 12:03:06 -08:00
joshualitt
0b9c015bd9 release expectations rebase
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/700613002
2014-11-03 11:36:40 -08:00
joshualitt
f002af791f rebase nvpr expectations
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/688413004
2014-11-03 11:14:25 -08:00
joshualitt
882ee19a26 ignoring degenerat segments across all nvprm
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/696373002
2014-11-03 10:51:42 -08:00
egdaniel
c5da8b9c8b Rebaselines for new colortype-xfermodes gm
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/695343002
2014-11-03 08:26:29 -08:00
robertphillips
66cad7669b Always enable layer hoisting in Skia
This will prevent bit rot of the layer hoisting code and position us better for turning this on in Chromium.

Review URL: https://codereview.chromium.org/698493002
2014-11-03 07:19:30 -08:00
joshualitt
a39c5374f4 rebaseline
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/696853002
2014-10-31 16:16:56 -07:00
joshualitt
92e496f96a Beginning to refactor nvpr code
BUG=skia:

Review URL: https://codereview.chromium.org/687563008
2014-10-31 13:56:50 -07:00
jvanverth
9154dd4552 Rebaseline GMs for https://codereview.chromium.org/687283002/
BUG=skia:2935

Review URL: https://codereview.chromium.org/684833003
2014-10-31 07:16:54 -07:00
borenet
2000c3de5b Blind GM rebaseline for Galaxy S4
BUG=skia:3032

Review URL: https://codereview.chromium.org/694573002
2014-10-30 13:27:20 -07:00
scroggo
43d5debc84 Add skimage expectations for GalaxyS4.
Fixes build.

Review URL: https://codereview.chromium.org/692913003
2014-10-30 11:44:27 -07:00
jvanverth
b61283f9c7 Support multiple scales for dfpaths.
Adds miplevel as part of dfpath key, and scale factor so we know
how much to adjust to fit desired scale.

BUG=skia:2935

Review URL: https://codereview.chromium.org/687283002
2014-10-30 05:57:21 -07:00
senorblanco
8f3937d9fc Fix bounds computation of all 0-input filters.
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.

BUG=427251

Review URL: https://codereview.chromium.org/681643003
2014-10-29 12:36:32 -07:00
borenet
067c065a66 Rename GalaxyNexus GM and SkImage expectations for GalaxyS4, remove NexusS
GMs will surely need rebaselining.

BUG=skia:3032

Review URL: https://codereview.chromium.org/683853006
2014-10-29 06:21:28 -07:00
joshualitt
7a56931784 one more test updated
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/681373003
2014-10-28 17:23:35 -07:00
joshualitt
584e4fd2b8 rebaselines
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/682123003
2014-10-28 17:07:44 -07:00
joshualitt
ea04d2d0bb more ignores
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/688443002
2014-10-28 13:22:56 -07:00
joshualitt
0e602827df Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2

Committed: https://skia.googlesource.com/skia/+/95f5194abce19e8ed875f3495fd16c79a9b931b4

Review URL: https://codereview.chromium.org/678073005
2014-10-28 10:27:44 -07:00
joshualitt
98102a8f79 Revert of Patch to remove constant attributes (patchset #8 id:120002 of https://codereview.chromium.org/678073005/)
Reason for revert:
I'll checkin tonight when the tree is quieter

Original issue's description:
> Working patch to remove constant attributes.  This may cause some gm mismatches, I will rebaseline tonight.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2
>
> Committed: https://skia.googlesource.com/skia/+/95f5194abce19e8ed875f3495fd16c79a9b931b4

TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/683203002
2014-10-28 09:08:35 -07:00
joshualitt
95f5194abc Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2

Review URL: https://codereview.chromium.org/678073005
2014-10-28 07:54:54 -07:00
hcm
4396fa594e Revert of Use approximate scratch textures for image filters. (patchset #2 id:20001 of https://codereview.chromium.org/679113004/)
Reason for revert:
Continued GM failures

Original issue's description:
> Use approximate scratch textures for image filters.
>
> Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec
>
> Committed: https://skia.googlesource.com/skia/+/50a140563c5960acb2479d2be7c437d146963b3f

TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/681183002
2014-10-27 21:43:30 -07:00
hcm
d0f1969100 Revert of Fix bounds computation of all 0-input filters. (patchset #2 id:20001 of https://codereview.chromium.org/681643003/)
Reason for revert:
try again

Original issue's description:
> Fix bounds computation of all 0-input filters.
>
> The SkRectShaderImageFilter had the same bug as previously fixed for
> SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
> the implementation, this change makes all filters with 0 inputs return
> their source bounds, instead of returning false.
>
> BUG=427251
>
> Committed: https://skia.googlesource.com/skia/+/ba036cc82b5a543a13cafd11a19ba0e3087fca38

TBR=bsalomon@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=427251

Review URL: https://codereview.chromium.org/678273002
2014-10-27 20:55:01 -07:00
hcm
4984d473ab Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests. (patchset #3 id:40001 of https://codereview.chromium.org/685523002/)
Reason for revert:
Getting to revert for failures on image filter tests in Skia and Blink

Original issue's description:
> Rebaseline imagemagnifier and dropshadowimagefilter tests.
>
> BUG=skia:
> TBR=hcm@google.com
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/0fc71ea432d3895ede198a24080f877e607cd264

TBR=senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/678043003
2014-10-27 20:53:25 -07:00
hcm
ac011a5f90 Revert of Re-add suppressions for magnifier and dropshadow GMs. (patchset #1 id:1 of https://codereview.chromium.org/686573002/)
Reason for revert:
Trying to get revert of patchset potentially causing failures on image filter tests

Original issue's description:
> Re-add suppressions for magnifier and dropshadow GMs.
>
> Brian's change has invalidated the new baselines, so they'll need
> to be rebaselined again once his changed has worked its way through.
>
> TBR=bsalomon
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/fa4689d56384da5bb264a480e636fac126fb93ca

TBR=bsalomon@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/679413002
2014-10-27 20:48:57 -07:00
joshualitt
9f2825f249 Revert of Patch to remove constant attributes (patchset #6 id:100001 of https://codereview.chromium.org/678073005/)
Reason for revert:
Breaks the K1

Original issue's description:
> Working patch to remove constant attributes.  This may cause some gm mismatches, I will rebaseline tonight.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2

TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/679363002
2014-10-27 17:56:18 -07:00
joshualitt
84c94c0dfd Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:

Review URL: https://codereview.chromium.org/678073005
2014-10-27 15:33:33 -07:00
senorblanco
fa4689d563 Re-add suppressions for magnifier and dropshadow GMs.
Brian's change has invalidated the new baselines, so they'll need
to be rebaselined again once his changed has worked its way through.

TBR=bsalomon
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/686573002
2014-10-27 14:26:26 -07:00
senorblanco
0fc71ea432 Rebaseline imagemagnifier and dropshadowimagefilter tests.
BUG=skia:
TBR=hcm@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/685523002
2014-10-27 14:12:58 -07:00
bsalomon
50a140563c Use approximate scratch textures for image filters.
Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec

Review URL: https://codereview.chromium.org/679113004
2014-10-27 13:56:20 -07:00
senorblanco
ba036cc82b Fix bounds computation of all 0-input filters.
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.

BUG=427251

Review URL: https://codereview.chromium.org/681643003
2014-10-27 13:38:13 -07:00
jvanverth
d482d297c5 Update perspective GM expectations after disabling some DF paths
BUG=skia:3066
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/680913003
2014-10-27 07:58:30 -07:00
jvanverth
87ab518627 Update GM expectations for https://codereview.chromium.org/677463002/
BUG=skia:2935
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/677123002
2014-10-24 12:53:01 -07:00
jvanverth
00c83ddfcb Ignore simpleaaclip_path on Win7-gpu for now.
BUG=skia:3066
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/646523005
2014-10-24 09:40:43 -07:00
mtklein
da0de7ed90 rebaseline for new shaderproc
BUG=skia:

Review URL: https://codereview.chromium.org/674123003
2014-10-24 08:05:59 -07:00
bsalomon
8dae0f364b Rebaseline lots of images, associate some with bug 3063.
TBR=
NOTRY=true

Review URL: https://codereview.chromium.org/661323003
2014-10-24 07:26:01 -07:00
jvanverth
b3eb687f8a Set temporary paths volatile so we don't cache them.
Any path that is generated frame-to-frame should not be rendered by using the
DistanceFieldPathRenderer, because generating the initial distance field,
uploading it and rendering it takes longer than the SoftwarePathRenderer.

BUG=skia:2935

Review URL: https://codereview.chromium.org/677463002
2014-10-24 07:12:51 -07:00
mtklein
afc9b6ec95 squelch filterindiabox too
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/677463003
2014-10-23 15:24:11 -07:00
senorblanco
cbf6b6ecd5 Fix imagemagnifier GM quality and speed.
The imagemagnifier GM was applying the filter both to a saveLayer()
restore() around the whole scene, as well as to each individual
text draw.

Applying the filter only in the saveLayer() makes it run ~20x faster
on my Linux box, and the quality is improved as well (since the
primitives are not double-filtered).

BUG=skia:

Review URL: https://codereview.chromium.org/637283009
2014-10-23 15:00:12 -07:00
mtklein
14e4d392d4 Revert "Revert of create shaderproc for nofilter-opaque-dx (patchset #7 id:120001 of https://codereview.chromium.org/664783004/)"
This reverts commit 430b795cc8 and adds suppressions.

BUG=skia:

Review URL: https://codereview.chromium.org/673023002
2014-10-23 14:35:01 -07:00
bsalomon
efd7d45fc0 Don't use MIP filter mode on compressed textures
Add compressed texture image downsample GMs

BUG=chromium:426331

Review URL: https://codereview.chromium.org/672863003
2014-10-23 14:17:46 -07:00
senorblanco
c4d619e145 Remove test expectations from ignored-tests.txt.
TBR=mtklein@google.com
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/659393006
2014-10-23 14:01:38 -07:00
sugoi
234f036b3e Adding an option to render only the shadow in SkDropShadowImageFilter
This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here.

BUG=skia:

Review URL: https://codereview.chromium.org/646213004
2014-10-23 13:59:52 -07:00
senorblanco
d0777fd2cf Rebaselines for tests affected by image filter PDF change.
(aka https://codereview.chromium.org/644323006/)

TBR=mtklein@google.com
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/671303003
2014-10-23 13:50:54 -07:00
joshualitt
70649c174b updating k1 expectations
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/642543003
2014-10-23 11:34:08 -07:00
borenet
4f93f3c441 Rename Nexus9 expectations
BUG=skia:3047
TBR=djsollen

Review URL: https://codereview.chromium.org/652003003
2014-10-23 08:08:23 -07:00
joshualitt
99db3b1308 some more expectations, update ignores
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/668393002
2014-10-22 20:23:08 -07:00
joshualitt
4a38fbd7f2 New baselines
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/668823006
2014-10-22 19:47:37 -07:00
joshualitt
9292fafd4a one more test to ignore
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/674713002
2014-10-22 17:52:31 -07:00
joshualitt
5ead6da4ab Oval and stroke AA rect now batch
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d

Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0

Review URL: https://codereview.chromium.org/664193002
2014-10-22 16:00:30 -07:00
joshualitt
67f7f74fb2 Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of https://codereview.chromium.org/664193002/)
Reason for revert:
whoops, accidental commit

Original issue's description:
> Oval and stroke AA rect now batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d
>
> Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0

TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/675623002
2014-10-22 15:51:52 -07:00
joshualitt
18055afb83 Oval and stroke AA rect now batch
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d

Review URL: https://codereview.chromium.org/664193002
2014-10-22 15:48:48 -07:00
mtklein
9deb696f58 Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of https://codereview.chromium.org/664193002/)
Reason for revert:
Many GMs failing, e.g. http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus5-Adreno330-Arm7-Release/builds/95/steps/Compare%20GMs/logs/stdio

Original issue's description:
> Oval and stroke AA rect now batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d

TBR=robertphillips@google.com,joshualitt@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/671993003
2014-10-22 15:23:29 -07:00
joshualitt
bc54fab1a4 Oval and stroke AA rect now batch
BUG=skia:

Review URL: https://codereview.chromium.org/664193002
2014-10-22 14:41:45 -07:00
joshualitt
02b4725cb8 Ignore failure on internal bot
BUG=skia:3023
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/640063004
2014-10-22 07:29:21 -07:00
jvanverth
bf5473b218 Rebaseline dftext GM for new color emoji test.
BUG=skia:3033
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/671513007
2014-10-21 07:39:51 -07:00
senorblanco
b0e89dcc1d Fix image filters for PDF backend.
Currently, the PDF backend does not support image filters (since PDF
does not have that functionality), so it simply removes them. This is
causing Chrome print preview to render incorrectly (see bug). The fix
here is to fall back to a raster device for image filters, as we used
to do in Blink. The resulting bitmap will be drawn to the destination
device as a normal main-memory-backed bitmap.

Note: this change invalidates the PDF results of all GMs containing
image filters (since they'll actually be rendered).

BUG=422144

Review URL: https://codereview.chromium.org/644323006
2014-10-20 14:03:13 -07:00
bungeman
a4c4a2d8cd Replace SkTypeface::Style with SkFontStyle.
Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20

Review URL: https://codereview.chromium.org/488143002
2014-10-20 13:33:19 -07:00
jvanverth
fca302ccf4 Add color emoji fallback for distance field text.
BUG=skia:3033

Review URL: https://codereview.chromium.org/670533002
2014-10-20 13:12:55 -07:00
Florin Malita
4ce01d606d Rebaseline textblob GM
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/654303006
2014-10-16 20:45:49 -04:00
fmalita
19653d1d00 Implicit SkTextBlob bounds
Compute blob bounds when the client doesn't pass explicit run rects to
the builder. This allows us to remove a couple of internal workarounds.

R=reed@google.com,mtklein@google.com,bungeman@google.com

Review URL: https://codereview.chromium.org/654873003
2014-10-16 11:53:30 -07:00
jvanverth
aab626c367 Revert of Change drawText() to generate positions and send to drawPosText() (patchset #4 id:60001 of https://codereview.chromium.org/653133004/)
Reason for revert:
A large number of GMs on Ubuntu12 are failing. The text layout on GPU is visibly different than that for 8888.

Original issue's description:
> Change drawText() to generate positions and send to drawPosText()
>
> The idea here is to have a central place that does layout for drawText(), and
> then always feed text through drawPosText(). This both makes all of the
> GrTextContexts consistent in drawText() output, and does a better job of
> stressing drawPosText().
>
> Because of the effect of matrices on hinting and approximation error, the
> generated text is not 100% identical to that produced by the raster pipeline.
>
> BUG=skia:2778
>
> Committed: https://skia.googlesource.com/skia/+/7851a56895c9c076f73a835a7dd51d3c6180c16f

TBR=cdalton.nvidia@gmail.com,bungeman@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2778

Review URL: https://codereview.chromium.org/659993003
2014-10-16 08:04:39 -07:00
jvanverth
7851a56895 Change drawText() to generate positions and send to drawPosText()
The idea here is to have a central place that does layout for drawText(), and
then always feed text through drawPosText(). This both makes all of the
GrTextContexts consistent in drawText() output, and does a better job of
stressing drawPosText().

Because of the effect of matrices on hinting and approximation error, the
generated text is not 100% identical to that produced by the raster pipeline.

BUG=skia:2778

Review URL: https://codereview.chromium.org/653133004
2014-10-16 06:20:35 -07:00
Brian Salomon
5b9cb06761 Ignore ubuntu nvprmsaa4/mixed_xfermodes GM result.
BUG=skia:2443

Review URL: https://codereview.chromium.org/653153003
2014-10-14 16:12:23 -04:00
Brian Salomon
d5da96a814 Rebaseline mixedxfermodes on ubuntu/nvprmsaa4
TBR=

Review URL: https://codereview.chromium.org/657603005
2014-10-14 15:52:46 -04:00
borenet
5940f952b2 Adjust skimage expectations for Android reference device
BUG=skia:3012

Review URL: https://codereview.chromium.org/650223004
2014-10-14 08:05:59 -07:00
borenet
af44e701a5 Fix links to skia-buildbot code in preparation for deletion
BUG=skia:761

Review URL: https://codereview.chromium.org/655643002
2014-10-14 04:44:44 -07:00
jvanverth
0880686d95 Enable color emoji GM on Android
BUG=skia:2887

Review URL: https://codereview.chromium.org/656433002
2014-10-13 12:48:10 -07:00
jvanverth
75e926a1b1 Update coloremoji expectations
TBR=reed@google.com
BUG=skia:2887

Review URL: https://codereview.chromium.org/649753003
2014-10-10 12:58:46 -07:00
jvanverth
294c32612d Fix color emoji.
Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

Review URL: https://codereview.chromium.org/636183005
2014-10-10 11:36:12 -07:00
jvanverth
e817dbb889 Revert of Fix color emoji. (patchset #11 id:320001 of https://codereview.chromium.org/636183005/)
Reason for revert:
Crashing the Windows bots.

Original issue's description:
> Fix color emoji.
>
> Removes the GrMaskFormat and single atlas in GrTextStrike.
> Replaces it by storing the GrMaskFormat in each GrGlyph, and
> doing a lookup for the correct atlas based on that.
>
> Disables color glyph rendering in GrDistanceFieldTextContext
> for now.
>
> BUG=skia:2887
>
> Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

TBR=robertphillips@google.com,bungeman@google.com,reed@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2887

Review URL: https://codereview.chromium.org/640413004
2014-10-10 08:52:03 -07:00
jvanverth
bc92163ddf Fix color emoji.
Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Review URL: https://codereview.chromium.org/636183005
2014-10-10 08:21:29 -07:00
jvanverth
6cb35fa467 Ignore complexclip_path_aa on Win7-HD2000 for the moment.
TBR=reed@google.com
BUG=skia:3006

Review URL: https://codereview.chromium.org/643103002
2014-10-10 07:14:55 -07:00
joshualitt
d8088f846f updating expectations
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/646963002
2014-10-10 06:48:48 -07:00
jvanverth
e01844540a Update expectations for distance field path rendering.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/641203002
2014-10-09 12:37:36 -07:00
egdaniel
691d6730e0 Rebase Nexus 10 gm failure
TBR=robertphillips@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/638043002
2014-10-08 09:38:30 -07:00
bsalomon
b82b9d577e Make GM default to reseting gpu contexts on android.
TBR=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb

Review URL: https://codereview.chromium.org/635293003
2014-10-08 08:17:11 -07:00
derekf
e6efd39a33 Only use msaa target for blur mask when doAA is true
BUG=skia:2995

Review URL: https://codereview.chromium.org/639523002
2014-10-07 14:44:34 -07:00
jvanverth
d99741cbbe Update perspective GMs for dfpaths
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/632363004
2014-10-07 10:55:43 -07:00
jvanverth
c7c2716a5b Add baselines for dftext GM.
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/638683002
2014-10-07 10:23:34 -07:00
robertphillips
c1188aacd5 Added more msaa blurring rebaselines & a suppression
These are rebaselines for: Create MSAA render target for blur mask texture - https://codereview.chromium.org/616923004

BUG=skia:2995
TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628813003
2014-10-07 05:56:24 -07:00
robertphillips
b1b2085569 Rebaseline multipicturedraw_biglayer_*
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/635813003
2014-10-07 05:08:12 -07:00
robertphillips
40e01c499e Remove suppressions in ignored-tests.txt
This should be safe after: Update suppressed baseline images - https://codereview.chromium.org/605973003/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628013003
2014-10-07 04:52:16 -07:00
bsalomon
4e8955b772 Rebaseline after msaa blur change
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631993002
2014-10-06 13:29:22 -07:00
robertphillips
e71d8841ce Update suppressed baseline images
This updates the non-multipicturedraw GM images suppressed in:
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/605973003
2014-10-06 12:54:15 -07:00
robertphillips
3342d1b5a0 Add suppression for multipicturedraw_biglayer GM
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631973002
2014-10-06 12:27:53 -07:00
robertphillips
0cb34b5ab6 Update baseline GM images
This updates the multipicturedraw_* GM images for:

Reduce overdraw in MultiPictureDraw Sierpinski GM - https://codereview.chromium.org/582633003/
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/632703003
2014-10-06 11:41:04 -07:00
robertphillips
2e5a986bc7 New baselines
New baseline images for multipicturedraw_biglayer* GMs added in (Add a MultiPictureDraw GM to exercise layer clipping - https://codereview.chromium.org/617723004/).

NOTRY=true
TBR=reed@google.com

Review URL: https://codereview.chromium.org/629293002
2014-10-06 10:57:14 -07:00
jvanverth
5d271f1581 Update fontcache expectations
TBR=reed@google.com

Review URL: https://codereview.chromium.org/634623002
2014-10-06 10:47:59 -07:00
jvanverth
fa38a30897 Add GrAASmallPathRenderer.
Uses cached signed distance fields to render scaled and rotated versions
of small paths.

BUG=skia:2935

Review URL: https://codereview.chromium.org/589103004
2014-10-06 05:59:05 -07:00
robertphillips
4611e7f479 Don't turn on dither for saveLayers which have no paint
Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining.

NOTRY=true

Review URL: https://codereview.chromium.org/619363002
2014-10-03 06:53:04 -07:00
fmalita
08bd03bc17 Add blobshader GM baselines.
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/616853003
2014-10-02 05:00:29 -07:00
reed
5817f21e0b remove suppression for gm
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/617193003
2014-10-01 12:53:53 -07:00
reed
8324a6a27e add baseline for clip_strokerect
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/618373002
2014-10-01 12:41:13 -07:00
reed
39f31c6ed0 baseline new GMs
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/623443004
2014-10-01 12:18:40 -07:00
robertphillips
6589dec11e Rebaseline Unknown-Arm64 GM flakes
These inconsequential changes appeared after (GrResourceCache2 manages scratch texture - https://codereview.chromium.org/608883003) but persisted even after that CL was reverted.

TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/617103005
2014-10-01 09:47:11 -07:00
fmalita
dbcb5ff125 Add pdf-native textblobshader GM baseline
BUG=skia:2983
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/615853004
2014-10-01 09:19:05 -07:00
robertphillips
92656eaaa8 Add buggy GPU baselines for MultiPictureDraw Sierpinski GM (with bug label)
I am checking in these baseline images even though they are afflicted by a bug (skia:2979).

NOTRY=true
NOTREECHECKS=true
BUG=skia:2979
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/619873003
2014-10-01 08:04:29 -07:00
Justin Novosad
e946f7115c New baselines for image=surface gm
TBR=robertphillips@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/623473002
2014-10-01 10:29:16 -04:00
robertphillips
24e430ff32 Add 8888 & 565 baselines for multipicturedraw Sierpinski GM
TBR=jvanverth@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/614353002
2014-10-01 05:33:25 -07:00
robertphillips
dbe6074a06 Revert of GrResourceCache2 manages scratch texture. (patchset #14 id:260001 of https://codereview.chromium.org/608883003/)
Reason for revert:
Turning bots red:
Nanobench seems to be uniformly failing on Android
(http://108.170.220.21:10117/builders/Perf-Android-Venue8-PowerVR-x86-Release/builds/99/steps/RunNanobench/logs/stdio)

Ubuntu GTX660 32bit is failing in both Debug and Release on GM generation (it appears to be out of memory) (http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/builds/2457/steps/GenerateGMs/logs/stdio)

Original issue's description:
> GrResourceCache2 manages scratch texture.
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3d398c876440deaab39bbf2a9b881c337e6dc8d4

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/611383003
2014-09-30 06:54:17 -07:00
bsalomon
3d398c8764 GrResourceCache2 manages scratch texture.
BUG=skia:
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/608883003
2014-09-30 06:02:23 -07:00
robertphillips
92f7fc4868 Rebaselining Win7 image failures (textblob, verttext2)
Rebaselining these for now and see if they recur.

R=borenet@google.com
TBR=borenet@google.com

BUG=skia:2956

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/600533003
2014-09-29 11:17:58 -07:00
Justin Novosad
cce6bbf494 Adding test suppression for image-surface GM
Test needs to be rebaselined on gpu

TBR=bsalomon

Review URL: https://codereview.chromium.org/602203006
2014-09-26 17:41:28 -04:00
cdalton
9959c21dc7 Rebaseline gm expectations after nvpr text change
BUG=skia:2951
BUG=skia:2954
R=bsalomon@google.com, borenet@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/580943003
2014-09-22 12:26:41 -07:00
jvanverth
f782639a7c Add ignored expectation for https://codereview.chromium.org/563283004.
BUG=skia:2951
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/585943002
2014-09-19 06:46:09 -07:00
cdalton
855d83ff79 Uses a single pre-baked set of paths for drawing nvpr text of a given
typeface. Loads the paths using the driver's glyph loading routines.

Refactors GrPathRange to accept a PathGenerator class that it uses to
lazily initialize its paths. The client code is no longer expected to
initialize the paths in a GrPathRange; instead it must provide a
PathGenerator* instance to createPathRange().

Adds a new createGlyphs() method to GrPathRendering that creates a
range of glyph paths, indexed by glyph id. GrPathRendering implements
createGlyphs() with a PathGenerator that loads glyph paths using the
skia frameworks. GrGLPathRendering uses glMemoryGlyphIndexArrayNV()
instead, when possible, to load the glyph paths.

Removes all GlyphPathRange logic from GrStencilAndCoverTextContext.
It instead uses createGlyphs().

BUG=skia:2939
R=bsalomon@google.com, jvanverth@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/563283004
2014-09-18 13:51:53 -07:00
Florin Malita
8bb9e1e412 Rebaseline textblob GM after acb882c
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/575893003
2014-09-17 10:21:48 -04:00
fmalita
acb882c239 Ensure blob typeface information survives SkGPipe serialization.
When flattening text blobs to the temp buffer, we need to collect
typeface info and ship it across the pipe explicitly.

R=mtklein@google.com, reed@google.com, robertphillips@google.com, bungeman@google.com
BUG=412445

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/563783003
2014-09-16 17:58:34 -07:00
Mike Klein
a63d5df455 Rebaseline hittestpath and ignore flaky failure on TARUAD
BUG=skia:2937

Review URL: https://codereview.chromium.org/571963002
2014-09-15 10:56:59 -04:00
rileya
abaef86f2b Add support for the Rec601 YUV color space to GrYUVtoRGBEffect.
R=bsalomon@google.com, senorblanco@chromium.org, sugoi@chromium.org, reed@google.com

Author: rileya@chromium.org

Review URL: https://codereview.chromium.org/516463005
2014-09-12 17:45:58 -07:00
Mike Klein
d0af38793e Expectation file update for bot changes.
BUG=skia:

Review URL: https://codereview.chromium.org/560873002
2014-09-10 11:10:48 -04:00
reed
9728a2bf56 correct prev suppression
TBR=
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/543903005
2014-09-09 19:22:37 -07:00
reed
9a6300a2b0 suppress multipicturedraw_pathclip_tiled_nvprmsaa4 after the conservative-rasterclip cl
TBR=
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/555403002
2014-09-09 19:08:28 -07:00
bungeman
87a79236f5 Rebaselines for 6bc2c94de3 (fontmgr_iter).
Rebaselines for "Add font fallback support to SkFontMgr_fontconfig."
2014-09-09 21:38:04 -04:00
Mike Klein
be20c5a118 rebase a couple oddballs
BUG=skia:

Review URL: https://codereview.chromium.org/555193004
2014-09-09 17:52:40 -04:00